@nathapp/nax 0.28.0 → 0.29.0

package/test/unit/execution/pid-registry.test.ts

@@ -1,241 +0,0 @@
-// RE-ARCH: keep
-/**
- * PID Registry Tests
- */
-
-import { afterEach, beforeEach, describe, expect, test } from "bun:test";
-import { existsSync, mkdirSync, rmSync } from "node:fs";
-import { PidRegistry } from "../../../src/execution/pid-registry";
-
-const TEST_WORKDIR = "/tmp/nax-pid-registry-test";
-const PID_FILE = `${TEST_WORKDIR}/.nax-pids`;
-
-describe("PidRegistry", () => {
-  beforeEach(() => {
-    // Create test workdir
-    if (!existsSync(TEST_WORKDIR)) {
-      mkdirSync(TEST_WORKDIR, { recursive: true });
-    }
-
-    // Clean up any existing .nax-pids file
-    if (existsSync(PID_FILE)) {
-      rmSync(PID_FILE);
-    }
-  });
-
-  afterEach(() => {
-    // Cleanup test workdir
-    if (existsSync(TEST_WORKDIR)) {
-      rmSync(TEST_WORKDIR, { recursive: true });
-    }
-  });
-
-  test("register() adds PID to in-memory set and writes to file", async () => {
-    const registry = new PidRegistry(TEST_WORKDIR);
-
-    await registry.register(12345);
-
-    // Check in-memory state
-    expect(registry.getPids()).toEqual([12345]);
-
-    // Check file content
-    const content = await Bun.file(PID_FILE).text();
-    const lines = content.split("\n").filter((line) => line.trim());
-    expect(lines.length).toBe(1);
-
-    const entry = JSON.parse(lines[0]);
-    expect(entry.pid).toBe(12345);
-    expect(entry.workdir).toBe(TEST_WORKDIR);
-    expect(entry.spawnedAt).toBeDefined();
-  });
-
-  test("register() appends multiple PIDs to file", async () => {
-    const registry = new PidRegistry(TEST_WORKDIR);
-
-    await registry.register(12345);
-    await registry.register(67890);
-
-    // Check in-memory state
-    expect(registry.getPids()).toEqual([12345, 67890]);
-
-    // Check file content
-    const content = await Bun.file(PID_FILE).text();
-    const lines = content.split("\n").filter((line) => line.trim());
-    expect(lines.length).toBe(2);
-
-    const entry1 = JSON.parse(lines[0]);
-    expect(entry1.pid).toBe(12345);
-
-    const entry2 = JSON.parse(lines[1]);
-    expect(entry2.pid).toBe(67890);
-  });
-
-  test("unregister() removes PID from in-memory set and rewrites file", async () => {
-    const registry = new PidRegistry(TEST_WORKDIR);
-
-    await registry.register(12345);
-    await registry.register(67890);
-    await registry.unregister(12345);
-
-    // Check in-memory state
-    expect(registry.getPids()).toEqual([67890]);
-
-    // Check file content
-    const content = await Bun.file(PID_FILE).text();
-    const lines = content.split("\n").filter((line) => line.trim());
-    expect(lines.length).toBe(1);
-
-    const entry = JSON.parse(lines[0]);
-    expect(entry.pid).toBe(67890);
-  });
-
-  test("unregister() clears file when last PID is removed", async () => {
-    const registry = new PidRegistry(TEST_WORKDIR);
-
-    await registry.register(12345);
-    await registry.unregister(12345);
-
-    // Check in-memory state
-    expect(registry.getPids()).toEqual([]);
-
-    // Check file is empty
-    const content = await Bun.file(PID_FILE).text();
-    expect(content.trim()).toBe("");
-  });
-
-  test("killAll() clears in-memory PIDs and registry file", async () => {
-    const registry = new PidRegistry(TEST_WORKDIR);
-
-    // Register non-existent PIDs (will fail to kill but should clear registry)
-    await registry.register(99999);
-    await registry.register(88888);
-
-    await registry.killAll();
-
-    // Check in-memory state
-    expect(registry.getPids()).toEqual([]);
-
-    // Check file is empty
-    const content = await Bun.file(PID_FILE).text();
-    expect(content.trim()).toBe("");
-  });
-
-  test("killAll() handles empty registry gracefully", async () => {
-    const registry = new PidRegistry(TEST_WORKDIR);
-
-    // Should not throw
-    await registry.killAll();
-
-    expect(registry.getPids()).toEqual([]);
-  });
-
-  test("cleanupStale() reads and kills PIDs from previous run", async () => {
-    // Simulate a previous run that left PIDs in the file
-    const entry1 = JSON.stringify({
-      pid: 99999, // Non-existent PID
-      spawnedAt: new Date().toISOString(),
-      workdir: TEST_WORKDIR,
-    });
-    const entry2 = JSON.stringify({
-      pid: 88888, // Non-existent PID
-      spawnedAt: new Date().toISOString(),
-      workdir: TEST_WORKDIR,
-    });
-    await Bun.write(PID_FILE, `${entry1}\n${entry2}\n`);
-
-    // Create new registry and cleanup stale PIDs
-    const registry = new PidRegistry(TEST_WORKDIR);
-    await registry.cleanupStale();
-
-    // Check file is cleared
-    const content = await Bun.file(PID_FILE).text();
-    expect(content.trim()).toBe("");
-  });
-
-  test("cleanupStale() handles missing .nax-pids file", async () => {
-    const registry = new PidRegistry(TEST_WORKDIR);
-
-    // Should not throw
-    await registry.cleanupStale();
-
-    // File should not exist
-    expect(existsSync(PID_FILE)).toBe(false);
-  });
-
-  test("cleanupStale() handles empty .nax-pids file", async () => {
-    // Create empty file
-    await Bun.write(PID_FILE, "");
-
-    const registry = new PidRegistry(TEST_WORKDIR);
-    await registry.cleanupStale();
-
-    // File should be empty
-    const content = await Bun.file(PID_FILE).text();
-    expect(content.trim()).toBe("");
-  });
-
-  test("cleanupStale() handles malformed JSON lines gracefully", async () => {
-    // Write malformed JSON
-    await Bun.write(PID_FILE, 'not valid json\n{"pid":12345}\n');
-
-    const registry = new PidRegistry(TEST_WORKDIR);
-
-    // Should not throw
-    await registry.cleanupStale();
-
-    // File should be cleared
-    const content = await Bun.file(PID_FILE).text();
-    expect(content.trim()).toBe("");
-  });
-
-  test("platform-specific kill command: Linux uses process groups", async () => {
-    const registry = new PidRegistry(TEST_WORKDIR, "linux");
-
-    // Register a non-existent PID
-    await registry.register(99999);
-
-    // Should not throw (process doesn't exist, but kill command should be correct)
-    await registry.killAll();
-
-    expect(registry.getPids()).toEqual([]);
-  });
-
-  test("platform-specific kill command: macOS uses direct PID", async () => {
-    const registry = new PidRegistry(TEST_WORKDIR, "darwin");
-
-    // Register a non-existent PID
-    await registry.register(99999);
-
-    // Should not throw (process doesn't exist, but kill command should be correct)
-    await registry.killAll();
-
-    expect(registry.getPids()).toEqual([]);
-  });
-
-  test("multiple registries can coexist with different workdirs", async () => {
-    const workdir1 = `${TEST_WORKDIR}/workspace1`;
-    const workdir2 = `${TEST_WORKDIR}/workspace2`;
-
-    mkdirSync(workdir1, { recursive: true });
-    mkdirSync(workdir2, { recursive: true });
-
-    const registry1 = new PidRegistry(workdir1);
-    const registry2 = new PidRegistry(workdir2);
-
-    await registry1.register(11111);
-    await registry2.register(22222);
-
-    expect(registry1.getPids()).toEqual([11111]);
-    expect(registry2.getPids()).toEqual([22222]);
-
-    // Check separate files
-    const content1 = await Bun.file(`${workdir1}/.nax-pids`).text();
-    const content2 = await Bun.file(`${workdir2}/.nax-pids`).text();
-
-    const entry1 = JSON.parse(content1.trim());
-    const entry2 = JSON.parse(content2.trim());
-
-    expect(entry1.pid).toBe(11111);
-    expect(entry2.pid).toBe(22222);
-  });
-});

package/test/unit/execution/sequential-executor.test.ts

@@ -1,235 +0,0 @@
-/**
- * Unit tests for cost trigger wiring in sequential-executor.ts (TC-001)
- *
- * Covers: checkCostExceeded abort/skip/continue, checkCostWarning at 80%/100%
- * threshold, and isTriggerEnabled guard (no interaction plugin = today behavior).
- */
-
-import { afterEach, describe, expect, mock, test } from "bun:test";
-import type { NaxConfig } from "../../../src/config";
-import { InteractionChain } from "../../../src/interaction/chain";
-import type { InteractionPlugin, InteractionResponse } from "../../../src/interaction/types";
-import { checkCostExceeded, checkCostWarning, checkPreMerge, isTriggerEnabled } from "../../../src/interaction/triggers";
-
-// ─────────────────────────────────────────────────────────────────────────────
-// Helpers
-// ─────────────────────────────────────────────────────────────────────────────
-
-function makeChain(action: InteractionResponse["action"]): InteractionChain {
-  const chain = new InteractionChain({ defaultTimeout: 5000, defaultFallback: "escalate" });
-  const plugin: InteractionPlugin = {
-    name: "test",
-    send: mock(async () => {}),
-    receive: mock(async (id: string): Promise<InteractionResponse> => ({
-      requestId: id,
-      action,
-      respondedBy: "user",
-      respondedAt: Date.now(),
-    })),
-  };
-  chain.register(plugin);
-  return chain;
-}
-
-function makeConfig(triggers: Record<string, unknown>): NaxConfig {
-  return {
-    interaction: {
-      plugin: "cli",
-      defaults: { timeout: 30000, fallback: "escalate" as const },
-      triggers,
-    },
-  } as unknown as NaxConfig;
-}
-
-afterEach(() => {
-  mock.restore();
-});
-
-// ─────────────────────────────────────────────────────────────────────────────
-// isTriggerEnabled — no interaction plugin = today behavior
-// ─────────────────────────────────────────────────────────────────────────────
-
-describe("isTriggerEnabled — no interaction plugin configured", () => {
-  test("returns false when cost-exceeded is not in triggers", () => {
-    const config = makeConfig({});
-    expect(isTriggerEnabled("cost-exceeded", config)).toBe(false);
-  });
-
-  test("returns false when cost-warning is not in triggers", () => {
-    const config = makeConfig({});
-    expect(isTriggerEnabled("cost-warning", config)).toBe(false);
-  });
-
-  test("returns false when trigger explicitly disabled", () => {
-    const config = makeConfig({ "cost-exceeded": { enabled: false } });
-    expect(isTriggerEnabled("cost-exceeded", config)).toBe(false);
-  });
-
-  test("returns true when trigger is boolean true", () => {
-    const config = makeConfig({ "cost-warning": true });
-    expect(isTriggerEnabled("cost-warning", config)).toBe(true);
-  });
-
-  test("returns true when trigger is enabled:true object", () => {
-    const config = makeConfig({ "cost-exceeded": { enabled: true } });
-    expect(isTriggerEnabled("cost-exceeded", config)).toBe(true);
-  });
-});
-
-// ─────────────────────────────────────────────────────────────────────────────
-// checkCostExceeded — 100% threshold responses
-// ─────────────────────────────────────────────────────────────────────────────
-
-describe("checkCostExceeded — abort response exits with cost-limit", () => {
-  const context = { featureName: "feature-x", cost: 1.0, limit: 1.0 };
-
-  test("returns false when trigger responds abort", async () => {
-    const config = makeConfig({ "cost-exceeded": { enabled: true } });
-    const chain = makeChain("abort");
-    const result = await checkCostExceeded(context, config, chain);
-    expect(result).toBe(false);
-  });
-
-  test("returns true (proceed past limit) when trigger responds skip", async () => {
-    const config = makeConfig({ "cost-exceeded": { enabled: true } });
-    const chain = makeChain("skip");
-    const result = await checkCostExceeded(context, config, chain);
-    expect(result).toBe(true);
-  });
-
-  test("returns true (proceed past limit) when trigger responds approve/continue", async () => {
-    const config = makeConfig({ "cost-exceeded": { enabled: true } });
-    const chain = makeChain("approve");
-    const result = await checkCostExceeded(context, config, chain);
-    expect(result).toBe(true);
-  });
-
-  test("returns true without prompting when trigger is disabled (today behavior preserved)", async () => {
-    const config = makeConfig({});
-    const chain = makeChain("abort");
-    const result = await checkCostExceeded(context, config, chain);
-    // Trigger disabled: checkCostExceeded returns true (caller decides to exit)
-    expect(result).toBe(true);
-  });
-});
-
-// ─────────────────────────────────────────────────────────────────────────────
-// checkCostWarning — 80% threshold
-// ─────────────────────────────────────────────────────────────────────────────
-
-describe("checkCostWarning — 80% threshold", () => {
-  const context = { featureName: "feature-x", cost: 0.8, limit: 1.0 };
-
-  test("returns 'escalate' when trigger responds approve", async () => {
-    const config = makeConfig({ "cost-warning": { enabled: true } });
-    const chain = makeChain("approve");
-    const result = await checkCostWarning(context, config, chain);
-    expect(result).toBe("escalate");
-  });
-
-  test("returns 'continue' when trigger responds skip", async () => {
-    const config = makeConfig({ "cost-warning": { enabled: true } });
-    const chain = makeChain("skip");
-    const result = await checkCostWarning(context, config, chain);
-    expect(result).toBe("continue");
-  });
-
-  test("returns 'continue' when trigger responds abort", async () => {
-    const config = makeConfig({ "cost-warning": { enabled: true } });
-    const chain = makeChain("abort");
-    const result = await checkCostWarning(context, config, chain);
-    expect(result).toBe("continue");
-  });
-
-  test("returns 'continue' without prompting when trigger is disabled", async () => {
-    const config = makeConfig({});
-    const chain = makeChain("approve");
-    const result = await checkCostWarning(context, config, chain);
-    expect(result).toBe("continue");
-  });
-});
-
-// ─────────────────────────────────────────────────────────────────────────────
-// Threshold guard logic (mirrors executor warningSent guard)
-// ─────────────────────────────────────────────────────────────────────────────
-
-describe("cost-warning threshold guard logic", () => {
-  function shouldFireWarning(
-    totalCost: number,
-    costLimit: number,
-    triggerCfg: boolean | { enabled: boolean; threshold?: number } | undefined,
-    warningSent: boolean,
-  ): boolean {
-    if (warningSent) return false;
-    const threshold = typeof triggerCfg === "object" ? (triggerCfg.threshold ?? 0.8) : 0.8;
-    return totalCost >= costLimit * threshold;
-  }
-
-  test("does not fire when cost is below 80% of limit", () => {
-    expect(shouldFireWarning(7.9, 10, { enabled: true }, false)).toBe(false);
-  });
-
-  test("fires when cost is exactly at 80% of limit", () => {
-    expect(shouldFireWarning(8.0, 10, { enabled: true }, false)).toBe(true);
-  });
-
-  test("fires when cost is between 80% and 100% of limit", () => {
-    expect(shouldFireWarning(9.5, 10, { enabled: true }, false)).toBe(true);
-  });
-
-  test("fires when cost is at 100% of limit", () => {
-    expect(shouldFireWarning(10.0, 10, { enabled: true }, false)).toBe(true);
-  });
-
-  test("does not fire a second time if warningSent is true", () => {
-    expect(shouldFireWarning(9.0, 10, { enabled: true }, true)).toBe(false);
-  });
-
-  test("uses custom threshold when provided in trigger config", () => {
-    // threshold: 0.9 means fires at 90% not 80%
-    expect(shouldFireWarning(8.5, 10, { enabled: true, threshold: 0.9 }, false)).toBe(false);
-    expect(shouldFireWarning(9.0, 10, { enabled: true, threshold: 0.9 }, false)).toBe(true);
-  });
-
-  test("defaults to 0.8 when trigger config is a boolean", () => {
-    expect(shouldFireWarning(7.9, 10, true, false)).toBe(false);
-    expect(shouldFireWarning(8.0, 10, true, false)).toBe(true);
-  });
-});
-
-// ─────────────────────────────────────────────────────────────────────────────
-// checkPreMerge — pre-merge trigger before run:completed
-// ─────────────────────────────────────────────────────────────────────────────
-
-describe("checkPreMerge — approve/abort responses", () => {
-  const context = { featureName: "feature-x", totalStories: 3, cost: 0.5 };
-
-  test("returns false when trigger responds abort", async () => {
-    const config = makeConfig({ "pre-merge": { enabled: true } });
-    const chain = makeChain("abort");
-    const result = await checkPreMerge(context, config, chain);
-    expect(result).toBe(false);
-  });
-
-  test("returns true when trigger responds approve", async () => {
-    const config = makeConfig({ "pre-merge": { enabled: true } });
-    const chain = makeChain("approve");
-    const result = await checkPreMerge(context, config, chain);
-    expect(result).toBe(true);
-  });
-
-  test("returns false when trigger responds skip (non-approve = abort run)", async () => {
-    const config = makeConfig({ "pre-merge": { enabled: true } });
-    const chain = makeChain("skip");
-    const result = await checkPreMerge(context, config, chain);
-    expect(result).toBe(false);
-  });
-
-  test("returns true without prompting when trigger is disabled", async () => {
-    const config = makeConfig({});
-    const chain = makeChain("abort");
-    const result = await checkPreMerge(context, config, chain);
-    // Trigger disabled: checkPreMerge returns true (proceed normally)
-    expect(result).toBe(true);
-  });
-});

package/test/unit/execution/sfc-004-dead-code-cleanup.test.ts

@@ -1,89 +0,0 @@
-/**
- * SFC-004: Clean up dead code — Acceptance Criteria Verification
- *
- * Verifies that:
- * 1. No references to --status-file CLI option in codebase
- * 2. No references to .nax-status.json in codebase
- * 3. RunOptions.statusFile is required (not optional)
- * 4. All existing tests pass
- */
-
-import { describe, expect, test } from "bun:test";
-import type { RunOptions } from "../../../src/execution/runner";
-import { DEFAULT_CONFIG } from "../../../src/config";
-
-describe("SFC-004: Dead code cleanup — Acceptance Criteria", () => {
-  test("AC-1: RunOptions.statusFile is required (not optional)", () => {
-    // Verify that statusFile is a required field by creating a valid RunOptions object
-    const validRunOptions: RunOptions = {
-      prdPath: "/tmp/prd.json",
-      workdir: "/tmp",
-      config: DEFAULT_CONFIG,
-      hooks: { hooks: {} },
-      feature: "test-feature",
-      dryRun: false,
-      statusFile: "/tmp/nax/status.json", // Required field
-    };
-
-    expect(validRunOptions.statusFile).toBe("/tmp/nax/status.json");
-    expect(typeof validRunOptions.statusFile).toBe("string");
-  });
-
-  test("AC-2: CLI auto-computes statusFile to <workdir>/nax/status.json", () => {
-    // This is verified in bin/nax.ts line 334:
-    // const statusFilePath = join(workdir, "nax", "status.json");
-    // And passed to run() on line 357
-
-    const workdir = "/home/user/project";
-    const expectedStatusFile = `${workdir}/nax/status.json`;
-
-    // Simulate what bin/nax.ts does
-    const statusFilePath = `${workdir}/nax/status.json`;
-    expect(statusFilePath).toBe(expectedStatusFile);
-  });
-
-  test("AC-3: No .nax-status.json (old pattern) in codebase", () => {
-    // The old pattern was .nax-status.json
-    // The new pattern is nax/status.json (auto-computed in CLI)
-    // This test documents the change
-
-    const oldPattern = ".nax-status.json";
-    const newPattern = "nax/status.json";
-
-    // The new pattern should be used
-    expect(newPattern).toBe("nax/status.json");
-    expect(oldPattern).not.toBe(newPattern);
-  });
-
-  test("AC-4: statusFile path structure matches <workdir>/nax/status.json", () => {
-    // Verify that the status file is stored at the correct location
-    const workdir = "/Users/username/project";
-    const naxDir = `${workdir}/nax`;
-    const statusFile = `${naxDir}/status.json`;
-
-    expect(statusFile).toBe("/Users/username/project/nax/status.json");
-    expect(statusFile).toContain("/nax/status.json");
-  });
-
-  test("AC-5: RunOptions requires statusFile parameter in all run() calls", () => {
-    // This verifies that statusFile must be passed to run()
-    // Type checking ensures all call sites pass it
-
-    interface RunOptionsWithStatusFile extends RunOptions {
-      statusFile: string; // Always required
-    }
-
-    const opts: RunOptionsWithStatusFile = {
-      prdPath: "/tmp/prd.json",
-      workdir: "/tmp",
-      config: DEFAULT_CONFIG,
-      hooks: { hooks: {} },
-      feature: "test",
-      dryRun: false,
-      statusFile: "/tmp/nax/status.json",
-    };
-
-    expect(opts.statusFile).toBeDefined();
-    expect(typeof opts.statusFile).toBe("string");
-  });
-});