@nanobpm/nano-workforce 0.35.2 → 0.37.0

package/workers/retro-record/worker.test.ts

@@ -1,35 +1,28 @@
-import { assertEquals } from "jsr:@std/assert@1";
+import { test } from "node:test";
+import { assertEquals } from "#test-assert";
 import handler from "./worker.ts";
 
 function fakeApp() {
-  // deno-lint-ignore no-explicit-any
   const stores: Record<string, any[]> = { plan_retros: [] };
   const seq: Record<string, number> = {};
   function tbl(name: string, pk = "id") {
-    // deno-lint-ignore no-explicit-any
     const rows = (stores[name] ??= [] as any[]);
-    // deno-lint-ignore no-explicit-any
     const match = (r: any, where: any) => Object.entries(where).every(([k, v]) => r[k] === v);
     return {
-      // deno-lint-ignore no-explicit-any require-await
       async insert(row: any) {
         const id = (seq[name] = (seq[name] ?? 0) + 1);
         rows.push(pk === "id" ? { id, ...row } : { ...row });
         return pk === "id" ? id : row[pk];
       },
-      // deno-lint-ignore no-explicit-any require-await
       async find(where: any = {}) {
         return rows.filter((r) => match(r, where));
       },
-      // deno-lint-ignore no-explicit-any require-await
       async findOne(where: any = {}) {
         return rows.find((r) => match(r, where));
       },
-      // deno-lint-ignore no-explicit-any require-await
       async get(id: any) {
         return rows.find((row) => row[pk] === id);
       },
-      // deno-lint-ignore no-explicit-any require-await
       async update(id: any, patch: any) {
         const r = rows.find((row) => row[pk] === id);
         if (r) Object.assign(r, patch);
@@ -40,10 +33,9 @@ function fakeApp() {
   return { app, stores };
 }
 
-Deno.test("retro-record: persists a filed retro from hoisted result vars", async () => {
+test("retro-record: persists a filed retro from hoisted result vars", async () => {
   const { app, stores } = fakeApp();
   await handler(
-    // deno-lint-ignore no-explicit-any
     {
       variables: {
         planKey: "o/r#5",
@@ -54,7 +46,6 @@ Deno.test("retro-record: persists a filed retro from hoisted result vars", async
         "io.nanobpm.agentResult": { output: "the full report" },
       },
     } as any,
-    // deno-lint-ignore no-explicit-any
     app as any,
   );
 
@@ -67,59 +58,49 @@ Deno.test("retro-record: persists a filed retro from hoisted result vars", async
   assertEquals(row.report, "the full report");
 });
 
-Deno.test("retro-record: defaults to skipped when the agent filed no PR", async () => {
+test("retro-record: defaults to skipped when the agent filed no PR", async () => {
   const { app, stores } = fakeApp();
   await handler(
-    // deno-lint-ignore no-explicit-any
     { variables: { planKey: "o/r#6", summary: "nothing durable" } } as any,
-    // deno-lint-ignore no-explicit-any
     app as any,
   );
   assertEquals(stores.plan_retros[0].status, "skipped");
   assertEquals(stores.plan_retros[0].pr_key, null);
 });
 
-Deno.test("retro-record: honours an explicit blocked status", async () => {
+test("retro-record: honours an explicit blocked status", async () => {
   const { app, stores } = fakeApp();
   await handler(
-    // deno-lint-ignore no-explicit-any
     { variables: { planKey: "o/r#7", status: "blocked", summary: "no write access" } } as any,
-    // deno-lint-ignore no-explicit-any
     app as any,
   );
   assertEquals(stores.plan_retros[0].status, "blocked");
 });
 
-Deno.test("retro-record: ignores a PR unless the status is filed", async () => {
+test("retro-record: ignores a PR unless the status is filed", async () => {
   const { app, stores } = fakeApp();
   await handler(
-    // deno-lint-ignore no-explicit-any
     { variables: { planKey: "o/r#8", status: "skipped", pr: "o/r#43", summary: "not durable" } } as any,
-    // deno-lint-ignore no-explicit-any
     app as any,
   );
   assertEquals(stores.plan_retros[0].status, "skipped");
   assertEquals(stores.plan_retros[0].pr_key, null);
 });
 
-Deno.test("retro-record: defaults invalid status from PR presence", async () => {
+test("retro-record: defaults invalid status from PR presence", async () => {
   const { app, stores } = fakeApp();
   await handler(
-    // deno-lint-ignore no-explicit-any
     { variables: { planKey: "o/r#9", status: "done", pr: "o/r#44" } } as any,
-    // deno-lint-ignore no-explicit-any
     app as any,
   );
   assertEquals(stores.plan_retros[0].status, "filed");
   assertEquals(stores.plan_retros[0].pr_key, "o/r#44");
 });
 
-Deno.test("retro-record: coerces filed without a PR to skipped", async () => {
+test("retro-record: coerces filed without a PR to skipped", async () => {
   const { app, stores } = fakeApp();
   await handler(
-    // deno-lint-ignore no-explicit-any
     { variables: { planKey: "o/r#10", status: "filed", summary: "forgot the PR" } } as any,
-    // deno-lint-ignore no-explicit-any
     app as any,
   );
   assertEquals(stores.plan_retros[0].status, "skipped");

package/workers/retro-record/worker.ts

@@ -10,7 +10,6 @@ import type { AppJobHandler } from "@nanobpm/urban";
 import { recordRetro } from "../../app/retro.ts";
 
 const AGENT_RESULT_KEY = "io.nanobpm.agentResult";
-const VALID_STATUSES = new Set(["filed", "skipped", "blocked"]);
 
 interface In extends Record<string, unknown> {
   planKey: string;
@@ -26,9 +25,9 @@ function asStr(v: unknown): string | null {
 
 function asStatus(v: unknown, hasPr: boolean): "filed" | "skipped" | "blocked" {
   const s = asStr(v);
-  if (s && VALID_STATUSES.has(s)) {
+  if (s === "filed" || s === "skipped" || s === "blocked") {
     if (s === "filed" && !hasPr) return "skipped";
-    return s as "filed" | "skipped" | "blocked";
+    return s;
   }
   return hasPr ? "filed" : "skipped";
 }
@@ -42,6 +41,7 @@ const handler: AppJobHandler<In> = async (job, app) => {
   const prKey = status === "filed" ? rawPrKey : null;
   const summary = asStr(job.variables.summary);
 
+  // biome-ignore lint/plugin: runtime/framework contract boundary for external data shape
   const env = job.variables[AGENT_RESULT_KEY] as { output?: unknown } | undefined;
   const report = typeof env?.output === "string" ? env.output : null;
 

package/workers/select-wave/worker.test.ts

@@ -3,7 +3,8 @@
 // A predecessor parked behind a merge lane is not a failed slice: dependents must remain pending
 // so a later retry can dispatch them once the lane clears. Real non-open failures still cascade
 // to `skipped` as before.
-import { assertEquals } from "jsr:@std/assert@1";
+import { test } from "node:test";
+import { assertEquals } from "#test-assert";
 import handler from "./worker.ts";
 import type { PlanTaskStatus } from "../../app/plan.ts";
 
@@ -30,7 +31,6 @@ function fakeApp(rows: Row[], deps: DepRow[]) {
       table(name: string, key: string) {
         const store = name === "plan_tasks" ? rows : deps;
         return {
-          // deno-lint-ignore no-explicit-any
           find: (q: any) =>
             Promise.resolve(
               store.filter((r) =>
@@ -39,7 +39,6 @@ function fakeApp(rows: Row[], deps: DepRow[]) {
                 )
               ),
             ),
-          // deno-lint-ignore no-explicit-any
           update: (k: any, patch: any) => {
             const row = store.find((r) =>
               ((r as unknown) as Record<string, unknown>)[key] === k
@@ -50,20 +49,18 @@ function fakeApp(rows: Row[], deps: DepRow[]) {
         };
       },
     },
-    // deno-lint-ignore no-explicit-any
   } as any;
 }
 
 async function selectWave(rows: Row[], deps: DepRow[]) {
   const out = await handler(
-    // deno-lint-ignore no-explicit-any
     { variables: { planKey: "owner/repo#63", currentWave: 1 } } as any,
     fakeApp(rows, deps),
   );
   return out as { waveTasks: unknown[] };
 }
 
-Deno.test("select-wave leaves dependents pending behind a waiting-for-lane dependency", async () => {
+test("select-wave leaves dependents pending behind a waiting-for-lane dependency", async () => {
   const rows: Row[] = [
     {
       id: 1,
@@ -95,9 +92,9 @@ Deno.test("select-wave leaves dependents pending behind a waiting-for-lane depen
   assertEquals(rows[1].summary, undefined);
 });
 
-Deno.test("select-wave still skips dependents behind failed or otherwise non-open dependencies", async (t) => {
+test("select-wave still skips dependents behind failed or otherwise non-open dependencies", async (t) => {
   for (const depStatus of ["blocked", "skipped", "pending"] as const) {
-    await t.step(depStatus, async () => {
+    await t.test(depStatus, async () => {
       const rows: Row[] = [
         {
           id: 1,

package/deno.json

@@ -1,24 +0,0 @@
-{
-  "compilerOptions": {
-    "lib": [
-      "deno.window",
-      "deno.ns"
-    ]
-  },
-  "imports": {
-    "@nanobpm/urban": "npm:@nanobpm/urban@^0.33.0"
-  },
-  "tasks": {
-    "start": "deno run --allow-net --allow-read --allow-write --allow-run=gh --allow-env main.ts",
-    "purge": "deno run --allow-read --allow-write --allow-env scripts/purge-db.ts",
-    "check": "deno run -A @nanobpm/urban check",
-    "check:prompts": "deno run -A scripts/check-agent-prompts.ts",
-    "gen": "deno run -A @nanobpm/urban gen",
-    "gen:check": "deno run -A @nanobpm/urban gen --check",
-    "layout": "deno run -A scripts/layout-bpmn.ts",
-    "layout:check": "deno run -A scripts/layout-bpmn.ts --check",
-    "dev": "deno run -A @nanobpm/urban dev",
-    "compile": "deno compile --allow-net --allow-read --allow-write --allow-run=gh --allow-env -o dist/nano-workforce main.ts",
-    "test": "deno test -A"
-  }
-}