@nanobpm/nano-workforce 0.35.2 → 0.37.0

package/workers/merge/worker.ts

@@ -9,11 +9,11 @@
 // calls live in app/github.ts; this worker records the attempt in the `merges` audit table and
 // shapes the escalation payload on a block.
 import type { AppJobHandler } from "@nanobpm/urban";
-import { enqueueViaComment, mergePr } from "../../app/github.ts";
-import { MERGE_ADMIN, MERGE_METHOD, ensurePr } from "../../app/service.ts";
 import { abandonTokenFromUrl } from "../../app/abandon.ts";
-import { loadMergeProtocol } from "../../app/mergeProtocol.ts";
 import { checkBaseTarget } from "../../app/baseGuard.ts";
+import { enqueueViaComment, mergePr } from "../../app/github.ts";
+import { loadMergeProtocol } from "../../app/mergeProtocol.ts";
+import { ensurePr, MERGE_ADMIN, MERGE_METHOD } from "../../app/service.ts";
 
 interface In extends Record<string, unknown> {
   prKey: string;

package/workers/persist-escalation/worker.ts

@@ -3,8 +3,8 @@
 // and the MAX_ROUNDS guard (status = blocked, question set by the process). Returns
 // `escalationId` for the UI.
 import type { AppJobHandler } from "@nanobpm/urban";
-import { ensurePr, parsePr } from "../../app/service.ts";
 import { abandonTokenFromUrl } from "../../app/abandon.ts";
+import { ensurePr, parsePr } from "../../app/service.ts";
 
 // Extends Record so the declared fields are typed while the job may still carry
 // other process variables (e.g. io.nanobpm.agentResult, read by transcriptOf).
@@ -39,6 +39,7 @@ function nonBlank(v: unknown): string | undefined {
 
 const AGENT_RESULT_KEY = "io.nanobpm.agentResult";
 function transcriptOf(vars: Record<string, unknown>): string | null {
+  // biome-ignore lint/plugin: runtime/framework contract boundary for external data shape
   const env = vars[AGENT_RESULT_KEY] as { output?: unknown } | undefined;
   return typeof env?.output === "string" ? env.output : null;
 }

package/workers/persist-round/worker.ts

@@ -5,8 +5,8 @@
 // Data access goes through the injected app datasource gateway (`app.data.table<T>`), the RAD
 // `Table<T>` surface — `rounds.insert(...)` / `pull_requests.update(...)`, not hand-written SQL.
 import type { AppJobHandler } from "@nanobpm/urban";
-import { ensurePr, parsePr } from "../../app/service.ts";
 import { abandonTokenFromUrl } from "../../app/abandon.ts";
+import { ensurePr, parsePr } from "../../app/service.ts";
 
 // Extends Record so the declared fields are typed while the job may still carry
 // other process variables (e.g. io.nanobpm.agentResult, read by transcriptOf).
@@ -29,6 +29,7 @@ interface In extends Record<string, unknown> {
 // for audit so a human can see what the agent did this round.
 const AGENT_RESULT_KEY = "io.nanobpm.agentResult";
 function transcriptOf(vars: Record<string, unknown>): string | null {
+  // biome-ignore lint/plugin: runtime/framework contract boundary for external data shape
   const env = vars[AGENT_RESULT_KEY] as { output?: unknown } | undefined;
   return typeof env?.output === "string" ? env.output : null;
 }

package/workers/record-plan-review/worker.test.ts

@@ -5,7 +5,8 @@
 // plan was empty (e.g. the planner agent couldn't persist its result) — completed the whole epic
 // GREEN having done nothing (instance 21). We now HARD-FAIL: the terminal, unapproved round raises
 // a non-retryable `PLAN_REJECTED` BpmnError (→ incident), so an un-approved plan never dispatches.
-import { assertEquals, assertRejects } from "jsr:@std/assert@1";
+import { test } from "node:test";
+import { assertEquals, assertRejects } from "#test-assert";
 import { BpmnError } from "@nanobpm/urban";
 import handler from "./worker.ts";
 import { MAX_PLAN_REVIEW_ROUNDS, type PlanReview } from "../../app/plan.ts";
@@ -18,9 +19,7 @@ function fakeApp(existing: PlanReview[] = []) {
     data: {
       table() {
         return {
-          // deno-lint-ignore no-explicit-any
           findOne: (q: any) => Promise.resolve(rows.find((r) => match(r, q)) ?? null),
-          // deno-lint-ignore no-explicit-any
           count: (q: any) => Promise.resolve(rows.filter((r) => match(r, q)).length),
           insert: (row: PlanReview) => {
             rows.push(row);
@@ -31,7 +30,6 @@ function fakeApp(existing: PlanReview[] = []) {
     },
     log: () => {},
     _rows: rows,
-    // deno-lint-ignore no-explicit-any
   } as any;
 }
 
@@ -48,16 +46,15 @@ function priorRounds(planKey: string, n: number): PlanReview[] {
 }
 
 const call = async (app: unknown, vars: Record<string, unknown>, jobKey = "j-new") =>
-  // deno-lint-ignore no-explicit-any
   await handler({ variables: vars, jobKey } as any, app as any);
 
-Deno.test("approved round proceeds (planApproved=true, no throw)", async () => {
+test("approved round proceeds (planApproved=true, no throw)", async () => {
   const app = fakeApp(priorRounds("o/r#1", 0));
   const out = await call(app, { planKey: "o/r#1", approved: true });
   assertEquals((out as { planApproved: boolean }).planApproved, true);
 });
 
-Deno.test("unapproved, non-final round revises (planApproved=false, no throw)", async () => {
+test("unapproved, non-final round revises (planApproved=false, no throw)", async () => {
   // First round of a 3-round cap: not final, so revise.
   const app = fakeApp(priorRounds("o/r#2", 0));
   const out = await call(app, { planKey: "o/r#2", approved: false, findings: "fix X" });
@@ -65,7 +62,7 @@ Deno.test("unapproved, non-final round revises (planApproved=false, no throw)",
   assertEquals((out as { planFindings: string }).planFindings, "fix X");
 });
 
-Deno.test("unapproved FINAL round hard-fails with PLAN_REJECTED incident", async () => {
+test("unapproved FINAL round hard-fails with PLAN_REJECTED incident", async () => {
   // Seed cap-1 prior rounds so this job is the last permitted round; unapproved ⇒ must throw.
   const app = fakeApp(priorRounds("o/r#3", MAX_PLAN_REVIEW_ROUNDS - 1));
   const err = await assertRejects(
@@ -75,7 +72,7 @@ Deno.test("unapproved FINAL round hard-fails with PLAN_REJECTED incident", async
   assertEquals((err as BpmnError).errorCode, "PLAN_REJECTED");
 });
 
-Deno.test("approved on the FINAL round still proceeds (no throw)", async () => {
+test("approved on the FINAL round still proceeds (no throw)", async () => {
   const app = fakeApp(priorRounds("o/r#4", MAX_PLAN_REVIEW_ROUNDS - 1));
   const out = await call(app, { planKey: "o/r#4", approved: true });
   assertEquals((out as { planApproved: boolean }).planApproved, true);

package/workers/record-plan-review/worker.ts

@@ -16,8 +16,9 @@
 // the whole epic complete GREEN having done nothing. The cap still bounds the loop; it now bounds
 // it into an incident, not a silent proceed. A missing/ambiguous `approved` is treated as NOT
 // approved (revise until the cap).
-import { BpmnError } from "@nanobpm/urban";
+
 import type { AppJobHandler } from "@nanobpm/urban";
+import { BpmnError } from "@nanobpm/urban";
 import { MAX_PLAN_REVIEW_ROUNDS, type PlanReview, planReviews } from "../../app/plan.ts";
 
 interface In extends Record<string, unknown> {

package/workers/record-results/worker.test.ts

@@ -6,7 +6,8 @@
 // non-retryable `NO_WORK_DISPATCHED` BpmnError (→ incident) when the epic finalizes with no opened
 // PR, recording a `failed` terminal status + outcome first, so "accomplished nothing" surfaces
 // instead of masquerading as a completed epic.
-import { assertEquals, assertRejects } from "jsr:@std/assert@1";
+import { test } from "node:test";
+import { assertEquals, assertRejects } from "#test-assert";
 import { BpmnError } from "@nanobpm/urban";
 import handler from "./worker.ts";
 import type { PlanTaskStatus } from "../../app/plan.ts";
@@ -25,7 +26,6 @@ function fakeApp(rows: Row[]) {
       table(name: string, key: string) {
         if (name === "plans") {
           return {
-            // deno-lint-ignore no-explicit-any
             update: (k: any, patch: any) => {
               plans.push({ [key]: k, ...patch });
               return Promise.resolve(patch);
@@ -34,7 +34,6 @@ function fakeApp(rows: Row[]) {
         }
         // plan_tasks
         return {
-          // deno-lint-ignore no-explicit-any
           find: (q: any) =>
             Promise.resolve(
               rows.filter((r) =>
@@ -48,15 +47,13 @@ function fakeApp(rows: Row[]) {
     },
     log: () => {},
     _plans: plans,
-    // deno-lint-ignore no-explicit-any
   } as any;
 }
 
 const call = async (app: unknown, planKey = "o/r#1") =>
-  // deno-lint-ignore no-explicit-any
   await handler({ variables: { planKey } } as any, app as any);
 
-Deno.test("no opened PRs (empty plan) hard-fails with NO_WORK_DISPATCHED", async () => {
+test("no opened PRs (empty plan) hard-fails with NO_WORK_DISPATCHED", async () => {
   const app = fakeApp([]);
   const err = await assertRejects(() => call(app), BpmnError);
   assertEquals((err as BpmnError).errorCode, "NO_WORK_DISPATCHED");
@@ -67,7 +64,7 @@ Deno.test("no opened PRs (empty plan) hard-fails with NO_WORK_DISPATCHED", async
   assertEquals(plan.outcome, "no work dispatched — the planner produced no tasks");
 });
 
-Deno.test("tasks present but none opened (all skipped/blocked) hard-fails", async () => {
+test("tasks present but none opened (all skipped/blocked) hard-fails", async () => {
   const app = fakeApp([
     { id: 1, plan_key: "o/r#1", task_id: "a", status: "skipped" },
     { id: 2, plan_key: "o/r#1", task_id: "b", status: "blocked" },
@@ -79,7 +76,7 @@ Deno.test("tasks present but none opened (all skipped/blocked) hard-fails", asyn
   assertEquals(plan.outcome, "no work dispatched — every task was blocked or skipped");
 });
 
-Deno.test("at least one opened PR finalizes cleanly (no throw)", async () => {
+test("at least one opened PR finalizes cleanly (no throw)", async () => {
   const app = fakeApp([
     { id: 1, plan_key: "o/r#1", task_id: "a", status: "opened" },
     { id: 2, plan_key: "o/r#1", task_id: "b", status: "skipped" },

package/workers/record-results/worker.ts

@@ -10,8 +10,9 @@
 //   • zero PRs opened → record a `failed` outcome for observability, then throw the non-retryable
 //     `NO_WORK_DISPATCHED` BpmnError so the engine parks the instance on an incident instead of
 //     completing green (issue #86). The `failed` status is terminal, so `startPlan` can re-plan it.
-import { BpmnError } from "@nanobpm/urban";
+
 import type { AppJobHandler } from "@nanobpm/urban";
+import { BpmnError } from "@nanobpm/urban";
 import { planTasks } from "../../app/plan.ts";
 
 interface In extends Record<string, unknown> {

package/workers/record-trial-merge/worker.test.ts

@@ -1,4 +1,5 @@
-import { assertEquals, assertStringIncludes } from "jsr:@std/assert@1";
+import { test } from "node:test";
+import { assertEquals, assertStringIncludes } from "#test-assert";
 import handler, { parseResult } from "./worker.ts";
 
 function fakeApp() {
@@ -7,16 +8,13 @@ function fakeApp() {
     data: {
       table(name: string, _key: string) {
         return {
-          // deno-lint-ignore require-await
           async find(_q: unknown) {
             return [];
           },
-          // deno-lint-ignore require-await
           async insert(row: unknown) {
             (inserts[name] ??= []).push(row);
             return 7;
           },
-          // deno-lint-ignore require-await
           async update(_key: unknown, _patch: unknown) {},
         };
       },
@@ -26,31 +24,27 @@ function fakeApp() {
   return { app, inserts };
 }
 
-Deno.test("record-trial-merge shapes clean results as proceed", async () => {
+test("record-trial-merge shapes clean results as proceed", async () => {
   const { app, inserts } = fakeApp();
   const out = await handler(
-    // deno-lint-ignore no-explicit-any
     { key: 11, variables: { planKey: "o/r#69", currentWave: 2, result: "clean", summary: "green" } } as any,
-    // deno-lint-ignore no-explicit-any
     app as any,
   ) as Record<string, unknown>;
 
   assertEquals(out.trialMergeRed, false);
   assertEquals(inserts.plan_trial_merges.length, 1);
-  // deno-lint-ignore no-explicit-any
   assertEquals((inserts.plan_trial_merges[0] as any).result, "clean");
 });
 
-Deno.test("parseResult trims valid agent result strings", () => {
+test("parseResult trims valid agent result strings", () => {
   assertEquals(parseResult("clean\n"), "clean");
   assertEquals(parseResult(" merge-conflict "), "merge-conflict");
   assertEquals(parseResult("unknown"), "suite-failed");
 });
 
-Deno.test("record-trial-merge escalates only suite-failed results", async () => {
+test("record-trial-merge escalates only suite-failed results", async () => {
   const { app } = fakeApp();
   const out = await handler(
-    // deno-lint-ignore no-explicit-any
     {
       key: 12,
       variables: {
@@ -61,7 +55,6 @@ Deno.test("record-trial-merge escalates only suite-failed results", async () =>
         failing: ["integration suite"],
       },
     } as any,
-    // deno-lint-ignore no-explicit-any
     app as any,
   ) as Record<string, unknown>;
 
@@ -71,10 +64,9 @@ Deno.test("record-trial-merge escalates only suite-failed results", async () =>
   assertStringIncludes(String(out.question ?? ""), "proceed");
 });
 
-Deno.test("record-trial-merge renders odd failing payloads without throwing", async () => {
+test("record-trial-merge renders odd failing payloads without throwing", async () => {
   const { app } = fakeApp();
   const out = await handler(
-    // deno-lint-ignore no-explicit-any
     {
       variables: {
         planKey: "o/r#69",
@@ -83,7 +75,6 @@ Deno.test("record-trial-merge renders odd failing payloads without throwing", as
         failing: [1n],
       },
     } as any,
-    // deno-lint-ignore no-explicit-any
     app as any,
   ) as Record<string, unknown>;
 
@@ -91,12 +82,10 @@ Deno.test("record-trial-merge renders odd failing payloads without throwing", as
   assertStringIncludes(String(out.question ?? ""), "Failing:");
 });
 
-Deno.test("record-trial-merge treats textual conflicts as pass-through", async () => {
+test("record-trial-merge treats textual conflicts as pass-through", async () => {
   const { app } = fakeApp();
   const out = await handler(
-    // deno-lint-ignore no-explicit-any
     { variables: { planKey: "o/r#69", result: "merge-conflict", conflicts: [{ prs: [1, 2] }] } } as any,
-    // deno-lint-ignore no-explicit-any
     app as any,
   ) as Record<string, unknown>;
 

package/workers/record-trial-merge/worker.ts

@@ -4,9 +4,9 @@
 import type { AppJobHandler } from "@nanobpm/urban";
 import {
   recordTrialMergeAudit,
+  type TrialMergeResult,
   trialMergeDecision,
   trialMergeTaskId,
-  type TrialMergeResult,
 } from "../../app/trialMerge.ts";
 
 interface In extends Record<string, unknown> {
@@ -26,7 +26,6 @@ interface Out extends Record<string, unknown> {
   summary?: string;
 }
 
-const RESULTS = new Set<TrialMergeResult>(["clean", "merge-conflict", "suite-failed"]);
 const str = (v: unknown): string | undefined =>
   typeof v === "string" && v.trim().length > 0 ? v.trim() : undefined;
 const waveNo = (v: unknown): number => {
@@ -43,7 +42,8 @@ const safeJson = (v: unknown): string => {
 
 function parseResult(v: unknown): TrialMergeResult {
   const s = typeof v === "string" ? v.trim() : "";
-  return RESULTS.has(s as TrialMergeResult) ? (s as TrialMergeResult) : "suite-failed";
+  if (s === "clean" || s === "merge-conflict" || s === "suite-failed") return s;
+  return "suite-failed";
 }
 
 const handler: AppJobHandler<In, Out> = async (job, app) => {
@@ -52,8 +52,8 @@ const handler: AppJobHandler<In, Out> = async (job, app) => {
   const result = parseResult(job.variables.result);
   const summary = str(job.variables.summary) ??
     (result === "suite-failed" ? "Trial merge suite failed or returned no machine-readable result" : result);
-  const rawJobKey = (job as { key?: unknown }).key;
-  const jobKey = rawJobKey == null ? null : String(rawJobKey);
+  const legacyJobKey = Reflect.get(job, "key");
+  const jobKey = job.jobKey ?? (legacyJobKey == null ? null : String(legacyJobKey));
 
   try {
     await recordTrialMergeAudit(app.data, {
@@ -80,7 +80,7 @@ const handler: AppJobHandler<In, Out> = async (job, app) => {
     trialMergeRed,
     summary,
     task: { id: trialMergeTaskId(wave), title: `Trial merge gate for wave ${wave}` },
-    question: `${summary}${failing}\n\nD3 needs a human decision: either the PR heads merged cleanly and the combined suite failed, or the trial-merge agent did not return a valid machine-readable result. Decide the design/infrastructure fix, update the PR heads if needed, then answer to rerun the trial merge; answer exactly \"proceed\" only to override and continue without rerunning.`,
+    question: `${summary}${failing}\n\nD3 needs a human decision: either the PR heads merged cleanly and the combined suite failed, or the trial-merge agent did not return a valid machine-readable result. Decide the design/infrastructure fix, update the PR heads if needed, then answer to rerun the trial merge; answer exactly "proceed" only to override and continue without rerunning.`,
   };
 };
 

package/workers/record-wave/worker.test.ts

@@ -1,7 +1,8 @@
 // Red/green regression for retrying a wave when `select-wave` deliberately left pending work
 // behind a non-fatal wait (D7 / issue #63). Advancing past that wave would make `record-results`
 // finish the plan with a still-pending task.
-import { assertEquals } from "jsr:@std/assert@1";
+import { test } from "node:test";
+import { assertEquals } from "#test-assert";
 import handler from "./worker.ts";
 import type { PlanTaskStatus } from "../../app/plan.ts";
 import { _clearMergeProtocolCache } from "../../app/mergeProtocol.ts";
@@ -32,10 +33,8 @@ function fakeApp(rows: Row[]) {
         table(name: string, key: string) {
           const store = stores[name] ??= [];
           return {
-            // deno-lint-ignore no-explicit-any
             get: (k: any) =>
               Promise.resolve(store.find((r) => ((r as unknown) as Record<string, unknown>)[key] === k)),
-            // deno-lint-ignore no-explicit-any
             find: (q: any) =>
               Promise.resolve(
                 store.filter((r) =>
@@ -44,12 +43,10 @@ function fakeApp(rows: Row[]) {
                   )
                 ),
               ),
-            // deno-lint-ignore no-explicit-any
             insert: (row: any) => {
               store.push(row);
               return Promise.resolve(store.length);
             },
-            // deno-lint-ignore no-explicit-any
             update: (k: any, patch: any) => {
               if (name === "plans") {
                 planUpdates.push({ key: k, patch });
@@ -68,7 +65,6 @@ function fakeApp(rows: Row[]) {
       engine: {
         createInstance: () => Promise.resolve({ processInstanceKey: "pi" }),
       },
-      // deno-lint-ignore no-explicit-any
     } as any,
     planUpdates,
   };
@@ -76,11 +72,11 @@ function fakeApp(rows: Row[]) {
 
 function installGithubStub(method: "gh-merge" | "mergify-queue") {
   _clearMergeProtocolCache();
-  const oldTransport = Deno.env.get("NANO_PR_GITHUB_TRANSPORT");
-  const oldToken = Deno.env.get("GITHUB_TOKEN");
+  const oldTransport = process.env["NANO_PR_GITHUB_TRANSPORT"];
+  const oldToken = process.env["GITHUB_TOKEN"];
   const oldFetch = globalThis.fetch;
-  Deno.env.set("NANO_PR_GITHUB_TRANSPORT", "token");
-  Deno.env.set("GITHUB_TOKEN", "test-token");
+  process.env["NANO_PR_GITHUB_TRANSPORT"] = "token";
+  process.env["GITHUB_TOKEN"] = "test-token";
   globalThis.fetch = ((input: string | URL | Request) => {
     const url = String(input);
     if (url.includes("/contents/AGENTS.md")) {
@@ -104,16 +100,16 @@ function installGithubStub(method: "gh-merge" | "mergify-queue") {
     return Promise.resolve(new Response("not found", { status: 404 }));
   }) as typeof fetch;
   return () => {
-    if (oldTransport == null) Deno.env.delete("NANO_PR_GITHUB_TRANSPORT");
-    else Deno.env.set("NANO_PR_GITHUB_TRANSPORT", oldTransport);
-    if (oldToken == null) Deno.env.delete("GITHUB_TOKEN");
-    else Deno.env.set("GITHUB_TOKEN", oldToken);
+    if (oldTransport == null) delete process.env["NANO_PR_GITHUB_TRANSPORT"];
+    else process.env["NANO_PR_GITHUB_TRANSPORT"] = oldTransport;
+    if (oldToken == null) delete process.env["GITHUB_TOKEN"];
+    else process.env["GITHUB_TOKEN"] = oldToken;
     globalThis.fetch = oldFetch;
     _clearMergeProtocolCache();
   };
 }
 
-Deno.test("record-wave retries the same wave when a task is still pending", async () => {
+test("record-wave retries the same wave when a task is still pending", async () => {
   const rows: Row[] = [{
     id: 2,
     plan_key: "owner/repo#63",
@@ -124,7 +120,6 @@ Deno.test("record-wave retries the same wave when a task is still pending", asyn
   const { app, planUpdates } = fakeApp(rows);
 
   const out = await handler(
-    // deno-lint-ignore no-explicit-any
     {
       variables: {
         planKey: "owner/repo#63",
@@ -148,7 +143,7 @@ Deno.test("record-wave retries the same wave when a task is still pending", asyn
   assertEquals((planUpdates[0].patch as Record<string, unknown>).gate_wave, 1);
 });
 
-Deno.test("record-wave skips trial merge for mergify-queue repos with 2+ heads", async () => {
+test("record-wave skips trial merge for mergify-queue repos with 2+ heads", async () => {
   const restore = installGithubStub("mergify-queue");
   try {
     const rows: Row[] = [
@@ -157,7 +152,6 @@ Deno.test("record-wave skips trial merge for mergify-queue repos with 2+ heads",
     ];
     const { app } = fakeApp(rows);
     const out = await handler(
-      // deno-lint-ignore no-explicit-any
       {
         variables: {
           planKey: "owner/repo#69",
@@ -184,7 +178,7 @@ Deno.test("record-wave skips trial merge for mergify-queue repos with 2+ heads",
   }
 });
 
-Deno.test("record-wave runs trial merge for non-queue repos with populated heads", async () => {
+test("record-wave runs trial merge for non-queue repos with populated heads", async () => {
   const restore = installGithubStub("gh-merge");
   try {
     const rows: Row[] = [
@@ -193,7 +187,6 @@ Deno.test("record-wave runs trial merge for non-queue repos with populated heads
     ];
     const { app } = fakeApp(rows);
     const out = await handler(
-      // deno-lint-ignore no-explicit-any
       {
         variables: {
           planKey: "owner/repo#69",

package/workers/record-wave/worker.ts

@@ -14,19 +14,19 @@
 // Enrollment lives here (not in the finalizer) so a PR is enrolled the moment its wave lands —
 // and, crucially, so a later wave's `dependsOn` can reference the PR keys earlier waves produced.
 import type { AppJobHandler } from "@nanobpm/urban";
+import { appendEntry } from "../../app/blackboard.ts";
+import { fetchPrFiles, fetchPrHead } from "../../app/github.ts";
+import { deriveExclusions, recordExclusions } from "../../app/mergeExclusion.ts";
+import { loadMergeProtocol } from "../../app/mergeProtocol.ts";
 import {
   type PlanTask,
   type PlanTaskStatus,
+  plans,
   planTaskDeps,
   planTasks,
-  plans,
 } from "../../app/plan.ts";
 import { parsePr, submitPr } from "../../app/service.ts";
 import { parseTaskDelta, readTaskDeltas, recordTaskDelta } from "../../app/taskDelta.ts";
-import { appendEntry } from "../../app/blackboard.ts";
-import { deriveExclusions, recordExclusions } from "../../app/mergeExclusion.ts";
-import { fetchPrFiles, fetchPrHead } from "../../app/github.ts";
-import { loadMergeProtocol } from "../../app/mergeProtocol.ts";
 import { shouldRunTrialMerge, type TrialMergeHead } from "../../app/trialMerge.ts";
 
 interface Result {
@@ -61,9 +61,8 @@ const str = (v: unknown): string | undefined =>
 // including a missing status — is treated as `blocked`: we must not assume a PR was opened,
 // and we only hand off / persist a PR when the status is `opened`.
 type WaveResultStatus = Extract<PlanTaskStatus, "opened" | "blocked" | "skipped">;
-const ALLOWED_STATUSES = new Set<WaveResultStatus>(["opened", "blocked", "skipped"]);
 const isWaveResultStatus = (s: string): s is WaveResultStatus =>
-  ALLOWED_STATUSES.has(s as WaveResultStatus);
+  s === "opened" || s === "blocked" || s === "skipped";
 
 // Coerce a wave index/count to a non-negative integer, falling back to 0. A NaN here would make
 // `nextWave < waveCount` mis-evaluate and end the loop early, leaving tasks `pending`.
@@ -103,7 +102,7 @@ const handler: AppJobHandler<In, Out> = async (job, app) => {
   const readyHeadsThisWave: { repo: string; number: number | string }[] = [];
 
   for (let i = 0; i < waveTasks.length; i++) {
-    const taskId = str((waveTasks[i] ?? {}).id);
+    const taskId = str(waveTasks[i]?.id);
     if (!taskId) continue;
     const res = results[i] ?? {};
     const rawStatus = str(res.status);

package/workers/retro-gather/worker.test.ts

@@ -1,47 +1,38 @@
-import { assert, assertEquals, assertStringIncludes } from "jsr:@std/assert@1";
+import { test } from "node:test";
+import { assert, assertEquals, assertStringIncludes } from "#test-assert";
 import type { DataLayer } from "@nanobpm/urban";
 import { appendEntry } from "../../app/blackboard.ts";
 import handler from "./worker.ts";
 
-// deno-lint-ignore no-explicit-any
 function memData(): { data: DataLayer; stores: Record<string, any[]> } {
-  // deno-lint-ignore no-explicit-any
   const stores: Record<string, any[]> = {};
   const seq: Record<string, number> = {};
   function tbl(name: string, pk = "id") {
-    // deno-lint-ignore no-explicit-any
     const rows = (stores[name] ??= [] as any[]);
-    // deno-lint-ignore no-explicit-any
     const match = (r: any, where: any) => Object.entries(where).every(([k, v]) => r[k] === v);
     return {
-      // deno-lint-ignore no-explicit-any require-await
       async insert(row: any) {
         const id = (seq[name] = (seq[name] ?? 0) + 1);
         rows.push(pk === "id" ? { id, ...row } : { ...row });
         return pk === "id" ? id : row[pk];
       },
-      // deno-lint-ignore no-explicit-any require-await
       async find(where: any = {}) {
         return rows.filter((r) => match(r, where));
       },
-      // deno-lint-ignore no-explicit-any require-await
       async findOne(where: any = {}) {
         return rows.find((r) => match(r, where));
       },
-      // deno-lint-ignore no-explicit-any require-await
       async get(id: any) {
         return rows.find((row) => row[pk] === id);
       },
-      // deno-lint-ignore no-explicit-any require-await
       async update() {},
     };
   }
-  // deno-lint-ignore no-explicit-any
   const data = { table: (n: string, pk?: string) => tbl(n, pk) } as any as DataLayer;
   return { data, stores };
 }
 
-Deno.test("retro-gather: emits a digest brief + learning count for the plan", async () => {
+test("retro-gather: emits a digest brief + learning count for the plan", async () => {
   const { data, stores } = memData();
   stores["plans"] = [{ plan_key: "o/r#3", repo: "o/r", issue_url: "https://x/3", title: "Epic" }];
   await appendEntry(data, "o/r#3", { author_task: "t1", kind: "learning", body: "regen before build" });
@@ -49,9 +40,7 @@ Deno.test("retro-gather: emits a digest brief + learning count for the plan", as
 
   const app = { data, log: () => undefined };
   const out = await handler(
-    // deno-lint-ignore no-explicit-any
     { variables: { planKey: "o/r#3" } } as any,
-    // deno-lint-ignore no-explicit-any
     app as any,
   ) as Record<string, unknown>;
 
@@ -61,14 +50,12 @@ Deno.test("retro-gather: emits a digest brief + learning count for the plan", as
   assertStringIncludes(String(out.retroDigest), "o/r#3");
 });
 
-Deno.test("retro-gather: an epic with no learnings still renders a valid brief", async () => {
+test("retro-gather: an epic with no learnings still renders a valid brief", async () => {
   const { data, stores } = memData();
   stores["plans"] = [{ plan_key: "o/r#4", repo: "o/r", issue_url: "", title: null }];
   const app = { data, log: () => undefined };
   const out = await handler(
-    // deno-lint-ignore no-explicit-any
     { variables: { planKey: "o/r#4" } } as any,
-    // deno-lint-ignore no-explicit-any
     app as any,
   ) as Record<string, unknown>;