@nanobpm/nano-workforce 0.35.2 → 0.37.0

package/app/retro.test.ts

@@ -1,5 +1,6 @@
 // Unit tests for the epic retrospective stage (app/retro.ts, 016_plan_retro.sql).
-import { assert, assertEquals, assertStringIncludes } from "jsr:@std/assert@1";
+import { test } from "node:test";
+import { assert, assertEquals, assertStringIncludes } from "#test-assert";
 import type { DataLayer, EngineClient } from "@nanobpm/urban";
 import { appendEntry } from "./blackboard.ts";
 import { recordTaskDelta } from "./taskDelta.ts";
@@ -15,18 +16,13 @@ import {
 } from "./retro.ts";
 
 // In-memory record gateway matching the Table<T> subset retro.ts uses: insert/find/findOne/get/update.
-// deno-lint-ignore no-explicit-any
 function memData(): { data: DataLayer; stores: Record<string, any[]> } {
-  // deno-lint-ignore no-explicit-any
   const stores: Record<string, any[]> = {};
   const seq: Record<string, number> = {};
   function tbl(name: string, pk = "id") {
-    // deno-lint-ignore no-explicit-any
     const rows = (stores[name] ??= [] as any[]);
-    // deno-lint-ignore no-explicit-any
     const match = (r: any, where: any) => Object.entries(where).every(([k, v]) => r[k] === v);
     return {
-      // deno-lint-ignore no-explicit-any require-await
       async insert(row: any) {
         if (pk !== "id" && rows.some((r) => r[pk] === row[pk])) {
           throw new Error(`UNIQUE constraint failed: ${name}.${pk}`);
@@ -35,26 +31,21 @@ function memData(): { data: DataLayer; stores: Record<string, any[]> } {
         rows.push(pk === "id" ? { id, ...row } : { ...row });
         return pk === "id" ? id : row[pk];
       },
-      // deno-lint-ignore no-explicit-any require-await
       async find(where: any = {}) {
         return rows.filter((r) => match(r, where));
       },
-      // deno-lint-ignore no-explicit-any require-await
       async findOne(where: any = {}) {
         return rows.find((r) => match(r, where));
       },
-      // deno-lint-ignore no-explicit-any require-await
       async get(id: any) {
         return rows.find((row) => row[pk] === id);
       },
-      // deno-lint-ignore no-explicit-any require-await
       async update(id: any, patch: any) {
         const r = rows.find((row) => row[pk] === id);
         if (r) Object.assign(r, patch);
       },
     };
   }
-  // deno-lint-ignore no-explicit-any
   const data = { table: (n: string, pk?: string) => tbl(n, pk) } as any as DataLayer;
   return { data, stores };
 }
@@ -62,21 +53,17 @@ function memData(): { data: DataLayer; stores: Record<string, any[]> } {
 // A fake engine recording createInstance calls.
 function fakeEngine(): { engine: EngineClient; started: { processDefinitionId: string; variables: Record<string, unknown> }[] } {
   const started: { processDefinitionId: string; variables: Record<string, unknown> }[] = [];
-  // deno-lint-ignore no-explicit-any
   const engine = {
-    // deno-lint-ignore no-explicit-any require-await
     async createInstance(req: any) {
       started.push({ processDefinitionId: req.processDefinitionId, variables: req.variables });
       return { processInstanceKey: `PI-${started.length}` };
     },
-    // deno-lint-ignore no-explicit-any require-await
   } as any as EngineClient;
   return { engine, started };
 }
 
 const PLAN = "acme/widgets#7";
 
-// deno-lint-ignore no-explicit-any
 function seedPlan(stores: Record<string, any[]>, over: Record<string, unknown> = {}) {
   stores["plans"] = [{
     plan_key: PLAN,
@@ -89,20 +76,17 @@ function seedPlan(stores: Record<string, any[]>, over: Record<string, unknown> =
   }];
 }
 
-// deno-lint-ignore no-explicit-any
 function seedTask(stores: Record<string, any[]>, task: Record<string, unknown>) {
   (stores["plan_tasks"] ??= []).push({ plan_key: PLAN, ...task });
 }
-// deno-lint-ignore no-explicit-any
 function seedPr(stores: Record<string, any[]>, pr_key: string, status: string) {
   (stores["pull_requests"] ??= []).push({ pr_key, status });
 }
-// deno-lint-ignore no-explicit-any
 function seedReview(stores: Record<string, any[]>, round: number, approved: number, findings: string | null) {
   (stores["plan_reviews"] ??= []).push({ plan_key: PLAN, round, approved, findings, created_at: `t${round}`, job_key: null });
 }
 
-Deno.test("autoRetroEnabled: on by default; disabled by 0/false/off/no", () => {
+test("autoRetroEnabled: on by default; disabled by 0/false/off/no", () => {
   const prev = process.env.NANO_AUTO_RETRO;
   try {
     delete process.env.NANO_AUTO_RETRO;
@@ -119,7 +103,7 @@ Deno.test("autoRetroEnabled: on by default; disabled by 0/false/off/no", () => {
   }
 });
 
-Deno.test("planKeyForPr: resolves the plan a PR's task belongs to; undefined when unlinked", async () => {
+test("planKeyForPr: resolves the plan a PR's task belongs to; undefined when unlinked", async () => {
   const { data, stores } = memData();
   seedTask(stores, { id: "t1", status: "opened", pr_key: "acme/widgets#10" });
   assertEquals(await planKeyForPr(data, "acme/widgets#10"), PLAN);
@@ -127,7 +111,7 @@ Deno.test("planKeyForPr: resolves the plan a PR's task belongs to; undefined whe
   assertEquals(await planKeyForPr(data, ""), undefined);
 });
 
-Deno.test("isPlanComplete: false while any task is still in flight", async () => {
+test("isPlanComplete: false while any task is still in flight", async () => {
   const { data, stores } = memData();
   seedTask(stores, { id: "t1", status: "opened", pr_key: "acme/widgets#10" });
   seedTask(stores, { id: "t2", status: "pending", pr_key: null });
@@ -136,14 +120,14 @@ Deno.test("isPlanComplete: false while any task is still in flight", async () =>
   assertEquals(await isPlanComplete(data, PLAN), false);
 });
 
-Deno.test("isPlanComplete: false when an opened task's PR is not yet terminal", async () => {
+test("isPlanComplete: false when an opened task's PR is not yet terminal", async () => {
   const { data, stores } = memData();
   seedTask(stores, { id: "t1", status: "opened", pr_key: "acme/widgets#10" });
   seedPr(stores, "acme/widgets#10", "waiting_deps"); // in the merge stage, not terminal
   assertEquals(await isPlanComplete(data, PLAN), false);
 });
 
-Deno.test("isPlanComplete: true when every task is settled (terminal PR or skipped/blocked)", async () => {
+test("isPlanComplete: true when every task is settled (terminal PR or skipped/blocked)", async () => {
   const { data, stores } = memData();
   seedTask(stores, { id: "t1", status: "opened", pr_key: "acme/widgets#10" });
   seedTask(stores, { id: "t2", status: "skipped", pr_key: null });
@@ -153,12 +137,12 @@ Deno.test("isPlanComplete: true when every task is settled (terminal PR or skipp
   assertEquals(await isPlanComplete(data, PLAN), true);
 });
 
-Deno.test("isPlanComplete: an empty plan has nothing to retrospect", async () => {
+test("isPlanComplete: an empty plan has nothing to retrospect", async () => {
   const { data } = memData();
   assertEquals(await isPlanComplete(data, PLAN), false);
 });
 
-Deno.test("gatherRetro: separates learnings from notes and folds in deltas", async () => {
+test("gatherRetro: separates learnings from notes and folds in deltas", async () => {
   const { data, stores } = memData();
   seedPlan(stores);
   await appendEntry(data, PLAN, { author_task: "t1", kind: "learning", body: "regen the API surface before building" });
@@ -181,7 +165,7 @@ Deno.test("gatherRetro: separates learnings from notes and folds in deltas", asy
   assertEquals(d.repo, "acme/widgets");
 });
 
-Deno.test("gatherRetro: folds in the plan-review trace and task-outcome shape", async () => {
+test("gatherRetro: folds in the plan-review trace and task-outcome shape", async () => {
   const { data, stores } = memData();
   seedPlan(stores);
   seedTask(stores, { id: "t1", task_id: "t1", status: "opened", pr_key: "acme/widgets#10" });
@@ -201,7 +185,7 @@ Deno.test("gatherRetro: folds in the plan-review trace and task-outcome shape",
   assertEquals(d.taskOutcomes.byStatus, { opened: 2, skipped: 1 });
 });
 
-Deno.test("gatherRetro: no reviews → zero rounds, not approved, empty rejections", async () => {
+test("gatherRetro: no reviews → zero rounds, not approved, empty rejections", async () => {
   const { data, stores } = memData();
   seedPlan(stores);
   const d = await gatherRetro(data, PLAN);
@@ -211,7 +195,7 @@ Deno.test("gatherRetro: no reviews → zero rounds, not approved, empty rejectio
   assertEquals(d.taskOutcomes, { total: 0, byStatus: {} });
 });
 
-Deno.test("renderRetroBrief: renders learnings + constraints; states 'none' with no learnings", () => {
+test("renderRetroBrief: renders learnings + constraints; states 'none' with no learnings", () => {
   const empty = renderRetroBrief({
     planKey: PLAN, repo: "acme/widgets", issueUrl: "", title: null,
     learnings: [], touchedFiles: [], contractChanges: [], constraints: [], notes: [],
@@ -243,7 +227,7 @@ Deno.test("renderRetroBrief: renders learnings + constraints; states 'none' with
   assertStringIncludes(brief, "Task outcomes");
 });
 
-Deno.test("isDigestEmpty: empty only with no learnings/deltas/notes AND no review rejections", () => {
+test("isDigestEmpty: empty only with no learnings/deltas/notes AND no review rejections", () => {
   const base = { planKey: PLAN, repo: "", issueUrl: "", title: null, learnings: [], touchedFiles: [], contractChanges: [], constraints: [], notes: [], reviewRounds: 0, reviewRejections: [], planApproved: false, taskOutcomes: { total: 0, byStatus: {} } };
   assert(isDigestEmpty({ ...base, counts: { learnings: 0, deltas: 0, notes: 0 } }));
   assert(!isDigestEmpty({ ...base, counts: { learnings: 1, deltas: 0, notes: 0 } }));
@@ -255,7 +239,7 @@ Deno.test("isDigestEmpty: empty only with no learnings/deltas/notes AND no revie
   assert(isDigestEmpty({ ...base, reviewRounds: 1, planApproved: true, taskOutcomes: { total: 3, byStatus: { opened: 3 } }, counts: { learnings: 0, deltas: 0, notes: 0 } }));
 });
 
-Deno.test("recordRetro: inserts then updates the same plan_key row in place", async () => {
+test("recordRetro: inserts then updates the same plan_key row in place", async () => {
   const { data, stores } = memData();
   await recordRetro(data, PLAN, { status: "filed", prKey: "acme/widgets#20", learnings: 3, summary: "promoted 2" });
   assertEquals(stores["plan_retros"].length, 1);
@@ -268,25 +252,21 @@ Deno.test("recordRetro: inserts then updates the same plan_key row in place", as
   assertEquals(stores["plan_retros"][0].pr_key, null);
 });
 
-Deno.test("recordRetro: rethrows a non-unique (FOREIGN KEY) constraint error instead of swallowing it", async () => {
+test("recordRetro: rethrows a non-unique (FOREIGN KEY) constraint error instead of swallowing it", async () => {
   // A FK failure (e.g. plan_key missing in plans) must NOT be treated as a benign duplicate and
   // fall through to a silent update — that would make the write look successful while doing nothing.
   let updated = false;
   const table = {
-    // deno-lint-ignore require-await
     async insert() {
       throw new Error("FOREIGN KEY constraint failed");
     },
-    // deno-lint-ignore require-await
     async update() {
       updated = true;
     },
-    // deno-lint-ignore require-await
     async get() {
       return undefined;
     },
   };
-  // deno-lint-ignore no-explicit-any
   const data = { table: () => table } as any as DataLayer;
   let threw = false;
   try {
@@ -299,7 +279,7 @@ Deno.test("recordRetro: rethrows a non-unique (FOREIGN KEY) constraint error ins
   assertEquals(updated, false, "must not silently fall back to update on a non-unique error");
 });
 
-Deno.test("maybeStartRetro: starts the retro exactly once when the last PR lands with material", async () => {
+test("maybeStartRetro: starts the retro exactly once when the last PR lands with material", async () => {
   const { data, stores } = memData();
   seedPlan(stores);
   seedTask(stores, { id: "t1", status: "opened", pr_key: "acme/widgets#10" });
@@ -325,13 +305,12 @@ Deno.test("maybeStartRetro: starts the retro exactly once when the last PR lands
   assertEquals(started.length, 1, "fire-once guard");
 });
 
-Deno.test("maybeStartRetro: a createInstance failure records a blocked retro (fire-once guard already consumed)", async () => {
+test("maybeStartRetro: a createInstance failure records a blocked retro (fire-once guard already consumed)", async () => {
   const { data, stores } = memData();
   seedPlan(stores);
   seedTask(stores, { id: "t1", status: "opened", pr_key: "acme/widgets#10" });
   seedPr(stores, "acme/widgets#10", "merged");
   await appendEntry(data, PLAN, { author_task: "t1", kind: "learning", body: "regen first" });
-  // deno-lint-ignore no-explicit-any require-await
   const engine = { async createInstance() { throw new Error("gateway down"); } } as any as EngineClient;
 
   const r = await maybeStartRetro(data, engine, "acme/widgets#10");
@@ -346,19 +325,16 @@ Deno.test("maybeStartRetro: a createInstance failure records a blocked retro (fi
   assertStringIncludes(String(stores["plan_retros"][0].summary), "gateway down");
 });
 
-Deno.test("maybeStartRetro: a secondary blocked-retro persistence failure still returns start-failed (not error)", async () => {
+test("maybeStartRetro: a secondary blocked-retro persistence failure still returns start-failed (not error)", async () => {
   const { data, stores } = memData();
   seedPlan(stores);
   seedTask(stores, { id: "t1", status: "opened", pr_key: "acme/widgets#10" });
   seedPr(stores, "acme/widgets#10", "merged");
   await appendEntry(data, PLAN, { author_task: "t1", kind: "learning", body: "regen first" });
-  // deno-lint-ignore no-explicit-any require-await
   const engine = { async createInstance() { throw new Error("gateway down"); } } as any as EngineClient;
   // recordRetro rethrows non-unique DB errors; simulate the blocked-retro insert hitting a
   // FOREIGN KEY failure so the persistence in the createInstance-failure handler throws.
-  // deno-lint-ignore no-explicit-any
   const failingData = {
-    // deno-lint-ignore no-explicit-any
     table: (name: string, pk?: string) => {
       const t = (data as any).table(name, pk);
       if (name !== "plan_retros") return t;
@@ -374,7 +350,7 @@ Deno.test("maybeStartRetro: a secondary blocked-retro persistence failure still
   assertEquals(stores["plan_retros"].length, 0);
 });
 
-Deno.test("maybeStartRetro: a pre-claimed retro start does not start a duplicate process", async () => {
+test("maybeStartRetro: a pre-claimed retro start does not start a duplicate process", async () => {
   const { data, stores } = memData();
   seedPlan(stores);
   seedTask(stores, { id: "t1", status: "opened", pr_key: "acme/widgets#10" });
@@ -389,7 +365,7 @@ Deno.test("maybeStartRetro: a pre-claimed retro start does not start a duplicate
   assertEquals(stores["plans"][0].retro_started_at, null);
 });
 
-Deno.test("maybeStartRetro: bails while the plan is incomplete", async () => {
+test("maybeStartRetro: bails while the plan is incomplete", async () => {
   const { data, stores } = memData();
   seedPlan(stores);
   seedTask(stores, { id: "t1", status: "opened", pr_key: "acme/widgets#10" });
@@ -404,7 +380,7 @@ Deno.test("maybeStartRetro: bails while the plan is incomplete", async () => {
   assertEquals(stores["plans"][0].retro_started_at, null, "must not stamp an incomplete plan");
 });
 
-Deno.test("maybeStartRetro: complete but empty → records a skipped retro, does not start the process", async () => {
+test("maybeStartRetro: complete but empty → records a skipped retro, does not start the process", async () => {
   const { data, stores } = memData();
   seedPlan(stores);
   seedTask(stores, { id: "t1", status: "opened", pr_key: "acme/widgets#10" });
@@ -419,7 +395,7 @@ Deno.test("maybeStartRetro: complete but empty → records a skipped retro, does
   assertEquals(stores["plan_retros"][0].status, "skipped");
 });
 
-Deno.test("maybeStartRetro: a rejected review round alone is enough to fire the retro", async () => {
+test("maybeStartRetro: a rejected review round alone is enough to fire the retro", async () => {
   const { data, stores } = memData();
   seedPlan(stores);
   seedTask(stores, { id: "t1", status: "opened", pr_key: "acme/widgets#10" });
@@ -436,7 +412,7 @@ Deno.test("maybeStartRetro: a rejected review round alone is enough to fire the
   assert(stores["plans"][0].retro_started_at, "retro_started_at must be stamped");
 });
 
-Deno.test("maybeStartRetro: a PR not part of any plan is a no-op", async () => {
+test("maybeStartRetro: a PR not part of any plan is a no-op", async () => {
   const { data } = memData();
   const { engine, started } = fakeEngine();
   const r = await maybeStartRetro(data, engine, "acme/widgets#99");
@@ -445,7 +421,7 @@ Deno.test("maybeStartRetro: a PR not part of any plan is a no-op", async () => {
   assertEquals(started.length, 0);
 });
 
-Deno.test("maybeStartRetro: honours NANO_AUTO_RETRO=0", async () => {
+test("maybeStartRetro: honours NANO_AUTO_RETRO=0", async () => {
   const prev = process.env.NANO_AUTO_RETRO;
   process.env.NANO_AUTO_RETRO = "0";
   try {

package/app/retro.ts

@@ -14,16 +14,17 @@
 // Data access goes through the record gateway (`data.table`), never hand-written SQL — matching
 // app/plan.ts, app/blackboard.ts, and app/taskDelta.ts.
 import type { DataLayer, EngineClient } from "@nanobpm/urban";
-import { planReviews, planTasks } from "./plan.ts";
 import { isUniqueViolation, readBlackboard } from "./blackboard.ts";
-import { aggregateEpicDeltas } from "./taskDelta.ts";
+import { planReviews, planTasks } from "./plan.ts";
 import { TERMINAL_STATUSES } from "./service.ts";
+import { aggregateEpicDeltas } from "./taskDelta.ts";
 
 export const RETRO_PROCESS_ID = "retro";
 
 /** Opt-out env toggle. Retro runs by default; set NANO_AUTO_RETRO=0/false to disable (e.g. in a
  * review-only deployment that doesn't want the fleet opening promotion PRs). */
 export function autoRetroEnabled(): boolean {
+  // biome-ignore lint/plugin: runtime/framework contract boundary for external data shape
   const v = (globalThis as { process?: { env?: Record<string, string | undefined> } })
     .process?.env?.NANO_AUTO_RETRO;
   if (v == null) return true;
@@ -128,6 +129,7 @@ export async function gatherRetro(data: DataLayer, planKey: string): Promise<Ret
     .sort((a, b) => a.round - b.round);
   const reviewRejections = reviews
     .filter((r) => r.approved === 0 && (r.findings ?? "").trim() !== "")
+    // biome-ignore lint/plugin: runtime/framework contract boundary for external data shape
     .map((r) => ({ round: r.round, findings: r.findings as string }));
   const planApproved = reviews.length > 0 && reviews[reviews.length - 1].approved === 1;
 

package/app/reviewWait.test.ts

@@ -1,8 +1,9 @@
 // Contract for the review-wait liveness policy — the ISO-8601 timeout validation handed to the
 // process's timer catch, and the Copilot re-request nudge cooldown. Both are env-driven, so a
 // blank/malformed operator value must fall back to a sane default rather than deploy an
-// uninterpretable timer or a runaway nudge interval. Run with `deno test -A`.
-import { assertEquals } from "jsr:@std/assert@1";
+// uninterpretable timer or a runaway nudge interval. Run with `node --test`.
+import { test } from "node:test";
+import { assertEquals } from "#test-assert";
 import {
   clampNudgeMinutes,
   DEFAULT_REVIEW_NUDGE_MINUTES,
@@ -11,7 +12,7 @@ import {
   reviewWaitTimeout,
 } from "./reviewWait.ts";
 
-Deno.test("reviewWaitTimeout: blank / absent / malformed → default", () => {
+test("reviewWaitTimeout: blank / absent / malformed → default", () => {
   assertEquals(reviewWaitTimeout(undefined), DEFAULT_REVIEW_WAIT_TIMEOUT);
   assertEquals(reviewWaitTimeout(""), DEFAULT_REVIEW_WAIT_TIMEOUT);
   assertEquals(reviewWaitTimeout("   "), DEFAULT_REVIEW_WAIT_TIMEOUT);
@@ -21,7 +22,7 @@ Deno.test("reviewWaitTimeout: blank / absent / malformed → default", () => {
   assertEquals(reviewWaitTimeout("garbage"), DEFAULT_REVIEW_WAIT_TIMEOUT);
 });
 
-Deno.test("reviewWaitTimeout: a valid ISO-8601 duration is honoured and upper-cased", () => {
+test("reviewWaitTimeout: a valid ISO-8601 duration is honoured and upper-cased", () => {
   assertEquals(reviewWaitTimeout("PT30M"), "PT30M");
   assertEquals(reviewWaitTimeout("pt30m"), "PT30M");
   assertEquals(reviewWaitTimeout(" PT1H30M "), "PT1H30M");
@@ -30,12 +31,12 @@ Deno.test("reviewWaitTimeout: a valid ISO-8601 duration is honoured and upper-ca
   assertEquals(reviewWaitTimeout("P1DT2H"), "P1DT2H");
 });
 
-Deno.test("reviewWaitTimeout: a custom fallback is used when the value is invalid", () => {
+test("reviewWaitTimeout: a custom fallback is used when the value is invalid", () => {
   assertEquals(reviewWaitTimeout("nope", "PT10M"), "PT10M");
   assertEquals(reviewWaitTimeout(undefined, "PT10M"), "PT10M");
 });
 
-Deno.test("clampNudgeMinutes: blank / absent / non-numeric → fallback", () => {
+test("clampNudgeMinutes: blank / absent / non-numeric → fallback", () => {
   assertEquals(clampNudgeMinutes(""), DEFAULT_REVIEW_NUDGE_MINUTES);
   assertEquals(clampNudgeMinutes("   "), DEFAULT_REVIEW_NUDGE_MINUTES);
   assertEquals(clampNudgeMinutes(undefined), DEFAULT_REVIEW_NUDGE_MINUTES);
@@ -44,27 +45,27 @@ Deno.test("clampNudgeMinutes: blank / absent / non-numeric → fallback", () =>
   assertEquals(clampNudgeMinutes(NaN), DEFAULT_REVIEW_NUDGE_MINUTES);
 });
 
-Deno.test("clampNudgeMinutes: a valid positive value (string or number) is honoured", () => {
+test("clampNudgeMinutes: a valid positive value (string or number) is honoured", () => {
   assertEquals(clampNudgeMinutes("10"), 10);
   assertEquals(clampNudgeMinutes(15), 15);
   assertEquals(clampNudgeMinutes(" 7 "), 7);
 });
 
-Deno.test("clampNudgeMinutes: fractional values are truncated", () => {
+test("clampNudgeMinutes: fractional values are truncated", () => {
   assertEquals(clampNudgeMinutes("5.9"), 5);
   assertEquals(clampNudgeMinutes(3.2), 3);
 });
 
-Deno.test("clampNudgeMinutes: zero and negatives fall back (a 0 cooldown would hammer the API)", () => {
+test("clampNudgeMinutes: zero and negatives fall back (a 0 cooldown would hammer the API)", () => {
   assertEquals(clampNudgeMinutes(0), DEFAULT_REVIEW_NUDGE_MINUTES);
   assertEquals(clampNudgeMinutes("-4"), DEFAULT_REVIEW_NUDGE_MINUTES);
 });
 
-Deno.test("clampNudgeMinutes: above the ceiling is clamped, not rejected", () => {
+test("clampNudgeMinutes: above the ceiling is clamped, not rejected", () => {
   assertEquals(clampNudgeMinutes(100_000), MAX_REVIEW_NUDGE_MINUTES);
   assertEquals(clampNudgeMinutes(String(MAX_REVIEW_NUDGE_MINUTES + 1)), MAX_REVIEW_NUDGE_MINUTES);
 });
 
-Deno.test("clampNudgeMinutes: an oversized fallback is itself clamped to the ceiling", () => {
+test("clampNudgeMinutes: an oversized fallback is itself clamped to the ceiling", () => {
   assertEquals(clampNudgeMinutes("", MAX_REVIEW_NUDGE_MINUTES + 50), MAX_REVIEW_NUDGE_MINUTES);
 });

package/app/rounds.test.ts

@@ -1,10 +1,11 @@
 // Contract for clampRounds — the per-submit round-cap coercion. The submit form renders every
 // field as a text input (the runtime hardcodes type="text"), so the override arrives as a string
-// and a blank field must fall back to the fleet default. Run with `deno test`.
-import { assertEquals } from "jsr:@std/assert@1";
+// and a blank field must fall back to the fleet default. Run with `node --test`.
+import { test } from "node:test";
+import { assertEquals } from "#test-assert";
 import { clampCiFixBudget, clampRounds, MAX_CI_FIX_CEILING, MAX_ROUNDS_CEILING } from "./rounds.ts";
 
-Deno.test("blank / absent / non-numeric → fallback", () => {
+test("blank / absent / non-numeric → fallback", () => {
   assertEquals(clampRounds("", 20), 20);
   assertEquals(clampRounds("   ", 20), 20);
   assertEquals(clampRounds(undefined, 20), 20);
@@ -13,28 +14,28 @@ Deno.test("blank / absent / non-numeric → fallback", () => {
   assertEquals(clampRounds(NaN, 20), 20);
 });
 
-Deno.test("a valid positive value (string or number) is honoured", () => {
+test("a valid positive value (string or number) is honoured", () => {
   assertEquals(clampRounds("5", 20), 5);
   assertEquals(clampRounds(30, 20), 30);
   assertEquals(clampRounds(" 12 ", 20), 12);
 });
 
-Deno.test("fractional values are truncated to a whole round", () => {
+test("fractional values are truncated to a whole round", () => {
   assertEquals(clampRounds("7.9", 20), 7);
   assertEquals(clampRounds(3.2, 20), 3);
 });
 
-Deno.test("zero and negatives fall back (a cap < 1 would escalate before round 1)", () => {
+test("zero and negatives fall back (a cap < 1 would escalate before round 1)", () => {
   assertEquals(clampRounds(0, 20), 20);
   assertEquals(clampRounds("-4", 20), 20);
 });
 
-Deno.test("above the ceiling is clamped, not rejected", () => {
+test("above the ceiling is clamped, not rejected", () => {
   assertEquals(clampRounds(1000, 20), MAX_ROUNDS_CEILING);
   assertEquals(clampRounds(String(MAX_ROUNDS_CEILING + 1), 20), MAX_ROUNDS_CEILING);
 });
 
-Deno.test("an oversized fallback is itself clamped to the ceiling", () => {
+test("an oversized fallback is itself clamped to the ceiling", () => {
   // A blank/invalid input falls back — but the fallback must not bypass the ceiling.
   assertEquals(clampRounds("", MAX_ROUNDS_CEILING + 50), MAX_ROUNDS_CEILING);
   assertEquals(clampRounds("   ", MAX_ROUNDS_CEILING + 1), MAX_ROUNDS_CEILING);
@@ -45,7 +46,7 @@ Deno.test("an oversized fallback is itself clamped to the ceiling", () => {
 // clampCiFixBudget — the merge stage's CI-fix attempt budget (NANO_PR_MAX_CI_FIX_ROUNDS). Unlike
 // clampRounds it ALLOWS 0, because 0 is a meaningful setting: disable auto-fix so a blocked PR
 // escalates to a human immediately.
-Deno.test("ci-fix budget: blank / non-numeric / negative → fallback", () => {
+test("ci-fix budget: blank / non-numeric / negative → fallback", () => {
   assertEquals(clampCiFixBudget("", 3), 3);
   assertEquals(clampCiFixBudget("   ", 3), 3);
   assertEquals(clampCiFixBudget(undefined, 3), 3);
@@ -55,20 +56,20 @@ Deno.test("ci-fix budget: blank / non-numeric / negative → fallback", () => {
   assertEquals(clampCiFixBudget("-1", 3), 3);
 });
 
-Deno.test("ci-fix budget: 0 is honoured (disables auto-fix), unlike clampRounds", () => {
+test("ci-fix budget: 0 is honoured (disables auto-fix), unlike clampRounds", () => {
   assertEquals(clampCiFixBudget(0, 3), 0);
   assertEquals(clampCiFixBudget("0", 3), 0);
   // Contrast: the round cap treats 0 as invalid and falls back.
   assertEquals(clampRounds(0, 3), 3);
 });
 
-Deno.test("ci-fix budget: a valid positive value is honoured and truncated", () => {
+test("ci-fix budget: a valid positive value is honoured and truncated", () => {
   assertEquals(clampCiFixBudget("5", 3), 5);
   assertEquals(clampCiFixBudget(2, 3), 2);
   assertEquals(clampCiFixBudget("4.8", 3), 4);
 });
 
-Deno.test("ci-fix budget: above the ceiling is clamped; oversized fallback too", () => {
+test("ci-fix budget: above the ceiling is clamped; oversized fallback too", () => {
   assertEquals(clampCiFixBudget(1000, 3), MAX_CI_FIX_CEILING);
   assertEquals(clampCiFixBudget("", MAX_CI_FIX_CEILING + 5), MAX_CI_FIX_CEILING);
 });

package/app/service.test.ts

@@ -5,30 +5,25 @@
 // dead "(no question provided)" question on the re-opened PR (the same stale-row class the plan
 // loop already guards in `startPlan`). Drives `submitPr` against an in-memory data layer with the
 // GitHub transport forced off so it is hermetic.
-import { assertEquals } from "jsr:@std/assert@1";
+import { test } from "node:test";
+import { assertEquals } from "#test-assert";
 import { pollIncidentsImpl, submitPr } from "./service.ts";
 
-// deno-lint-ignore no-explicit-any
 function memTable(rows: any[], key: string) {
   return {
-    // deno-lint-ignore no-explicit-any
     get: (k: any) => Promise.resolve(rows.find((r) => r[key] === k) ?? null),
     all: () => Promise.resolve([...rows]),
-    // deno-lint-ignore no-explicit-any
     find: (q: any) =>
       Promise.resolve(rows.filter((r) => Object.entries(q).every(([f, v]) => r[f] === v))),
-    // deno-lint-ignore no-explicit-any
     insert: (r: any) => {
       rows.push(r);
       return Promise.resolve(r);
     },
-    // deno-lint-ignore no-explicit-any
     update: (k: any, patch: any) => {
       const r = rows.find((x) => x[key] === k);
       if (r) Object.assign(r, patch);
       return Promise.resolve(r);
     },
-    // deno-lint-ignore no-explicit-any
     delete: (k: any) => {
       for (let i = rows.length - 1; i >= 0; i--) if (rows[i][key] === k) rows.splice(i, 1);
       return Promise.resolve();
@@ -37,18 +32,18 @@ function memTable(rows: any[], key: string) {
 }
 
 function withGithubOff(run: () => Promise<void>): Promise<void> {
-  const prevMode = Deno.env.get("NANO_PR_GITHUB_TRANSPORT");
-  const prevTok = Deno.env.get("GITHUB_TOKEN");
-  Deno.env.set("NANO_PR_GITHUB_TRANSPORT", "token"); // no token below -> fetchPrMeta returns null
-  Deno.env.delete("GITHUB_TOKEN");
+  const prevMode = process.env["NANO_PR_GITHUB_TRANSPORT"];
+  const prevTok = process.env["GITHUB_TOKEN"];
+  process.env["NANO_PR_GITHUB_TRANSPORT"] = "token"; // no token below -> fetchPrMeta returns null
+  delete process.env["GITHUB_TOKEN"];
   return run().finally(() => {
-    if (prevMode !== undefined) Deno.env.set("NANO_PR_GITHUB_TRANSPORT", prevMode);
-    else Deno.env.delete("NANO_PR_GITHUB_TRANSPORT");
-    if (prevTok !== undefined) Deno.env.set("GITHUB_TOKEN", prevTok);
+    if (prevMode !== undefined) process.env["NANO_PR_GITHUB_TRANSPORT"] = prevMode;
+    else delete process.env["NANO_PR_GITHUB_TRANSPORT"];
+    if (prevTok !== undefined) process.env["GITHUB_TOKEN"] = prevTok;
   });
 }
 
-Deno.test("re-submit of a cancelled PR clears stale open escalations + the denormalised pointer", async () => {
+test("re-submit of a cancelled PR clears stale open escalations + the denormalised pointer", async () => {
   await withGithubOff(async () => {
     const PR_KEY = "owner/repo#42";
     const stores: Record<string, { rows: unknown[]; key: string }> = {
@@ -74,11 +69,9 @@ Deno.test("re-submit of a cancelled PR clears stale open escalations + the denor
     };
     const data = {
       table: (name: string, key: string) => memTable(stores[name]?.rows ?? [], stores[name]?.key ?? key),
-      // deno-lint-ignore no-explicit-any
     } as any;
     const engine = {
       createInstance: () => Promise.resolve({ processInstanceKey: "PI-9" }),
-      // deno-lint-ignore no-explicit-any
     } as any;
 
     await submitPr(data, engine, {
@@ -125,7 +118,7 @@ function incidentFetch(byInstance: Record<string, unknown[]>) {
   };
 }
 
-Deno.test("pollIncidents mirrors an ACTIVE incident onto the PR row, then clears it, leaving status untouched", async () => {
+test("pollIncidents mirrors an ACTIVE incident onto the PR row, then clears it, leaving status untouched", async () => {
   const row = {
     pr_key: "owner/repo#7",
     repo: "owner/repo",
@@ -141,7 +134,6 @@ Deno.test("pollIncidents mirrors an ACTIVE incident onto the PR row, then clears
   };
   const data = {
     table: (name: string, key: string) => memTable(stores[name]?.rows ?? [], stores[name]?.key ?? key),
-    // deno-lint-ignore no-explicit-any
   } as any;
   const headers = { "content-type": "application/json" };
 
@@ -173,7 +165,7 @@ Deno.test("pollIncidents mirrors an ACTIVE incident onto the PR row, then clears
   assertEquals(row.status, "converging");
 });
 
-Deno.test("pollIncidents never queries a PR with no live instance and clears any stale incident", async () => {
+test("pollIncidents never queries a PR with no live instance and clears any stale incident", async () => {
   const noKey = {
     pr_key: "owner/repo#8",
     status: "converging",
@@ -195,7 +187,6 @@ Deno.test("pollIncidents never queries a PR with no live instance and clears any
   };
   const data = {
     table: (name: string, key: string) => memTable(stores[name]?.rows ?? [], stores[name]?.key ?? key),
-    // deno-lint-ignore no-explicit-any
   } as any;
   const headers = { "content-type": "application/json" };
 
@@ -215,7 +206,7 @@ Deno.test("pollIncidents never queries a PR with no live instance and clears any
   assertEquals(terminal.incident_message, null);
 });
 
-Deno.test("pollIncidents picks the oldest incident by creationTime, sorting a missing timestamp last", async () => {
+test("pollIncidents picks the oldest incident by creationTime, sorting a missing timestamp last", async () => {
   const row = {
     pr_key: "owner/repo#11",
     status: "converging",
@@ -229,7 +220,6 @@ Deno.test("pollIncidents picks the oldest incident by creationTime, sorting a mi
   };
   const data = {
     table: (name: string, key: string) => memTable(stores[name]?.rows ?? [], stores[name]?.key ?? key),
-    // deno-lint-ignore no-explicit-any
   } as any;
   const headers = { "content-type": "application/json" };
 
@@ -259,7 +249,7 @@ Deno.test("pollIncidents picks the oldest incident by creationTime, sorting a mi
 // source also keeps the returned key aligned with the DB-persisted `String(...)` value and dodges
 // JS 53-bit precision limits for large 64-bit keys (which is why keys travel as strings in
 // practice). `submitPr` must stringify it both in the returned body and the persisted row.
-Deno.test("submitPr stringifies a numeric processInstanceKey (contract: string | null)", async () => {
+test("submitPr stringifies a numeric processInstanceKey (contract: string | null)", async () => {
   await withGithubOff(async () => {
     const PR_KEY = "owner/repo#7";
     const stores: Record<string, { rows: unknown[]; key: string }> = {
@@ -269,14 +259,12 @@ Deno.test("submitPr stringifies a numeric processInstanceKey (contract: string |
     };
     const data = {
       table: (name: string, key: string) => memTable(stores[name]?.rows ?? [], stores[name]?.key ?? key),
-      // deno-lint-ignore no-explicit-any
     } as any;
     const engine = {
       // A large key delivered as a JS number — the exact case that breaks dev response validation
       // (number vs the `string | null` contract). Kept within MAX_SAFE_INTEGER so the fixture
       // itself is exact; true 64-bit keys travel as strings for the same precision reason.
       createInstance: () => Promise.resolve({ processInstanceKey: 2251799813685249 }),
-      // deno-lint-ignore no-explicit-any
     } as any;
 
     const res = await submitPr(data, engine, {
@@ -286,7 +274,6 @@ Deno.test("submitPr stringifies a numeric processInstanceKey (contract: string |
       prKey: PR_KEY,
     });
 
-    // deno-lint-ignore no-explicit-any
     const processKey = (res as any).processKey;
     assertEquals(typeof processKey, "string");
     assertEquals(processKey, "2251799813685249");