@mycadet/assistant 0.12.7 → 0.12.8

package/src/__tests__/clawhub.test.ts

@@ -75,7 +75,7 @@ describe("clawhubInstall slug validation", () => {
 });
 
 describe("clawhubInstall staging", () => {
-  test("runs clawhub in a staging project root without touching the managed skill", async () => {
+  test("runs clawhub in a staging project root without touching the cloud skill", async () => {
     const originalSpawn = Bun.spawn;
     const projectRoot = join(TEST_DIR, "clawhub-staging-project");
     const finalSkillDir = join(TEST_DIR, "skills", "demo-skill");

package/src/__tests__/{platform-callback-registration.test.ts → cloud-callback-registration.test.ts}

@@ -9,8 +9,8 @@ import { useFaultableSecureKeyMap } from "./helpers/secure-keys.js";
 
 let mockIsPlatform = true;
 let mockTunnelWebhooksEnabled = false;
-let mockPlatformBaseUrl = "";
-let mockPlatformAssistantId = "";
+let mockCloudBaseUrl = "";
+let mockCloudAssistantId = "";
 let mockConfig: { ingress?: { publicBaseUrl?: string; enabled?: boolean } } =
   {};
 
@@ -37,7 +37,7 @@ let ipcRegisterCalls: RegisterWebhookRouteIpcParams[] = [];
 const actualEnvRegistry = await import("../config/env-registry.js");
 mock.module("../config/env-registry.js", () => ({
   ...actualEnvRegistry,
-  getIsPlatform: () => mockIsPlatform,
+  getIsCloud: () => mockIsPlatform,
 }));
 
 const actualTunnelGate = await import("../inbound/tunnel-webhooks-gate.js");
@@ -49,8 +49,8 @@ mock.module("../inbound/tunnel-webhooks-gate.js", () => ({
 const actualEnv = await import("../config/env.js");
 mock.module("../config/env.js", () => ({
   ...actualEnv,
-  getPlatformBaseUrl: () => mockPlatformBaseUrl,
-  getPlatformAssistantId: () => mockPlatformAssistantId,
+  getCloudBaseUrl: () => mockCloudBaseUrl,
+  getCloudAssistantId: () => mockCloudAssistantId,
 }));
 
 const actualGatewayClient = await import("../ipc/gateway-client.js");
@@ -78,8 +78,8 @@ const originalEnvCredential = process.env.ASSISTANT_API_KEY;
 const {
   registerCallbackRoute,
   resolveCallbackUrl,
-  resolvePlatformCallbackRegistrationContext,
-} = await import("../inbound/platform-callback-registration.js");
+  resolveCloudCallbackRegistrationContext,
+} = await import("../inbound/cloud-callback-registration.js");
 
 const { PublicIngressDisabledError } =
   await import("../inbound/public-ingress-urls.js");
@@ -87,8 +87,8 @@ const { PublicIngressDisabledError } =
 describe("platform callback registration", () => {
   beforeEach(() => {
     mockIsPlatform = true;
-    mockPlatformBaseUrl = "";
-    mockPlatformAssistantId = "";
+    mockCloudBaseUrl = "";
+    mockCloudAssistantId = "";
     secureKeyStore.clear();
     setAllUnreachable(false);
     mockConfig = {};
@@ -107,43 +107,37 @@ describe("platform callback registration", () => {
   });
 
   test("resolves managed callback context from stored credentials", async () => {
-    secureKeyStore.set(
-      credentialKey("cadet", "platform_base_url"),
-      "https://platform.example.com",
-    );
-    mockPlatformAssistantId = "11111111-2222-4333-8444-555555555555";
+    mockCloudBaseUrl = "https://platform.example.com";
+    mockCloudAssistantId = "11111111-2222-4333-8444-555555555555";
     secureKeyStore.set(
       credentialKey("cadet", "assistant_api_key"),
       "ast-managed-key",
     );
 
-    const context = await resolvePlatformCallbackRegistrationContext();
+    const context = await resolveCloudCallbackRegistrationContext();
 
     expect(context.enabled).toBe(true);
     expect(context.isPlatform).toBe(true);
-    expect(context.platformBaseUrl).toBe("https://platform.example.com");
+    expect(context.cloudBaseUrl).toBe("https://platform.example.com");
     expect(context.assistantId).toBe("11111111-2222-4333-8444-555555555555");
     expect(context.hasAssistantApiKey).toBe(true);
     expect(context.authHeader).toBe("Api-Key ast-managed-key");
   });
 
-  test("self-hosted assistant with stored credentials is enabled without IS_PLATFORM", async () => {
+  test("self-hosted assistant with stored credentials is enabled without IS_CLOUD", async () => {
     mockIsPlatform = false;
-    secureKeyStore.set(
-      credentialKey("cadet", "platform_base_url"),
-      "https://platform.example.com",
-    );
-    mockPlatformAssistantId = "22222222-3333-4444-8555-666666666666";
+    mockCloudBaseUrl = "https://platform.example.com";
+    mockCloudAssistantId = "22222222-3333-4444-8555-666666666666";
     secureKeyStore.set(
       credentialKey("cadet", "assistant_api_key"),
       "ast-self-hosted-key",
     );
 
-    const context = await resolvePlatformCallbackRegistrationContext();
+    const context = await resolveCloudCallbackRegistrationContext();
 
     expect(context.enabled).toBe(true);
     expect(context.isPlatform).toBe(false);
-    expect(context.platformBaseUrl).toBe("https://platform.example.com");
+    expect(context.cloudBaseUrl).toBe("https://platform.example.com");
     expect(context.assistantId).toBe("22222222-3333-4444-8555-666666666666");
     expect(context.hasAssistantApiKey).toBe(true);
     expect(context.authHeader).toBe("Api-Key ast-self-hosted-key");
@@ -151,23 +145,23 @@ describe("platform callback registration", () => {
 
   test("uses ASSISTANT_API_KEY env fallback when stored credential is missing", async () => {
     process.env.ASSISTANT_API_KEY = "env-key";
-    mockPlatformBaseUrl = "https://platform.example.com";
-    mockPlatformAssistantId = "33333333-4444-4555-8666-777777777777";
+    mockCloudBaseUrl = "https://platform.example.com";
+    mockCloudAssistantId = "33333333-4444-4555-8666-777777777777";
 
-    const context = await resolvePlatformCallbackRegistrationContext();
+    const context = await resolveCloudCallbackRegistrationContext();
 
     expect(context.enabled).toBe(true);
-    expect(context.platformBaseUrl).toBe("https://platform.example.com");
+    expect(context.cloudBaseUrl).toBe("https://platform.example.com");
     expect(context.assistantId).toBe("33333333-4444-4555-8666-777777777777");
     expect(context.hasAssistantApiKey).toBe(true);
     expect(context.authHeader).toBe("Api-Key env-key");
   });
 
   test("reports the key as missing when the store answers and holds none", async () => {
-    mockPlatformBaseUrl = "https://platform.example.com";
-    mockPlatformAssistantId = "44444444-5555-4666-8777-888888888888";
+    mockCloudBaseUrl = "https://platform.example.com";
+    mockCloudAssistantId = "44444444-5555-4666-8777-888888888888";
 
-    const context = await resolvePlatformCallbackRegistrationContext();
+    const context = await resolveCloudCallbackRegistrationContext();
 
     expect(context.hasAssistantApiKey).toBe(false);
     expect(context.authHeader).toBeNull();
@@ -178,10 +172,10 @@ describe("platform callback registration", () => {
     // A client that provisions a key when it sees none must not be told
     // "none" by a daemon whose store did not answer.
     setAllUnreachable(true);
-    mockPlatformBaseUrl = "https://platform.example.com";
-    mockPlatformAssistantId = "44444444-5555-4666-8777-888888888888";
+    mockCloudBaseUrl = "https://platform.example.com";
+    mockCloudAssistantId = "44444444-5555-4666-8777-888888888888";
 
-    const context = await resolvePlatformCallbackRegistrationContext();
+    const context = await resolveCloudCallbackRegistrationContext();
 
     expect(context.hasAssistantApiKey).toBeNull();
     expect(context.authHeader).toBeNull();
@@ -191,21 +185,18 @@ describe("platform callback registration", () => {
   test("an environment key counts as present even when the store did not answer", async () => {
     setAllUnreachable(true);
     process.env.ASSISTANT_API_KEY = "env-key";
-    mockPlatformBaseUrl = "https://platform.example.com";
-    mockPlatformAssistantId = "44444444-5555-4666-8777-888888888888";
+    mockCloudBaseUrl = "https://platform.example.com";
+    mockCloudAssistantId = "44444444-5555-4666-8777-888888888888";
 
-    const context = await resolvePlatformCallbackRegistrationContext();
+    const context = await resolveCloudCallbackRegistrationContext();
 
     expect(context.hasAssistantApiKey).toBe(true);
     expect(context.authHeader).toBe("Api-Key env-key");
   });
 
   test("registerCallbackRoute falls back to assistant API key auth", async () => {
-    secureKeyStore.set(
-      credentialKey("cadet", "platform_base_url"),
-      "https://platform.example.com",
-    );
-    mockPlatformAssistantId = "11111111-2222-4333-8444-555555555555";
+    mockCloudBaseUrl = "https://platform.example.com";
+    mockCloudAssistantId = "11111111-2222-4333-8444-555555555555";
     secureKeyStore.set(
       credentialKey("cadet", "assistant_api_key"),
       "ast-managed-key",
@@ -252,11 +243,8 @@ describe("platform callback registration", () => {
     mockConfig = {
       ingress: { publicBaseUrl: "https://my-assistant.example.com" },
     };
-    secureKeyStore.set(
-      credentialKey("cadet", "platform_base_url"),
-      "https://platform.example.com",
-    );
-    mockPlatformAssistantId = "22222222-3333-4444-8555-666666666666";
+    mockCloudBaseUrl = "https://platform.example.com";
+    mockCloudAssistantId = "22222222-3333-4444-8555-666666666666";
     secureKeyStore.set(
       credentialKey("cadet", "assistant_api_key"),
       "ast-self-hosted-key",
@@ -297,11 +285,8 @@ describe("platform callback registration", () => {
     mockIsPlatform = false;
     mockConfig = {};
     setIngressPublicBaseUrl("https://detected.example.com/");
-    secureKeyStore.set(
-      credentialKey("cadet", "platform_base_url"),
-      "https://platform.example.com",
-    );
-    mockPlatformAssistantId = "22222222-3333-4444-8555-666666666666";
+    mockCloudBaseUrl = "https://platform.example.com";
+    mockCloudAssistantId = "22222222-3333-4444-8555-666666666666";
     secureKeyStore.set(
       credentialKey("cadet", "assistant_api_key"),
       "ast-self-hosted-key",
@@ -341,11 +326,8 @@ describe("platform callback registration", () => {
   test("self-hosted registerCallbackRoute omits callback_base_url when no ingress is available", async () => {
     mockIsPlatform = false;
     mockConfig = {};
-    secureKeyStore.set(
-      credentialKey("cadet", "platform_base_url"),
-      "https://platform.example.com",
-    );
-    mockPlatformAssistantId = "22222222-3333-4444-8555-666666666666";
+    mockCloudBaseUrl = "https://platform.example.com";
+    mockCloudAssistantId = "22222222-3333-4444-8555-666666666666";
     secureKeyStore.set(
       credentialKey("cadet", "assistant_api_key"),
       "ast-self-hosted-key",
@@ -383,14 +365,11 @@ describe("platform callback registration", () => {
     ).resolves.toBe("https://platform.example.com/v1/gateway/callbacks/x/");
   });
 
-  test("platform-managed registerCallbackRoute omits callback_base_url even when ingress exists", async () => {
+  test("cloud-managed registerCallbackRoute omits callback_base_url even when ingress exists", async () => {
     mockIsPlatform = true;
     mockConfig = { ingress: { publicBaseUrl: "https://tunnel.example.com" } };
-    secureKeyStore.set(
-      credentialKey("cadet", "platform_base_url"),
-      "https://platform.example.com",
-    );
-    mockPlatformAssistantId = "11111111-2222-4333-8444-555555555555";
+    mockCloudBaseUrl = "https://platform.example.com";
+    mockCloudAssistantId = "11111111-2222-4333-8444-555555555555";
     secureKeyStore.set(
       credentialKey("cadet", "assistant_api_key"),
       "ast-managed-key",
@@ -450,12 +429,9 @@ describe("resolveCallbackUrl resolution order", () => {
     throw new PublicIngressDisabledError();
   }
 
-  function seedPlatformCredentials(): void {
-    secureKeyStore.set(
-      credentialKey("cadet", "platform_base_url"),
-      "https://platform.example.com",
-    );
-    mockPlatformAssistantId = "11111111-2222-4333-8444-555555555555";
+  function seedCloudCredentials(): void {
+    mockCloudBaseUrl = "https://platform.example.com";
+    mockCloudAssistantId = "11111111-2222-4333-8444-555555555555";
     secureKeyStore.set(
       credentialKey("cadet", "assistant_api_key"),
       "ast-managed-key",
@@ -467,8 +443,8 @@ describe("resolveCallbackUrl resolution order", () => {
   beforeEach(() => {
     mockIsPlatform = false;
     mockTunnelWebhooksEnabled = false;
-    mockPlatformBaseUrl = "";
-    mockPlatformAssistantId = "";
+    mockCloudBaseUrl = "";
+    mockCloudAssistantId = "";
     secureKeyStore.clear();
     setAllUnreachable(false);
     mockConfig = {};
@@ -499,9 +475,9 @@ describe("resolveCallbackUrl resolution order", () => {
     globalThis.fetch = originalFetch;
   });
 
-  test("platform pods register with the platform gateway", async () => {
+  test("cloud pods register with the cloud gateway", async () => {
     mockIsPlatform = true;
-    seedPlatformCredentials();
+    seedCloudCredentials();
 
     // The direct supplier is never evaluated on a pod: there is no ingress of
     // its own to advertise, and evaluating it would throw.
@@ -515,7 +491,7 @@ describe("resolveCallbackUrl resolution order", () => {
   test("tunnel-webhooks on: a pod claims the subpath and uses the published URL", async () => {
     mockIsPlatform = true;
     mockTunnelWebhooksEnabled = true;
-    seedPlatformCredentials();
+    seedCloudCredentials();
 
     await expect(
       resolveCallbackUrl(
@@ -538,11 +514,11 @@ describe("resolveCallbackUrl resolution order", () => {
     ]);
   });
 
-  test("tunnel-webhooks on: a refused claim falls back to the platform", async () => {
+  test("tunnel-webhooks on: a refused claim falls back to the cloud", async () => {
     mockIsPlatform = true;
     mockTunnelWebhooksEnabled = true;
     mockRegisterWebhookRouteResult = { ok: true, disabled: true };
-    seedPlatformCredentials();
+    seedCloudCredentials();
 
     await expect(
       resolveCallbackUrl(
@@ -555,11 +531,11 @@ describe("resolveCallbackUrl resolution order", () => {
     expect(ipcRegisterCalls).toHaveLength(1);
   });
 
-  test("tunnel-webhooks on: an unreachable gateway falls back to the platform", async () => {
+  test("tunnel-webhooks on: an unreachable gateway falls back to the cloud", async () => {
     mockIsPlatform = true;
     mockTunnelWebhooksEnabled = true;
     mockRegisterWebhookRouteResult = { ok: false, reason: "no_response" };
-    seedPlatformCredentials();
+    seedCloudCredentials();
 
     await expect(
       resolveCallbackUrl(
@@ -572,10 +548,10 @@ describe("resolveCallbackUrl resolution order", () => {
     expect(ipcRegisterCalls).toHaveLength(1);
   });
 
-  test("tunnel-webhooks on: a pod with no published URL still registers with the platform", async () => {
+  test("tunnel-webhooks on: a pod with no published URL still registers with the cloud", async () => {
     mockIsPlatform = true;
     mockTunnelWebhooksEnabled = true;
-    seedPlatformCredentials();
+    seedCloudCredentials();
 
     await expect(
       resolveCallbackUrl(noIngress, "webhooks/twilio/voice", "twilio_voice"),
@@ -587,7 +563,7 @@ describe("resolveCallbackUrl resolution order", () => {
   test("tunnel-webhooks on: a pod with ingress disabled falls back instead of throwing", async () => {
     mockIsPlatform = true;
     mockTunnelWebhooksEnabled = true;
-    seedPlatformCredentials();
+    seedCloudCredentials();
 
     await expect(
       resolveCallbackUrl(
@@ -602,7 +578,7 @@ describe("resolveCallbackUrl resolution order", () => {
 
   test("tunnel-webhooks on: self-hosted opt-out still surfaces", async () => {
     mockTunnelWebhooksEnabled = true;
-    seedPlatformCredentials();
+    seedCloudCredentials();
 
     await expect(
       resolveCallbackUrl(
@@ -617,7 +593,7 @@ describe("resolveCallbackUrl resolution order", () => {
 
   test("tunnel-webhooks on: a self-hosted ingress URL is not claimed on the gateway", async () => {
     mockTunnelWebhooksEnabled = true;
-    seedPlatformCredentials();
+    seedCloudCredentials();
 
     await expect(
       resolveCallbackUrl(
@@ -630,7 +606,7 @@ describe("resolveCallbackUrl resolution order", () => {
   });
 
   test("a configured ingress wins over platform connectivity", async () => {
-    seedPlatformCredentials();
+    seedCloudCredentials();
 
     await expect(
       resolveCallbackUrl(
@@ -643,10 +619,10 @@ describe("resolveCallbackUrl resolution order", () => {
     expect(ipcRegisterCalls).toEqual([]);
   });
 
-  test("a platform-connected assistant with no ingress registers with the platform", async () => {
+  test("a cloud-connected assistant with no ingress registers with the cloud", async () => {
     // LUM-2882: this used to return the direct builder's throw because the
-    // platform branch was gated on IS_PLATFORM, which is only true on a pod.
-    seedPlatformCredentials();
+    // platform branch was gated on IS_CLOUD, which is only true on a pod.
+    seedCloudCredentials();
 
     await expect(
       resolveCallbackUrl(noIngress, "webhooks/twilio/voice", "twilio_voice"),
@@ -654,8 +630,8 @@ describe("resolveCallbackUrl resolution order", () => {
     expect(registerCalls).toBe(1);
   });
 
-  test("query parameters are appended to the platform URL", async () => {
-    seedPlatformCredentials();
+  test("query parameters are appended to the cloud URL", async () => {
+    seedCloudCredentials();
 
     await expect(
       resolveCallbackUrl(noIngress, "webhooks/twilio/voice", "twilio_voice", {
@@ -665,7 +641,7 @@ describe("resolveCallbackUrl resolution order", () => {
   });
 
   test("an explicit ingress opt-out is not routed around", async () => {
-    seedPlatformCredentials();
+    seedCloudCredentials();
 
     await expect(
       resolveCallbackUrl(

package/src/__tests__/{platform-client-verify-credential.test.ts → cloud-client-verify-credential.test.ts}

@@ -2,21 +2,21 @@ import { afterEach, beforeEach, describe, expect, mock, test } from "bun:test";
 
 import { useMemorySecureKeys } from "./helpers/secure-keys.js";
 
-let platformAssistantId = "asst_123";
+let cloudAssistantId = "asst_123";
 let fetchImpl: (
   url: string,
   init?: RequestInit,
 ) => Promise<Response> = async () => new Response("{}", { status: 200 });
 const fetchCalls: Array<{ url: string; init?: RequestInit }> = [];
 
-mock.module("../platform/feature-gate.js", () => ({
-  arePlatformFeaturesEnabled: () => true,
+mock.module("../cloud/feature-gate.js", () => ({
+  areCloudFeaturesEnabled: () => true,
 }));
 
-mock.module("../providers/platform-proxy/context.js", () => ({
-  resolveManagedProxyContext: async () => ({
+mock.module("../providers/cloud-proxy/context.js", () => ({
+  resolveCloudProxyContext: async () => ({
     enabled: true,
-    platformBaseUrl: "https://platform.test/",
+    cloudBaseUrl: "https://platform.test/",
     assistantApiKey: "assistant-key",
   }),
 }));
@@ -24,16 +24,16 @@ mock.module("../providers/platform-proxy/context.js", () => ({
 const actualEnv = await import("../config/env.js");
 mock.module("../config/env.js", () => ({
   ...actualEnv,
-  getPlatformAssistantId: () => platformAssistantId,
+  getCloudAssistantId: () => cloudAssistantId,
 }));
 
 useMemorySecureKeys();
-const { CadetPlatformClient } = await import("../platform/client.js");
+const { CadetCloudClient } = await import("../cloud/client.js");
 
 const originalFetch = globalThis.fetch;
 
 beforeEach(() => {
-  platformAssistantId = "asst_123";
+  cloudAssistantId = "asst_123";
   fetchCalls.length = 0;
   fetchImpl = async () => new Response("{}", { status: 200 });
   globalThis.fetch = (async (input: RequestInfo | URL, init?: RequestInit) => {
@@ -48,14 +48,14 @@ afterEach(() => {
 });
 
 async function createClient() {
-  const client = await CadetPlatformClient.create();
+  const client = await CadetCloudClient.create();
   if (!client) {
     throw new Error("client prerequisites were not satisfied");
   }
   return client;
 }
 
-describe("CadetPlatformClient.verifyCredential", () => {
+describe("CadetCloudClient.verifyCredential", () => {
   test("an accepted request is a valid credential, asked on the owner-consent carrier with the stored key", async () => {
     const client = await createClient();
 
@@ -71,7 +71,7 @@ describe("CadetPlatformClient.verifyCredential", () => {
     expect(fetchCalls[0]?.init?.signal).toBeInstanceOf(AbortSignal);
   });
 
-  // Only the platform's own refusal may drive a rotation.
+  // Only the cloud's own refusal may drive a rotation.
   test.each([401, 403])("a %i is the settled rejection", async (status) => {
     fetchImpl = async () => new Response("", { status });
     const client = await createClient();
@@ -92,8 +92,8 @@ describe("CadetPlatformClient.verifyCredential", () => {
     expect(await client.verifyCredential()).toBe("unknown");
   });
 
-  test("without a platform assistant id there is nothing to verify", async () => {
-    platformAssistantId = "";
+  test("without a cloud assistant id there is nothing to verify", async () => {
+    cloudAssistantId = "";
     const client = await createClient();
     expect(await client.verifyCredential()).toBe("unknown");
     expect(fetchCalls).toHaveLength(0);