@mycadet/assistant 0.12.7 → 0.12.8

package/src/__tests__/memory-config-file-parity.test.ts

@@ -18,7 +18,7 @@ import { getMemoryConfig } from "../plugins/defaults/memory/config.js";
 import { getWorkspaceConfigPath } from "../util/platform.js";
 
 const configPath = getWorkspaceConfigPath();
-const savedIsPlatform = process.env.IS_PLATFORM;
+const savedIsPlatform = process.env.IS_CLOUD;
 
 function writeConfig(value: unknown): void {
   writeFileSync(configPath, JSON.stringify(value, null, 2));
@@ -26,7 +26,7 @@ function writeConfig(value: unknown): void {
 
 function resetState(): void {
   rmSync(configPath, { force: true });
-  delete process.env.IS_PLATFORM;
+  delete process.env.IS_CLOUD;
 }
 
 /** Assert the plugin resolution deep-equals the host loader's slice. */
@@ -41,7 +41,7 @@ describe("memory config file parity", () => {
   afterEach(() => {
     resetState();
     if (savedIsPlatform !== undefined) {
-      process.env.IS_PLATFORM = savedIsPlatform;
+      process.env.IS_CLOUD = savedIsPlatform;
     }
   });
 
@@ -88,14 +88,14 @@ describe("memory config file parity", () => {
   });
 
   test("platform deployment fill applies when the leaf is absent on disk", () => {
-    process.env.IS_PLATFORM = "true";
+    process.env.IS_CLOUD = "true";
     writeConfig({ memory: {} });
     const memory = expectParity();
     expect(memory.embeddings.provider).toBe("gemini");
   });
 
-  test("an explicit on-disk provider beats the platform fill", () => {
-    process.env.IS_PLATFORM = "true";
+  test("an explicit on-disk provider beats the cloud fill", () => {
+    process.env.IS_CLOUD = "true";
     writeConfig({ memory: { embeddings: { provider: "openai" } } });
     const memory = expectParity();
     expect(memory.embeddings.provider).toBe("openai");

package/src/__tests__/migration-export-to-gcs.test.ts

@@ -284,8 +284,8 @@ describe("handleMigrationExportToGcs — happy path", () => {
     // manifest claims a truthful `secrets_redacted: true` regardless of
     // credential-store state, and the bundle passes validation with
     // `origin.mode: "managed"`.
-    const originalIsPlatform = process.env.IS_PLATFORM;
-    process.env.IS_PLATFORM = "true";
+    const originalIsPlatform = process.env.IS_CLOUD;
+    process.env.IS_CLOUD = "true";
 
     let capturedBody: Buffer | undefined;
     const fixture = await startFixtureServer(async (req, res) => {
@@ -328,9 +328,9 @@ describe("handleMigrationExportToGcs — happy path", () => {
       expect(validation.manifest?.secrets_redacted).toBe(true);
     } finally {
       if (originalIsPlatform === undefined) {
-        delete process.env.IS_PLATFORM;
+        delete process.env.IS_CLOUD;
       } else {
-        process.env.IS_PLATFORM = originalIsPlatform;
+        process.env.IS_CLOUD = originalIsPlatform;
       }
       await fixture.close();
     }

package/src/__tests__/migration-import-commit-http.test.ts

@@ -630,7 +630,7 @@ describe("handleMigrationImport — validation failures", () => {
 //
 // Pin: a bundle whose min_runtime_version exceeds APP_VERSION must surface as
 // a 4xx user-actionable response (422 Unprocessable Entity), not a 500
-// InternalError. Body mirrors the platform's PR #5470 response shape so
+// InternalError. Body mirrors the cloud's PR #5470 response shape so
 // clients can render the same UX regardless of which gate (platform or
 // runtime) rejected the bundle.
 // ---------------------------------------------------------------------------

package/src/__tests__/mtime-cache.test.ts

@@ -731,7 +731,7 @@ describe("plugin runtime activation", () => {
       getAllToolDefinitions().some((t) => t.name === "teardown-tool"),
     ).toBe(true);
 
-    // This is the daemon uninstall route's teardown path: the managed uninstall
+    // This is the daemon uninstall route's teardown path: the cloud uninstall
     // runs `shutdown` itself (while the files are present) and removes the
     // directory, then reconciles. The reconcile here only mirrors the removal —
     // it drops the plugin's tools/hooks but must NOT run `shutdown` a second
@@ -766,7 +766,7 @@ describe("plugin runtime activation", () => {
   });
 
   test("an out-of-band directory removal unregisters tools but runs no shutdown", async () => {
-    // A raw `rm` (bypassing the managed uninstall) is only noticed by the
+    // A raw `rm` (bypassing the cloud uninstall) is only noticed by the
     // monitor after the files are gone, so there's no `shutdown` to resolve —
     // the reconcile just evicts. A managed uninstall runs `shutdown` before
     // removal (see uninstall-plugin.test.ts).

package/src/__tests__/{notification-platform-adapter.test.ts → notification-cloud-adapter.test.ts}

@@ -30,7 +30,7 @@ mock.module("../util/retry.js", () => ({
   },
 }));
 
-// ── CadetPlatformClient mock state ──────────────────────────────────────────
+// ── CadetCloudClient mock state ──────────────────────────────────────────
 
 interface FetchCall {
   path: string;
@@ -46,15 +46,15 @@ const fetchErrors: Error[] = [];
 let clientAvailable = true;
 let onClientCreation: () => Promise<void> = async () => {};
 
-mock.module("../platform/client.js", () => ({
-  CadetPlatformClient: {
+mock.module("../cloud/client.js", () => ({
+  CadetCloudClient: {
     create: async () => {
       await onClientCreation();
       if (!clientAvailable) {
         return null;
       }
       return {
-        platformAssistantId: "test-assistant-id",
+        cloudAssistantId: "test-assistant-id",
         fetch: async (path: string, init?: RequestInit) => {
           const body = init?.body
             ? (JSON.parse(init.body as string) as Record<string, unknown>)
@@ -86,7 +86,7 @@ mock.module("../platform/client.js", () => ({
   },
 }));
 
-import { PlatformPushAdapter } from "../notifications/adapters/platform.js";
+import { CloudPushAdapter } from "../notifications/adapters/cloud.js";
 import type {
   ChannelDeliveryPayload,
   ChannelDestination,
@@ -120,7 +120,7 @@ function makeDestination(
 
 // ── Tests ────────────────────────────────────────────────────────────────────
 
-describe("PlatformPushAdapter", () => {
+describe("CloudPushAdapter", () => {
   beforeEach(() => {
     saveRawConfig({});
     fetchCalls.length = 0;
@@ -133,7 +133,7 @@ describe("PlatformPushAdapter", () => {
 
   test("skips a disabled chat reply without sending a native push", async () => {
     saveRawConfig({ notifications: { newMessageEnabled: false } });
-    const result = await new PlatformPushAdapter().send(
+    const result = await new CloudPushAdapter().send(
       makePayload({ sourceEventName: "chat.assistant_reply" }),
       makeDestination(),
     );
@@ -149,7 +149,7 @@ describe("PlatformPushAdapter", () => {
     onClientCreation = async () => {
       saveRawConfig({ notifications: { newMessageEnabled: false } });
     };
-    const result = await new PlatformPushAdapter().send(
+    const result = await new CloudPushAdapter().send(
       makePayload({ sourceEventName: "chat.assistant_reply" }),
       makeDestination(),
     );
@@ -172,7 +172,7 @@ describe("PlatformPushAdapter", () => {
       onRetrySleep = async () => {
         saveRawConfig({ notifications: { newMessageEnabled: false } });
       };
-      const result = await new PlatformPushAdapter().send(
+      const result = await new CloudPushAdapter().send(
         makePayload({ sourceEventName: "chat.assistant_reply" }),
         makeDestination(),
       );
@@ -196,7 +196,7 @@ describe("PlatformPushAdapter", () => {
     "keeps %s native push enabled when ordinary reply alerts are off",
     async (sourceEventName) => {
       saveRawConfig({ notifications: { newMessageEnabled: false } });
-      const result = await new PlatformPushAdapter().send(
+      const result = await new CloudPushAdapter().send(
         makePayload({ sourceEventName }),
         makeDestination(),
       );
@@ -206,11 +206,11 @@ describe("PlatformPushAdapter", () => {
   );
 
   test("channel is 'platform'", () => {
-    expect(new PlatformPushAdapter().channel).toBe("platform");
+    expect(new CloudPushAdapter().channel).toBe("platform");
   });
 
   test("POSTs to the correct dispatch endpoint with snake_case body", async () => {
-    const adapter = new PlatformPushAdapter();
+    const adapter = new CloudPushAdapter();
     const result = await adapter.send(makePayload(), makeDestination());
 
     expect(result.success).toBe(true);
@@ -232,7 +232,7 @@ describe("PlatformPushAdapter", () => {
   });
 
   test("sets target_guardian_principal_id for guardian-sensitive events", async () => {
-    const adapter = new PlatformPushAdapter();
+    const adapter = new CloudPushAdapter();
     const payload = makePayload({ sourceEventName: "guardian.question" });
     const destination = makeDestination({
       metadata: { guardianPrincipalId: "principal-xyz" },
@@ -249,7 +249,7 @@ describe("PlatformPushAdapter", () => {
   test.each(["chat.assistant_reply", "schedule.result", "activity.complete"])(
     "%s targets the resolved completion recipient",
     async (sourceEventName) => {
-      const adapter = new PlatformPushAdapter();
+      const adapter = new CloudPushAdapter();
       const result = await adapter.send(
         makePayload({
           sourceEventName,
@@ -275,7 +275,7 @@ describe("PlatformPushAdapter", () => {
   test.each([undefined, "  ", "other-principal"])(
     "does not send typed completion preview with unavailable recipient %s",
     async (guardianPrincipalId) => {
-      const adapter = new PlatformPushAdapter();
+      const adapter = new CloudPushAdapter();
       const result = await adapter.send(
         makePayload({
           sourceEventName: "activity.complete",
@@ -302,7 +302,7 @@ describe("PlatformPushAdapter", () => {
   test.each(["chat.assistant_reply", "schedule.result"])(
     "%s preserves owner-scoped push when recipient lookup is unavailable",
     async (sourceEventName) => {
-      const result = await new PlatformPushAdapter().send(
+      const result = await new CloudPushAdapter().send(
         makePayload({ sourceEventName }),
         makeDestination(),
       );
@@ -325,7 +325,7 @@ describe("PlatformPushAdapter", () => {
   ])(
     "malformed ownership %j never dispatches a mobile preview",
     async (completion) => {
-      const result = await new PlatformPushAdapter().send(
+      const result = await new CloudPushAdapter().send(
         makePayload({
           sourceEventName: "activity.complete",
           urgency: "high",
@@ -344,7 +344,7 @@ describe("PlatformPushAdapter", () => {
   );
 
   test("omits target_guardian_principal_id for non-guardian events even with principalId in metadata", async () => {
-    const adapter = new PlatformPushAdapter();
+    const adapter = new CloudPushAdapter();
     const payload = makePayload({ sourceEventName: "schedule.notify" });
     const destination = makeDestination({
       metadata: { guardianPrincipalId: "principal-xyz" },
@@ -358,7 +358,7 @@ describe("PlatformPushAdapter", () => {
 
   test("returns failure when platform client is unavailable", async () => {
     clientAvailable = false;
-    const adapter = new PlatformPushAdapter();
+    const adapter = new CloudPushAdapter();
     const result = await adapter.send(makePayload(), makeDestination());
 
     expect(result.success).toBe(false);
@@ -372,7 +372,7 @@ describe("PlatformPushAdapter", () => {
       { ok: false, status: 500, body: "internal error" },
       { ok: true, status: 200, body: "{}" },
     );
-    const adapter = new PlatformPushAdapter();
+    const adapter = new CloudPushAdapter();
     const result = await adapter.send(makePayload(), makeDestination());
 
     expect(result.success).toBe(true);
@@ -386,7 +386,7 @@ describe("PlatformPushAdapter", () => {
       { ok: false, status: 503, body: "unavailable" },
       { ok: false, status: 500, body: "still failing" },
     );
-    const adapter = new PlatformPushAdapter();
+    const adapter = new CloudPushAdapter();
     const result = await adapter.send(makePayload(), makeDestination());
 
     expect(result.success).toBe(false);
@@ -396,7 +396,7 @@ describe("PlatformPushAdapter", () => {
   });
 
   test("bounds every attempt with an abort signal", async () => {
-    const adapter = new PlatformPushAdapter();
+    const adapter = new CloudPushAdapter();
     const result = await adapter.send(makePayload(), makeDestination());
 
     expect(result.success).toBe(true);
@@ -409,7 +409,7 @@ describe("PlatformPushAdapter", () => {
     );
     fetchResponses.push({ ok: true, status: 200, body: '{"tokens_sent": 1}' });
 
-    const adapter = new PlatformPushAdapter();
+    const adapter = new CloudPushAdapter();
     const result = await adapter.send(makePayload(), makeDestination());
 
     expect(result.success).toBe(true);
@@ -419,7 +419,7 @@ describe("PlatformPushAdapter", () => {
 
   test("does not retry on 4xx responses", async () => {
     fetchResponses.push({ ok: false, status: 400, body: "bad request" });
-    const adapter = new PlatformPushAdapter();
+    const adapter = new CloudPushAdapter();
     const result = await adapter.send(makePayload(), makeDestination());
 
     expect(result.success).toBe(false);
@@ -433,7 +433,7 @@ describe("PlatformPushAdapter", () => {
       status: 200,
       body: '{"tokens_sent":2,"accepted_platforms":[]}',
     });
-    const adapter = new PlatformPushAdapter();
+    const adapter = new CloudPushAdapter();
     const result = await adapter.send(makePayload(), makeDestination());
 
     expect(result.success).toBe(true);
@@ -457,7 +457,7 @@ describe("PlatformPushAdapter", () => {
       },
     );
 
-    const result = await new PlatformPushAdapter().send(
+    const result = await new CloudPushAdapter().send(
       makePayload(),
       makeDestination(),
     );
@@ -472,7 +472,7 @@ describe("PlatformPushAdapter", () => {
       status: 202,
       body: '{"skipped": "flag_off"}',
     });
-    const adapter = new PlatformPushAdapter();
+    const adapter = new CloudPushAdapter();
     const result = await adapter.send(makePayload(), makeDestination());
 
     expect(result.success).toBe(true);
@@ -485,7 +485,7 @@ describe("PlatformPushAdapter", () => {
       status: 200,
       body: '{"idempotent": true, "tokens_sent": 0}',
     });
-    const adapter = new PlatformPushAdapter();
+    const adapter = new CloudPushAdapter();
     const result = await adapter.send(makePayload(), makeDestination());
 
     expect(result.success).toBe(true);
@@ -494,7 +494,7 @@ describe("PlatformPushAdapter", () => {
 
   test("reports remotePushAccepted: false when the success body is unparseable", async () => {
     fetchResponses.push({ ok: true, status: 200, body: "not json" });
-    const adapter = new PlatformPushAdapter();
+    const adapter = new CloudPushAdapter();
     const result = await adapter.send(makePayload(), makeDestination());
 
     expect(result.success).toBe(true);
@@ -503,16 +503,16 @@ describe("PlatformPushAdapter", () => {
 
   test("leaves remotePushAccepted unset on non-2xx failure", async () => {
     fetchResponses.push({ ok: false, status: 400, body: "bad request" });
-    const adapter = new PlatformPushAdapter();
+    const adapter = new CloudPushAdapter();
     const result = await adapter.send(makePayload(), makeDestination());
 
     expect(result.success).toBe(false);
     expect(result.remotePushAccepted).toBeUndefined();
   });
 
-  test("leaves remotePushAccepted unset when the platform client is unavailable", async () => {
+  test("leaves remotePushAccepted unset when the cloud client is unavailable", async () => {
     clientAvailable = false;
-    const adapter = new PlatformPushAdapter();
+    const adapter = new CloudPushAdapter();
     const result = await adapter.send(makePayload(), makeDestination());
 
     expect(result.success).toBe(false);
@@ -523,7 +523,7 @@ describe("PlatformPushAdapter", () => {
   // dispatch body reads as literal punctuation. See `stripMarkdownForPreview`.
   describe("markdown flattening", () => {
     test("flattens markdown out of the dispatched title and body", async () => {
-      const adapter = new PlatformPushAdapter();
+      const adapter = new CloudPushAdapter();
       const payload = makePayload({
         copy: {
           title: "**Build** finished",
@@ -556,7 +556,7 @@ describe("PlatformPushAdapter", () => {
     // Guardian question copy joins its question and instruction with a blank
     // line, and iOS renders the break, so flattening must not collapse it.
     test("preserves newlines in the dispatched body", async () => {
-      const adapter = new PlatformPushAdapter();
+      const adapter = new CloudPushAdapter();
       const payload = makePayload({
         copy: {
           title: "Question",
@@ -573,7 +573,7 @@ describe("PlatformPushAdapter", () => {
     });
 
     test("leaves plain prose untouched", async () => {
-      const adapter = new PlatformPushAdapter();
+      const adapter = new CloudPushAdapter();
       const result = await adapter.send(makePayload(), makeDestination());
 
       expect(result.success).toBe(true);
@@ -588,7 +588,7 @@ describe("PlatformPushAdapter", () => {
     // costs the whole notification.
     describe("copy that flattens to nothing", () => {
       test("names the media instead of dispatching blank fields", async () => {
-        const adapter = new PlatformPushAdapter();
+        const adapter = new CloudPushAdapter();
         const embed = "![clip](cadet://workspace/a.mp4)";
         const payload = makePayload({ copy: { title: embed, body: embed } });
 
@@ -600,7 +600,7 @@ describe("PlatformPushAdapter", () => {
       });
 
       test("counts several embeds", async () => {
-        const adapter = new PlatformPushAdapter();
+        const adapter = new CloudPushAdapter();
         const embeds =
           "![one](cadet://workspace/1.mp4) ![two](https://e.com/2.png)";
         const payload = makePayload({ copy: { title: embeds, body: embeds } });
@@ -613,7 +613,7 @@ describe("PlatformPushAdapter", () => {
       // Nothing nameable is left, so the original beats a blank field: ugly
       // copy still delivers, an empty title is a 400.
       test("keeps the original when there is no media to name", async () => {
-        const adapter = new PlatformPushAdapter();
+        const adapter = new CloudPushAdapter();
         const payload = makePayload({ copy: { title: "###", body: "###" } });
 
         await adapter.send(payload, makeDestination());
@@ -624,7 +624,7 @@ describe("PlatformPushAdapter", () => {
   });
 
   test("omits optional fields when absent from payload", async () => {
-    const adapter = new PlatformPushAdapter();
+    const adapter = new CloudPushAdapter();
     const payload: ChannelDeliveryPayload = {
       sourceEventName: "schedule.notify",
       copy: { title: "Hi", body: "Hello" },

package/src/__tests__/notification-deep-link.test.ts

@@ -4,7 +4,7 @@
  * Validates that the CadetAdapter broadcasts notification_intent with
  * deepLinkMetadata, and that the broadcaster correctly passes deepLinkTarget
  * from the decision through to the adapter payload — regardless of whether
- * the conversation was newly created or reused. Also covers the platform
+ * the conversation was newly created or reused. Also covers the cloud
  * (APNs) channel, whose deepLinkTarget must be enriched with the
  * conversationId so remote-push taps can navigate.
  */
@@ -691,14 +691,14 @@ describe("notification deep-link metadata", () => {
 
     // ── Platform (APNs) channel deep-link enrichment ──────────────────
     //
-    // The platform adapter forwards deepLinkTarget verbatim as
+    // The cloud adapter forwards deepLinkTarget verbatim as
     // deep_link_metadata, so the broadcaster must enrich it with the
     // conversationId the same way it does for cadet — otherwise remote-push
     // taps have no routing key and cannot navigate.
 
     test("broadcaster merges pairing conversationId and messageId into deepLinkTarget for platform", async () => {
-      const platformAdapter = new MockAdapter("platform");
-      const broadcaster = new NotificationBroadcaster([platformAdapter]);
+      const cloudAdapter = new MockAdapter("platform");
+      const broadcaster = new NotificationBroadcaster([cloudAdapter]);
 
       nextPairingResult = {
         conversationId: "conv-paired-platform",
@@ -718,16 +718,16 @@ describe("notification deep-link metadata", () => {
 
       await broadcaster.broadcastDecision(signal, decision);
 
-      expect(platformAdapter.sent).toHaveLength(1);
-      const deepLink = platformAdapter.sent[0].deepLinkTarget;
+      expect(cloudAdapter.sent).toHaveLength(1);
+      const deepLink = cloudAdapter.sent[0].deepLinkTarget;
       expect(deepLink).toBeDefined();
       expect(deepLink!.conversationId).toBe("conv-paired-platform");
       expect(deepLink!.messageId).toBe("msg-paired-platform");
     });
 
     test("platform deep link falls back to signal.sourceContextId when pairing returns no conversation", async () => {
-      const platformAdapter = new MockAdapter("platform");
-      const broadcaster = new NotificationBroadcaster([platformAdapter]);
+      const cloudAdapter = new MockAdapter("platform");
+      const broadcaster = new NotificationBroadcaster([cloudAdapter]);
 
       // Production platform pairing: push_only strategy pairs no conversation.
       nextPairingResult = {
@@ -751,15 +751,15 @@ describe("notification deep-link metadata", () => {
 
       await broadcaster.broadcastDecision(signal, decision);
 
-      expect(platformAdapter.sent).toHaveLength(1);
-      const deepLink = platformAdapter.sent[0].deepLinkTarget;
+      expect(cloudAdapter.sent).toHaveLength(1);
+      const deepLink = cloudAdapter.sent[0].deepLinkTarget;
       expect(deepLink).toBeDefined();
       expect(deepLink!.conversationId).toBe(originConvId);
     });
 
     test("platform deep link omits conversationId when sourceContextId is a sentinel", async () => {
-      const platformAdapter = new MockAdapter("platform");
-      const broadcaster = new NotificationBroadcaster([platformAdapter]);
+      const cloudAdapter = new MockAdapter("platform");
+      const broadcaster = new NotificationBroadcaster([cloudAdapter]);
 
       nextPairingResult = {
         conversationId: null,
@@ -779,22 +779,22 @@ describe("notification deep-link metadata", () => {
 
       await broadcaster.broadcastDecision(signal, decision);
 
-      expect(platformAdapter.sent).toHaveLength(1);
+      expect(cloudAdapter.sent).toHaveLength(1);
       expect(
-        platformAdapter.sent[0].deepLinkTarget?.conversationId,
+        cloudAdapter.sent[0].deepLinkTarget?.conversationId,
       ).toBeUndefined();
     });
 
     test("cadet and platform each receive deep-link enrichment in the same broadcast", async () => {
       const cadetAdapter = new MockAdapter("cadet");
-      const platformAdapter = new MockAdapter("platform");
+      const cloudAdapter = new MockAdapter("platform");
       const broadcaster = new NotificationBroadcaster([
         cadetAdapter,
-        platformAdapter,
+        cloudAdapter,
       ]);
 
       // Cadet is ordered first and consumes the queued pairing result;
-      // the platform pairing call then receives the mock's auto-generated
+      // the cloud pairing call then receives the mock's auto-generated
       // conversation, so each channel is enriched from its own pairing.
       nextPairingResult = {
         conversationId: "conv-cadet-paired",
@@ -822,26 +822,26 @@ describe("notification deep-link metadata", () => {
       );
 
       // Platform enriched independently from its own pairing call.
-      expect(platformAdapter.sent).toHaveLength(1);
+      expect(cloudAdapter.sent).toHaveLength(1);
       const platformConvId =
-        platformAdapter.sent[0].deepLinkTarget?.conversationId;
+        cloudAdapter.sent[0].deepLinkTarget?.conversationId;
       expect(String(platformConvId)).toStartWith("mock-conv-");
     });
 
-    // ── Cadet pairing carried into the platform deep link ─────────────
+    // ── Cadet pairing carried into the cloud deep link ─────────────
     //
-    // In production the platform channel is push_only: its own pairing
+    // In production the cloud channel is push_only: its own pairing
     // returns null. When the cadet channel creates (or reuses) a
-    // conversation in the same broadcast, the platform deep link must
+    // conversation in the same broadcast, the cloud deep link must
     // carry that conversation so remote-push taps land in the thread the
     // notification is about (approval requests, guardian questions).
 
     test("platform deep link carries the cadet-created conversation in a mixed broadcast", async () => {
       const cadetAdapter = new MockAdapter("cadet");
-      const platformAdapter = new MockAdapter("platform");
+      const cloudAdapter = new MockAdapter("platform");
       const broadcaster = new NotificationBroadcaster([
         cadetAdapter,
-        platformAdapter,
+        cloudAdapter,
       ]);
 
       pairingResultsByChannel = {
@@ -886,21 +886,21 @@ describe("notification deep-link metadata", () => {
       );
 
       // Platform carries the cadet-created conversation and seed message.
-      expect(platformAdapter.sent).toHaveLength(1);
-      expect(platformAdapter.sent[0].deepLinkTarget?.conversationId).toBe(
+      expect(cloudAdapter.sent).toHaveLength(1);
+      expect(cloudAdapter.sent[0].deepLinkTarget?.conversationId).toBe(
         "conv-cadet-created",
       );
-      expect(platformAdapter.sent[0].deepLinkTarget?.messageId).toBe(
+      expect(cloudAdapter.sent[0].deepLinkTarget?.messageId).toBe(
         "msg-cadet-seed",
       );
     });
 
     test("platform prefers the cadet pairing over the source-context fallback in a mixed broadcast", async () => {
       const cadetAdapter = new MockAdapter("cadet");
-      const platformAdapter = new MockAdapter("platform");
+      const cloudAdapter = new MockAdapter("platform");
       const broadcaster = new NotificationBroadcaster([
         cadetAdapter,
-        platformAdapter,
+        cloudAdapter,
       ]);
 
       pairingResultsByChannel = {
@@ -936,18 +936,18 @@ describe("notification deep-link metadata", () => {
 
       await broadcaster.broadcastDecision(signal, decision);
 
-      expect(platformAdapter.sent).toHaveLength(1);
-      expect(platformAdapter.sent[0].deepLinkTarget?.conversationId).toBe(
+      expect(cloudAdapter.sent).toHaveLength(1);
+      expect(cloudAdapter.sent[0].deepLinkTarget?.conversationId).toBe(
         "conv-approval-thread",
       );
     });
 
     test("platform deep link carries the conversation from a duplicate cadet delivery on retry", async () => {
       const cadetAdapter = new MockAdapter("cadet");
-      const platformAdapter = new MockAdapter("platform");
+      const cloudAdapter = new MockAdapter("platform");
       const broadcaster = new NotificationBroadcaster([
         cadetAdapter,
-        platformAdapter,
+        cloudAdapter,
       ]);
 
       // Persisted-decision retry: the cadet delivery row already exists
@@ -992,21 +992,21 @@ describe("notification deep-link metadata", () => {
       expect(cadetResult?.conversationId).toBe("conv-from-existing-row");
 
       // Platform still delivers, carrying the existing row's conversation.
-      expect(platformAdapter.sent).toHaveLength(1);
-      expect(platformAdapter.sent[0].deepLinkTarget?.conversationId).toBe(
+      expect(cloudAdapter.sent).toHaveLength(1);
+      expect(cloudAdapter.sent[0].deepLinkTarget?.conversationId).toBe(
         "conv-from-existing-row",
       );
-      expect(platformAdapter.sent[0].deepLinkTarget?.messageId).toBe(
+      expect(cloudAdapter.sent[0].deepLinkTarget?.messageId).toBe(
         "msg-from-existing-row",
       );
     });
 
     test("platform falls back to sourceContextId in a mixed broadcast when cadet pairs no conversation", async () => {
       const cadetAdapter = new MockAdapter("cadet");
-      const platformAdapter = new MockAdapter("platform");
+      const cloudAdapter = new MockAdapter("platform");
       const broadcaster = new NotificationBroadcaster([
         cadetAdapter,
-        platformAdapter,
+        cloudAdapter,
       ]);
 
       // Passive cadet signal: pairing skips conversation creation.
@@ -1041,8 +1041,8 @@ describe("notification deep-link metadata", () => {
 
       await broadcaster.broadcastDecision(signal, decision);
 
-      expect(platformAdapter.sent).toHaveLength(1);
-      expect(platformAdapter.sent[0].deepLinkTarget?.conversationId).toBe(
+      expect(cloudAdapter.sent).toHaveLength(1);
+      expect(cloudAdapter.sent[0].deepLinkTarget?.conversationId).toBe(
         originConvId,
       );
     });

package/src/__tests__/oauth-apps-routes.test.ts

@@ -47,7 +47,7 @@ mock.module("../oauth/oauth-store.js", () => ({
           logoUrl: null,
           clientIdPlaceholder: null,
           requiresClientSecret: 1,
-          managedServiceConfigKey: "google-oauth",
+          cloudServiceConfigKey: "google-oauth",
           authorizeUrl: "https://accounts.google.com/o/oauth2/v2/auth",
           tokenExchangeUrl: "https://oauth2.googleapis.com/token",
           refreshUrl: null,
@@ -168,7 +168,7 @@ describe("GET /v1/oauth/apps", () => {
         dashboard_url: string | null;
         client_id_placeholder: string | null;
         requires_client_secret: boolean;
-        supports_managed_mode: boolean;
+        supports_cloud_mode: boolean;
       } | null;
       apps: unknown[];
     };
@@ -179,7 +179,7 @@ describe("GET /v1/oauth/apps", () => {
     expect(result.provider!.description).toBe("Google OAuth provider");
     expect(result.provider!.requires_client_secret).toBe(true);
     expect(typeof result.provider!.requires_client_secret).toBe("boolean");
-    expect(result.provider!.supports_managed_mode).toBe(true);
+    expect(result.provider!.supports_cloud_mode).toBe(true);
   });
 
   test("returns null provider when provider does not exist", async () => {