@mmerterden/multi-agent-pipeline 8.6.1 → 10.0.6

package/pipeline/skills/shared/external/app-store-review/SKILL.md

@@ -1,16 +1,15 @@
 ---
 name: app-store-review
-description: "Prepare for App Store review and prevent rejections. Covers App Store review guidelines, app rejection reasons, code signing errors (ITMS-90035, ITMS-90034, ITMS-90046, ITMS-91065), provisioning profile issues, SDK signature requirements, entitlements mismatches, PrivacyInfo.xcprivacy privacy manifest requirements, required API reason codes, in-app purchase IAP and StoreKit rules, App Store Guidelines compliance, ATT App Tracking Transparency, EU DMA Digital Markets Act, HIG compliance checklist, app submission preparation, review preparation, metadata requirements, entitlements, widgets, and Live Activities review rules. Use when preparing for App Store submission, fixing rejection reasons, resolving code signing issues, fixing ITMS errors, auditing privacy manifests, implementing ATT consent flow, configuring StoreKit IAP, or checking HIG compliance."
+description: "Prepare for App Store review and prevent rejections. Covers App Store review guidelines, app rejection reasons, PrivacyInfo.xcprivacy privacy manifest requirements, required API reason codes, in-app purchase IAP and StoreKit rules, App Store Guidelines compliance, ATT App Tracking Transparency, EU DMA Digital Markets Act, HIG compliance checklist, app submission preparation, review preparation, metadata requirements, entitlements, widgets, and Live Activities review rules. Use when preparing for App Store submission, fixing rejection reasons, auditing privacy manifests, implementing ATT consent flow, configuring StoreKit IAP, or checking HIG compliance."
 ---
 
 # App Store Review Preparation
 
-Guidance for catching App Store rejection risks before submission. Apple reviewed 7.7 million submissions in 2024 and rejected 1.9 million. Most rejections are preventable with proper preparation.
+Guidance for catching App Store rejection risks before submission. Apple's May 2026 fraud-prevention update says App Review evaluated more than 9.1 million submissions in 2025 and rejected more than 2 million, so treat rejection prevention as a normal release-readiness step and re-check official Apple sources before quoting annual statistics.
 
 ## Contents
 
 - [Overview](#overview)
-- [Code Signing and SDK Signature Errors](#code-signing-and-sdk-signature-errors)
 - [Top Rejection Reasons and How to Avoid Them](#top-rejection-reasons-and-how-to-avoid-them)
 - [PrivacyInfo.xcprivacy -- Privacy Manifest Requirements](#privacyinfoxcprivacy-privacy-manifest-requirements)
 - [Data Use, Sharing, and Privacy Policy (Guideline 5.1.2)](#data-use-sharing-and-privacy-policy-guideline-512)
@@ -28,75 +27,21 @@ Guidance for catching App Store rejection risks before submission. Apple reviewe
 
 ## Overview
 
-Use this SKILL.md for quick guidance on common rejection reasons and key policies. Use the references for detailed checklists, privacy manifest specifics, and code signing troubleshooting.
+Use this SKILL.md for quick guidance on common rejection reasons and key policies. Use the references for detailed checklists and privacy manifest specifics.
 
-## Code Signing and SDK Signature Errors
+For prompts about keywords, screenshot captions, product-page metadata, or metadata rejection risk, answer from a compliance angle and explicitly defer keyword research, ranking strategy, conversion optimization, screenshot ordering, and A/B testing to `app-store-optimization`. Keep App Review metadata guidance limited to accuracy, field limits, misleading-content risk, and screenshot compliance. Always surface the rejection-prone format checks: app name 30 characters, subtitle 30 characters, keyword field 100 characters with comma-separated keywords and no spaces after commas, screenshots showing actual app UI, 6.9-inch iPhone screenshots as the primary current iPhone set, and 13-inch iPad screenshots when the app runs on iPad.
 
-Code signing issues are the most common **upload-time** rejection (before human review even starts). See `references/code-signing.md` for the full guide and `references/rejection-patterns.md` for high-risk patterns.
+For full submission readiness audits, separate blocking upload/review issues from ordinary cleanup. Treat Xcode 26+ with the relevant platform SDK 26+ as a blocking App Store Connect upload requirement after April 28, 2026. Cross-check privacy manifests, App Store privacy nutrition labels, privacy policy, ATT state, runtime network behavior, and SDK behavior against each other; the declarations and observed behavior must align.
 
-### ITMS-91065: Missing SDK Signature (Most Common in 2024+)
+### Blocking Submission Checks
 
-Apple now requires commonly used third-party SDK binaries to include a code signature. This is triggered when embedding unsigned `.framework` files.
+Escalate these as blockers before ordinary cleanup:
 
-**Error example:**
-```
-ITMS-91065: Missing signature - Your app includes "Frameworks/Toast.framework/Toast",
-which includes Toast, an SDK that was identified as a commonly used third-party SDK.
-```
-
-**Resolution options (in priority order):**
-
-1. **Replace binary with source files** — Add the SDK's source `.swift` files directly to your project instead of embedding the pre-built binary. No binary = no signature requirement. This is the most reliable fix.
-2. **Switch to SPM or source-based CocoaPods** — Source-level integration compiles the SDK as part of your project, eliminating the signature issue entirely.
-3. **Update SDK** — Get a newer version that includes Apple's required signature from the vendor.
-4. **Sign the framework manually** (last resort):
-   ```bash
-   codesign --force --sign "Apple Distribution: Your Company (TEAM_ID)" \
-     --preserve-metadata=identifier,entitlements \
-     Frameworks/SDKName.framework
-   ```
-
-**Prevention:** Before adding any binary dependency, verify it is signed:
-```bash
-codesign --verify --deep --strict NewSDK.framework
-```
-
-### ITMS-90035: Invalid Signature
-
-Binary signed with wrong certificate (development instead of distribution).
-
-**Fix:** Archive must use "Apple Distribution" certificate. Verify:
-```bash
-codesign -dv --verbose=4 YourApp.app
-# Authority line must show "Apple Distribution"
-```
-
-### ITMS-90046: Invalid Code Signing Entitlements
-
-App claims entitlements not in provisioning profile.
-
-**Fix:** Compare binary entitlements against profile:
-```bash
-# Binary entitlements
-codesign -d --entitlements - YourApp.app
-
-# Profile entitlements
-security cms -D -i YourApp.app/embedded.mobileprovision
-```
-
-Every entitlement in the binary MUST exist in the provisioning profile.
-
-### Quick Code Signing Checklist
-
-- [ ] Archive built with Release configuration + Apple Distribution certificate
-- [ ] All provisioning profiles are App Store type and not expired
-- [ ] All targets (app, extensions, widgets) use same team ID
-- [ ] Entitlements in binary match profile capabilities
-- [ ] No `get-task-allow` in Release builds (debug-only entitlement)
-- [ ] All embedded frameworks signed with same distribution identity
-- [ ] No simulator architectures (`x86_64`, `i386`) in embedded frameworks
-- [ ] Push environment is `production` (not `development`) in Release
-- [ ] Third-party binary SDKs are signed (ITMS-91065)
+- Uploads after April 28, 2026 that are not built with Xcode 26+ and the relevant platform SDK 26+
+- Privacy manifest, privacy label, privacy policy, ATT state, SDK transmissions, or audited runtime network behavior mismatches
+- Digital goods and subscriptions that bypass StoreKit IAP, or external purchase paths/links/buttons/CTAs for digital goods, unless current rules or approved entitlements allow them
+- Missing required screenshot sets: 6.9-inch iPhone screenshots, and 13-inch iPad screenshots when the app runs on iPad
+- Login-gated or non-obvious features without demo credentials, demo mode, and clear App Review notes
 
 ## Top Rejection Reasons and How to Avoid Them
 
@@ -134,36 +79,38 @@ Apple rejects apps that are too simple or are just websites in a wrapper:
 ### Guideline 2.5.1 -- Software Requirements
 
 - Must use public APIs only -- private API usage is an instant rejection
-- Must be built with the current Xcode GM release or later
-- Must support the latest two major iOS versions (guideline, not strict rule)
-- Must not download or execute code dynamically (except JavaScript in WKWebView)
+- As of April 28, 2026, uploads to App Store Connect must be built with Xcode 26 or later using the relevant platform SDK 26 or later
+- Deployment target support is a product and compatibility decision, not an App Review rule
+- Must not download or execute code that introduces or changes app features or functionality after review, except where Apple guidelines and agreements explicitly allow interpreted code
 
 ## PrivacyInfo.xcprivacy -- Privacy Manifest Requirements
 
-This is the fastest-growing rejection category (Guideline 5.1.1). A privacy manifest is **required** if your app or any of its dependencies uses certain categories of APIs.
+A privacy manifest is required when your app code, an executable, a dynamic library, or a third-party SDK uses Apple's required-reason API categories or declares collected data/tracking behavior.
 
-**See:** `references/privacy-manifest.md` for the full structure, reason codes, and checklists.
+**See:** [references/privacy-manifest.md](references/privacy-manifest.md) for the full structure, reason codes, and checklists.
 
 ### Summary
 
-- File timestamp, system boot time, disk space, user defaults, and active keyboard APIs all require reason codes.
-- Every third-party SDK must ship its own privacy manifest.
-- Manifest declarations must match App Store privacy nutrition labels and actual network behavior.
+- Required-reason API categories are file timestamps, system boot time, disk space, active keyboards, and UserDefaults; each requires an approved reason code when used.
+- Before final submission, re-check Apple's current required-reason API documentation and do not choose broad, convenient, or invented reason codes.
+- Required-reason API declarations belong in the bundle that contains the code using the API; every app target, executable, dynamic library, framework, or SDK bundle containing manifest-relevant code needs the matching manifest declarations.
+- Each SDK, executable, or dynamic library that collects data, uses required-reason APIs, enables data collection/tracking, or contacts tracking domains needs manifest attention in the bundle containing that code; SDK code cannot rely on the host app's manifest to report the SDK's own usage.
+- Manifest declarations must match App Store privacy nutrition labels, SDK behavior, and the app's presented functionality.
 
 ## Data Use, Sharing, and Privacy Policy (Guideline 5.1.2)
 
 - A privacy policy URL must be set in App Store Connect AND accessible within the app
 - The privacy policy must accurately describe what data you collect, how you use it, and who you share it with
 - App Store privacy nutrition labels must match your actual data collection practices
-- Apple cross-references your privacy manifest, nutrition labels, and observed network traffic
+- Privacy labels, privacy manifests, SDK disclosures, and runtime behavior should tell the same story
 
 ## In-App Purchase and StoreKit Rules (Guideline 3.1.1)
 
 IAP rules are strict and heavily enforced.
 
-### What Requires Apple IAP
+### What Generally Requires Apple IAP
 
-All digital content and services must use Apple's In-App Purchase system:
+Digital content, features, subscriptions, and services unlocked in the app generally must use Apple's In-App Purchase system unless a specific App Review guideline exception, regional rule, or approved entitlement applies. Remove external purchase paths unless the current rules or an approved entitlement allow them:
 
 - Premium features or content unlocks
 - Subscriptions to app functionality
@@ -181,8 +128,8 @@ All digital content and services must use Apple's In-App Purchase system:
 ### Subscription Display Requirements
 
 - Price, duration, and auto-renewal terms must be clearly displayed before purchase
-- Free trials must state what happens when they end (price, billing frequency)
-- No links, buttons, or language directing users to purchase outside the app
+- Free trials must clearly show trial duration, post-trial price, billing frequency, auto-renewal, and cancellation terms before purchase
+- Remove external purchase links, buttons, calls to action, or purchase paths for digital goods unless the current storefront rules or an approved entitlement explicitly allow them
 - "Reader" apps (Netflix, Spotify) may link to external sign-up but cannot offer IAP bypass
 
 ### StoreKit Implementation Checklist
@@ -194,7 +141,7 @@ All digital content and services must use Apple's In-App Purchase system:
 
 ## HIG Compliance Checklist
 
-See `references/review-checklists.md` for the full HIG checklist (navigation, modals, widgets, system feature support, launch screen, empty states). This section stays intentionally brief to keep SKILL.md concise.
+See [references/review-checklists.md](references/review-checklists.md) for the full HIG checklist (navigation, modals, widgets, system feature support, launch screen, empty states). This section stays intentionally brief to keep SKILL.md concise.
 
 ## App Tracking Transparency (ATT)
 
@@ -202,8 +149,8 @@ See `references/review-checklists.md` for the full HIG checklist (navigation, mo
 
 If your app tracks users across other companies' apps or websites, you must:
 
-1. Request permission via `ATTrackingManager.requestTrackingAuthorization` before any tracking occurs
-2. Respect the user's choice -- do not track if the user denies permission
+1. Request permission via `ATTrackingManager.requestTrackingAuthorization` before any cross-app or cross-website tracking occurs, including tracking-capable SDK behavior
+2. Respect the user's choice -- disable cross-app and cross-website tracking if the user denies permission
 3. Not gate app functionality behind tracking consent ("Accept tracking or you cannot use this app" is rejected)
 4. Provide a clear purpose string in `NSUserTrackingUsageDescription` explaining what tracking is used for
 
@@ -216,6 +163,7 @@ If you do not track users across apps or websites, do not show the ATT prompt. A
 ```swift
 import AppTrackingTransparency
 
+@MainActor
 func requestTrackingPermission() async {
     let status = await ATTrackingManager.requestTrackingAuthorization()
     switch status {
@@ -223,7 +171,7 @@ func requestTrackingPermission() async {
         // Enable tracking, initialize ad SDKs with tracking
         break
     case .denied, .restricted:
-        // Use non-personalized ads, disable cross-app tracking
+        // Use non-personalized ads and disable cross-app/cross-website tracking
         break
     case .notDetermined:
         // Should not happen after request, handle gracefully
@@ -234,11 +182,11 @@ func requestTrackingPermission() async {
 }
 ```
 
-**Timing:** Request ATT permission after the app has launched and the user has context for why tracking is being requested. Do not show the prompt immediately on first launch.
+**Timing:** Request ATT permission after the app is active and the user has context for why tracking is being requested. Do not show the prompt immediately on first launch or stack it with another system permission prompt.
 
 ## EU Digital Markets Act (DMA) Considerations
 
-For apps distributed in the EU:
+For apps distributed in the EU, and for other region-specific distribution models as Apple updates them:
 
 - Alternative browser engines are permitted on iOS in the EU
 - Alternative app marketplaces exist -- apps may be distributed outside the App Store
@@ -286,8 +234,8 @@ Apple rejects vague usage descriptions. Always state what the data is used for i
 1. **Archive in Xcode.** Product > Archive (requires a Distribution signing identity). Verify the archive builds clean with zero warnings in Release configuration.
 2. **Upload to App Store Connect.** Use the Organizer window (Distribute App > App Store Connect) or `xcodebuild -exportArchive`. Automated uploads via `altool` or Transporter also work.
 3. **TestFlight internal testing.** The build is available to internal testers (your team) within minutes of processing. Walk through every screen and flow on at least two device sizes.
-4. **TestFlight external testing.** External groups require a brief Beta App Review (usually < 24 hours). Use this to validate with real users before full submission.
-5. **Submit for App Review.** In App Store Connect, select the build, fill in all metadata fields, attach screenshots, and click Submit for Review. Average review time is under 24 hours, but allow 48 hours.
+4. **TestFlight external testing.** External groups require Beta App Review before first external distribution. Use this to validate with real users before full submission.
+5. **Submit for App Review.** In App Store Connect, select the build, fill in all metadata fields, attach screenshots, and click Submit for Review. Review timing varies; allow buffer for rejections, appeals, and metadata fixes.
 
 ### Expedited Review Requests
 
@@ -328,20 +276,20 @@ Users who manually check for updates in the App Store will receive the update im
 
 ### Screenshot Requirements
 
-- Provide screenshots for every required device size (6.9", 6.7", 6.5", 5.5" for iPhone; 13" for iPad if supporting iPad).
+- Provide 1-10 screenshots per required platform and localization.
+- For iPhone, use the current App Store Connect screenshot specifications. As of May 2026, 6.9-inch iPhone screenshots are the primary accepted iPhone set; 6.5-inch screenshots are required only when 6.9-inch screenshots are not provided, and smaller iPhone displays can use scaled screenshots from larger sets.
+- For iPad apps, 13-inch iPad screenshots are required; smaller iPad displays can use scaled screenshots from larger sets.
 - Screenshots must show the **actual app UI** -- no misleading content, no features that do not exist.
 - Text overlays and marketing frames are allowed but must not obscure or misrepresent the actual interface.
-- Up to 10 screenshots per localization. Lead with your most compelling screen.
+- Up to 10 screenshots per localization.
 - Screenshots for different localizations should show localized UI.
 
-### Keywords Optimization
+### Keyword Field Compliance
 
 - 100-character limit, comma-separated, no spaces after commas.
 - Do not duplicate words already in your app name or subtitle (Apple indexes those automatically).
 - Use singular or plural, not both ("game" not "game,games").
 - No competitor names, trademarked terms, or irrelevant words.
-- Place highest-value keywords first.
-- Update keywords with each release based on Search Ads and analytics data.
 
 ### App Preview Videos
 
@@ -349,7 +297,7 @@ Users who manually check for updates in the App Store will receive the update im
 - Up to 3 preview videos per localization.
 - Must show the actual app running on device -- no pre-rendered animations of features that look different in practice.
 - App audio is captured; narration and background music are optional.
-- No device frames or hands unless showing real device interaction.
+- Avoid any framing, hand footage, or visual treatment that makes the preview misleading about the actual app experience.
 - First frame is used as the poster frame on the product page (choose carefully).
 
 ## Appeal Process
@@ -384,28 +332,30 @@ If the Resolution Center exchange does not resolve the issue:
 ## Common Mistakes
 
 1. **Missing demo credentials.** Provide App Review login credentials in App Store Connect notes. Most Guideline 2.1 rejections are from reviewers unable to test behind a login.
-2. **Privacy manifest mismatch.** Declared data collection in PrivacyInfo.xcprivacy must match App Store privacy nutrition labels and actual network traffic.
+2. **Privacy manifest mismatch.** Declared data collection in PrivacyInfo.xcprivacy must match App Store privacy nutrition labels, SDK behavior, and app functionality.
 3. **Unnecessary ATT prompt.** Do not show the App Tracking Transparency prompt unless you actually track users across apps or websites. Apple rejects unnecessary prompts.
 4. **Vague usage descriptions.** "This app needs your location" is rejected. State the specific feature that uses the data.
-5. **External payment links for digital content.** Any language or button directing users to purchase digital content outside the app is rejected.
-6. **Missing concurrency annotations.** Ensure ATT request and StoreKit calls run on `@MainActor` or appropriate actor context. Mark shared state types as `Sendable` for Swift 6 concurrency safety.
+5. **Unapproved external purchase paths.** External payment links for digital goods are region- and entitlement-sensitive; do not add them without checking current Guideline 3.1.1(a) rules.
+6. **Treating code quality as review compliance.** Swift 6 concurrency annotations and StoreKit transaction handling matter, but they do not replace privacy, payment, metadata, and entitlement compliance checks.
 
 ## Review Checklist
 
-Quick-check before every submission (full version in `references/review-checklists.md`):
+Quick-check before every submission (full version in [references/review-checklists.md](references/review-checklists.md)):
 
 - [ ] No placeholder/test content; all features functional; demo credentials provided
-- [ ] App name matches functionality; screenshots are real; no prices in description
-- [ ] PrivacyInfo.xcprivacy present with reason codes; nutrition labels match reality
+- [ ] App name matches functionality; screenshots are real; no prices in description; 6.9-inch iPhone and 13-inch iPad screenshots supplied when applicable
+- [ ] PrivacyInfo.xcprivacy present when required-reason APIs, tracking, collected data declarations, or SDK tracking domains apply; nutrition labels match reality
 - [ ] Privacy policy URL set and accessible in-app
-- [ ] Digital content uses IAP; subscription terms visible; restore purchases works
+- [ ] Digital content uses IAP; subscription terms visible; restore purchases works; external purchase links/buttons/CTAs removed unless current rules or approved entitlements allow them
 - [ ] Dark Mode and Dynamic Type supported; standard navigation patterns
-- [ ] Built with current Xcode GM; no private APIs; entitlements justified
-- [ ] ATT prompt only if cross-app tracking occurs
+- [ ] Built with Xcode 26+ and platform SDK 26+ for uploads after April 28, 2026; no private APIs; entitlements justified
+- [ ] ATT prompt only if cross-app or cross-website tracking occurs
 
 ## References
 
-- Review checklists: `references/review-checklists.md`
-- Privacy manifest guide: `references/privacy-manifest.md`
-- Code signing guide: `references/code-signing.md`
-- High-risk rejection patterns: `references/rejection-patterns.md`
+- Review checklists: [references/review-checklists.md](references/review-checklists.md)
+- Privacy manifest guide: [references/privacy-manifest.md](references/privacy-manifest.md)
+- Apple App Review Guidelines: https://developer.apple.com/app-store/review/guidelines/
+- Apple upcoming SDK requirements: https://developer.apple.com/news/upcoming-requirements/
+- App Store Connect screenshot specifications: https://developer.apple.com/help/app-store-connect/reference/app-information/screenshot-specifications/
+- Sosumi required-reason API docs: https://sosumi.ai/documentation/bundleresources/describing-use-of-required-reason-api

package/pipeline/skills/shared/external/app-store-review/evals/evals.json

@@ -0,0 +1,44 @@
+{
+  "skill_name": "app-store-review",
+  "evals": [
+    {
+      "id": 1,
+      "prompt": "Audit this iOS app's App Store submission readiness: it has subscriptions, a third-party analytics SDK, ads that may track users across apps, iPhone and iPad support, and a PrivacyInfo.xcprivacy file that only declares UserDefaults with CA92.1. Give the highest-risk rejection issues and the exact checks the team should run before upload.",
+      "expected_output": "A source-grounded App Review readiness audit covering IAP/subscription display, ATT, privacy manifests and SDK manifests, Xcode/SDK upload requirements, screenshot requirements, metadata, and reviewer access.",
+      "files": [],
+      "expectations": [
+        "Mentions that uploads after April 28, 2026 need Xcode 26 or later with the relevant platform SDK 26 or later.",
+        "Identifies that tracking across apps or websites requires ATT, NSUserTrackingUsageDescription, and no tracking before authorization.",
+        "Checks whether third-party SDK code that collects data, uses required-reason APIs, enables data collection, or contacts tracking domains has its own privacy manifest.",
+        "Warns that digital subscriptions generally require StoreKit IAP and visible subscription terms, restore purchases, and no external purchase path unless current rules or entitlements allow it.",
+        "Includes iPhone 6.9-inch and iPad 13-inch screenshot requirements for a universal iPhone/iPad app."
+      ]
+    },
+    {
+      "id": 2,
+      "prompt": "Review this proposed PrivacyInfo.xcprivacy plan: the app uses UserDefaults for settings, checks free disk space before downloading offline videos, reads file modification dates for files picked through UIDocumentPickerViewController, and includes an SDK that wraps UserDefaults for the app. Which required-reason API categories and reason codes should be declared, and where should the app versus SDK declarations live?",
+      "expected_output": "A privacy-manifest reason-code review that selects current approved reason codes and correctly separates app manifest declarations from SDK manifest declarations.",
+      "files": [],
+      "expectations": [
+        "Selects NSPrivacyAccessedAPICategoryUserDefaults with CA92.1 for app-owned UserDefaults settings.",
+        "Selects NSPrivacyAccessedAPICategoryDiskSpace with E174.1 for checking free space before downloads.",
+        "Selects NSPrivacyAccessedAPICategoryFileTimestamp with 3B52.1 for user-granted document picker files.",
+        "Selects UserDefaults wrapper SDK reason C56D.1 for the SDK only and says the SDK must report its own required-reason API use in its own manifest.",
+        "Warns not to invent broad reasons and to re-check Apple's current required-reason API documentation."
+      ]
+    },
+    {
+      "id": 3,
+      "prompt": "I want better App Store keywords and screenshot captions for my habit tracker, but I also don't want a metadata rejection. Give me the compliance guardrails only, and call out which parts belong in an ASO strategy pass rather than an App Review pass.",
+      "expected_output": "A boundary-aware answer that keeps app-store-review focused on metadata compliance and routes keyword strategy and conversion optimization to the ASO skill.",
+      "files": [],
+      "expectations": [
+        "States that keyword research, ranking strategy, and conversion optimization belong to an ASO strategy pass rather than App Review compliance.",
+        "Gives App Review metadata guardrails: accurate app name, screenshots showing real UI, no misleading features, no prices in description, no competitor names or irrelevant keywords.",
+        "Mentions the 30-character app name/subtitle limits and 100-character keyword field limit with comma-separated keywords and no spaces after commas.",
+        "Mentions current screenshot size compliance, including 6.9-inch iPhone and 13-inch iPad requirements when applicable.",
+        "Does not expand into a full keyword plan or marketing copy rewrite."
+      ]
+    }
+  ]
+}

package/pipeline/skills/shared/external/app-store-review/references/privacy-manifest.md

@@ -7,6 +7,7 @@
 - Privacy Manifest Keys Reference
 - Third-Party SDK Manifests
 - Collected Data Types Declaration
+- Sources To Re-Check
 
 ## When a Privacy Manifest Is Required
 
@@ -15,9 +16,11 @@ A `PrivacyInfo.xcprivacy` file is required if your app or any dependency uses th
 - File timestamp APIs (`NSPrivacyAccessedAPICategoryFileTimestamp`)
 - System boot time APIs (`NSPrivacyAccessedAPICategorySystemBootTime`)
 - Disk space APIs (`NSPrivacyAccessedAPICategoryDiskSpace`)
-- User defaults (`NSPrivacyAccessedAPICategoryUserDefaults`) when storing user-identifiable data
+- User defaults (`NSPrivacyAccessedAPICategoryUserDefaults`)
 - Active keyboard APIs (`NSPrivacyAccessedAPICategoryActiveKeyboards`)
 
+Apple updates required-reason API coverage over time. Before final submission or release, re-check the current `NSPrivacyAccessedAPIType` and `NSPrivacyAccessedAPITypeReasons` documentation and do not invent broad or convenient reasons.
+
 ## Privacy Manifest Structure
 
 ```xml
@@ -52,16 +55,29 @@ A `PrivacyInfo.xcprivacy` file is required if your app or any dependency uses th
 
 ## Required API Reason Codes
 
+Use the exact approved reason that matches the app or SDK behavior. Do not use a broad reason code because it is convenient; Apple requires the declared reason to match the presented functionality and derived-data use.
+
+Before final submission, re-check Apple's current required-reason API documentation. Reason-code coverage can change, and invented or overly broad reasons are not acceptable.
+
 | API Category | Code | Reason |
 |---|---|---|
-| FileTimestamp | `C617.1` | Access files inside app container |
-| FileTimestamp | `3B52.1` | Access user-selected files |
-| FileTimestamp | `0A2A.1` | Third-party SDK accessed on behalf of user |
+| FileTimestamp | `DDA9.1` | Display file timestamps to the person using the device |
+| FileTimestamp | `C617.1` | Access timestamps, size, or metadata for files in the app, app group, or CloudKit container |
+| FileTimestamp | `3B52.1` | Access timestamps, size, or metadata for user-granted files or directories |
+| FileTimestamp | `0A2A.1` | Third-party SDK wrapper around file timestamp APIs, only when called by the app |
 | SystemBootTime | `35F9.1` | Measure elapsed time between events |
-| DiskSpace | `E174.1` | Check available space before writes |
-| UserDefaults | `CA92.1` | Access within your own app |
-| UserDefaults | `1C8F.1` | Access within same app group |
-| ActiveKeyboards | `3EC4.1` | Customize UI based on active keyboards |
+| SystemBootTime | `8FFB.1` | Calculate absolute timestamps for events that occurred within the app |
+| SystemBootTime | `3D61.1` | Include system boot time in an optional user-submitted bug report |
+| DiskSpace | `85F4.1` | Display disk space information to the person using the device |
+| DiskSpace | `E174.1` | Check available or low disk space before writes or cleanup |
+| DiskSpace | `7D9E.1` | Include disk space information in an optional user-submitted bug report |
+| DiskSpace | `B728.1` | Health research app detects low disk space impacting research data collection |
+| ActiveKeyboards | `3EC4.1` | Custom keyboard app checks active keyboards |
+| ActiveKeyboards | `54BD.1` | Present UI that visibly changes based on active keyboards |
+| UserDefaults | `CA92.1` | Read/write information accessible only to the app itself |
+| UserDefaults | `1C8F.1` | Read/write information accessible only within the same App Group |
+| UserDefaults | `C56D.1` | Third-party SDK wrapper around UserDefaults APIs, only when called by the app |
+| UserDefaults | `AC6B.1` | Managed app configuration or managed feedback keys for MDM |
 
 ## Privacy Manifest Keys Reference
 
@@ -74,9 +90,10 @@ A `PrivacyInfo.xcprivacy` file is required if your app or any dependency uses th
 
 ## Third-Party SDK Manifests
 
-- Verify each SDK contains `PrivacyInfo.xcprivacy` in its bundle
-- Ensure SDK reason codes match actual usage
-- Update SDK versions when manifests are missing
+- Verify each SDK, executable, or dynamic library that uses required-reason APIs includes `PrivacyInfo.xcprivacy` in the bundle containing that code
+- Ensure SDK reason codes match actual SDK usage; an SDK cannot rely on the host app's manifest to report the SDK's own required-reason API use
+- Update SDK versions when required manifests or reason declarations are missing
+- Keep the app's manifest focused on app code and app-level collected data/tracking declarations
 
 ## Collected Data Types Declaration
 
@@ -87,4 +104,10 @@ Each `NSPrivacyCollectedDataTypes` entry must specify:
 - `NSPrivacyCollectedDataTypeTracking` (used for tracking)
 - `NSPrivacyCollectedDataTypePurposes` (purposes array)
 
-Apple cross-references manifests with privacy nutrition labels and network traffic. Mismatches cause rejection.
+Keep manifests, privacy nutrition labels, SDK behavior, and app functionality consistent. Mismatches cause rejection.
+
+## Sources To Re-Check
+
+- Required-reason API overview: https://sosumi.ai/documentation/bundleresources/describing-use-of-required-reason-api
+- Required-reason API categories: https://sosumi.ai/documentation/bundleresources/app-privacy-configuration/nsprivacyaccessedapitypes/nsprivacyaccessedapitype
+- Required-reason codes: https://sosumi.ai/documentation/bundleresources/app-privacy-configuration/nsprivacyaccessedapitypes/nsprivacyaccessedapitypereasons

package/pipeline/skills/shared/external/app-store-review/references/review-checklists.md

@@ -4,6 +4,7 @@
 - App Review Information Checklist
 - Privacy Manifest Checklist
 - In-App Purchase Checklist
+- Screenshot and App Preview Checklist
 - HIG Compliance Checklist
 - Pre-Submission Checklist
 
@@ -12,7 +13,9 @@
 Use this to avoid Guideline 2.1 rejections:
 
 - [ ] Demo credentials provided in App Review Information notes (if login required)
+- [ ] Demo mode available if credentials are impractical or account state is hard to reproduce
 - [ ] Demo account works and has access to all features
+- [ ] App Review notes explain login-gated, role-gated, region-gated, hardware-gated, or otherwise non-obvious features
 - [ ] All screens have real content (no placeholders or Lorem Ipsum)
 - [ ] No broken links or dead-end flows
 - [ ] All hardware-required features have fallback or reviewer instructions
@@ -21,20 +24,31 @@ Use this to avoid Guideline 2.1 rejections:
 
 Verify PrivacyInfo.xcprivacy completeness:
 
-- [ ] `PrivacyInfo.xcprivacy` exists in app bundle
-- [ ] All required API categories are declared with reason codes
+- [ ] `PrivacyInfo.xcprivacy` exists where app code, SDK code, executables, or dynamic libraries need it
+- [ ] All required-reason API categories in app and bundled SDK code are declared with approved reason codes
 - [ ] `NSPrivacyTracking` is true only if tracking occurs
-- [ ] Third-party SDK manifests present and up to date
+- [ ] Third-party SDK manifests present and up to date when SDKs collect data, use required-reason APIs, enable data collection, or contact tracking domains
 - [ ] Privacy nutrition labels match actual data collection
+- [ ] Audit runtime network traffic and SDK transmissions; observed behavior must match privacy labels, manifests, privacy policy, and ATT state
 
 ## In-App Purchase Checklist
 
-- [ ] All digital goods use StoreKit IAP
-- [ ] Subscription pricing and auto-renewal terms shown before purchase
+- [ ] Digital goods and subscriptions use StoreKit IAP unless current storefront rules or approved entitlements allow otherwise
+- [ ] Subscription price, duration, billing frequency, auto-renewal terms, and any trial duration/post-trial price shown before purchase
 - [ ] Restore purchases button present and functional
+- [ ] No external purchase path, link, button, or call to action for digital goods unless current rules or approved entitlements allow it
 - [ ] Ask-to-buy and interrupted purchases handled
 - [ ] Transaction verification uses StoreKit 2 or server-side verification
 
+## Screenshot and App Preview Checklist
+
+- [ ] 1-10 screenshots uploaded for each required platform and localization
+- [ ] iPhone screenshots use current App Store Connect accepted sizes; 6.9-inch iPhone screenshots are the primary set as of May 2026
+- [ ] 6.5-inch iPhone screenshots provided only when 6.9-inch iPhone screenshots are not provided or when manually optimizing that fallback
+- [ ] 13-inch iPad screenshots provided if the app runs on iPad
+- [ ] Screenshots and preview videos show actual app UI and do not misrepresent unavailable features
+- [ ] App previews are 30 seconds or shorter, with a poster frame that works without autoplay
+
 ## HIG Compliance Checklist
 
 ### Navigation
@@ -66,26 +80,26 @@ Verify PrivacyInfo.xcprivacy completeness:
 ### Completeness
 - [ ] No placeholder or test content
 - [ ] All features functional without special hardware
-- [ ] Demo credentials provided
+- [ ] Demo credentials or demo mode provided, with App Review notes for gated or non-obvious features
 - [ ] No dead-end screens
 
 ### Metadata
 - [ ] App name matches functionality
-- [ ] Screenshots are real app screenshots
+- [ ] Screenshots are real app screenshots using current required platform sizes, including 6.9-inch iPhone and 13-inch iPad when applicable
 - [ ] Description contains no prices or competitor mentions
 - [ ] Category is correct
 
 ### Privacy
-- [ ] Privacy manifest present with required reason codes
+- [ ] Privacy manifest present where required, with approved reason codes
 - [ ] Third-party SDK manifests verified
 - [ ] Privacy policy URL present and accessible
-- [ ] Nutrition labels match actual data collection
+- [ ] Audit runtime network traffic and SDK transmissions; nutrition labels, privacy manifest declarations, privacy policy, and observed behavior match actual data collection
 - [ ] ATT prompt only if tracking occurs
 
 ### Payments
-- [ ] Digital content uses IAP
-- [ ] Subscription terms visible before purchase
-- [ ] No external payment links
+- [ ] Digital content uses StoreKit IAP unless current rules or approved entitlements allow otherwise
+- [ ] Subscription price, duration, billing frequency, auto-renewal terms, and any trial duration/post-trial price visible before purchase
+- [ ] No external purchase paths, payment links, buttons, or calls to action unless current storefront rules or approved entitlements allow them
 - [ ] Free trial terms clear
 - [ ] Restore purchases implemented
 
@@ -98,21 +112,9 @@ Verify PrivacyInfo.xcprivacy completeness:
 - [ ] Empty states provide guidance
 
 ### Technical
-- [ ] Built with current Xcode GM
+- [ ] Built with Xcode 26 or later and relevant platform SDK 26 or later for uploads after April 28, 2026
 - [ ] No private API usage
 - [ ] No dynamic code execution
 - [ ] Entitlements justified with usage descriptions
 - [ ] Background modes justified and used
-- [ ] Minimum deployment target covers latest two major iOS versions
-
-### Code Signing
-- [ ] Archive uses Apple Distribution certificate (not Development)
-- [ ] All provisioning profiles are App Store type and not expired
-- [ ] All targets use same team ID
-- [ ] Binary entitlements match provisioning profile capabilities
-- [ ] No `get-task-allow` entitlement in Release build
-- [ ] All embedded frameworks signed with distribution identity
-- [ ] No simulator architectures in embedded frameworks
-- [ ] Push environment is `production` in Release
-- [ ] Third-party binary SDKs are signed (ITMS-91065)
-- [ ] `codesign --verify --deep --strict` passes on app bundle
+- [ ] Deployment target is intentionally chosen and tested