@mmerterden/multi-agent-pipeline 8.6.1 → 10.0.6

package/pipeline/skills/figma-common/figma-validate/SKILL.md

@@ -8,14 +8,14 @@ status: wip-v5
 sourced-from: upstream/figma-validate
 ---
 
-# /figma-validate — Pre-Implementation Component Validation
+# /figma-validate  -  Pre-Implementation Component Validation
 
 ## Purpose
 
 Validates whether a Figma component is ready for the figma-to-swiftui implementation pipeline.
 Runs 6 criteria checks and returns a verdict: **VALID**, **CONDITIONAL**, or **INVALID**.
 
-This is a **read-only diagnostic skill** — it does NOT modify any files.
+This is a **read-only diagnostic skill**  -  it does NOT modify any files.
 
 ## Parameters
 
@@ -80,8 +80,8 @@ gh issue view <N> --repo ${GH_REPO} --json number,title,body
 ```
 
 Extract from the issue body:
-- **Figma URL** — from the line after `### Figma URL` heading
-- **Component Name** — from `### Component Name (PascalCase)` section (informational)
+- **Figma URL**  -  from the line after `### Figma URL` heading
+- **Component Name**  -  from `### Component Name (PascalCase)` section (informational)
 
 ```python
 import json, re
@@ -117,7 +117,7 @@ Seven criteria are checked. Each returns ✅ (pass) or ❌ (fail) with a reason.
 
 ---
 
-### Criterion 1 — Component Registry Presence
+### Criterion 1  -  Component Registry Presence
 
 **Question:** Component registry'de (`component-registry.json`) yer alıyor mu?
 
@@ -131,9 +131,9 @@ Also check `excludePatterns` in `$REGISTRY_CONFIG`:
 - If the component's `pageName` or `sectionName` matches an exclude pattern → ❌ FAIL. Reason: "Component is in an excluded page: {pageName}."
 
 **Known valid file keys** (from registry config):
-- `ps4xrJzhn7WNbfkZs895Bi` — Design System Core
-- `9ipBvrtsq9HlQ175B9k0wx` — Mobile App Components
-- `YSs4g0EeGAW53haB0zz5sa` — Visual Assets
+- `ps4xrJzhn7WNbfkZs895Bi`  -  Design System Core
+- `9ipBvrtsq9HlQ175B9k0wx`  -  Mobile App Components
+- `YSs4g0EeGAW53haB0zz5sa`  -  Visual Assets
 
 If the URL's `fileKey` does not match any of these → ❌ FAIL. Reason: "Unknown Figma file. Only Design System Core, Mobile App Components, and Visual Assets are supported."
 
@@ -141,7 +141,7 @@ If the URL's `fileKey` does not match any of these → ❌ FAIL. Reason: "Unknow
 
 ---
 
-### Criterion 2 — Figma Property Structure & Code Connect Strategy
+### Criterion 2  -  Figma Property Structure & Code Connect Strategy
 
 **Question:** Uygulanabilir bir Code Connect stratejisi var mı?
 
@@ -149,7 +149,7 @@ If the URL's `fileKey` does not match any of these → ❌ FAIL. Reason: "Unknow
 
 1. Fetch component data via Figma REST API:
    ```python
-   # Use python3 urllib.request — curl may be blocked by policy
+   # Use python3 urllib.request  -  curl may be blocked by policy
    import subprocess, urllib.request, json
    token = subprocess.check_output(
        ["security", "find-generic-password", "-s", "FIGMA_ACCESS_TOKEN", "-w"],
@@ -177,32 +177,32 @@ If the URL's `fileKey` does not match any of these → ❌ FAIL. Reason: "Unknow
 | `COMPONENT` | 0 properties | STATIC_VALUES | ✅ PASS |
 | `COMPONENT` | N/A | STATIC_VALUES | ✅ PASS |
 
-**Pass Condition:** Component has a valid Code Connect strategy — either property mapping (for COMPONENT_SET with ≥1 property) or STATIC_VALUES (for plain COMPONENT).
+**Pass Condition:** Component has a valid Code Connect strategy  -  either property mapping (for COMPONENT_SET with ≥1 property) or STATIC_VALUES (for plain COMPONENT).
 
 **Output:** Always report the detected strategy in the result:
-- `✅ STATIC_VALUES — plain COMPONENT, no variant properties (uses static preview in .figma.swift)`
-- `✅ Property Mapping — 3 enum, 1 string, 2 bool`
-- `❌ COMPONENT_SET with 0 properties — unexpected, needs design review`
+- `✅ STATIC_VALUES  -  plain COMPONENT, no variant properties (uses static preview in .figma.swift)`
+- `✅ Property Mapping  -  3 enum, 1 string, 2 bool`
+- `❌ COMPONENT_SET with 0 properties  -  unexpected, needs design review`
 
 **Warning Flags** (informational, not failures):
-- Property named `"Property 1"` → flag as `UNNAMED_PROPERTY`: "Unnamed property detected — design team should rename."
+- Property named `"Property 1"` → flag as `UNNAMED_PROPERTY`: "Unnamed property detected  -  design team should rename."
 - Property values with likely typos (e.g., `"Standart"`, `"Clasic Plus"`) → flag as `TYPO_DETECTED`.
 
 **Fallback:** If Figma API is unreachable, mark criterion as ⚠️ SKIPPED. Do NOT fail the entire validation.
 
 ---
 
-### Criterion 3 — Design Token Compliance
+### Criterion 3  -  Design Token Compliance
 
 **Question:** Renkler/spacing/typography design token kullanıyor mu?
 
 **Check:**
 
 1. From Figma node data, extract:
-   - **Fill colors** — check if they correspond to known design token hex values
-   - **Text styles** — check if they match `UIAssetTokens` typography styles
-   - **Spacing values** — check if padding/gap values are standard multiples: 2, 4, 8, 12, 16, 24, 32, 48
-   - **Corner radius** — check if values match known radius tokens: 4, 8, 12, 16, 24
+   - **Fill colors**  -  check if they correspond to known design token hex values
+   - **Text styles**  -  check if they match `UIAssetTokens` typography styles
+   - **Spacing values**  -  check if padding/gap values are standard multiples: 2, 4, 8, 12, 16, 24, 32, 48
+   - **Corner radius**  -  check if values match known radius tokens: 4, 8, 12, 16, 24
 2. Optionally cross-reference with the token index:
    ```bash
    cd "${COMMON_PATH}" && .build/debug/FigmaRegistryUtility uitoken-index 2>/dev/null
@@ -210,11 +210,11 @@ If the URL's `fileKey` does not match any of these → ❌ FAIL. Reason: "Unknow
 
 **Pass Condition:** No hardcoded hex colors outside the design token palette. Spacing uses standard increments.
 
-**Soft Pass:** If token verification is not possible from the API response, mark as ⚠️ ASSUMED PASS with note: "Token compliance could not be fully verified from API — manual visual check recommended."
+**Soft Pass:** If token verification is not possible from the API response, mark as ⚠️ ASSUMED PASS with note: "Token compliance could not be fully verified from API  -  manual visual check recommended."
 
 ---
 
-### Criterion 4 — Nested Dependency Readiness
+### Criterion 4  -  Nested Dependency Readiness
 
 **Question:** Bağımlı olduğu alt bileşenler zaten implemente mi?
 
@@ -225,7 +225,7 @@ If the URL's `fileKey` does not match any of these → ❌ FAIL. Reason: "Unknow
 3. **Resolve the componentId** to a searchable ID using the `components` metadata from the API response.
 4. **Search for implementation** using the decision tree below.
 
-#### Step 3 — ComponentId Resolution (CRITICAL)
+#### Step 3  -  ComponentId Resolution (CRITICAL)
 
 Figma INSTANCE nodes reference a **variant's node ID** (`componentId`), NOT the COMPONENT_SET's node ID. The API response includes a `components` metadata map at `data.nodes[nodeId].components` that provides the `componentSetId` for each variant.
 
@@ -266,7 +266,7 @@ For each child `componentId`, look it up in the component registry (`component-r
                  │                 └──────────┬───────────────────┘
     ┌────────────┼────────────┐          found │         not found
     │            │            │               │              │
-  VA (Y…sa)  DSC (p…Bi)  MAC (9…wx)    ┌─────┴──────┐   UNKNOWN
+  VA (Y...sa)  DSC (p...Bi)  MAC (9...wx)    ┌─────┴──────┐   UNKNOWN
     │            │            │         │status.ios. │   (warn)
     ▼            ▼            ▼         │implemented │
   COMMON     UICOMP       UICOMP        │.value=true?│
@@ -283,7 +283,7 @@ For each child `componentId`, look it up in the component registry (`component-r
 | `ps4xrJzhn7WNbfkZs895Bi` | Design System Core | **UICOMP** | Core UI components |
 | `9ipBvrtsq9HlQ175B9k0wx` | Mobile App Components | **UICOMP** | Flow-based / app-specific components |
 
-**Registry-based shortcuts** (parentPage check — no filesystem search needed):
+**Registry-based shortcuts** (parentPage check  -  no filesystem search needed):
 
 | `parentPage` value | Location | Verification |
 |--------------------|----------|-------------|
@@ -300,7 +300,7 @@ For each child `componentId`, look it up in the component registry (`component-r
 # IMPORTANT: Search on iteration/develop, not current HEAD
 cd "${COMMON_PATH}"
 NODE_DASH="${nodeId//:/-}"
-# 1. Check Components/{nodeId}.json — new status.ios.implemented.value (architecture-update)
+# 1. Check Components/{nodeId}.json  -  new status.ios.implemented.value (architecture-update)
 #    with legacy codeConnect.ios fallback for pre-backfill entries
 git show iteration/develop:Shared/Figma/Components/${NODE_DASH}.json 2>/dev/null | \
   python3 -c "
@@ -342,7 +342,7 @@ git grep -rl "${component_name}" iteration/develop -- 'Sources/UIComponents/Regr
 
 **Pass Condition:** ALL child component instances are either:
 - Already implemented (have a matching `.figma.swift` on `iteration/develop`), OR
-- Have `status.ios.implemented.value = true` in individual `Components/{nodeId}.json` (architecture-update model — with legacy `codeConnect.ios = true` as fallback for pre-backfill entries), OR
+- Have `status.ios.implemented.value = true` in individual `Components/{nodeId}.json` (architecture-update model  -  with legacy `codeConnect.ios = true` as fallback for pre-backfill entries), OR
 - Listed under `parentPage: "Icons"` or `"Logos"` in the component registry, OR
 - Found in `Regroup/` folder (cross-file logos like `MilesAndSmilesLogo`), OR
 - Marked as skipped in registry (`skip: true`), OR
@@ -353,7 +353,7 @@ List the missing dependencies with their Figma names and node IDs.
 
 ---
 
-### Criterion 5 — Atomic Component Scope
+### Criterion 5  -  Atomic Component Scope
 
 **Question:** Atomic (tek başına anlamlı) bir UI parçası mı?
 
@@ -365,8 +365,8 @@ List the missing dependencies with their Figma names and node IDs.
 2. From Figma node data, check dimensions:
    - Width > 500 AND height > 800 → likely a full screen ❌
 3. Check variant count from component properties:
-   - 2–50 variant combinations → reasonable ✅
-   - 0–1 variants → acceptable for STATIC_VALUES components — ⚠️ warn but pass
+   - 2-50 variant combinations → reasonable ✅
+   - 0-1 variants → acceptable for STATIC_VALUES components  -  ⚠️ warn but pass
    - 500+ variants → likely needs splitting ❌
 4. Check component name depth:
    - Name contains `/` separators with 4+ levels (e.g., `A/B/C/D/E`) → ⚠️ warn, may be deeply nested subcomponent
@@ -375,7 +375,7 @@ List the missing dependencies with their Figma names and node IDs.
 
 ---
 
-### Criterion 6 — iOS Platform Applicability
+### Criterion 6  -  iOS Platform Applicability
 
 **Question:** iOS platformu için geçerli mi (Hover-only değil)?
 
@@ -390,11 +390,11 @@ List the missing dependencies with their Figma names and node IDs.
 3. Check for web-only component patterns in the name:
    - `"Breadcrumb"`, `"Sidebar"`, `"Tooltip/Hover"` → ⚠️ flag for review but don't auto-fail
 
-**Pass Condition:** Component is usable on iOS — has non-hover states and is not desktop-only.
+**Pass Condition:** Component is usable on iOS  -  has non-hover states and is not desktop-only.
 
 ---
 
-### Criterion 7 — Already Implemented Check
+### Criterion 7  -  Already Implemented Check
 
 **Question:** Bu component zaten implemente edilmiş mi?
 
@@ -466,8 +466,8 @@ From registry, count how many components on the same `pageName` are implemented
 | Score | Verdict | Meaning |
 |-------|---------|---------|
 | 7/7 ✅ | **VALID** | Ready for `/figma-to-swiftui` implementation pipeline |
-| 6/7 ✅ | **CONDITIONAL** | One criterion failed — may be resolvable |
-| 5/7 or below | **INVALID** | Not ready — requires design-side changes or scope adjustment |
+| 6/7 ✅ | **CONDITIONAL** | One criterion failed  -  may be resolvable |
+| 5/7 or below | **INVALID** | Not ready  -  requires design-side changes or scope adjustment |
 
 **Note on ⚠️ SKIPPED criteria:** A skipped criterion (e.g., Figma API unreachable) counts as a pass for scoring purposes but is noted in the output.
 
@@ -509,7 +509,7 @@ From registry, count how many components on the same `pageName` are implemented
   - Page progress: Explore 12/18 (67%)
 
 ⚠️ Warnings:
-  - UNNAMED_PROPERTY: "Property 1" detected — design team should rename
+  - UNNAMED_PROPERTY: "Property 1" detected  -  design team should rename
 ```
 
 If `--verbose`, expand each criterion with detailed findings.
@@ -539,13 +539,13 @@ These are logged but do NOT affect the VALID/INVALID verdict:
 
 | Flag | Description |
 |------|-------------|
-| `UNNAMED_PROPERTY` | Figma property named "Property 1" — tasarımcı rename etmeli |
+| `UNNAMED_PROPERTY` | Figma property named "Property 1"  -  tasarımcı rename etmeli |
 | `TYPO_DETECTED` | Variant value appears misspelled (e.g., "Standart", "Clasic Plus") |
-| `DESKTOP_CHANNEL` | Component has Desktop/Web channel mapping — iOS'ta kullanılmaz |
-| `MEND_CANDIDATE` | A previous implementation exists in `Discarded/` — use `/figma-mend` instead |
+| `DESKTOP_CHANNEL` | Component has Desktop/Web channel mapping  -  iOS'ta kullanılmaz |
+| `MEND_CANDIDATE` | A previous implementation exists in `Discarded/`  -  use `/figma-mend` instead |
 | `URL_FORMAT_INCONSISTENT` | Node URL uses non-standard format (www vs non-www, `:` vs `-`) |
-| `LOW_VARIANT_COUNT` | 0–1 variants — uses STATIC_VALUES Code Connect strategy |
-| `DEEP_NESTING` | Component name has 4+ path levels — may be a deeply nested subcomponent |
+| `LOW_VARIANT_COUNT` | 0-1 variants  -  uses STATIC_VALUES Code Connect strategy |
+| `DEEP_NESTING` | Component name has 4+ path levels  -  may be a deeply nested subcomponent |
 
 ---
 
@@ -553,7 +553,7 @@ These are logged but do NOT affect the VALID/INVALID verdict:
 
 | Error | Action |
 |-------|--------|
-| Figma API unreachable | Skip Criteria 2, 3, 4, 6 — mark as ⚠️ SKIPPED, continue with Criteria 1, 5, 7 |
+| Figma API unreachable | Skip Criteria 2, 3, 4, 6  -  mark as ⚠️ SKIPPED, continue with Criteria 1, 5, 7 |
 | Registry file not found | Show command: `cd ${COMMON_PATH} && swift build --product FigmaRegistryUtility && .build/debug/FigmaRegistryUtility update` |
 | FigmaRegistryUtility not built | Show: `cd ${COMMON_PATH} && swift build --product FigmaRegistryUtility` |
 | Invalid URL format | Ask user for correct URL via AskUserQuestion |
@@ -593,7 +593,7 @@ The script:
 - Outputs a single JSON object with `results`, `intel`, `warnings`, `score`, `total`, `elapsed_ms`
 - Agent parses the JSON and formats the verdict box
 
-**IMPORTANT — Do NOT create temporary `.py` or `.json` files.** Always use the permanent script above. If for any reason temporary files were created during execution, clean them up before returning the result:
+**IMPORTANT  -  Do NOT create temporary `.py` or `.json` files.** Always use the permanent script above. If for any reason temporary files were created during execution, clean them up before returning the result:
 
 ```bash
 rm -f /tmp/figma_validate*.py /tmp/figma_validate*.json /tmp/figma_qr*.py /tmp/figma_analyze*.py /tmp/figma_lookup*.py
@@ -607,17 +607,17 @@ rm -f /tmp/figma_validate*.py /tmp/figma_validate*.json /tmp/figma_qr*.py /tmp/f
 Never write intermediate results to disk.
 
 **Key rules for speed:**
-- ONE terminal command total (the python3 script) — no sequential shell calls
-- Use `urllib.request` — never `curl` (may be blocked by auto-approval policy)
-- Use `os.walk` / `glob.glob` for file searches — never shell `grep`/`find`
-- Never put `#` comments in shell compound commands — causes `zsh` parse errors
+- ONE terminal command total (the python3 script)  -  no sequential shell calls
+- Use `urllib.request`  -  never `curl` (may be blocked by auto-approval policy)
+- Use `os.walk` / `glob.glob` for file searches  -  never shell `grep`/`find`
+- Never put `#` comments in shell compound commands  -  causes `zsh` parse errors
 
 ---
 
 ## Future Extensibility
 
 Each criterion is self-contained with:
-- A **question** (what it checks — displayed in Turkish for team context)
+- A **question** (what it checks  -  displayed in Turkish for team context)
 - A **check** procedure (how to verify)
 - A **pass condition** (what constitutes success)
 

package/pipeline/skills/figma-common/performance-iteration-commit-all/SKILL.md

@@ -1,4 +1,9 @@
-# /performance-iteration-commit-all — Batch Validate & Push All Tour Components
+---
+name: performance-iteration-commit-all
+description: Reads `_tour_tracker.json`, validates all reviewed components in a single build+test cycle, pushes all local commits in a single push per submodule, then handles issue.
+---
+
+# /performance-iteration-commit-all  -  Batch Validate & Push All Tour Components
 
 > Reads `_tour_tracker.json`, validates all reviewed components in a single build+test
 > cycle, pushes all local commits in a single push per submodule, then handles issue
@@ -16,7 +21,7 @@
 
 ## Parameters
 
-No arguments — reads `_tour_tracker.json`.
+No arguments  -  reads `_tour_tracker.json`.
 
 ```
 /performance-iteration-commit-all
@@ -37,12 +42,12 @@ TRACKER_FILE    = ${REPO_ROOT}/_tour_tracker.json
 
 ---
 
-## STEP 0 — Read Tracker & Verify State
+## STEP 0  -  Read Tracker & Verify State
 
 Read `_tour_tracker.json`.
 
 Verify:
-- `current_step` is `"STEP_3"` — if not, HALT: "Review not complete. Run /performance-review-next first."
+- `current_step` is `"STEP_3"`  -  if not, HALT: "Review not complete. Run /performance-review-next first."
 - `reviewed_components` has at least 1 entry
 - All reviewed components have local commits (check with `git log`)
 
@@ -57,15 +62,15 @@ Print:
 
 ```
 ╔══════════════════════════════════════════════════════════════╗
-║  BATCH COMMIT — PRE-FLIGHT                                   ║
+║  BATCH COMMIT  -  PRE-FLIGHT                                   ║
 ╠══════════════════════════════════════════════════════════════╣
 ║                                                              ║
 ║  Components to commit:                                       ║
-║  1. ComponentA (#1000) — reviewed ✅                         ║
-║  2. ComponentC (#1002) — reviewed ✅                         ║
+║  1. ComponentA (#1000)  -  reviewed ✅                         ║
+║  2. ComponentC (#1002)  -  reviewed ✅                         ║
 ║                                                              ║
 ║  Dropped (will NOT be committed):                            ║
-║  ❌ ComponentB (#1001) — halted, dropped                     ║
+║  ❌ ComponentB (#1001)  -  halted, dropped                     ║
 ║                                                              ║
 ╚══════════════════════════════════════════════════════════════╝
 
@@ -76,7 +81,7 @@ Wait for user confirmation.
 
 ---
 
-## STEP 1 — Validate (SINGLE PASS)
+## STEP 1  -  Validate (SINGLE PASS)
 
 ### 1a. Build
 
@@ -165,7 +170,7 @@ Validation Summary:
 
 ---
 
-## STEP 2 — Push (SINGLE PUSH per submodule)
+## STEP 2  -  Push (SINGLE PUSH per submodule)
 
 ### 2a. Push with Rebase-Retry Loop
 
@@ -179,12 +184,12 @@ MAX_RETRIES=3
 for i in $(seq 1 $MAX_RETRIES); do
   git push origin ${PUSH_BRANCH} && break
 
-  echo "Push rejected — remote updated. Rebasing (attempt $i)..."
+  echo "Push rejected  -  remote updated. Rebasing (attempt $i)..."
   git fetch origin ${PUSH_BRANCH}
   git rebase origin/${PUSH_BRANCH}
 
   if [ $? -ne 0 ]; then
-    # Rebase conflict — attempt auto-resolution for generated files
+    # Rebase conflict  -  attempt auto-resolution for generated files
     # See "Generated File Conflict Resolution" below
     # If auto-resolution fails → HALT
   fi
@@ -202,12 +207,12 @@ done
 ```
 
 **Push order matters:** common → uicomponents → wiki (dependencies flow this direction).
-In **lean mode**, wiki submodule has no commits — skip the wiki push entirely.
+In **lean mode**, wiki submodule has no commits  -  skip the wiki push entirely.
 
 #### Generated File Conflict Resolution (common submodule)
 
 During rebase, conflicts in generated files are **expected** when others have pushed to
-`iteration/develop` concurrently. **NEVER resolve these by picking a side — always
+`iteration/develop` concurrently. **NEVER resolve these by picking a side  -  always
 accept remote then regenerate.**
 
 **Conflict resolution table:**
@@ -265,7 +270,7 @@ Update tracker: record SHAs for each component.
 ```bash
 cd ${COMMON} && git fetch origin iteration/develop
 cd ${UICOMPONENTS} && git fetch origin iteration/develop
-# Wiki fetch — skip in lean mode
+# Wiki fetch  -  skip in lean mode
 if [ "$LEAN_MODE" != "true" ]; then
   cd ${WIKI} && git fetch origin master
 fi
@@ -308,7 +313,7 @@ conflict resolution (e.g., `LocalizationStringKeys.swift` missing component keys
 
 ---
 
-## STEP 3 — Issue Housekeeping (Per Component)
+## STEP 3  -  Issue Housekeeping (Per Component)
 
 > **(strict) NONE of these substeps may be skipped.** Each substep prints a
 > status line (`✅` or `❌`). The Completion Gate at the end (3g) verifies ALL
@@ -348,9 +353,9 @@ Print: `  #<N> 3a Comment: ✅` or `❌`
 
 Determine completed phases from committed files:
 - Has Swift view file → phase:implementation done
-- Has test files → phase:testing done (**skip check in lean mode — always false**)
+- Has test files → phase:testing done (**skip check in lean mode  -  always false**)
 - Has .figma.swift → phase:code-connect done
-- Has wiki markdown → phase:documentation done (**skip check in lean mode — always false**)
+- Has wiki markdown → phase:documentation done (**skip check in lean mode  -  always false**)
 
 **Add phase labels to issue (adjust for lean mode):**
 
@@ -385,7 +390,7 @@ ISSUE_NODE_ID=$(gh api graphql -f query='{ repository(owner: "{github.org}", nam
 
 ITEM_ID=$(gh api graphql -f query='mutation { addProjectV2ItemById(input: { projectId: "{github.projectV2Id}", contentId: "'"$ISSUE_NODE_ID"'" }) { item { id } } }' --jq '.data.addProjectV2ItemById.item.id')
 
-# Set Phase = Documentation (last completed) — or Code Connect in lean mode
+# Set Phase = Documentation (last completed)  -  or Code Connect in lean mode
 LAST_PHASE_ID="7307fb8f"  # Documentation
 if [ "$LEAN_MODE" = "true" ]; then
   LAST_PHASE_ID="5384b1e1"  # Code Connect
@@ -466,7 +471,7 @@ python3 ${REPO_ROOT}/.instructions/figma/figma-to-swiftui/scripts/update-status-
 
 If the script is not available, skip with a warning:
 ```
-⚠️  Status dashboard regeneration skipped — script not found.
+⚠️  Status dashboard regeneration skipped  -  script not found.
      Run /figma-to-swift-ui-status-update manually to update counts.
 ```
 
@@ -599,7 +604,7 @@ Print the housekeeping checklist for ALL components:
 ║  HOUSEKEEPING COMPLETION GATE                                ║
 ╠══════════════════════════════════════════════════════════════╣
 ║                                                              ║
-║  #308 MilesSmilesInviteInviteList                            ║
+║  #308 FeatureXInviteList                                     ║
 ║    3a Comment:    ✅                                         ║
 ║    3b Phase:      ✅ → Documentation                        ║
 ║    3c Wiki Link:  ✅                                         ║
@@ -607,7 +612,7 @@ Print the housekeeping checklist for ALL components:
 ║    3e Dashboard:  ✅ regenerated                             ║
 ║    3f Jira:       ✅ {jira.projectKey}-132507                          ║
 ║                                                              ║
-║  #309 MilesSmilesMenuVoucherRightsGroup                      ║
+║  #309 FeatureXVoucherGroup                                   ║
 ║    3a Comment:    ✅                                         ║
 ║    3b Phase:      ✅ → Documentation                        ║
 ║    3c Wiki Link:  ✅                                         ║
@@ -627,14 +632,14 @@ Print the housekeeping checklist for ALL components:
 ```
 
 **Critical substeps** (MUST pass or have valid skip reason):
-- **3a** — Comment on issue
-- **3b** — Phase + labels updated
-- **3c** — Wiki linked (if wiki committed)
-- **3f** — Jira assigned (if Jira key exists)
+- **3a**  -  Comment on issue
+- **3b**  -  Phase + labels updated
+- **3c**  -  Wiki linked (if wiki committed)
+- **3f**  -  Jira assigned (if Jira key exists)
 
 **Non-critical substeps** (warn but continue):
-- **3d** — Auto-unblock (best effort)
-- **3e** — Status dashboard (best effort)
+- **3d**  -  Auto-unblock (best effort)
+- **3e**  -  Status dashboard (best effort)
 
 If ANY critical substep shows `❌`:
 1. Print which substeps failed and for which components
@@ -645,11 +650,11 @@ If gate passes → proceed to STEP 4.
 
 ---
 
-## STEP 4 — Final Report
+## STEP 4  -  Final Report
 
 ```
 ╔══════════════════════════════════════════════════════════════╗
-║  TOUR COMPLETE — FINAL REPORT                                ║
+║  TOUR COMPLETE  -  FINAL REPORT                                ║
 ╠══════════════════════════════════════════════════════════════╣
 ║                                                              ║
 ║  ┌───┬────────┬──────────────┬──────────┬────────────────┐  ║
@@ -657,7 +662,7 @@ If gate passes → proceed to STEP 4.
 ║  ├───┼────────┼──────────────┼──────────┼────────────────┤  ║
 ║  │ 1 │ #1000  │ ComponentA   │ ✅ Pushed │ abc1234       │  ║
 ║  │ 2 │ #1002  │ ComponentC   │ ✅ Pushed │ def5678       │  ║
-║  │ 3 │ #1001  │ ComponentB   │ ❌ Dropped│ —             │  ║
+║  │ 3 │ #1001  │ ComponentB   │ ❌ Dropped│  -              │  ║
 ║  └───┴────────┴──────────────┴──────────┴────────────────┘  ║
 ║                                                              ║
 ║  Validation:                                                 ║
@@ -698,14 +703,14 @@ rm -f ${TRACKER_FILE}
 | Tracker not found | HALT: "No tour in progress" |
 | current_step not STEP_3 | HALT: "Review not complete" |
 | No reviewed components | HALT: "Nothing to commit" |
-| Build fails | HALT — fix, then re-run |
-| Tests fail | HALT — fix failing component, then re-run |
-| Push rejected (after 3 retries) | HALT — manual conflict resolution needed |
+| Build fails | HALT  -  fix, then re-run |
+| Tests fail | HALT  -  fix failing component, then re-run |
+| Push rejected (after 3 retries) | HALT  -  manual conflict resolution needed |
 | Rebase conflict (generated file) | Auto-resolve: accept remote + regenerate (see 2a table) |
-| Rebase conflict (non-generated) | HALT — print conflict file, ask user to resolve |
+| Rebase conflict (non-generated) | HALT  -  print conflict file, ask user to resolve |
 | Post-push build fails | Regenerate generated files in common, commit + push fix |
-| Status dashboard script missing | Warn + skip — not blocking |
+| Status dashboard script missing | Warn + skip  -  not blocking |
 | Issue housekeeping fails (critical: 3a/3b/3c/3f) | Retry once → if still fails, HALT |
 | Issue housekeeping fails (non-critical: 3d/3e) | Warn but continue |
-| Jira unreachable | ⚠️ warn — mark 3f as skipped with reason, pass gate |
+| Jira unreachable | ⚠️ warn  -  mark 3f as skipped with reason, pass gate |
 | Completion gate fails | HALT: print failed substeps, retry once, then abort |

package/pipeline/skills/figma-common/performance-review-next/SKILL.md

@@ -1,4 +1,9 @@
-# /performance-review-next — Interactive Component Review Session
+---
+name: performance-review-next
+description: Reads `_tour_tracker.json`, presents a dashboard of produced components, and guides the user through reviewing each one. Fix commits are separate. Halted components can be retried or dropped.
+---
+
+# /performance-review-next  -  Interactive Component Review Session
 
 > Reads `_tour_tracker.json`, presents a dashboard of produced components,
 > and guides the user through reviewing each one. Fix commits are separate.
@@ -8,7 +13,7 @@
 
 | Parameter | Required | Default | Description |
 |-----------|----------|---------|-------------|
-| `--status` | No | — | Show dashboard only, don't start review loop |
+| `--status` | No |  -  | Show dashboard only, don't start review loop |
 
 ```
 /performance-review-next
@@ -27,7 +32,7 @@ UICOMPONENTS    = ${REPO_ROOT}/{repos.components.path}
 
 ---
 
-## STEP 0 — Read Tracker & Show Dashboard
+## STEP 0  -  Read Tracker & Show Dashboard
 
 Read `_tour_tracker.json`. If not found → HALT: "No tour in progress."
 
@@ -45,8 +50,8 @@ lean_mode = tracker.get("lean_mode", False)
 ║                                                              ║
 ║  # │ Issue  │ Component    │ Status                          ║
 ║  ──┼────────┼──────────────┼──────────────────────────────── ║
-║  1 │ #1000  │ ComponentA   │ ✅ Produced — ready for review  ║
-║  2 │ #1002  │ ComponentC   │ ✅ Produced — ready for review  ║
+║  1 │ #1000  │ ComponentA   │ ✅ Produced  -  ready for review  ║
+║  2 │ #1002  │ ComponentC   │ ✅ Produced  -  ready for review  ║
 ║  3 │ #1001  │ ComponentB   │ ❌ Halted (Phase 4)             ║
 ║                                                              ║
 ║  Reviewed: 0/2 produced                                      ║
@@ -57,7 +62,7 @@ lean_mode = tracker.get("lean_mode", False)
 If `lean_mode` is `true`, add a warning banner after the dashboard:
 
 ```
-⚠️  LEAN MODE — Tests & wiki were NOT generated.
+⚠️  LEAN MODE  -  Tests & wiki were NOT generated.
     Review covers: implementation (Phase 4) + Code Connect (Phase 6) only.
 ```
 
@@ -65,7 +70,7 @@ If `--status` → print dashboard and exit.
 
 ---
 
-## STEP 1 — Build All (One Time)
+## STEP 1  -  Build All (One Time)
 
 Before any review, run a single build to verify the current state:
 
@@ -89,19 +94,19 @@ Print:
 
 Do NOT proceed until build passes.
 
-**If build passes:** Print "Build ✅ — all components compile" and proceed to STEP 2.
+**If build passes:** Print "Build ✅  -  all components compile" and proceed to STEP 2.
 
 ---
 
-## STEP 2 — Review Loop
+## STEP 2  -  Review Loop
 
 Ask user which component to review:
 
 ```
 Which component would you like to review?
-  [1] ComponentA (#1000) — ready for review
-  [2] ComponentC (#1002) — ready for review
-  [3] ComponentB (#1001) — halted (retry/drop)
+  [1] ComponentA (#1000)  -  ready for review
+  [2] ComponentC (#1002)  -  ready for review
+  [3] ComponentB (#1001)  -  halted (retry/drop)
   [done] All reviews complete → proceed to commit
 ```
 
@@ -131,13 +136,13 @@ When user selects a produced component:
 
 3. **Present review options:**
    ```
-   ComponentA (#1000) — Review
+   ComponentA (#1000)  -  Review
      Files: 8 files (view, config, tests, snapshots, wiki, code-connect)    # lean: fewer files
      Tests: ✅ 12 passed    # lean: ⏭ skipped (lean mode)
    
    Actions:
      [approve] Mark as reviewed ✅
-     [fix]     I see an issue — let me fix it
+     [fix]     I see an issue  -  let me fix it
      [back]    Back to dashboard
    ```
 
@@ -166,8 +171,8 @@ When user selects a produced component:
 When user selects a halted component:
 
 ```
-ComponentB (#1001) — Halted at Phase 4
-  Reason: Build failure — missing dependency protocol
+ComponentB (#1001)  -  Halted at Phase 4
+  Reason: Build failure  -  missing dependency protocol
   
   Actions:
     [retry]  Re-produce this component from scratch
@@ -198,8 +203,8 @@ When user selects "done" or all produced components are reviewed:
 ║  Dropped:   1 component (ComponentB)                         ║
 ║                                                              ║
 ║  Ready to commit:                                            ║
-║  ✅ #1000 — ComponentA                                       ║
-║  ✅ #1002 — ComponentC                                       ║
+║  ✅ #1000  -  ComponentA                                       ║
+║  ✅ #1002  -  ComponentC                                       ║
 ║                                                              ║
 ║  Next: /performance-iteration-commit-all                     ║
 ╚══════════════════════════════════════════════════════════════╝