@mmerterden/multi-agent-pipeline 8.6.1 → 10.0.6

package/pipeline/scripts/smoke-bitbucket-contract.sh

@@ -1,5 +1,5 @@
 #!/usr/bin/env bash
-# smoke-bitbucket-contract.sh — offline contract test for repo-cache.sh
+# smoke-bitbucket-contract.sh  -  offline contract test for repo-cache.sh
 # Bitbucket Server backend.
 #
 # Replaces curl with a stub that serves a fixture JSON, then verifies the
@@ -71,7 +71,7 @@ cat > "$TMP/curl" <<EOF
 #!/usr/bin/env bash
 # Capture every invocation so we can assert the URL + auth header shape.
 echo "INVOCATION:" "\$@" >> "$TMP/curl-calls.log"
-# Echo the fixture body (BB Server response) to stdout — same as real curl -sf.
+# Echo the fixture body (BB Server response) to stdout  -  same as real curl -sf.
 cat "$TMP/fixture.json"
 exit 0
 EOF
@@ -102,6 +102,22 @@ esac
 EOF
 chmod +x "$TMP/security"
 
+# Stub `secret-tool` for the same purpose on Linux - credential-store.sh
+# routes get() through libsecret there, so the macOS `security` stub alone
+# leaves BB_TOKEN empty and every downstream assertion blank.
+cat > "$TMP/secret-tool" <<EOF
+#!/usr/bin/env bash
+# Mimic: secret-tool lookup service <key>
+if [ "\$1" = "lookup" ]; then
+  case "\$3" in
+    mock_BB_Token) echo "test-bb-token" ;;
+    mock_BB_User)  echo "test-bb-user" ;;
+    *) exit 1 ;;
+  esac
+fi
+EOF
+chmod +x "$TMP/secret-tool"
+
 # Override repo-cache TTL and stub PATH so curl + security come from $TMP.
 export PATH="$TMP:$PATH"
 export REPO_CACHE_TTL=0   # skip cache, force fetch
@@ -115,7 +131,7 @@ mkdir -p "$HOME/.claude/cache/repos" "$HOME/.claude/lib"
 ln -sf "$LIB_DIR/credential-store.sh" "$HOME/.claude/lib/credential-store.sh"
 
 # --- Run the call -----------------------------------------------------------
-echo "→ 1. repo-cache.sh bitbucket MOBILE — invoke + parse"
+echo "→ 1. repo-cache.sh bitbucket MOBILE  -  invoke + parse"
 out=$("$REPO_CACHE" bitbucket MOBILE --refresh 2>&1)
 if [ $? -eq 0 ]; then
   ok "exit 0 with valid fixture"

package/pipeline/scripts/smoke-changelog-version.sh

@@ -0,0 +1,47 @@
+#!/usr/bin/env bash
+# smoke-changelog-version.sh - fail when CHANGELOG.md and package.json drift.
+#
+# Gates (release.yml relies on both holding):
+#   1. The newest "## [X.Y.Z] - YYYY-MM-DD" entry in CHANGELOG.md matches
+#      package.json "version".
+#   2. The entry's date is ISO formatted.
+#   3. CHANGELOG-archive.md is NOT listed in package.json files[] (repo-only).
+set -euo pipefail
+
+ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/../.." && pwd)"
+PASS=0
+FAIL=0
+
+record_pass() { PASS=$((PASS + 1)); printf '  PASS %s\n' "$1"; }
+record_fail() { FAIL=$((FAIL + 1)); printf '  FAIL %s\n' "$1"; }
+
+printf 'smoke-changelog-version: CHANGELOG.md <-> package.json drift gate\n'
+
+PKG_VERSION=$(jq -r .version "$ROOT/package.json")
+TOP_ENTRY=$(grep -m1 -E '^## \[[0-9]+\.[0-9]+\.[0-9]+\]' "$ROOT/CHANGELOG.md" || true)
+
+if [ -z "$TOP_ENTRY" ]; then
+  record_fail "CHANGELOG.md has no '## [X.Y.Z] - YYYY-MM-DD' entry"
+else
+  record_pass "CHANGELOG.md has a parseable top entry"
+  TOP_VERSION=$(printf '%s' "$TOP_ENTRY" | grep -oE '[0-9]+\.[0-9]+\.[0-9]+' | head -1)
+  if [ "$TOP_VERSION" = "$PKG_VERSION" ]; then
+    record_pass "top entry $TOP_VERSION matches package.json $PKG_VERSION"
+  else
+    record_fail "top entry $TOP_VERSION != package.json $PKG_VERSION"
+  fi
+  if printf '%s' "$TOP_ENTRY" | grep -qE '[0-9]{4}-[0-9]{2}-[0-9]{2}'; then
+    record_pass "top entry date is ISO formatted"
+  else
+    record_fail "top entry date is not ISO formatted: $TOP_ENTRY"
+  fi
+fi
+
+if jq -e '.files | index("CHANGELOG-archive.md")' "$ROOT/package.json" >/dev/null 2>&1; then
+  record_fail "CHANGELOG-archive.md must stay repo-only (remove from files[])"
+else
+  record_pass "CHANGELOG-archive.md not shipped in npm tarball"
+fi
+
+printf 'smoke-changelog-version: %d passed, %d failed\n' "$PASS" "$FAIL"
+[ "$FAIL" -eq 0 ]

package/pipeline/scripts/smoke-channels-flow.sh

@@ -1,5 +1,5 @@
 #!/usr/bin/env bash
-# smoke-channels-flow.sh — asserts the v5.7+ /multi-agent:channels contract:
+# smoke-channels-flow.sh  -  asserts the v5.7+ /multi-agent:channels contract:
 #   1. channels.md exists (Claude) + multi-agent-channels SKILL.md exists (Copilot)
 #   2. enrich.md is GONE (Claude) + multi-agent-enrich skill is GONE (Copilot)
 #   3. channels.md declares the 4 channels (pr, jira, confluence, wiki)

package/pipeline/scripts/smoke-ci-workflows.sh

@@ -1,6 +1,6 @@
 #!/usr/bin/env bash
 #
-# smoke-ci-workflows.sh — structural validator for `.github/workflows/*.yml`.
+# smoke-ci-workflows.sh  -  structural validator for `.github/workflows/*.yml`.
 #
 # We don't have `act` (or PyYAML) as a hard dependency, and we don't run
 # workflows on GitHub during this smoke (billing-friendly stance). This
@@ -15,7 +15,7 @@
 #   - No `--token=` argv pattern in shell steps (Vercel leak shape)
 #
 # The full job semantics (Docker image resolution, secret resolution,
-# matrix expansion) are NOT checked — install `act` and run
+# matrix expansion) are NOT checked  -  install `act` and run
 # `act -W .github/workflows/<file> --list` for that.
 #
 # Exit codes: 0=pass, 1=structural break
@@ -61,19 +61,19 @@ for wf in $WORKFLOWS; do
   if grep -q 'workflow_dispatch' "$wf"; then
     pass "$name supports workflow_dispatch (manual run)"
   else
-    fail "$name missing workflow_dispatch — won't be runnable while billing is paused"
+    fail "$name missing workflow_dispatch  -  won't be runnable while billing is paused"
   fi
 
   # Pin check: `uses: foo/bar@vN` good; `uses: foo/bar@main` bad
   if grep -E '^[[:space:]]+- uses: [^@]+@(main|master)[^[:alnum:]]?' "$wf" >/dev/null 2>&1; then
-    fail "$name has uses: pinned to a moving branch (main/master) — pin to a version"
+    fail "$name has uses: pinned to a moving branch (main/master)  -  pin to a version"
   else
     pass "$name uses: lines are not pinned to main/master"
   fi
 
   # Vercel leak shape: `--token=` or `--token ` in a `run:` block
   if grep -E "vercel.*--token[ =]" "$wf" >/dev/null 2>&1; then
-    fail "$name contains 'vercel --token=…' — must use VERCEL_TOKEN env + wrapper instead"
+    fail "$name contains 'vercel --token=...'  -  must use VERCEL_TOKEN env + wrapper instead"
   else
     pass "$name does not pass --token= to vercel"
   fi

package/pipeline/scripts/smoke-clarify.sh

@@ -116,10 +116,10 @@ fi
 if [ ! -f "$PHASE_DOC" ]; then
   record_fail "phase-0-init.md missing"
 else
-  if grep -qE 'Step 8 — Clarification' "$PHASE_DOC"; then
-    record_pass "phase-0-init.md documents Step 8 — Clarification"
+  if grep -qE 'Step 8  -  Clarification' "$PHASE_DOC"; then
+    record_pass "phase-0-init.md documents Step 8  -  Clarification"
   else
-    record_fail "phase-0-init.md missing Step 8 — Clarification section"
+    record_fail "phase-0-init.md missing Step 8  -  Clarification section"
   fi
   # 12. cites task-clarifier
   if grep -qF "task-clarifier.md" "$PHASE_DOC"; then

package/pipeline/scripts/smoke-commands-skills-parity.sh

@@ -1,15 +1,15 @@
 #!/usr/bin/env bash
-# smoke-commands-skills-parity.sh — catch drift between the dual source of
+# smoke-commands-skills-parity.sh  -  catch drift between the dual source of
 # truth for pipeline sub-commands.
 #
 # Current state: pipeline/commands/multi-agent/{cmd}.md (Claude slash
 # commands) and pipeline/skills/shared/multi-agent-{cmd}/SKILL.md (Copilot
 # skills) describe the same behaviors in parallel. ROADMAP 4.0 will collapse
 # them to a single source. Until then, any command that exists in one but
-# not the other is a bug — users will see feature mismatch between CLIs.
+# not the other is a bug  -  users will see feature mismatch between CLIs.
 #
 # This smoke enforces structural parity (every command has a matching skill).
-# Content drift is a separate problem — sync-parity-check.sh is the manual
+# Content drift is a separate problem  -  sync-parity-check.sh is the manual
 # watchdog for that.
 
 set -uo pipefail
@@ -32,7 +32,7 @@ FAIL=0
 pass() { PASS=$((PASS+1)); echo "  ✓ $1"; }
 fail() { FAIL=$((FAIL+1)); echo "  ✗ $1"; }
 
-# Commands to check — top-level *.md files under commands/multi-agent/.
+# Commands to check  -  top-level *.md files under commands/multi-agent/.
 # Underscore-prefixed files (e.g. _account-picker.md) are internal fragments
 # loaded by other commands via Read; they're not invocable slash commands and
 # intentionally have no matching skill.

package/pipeline/scripts/smoke-community-gates.sh

@@ -0,0 +1,75 @@
+#!/usr/bin/env bash
+# smoke-community-gates.sh  -  v9.11.0
+#
+# Validates that the three community-sourced quality steps are wired into
+# their phase docs:
+#   B1  code-simplifier pass     -> phase-3-dev.md   (diff shrink before Phase 4)
+#   B2  lesson memory loop       -> phase-4-review.md (root-cause lesson per fix round)
+#   B3  cross-artifact check     -> phase-2-planning.md (plan vs analysis, pre-approval)
+#
+# Without this, the steps can silently drop out of the phase docs during a
+# refactor and the pipeline regresses to bloated diffs, repeated root causes,
+# and plans that drift from the analysis.
+#
+# What this does NOT enforce:
+#   - Runtime  -  that the agent actually runs the steps. This smoke catches
+#     the prompt-side gap, same as smoke-tracker-contract.sh.
+
+set -euo pipefail
+
+REPO_ROOT="$(cd "$(dirname "$0")/../.." && pwd)"
+PHASES_DIR="$REPO_ROOT/pipeline/commands/multi-agent/refs/phases"
+
+PASS=0
+FAIL=0
+pass() { PASS=$((PASS + 1)); echo "  ✓ $1"; }
+fail() { FAIL=$((FAIL + 1)); echo "  ✗ $1"; }
+
+check() {
+  local doc="$1" marker="$2" label="$3"
+  local full="$PHASES_DIR/$doc"
+  if [ ! -f "$full" ]; then
+    fail "$doc missing"
+    return
+  fi
+  if grep -qiF "$marker" "$full"; then
+    pass "$doc: $label"
+  else
+    fail "$doc missing $label (marker: $marker)"
+  fi
+}
+
+# ──────────────────────────────────────────────────────────────────────────
+echo "→ 1. B1  -  code-simplifier pass in phase-3-dev.md"
+check "phase-3-dev.md" "Code-simplifier pass" "diff-shrink step heading"
+check "phase-3-dev.md" "Comment bloat" "comment-bloat smell"
+check "phase-3-dev.md" "Unrelated rewrites" "unrelated-rewrites smell"
+check "phase-3-dev.md" "Dead code" "dead-code smell"
+check "phase-3-dev.md" "Over-abstraction" "over-abstraction smell"
+check "phase-3-dev.md" "Re-run build + tests" "post-shrink build/test re-run"
+check "phase-3-dev.md" "dev.simplifier_pass" "cost-ledger metric for the subagent"
+check "phase-3-dev.md" "dispatching code-simplifier diff-shrink" "progress line"
+
+# ──────────────────────────────────────────────────────────────────────────
+echo ""
+echo "→ 2. B2  -  lesson memory loop in phase-4-review.md"
+check "phase-4-review.md" "Lesson memory loop" "lesson step heading"
+check "phase-4-review.md" "learnings-ledger.mjs add" "ledger append invocation (existing store, no parallel store)"
+check "phase-4-review.md" "one-line root-cause lesson" "one-line root-cause contract"
+check "phase-4-review.md" "writing lesson to learnings ledger" "progress line"
+
+# ──────────────────────────────────────────────────────────────────────────
+echo ""
+echo "→ 3. B3  -  cross-artifact consistency check in phase-2-planning.md"
+check "phase-2-planning.md" "Cross-artifact consistency check" "consistency step heading"
+check "phase-2-planning.md" "maps to at least one plan task" "requirement-coverage check"
+check "phase-2-planning.md" "No plan task without an analysis anchor" "anchor-integrity check"
+check "phase-2-planning.md" "Open-question carry-over" "open-question carry-over check"
+check "phase-2-planning.md" "revise the plan ONCE" "single-revision rule"
+check "phase-2-planning.md" "Consistency gaps" "remaining-gaps surfacing banner"
+check "phase-2-planning.md" "checking plan-vs-analysis consistency" "progress line"
+
+# ──────────────────────────────────────────────────────────────────────────
+echo ""
+echo "══ community-gates smoke: $PASS passed, $FAIL failed ══"
+[ "$FAIL" -eq 0 ]

package/pipeline/scripts/smoke-compliance-skills.sh

@@ -1,5 +1,5 @@
 #!/usr/bin/env bash
-# smoke-compliance-skills.sh — v5.8.0+ store-ready compliance skills contract.
+# smoke-compliance-skills.sh  -  v5.8.0+ store-ready compliance skills contract.
 #
 # Verifies the two compliance skills are consistent with their documentation and
 # that the 4 claimed consumer surfaces actually reference them (not just promise).
@@ -91,19 +91,19 @@ grep -q 'google-play-compliance' "$SIM_TEST" && pass "sim-test dispatches google
 grep -q '\.xcodeproj' "$SIM_TEST" && pass "sim-test platform-detects .xcodeproj" || fail "sim-test missing .xcodeproj detect"
 grep -q 'build\.gradle' "$SIM_TEST" && pass "sim-test platform-detects build.gradle" || fail "sim-test missing build.gradle detect"
 
-echo "→ 9. consumer wiring — security-auditor (both catalogs)"
+echo "→ 9. consumer wiring  -  security-auditor (both catalogs)"
 grep -q 'apple-archive-compliance' "$SEC_AUDITOR" && pass "security-auditor references apple skill" || fail "security-auditor apple reference missing"
 grep -q 'google-play-compliance' "$SEC_AUDITOR" && pass "security-auditor references google skill" || fail "security-auditor google reference missing"
 grep -qE 'Info\.plist|PrivacyInfo|entitlements' "$SEC_AUDITOR" && pass "security-auditor lists iOS trigger files" || fail "security-auditor iOS trigger files missing"
 grep -qE 'AndroidManifest|build\.gradle|proguard' "$SEC_AUDITOR" && pass "security-auditor lists Android trigger files" || fail "security-auditor Android trigger files missing"
 
-echo "→ 10. consumer wiring — /multi-agent:review (both CLIs)"
+echo "→ 10. consumer wiring  -  /multi-agent:review (both CLIs)"
 grep -q 'apple-archive-compliance' "$REVIEW_CMD" && pass "review.md cites apple catalog" || fail "review.md apple reference missing"
 grep -q 'google-play-compliance' "$REVIEW_CMD" && pass "review.md cites google catalog" || fail "review.md google reference missing"
 grep -q 'apple-archive-compliance' "$REVIEW_SKILL" && pass "review SKILL.md cites apple catalog" || fail "review SKILL.md apple missing"
 grep -q 'google-play-compliance' "$REVIEW_SKILL" && pass "review SKILL.md cites google catalog" || fail "review SKILL.md google missing"
 
-echo "→ 11. consumer wiring — /multi-agent:channels auto-augmentation"
+echo "→ 11. consumer wiring  -  /multi-agent:channels auto-augmentation"
 grep -q 'archiveguard-.*\.json' "$CHANNELS_CMD" && pass "channels.md reads cached archiveguard JSON" || fail "channels.md archiveguard cache missing"
 grep -q 'play-compliance-.*\.json' "$CHANNELS_CMD" && pass "channels.md reads cached play-compliance JSON" || fail "channels.md play-compliance cache missing"
 grep -qE 'Store compliance|store compliance' "$CHANNELS_CMD" && pass "channels.md has Store compliance section" || fail "channels.md Store compliance section missing"
@@ -112,7 +112,7 @@ grep -q 'play-compliance-.*\.json' "$CHANNELS_SKILL" && pass "channels SKILL.md
 grep -qE 'Store compliance|store compliance' "$CHANNELS_SKILL" && pass "channels SKILL.md has Store compliance section" || fail "channels SKILL.md Store compliance section missing"
 
 echo "→ 12. apple skill writes the cache filename channels.md reads (producer↔consumer agreement)"
-grep -q 'archiveguard-\$\$\.json\|archiveguard-{pid}\.json' "$APPLE_SKILL" && pass "apple skill writes /tmp/archiveguard-*.json (matches channels glob)" || fail "apple skill cache filename does NOT match channels glob — store-compliance auto-augmentation will silently never trigger"
+grep -q 'archiveguard-\$\$\.json\|archiveguard-{pid}\.json' "$APPLE_SKILL" && pass "apple skill writes /tmp/archiveguard-*.json (matches channels glob)" || fail "apple skill cache filename does NOT match channels glob  -  store-compliance auto-augmentation will silently never trigger"
 
 echo ""
 echo "══ compliance-skills smoke: $PASS passed, $FAIL failed ══"

package/pipeline/scripts/smoke-cost-budget.sh

@@ -0,0 +1,70 @@
+#!/usr/bin/env bash
+# smoke-cost-budget.sh  -  exercise cost-budget-check.mjs decision logic with
+# fixture tracker files: disabled no-op, ok, warn threshold, hard ceiling,
+# missing tracker, and prefs-driven config.
+
+set -uo pipefail
+
+REPO_ROOT="$(cd "$(dirname "$0")/../.." && pwd)"
+CHECK="$REPO_ROOT/pipeline/scripts/cost-budget-check.mjs"
+
+PASS=0
+FAIL=0
+pass() { PASS=$((PASS + 1)); echo "  ✓ $1"; }
+fail() { FAIL=$((FAIL + 1)); echo "  ✗ $1"; }
+
+cleanup() { [ -n "${TMP:-}" ] && rm -rf "$TMP"; }
+trap cleanup EXIT
+TMP=$(mktemp -d)
+
+# opus rate in cost-table.json: $15/Mtok in, $75/Mtok out.
+# 100k in + 100k out = 0.1*5 + 0.1*25 = $0.50 + $2.50 = $3.00.
+mk_tracker() { # <in> <out> -> path
+  local f="$TMP/tracker-$1-$2.json"
+  printf '{"phases":{"1":{"name":"Analysis","tokens_in":%s,"tokens_out":%s}}}' "$1" "$2" > "$f"
+  echo "$f"
+}
+
+run() { node "$CHECK" "$@" >/dev/null 2>&1; echo $?; }
+
+echo "→ 1. Disabled (no --enabled, no prefs) is a silent no-op (exit 0)"
+T=$(mk_tracker 100000 100000)
+[ "$(run --tracker "$T" --max-usd 5)" = "0" ] && pass "disabled exits 0" || fail "disabled should exit 0"
+
+echo "→ 2. Under budget -> OK (exit 0)"
+T=$(mk_tracker 1000 1000)  # ~ $0.03 of $5
+[ "$(run --tracker "$T" --enabled --max-usd 5 --pricing-model opus)" = "0" ] && pass "under budget exits 0" || fail "under budget should exit 0"
+
+echo "→ 3. Past warn threshold -> WARN (exit 10)"
+# $3.00 spend, max $4, warn 70% ($2.80) -> warn
+T=$(mk_tracker 100000 100000)
+[ "$(run --tracker "$T" --enabled --max-usd 4 --warn-pct 70 --pricing-model opus)" = "10" ] && pass "warn threshold exits 10" || fail "warn threshold should exit 10"
+
+echo "→ 4. Over ceiling -> EXCEEDED (exit 11)"
+# $3.00 spend, max $2 -> exceeded
+[ "$(run --tracker "$T" --enabled --max-usd 2 --pricing-model opus)" = "11" ] && pass "over ceiling exits 11" || fail "over ceiling should exit 11"
+
+echo "→ 5. Cheaper pricing model lowers the estimate"
+# same tokens at haiku ($1/$5): 0.1*1 + 0.1*5 = $0.60 -> under $5
+[ "$(run --tracker "$T" --enabled --max-usd 5 --pricing-model haiku)" = "0" ] && pass "haiku rate stays under budget" || fail "haiku rate should be under budget"
+
+echo "→ 6. Missing tracker is non-fatal (exit 0)"
+[ "$(run --tracker "$TMP/does-not-exist.json" --enabled --max-usd 5)" = "2" ] && pass "explicit missing tracker errors (exit 2)" || fail "explicit missing tracker should exit 2"
+[ "$(run --task-id 99999 --enabled --max-usd 5)" = "0" ] && pass "unresolvable task-id tracker exits 0 (nothing to gate)" || fail "unresolvable task-id should exit 0"
+
+echo "→ 7. prefs-driven config (enabled + maxUsd from prefs)"
+cat > "$TMP/prefs.json" <<'EOF'
+{"global":{"costBudget":{"enabled":true,"maxUsd":2.0,"warnPct":80,"pricingModel":"opus"}}}
+EOF
+[ "$(run --tracker "$T" --prefs "$TMP/prefs.json")" = "11" ] && pass "prefs enable + low ceiling exits 11" || fail "prefs-driven exceeded should exit 11"
+
+echo "→ 8. prefs disabled overrides to no-op unless --enabled forces it"
+cat > "$TMP/prefs-off.json" <<'EOF'
+{"global":{"costBudget":{"enabled":false,"maxUsd":1.0}}}
+EOF
+[ "$(run --tracker "$T" --prefs "$TMP/prefs-off.json")" = "0" ] && pass "prefs disabled exits 0" || fail "prefs disabled should exit 0"
+[ "$(run --tracker "$T" --prefs "$TMP/prefs-off.json" --enabled --max-usd 1)" = "11" ] && pass "--enabled overrides prefs disabled" || fail "--enabled should override prefs disabled"
+
+echo ""
+echo "══ cost-budget smoke: $PASS passed, $FAIL failed ══"
+[ "$FAIL" -eq 0 ]

package/pipeline/scripts/smoke-cost-summary.sh

@@ -1,12 +1,12 @@
 #!/usr/bin/env bash
-# smoke-cost-summary.sh — v6.1.J
+# smoke-cost-summary.sh  -  v6.1.J
 #
 # Verifies the cost-summary pipeline:
 #   1. cost-table.json parses and has opus/sonnet/haiku entries
 #   2. render-cost-summary.sh exits 2 when no tracker data available
 #   3. render-cost-summary.sh emits a valid markdown table from tracker fixture
 #   4. OTel-spans fallback path renders when tracker JSON is missing
-#   5. Unknown model gracefully renders USD as — with footnote
+#   5. Unknown model gracefully renders USD as  -  with footnote
 #   6. Schema (prefs.schema.json) exposes costSummary toggle
 #   7. channels.md documents Cost Summary content option
 #
@@ -97,7 +97,7 @@ else
   record_fail "OTel fallback did not aggregate tokens (expected 8,000 in, got: $(echo "$out2" | tr '\n' ' ' | cut -c1-200))"
 fi
 
-# --- 5: unknown model → — + footnote ---
+# --- 5: unknown model →  -  + footnote ---
 tmp=$(mktemp -d)
 pushd "$tmp" >/dev/null
 mkdir -p .worktrees/UNK-1
@@ -110,7 +110,7 @@ out3=$(bash "$RENDERER" UNK-1)
 popd >/dev/null
 rm -rf "$tmp"
 
-if grep -q '| —' <<< "$out3" && grep -q 'USD unavailable' <<< "$out3"; then
+if grep -q '|  - ' <<< "$out3" && grep -q 'USD unavailable' <<< "$out3"; then
   record_pass "unknown model renders dash + footnote"
 else
   record_fail "unknown model path missing dash or footnote"

package/pipeline/scripts/smoke-cross-cli-behavior.sh

@@ -1,5 +1,5 @@
 #!/usr/bin/env bash
-# smoke-cross-cli-behavior.sh — enforces the cross-CLI parity invariant
+# smoke-cross-cli-behavior.sh  -  enforces the cross-CLI parity invariant
 # defined in ~/.claude/commands/multi-agent/refs/cross-cli-contract.md.
 #
 # This is a behavioral complement to smoke-sync-parity.sh (which tests the
@@ -100,13 +100,13 @@ echo "→ 4. Canonical placeholders present (sanity)"
 if grep -q -F "{owner}" "$CLAUDE_CMDS/sync.md" 2>/dev/null; then
   pass "sync.md uses canonical '{owner}'"
 else
-  fail "sync.md missing '{owner}' — drift fix may have regressed"
+  fail "sync.md missing '{owner}'  -  drift fix may have regressed"
 fi
 
 if grep -q -F "{website-host}" "$CLAUDE_CMDS/sync.md" 2>/dev/null; then
   pass "sync.md uses canonical '{website-host}'"
 else
-  fail "sync.md missing '{website-host}' — drift fix may have regressed"
+  fail "sync.md missing '{website-host}'  -  drift fix may have regressed"
 fi
 
 # ──────────────────────────────────────────────────────────────────────────
@@ -130,7 +130,7 @@ if [ -f "$CONTRACT" ]; then
   if [ "$SIZE" -ge 100 ]; then
     pass "cross-cli-contract.md present ($SIZE lines)"
   else
-    fail "cross-cli-contract.md suspiciously short ($SIZE lines) — stub?"
+    fail "cross-cli-contract.md suspiciously short ($SIZE lines)  -  stub?"
   fi
 else
   fail "cross-cli-contract.md missing at $CONTRACT"
@@ -145,19 +145,27 @@ FIGMA_TREES=(figma-ios figma-android figma-common)
 
 for tree in "${FIGMA_TREES[@]}"; do
   claude_tree="$CLAUDE_SKILLS/$tree"
+  claude_note=""
+  # /multi-agent:stack parks inactive-platform trees under skills-inactive/.
+  # A parked tree is still deployed - count it from its parked location so
+  # iOS-stack machines don't fail on the android tree (and vice versa).
+  if [ ! -d "$claude_tree" ] && [ -d "$HOME/.claude/skills-inactive/$tree" ]; then
+    claude_tree="$HOME/.claude/skills-inactive/$tree"
+    claude_note=" (claude: parked by /multi-agent:stack)"
+  fi
   copilot_tree="$COPILOT_SKILLS/$tree"
   if [ -d "$claude_tree" ] && [ -d "$copilot_tree" ]; then
     claude_count=$(find "$claude_tree" -maxdepth 1 -mindepth 1 -type d | wc -l | tr -d ' ')
     copilot_count=$(find "$copilot_tree" -maxdepth 1 -mindepth 1 -type d | wc -l | tr -d ' ')
     if [ "$claude_count" -eq "$copilot_count" ]; then
-      pass "$tree deployed to both CLIs ($claude_count skills each)"
+      pass "$tree deployed to both CLIs ($claude_count skills each)$claude_note"
     else
-      fail "$tree count mismatch (claude=$claude_count copilot=$copilot_count)"
+      fail "$tree count mismatch (claude=$claude_count copilot=$copilot_count)$claude_note"
     fi
   elif [ -d "$claude_tree" ] || [ -d "$copilot_tree" ]; then
     fail "$tree deployed to only ONE CLI"
   else
-    echo "    (tree not installed on either CLI — run \`node install.js --all\` to deploy)"
+    echo "    (tree not installed on either CLI  -  run \`node install.js --all\` to deploy)"
   fi
 done
 
@@ -187,12 +195,45 @@ if [ -d "$CLAUDE_AGENTS" ] && [ -d "$COPILOT_AGENTS" ]; then
     fail "agents/ count mismatch (claude=$claude_count copilot=$copilot_count)"
   fi
 elif [ -d "$CLAUDE_AGENTS" ] || [ -d "$COPILOT_AGENTS" ]; then
-  fail "agents/ deployed to only ONE CLI — cross-CLI parity broken"
+  fail "agents/ deployed to only ONE CLI  -  cross-CLI parity broken"
 else
-  echo "    (agents/ not installed on either CLI — run \`node install.js --all\` to deploy)"
+  echo "    (agents/ not installed on either CLI  -  run \`node install.js --all\` to deploy)"
 fi
 
 # ──────────────────────────────────────────────────────────────────────────
+# CLI-aware reviewer-count contract: Claude Code = 2 reviewers (Opus + Sonnet),
+# Copilot CLI = 3 (GPT-5.4 + Opus + Sonnet). Nothing in code enforces the count
+# (the orchestrator dispatches per the doc), so lock the CONTRACT here against
+# drift across the phase doc, the schema, and the consensus block.
+echo "→ reviewer-count contract (Claude=2, Copilot=3)"
+REPO_ROOT="$(cd "$(dirname "$0")/../.." && pwd)"
+P4="$REPO_ROOT/pipeline/commands/multi-agent/refs/phases/phase-4-review.md"
+REVSCHEMA="$REPO_ROOT/pipeline/schemas/reviewer-output.schema.json"
+TRSCHEMA="$REPO_ROOT/pipeline/schemas/triage-output.schema.json"
+if grep -qiE "Claude Code (dispatches|=|:) ?2|2-model" "$P4" && grep -qiE "Copilot CLI (dispatches|=|:) ?3|3-model" "$P4"; then
+  pass "phase-4-review declares Claude=2 / Copilot=3 reviewers"
+else
+  fail "phase-4-review does not declare the CLI-aware reviewer count"
+fi
+if grep -qi "Copilot CLI" "$REVSCHEMA" && grep -qi "Claude" "$REVSCHEMA"; then
+  pass "reviewer-output schema notes the CLI-aware reviewer set"
+else
+  fail "reviewer-output schema missing the CLI-aware note"
+fi
+# consensus.reviewerCount must accommodate both 2 and 3 (min 1, no max < 3)
+if grep -q '"reviewerCount"' "$TRSCHEMA" && grep -qi "Claude Code = 2, Copilot CLI = 3" "$TRSCHEMA"; then
+  pass "triage consensus.reviewerCount documents 2 (Claude) and 3 (Copilot)"
+else
+  fail "triage consensus.reviewerCount does not document the 2/3 split"
+fi
+# The 3 adapter platforms must document their concrete reviewer set (a 2-model
+# cross-vendor review configured to each platform's available models).
+if grep -qi "Adapter platforms" "$P4" && grep -qi "cross-vendor" "$P4" && grep -q "ma-code-reviewer-x" "$P4"; then
+  pass "phase-4-review documents the adapter-platform cross-vendor reviewer set"
+else
+  fail "phase-4-review does not document the adapter-platform reviewer set"
+fi
+
 echo ""
 echo "══ cross-cli-behavior smoke: $PASS passed, $FAIL failed ══"
 [ "$FAIL" -eq 0 ]

package/pipeline/scripts/smoke-cross-phase-cohesion.sh

@@ -1,13 +1,13 @@
 #!/usr/bin/env bash
 #
-# smoke-cross-phase-cohesion.sh — assert every Phase N → Phase N+1 hand-off
+# smoke-cross-phase-cohesion.sh  -  assert every Phase N → Phase N+1 hand-off
 # in the multi-agent pipeline references the same schema on both sides.
 #
 # Why this exists (v8.0.0): existing schema-validation smoke proves each
 # JSON schema is itself well-formed. It does NOT prove that Phase 1's
 # reference doc says "I emit analysis-output.schema.json" while Phase 2's
 # reference doc says "I read analysis-output.schema.json". A reference can
-# rename or drop the schema without the validator catching it — phase docs
+# rename or drop the schema without the validator catching it  -  phase docs
 # would silently desynchronize from the runtime contract.
 #
 # The contract chain:
@@ -37,7 +37,7 @@ assert_schema_exists() {
   if [ -f "$SCHEMA_DIR/$schema" ]; then
     pass "$schema exists in pipeline/schemas/"
   else
-    fail "$schema MISSING — runtime contract broken"
+    fail "$schema MISSING  -  runtime contract broken"
   fi
 }
 
@@ -51,7 +51,7 @@ assert_phase_references() {
   if grep -Fq "$schema" "$path"; then
     pass "$phase_file [$role] references $schema"
   else
-    fail "$phase_file [$role] does NOT reference $schema — cohesion break"
+    fail "$phase_file [$role] does NOT reference $schema  -  cohesion break"
   fi
 }
 
@@ -119,7 +119,7 @@ echo "→ 7. Validator runs the round-trip without errors"
 if node "$REPO_ROOT/pipeline/scripts/validate-schemas.mjs" >/dev/null 2>&1; then
   pass "validate-schemas.mjs reports all schemas valid"
 else
-  fail "validate-schemas.mjs failed — schema integrity broken"
+  fail "validate-schemas.mjs failed  -  schema integrity broken"
 fi
 
 # -----------------------------------------------------------------------------

package/pipeline/scripts/smoke-delete-flow.sh

@@ -1,5 +1,5 @@
 #!/usr/bin/env bash
-# smoke-delete-flow.sh — v7.7.0 token-preserving uninstall.
+# smoke-delete-flow.sh  -  v7.7.0 token-preserving uninstall.
 #
 # Round-trip integrity for `multi-agent uninstall`:
 #   1. --dry-run produces a preview without modifying the filesystem
@@ -9,7 +9,7 @@
 #   5. Adapter `uninstall()` is invoked and its result reflects in the output
 #   6. (Bonus) Slash command + Copilot skill exist with byte-eq description (parity)
 #
-# We never invoke the uninstaller against $HOME — the test scaffolds an
+# We never invoke the uninstaller against $HOME  -  the test scaffolds an
 # isolated `--target` tree and exercises the adapter portion only. Claude /
 # Copilot uninstall paths are exercised via dry-run (which reports them).
 
@@ -95,7 +95,7 @@ else
 fi
 
 # ──────────────────────────────────────────────────────────────────────────
-echo "→ 5. Selective target — --copilot-chat doesn't touch cursor tree"
+echo "→ 5. Selective target  -  --copilot-chat doesn't touch cursor tree"
 rm -rf "$TMP" && TMP=$(mktemp -d)
 node "$INSTALL" --cursor --target="$TMP" >/dev/null 2>&1
 node "$INSTALL" --copilot-chat --target="$TMP" >/dev/null 2>&1
@@ -119,7 +119,7 @@ else
 fi
 
 # ──────────────────────────────────────────────────────────────────────────
-echo "→ 6. CLI router — 'uninstall' and 'delete' both reach the script"
+echo "→ 6. CLI router  -  'uninstall' and 'delete' both reach the script"
 OUT_UNINSTALL=$(node "$REPO_ROOT/index.js" uninstall --dry-run --yes --cursor --target=/tmp/fake 2>&1 || true)
 OUT_DELETE=$(node "$REPO_ROOT/index.js" delete --dry-run --yes --cursor --target=/tmp/fake 2>&1 || true)
 
@@ -136,7 +136,7 @@ else
 fi
 
 # ──────────────────────────────────────────────────────────────────────────
-echo "→ 7. Token preservation — uninstaller never invokes credential-store"
+echo "→ 7. Token preservation  -  uninstaller never invokes credential-store"
 # Static check: uninstall.mjs must not import credential-store.sh or call
 # `security delete-generic-password` / `cmdkey /delete` / `secret-tool clear`.
 if grep -qE "credential-store|delete-generic-password|cmdkey /delete|secret-tool clear|secret-tool del" "$UNINSTALL"; then

package/pipeline/scripts/smoke-dev-critic.sh

@@ -54,7 +54,7 @@ if [ ! -f "$PHASE_DOC" ]; then
   record_fail "phase-3-dev.md missing"
 else
   if grep -qF "Step 3.5" "$PHASE_DOC" && grep -qF "Dev Critic" "$PHASE_DOC"; then
-    record_pass "phase-3-dev.md documents Step 3.5 — Dev Critic"
+    record_pass "phase-3-dev.md documents Step 3.5  -  Dev Critic"
   else
     record_fail "phase-3-dev.md missing Step 3.5 section"
   fi
@@ -125,7 +125,7 @@ else
   record_fail "devCritic.maxIterations default should be 2 (was: ${default_iter:-missing})"
 fi
 
-# 7. Off by default — preserves existing-user baseline
+# 7. Off by default  -  preserves existing-user baseline
 # Note: jq's `// empty` treats boolean false as falsy, so use `has("default")` + raw value.
 if jq -e '.properties.global.properties.devCritic.properties.enabled
           | has("default") and .default == false' "$PREFS_SCHEMA" >/dev/null 2>&1; then