@luma.gl/webgl 8.6.0-alpha.1 → 8.6.0-alpha.5

package/src/classes/copy-and-blit.ts

@@ -1,20 +1,25 @@
-// @ts-nocheck
+import {log, assert} from '@luma.gl/api';
 import GL from '@luma.gl/constants';
 import Buffer from './webgl-buffer';
 import Framebuffer from './framebuffer';
 import Texture from './texture';
-import {assertWebGL2Context, withParameters, log} from '@luma.gl/gltools';
-import {flipRows, scalePixels} from '../webgl-utils';
+import {assertWebGL2Context} from '../context/context/webgl-checks';
+import {withParameters} from '../context/state-tracker/with-parameters';
+import {flipRows, scalePixels} from '../webgl-utils/typed-array-utils';
 import {getTypedArrayFromGLType, getGLTypeFromTypedArray} from '../webgl-utils/typed-array-utils';
 import {glFormatToComponents, glTypeToBytes} from '../webgl-utils/format-utils';
 import {toFramebuffer} from '../webgl-utils/texture-utils';
-import {assert} from '../utils';
 
-// NOTE: Slow requires roundtrip to GPU
-// Copies data from a Framebuffer or a Texture object into ArrayBuffer object.
-// App can provide targetPixelArray or have it auto allocated by this method
+/**
+ * Copies data from a Framebuffer or a Texture object into ArrayBuffer object.
+ * App can provide targetPixelArray or have it auto allocated by this method
+ *  newly allocated by this method unless provided by app.
+ * @note Slow requires roundtrip to GPU
+ *
+ * @param source
+ * @param options
 // @returns {Uint8Array|Uint16Array|FloatArray} - pixel array,
-//  newly allocated by this method unless provided by app.
+ */
 export function readPixelsToArray(
   source: Framebuffer | Texture,
   options?: {
@@ -28,15 +33,8 @@ export function readPixelsToArray(
     sourceHeight?: number;
     sourceType?: number;
   }
-): Uint8Array | Uint16Array | Float32Array;
-
-// NOTE: Slow requires roundtrip to GPU
-// Copies data from a Framebuffer or a Texture object into ArrayBuffer object.
-// App can provide targetPixelArray or have it auto allocated by this method
-// @returns {Uint8Array|Uint16Array|FloatArray} - pixel array,
-//  newly allocated by this method unless provided by app.
-export function readPixelsToArray(source, options = {}) {
-  const {sourceX = 0, sourceY = 0, sourceFormat = GL.RGBA} = options;
+): Uint8Array | Uint16Array | Float32Array {
+  const {sourceX = 0, sourceY = 0, sourceFormat = GL.RGBA} = options || {};
   let {
     sourceAttachment = GL.COLOR_ATTACHMENT0, // TODO - support gl.readBuffer
     target = null,
@@ -44,7 +42,7 @@ export function readPixelsToArray(source, options = {}) {
     sourceWidth,
     sourceHeight,
     sourceType
-  } = options;
+  } = options || {};
 
   const {framebuffer, deleteFramebuffer} = getFramebuffer(source);
   assert(framebuffer);
@@ -70,7 +68,7 @@ export function readPixelsToArray(source, options = {}) {
 
   const prevHandle = gl.bindFramebuffer(GL.FRAMEBUFFER, handle);
   gl.readPixels(sourceX, sourceY, sourceWidth, sourceHeight, sourceFormat, sourceType, target);
-  // @ts-ignore
+  // @ts-expect-error
   gl.bindFramebuffer(GL.FRAMEBUFFER, prevHandle || null);
   if (deleteFramebuffer) {
     framebuffer.delete();
@@ -78,8 +76,12 @@ export function readPixelsToArray(source, options = {}) {
   return target;
 }
 
-// NOTE: doesn't wait for copy to be complete, it programs GPU to perform a DMA transffer.
-// Copies data from a Framebuffer or a Texture object into a Buffer object.
+/**
+ * Copies data from a Framebuffer or a Texture object into a Buffer object.
+ * NOTE: doesn't wait for copy to be complete, it programs GPU to perform a DMA transffer.
+ * @param source
+ * @param options
+ */
 export function readPixelsToBuffer(
   source: Framebuffer | Texture,
   options?: {
@@ -93,30 +95,23 @@ export function readPixelsToBuffer(
     sourceHeight?: number;
     sourceType?: number;
   }
-): Buffer;
-
-// NOTE: doesn't wait for copy to be complete, it programs GPU to perform a DMA transffer.
-// Copies data from a Framebuffer or a Texture object into a Buffer object.
-export function readPixelsToBuffer(
-  source,
-  {
-    sourceX = 0,
-    sourceY = 0,
-    sourceFormat = GL.RGBA,
-    target = null, // A new Buffer object is created when not provided.
-    targetByteOffset = 0, // byte offset in buffer object
+): Buffer {
+  const {sourceX = 0, sourceY = 0, sourceFormat = GL.RGBA,
+    targetByteOffset = 0
+  } = options || {};
     // following parameters are auto deduced if not provided
+  let {
+    target,
     sourceWidth,
     sourceHeight,
-    sourceType
-  }
-) {
+    sourceType,
+  } = options || {}
   const {framebuffer, deleteFramebuffer} = getFramebuffer(source);
   assert(framebuffer);
   sourceWidth = sourceWidth || framebuffer.width;
   sourceHeight = sourceHeight || framebuffer.height;
 
-  // Asynchronus read (PIXEL_PACK_BUFFER) is WebGL2 only feature
+  // Asynchronous read (PIXEL_PACK_BUFFER) is WebGL2 only feature
   const gl2 = assertWebGL2Context(framebuffer.gl);
 
   // deduce type if not available.
@@ -127,12 +122,11 @@ export function readPixelsToBuffer(
     const components = glFormatToComponents(sourceFormat);
     const byteCount = glTypeToBytes(sourceType);
     const byteLength = targetByteOffset + sourceWidth * sourceHeight * components * byteCount;
-    // @ts-expect-error TODO why is WebGL2 context not compatible
     target = new Buffer(gl2, {byteLength, accessor: {type: sourceType, size: components}});
   }
 
+  // @ts-expect-error
   target.bind({target: GL.PIXEL_PACK_BUFFER});
-  // @ts-expect-error TODO why is WebGL2 context not compatible
   withParameters(gl2, {framebuffer}, () => {
     gl2.readPixels(
       sourceX,
@@ -204,6 +198,7 @@ export function copyToImage(
 ): typeof Image {
   const dataUrl = copyToDataUrl(source, {sourceAttachment: options?.sourceAttachment || GL.COLOR_ATTACHMENT0});
   const targetImage = options?.targetImage || new Image();
+  // @ts-expect-error
   targetImage.src = dataUrl;
   // @ts-expect-error
   return targetImage;
@@ -215,7 +210,7 @@ export function copyToImage(
 // eslint-disable-next-line complexity, max-statements
 export function copyToTexture(
   source: Framebuffer | Texture,
-  target: Texture,
+  target: Texture | GL,
   options?: {
     sourceX?: number;
     sourceY?: number;
@@ -236,14 +231,14 @@ export function copyToTexture(
     // attachment = GL.COLOR_ATTACHMENT0, // TODO - support gl.readBuffer
     targetMipmaplevel = 0,
     targetInternalFormat = GL.RGBA
-  } = options;
+  } = options || {};
   let {
     targetX,
     targetY,
     targetZ,
     width, // defaults to target width
     height // defaults to target height
-  } = options;
+  } = options || {};
 
   const {framebuffer, deleteFramebuffer} = getFramebuffer(source);
   assert(framebuffer);
@@ -260,17 +255,20 @@ export function copyToTexture(
   // const prevBuffer = gl.readBuffer(attachment);
   assert(target);
   let texture = null;
+  let textureTarget: GL;
   if (target instanceof Texture) {
     texture = target;
     width = Number.isFinite(width) ? width : texture.width;
     height = Number.isFinite(height) ? height : texture.height;
     texture.bind(0);
-    target = texture.target;
+    textureTarget = texture.target;
+  } else {
+    textureTarget = target;
   }
 
   if (!isSubCopy) {
     gl.copyTexImage2D(
-      target,
+      textureTarget,
       targetMipmaplevel,
       targetInternalFormat,
       sourceX,
@@ -280,11 +278,11 @@ export function copyToTexture(
       0 /* border must be 0 */
     );
   } else {
-    switch (target) {
+    switch (textureTarget) {
       case GL.TEXTURE_2D:
       case GL.TEXTURE_CUBE_MAP:
         gl.copyTexSubImage2D(
-          target,
+          textureTarget,
           targetMipmaplevel,
           targetX,
           targetY,
@@ -298,7 +296,7 @@ export function copyToTexture(
       case GL.TEXTURE_3D:
         const gl2 = assertWebGL2Context(gl);
         gl2.copyTexSubImage3D(
-          target,
+          textureTarget,
           targetMipmaplevel,
           targetX,
           targetY,
@@ -315,7 +313,7 @@ export function copyToTexture(
   if (texture) {
     texture.unbind();
   }
-  // @ts-ignore
+  // @ts-expect-error
   gl.bindFramebuffer(GL.FRAMEBUFFER, prevHandle || null);
   if (deleteFramebuffer) {
     framebuffer.delete();
@@ -378,7 +376,6 @@ export function blit(
 
   assert(srcFramebuffer);
   assert(dstFramebuffer);
-  // @ts-ignore
   const {gl, handle, width, height, readBuffer} = dstFramebuffer;
   const gl2 = assertWebGL2Context(gl);
 
@@ -427,9 +424,9 @@ export function blit(
     filter
   );
   gl2.readBuffer(readBuffer);
-  // @ts-ignore
+  // @ts-expect-error
   gl2.bindFramebuffer(GL.READ_FRAMEBUFFER, prevReadHandle || null);
-  // @ts-ignore
+  // @ts-expect-error
   gl2.bindFramebuffer(GL.DRAW_FRAMEBUFFER, prevDrawHandle || null);
   if (deleteSrcFramebuffer) {
     srcFramebuffer.delete();
@@ -438,7 +435,7 @@ export function blit(
     dstFramebuffer.delete();
   }
 
-  return dstFramebuffer;
+  // return dstFramebuffer;
 }
 
 // Helper methods

package/src/classes/framebuffer.ts

@@ -1,16 +1,14 @@
+import {log, assert} from '@luma.gl/api';
 import GL from '@luma.gl/constants';
-import {getWebGL2Context, assertWebGL2Context, log} from '@luma.gl/gltools';
+import WebGLDevice from '../adapter/webgl-device';
+import {getWebGL2Context, assertWebGL2Context} from '../context/context/webgl-checks';
+import {getKey} from '../webgl-utils/constants-to-keys';
 import Resource, {ResourceProps} from './webgl-resource';
 import Texture2D from './texture-2d';
 import Renderbuffer from './renderbuffer';
 import {clear, clearBuffer} from './clear';
 import {copyToDataUrl} from './copy-and-blit';
 
-import {getLumaContextData} from '../context/luma-context-data';
-import {getFeatures} from '../features';
-import {getKey} from '../webgl-utils';
-import {assert} from '../utils';
-
 const ERR_MULTIPLE_RENDERTARGETS = 'Multiple render targets not supported';
 
 type TextureAttachment = {
@@ -40,7 +38,7 @@ type colorBufferFloatOptions = {colorBufferFloat?: boolean; colorBufferHalfFloat
 
 export class ImmutableFramebuffer extends Resource<FramebufferProps> {
   constructor(gl: WebGLRenderingContext, props?: FramebufferProps) {
-    super(gl, props, {} as any);
+    super(WebGLDevice.attach(gl), props, {} as any);
     this._initialize({
       attachments: props?.attachments || {},
       readBuffer: props?.readBuffer,
@@ -61,7 +59,7 @@ export class ImmutableFramebuffer extends Resource<FramebufferProps> {
     const {gl} = this;
     const prevHandle = gl.bindFramebuffer(GL.FRAMEBUFFER, this.handle);
     const status = gl.checkFramebufferStatus(GL.FRAMEBUFFER);
-    // @ts-ignore
+    // @ts-expect-error
     gl.bindFramebuffer(GL.FRAMEBUFFER, prevHandle || null);
     return status;
   }
@@ -82,7 +80,8 @@ export class ImmutableFramebuffer extends Resource<FramebufferProps> {
     }
     message = message || `Framebuffer ${this.id}`;
     const image = copyToDataUrl(this, {targetMaxHeight: 100});
-    log.image({logLevel, message, image}, message)();
+    // @ts-expect-error probe.gl typings incorrectly require priority...
+    log.image({logLevel, message, image})();
     return this;
   }
 
@@ -112,7 +111,7 @@ export class ImmutableFramebuffer extends Resource<FramebufferProps> {
     if (drawBuffers) {
       this._setDrawBuffers(drawBuffers);
     }
-    // @ts-ignore
+    // @ts-expect-error
     this.gl.bindFramebuffer(GL.FRAMEBUFFER, prevHandle || null);
 
     return this;
@@ -131,7 +130,7 @@ export class ImmutableFramebuffer extends Resource<FramebufferProps> {
       this._attachOne(attachmentPoint, attachment);
     }
 
-    // @ts-ignore
+    // @ts-expect-error
     this.gl.bindFramebuffer(GL.FRAMEBUFFER, prevHandle || null);
   }
 
@@ -280,16 +279,16 @@ export default class Framebuffer extends ImmutableFramebuffer {
    * Creates a Framebuffer object wrapper for the default WebGL framebuffer (target === null)
    */
   static getDefaultFramebuffer(gl: WebGLRenderingContext): Framebuffer {
-    const lumaContextData = getLumaContextData(gl);
-    lumaContextData.defaultFramebuffer =
-      lumaContextData.defaultFramebuffer ||
+    const webglDevice = WebGLDevice.fromContext(gl);
+    webglDevice.defaultFramebuffer =
+      webglDevice.defaultFramebuffer ||
       new Framebuffer(gl, {
         id: 'default-framebuffer',
         handle: null,
         attachments: {}
       });
     // TODO - can we query for and get a handle to the GL.FRONT renderbuffer?
-    return lumaContextData.defaultFramebuffer;
+    return webglDevice.defaultFramebuffer;
   }
 
   get MAX_COLOR_ATTACHMENTS(): number {
@@ -407,13 +406,13 @@ export default class Framebuffer extends ImmutableFramebuffer {
       this._setDrawBuffers(drawBuffers);
       this.drawBuffers = drawBuffers;
     }
-    // @ts-ignore
+    // @ts-expect-error
     gl.bindFramebuffer(GL.FRAMEBUFFER, prevHandle || null);
 
     return this;
   }
 
-  // Attachment resize is expected to be a noop if size is same
+  /** Attachment resize is expected to be a noop if size is same */
   resize(size?: {width?: number; height?: number}): this {
     let {width, height} = size || {};
     // for default framebuffer, just update the stored size
@@ -442,7 +441,7 @@ export default class Framebuffer extends ImmutableFramebuffer {
     return this;
   }
 
-  // Attach from a map of attachments
+  /** Attach from a map of attachments */
   attach(attachments, {clearAttachments = false, resizeAttachments = true} = {}) {
     const newAttachments = {};
 
@@ -480,7 +479,7 @@ export default class Framebuffer extends ImmutableFramebuffer {
       }
     }
 
-    // @ts-ignore
+    // @ts-expect-error
     this.gl.bindFramebuffer(GL.FRAMEBUFFER, prevHandle || null);
 
     // Assign to attachments and remove any nulls to get a clean attachment map
@@ -506,7 +505,7 @@ export default class Framebuffer extends ImmutableFramebuffer {
       clearBuffer(this.gl, {drawBuffer, value});
     });
 
-    // @ts-ignore
+    // @ts-expect-error
     this.gl.bindFramebuffer(GL.FRAMEBUFFER, prevHandle || null);
 
     return this;
@@ -531,10 +530,10 @@ export default class Framebuffer extends ImmutableFramebuffer {
       gl2.invalidateFramebuffer(GL.READ_FRAMEBUFFER, attachments);
     } else {
       // TODO - why does type checking fail on this line
-      // @ts-ignore
+      // @ts-expect-error
       gl2.invalidateFramebuffer(GL.READ_FRAMEBUFFER, attachments, x, y, width, height);
     }
-    // @ts-ignore
+    // @ts-expect-error
     gl2.bindFramebuffer(GL.READ_FRAMEBUFFER, prevHandle);
     return this;
   }
@@ -549,7 +548,7 @@ export default class Framebuffer extends ImmutableFramebuffer {
       this.gl.bindFramebuffer(GL.FRAMEBUFFER, null);
     }
     if (keys && value > 1000) {
-      // @ts-ignore
+      // @ts-expect-error
       value = getKey(this.gl, value);
     }
     return value;
@@ -558,7 +557,7 @@ export default class Framebuffer extends ImmutableFramebuffer {
   getAttachmentParameters(
     attachment = GL.COLOR_ATTACHMENT0,
     keys,
-    // @ts-ignore
+    // @ts-expect-error
     parameters = this.constructor.ATTACHMENT_PARAMETERS || []
   ) {
     const values = {};
@@ -672,32 +671,36 @@ export default class Framebuffer extends ImmutableFramebuffer {
     delete this.attachments[attachment];
   }
 
-  // Attempt to provide workable defaults for WebGL2 symbols under WebGL1
-  // null means OK to query
-  // TODO - move to webgl1 polyfills
-  /* eslint-disable complexity */
+  /**
+   * Attempt to provide workable defaults for WebGL2 symbols under WebGL1
+   * null means OK to query
+   * TODO - move to webgl1 polyfills
+   * @param pname 
+   * @returns 
+   */
+  // eslint-disable-next-line complexity
   _getAttachmentParameterFallback(pname) {
-    const caps = getFeatures(this.gl);
+    const webglDevice = WebGLDevice.fromContext(this.gl);
+    const features = webglDevice.features;
 
     switch (pname) {
       case GL.FRAMEBUFFER_ATTACHMENT_TEXTURE_LAYER: // GLint
-        return !caps.WEBGL2 ? 0 : null;
+        return !features.has('webgl2') ? 0 : null;
       case GL.FRAMEBUFFER_ATTACHMENT_RED_SIZE: // GLint
       case GL.FRAMEBUFFER_ATTACHMENT_GREEN_SIZE: // GLint
       case GL.FRAMEBUFFER_ATTACHMENT_BLUE_SIZE: // GLint
       case GL.FRAMEBUFFER_ATTACHMENT_ALPHA_SIZE: // GLint
       case GL.FRAMEBUFFER_ATTACHMENT_DEPTH_SIZE: // GLint
       case GL.FRAMEBUFFER_ATTACHMENT_STENCIL_SIZE: // GLint
-        return !caps.WEBGL2 ? 8 : null;
+        return !features.has('webgl2') ? 8 : null;
       case GL.FRAMEBUFFER_ATTACHMENT_COMPONENT_TYPE: // GLenum
-        return !caps.WEBGL2 ? GL.UNSIGNED_INT : null;
+        return !features.has('webgl2') ? GL.UNSIGNED_INT : null;
       case GL.FRAMEBUFFER_ATTACHMENT_COLOR_ENCODING:
-        return !caps.WEBGL2 && !caps.EXT_sRGB ? GL.LINEAR : null;
+        return !features.has('webgl2') && !features.has('webgl-color-encoding-srgb') ? GL.LINEAR : null;
       default:
         return null;
     }
   }
-  /* eslint-enable complexity */
 }
 
 // PUBLIC METHODS
@@ -713,7 +716,7 @@ function mapIndexToCubeMapFace(layer) {
 // Get a string describing the framebuffer error if installed
 function _getFrameBufferStatus(status) {
   // Use error mapping if installed
-  // @ts-ignore
+  // @ts-expect-error
   const STATUS = Framebuffer.STATUS || {};
   return STATUS[status] || `Framebuffer error ${status}`;
 }

package/src/classes/program-configuration.ts

@@ -1,8 +1,9 @@
 // Contains metadata describing attribute configurations for a program's shaders
 // Much of this is automatically extracted from shaders after program linking
-import Accessor from './accessor';
-import {isWebGL2} from '@luma.gl/gltools';
-import {decomposeCompositeGLType} from '../webgl-utils/attribute-utils';
+// import Accessor from './accessor';
+import type Program from './program';
+import type {AttributeBinding, VaryingBinding} from '../helpers/program-bindings';
+import {getProgramBindings} from '../helpers/get-program-bindings';
 
 /**
  * is a mechanism for taking a program object and querying information
@@ -12,22 +13,32 @@ import {decomposeCompositeGLType} from '../webgl-utils/attribute-utils';
  */
  export default class ProgramConfiguration {
   id: string;
-  attributeInfos = [];
-  attributeInfosByName = {};
+  attributeInfos: AttributeBinding[] = [];
+  attributeInfosByName: Record<string, AttributeBinding> = {};
   // Locations may not be contiguous the case of matrix attributes
   // so keep a separate location->attribute map.
-  attributeInfosByLocation = [];
-  varyingInfos = [];
-  varyingInfosByName = {};
+  attributeInfosByLocation: AttributeBinding[] = [];
+  varyingInfos: VaryingBinding[] = [];
+  varyingInfosByName: Record<string, VaryingBinding> = {};
 
-  constructor(program) {
+  constructor(program: Program) {
     this.id = program.id;
     Object.seal(this);
-    this._readAttributesFromProgram(program);
-    this._readVaryingsFromProgram(program);
+
+    const bindings = getProgramBindings(program.gl2, program.handle);
+
+    this.attributeInfos = bindings.attributes;
+    for (const attributeInfo of bindings.attributes) {
+      this.attributeInfosByName[attributeInfo.name] = attributeInfo;
+      this.attributeInfosByLocation[attributeInfo.location] = attributeInfo;
+    }
+
+    for (const varyingInfo of bindings.varyings) {
+      this.varyingInfosByName[varyingInfo.name] = varyingInfo;
+    }
   }
 
-  getAttributeInfo(locationOrName) {
+  getAttributeInfo(locationOrName: number | string): AttributeBinding {
     const location = Number(locationOrName);
     if (Number.isFinite(location)) {
       return this.attributeInfosByLocation[location];
@@ -36,17 +47,17 @@ import {decomposeCompositeGLType} from '../webgl-utils/attribute-utils';
   }
 
   // Resolves an attribute name or index to an index
-  getAttributeLocation(locationOrName) {
+  getAttributeLocation(locationOrName: number | string): number {
     const attributeInfo = this.getAttributeInfo(locationOrName);
     return attributeInfo ? attributeInfo.location : -1;
   }
 
-  getAttributeAccessor(locationOrName) {
+  getAttributeAccessor(locationOrName: number | string) {
     const attributeInfo = this.getAttributeInfo(locationOrName);
     return attributeInfo ? attributeInfo.accessor : null;
   }
 
-  getVaryingInfo(locationOrName) {
+  getVaryingInfo(locationOrName: number | string): VaryingBinding {
     const location = Number(locationOrName);
     if (Number.isFinite(location)) {
       return this.varyingInfos[location];
@@ -54,77 +65,13 @@ import {decomposeCompositeGLType} from '../webgl-utils/attribute-utils';
     return this.varyingInfosByName[locationOrName] || null;
   }
 
-  getVaryingIndex(locationOrName) {
+  getVaryingIndex(locationOrName: number | string): number {
     const varying = this.getVaryingInfo(locationOrName);
     return varying ? varying.location : -1;
   }
 
-  getVaryingAccessor(locationOrName) {
+  getVaryingAccessor(locationOrName: number | string) {
     const varying = this.getVaryingInfo(locationOrName);
     return varying ? varying.accessor : null;
   }
-
-  // PRIVATE METHODS
-
-  // linkProgram needs to have been called, although linking does not need to have been successful
-  _readAttributesFromProgram(program) {
-    const {gl} = program;
-    const count = gl.getProgramParameter(program.handle, gl.ACTIVE_ATTRIBUTES);
-
-    for (let index = 0; index < count; index++) {
-      const {name, type, size} = gl.getActiveAttrib(program.handle, index);
-      const location = gl.getAttribLocation(program.handle, name);
-      // Add only user provided attributes, for built-in attributes like
-      // `gl_InstanceID` locaiton will be < 0
-      if (location >= 0) {
-        this._addAttribute(location, name, type, size);
-      }
-    }
-
-    this.attributeInfos.sort((a, b) => a.location - b.location);
-  }
-
-  // linkProgram needs to have been called, although linking does not need to have been successful
-  _readVaryingsFromProgram(program) {
-    const {gl} = program;
-    if (!isWebGL2(gl)) {
-      return;
-    }
-
-    const count = gl.getProgramParameter(program.handle, gl.TRANSFORM_FEEDBACK_VARYINGS);
-    for (let location = 0; location < count; location++) {
-      const {name, type, size} = gl.getTransformFeedbackVarying(program.handle, location);
-      this._addVarying(location, name, type, size);
-    }
-
-    this.varyingInfos.sort((a, b) => a.location - b.location);
-  }
-
-  _addAttribute(location, name, compositeType, size) {
-    const {type, components} = decomposeCompositeGLType(compositeType);
-    const accessor = {type, size: size * components};
-    this._inferProperties(location, name, accessor);
-
-    const attributeInfo = {location, name, accessor: new Accessor(accessor)}; // Base values
-    this.attributeInfos.push(attributeInfo);
-    this.attributeInfosByLocation[location] = attributeInfo; // For quick location based lookup
-    this.attributeInfosByName[attributeInfo.name] = attributeInfo; // For quick name based lookup
-  }
-
-  // Extract additional attribute metadata from shader names (based on attribute naming conventions)
-  _inferProperties(location, name, accessor) {
-    if (/instance/i.test(name)) {
-      // Any attribute containing the word "instance" will be assumed to be instanced
-      accessor.divisor = 1;
-    }
-  }
-
-  _addVarying(location, name, compositeType, size) {
-    const {type, components} = decomposeCompositeGLType(compositeType);
-    const accessor = new Accessor({type, size: size * components});
-
-    const varying = {location, name, accessor}; // Base values
-    this.varyingInfos.push(varying);
-    this.varyingInfosByName[varying.name] = varying; // For quick name based lookup
-  }
 }