@lobehub/lobehub 2.0.0-next.50 → 2.0.0-next.52

package/apps/desktop/src/main/modules/fileSearch/__tests__/macOS.integration.test.ts

@@ -0,0 +1,357 @@
+import path from 'node:path';
+import { describe, expect, it } from 'vitest';
+
+import { MacOSSearchServiceImpl } from '../impl/macOS';
+
+/**
+ * macOS File Search Integration Tests
+ *
+ * These tests run against the real macOS Spotlight service
+ * using files in the current repository.
+ *
+ * Run with: bunx vitest run 'macOS.integration.test'
+ */
+
+// Get repository root path (assumes test runs from apps/desktop)
+const repoRoot = path.resolve(__dirname, '../../../../..');
+
+describe.skipIf(process.platform !== 'darwin')('MacOSSearchServiceImpl Integration', () => {
+  const searchService = new MacOSSearchServiceImpl();
+
+  describe('checkSearchServiceStatus', () => {
+    it('should verify Spotlight is available on macOS', async () => {
+      const isAvailable = await searchService.checkSearchServiceStatus();
+
+      expect(isAvailable).toBe(true);
+    });
+  });
+
+  describe('search for known repository files', () => {
+    it('should find package.json in repo root', async () => {
+      const results = await searchService.search({
+        keywords: 'package.json',
+        limit: 10,
+        onlyIn: repoRoot,
+      });
+
+      expect(results.length).toBeGreaterThan(0);
+
+      // Should find at least one package.json
+      const packageJson = results.find((r) => r.name === 'package.json');
+      expect(packageJson).toBeDefined();
+      expect(packageJson!.type).toBe('json');
+      expect(packageJson!.path).toContain(repoRoot);
+    });
+
+    it('should find README files', async () => {
+      const results = await searchService.search({
+        keywords: 'README',
+        limit: 10,
+        onlyIn: repoRoot,
+      });
+      expect(results.length).toBeGreaterThan(0);
+
+      // Should contain markdown files
+      const mdFile = results.find((r) => r.type === 'md');
+      expect(mdFile).toBeDefined();
+      expect(mdFile!.name).toMatch(/README/i);
+    });
+
+    it('should find TypeScript files', async () => {
+      const results = await searchService.search({
+        keywords: 'macOS',
+        limit: 10,
+        onlyIn: repoRoot,
+      });
+
+      expect(results.length).toBeGreaterThan(0);
+
+      // Should find the macOS.ts implementation file
+      const macOSFile = results.find((r) => r.name.includes('macOS') && r.type === 'ts');
+      expect(macOSFile).toBeDefined();
+      expect(macOSFile!.contentType).toBe('code');
+    });
+
+    it('should find files in apps/desktop directory', async () => {
+      const desktopPath = path.join(repoRoot, 'apps/desktop');
+
+      const results = await searchService.search({
+        keywords: 'src',
+        limit: 20,
+        onlyIn: desktopPath,
+      });
+
+      // Spotlight indexing may not be complete for this directory
+      // so we make the test lenient
+      if (results.length > 0) {
+        // All results should be within apps/desktop
+        results.forEach((result) => {
+          expect(result.path).toContain('apps/desktop');
+        });
+      } else {
+        // eslint-disable-next-line no-console
+        console.warn(
+          '⚠️  No results found in apps/desktop - Spotlight indexing may not be complete',
+        );
+      }
+
+      // At minimum, verify the search completed without error
+      expect(Array.isArray(results)).toBe(true);
+    });
+
+    it('should find test files', async () => {
+      const results = await searchService.search({
+        keywords: 'test.ts',
+        limit: 10,
+        onlyIn: repoRoot,
+      });
+
+      expect(results.length).toBeGreaterThan(0);
+
+      // Should find test files
+      const testFile = results.find((r) => r.name.endsWith('.test.ts'));
+      expect(testFile).toBeDefined();
+      expect(testFile!.path).toContain('__tests__');
+    });
+  });
+
+  describe('search with filters', () => {
+    it('should respect limit parameter', async () => {
+      const limit = 3;
+      const results = await searchService.search({
+        keywords: 'src',
+        limit,
+        onlyIn: repoRoot,
+      });
+
+      expect(results.length).toBeLessThanOrEqual(limit);
+    });
+
+    it('should search in specific subdirectory only', async () => {
+      const srcPath = path.join(repoRoot, 'apps/desktop/src');
+
+      const results = await searchService.search({
+        keywords: 'index',
+        limit: 10,
+        onlyIn: srcPath,
+      });
+
+      // All results should be within the specified directory
+      results.forEach((result) => {
+        expect(result.path).toContain('apps/desktop/src');
+      });
+    });
+
+    it('should return empty array for non-existent keywords', async () => {
+      const results = await searchService.search({
+        keywords: 'xyzabc123unlikely-keyword-that-does-not-exist-12345',
+        limit: 5,
+        onlyIn: repoRoot,
+      });
+
+      expect(results).toEqual([]);
+    });
+  });
+
+  describe('file type detection', () => {
+    it('should correctly identify TypeScript files', async () => {
+      const results = await searchService.search({
+        keywords: 'LocalFileCtr',
+        limit: 5,
+        onlyIn: repoRoot,
+      });
+
+      const tsFile = results.find((r) => r.name === 'LocalFileCtr.ts');
+      if (tsFile) {
+        expect(tsFile.type).toBe('ts');
+        expect(tsFile.contentType).toBe('code');
+        expect(tsFile.isDirectory).toBe(false);
+      }
+    });
+
+    it('should correctly identify JSON files', async () => {
+      const results = await searchService.search({
+        keywords: 'tsconfig',
+        limit: 5,
+        onlyIn: repoRoot,
+      });
+
+      const jsonFile = results.find((r) => r.name.includes('tsconfig') && r.type === 'json');
+      if (jsonFile) {
+        expect(jsonFile.type).toBe('json');
+        expect(jsonFile.contentType).toBe('code');
+        expect(jsonFile.size).toBeGreaterThan(0);
+      }
+    });
+
+    it('should correctly identify directories', async () => {
+      const results = await searchService.search({
+        keywords: '__tests__',
+        limit: 10,
+        onlyIn: repoRoot,
+      });
+
+      const testDir = results.find((r) => r.name === '__tests__' && r.isDirectory);
+      if (testDir) {
+        expect(testDir.isDirectory).toBe(true);
+        expect(testDir.type).toBe('');
+      }
+    });
+
+    it('should correctly identify markdown files', async () => {
+      const results = await searchService.search({
+        keywords: 'CLAUDE.md',
+        limit: 5,
+        onlyIn: repoRoot,
+      });
+
+      const mdFile = results.find((r) => r.name === 'CLAUDE.md');
+      if (mdFile) {
+        expect(mdFile.type).toBe('md');
+        expect(mdFile.contentType).toBe('text');
+      }
+    });
+  });
+
+  describe('file metadata', () => {
+    it('should return valid file metadata', async () => {
+      const results = await searchService.search({
+        keywords: 'package.json',
+        limit: 1,
+        onlyIn: repoRoot,
+      });
+
+      expect(results.length).toBeGreaterThan(0);
+
+      const file = results[0];
+
+      // Verify all metadata fields are present
+      expect(file.path).toBeTruthy();
+      expect(file.name).toBeTruthy();
+      expect(typeof file.isDirectory).toBe('boolean');
+      expect(typeof file.size).toBe('number');
+      expect(file.size).toBeGreaterThanOrEqual(0);
+      expect(file.type).toBeDefined();
+      expect(file.contentType).toBeDefined();
+      expect(file.modifiedTime).toBeInstanceOf(Date);
+      expect(file.createdTime).toBeInstanceOf(Date);
+      expect(file.lastAccessTime).toBeInstanceOf(Date);
+
+      // Dates should be valid
+      expect(file.modifiedTime.getTime()).toBeGreaterThan(0);
+      expect(file.createdTime.getTime()).toBeGreaterThan(0);
+    });
+
+    it('should handle files with different extensions', async () => {
+      const testCases = [
+        { keyword: '.ts', expectedType: 'ts', expectedContentType: 'code' },
+        { keyword: '.json', expectedType: 'json', expectedContentType: 'code' },
+        { keyword: '.txt', expectedType: 'txt', expectedContentType: 'text' },
+      ];
+
+      for (const { keyword, expectedType, expectedContentType } of testCases) {
+        const results = await searchService.search({
+          keywords: keyword,
+          limit: 5,
+          onlyIn: repoRoot,
+        });
+
+        if (results.length > 0) {
+          const file = results.find((r) => r.type === expectedType);
+          if (file) {
+            expect(file.type).toBe(expectedType);
+            expect(file.contentType).toBe(expectedContentType);
+          }
+        }
+      }
+    });
+  });
+
+  describe('search accuracy after fix', () => {
+    it('should use fuzzy matching instead of exact phrase', async () => {
+      // Test the fix: keywords should do fuzzy matching, not exact phrase
+      // Before fix: "local file" would only match exact phrase "local file"
+      // After fix: "local file" should match "LocalFileCtr" (contains "local" and "file")
+
+      const results = await searchService.search({
+        keywords: 'LocalFile',
+        limit: 10,
+        onlyIn: repoRoot,
+      });
+
+      expect(results.length).toBeGreaterThan(0);
+
+      // Should find LocalFileCtr.ts or similar files
+      const found = results.some(
+        (r) => r.name.includes('LocalFile') || r.name.includes('localFile'),
+      );
+      expect(found).toBe(true);
+    });
+
+    it('should handle paths with spaces correctly', async () => {
+      // Test the fix: command args should be properly split
+      // This test verifies spawn receives correct arguments array
+
+      const pathWithSpaces = repoRoot; // May contain spaces in CI or certain setups
+      const results = await searchService.search({
+        keywords: 'test',
+        limit: 5,
+        onlyIn: pathWithSpaces,
+      });
+
+      // Should not throw error even if path contains spaces
+      expect(Array.isArray(results)).toBe(true);
+    });
+
+    it('should search case-insensitively', async () => {
+      // The "cd" flag in kMDItemFSName makes it case-insensitive
+
+      const lowerResults = await searchService.search({
+        keywords: 'readme',
+        limit: 5,
+        onlyIn: repoRoot,
+      });
+
+      const upperResults = await searchService.search({
+        keywords: 'README',
+        limit: 5,
+        onlyIn: repoRoot,
+      });
+
+      // Both searches should find similar files
+      expect(lowerResults.length).toBeGreaterThan(0);
+      expect(upperResults.length).toBeGreaterThan(0);
+    });
+  });
+
+  describe('error handling', () => {
+    it('should handle non-existent directory gracefully', async () => {
+      const nonExistentPath = path.join(repoRoot, 'this-directory-does-not-exist-12345');
+
+      const results = await searchService.search({
+        keywords: 'test',
+        limit: 5,
+        onlyIn: nonExistentPath,
+      });
+
+      // Should return empty array instead of throwing
+      expect(results).toEqual([]);
+    });
+  });
+
+  describe('updateSearchIndex', () => {
+    it.skip('should handle index update request', async () => {
+      // Index update requires elevated permissions, may fail in restricted environments
+      const result = await searchService.updateSearchIndex(repoRoot);
+
+      // Should return boolean (true if succeeded, false if failed)
+      expect(typeof result).toBe('boolean');
+    }, 15000); // Index update can take time
+  });
+});
+
+// Skip message for non-macOS platforms
+if (process.platform !== 'darwin') {
+  // eslint-disable-next-line no-console
+  console.log('⏭️  Skipping macOS integration tests on', process.platform, '(only runs on darwin)');
+}

package/apps/desktop/src/main/modules/fileSearch/impl/macOS.ts

@@ -23,12 +23,11 @@ export class MacOSSearchServiceImpl extends FileSearchImpl {
    */
   async search(options: SearchOptions): Promise<FileResult[]> {
     // Build the command first, regardless of execution method
-    const command = this.buildSearchCommand(options);
-    logger.debug(`Executing command: ${command}`);
+    const { cmd, args, commandString } = this.buildSearchCommand(options);
+    logger.debug(`Executing command: ${commandString}`);
 
     // Use spawn for both live and non-live updates to handle large outputs
     return new Promise((resolve, reject) => {
-      const [cmd, ...args] = command.split(' ');
       const childProcess = spawn(cmd, args);
 
       let results: string[] = []; // Store raw file paths
@@ -137,31 +136,39 @@ export class MacOSSearchServiceImpl extends FileSearchImpl {
   /**
    * Build mdfind command string
    * @param options Search options
-   * @returns Complete command string
+   * @returns Command components (cmd, args array, and command string for logging)
    */
-  private buildSearchCommand(options: SearchOptions): string {
-    // Basic command
-    let command = 'mdfind';
-
-    // Add options
-    const mdFindOptions: string[] = [];
+  private buildSearchCommand(options: SearchOptions): {
+    args: string[];
+    cmd: string;
+    commandString: string;
+  } {
+    // Command and arguments array
+    const cmd = 'mdfind';
+    const args: string[] = [];
 
     // macOS mdfind doesn't support -limit parameter, we'll limit results in post-processing
 
     // Search in specific directory
     if (options.onlyIn) {
-      mdFindOptions.push(`-onlyin "${options.onlyIn}"`);
+      args.push('-onlyin', options.onlyIn);
     }
 
     // Live update
     if (options.liveUpdate) {
-      mdFindOptions.push('-live');
+      args.push('-live');
     }
 
     // Detailed metadata
     if (options.detailed) {
-      mdFindOptions.push(
-        '-attr kMDItemDisplayName kMDItemContentType kMDItemKind kMDItemFSSize kMDItemFSCreationDate kMDItemFSContentChangeDate',
+      args.push(
+        '-attr',
+        'kMDItemDisplayName',
+        'kMDItemContentType',
+        'kMDItemKind',
+        'kMDItemFSSize',
+        'kMDItemFSCreationDate',
+        'kMDItemFSContentChangeDate',
       );
     }
 
@@ -171,9 +178,10 @@ export class MacOSSearchServiceImpl extends FileSearchImpl {
     // Basic query
     if (options.keywords) {
       // If the query string doesn't use Spotlight query syntax (doesn't contain kMDItem properties),
-      // treat it as plain text search
+      // treat it as a flexible name search rather than exact phrase match
       if (!options.keywords.includes('kMDItem')) {
-        queryExpression = `"${options.keywords.replaceAll('"', '\\"')}"`;
+        // Use kMDItemFSName for filename matching with wildcards for better flexibility
+        queryExpression = `kMDItemFSName == "*${options.keywords.replaceAll('"', '\\"')}*"cd`;
       } else {
         queryExpression = options.keywords;
       }
@@ -244,15 +252,15 @@ export class MacOSSearchServiceImpl extends FileSearchImpl {
       }
     }
 
-    // Combine complete command
-    if (mdFindOptions.length > 0) {
-      command += ' ' + mdFindOptions.join(' ');
+    // Add query expression to args
+    if (queryExpression) {
+      args.push(queryExpression);
     }
 
-    // Finally add query expression
-    command += ` ${queryExpression}`;
+    // Build command string for logging
+    const commandString = `${cmd} ${args.map((arg) => (arg.includes(' ') || arg.includes('*') ? `"${arg}"` : arg)).join(' ')}`;
 
-    return command;
+    return { args, cmd, commandString };
   }
 
   /**

package/changelog/v1.json

@@ -1,4 +1,22 @@
 [
+  {
+    "children": {
+      "fixes": [
+        "Filter out reasoning fields from messages in ChatCompletion API."
+      ]
+    },
+    "date": "2025-11-13",
+    "version": "2.0.0-next.52"
+  },
+  {
+    "children": {
+      "improvements": [
+        "Update ERNIE-5.0-Thinking-Preview model."
+      ]
+    },
+    "date": "2025-11-13",
+    "version": "2.0.0-next.51"
+  },
   {
     "children": {
       "fixes": [

package/locales/ar/chat.json

@@ -369,6 +369,26 @@
     "remained": "متبقي",
     "used": "مستخدم"
   },
+  "tool": {
+    "intervention": {
+      "approve": "الموافقة",
+      "approveAndRemember": "الموافقة والتذكر",
+      "approveOnce": "الموافقة لمرة واحدة فقط",
+      "mode": {
+        "allowList": "قائمة السماح",
+        "allowListDesc": "تنفيذ الأدوات المعتمدة فقط تلقائيًا",
+        "autoRun": "الموافقة التلقائية",
+        "autoRunDesc": "الموافقة تلقائيًا على تنفيذ جميع الأدوات",
+        "manual": "يدوي",
+        "manualDesc": "يتطلب الموافقة اليدوية في كل مرة يتم فيها الاستدعاء"
+      },
+      "reject": "رفض",
+      "rejectReasonPlaceholder": "إدخال سبب الرفض سيساعد الوكيل على الفهم وتحسين الإجراءات المستقبلية",
+      "rejectTitle": "رفض استدعاء الأداة هذه المرة",
+      "rejectedWithReason": "تم رفض استدعاء الأداة هذه المرة بشكل يدوي: {{reason}}",
+      "toolRejected": "تم رفض استدعاء الأداة هذه المرة بشكل يدوي"
+    }
+  },
   "topic": {
     "checkOpenNewTopic": "هل ترغب في فتح موضوع جديد؟",
     "checkSaveCurrentMessages": "هل ترغب في حفظ الدردشة الحالية كموضوع؟",

package/locales/ar/common.json

@@ -135,6 +135,7 @@
     }
   },
   "close": "إغلاق",
+  "confirm": "تأكيد",
   "contact": "اتصل بنا",
   "copy": "نسخ",
   "copyFail": "فشل في النسخ",

package/locales/ar/components.json

@@ -106,6 +106,12 @@
     "keyPlaceholder": "المفتاح",
     "valuePlaceholder": "القيمة"
   },
+  "LocalFile": {
+    "action": {
+      "open": "فتح",
+      "showInFolder": "عرض في المجلد"
+    }
+  },
   "MaxTokenSlider": {
     "unlimited": "غير محدود"
   },