@libraz/libcantus 0.9.2 → 0.9.4

package/dist/{chunk-R3S2LUBH.js → chunk-7NKDPF74.js}

@@ -1,18 +1,24 @@
 import {
   createRng
-} from "./chunk-BHUT2S5G.js";
+} from "./chunk-HKGYCQ34.js";
 import {
   beatsPerBar,
+  createNoteEventIndex,
   formatTimeSignature,
   isStrongBeat,
   metricWeight
-} from "./chunk-MSWFZF7J.js";
+} from "./chunk-YLEMGEFH.js";
+import {
+  isDiatonic,
+  parallelKey
+} from "./chunk-KMHOICIY.js";
 import {
   roleOf
-} from "./chunk-SDM3VJJ5.js";
+} from "./chunk-NKIBQ6PT.js";
 import {
-  enumerateSafePitches
-} from "./chunk-A4532ZFR.js";
+  enumerateSafePitches,
+  evaluateSafety
+} from "./chunk-NYYWMV2C.js";
 import {
   NATURAL_MINOR_MASK,
   chordPitchClasses,
@@ -26,9 +32,23 @@ import {
   minorKey,
   nearestScaleTone,
   scaleTonesInDegreeOrder
-} from "./chunk-7Y7WF64D.js";
+} from "./chunk-D2FAJBYL.js";
+import {
+  InvalidInputError,
+  assertFiniteNumber,
+  assertGenerationBudget,
+  assertInteger,
+  assertNoteEvents,
+  assertOneOf,
+  assertPositiveInt,
+  assertRange,
+  assertTimeSignature,
+  dropSilentNotes,
+  pitchClassOf
+} from "./chunk-XEBG3G53.js";
 
 // src/generate/bass/index.ts
+var BASS_STYLES = ["root", "rootFifth", "pop", "walking", "arpeggio"];
 var DEFAULT_TS = { numerator: 4, denominator: 4 };
 var DEFAULT_STYLE = "root";
 var DEFAULT_OCTAVE = 2;
@@ -36,9 +56,6 @@ var STRONG_VELOCITY = 100;
 var WEAK_VELOCITY = 80;
 var PICKUP_PROB = 0.35;
 var EPS = 1e-9;
-function pitchClass(value) {
-  return (Math.trunc(value) % 12 + 12) % 12;
-}
 function placePc(pc, anchor, low) {
   const high = low + 12;
   let midi = pc + 12 * Math.round((anchor - pc) / 12);
@@ -54,24 +71,24 @@ function chordTonePcs(chord) {
   const seen = /* @__PURE__ */ new Set();
   const pcs = [];
   for (const interval of chord.intervals) {
-    const pc = pitchClass(chord.rootPc + interval);
+    const pc = pitchClassOf(chord.rootPc + interval);
     if (!seen.has(pc)) {
       seen.add(pc);
       pcs.push(pc);
     }
   }
   if (pcs.length === 0) {
-    pcs.push(pitchClass(chord.rootPc));
+    pcs.push(pitchClassOf(chord.rootPc));
   }
   return pcs;
 }
 function fifthPcOf(chord) {
-  const fifths = new Set(chord.intervals.map((i) => pitchClass(i)));
+  const fifths = new Set(chord.intervals.map((i) => pitchClassOf(i)));
   const chosen = fifths.has(7) ? 7 : fifths.has(6) ? 6 : fifths.has(8) ? 8 : void 0;
-  return chosen === void 0 ? pitchClass(chord.rootPc) : pitchClass(chord.rootPc + chosen);
+  return chosen === void 0 ? pitchClassOf(chord.rootPc) : pitchClassOf(chord.rootPc + chosen);
 }
 function bassPcOf(chord) {
-  return pitchClass(chord.bassPc ?? chord.rootPc);
+  return pitchClassOf(chord.bassPc ?? chord.rootPc);
 }
 function beatPositions(start, end) {
   const positions = [];
@@ -110,7 +127,8 @@ function buildPop(ctx, seg) {
     } else if (ctx.rng.prob(PICKUP_PROB)) {
       if (ctx.rng.prob(0.5)) {
         const base = placePc(rootPc, ctx.prevMidi, ctx.low);
-        emit(ctx, pos, rootPc, Math.max(ctx.low, base - 12));
+        const dropped = base - 12;
+        emit(ctx, pos, rootPc, dropped >= 0 ? dropped : base);
       } else {
         ctx.prevMidi = emit(ctx, pos, fifthPcOf(seg.chord));
       }
@@ -130,12 +148,23 @@ function buildArpeggio(ctx, seg) {
 }
 function approachNote(ctx, target, from) {
   const dir = from <= target ? -1 : 1;
+  const chromatic = target + dir;
   if (ctx.rng.prob(0.5)) {
-    return target + dir;
+    return foldIntoBand(chromatic, ctx.low);
   }
   const cand = nearestScaleTone(target + dir * 2, ctx.key);
   const step = Math.abs(cand - target);
-  return step >= 1 && step <= 2 ? cand : target + dir;
+  return foldIntoBand(step >= 1 && step <= 2 ? cand : chromatic, ctx.low);
+}
+function foldIntoBand(midi, low) {
+  let result = midi;
+  while (result < low) {
+    result += 12;
+  }
+  while (result > low + 12) {
+    result -= 12;
+  }
+  return result;
 }
 function buildWalking(ctx, seg, next) {
   const tones = chordTonePcs(seg.chord);
@@ -149,7 +178,7 @@ function buildWalking(ctx, seg, next) {
     if (next && count > 1 && i === count - 1) {
       const nextBass = placePc(bassPcOf(next.chord), ctx.prevMidi, ctx.low);
       const midi = approachNote(ctx, nextBass, ctx.prevMidi);
-      ctx.prevMidi = emit(ctx, pos, pitchClass(midi), midi);
+      ctx.prevMidi = emit(ctx, pos, pitchClassOf(midi), midi);
       return;
     }
     const pc = tones[i % tones.length] ?? bassPcOf(seg.chord);
@@ -157,13 +186,30 @@ function buildWalking(ctx, seg, next) {
   });
 }
 function generateBassLine(opts) {
+  assertGenerationBudget(opts.segments.length, "bass segments");
+  for (let index = 0; index < opts.segments.length; index += 1) {
+    const segment = opts.segments[index];
+    if (!segment) continue;
+    assertRange(segment.startBeat, 0, Number.MAX_SAFE_INTEGER, `segments[${index}].startBeat`);
+    assertRange(segment.endBeat, 0, Number.MAX_SAFE_INTEGER, `segments[${index}].endBeat`);
+    if (segment.endBeat <= segment.startBeat) {
+      throw new InvalidInputError(`segments[${index}] must have a positive duration`);
+    }
+  }
   const segments = [...opts.segments].sort((a, b) => a.startBeat - b.startBeat);
   if (segments.length === 0) {
     return [];
   }
   const ts = opts.ts ?? DEFAULT_TS;
-  const style = opts.style ?? DEFAULT_STYLE;
+  assertTimeSignature(ts);
+  const style = assertOneOf(opts.style ?? DEFAULT_STYLE, BASS_STYLES, "bass style");
   const octave = opts.octave ?? DEFAULT_OCTAVE;
+  assertInteger(octave, "bass octave", -1, 9);
+  const estimatedNotes = segments.reduce(
+    (count, segment) => count + Math.max(1, Math.ceil(segment.endBeat - segment.startBeat)),
+    0
+  );
+  assertGenerationBudget(estimatedNotes, "bass notes");
   const low = octave * 12 + 12;
   const ctx = {
     ts,
@@ -231,25 +277,31 @@ var HOLD_OFF_BEAT_PROB = 0.2;
 var REINFORCE_PROB = 0.35;
 var DEFAULT_MELODY_VELOCITY = 96;
 var VELOCITY_DROP = 16;
+var TIE_BREAK_JITTER = 1e-6;
 function isWholeBeat(beat) {
   return Math.abs(beat - Math.round(beat)) < EPS2;
 }
 function melodyNoteAt(melody, beat) {
-  let found;
-  for (const note of melody) {
-    if (note.startBeat - EPS2 <= beat && beat < note.startBeat + note.durationBeat - EPS2) {
-      if (!found || note.startBeat > found.startBeat) {
-        found = note;
-      }
-    }
-  }
-  return found;
+  return melody.at(beat)?.note;
 }
 function melodyAttacksAt(melody, beat) {
-  return melody.some((note) => Math.abs(note.startBeat - beat) < EPS2);
+  return melody.attacksAt(beat);
+}
+function melodySnapshotAt(melody, beat) {
+  const current = melodyNoteAt(melody, beat);
+  if (current === void 0) {
+    return void 0;
+  }
+  const attacked = Math.abs(current.startBeat - beat) < EPS2;
+  const previous = attacked ? melodyNoteAt(melody, beat - EPS2 * 2) : current;
+  const snapshot = { pitch: current.pitch };
+  if (previous !== void 0) {
+    snapshot.prevPitch = previous.pitch;
+  }
+  return snapshot;
 }
 function followOnsets(melody) {
-  return [...new Set(melody.map((note) => note.startBeat))].sort((a, b) => a - b);
+  return [...new Set(melody.notes.map(({ note }) => note.startBeat))];
 }
 function complementOnsets(melody, ts, spanStart, spanEnd, rng) {
   const onsets = [];
@@ -312,54 +364,134 @@ function scoreCandidate(pitch, melPitch, melPrev, prevPitch, chord, center) {
   score -= Math.abs(pitch - center) * 0.02;
   return score;
 }
-function fallbackPitch(melPitch, prevPitch, center, register, low, high, key) {
-  let target = prevPitch ?? Math.round(center);
-  if (melPitch !== void 0) {
-    if (register === "below" && target >= melPitch) {
-      target = melPitch - 5;
-    } else if (register === "above" && target <= melPitch) {
-      target = melPitch + 5;
+function heldNoteBoundaries(melody, startBeat, endBeat, chordChangeBeats) {
+  const boundaries = /* @__PURE__ */ new Set([startBeat]);
+  for (const onset of melody.onsetsBetween(startBeat, endBeat)) {
+    boundaries.add(onset);
+  }
+  for (const beat of chordChangeBeats) {
+    if (beat > startBeat + EPS2 && beat < endBeat - EPS2) {
+      boundaries.add(beat);
     }
   }
-  target = Math.min(Math.max(target, low), high);
-  let pitch = nearestScaleTone(target, key);
-  if (melPitch !== void 0) {
-    while (register === "below" && pitch >= melPitch && pitch - 12 >= low) {
-      pitch -= 12;
+  const firstGrid = Math.floor(startBeat / GRID_STEP + 1) * GRID_STEP;
+  for (let beat = firstGrid; beat < endBeat - EPS2; beat += GRID_STEP) {
+    boundaries.add(beat);
+  }
+  return [...boundaries].sort((a, b) => a - b);
+}
+function boundaryContexts(melody, harmony, startBeat, endBeat, ts) {
+  const boundaries = heldNoteBoundaries(melody, startBeat, endBeat, harmony.chordChangeBeats);
+  return boundaries.map((boundary) => {
+    const melodyVoice = melodySnapshotAt(melody, boundary);
+    return {
+      melodyVoice,
+      otherVoices: melodyVoice === void 0 ? [] : [melodyVoice],
+      chord: harmony.chordAt(boundary),
+      strongBeat: isStrongBeat(boundary, ts),
+      atCounterOnset: Math.abs(boundary - startBeat) < EPS2
+    };
+  });
+}
+function heldPitchSafety(pitch, contexts, prevPitch, key, profile, register, low, high) {
+  let worst = 0 /* Safe */;
+  for (const context of contexts) {
+    const melodyVoice = context.melodyVoice;
+    if (melodyVoice !== void 0 && (register === "below" && pitch >= melodyVoice.pitch || register === "above" && pitch <= melodyVoice.pitch)) {
+      return null;
     }
-    while (register === "above" && pitch <= melPitch && pitch + 12 <= high) {
-      pitch += 12;
+    const result = evaluateSafety(
+      {
+        profile,
+        candidatePitch: pitch,
+        prevPitch: context.atCounterOnset ? prevPitch : pitch,
+        chord: context.chord,
+        key,
+        otherVoices: context.otherVoices,
+        strongBeat: context.strongBeat,
+        vocalLow: low,
+        vocalHigh: high
+      },
+      { suggestions: false }
+    );
+    worst = Math.max(worst, result.safety);
+    if (worst === 2 /* Dissonant */) {
+      return worst;
     }
   }
-  return Math.min(Math.max(pitch, low), high);
+  return worst;
 }
 function generateCounterMelody(opts) {
-  const melody = [...opts.melody].sort((a, b) => a.startBeat - b.startBeat);
-  if (melody.length === 0) {
-    return [];
+  const timeline = opts.timeline;
+  const chordAt = timeline === void 0 ? opts.chordAt : (beat) => timeline.at(beat);
+  if (chordAt === void 0) {
+    throw new TypeError("countermelody needs a timeline or a chordAt callback");
   }
-  const ts = opts.ts ?? DEFAULT_TS2;
+  const chordChangeBeats = timeline === void 0 ? opts.chordChangeBeats ?? [] : timeline.segments.flatMap((segment) => [segment.startBeat, segment.endBeat]);
   const register = opts.register ?? "below";
-  const rhythm = opts.rhythm ?? "complement";
-  const profile = opts.profile ?? "pop";
+  const melody = createNoteEventIndex(opts.melody, {
+    allowNonPositiveDuration: true,
+    tieBreak: register === "below" ? "highest" : "lowest"
+  });
+  const ts = opts.ts ?? DEFAULT_TS2;
+  assertTimeSignature(ts);
+  const rhythm = assertOneOf(opts.rhythm ?? "complement", ["complement", "follow"], "rhythm");
+  const profile = assertOneOf(opts.profile ?? "pop", ["strict", "pop"], "safety profile");
   const rng = createRng(opts.seed ?? 0);
-  const spanStart = melody[0]?.startBeat ?? 0;
-  const spanEnd = melody.reduce((end, n) => Math.max(end, n.startBeat + n.durationBeat), spanStart);
-  const meanPitch = melody.reduce((sum, n) => sum + n.pitch, 0) / melody.length;
+  if (opts.pitchLow !== void 0) {
+    assertInteger(opts.pitchLow, "countermelody pitchLow");
+  }
+  if (opts.pitchHigh !== void 0) {
+    assertInteger(opts.pitchHigh, "countermelody pitchHigh");
+  }
+  if (melody.notes.every((indexed) => indexed.note.durationBeat <= 0)) {
+    return [];
+  }
+  const spanStart = melody.notes[0]?.note.startBeat ?? 0;
+  const spanEnd = melody.notes.reduce((end, n) => Math.max(end, n.endBeat), spanStart);
+  assertGenerationBudget(Math.ceil((spanEnd - spanStart) / GRID_STEP), "countermelody grid");
+  const meanPitch = melody.notes.reduce((sum, n) => sum + n.note.pitch, 0) / melody.notes.length;
   const defaultCenter = register === "below" ? meanPitch - REGISTER_OFFSET : meanPitch + REGISTER_OFFSET;
   const low = opts.pitchLow ?? Math.round(defaultCenter) - DEFAULT_HALF_RANGE;
   const high = opts.pitchHigh ?? Math.round(defaultCenter) + DEFAULT_HALF_RANGE;
+  assertInteger(low, "countermelody pitchLow");
+  assertInteger(high, "countermelody pitchHigh");
+  if (low > high) {
+    throw new InvalidInputError(
+      `countermelody pitchLow must not exceed pitchHigh; received ${low} > ${high}`
+    );
+  }
+  assertGenerationBudget(high - low + 1, "countermelody pitch candidates");
+  assertGenerationBudget(chordChangeBeats.length, "chord change beats");
+  for (let index = 0; index < chordChangeBeats.length; index += 1) {
+    assertRange(
+      chordChangeBeats[index] ?? Number.NaN,
+      0,
+      Number.MAX_SAFE_INTEGER,
+      `chordChangeBeats[${index}]`
+    );
+  }
   const center = (low + high) / 2;
   const onsets = rhythm === "follow" ? followOnsets(melody) : complementOnsets(melody, ts, spanStart, spanEnd, rng);
+  const boundaryEstimate = onsets.length + Math.ceil((spanEnd - spanStart) / GRID_STEP) + melody.notes.length + chordChangeBeats.length;
+  assertGenerationBudget(boundaryEstimate * (high - low + 1), "countermelody search");
+  const jitter = Array.from({ length: high - low + 1 }, () => rng.next() * TIE_BREAK_JITTER);
   const out = [];
   let prevPitch;
-  let prevOnset;
-  for (const beat of onsets) {
+  for (let onsetIndex = 0; onsetIndex < onsets.length; onsetIndex += 1) {
+    const beat = onsets[onsetIndex];
+    if (beat === void 0) {
+      continue;
+    }
+    const nextOnset = onsets[onsetIndex + 1];
+    const endBeat = nextOnset ?? Math.max(spanEnd, beat + GRID_STEP);
     const melNote = melodyNoteAt(melody, beat);
     const melPitch = melNote?.pitch;
-    const melPrev = prevOnset !== void 0 ? melodyNoteAt(melody, prevOnset)?.pitch : void 0;
-    const chord = opts.chordAt(beat);
-    const otherVoices = melPitch !== void 0 ? [{ pitch: melPitch, prevPitch: melPrev }] : [];
+    const melodyVoice = melodySnapshotAt(melody, beat);
+    const melPrev = melodyVoice?.prevPitch;
+    const contexts = boundaryContexts(melody, { chordAt, chordChangeBeats }, beat, endBeat, ts);
+    const chord = contexts[0]?.chord ?? chordAt(beat);
+    const otherVoices = melodyVoice !== void 0 ? [melodyVoice] : [];
     const candidates = enumerateSafePitches(
       {
         profile,
@@ -375,45 +507,48 @@ function generateCounterMelody(opts) {
       high
     );
     let bestPitch;
+    let bestWorstSafety = 2 /* Dissonant */;
     let bestScore = Number.NEGATIVE_INFINITY;
     for (const candidate of candidates) {
+      const worstSafety = heldPitchSafety(
+        candidate,
+        contexts,
+        prevPitch,
+        opts.key,
+        profile,
+        register,
+        low,
+        high
+      );
+      if (worstSafety === null || worstSafety === 2 /* Dissonant */) {
+        continue;
+      }
       if (melPitch !== void 0) {
-        if (register === "below" && candidate >= melPitch) {
-          continue;
-        }
-        if (register === "above" && candidate <= melPitch) {
-          continue;
-        }
         if (prevPitch !== void 0 && melPrev !== void 0 && // Parallel octaves are the perfect-class-zero case of this predicate,
         // so a single check covers both parallel fifths and octaves.
         createsParallelPerfect(prevPitch, candidate, melPrev, melPitch)) {
           continue;
         }
       }
-      const score = scoreCandidate(candidate, melPitch, melPrev, prevPitch, chord, center);
+      const score = scoreCandidate(candidate, melPitch, melPrev, prevPitch, chord, center) + (jitter[candidate - low] ?? 0);
       const tie = Math.abs(score - bestScore) <= EPS2 && candidate < (bestPitch ?? Number.POSITIVE_INFINITY);
-      if (score > bestScore + EPS2 || tie) {
+      if (worstSafety < bestWorstSafety || worstSafety === bestWorstSafety && (score > bestScore + EPS2 || tie)) {
+        bestWorstSafety = worstSafety;
         bestScore = score;
         bestPitch = candidate;
       }
     }
-    const pitch = bestPitch ?? fallbackPitch(melPitch, prevPitch, center, register, low, high, opts.key);
+    if (bestPitch === void 0) {
+      prevPitch = void 0;
+      continue;
+    }
+    const pitch = bestPitch;
     const velocity = Math.max(
       1,
       Math.min(127, Math.round((melNote?.velocity ?? DEFAULT_MELODY_VELOCITY) - VELOCITY_DROP))
     );
-    out.push({ pitch, startBeat: beat, durationBeat: GRID_STEP, velocity });
+    out.push({ pitch, startBeat: beat, durationBeat: endBeat - beat, velocity });
     prevPitch = pitch;
-    prevOnset = beat;
-  }
-  for (let i = 0; i < out.length; i += 1) {
-    const note = out[i];
-    if (!note) {
-      continue;
-    }
-    const next = out[i + 1];
-    const end = next ? next.startBeat : Math.max(spanEnd, note.startBeat + GRID_STEP);
-    note.durationBeat = end - note.startBeat;
   }
   return out;
 }
@@ -437,6 +572,27 @@ var GM = {
 };
 var EIGHTH = 0.5;
 var SIXTEENTH = 0.25;
+var DRUM_FEELS = ["straight", "swing", "shuffle"];
+var GROOVE_STYLES = [
+  "standard",
+  "funk",
+  "shuffle",
+  "bossa",
+  "trap",
+  "halftime",
+  "breakbeat",
+  "house",
+  "synthpop"
+];
+var DRUM_ROLES = ["full", "ambient", "minimal", "fxOnly"];
+var PUBLIC_SECTIONS = [
+  "intro",
+  "verse",
+  "prechorus",
+  "chorus",
+  "bridge",
+  "outro"
+];
 var STYLE_MAP = {
   // Standard pop pulse: kick on beats 1 and 3, backbeat snare on 2 and 4.
   standard: { style: "standard", feel: "straight", ghostBoost: false, snareBeat3: false },
@@ -636,7 +792,7 @@ function getGhostDensity(mood, section, backingDensity, bpm) {
   }
   return levelToProbability(level);
 }
-function getGhostVelocity(section, beatPosition, isAfterSnare) {
+function getGhostVelocity(section, beatPosition) {
   let base = 0.4;
   const even = beatPosition % 2 === 0 ? 0.05 : 0;
   switch (section) {
@@ -657,14 +813,11 @@ function getGhostVelocity(section, beatPosition, isAfterSnare) {
       base = 0.38;
       break;
   }
-  if (isAfterSnare) {
-    base += 0.1;
-  }
   return Math.max(0.25, Math.min(0.65, base));
 }
 function getGhostProbabilityAtPosition(beat, sixteenthInBeat) {
-  const nearSnare = beat === 0 && sixteenthInBeat === 3 || beat === 1 && sixteenthInBeat === 1 || beat === 2 && sixteenthInBeat === 3 || beat === 3 && sixteenthInBeat === 1;
-  return nearSnare ? 0.6 : 0.25;
+  const leadsIntoBackbeat = (beat === 0 || beat === 2) && sixteenthInBeat === 3;
+  return leadsIntoBackbeat ? 0.6 : 0.25;
 }
 function selectGhostPositions(mood, rng) {
   if (mood === 2 /* Energetic */) {
@@ -947,10 +1100,7 @@ function quantizeSwing(startBeat, swing, resolution) {
 }
 
 // src/generate/drums/beat.ts
-function swing16(tick, feel, swingAmount) {
-  return quantizeSwing(tick, effectiveSwing(feel, swingAmount), "sixteenth");
-}
-function hatSwingFactor(style) {
+function styleSwingFactor(style) {
   if (style === "trap") {
     return 0;
   }
@@ -959,6 +1109,12 @@ function hatSwingFactor(style) {
   }
   return 0.5;
 }
+function sectionSwing(sec, swingAmount) {
+  return effectiveSwing(sec.feel, swingAmount) * styleSwingFactor(sec.style);
+}
+function swing16(tick, sec, swingAmount) {
+  return quantizeSwing(tick, sectionSwing(sec, swingAmount), "sixteenth");
+}
 function generateKickForBeat(ctx, sec, kick) {
   if (ctx.inPrechorusLift) {
     return;
@@ -969,7 +1125,7 @@ function generateKickForBeat(ctx, sec, kick) {
     ctx.track.add(GM.BD, ctx.beatTick, EIGHTH, ctx.velocity);
   }
   if (and) {
-    const andTick = swing16(ctx.beatTick + EIGHTH, sec.feel, ctx.swingAmount);
+    const andTick = swing16(ctx.beatTick + EIGHTH, sec, ctx.swingAmount);
     ctx.track.add(GM.BD, andTick, EIGHTH, ctx.velocity * 0.85);
   }
 }
@@ -986,12 +1142,17 @@ function generateSnareForBeat(ctx, sec, isIntroFirst) {
   }
   const backbeatVel = Math.min(127, ctx.velocity + 16);
   const promoteSparseChorus = sec.style === "sparse" && ctx.section === "chorus" && sec.role === "full";
+  if (sec.role === "fxOnly") {
+    return;
+  }
+  if (sec.role === "minimal") {
+    ctx.track.add(GM.SIDESTICK, ctx.beatTick, EIGHTH, ctx.velocity * 0.65);
+    return;
+  }
   if (promoteSparseChorus) {
     ctx.track.add(GM.SD, ctx.beatTick, EIGHTH, backbeatVel);
   } else if (sec.style === "sparse" || sec.role === "ambient") {
-    if (sec.role !== "fxOnly" && sec.role !== "minimal") {
-      ctx.track.add(GM.SIDESTICK, ctx.beatTick, EIGHTH, ctx.velocity * 0.8);
-    }
+    ctx.track.add(GM.SIDESTICK, ctx.beatTick, EIGHTH, ctx.velocity * 0.8);
   } else {
     ctx.track.add(GM.SD, ctx.beatTick, EIGHTH, backbeatVel);
   }
@@ -1012,13 +1173,13 @@ function generateGhostNotesForBeat(ctx, sec) {
       continue;
     }
     const variation = ctx.rng.float(0.85, 1.15);
-    const ghostBase = getGhostVelocity(ctx.section, ctx.beat / 2, false);
+    const ghostBase = getGhostVelocity(ctx.section, ctx.beat / 2);
     let ghostVel = ctx.velocity * ghostBase * variation;
     if (pos === "a") {
       ghostVel *= 0.9;
     }
     const offset = pos === "e" ? SIXTEENTH : 3 * SIXTEENTH;
-    const tick = swing16(ctx.beatTick + offset, sec.feel, ctx.swingAmount);
+    const tick = swing16(ctx.beatTick + offset, sec, ctx.swingAmount);
     ctx.track.add(GM.SD, tick, SIXTEENTH, ghostVel);
   }
 }
@@ -1080,7 +1241,7 @@ function generateHiHatForBeat(ctx, sec) {
     for (let eighth = 0; eighth < 2; eighth += 1) {
       let hhTick = ctx.beatTick + eighth * EIGHTH;
       if (eighth === 1) {
-        hhTick = swing16(hhTick, sec.feel, ctx.swingAmount);
+        hhTick = swing16(hhTick, sec, ctx.swingAmount);
       }
       if (ctx.section === "intro" && eighth === 1) {
         if (sec.useFootHh && ctx.beat % 2 === 0) {
@@ -1110,9 +1271,8 @@ function generateHiHatForBeat(ctx, sec) {
   }
   for (let sixteenth = 0; sixteenth < 4; sixteenth += 1) {
     let hhTick = ctx.beatTick + sixteenth * SIXTEENTH;
-    if (sixteenth === 1 || sixteenth === 3) {
-      const swung = effectiveSwing(sec.feel, ctx.swingAmount) * hatSwingFactor(sec.style);
-      hhTick = quantizeSwing(hhTick, swung, "sixteenth");
+    if (sixteenth !== 0) {
+      hhTick = swing16(hhTick, sec, ctx.swingAmount);
     }
     const metricVel = hiHatVelocityMultiplier(sixteenth, ctx.rng);
     const hhVel = Math.max(20, ctx.velocity * dm * typeMult * metricVel);
@@ -1133,9 +1293,10 @@ function generateHiHatForBeat(ctx, sec) {
 
 // src/generate/drums/euclid.ts
 function euclideanRhythm(pulses, steps, rotation = 0) {
-  if (steps < 1) {
-    return [];
-  }
+  assertPositiveInt(steps, "euclidean steps");
+  assertInteger(pulses, "euclidean pulses");
+  assertInteger(rotation, "euclidean rotation");
+  assertGenerationBudget(steps, "euclidean pattern steps");
   const p = Math.max(0, Math.min(pulses, steps));
   const base = bjorklund(p, steps);
   const shift = (rotation % steps + steps) % steps;
@@ -1144,18 +1305,6 @@ function euclideanRhythm(pulses, steps, rotation = 0) {
   }
   return base.map((_, i) => base[(i - shift + steps) % steps] ?? false);
 }
-function hasHit(mask, step) {
-  return (mask >> step & 1) === 1;
-}
-function patternToMask(pattern) {
-  let mask = 0;
-  for (let i = 0; i < pattern.length; i += 1) {
-    if (pattern[i]) {
-      mask |= 1 << i;
-    }
-  }
-  return mask;
-}
 function bjorklund(pulses, steps) {
   if (pulses === 0) {
     return Array.from({ length: steps }, () => false);
@@ -1451,24 +1600,62 @@ function generateFill(track, beatTick, beat, fillType, velocity) {
 }
 
 // src/generate/drums/hit.ts
+var DRUM_NOTES = {
+  kick: GM.BD,
+  snare: GM.SD,
+  sideStick: GM.SIDESTICK,
+  handClap: GM.HANDCLAP,
+  closedHiHat: GM.CHH,
+  pedalHiHat: GM.FHH,
+  openHiHat: GM.OHH,
+  crash: GM.CRASH,
+  ride: GM.RIDE,
+  tambourine: GM.TAMBOURINE,
+  highTom: GM.TOM_H,
+  midTom: GM.TOM_M,
+  lowTom: GM.TOM_L,
+  shaker: GM.SHAKER
+};
+var VOICE_BY_NOTE = new Map(
+  Object.entries(DRUM_NOTES).map(([voice, note]) => [note, voice])
+);
+function drumVoiceOf(pitch) {
+  return VOICE_BY_NOTE.get(pitch);
+}
+var ONSET_KEY_SCALE = 128;
 var HitList = class {
   hits = [];
+  /** Onset keys already occupied, as `pitch:quantizedBeat`. */
+  #onsets = /* @__PURE__ */ new Set();
   /** Append a hit, clamping velocity and dropping non-positive positions. */
   add(pitch, startBeat, durationBeat, velocity) {
+    const beat = Math.max(0, startBeat);
     this.hits.push({
       pitch,
-      startBeat: Math.max(0, startBeat),
+      startBeat: beat,
       durationBeat,
       velocity: clampVel(velocity)
     });
+    this.#onsets.add(onsetKey(pitch, beat));
+  }
+  /** Whether a hit of this pitch already starts exactly at `startBeat`. */
+  hasOnset(pitch, startBeat) {
+    return this.#onsets.has(onsetKey(pitch, startBeat));
   }
   /** True when a crash already sits within a 16th of `startBeat`. */
   hasCrashNear(startBeat) {
-    return this.hits.some(
-      (h) => h.pitch === GM.CRASH && h.startBeat >= startBeat && h.startBeat < startBeat + 0.25
-    );
+    const steps = Math.round(0.25 * ONSET_KEY_SCALE);
+    for (let step = 0; step < steps; step += 1) {
+      if (this.#onsets.has(onsetKey(GM.CRASH, startBeat + step / ONSET_KEY_SCALE))) {
+        return true;
+      }
+    }
+    return false;
   }
 };
+function onsetKey(pitch, startBeat) {
+  return `${pitch}:${Math.round(startBeat * ONSET_KEY_SCALE)}`;
+}
 
 // src/generate/drums/kick.ts
 var EMPTY = {
@@ -1487,19 +1674,6 @@ function isInPreChorusLift(section, bar, sectionBars, nextIsChorus) {
   }
   return bar >= sectionBars - 2;
 }
-function euclideanToKickPattern(mask) {
-  const slot = (step) => hasHit(mask, step) || hasHit(mask, (step + 15) % 16);
-  return {
-    beat1: slot(0),
-    beat1and: slot(2),
-    beat2: slot(4),
-    beat2and: slot(6),
-    beat3: slot(8),
-    beat3and: slot(10),
-    beat4: slot(12),
-    beat4and: slot(14)
-  };
-}
 function getKickPattern(section, style, bar, rng) {
   const p = { ...EMPTY };
   if (section === "outro") {
@@ -1621,7 +1795,7 @@ function getPercussionConfig(mood, section) {
   };
 }
 function generateAuxPercussionForBar(track, barStart, config, role, densityMult, rng, bpm) {
-  if (role === "minimal" || role === "fxOnly") {
+  if (role === "minimal") {
     return;
   }
   if (config.tambourine) {
@@ -1669,15 +1843,31 @@ function generateAuxPercussionForBar(track, barStart, config, role, densityMult,
 }
 
 // src/generate/drums/index.ts
+var MAX_HITS_PER_BAR = 128;
 function generateDrums(opts) {
+  assertPositiveInt(opts.bars, "drum bars");
+  assertRange(opts.bpm, Number.MIN_VALUE, 1e3, "drum bpm");
+  assertRange(opts.density, 0, 1, "drum density");
+  assertGenerationBudget(opts.bars * MAX_HITS_PER_BAR, "drum hits");
+  if (opts.euclideanKick) {
+    const steps = opts.euclideanKick.steps ?? 16;
+    assertInteger(steps, "euclidean steps", 1, 16);
+    assertInteger(opts.euclideanKick.pulses, "euclidean pulses");
+    assertInteger(opts.euclideanKick.rotation ?? 0, "euclidean rotation");
+  }
+  const publicStyle = assertOneOf(opts.style, GROOVE_STYLES, "drum style");
+  const publicSection = assertOneOf(opts.section, PUBLIC_SECTIONS, "drum section");
+  if (opts.nextSection !== void 0) {
+    assertOneOf(opts.nextSection, PUBLIC_SECTIONS, "drum nextSection");
+  }
   const track = new HitList();
   const rng = createRng(opts.seed ?? 0);
-  const mapping = mapStyle(opts.style);
+  const mapping = mapStyle(publicStyle);
   const style = mapping.style;
-  const feel = opts.feel ?? mapping.feel;
-  const role = opts.role ?? "full";
+  const feel = opts.feel === void 0 ? mapping.feel : assertOneOf(opts.feel, DRUM_FEELS, "drum feel");
+  const role = opts.role === void 0 ? "full" : assertOneOf(opts.role, DRUM_ROLES, "drum role");
   const playMainVoices = role !== "fxOnly";
-  const section = mapSection(opts.section);
+  const section = mapSection(publicSection);
   const backingDensity = mapDensity(opts.density);
   const swingAmount = feelSwingAmount(feel);
   let densityMult = sectionDensityMultiplier(section);
@@ -1706,15 +1896,8 @@ function generateDrums(opts) {
   const percMood = percMoodCategory(style);
   const nextSection = opts.nextSection ? mapSection(opts.nextSection) : section;
   const nextEnergy = sectionEnergy(nextSection);
-  const euclidKick = opts.euclideanKick ? euclideanToKickPattern(
-    patternToMask(
-      euclideanRhythm(
-        opts.euclideanKick.pulses,
-        opts.euclideanKick.steps ?? 16,
-        opts.euclideanKick.rotation ?? 0
-      )
-    )
-  ) : void 0;
+  const euclidSteps = opts.euclideanKick?.steps ?? 16;
+  const euclidKick = opts.euclideanKick ? euclideanRhythm(opts.euclideanKick.pulses, euclidSteps, opts.euclideanKick.rotation ?? 0) : void 0;
   const reuseSectionKick = (section === "b" || section === "chorus") && style !== "sparse";
   let sectionKick;
   for (let bar = 0; bar < opts.bars; bar += 1) {
@@ -1730,15 +1913,13 @@ function generateDrums(opts) {
       barHasOpenHh = !track.hasCrashNear(barStart + openHhBeatIndex);
     }
     let kick;
-    if (euclidKick) {
-      kick = euclidKick;
-    } else if (reuseSectionKick) {
+    if (!euclidKick && reuseSectionKick) {
       sectionKick ??= getKickPattern(section, style, 0, rng);
       kick = sectionKick;
-    } else {
+    } else if (!euclidKick) {
       kick = getKickPattern(section, style, bar, rng);
     }
-    const inLift = isInPreChorusLift(section, bar, opts.bars, section === "b");
+    const inLift = isInPreChorusLift(section, bar, opts.bars, nextSection === "chorus");
     let currentFill = "snareRoll";
     for (let beat = 0; beat < 4; beat += 1) {
       const beatTick = barStart + beat;
@@ -1776,7 +1957,23 @@ function generateDrums(opts) {
         if (inLift) {
           generatePreChorusBuildup(ctx, sec, isLastBar);
         }
-        generateKickForBeat(ctx, sec, kick);
+        if (euclidKick && !inLift) {
+          const stepLength = 4 / euclidSteps;
+          for (let step = 0; step < euclidKick.length; step += 1) {
+            const onset = step * stepLength;
+            if (euclidKick[step] && Math.floor(onset) === beat) {
+              const wholeBeat = Math.abs(onset - Math.round(onset)) < 1e-9;
+              track.add(
+                GM.BD,
+                barStart + onset,
+                Math.min(0.5, stepLength),
+                velocity * (wholeBeat ? 1 : 0.85)
+              );
+            }
+          }
+        } else if (kick) {
+          generateKickForBeat(ctx, sec, kick);
+        }
         generateSnareForBeat(ctx, sec, section === "intro" && bar === 0);
         if (sec.useGhostNotes && !inLift) {
           generateGhostNotesForBeat(ctx, sec);
@@ -1787,27 +1984,36 @@ function generateDrums(opts) {
     if (sec.useFootHh && shouldPlayHiHat(role)) {
       for (let fhhBeat = 0; fhhBeat < 4; fhhBeat += 2) {
         const fhhTick = barStart + fhhBeat;
-        const occupied = track.hits.some((h) => h.pitch === GM.FHH && h.startBeat === fhhTick);
-        if (!occupied) {
+        if (!track.hasOnset(GM.FHH, fhhTick)) {
           track.add(GM.FHH, fhhTick, 0.5, footHiHatVelocity(rng));
         }
       }
     }
+    let percussionConfig = getPercussionConfig(percMood, section);
+    if (role === "fxOnly" && !percussionConfig.tambourine && !percussionConfig.shaker && !percussionConfig.handclap) {
+      percussionConfig = {
+        tambourine: false,
+        shaker: true,
+        handclap: false,
+        shaker16th: false
+      };
+    }
     generateAuxPercussionForBar(
       track,
       barStart,
-      getPercussionConfig(percMood, section),
+      percussionConfig,
       role,
       densityMult,
       rng,
       opts.bpm
     );
   }
-  return track.hits;
+  return [...track.hits].sort((a, b) => a.startBeat - b.startBeat || a.pitch - b.pitch);
 }
 
 // src/generate/groove/index.ts
 var DEFAULT_TS3 = { numerator: 4, denominator: 4 };
+var DEFAULT_GROOVE_SUBDIVISION = 4;
 var DEFAULT_TIMING = 0.02;
 var DEFAULT_VELOCITY_JITTER = 8;
 var DEFAULT_ACCENT = 12;
@@ -1817,12 +2023,19 @@ var MIN_VELOCITY = 1;
 var MAX_VELOCITY = 127;
 function humanize(events, opts = {}) {
   const ts = opts.ts ?? DEFAULT_TS3;
+  assertTimeSignature(ts);
+  assertNoteEvents(events, "humanize events", { allowNonPositiveDuration: true });
+  const sounding = dropSilentNotes(events);
   const timing = opts.timing ?? DEFAULT_TIMING;
   const velocityJitter = opts.velocity ?? DEFAULT_VELOCITY_JITTER;
   const accent = opts.accent ?? DEFAULT_ACCENT;
   const baseVelocity = opts.baseVelocity ?? DEFAULT_BASE_VELOCITY;
+  assertRange(timing, 0, Number.MAX_SAFE_INTEGER, "humanize timing");
+  assertRange(velocityJitter, 0, 127, "humanize velocity jitter");
+  assertRange(accent, 0, 127, "humanize accent");
+  assertRange(baseVelocity, 0, 127, "humanize base velocity");
   const rng = createRng(opts.seed ?? 0);
-  return events.map((event) => {
+  return sounding.map((event) => {
     const timingOffset = rng.float(-timing, timing);
     const startBeat = Math.max(0, event.startBeat + timingOffset);
     const weight = metricWeight(event.startBeat, ts);
@@ -1852,14 +2065,18 @@ function quantizeToGrid(beat, barBeats, subdivision, slotsPerBar) {
     slotIndex
   };
 }
-function extractGrooveTemplate(events, ts, subdivision) {
+function extractGrooveTemplate(events, ts, subdivision = DEFAULT_GROOVE_SUBDIVISION) {
+  assertTimeSignature(ts);
+  assertNoteEvents(events, "groove source events", { allowNonPositiveDuration: true });
+  assertPositiveInt(subdivision, "groove subdivision");
   const barBeats = beatsPerBar(ts);
   const slotsPerBar = Math.round(barBeats * subdivision);
+  assertGenerationBudget(slotsPerBar, "groove template slots");
   const offsetSums = new Array(slotsPerBar).fill(0);
   const velocitySums = new Array(slotsPerBar).fill(0);
   const counts = new Array(slotsPerBar).fill(0);
   const velocityCounts = new Array(slotsPerBar).fill(0);
-  for (const event of events) {
+  for (const event of dropSilentNotes(events)) {
     const { quantizedBeat, slotIndex } = quantizeToGrid(
       event.startBeat,
       barBeats,
@@ -1889,13 +2106,21 @@ function extractGrooveTemplate(events, ts, subdivision) {
   return { subdivision, slotsPerBar, slots, ts };
 }
 function applyGrooveTemplate(events, template, ts) {
+  assertTimeSignature(ts);
+  assertNoteEvents(events, "groove target events", { allowNonPositiveDuration: true });
+  assertPositiveInt(template.subdivision, "template subdivision");
+  assertPositiveInt(template.slotsPerBar, "template slotsPerBar");
+  assertGenerationBudget(template.slots.length, "template slots");
+  if (template.slots.length !== template.slotsPerBar) {
+    throw new InvalidInputError("template slots length must equal slotsPerBar");
+  }
   if (template.ts && (template.ts.numerator !== ts.numerator || template.ts.denominator !== ts.denominator)) {
-    throw new Error(
+    throw new InvalidInputError(
       `Groove template meter ${formatTimeSignature(template.ts)} does not match apply-time meter ${formatTimeSignature(ts)}`
     );
   }
   const barBeats = beatsPerBar(ts);
-  return events.map((event) => {
+  return dropSilentNotes(events).map((event) => {
     const { quantizedBeat, slotIndex } = quantizeToGrid(
       event.startBeat,
       barBeats,
@@ -1915,25 +2140,20 @@ function applyGrooveTemplate(events, template, ts) {
 }
 
 // src/generate/harmonize/index.ts
-var FALLBACK = { rootPc: 0, quality: "maj", secondaryDominant: false, base: 0 };
+var FALLBACK = {
+  rootPc: 0,
+  quality: "maj",
+  secondaryDominant: false,
+  base: 0,
+  pcs: chordPitchClasses(makeChord(0, "maj"))
+};
+var DEFAULT_HARMONIC_RHYTHM = 2;
+var DEFAULT_PLACEMENT = { transposeSearch: false, octaveSearch: false };
 var DEFAULT_METER = { numerator: 4, denominator: 4 };
 var COMFORT_LOW = 55;
 var COMFORT_HIGH = 79;
 var TESSITURA_WEIGHT = 1e-3;
-var TIE_BREAK_JITTER = 1e-6;
-function pitchClass2(pitch) {
-  return (Math.trunc(pitch) % 12 + 12) % 12;
-}
-function mulberry32(seed) {
-  let state = seed >>> 0;
-  return () => {
-    state = state + 1831565813 >>> 0;
-    let t = state;
-    t = Math.imul(t ^ t >>> 15, t | 1);
-    t ^= t + Math.imul(t ^ t >>> 7, t | 61);
-    return ((t ^ t >>> 14) >>> 0) / 4294967296;
-  };
-}
+var TIE_BREAK_JITTER2 = 1e-6;
 function inferKey(melody) {
   let best = majorKey(0);
   let bestScore = Number.NEGATIVE_INFINITY;
@@ -1942,13 +2162,13 @@ function inferKey(melody) {
     candidates.push(majorKey(tonic), minorKey(tonic));
   }
   for (const key of candidates) {
-    const tonic = pitchClass2(key.rootPc);
+    const tonic = pitchClassOf(key.rootPc);
     const isMinor = key.modeMask12 === NATURAL_MINOR_MASK;
     const leadingTone = (tonic + 11) % 12;
     let score = 0;
     for (const n of melody) {
       const w = Math.max(0.25, n.durationBeat);
-      const pc = pitchClass2(n.pitch);
+      const pc = pitchClassOf(n.pitch);
       if (isScaleTone(n.pitch, key) || isMinor && pc === leadingTone) {
         score += w;
       }
@@ -1965,50 +2185,59 @@ function inferKey(melody) {
 }
 function buildCandidates(key, reharmonize) {
   const tones = scaleTonesInDegreeOrder(key);
-  const candidates = tones.map((rootPc, degree) => ({
-    rootPc,
-    quality: diatonicTriad(degree, key).quality,
-    degree,
-    secondaryDominant: false,
-    base: 0
-  }));
-  const tonic = tones[0] ?? 0;
+  const candidates = tones.map((rootPc, degree) => {
+    const quality = diatonicTriad(degree, key).quality;
+    return {
+      rootPc,
+      quality,
+      degree,
+      secondaryDominant: false,
+      base: 0,
+      pcs: chordPitchClasses(makeChord(rootPc, quality))
+    };
+  });
   if (reharmonize !== "diatonic") {
     for (const target of [1, 3, 4, 5]) {
       const targetRoot = tones[target] ?? 0;
+      const rootPc = (targetRoot + 7) % 12;
       candidates.push({
-        rootPc: (targetRoot + 7) % 12,
+        rootPc,
         quality: "dom7",
         secondaryDominant: true,
         targetDegree: target,
-        base: 1.5
+        base: 1.5,
+        pcs: chordPitchClasses(makeChord(rootPc, "dom7"))
       });
     }
   }
   if (reharmonize === "borrowed") {
-    candidates.push({
-      rootPc: (tonic + 10) % 12,
-      quality: "maj",
-      secondaryDominant: false,
-      base: 2
-    });
-    candidates.push({
-      rootPc: (tonic + 8) % 12,
-      quality: "maj",
-      secondaryDominant: false,
-      base: 2
-    });
-    candidates.push({
-      rootPc: (tonic + 5) % 12,
-      quality: "min",
-      secondaryDominant: false,
-      base: 2
-    });
+    const parallel = parallelKey(key);
+    const parallelTones = scaleTonesInDegreeOrder(parallel);
+    for (let degree = 0; degree < parallelTones.length; degree += 1) {
+      const chord = diatonicTriad(degree, parallel);
+      if (!isDiatonic(chord, key)) {
+        candidates.push({
+          rootPc: chord.rootPc,
+          quality: chord.quality,
+          secondaryDominant: false,
+          base: 1.25,
+          pcs: chordPitchClasses(chord)
+        });
+      }
+    }
   }
-  return candidates;
+  const seen = /* @__PURE__ */ new Set();
+  return candidates.filter((candidate) => {
+    const id = `${candidate.rootPc}:${candidate.quality}`;
+    if (seen.has(id)) {
+      return false;
+    }
+    seen.add(id);
+    return true;
+  });
 }
-function emissionCost(seg, cand, melody, key) {
-  const pcs = chordPitchClasses(makeChord(cand.rootPc, cand.quality));
+function emissionCost(seg, cand, melody, key, ts) {
+  const pcs = cand.pcs;
   let cost = cand.base;
   for (const idx of seg.noteIndices) {
     const note = melody[idx];
@@ -2021,10 +2250,10 @@ function emissionCost(seg, cand, melody, key) {
       continue;
     }
     const w = Math.max(0.25, overlap);
-    if (pcs.includes(pitchClass2(note.pitch))) {
+    if (pcs.includes(pitchClassOf(note.pitch))) {
       continue;
     }
-    const strong = isStrongBeat(overlapStart, DEFAULT_METER);
+    const strong = isStrongBeat(overlapStart, ts);
     cost += (strong ? 10 : 2) * w;
     if (!isScaleTone(note.pitch, key)) {
       cost += w;
@@ -2058,13 +2287,13 @@ function transitionCost(prev, cur, tonicPc) {
   cost += dist * 0.3;
   return cost;
 }
-function harmonizeOnce(melody, key, candidates, segments, jitter) {
-  const tonicPc = pitchClass2(key.rootPc);
+function harmonizeOnce(melody, key, candidates, segments, jitter, ts) {
+  const tonicPc = pitchClassOf(key.rootPc);
   const n = candidates.length;
   const candAt = (i) => candidates[i] ?? FALLBACK;
   const seg0 = segments[0];
   let dp = candidates.map(
-    (c, ci) => (seg0 ? emissionCost(seg0, c, melody, key) : 0) + (jitter[ci] ?? 0)
+    (c, ci) => (seg0 ? emissionCost(seg0, c, melody, key, ts) : 0) + (jitter[ci] ?? 0)
   );
   const back = [];
   for (let s = 1; s < segments.length; s += 1) {
@@ -2084,7 +2313,7 @@ function harmonizeOnce(melody, key, candidates, segments, jitter) {
           bestPrev = p;
         }
       }
-      next[c] = best + emissionCost(seg, candAt(c), melody, key) + (jitter[c] ?? 0);
+      next[c] = best + emissionCost(seg, candAt(c), melody, key, ts) + (jitter[c] ?? 0);
       ptr[c] = bestPrev;
     }
     dp = next;
@@ -2109,30 +2338,56 @@ function harmonizeOnce(melody, key, candidates, segments, jitter) {
   return { cost: bestCost, path };
 }
 function harmonizeMelody(opts) {
-  const key = opts.key === "infer" ? inferKey(opts.melody) : opts.key;
-  const candidates = buildCandidates(key, opts.reharmonize);
+  const noteIndex = createNoteEventIndex(opts.melody, { allowNonPositiveDuration: true });
+  const ts = opts.ts ?? DEFAULT_METER;
+  assertTimeSignature(ts);
+  const requestedKey = opts.key ?? "infer";
+  const key = requestedKey === "infer" ? inferKey(opts.melody) : requestedKey;
+  const placement = opts.placement ?? DEFAULT_PLACEMENT;
+  if (noteIndex.notes.every((indexed) => indexed.note.durationBeat <= 0)) {
+    return { transposeSemitones: 0, key, chords: [], melodyRoles: [] };
+  }
+  const candidates = buildCandidates(key, opts.reharmonize ?? "diatonic");
   const candAt = (i) => candidates[i] ?? FALLBACK;
-  const rng = mulberry32(opts.seed ?? 0);
-  const jitter = candidates.map(() => rng() * TIE_BREAK_JITTER);
-  const melodyEnd = opts.melody.reduce((m, n) => Math.max(m, n.startBeat + n.durationBeat), 0);
-  const hr = Math.max(0.25, opts.harmonicRhythm);
+  const rng = createRng(opts.seed ?? 0);
+  const jitter = candidates.map(() => rng.next() * TIE_BREAK_JITTER2);
+  const melodyEnd = noteIndex.notes.reduce((m, n) => Math.max(m, n.endBeat), 0);
+  const hr = assertRange(
+    opts.harmonicRhythm ?? DEFAULT_HARMONIC_RHYTHM,
+    Number.MIN_VALUE,
+    Number.MAX_SAFE_INTEGER,
+    "harmonic rhythm"
+  );
   const segCount = Math.max(1, Math.ceil(melodyEnd / hr));
-  const segments = [];
-  for (let s = 0; s < segCount; s += 1) {
-    const startBeat = s * hr;
-    const endBeat = startBeat + hr;
-    const noteIndices = opts.melody.map((n, i) => ({ n, i })).filter(({ n }) => n.startBeat < endBeat && n.startBeat + n.durationBeat > startBeat).map(({ i }) => i);
-    segments.push({ startBeat, endBeat, noteIndices });
+  assertGenerationBudget(segCount, "harmonic segments");
+  assertGenerationBudget(segCount * candidates.length * candidates.length, "harmonization search");
+  const segments = Array.from({ length: segCount }, (_, s) => ({
+    startBeat: s * hr,
+    endBeat: (s + 1) * hr,
+    noteIndices: []
+  }));
+  let memberships = 0;
+  for (const indexed of noteIndex.notes) {
+    if (indexed.note.durationBeat <= 0) {
+      continue;
+    }
+    const first = Math.max(0, Math.floor(indexed.note.startBeat / hr));
+    const lastExclusive = Math.min(segCount, Math.ceil(indexed.endBeat / hr - Number.EPSILON));
+    memberships += Math.max(0, lastExclusive - first);
+    assertGenerationBudget(memberships, "note-to-segment memberships");
+    for (let segment = first; segment < lastExclusive; segment += 1) {
+      segments[segment]?.noteIndices.push(indexed.originalIndex);
+    }
   }
   const transposes = [0];
-  if (opts.placement.transposeSearch) {
+  if (placement.transposeSearch) {
     for (let s = -6; s <= 6; s += 1) {
       if (s !== 0) {
         transposes.push(s);
       }
     }
   }
-  if (opts.placement.octaveSearch) {
+  if (placement.octaveSearch) {
     for (const o of [-12, 12]) {
       if (!transposes.includes(o)) {
         transposes.push(o);
@@ -2143,13 +2398,13 @@ function harmonizeMelody(opts) {
   let bestTs = 0;
   let bestPath = [];
   let bestMelody = opts.melody;
-  for (const ts of transposes) {
-    const shifted = opts.melody.map((n) => ({ ...n, pitch: n.pitch + ts }));
-    const { cost, path } = harmonizeOnce(shifted, key, candidates, segments, jitter);
+  for (const shift of transposes) {
+    const shifted = opts.melody.map((n) => ({ ...n, pitch: n.pitch + shift }));
+    const { cost, path } = harmonizeOnce(shifted, key, candidates, segments, jitter, ts);
     const total = cost + tessituraCost(shifted);
     if (total < bestCost) {
       bestCost = total;
-      bestTs = ts;
+      bestTs = shift;
       bestPath = path;
       bestMelody = shifted;
     }
@@ -2169,20 +2424,23 @@ function harmonizeMelody(opts) {
     }
     return chord;
   });
-  const melodyRoles = bestMelody.map((note, noteIndex) => {
+  const melodyRoles = bestMelody.map((note, noteIndex2) => {
     const segIdx = Math.min(segments.length - 1, Math.max(0, Math.floor(note.startBeat / hr)));
     const cand = candAt(bestPath[segIdx] ?? 0);
     const chord = makeChord(cand.rootPc, cand.quality);
-    return { noteIndex, role: roleOf(note.pitch, chord).role };
+    return { noteIndex: noteIndex2, role: roleOf(note.pitch, chord).role };
   });
   return { transposeSemitones: bestTs, key, chords, melodyRoles };
 }
 
 // src/generate/motif/index.ts
-function pitchClass3(pitch) {
-  return (Math.trunc(pitch) % 12 + 12) % 12;
-}
 var MIN_TILE_SPAN = 1 / 256;
+var DEFAULT_TS4 = { numerator: 4, denominator: 4 };
+var EPS3 = 1e-9;
+function isDownbeat(startBeat, barBeats) {
+  const bar = startBeat / barBeats;
+  return Math.abs(bar - Math.round(bar)) < EPS3;
+}
 function upScaleTone(pitch, key) {
   for (let d = 1; d <= 12; d += 1) {
     if (isScaleTone(pitch + d, key)) {
@@ -2210,39 +2468,40 @@ function stepDiatonic(pitch, degrees, key) {
 function nearestChordTone(pitch, chord) {
   const pcs = chordPitchClasses(chord);
   for (let d = 0; d <= 12; d += 1) {
-    if (pcs.includes(pitchClass3(pitch - d))) {
+    if (pcs.includes(pitchClassOf(pitch - d))) {
       return pitch - d;
     }
-    if (pcs.includes(pitchClass3(pitch + d))) {
+    if (pcs.includes(pitchClassOf(pitch + d))) {
       return pitch + d;
     }
   }
   return pitch;
 }
 function cellOrigin(notes) {
-  return notes.length === 0 ? 0 : Math.min(...notes.map((n) => n.startBeat));
+  let origin = Number.POSITIVE_INFINITY;
+  for (const note of notes) {
+    origin = Math.min(origin, note.startBeat);
+  }
+  return Number.isFinite(origin) ? origin : 0;
+}
+function cellEnd(notes) {
+  let end = Number.NEGATIVE_INFINITY;
+  for (const note of notes) {
+    end = Math.max(end, note.startBeat + note.durationBeat);
+  }
+  return Number.isFinite(end) ? end : 0;
 }
 function cellSpan(cell) {
   if (cell.notes.length === 0) {
     return 0;
   }
   const start = cellOrigin(cell.notes);
-  const end = Math.max(...cell.notes.map((n) => n.startBeat + n.durationBeat));
+  const end = cellEnd(cell.notes);
   return end - start;
 }
 function clone(cell) {
   return { notes: cell.notes.map((n) => ({ ...n })) };
 }
-function mulberry322(seed) {
-  let state = seed >>> 0;
-  return () => {
-    state = state + 1831565813 >>> 0;
-    let t = state;
-    t = Math.imul(t ^ t >>> 15, t | 1);
-    t ^= t + Math.imul(t ^ t >>> 7, t | 61);
-    return ((t ^ t >>> 14) >>> 0) / 4294967296;
-  };
-}
 function contourOffsets(contour, count) {
   const offsets = [];
   for (let i = 0; i < count; i += 1) {
@@ -2265,30 +2524,59 @@ function contourOffsets(contour, count) {
 }
 function generateMotif(opts) {
   const contour = opts.contour ?? "arch";
-  const bars = Math.max(1, Math.trunc(opts.bars));
-  const totalBeats = bars * 4;
+  const bars = assertPositiveInt(opts.bars, "motif bars");
+  const barBeats = beatsPerBar(opts.ts ?? DEFAULT_TS4);
+  const totalBeats = bars * barBeats;
   const noteCount = Math.max(3, bars * 2);
+  assertGenerationBudget(noteCount, "motif notes");
   const beatsPerNote = totalBeats / noteCount;
-  const rng = mulberry322(opts.seed ?? 0);
-  const jitterProb = Math.min(1, Math.max(0, opts.jitter ?? 0));
-  const tonic = pitchClass3(opts.key.rootPc) + 60;
+  const rng = createRng(opts.seed ?? 0);
+  const requestedJitter = assertFiniteNumber(opts.jitter ?? 0, "motif jitter");
+  const jitterProb = Math.min(1, Math.max(0, requestedJitter));
+  const tonic = pitchClassOf(opts.key.rootPc) + 60;
   const offsets = contourOffsets(contour, noteCount);
   const notes = [];
   for (let i = 0; i < noteCount; i += 1) {
     let jitter = 0;
-    if (jitterProb > 0 && rng() < jitterProb) {
-      jitter = rng() < 0.5 ? 1 : -1;
+    if (jitterProb > 0 && rng.next() < jitterProb) {
+      jitter = rng.next() < 0.5 ? 1 : -1;
     }
     let pitch = stepDiatonic(tonic, (offsets[i] ?? 0) + jitter, opts.key);
     const startBeat = i * beatsPerNote;
-    if (opts.chord && startBeat % 4 === 0) {
+    if (opts.chord && isDownbeat(startBeat, barBeats)) {
       pitch = nearestChordTone(pitch, opts.chord);
     }
     notes.push({ pitch, startBeat, durationBeat: beatsPerNote });
   }
   return { notes };
 }
+function motifToNoteEvents(cell) {
+  return cell.notes.map((note) => ({ ...note }));
+}
 function transformMotif(cell, t, amount, key) {
+  return assertInRange(transformUnchecked(cell, t, amount, key));
+}
+function assertInRange(cell) {
+  for (const note of cell.notes) {
+    if (note.pitch < 0 || note.pitch > 127) {
+      throw new InvalidInputError(
+        `transformed motif pitch ${note.pitch} is outside the MIDI range 0..127`
+      );
+    }
+  }
+  return cell;
+}
+function transformUnchecked(cell, t, amount, key) {
+  assertNoteEvents(cell.notes, "motif notes");
+  if (amount !== void 0) {
+    assertFiniteNumber(amount, "motif transform amount");
+  }
+  if ((t === "transposeDiatonic" || t === "sequence") && amount !== void 0) {
+    assertInteger(amount, "diatonic transform amount");
+  }
+  if ((t === "augment" || t === "diminish") && amount !== void 0 && amount <= 0) {
+    throw new InvalidInputError("time transform amount must be positive");
+  }
   const notes = cell.notes;
   switch (t) {
     case "transposeChromatic": {
@@ -2315,7 +2603,7 @@ function transformMotif(cell, t, amount, key) {
         return { notes: [] };
       }
       const start = cellOrigin(notes);
-      const end = Math.max(...notes.map((n) => n.startBeat + n.durationBeat));
+      const end = cellEnd(notes);
       return {
         notes: notes.map((n) => ({
           pitch: n.pitch,
@@ -2347,9 +2635,11 @@ function scaleTime(cell, factor) {
     }))
   };
 }
-function developMotif(cell, timeline, key, bars) {
+function developMotif(cell, timeline, key, bars, ts = DEFAULT_TS4) {
+  assertPositiveInt(bars, "development bars");
+  assertNoteEvents(cell.notes, "motif notes");
   const span = cellSpan(cell);
-  const totalBeats = Math.max(1, Math.trunc(bars)) * 4;
+  const totalBeats = bars * beatsPerBar(ts);
   const origin = cellOrigin(cell.notes);
   const out = [];
   if (span <= 0) {
@@ -2357,6 +2647,7 @@ function developMotif(cell, timeline, key, bars) {
   }
   const tileSpan = Math.max(span, MIN_TILE_SPAN);
   const tileCount = Math.ceil(totalBeats / tileSpan);
+  assertGenerationBudget(tileCount * cell.notes.length, "developed motif notes");
   for (let k = 0; k < tileCount; k += 1) {
     const offset = k * tileSpan;
     for (const n of cell.notes) {
@@ -2367,7 +2658,7 @@ function developMotif(cell, timeline, key, bars) {
       const chord = timeline.at(startBeat);
       let pitch = n.pitch;
       if (chord) {
-        const isMember = chordPitchClasses(chord).includes(pitchClass3(pitch));
+        const isMember = chordPitchClasses(chord).includes(pitchClassOf(pitch));
         pitch = isMember ? pitch : nearestChordTone(pitch, chord);
       } else {
         pitch = nearestScaleTone(pitch, key);
@@ -2379,6 +2670,20 @@ function developMotif(cell, timeline, key, bars) {
 }
 
 // src/generate/progression/index.ts
+var BORROWED_DEGREES = {
+  /** Flat submediant: bVI. */
+  bVI: 8,
+  /** Flat subtonic: bVII. */
+  bVII: 10,
+  /** Flat mediant: bIII. */
+  bIII: 11,
+  /** Minor subdominant borrowed from the parallel minor: iv. */
+  iv: 12,
+  /** Neapolitan: bII. */
+  bII: 13,
+  /** Sharp subdominant, the diminished #IV. */
+  sharpIV: 14
+};
 var PRESETS = [
   {
     id: "fourChordPop",
@@ -2536,18 +2841,12 @@ var PRESETS = [
   }
 ];
 var BORROWED_OFFSET = {
-  8: 8,
-  // bVI
-  10: 10,
-  // bVII
-  11: 3,
-  // bIII
-  12: 5,
-  // iv
-  13: 1,
-  // bII
-  14: 6
-  // #IV
+  [BORROWED_DEGREES.bVI]: 8,
+  [BORROWED_DEGREES.bVII]: 10,
+  [BORROWED_DEGREES.bIII]: 3,
+  [BORROWED_DEGREES.iv]: 5,
+  [BORROWED_DEGREES.bII]: 1,
+  [BORROWED_DEGREES.sharpIV]: 6
 };
 function progressions() {
   return PRESETS.map((p) => ({ ...p, degrees: [...p.degrees], styles: [...p.styles] }));
@@ -2555,16 +2854,6 @@ function progressions() {
 function progressionsByStyle(style) {
   return progressions().filter((p) => p.styles.includes(style));
 }
-function mulberry323(seed) {
-  let state = seed >>> 0;
-  return () => {
-    state = state + 1831565813 >>> 0;
-    let t = state;
-    t = Math.imul(t ^ t >>> 15, t | 1);
-    t ^= t + Math.imul(t ^ t >>> 7, t | 61);
-    return ((t ^ t >>> 14) >>> 0) / 4294967296;
-  };
-}
 function degreeToRootPc(degree, key) {
   if (degree >= 0 && degree <= 6) {
     const tones = scaleTonesInDegreeOrder(key);
@@ -2585,38 +2874,83 @@ function autoQuality(degree, key) {
   }
   return "maj";
 }
+function resolveCycle(degrees, key, ext) {
+  const steps = [];
+  for (const degree of degrees) {
+    const step = {
+      source: degree,
+      rootPc: degreeToRootPc(degree, key),
+      quality: ext !== void 0 && ext !== "auto" ? ext : autoQuality(degree, key)
+    };
+    if (degree >= 0 && degree <= 6) {
+      step.degree = degree;
+    }
+    const previous = steps[steps.length - 1];
+    if (previous !== void 0 && previous.source !== step.source && sameStep(previous, step)) {
+      continue;
+    }
+    steps.push(step);
+  }
+  const first = steps[0];
+  const last = steps[steps.length - 1];
+  if (steps.length > 1 && first !== void 0 && last !== void 0 && first.source !== last.source && sameStep(first, last)) {
+    steps.pop();
+  }
+  return steps.length > 0 ? steps : [{ source: 0, degree: 0, rootPc: degreeToRootPc(0, key), quality: "maj" }];
+}
+function sameStep(a, b) {
+  return a.rootPc === b.rootPc && a.quality === b.quality;
+}
+function pickProgressionPreset(style, seed = 0) {
+  const pool = PRESETS.filter((preset) => preset.styles.includes(style));
+  if (pool.length === 0) {
+    throw new InvalidInputError(`Unknown progression style: ${style}`);
+  }
+  const rng = createRng(seed);
+  const index = Math.floor(rng.next() * pool.length) % pool.length;
+  return pool[index] ?? PRESETS[0];
+}
 function generateProgression(opts) {
+  assertPositiveInt(opts.bars, "progression bars");
+  assertGenerationBudget(opts.bars, "progression chords");
   const seed = opts.seed ?? 0;
   let preset;
-  if (opts.presetId !== void 0) {
+  if (opts.preset !== void 0) {
+    if (opts.preset.degrees.length === 0) {
+      throw new InvalidInputError("progression preset must name at least one degree");
+    }
+    preset = {
+      id: opts.preset.id ?? "custom",
+      name: opts.preset.name ?? "Custom",
+      degrees: opts.preset.degrees,
+      functional: opts.preset.functional ?? "loop",
+      styles: opts.preset.styles ?? [opts.style]
+    };
+  }
+  if (preset === void 0 && opts.presetId !== void 0) {
     preset = PRESETS.find((p) => p.id === opts.presetId);
     if (preset === void 0) {
-      throw new Error(`Unknown progression preset: ${opts.presetId}`);
+      throw new InvalidInputError(`Unknown progression preset: ${opts.presetId}`);
     }
   }
-  if (preset === void 0) {
-    const pool = PRESETS.filter((p) => p.styles.includes(opts.style));
-    const candidates = pool.length > 0 ? pool : PRESETS;
-    const rng = mulberry323(seed);
-    const index = Math.floor(rng() * candidates.length) % candidates.length;
-    preset = candidates[index] ?? PRESETS[0];
-  }
-  const degrees = preset?.degrees ?? [0];
+  preset ??= pickProgressionPreset(opts.style, seed);
+  const cycle = resolveCycle(preset?.degrees ?? [0], opts.key, opts.ext);
   const chords = [];
   for (let bar = 0; bar < opts.bars; bar += 1) {
-    const degree = degrees[bar % degrees.length] ?? 0;
-    const quality = opts.ext !== void 0 && opts.ext !== "auto" ? opts.ext : autoQuality(degree, opts.key);
+    const step = cycle[bar % cycle.length];
     const chord = {
-      rootPc: degreeToRootPc(degree, opts.key),
-      quality,
-      startBeat: bar * 4,
-      degree: degree >= 0 && degree <= 6 ? degree : void 0
+      rootPc: step?.rootPc ?? 0,
+      quality: step?.quality ?? "maj",
+      startBeat: bar * 4
     };
+    if (step?.degree !== void 0) {
+      chord.degree = step.degree;
+    }
     chords.push(chord);
   }
   if (opts.reharmonize) {
     const tonicPc = (opts.key.rootPc % 12 + 12) % 12;
-    const rrng = mulberry323((seed ^ 2654435769) >>> 0);
+    const rrng = createRng((seed ^ 2654435769) >>> 0);
     for (let i = 0; i < chords.length - 1; i += 1) {
       const cur = chords[i];
       const next = chords[i + 1];
@@ -2630,7 +2964,7 @@ function generateProgression(opts) {
       if (targetsTonic || alreadySecondary || isResolutionTarget) {
         continue;
       }
-      if (rrng() < 0.5) {
+      if (rrng.next() < 0.5) {
         chords[i] = {
           rootPc: domRoot,
           quality: "dom7",
@@ -2644,6 +2978,17 @@ function generateProgression(opts) {
 }
 
 // src/generate/rhythm/index.ts
+var DEFAULT_RHYTHM_VELOCITY = 96;
+function rhythmToNoteEvents(events, pitch, velocity = DEFAULT_RHYTHM_VELOCITY) {
+  assertFiniteNumber(pitch, "pitch");
+  assertRange(velocity, 0, 127, "velocity");
+  return events.map((event) => ({
+    pitch,
+    startBeat: event.position,
+    durationBeat: event.duration,
+    velocity
+  }));
+}
 var DEFAULT_SUBDIVISION = 2;
 var DEFAULT_DENSITY = 0.5;
 var DEFAULT_BARS = 1;
@@ -2663,11 +3008,14 @@ function generateRhythm(ts, opts = {}) {
   const seed = opts.seed ?? 0;
   const bars = opts.bars ?? DEFAULT_BARS;
   const subdivision = opts.subdivision ?? DEFAULT_SUBDIVISION;
-  const density = Math.min(1, Math.max(0, opts.density ?? DEFAULT_DENSITY));
+  const density = assertRange(opts.density ?? DEFAULT_DENSITY, 0, 1, "rhythm density");
+  assertPositiveInt(bars, "rhythm bars");
+  assertPositiveInt(subdivision, "rhythm subdivision");
   const barBeats = beatsPerBar(ts);
   const spanBeats = barBeats * bars;
   const step = 1 / subdivision;
   const slotCount = Math.round(spanBeats * subdivision);
+  assertGenerationBudget(slotCount, "rhythm grid slots");
   const slotsPerBar = Math.round(barBeats * subdivision);
   const rng = createRng(seed);
   const positions = [];
@@ -2702,21 +3050,28 @@ function rhythmDensity(events, ts) {
 }
 
 export {
+  BASS_STYLES,
   generateBassLine,
   generateCounterMelody,
+  DRUM_NOTES,
+  drumVoiceOf,
   generateDrums,
   humanize,
   extractGrooveTemplate,
   applyGrooveTemplate,
   harmonizeMelody,
   generateMotif,
+  motifToNoteEvents,
   transformMotif,
   developMotif,
+  BORROWED_DEGREES,
   progressions,
   progressionsByStyle,
+  pickProgressionPreset,
   generateProgression,
+  rhythmToNoteEvents,
   onsetWeightCurve,
   generateRhythm,
   rhythmDensity
 };
-//# sourceMappingURL=chunk-R3S2LUBH.js.map
+//# sourceMappingURL=chunk-7NKDPF74.js.map