@ledgerhq/live-common 27.0.0 → 27.0.1-next.0

package/src/families/polkadot/speculos-deviceActions.ts

@@ -2,88 +2,89 @@ import type { DeviceAction } from "../../bot/types";
 import type { PolkadotAccount, Transaction } from "./types";
 import { deviceActionFlow } from "../../bot/specs";
 import { formatCurrencyUnit } from "../../currencies";
-const acceptTransaction: DeviceAction<Transaction, any> = deviceActionFlow({
-  steps: [
-    {
-      title: "Staking",
-      button: "Rr",
-    },
-    {
-      title: "Balances",
-      button: "Rr",
-    },
-    {
-      title: "Dest",
-      button: "Rr",
-      expectedValue: ({ transaction }) => transaction.recipient,
-    },
-    {
-      title: "Amount",
-      button: "Rr",
-      expectedValue: ({ account, transaction }) => {
-        const formattedValue =
-          "DOT " +
-          formatCurrencyUnit(account.unit, transaction.amount, {
-            disableRounding: true,
-          });
 
-        if (!formattedValue.includes(".")) {
-          // if the value is pure integer, in the app it will automatically add an .0
-          return formattedValue + ".0";
-        }
+export const acceptTransaction: DeviceAction<Transaction, any> =
+  deviceActionFlow({
+    steps: [
+      {
+        title: "Staking",
+        button: "Rr",
+      },
+      {
+        title: "Balances",
+        button: "Rr",
+      },
+      {
+        title: "Dest",
+        button: "Rr",
+        expectedValue: ({ transaction }) => transaction.recipient,
+      },
+      {
+        title: "Amount",
+        button: "Rr",
+        expectedValue: ({ account, transaction }) => {
+          const formattedValue =
+            "DOT " +
+            formatCurrencyUnit(account.unit, transaction.amount, {
+              disableRounding: true,
+            });
+
+          if (!formattedValue.includes(".")) {
+            // if the value is pure integer, in the app it will automatically add an .0
+            return formattedValue + ".0";
+          }
 
-        return formattedValue;
+          return formattedValue;
+        },
+      },
+      {
+        title: "Chain",
+        button: "Rr",
+        expectedValue: () => "Polkadot",
+      },
+      {
+        title: "Nonce",
+        button: "Rr",
+        expectedValue: ({ account }) =>
+          (
+            (account as PolkadotAccount).polkadotResources?.nonce || 0
+          ).toString(),
+      },
+      {
+        title: "Tip",
+        button: "Rr",
+      },
+      {
+        title: "Controller",
+        button: "Rr",
+      },
+      {
+        title: "Payee",
+        button: "Rr",
+      },
+      {
+        title: "Max additional",
+        button: "Rr",
+      },
+      {
+        title: "Targets",
+        button: "Rr",
+      },
+      {
+        title: "Era Phase",
+        button: "Rr",
+      },
+      {
+        title: "Era Period",
+        button: "Rr",
+      },
+      {
+        title: "Block",
+        button: "Rr",
+      },
+      {
+        title: "APPROVE",
+        button: "LRlr",
       },
-    },
-    {
-      title: "Chain",
-      button: "Rr",
-      expectedValue: () => "Polkadot",
-    },
-    {
-      title: "Nonce",
-      button: "Rr",
-      expectedValue: ({ account }) =>
-        ((account as PolkadotAccount).polkadotResources?.nonce || 0).toString(),
-    },
-    {
-      title: "Tip",
-      button: "Rr",
-    },
-    {
-      title: "Controller",
-      button: "Rr",
-    },
-    {
-      title: "Payee",
-      button: "Rr",
-    },
-    {
-      title: "Max additional",
-      button: "Rr",
-    },
-    {
-      title: "Targets",
-      button: "Rr",
-    },
-    {
-      title: "Era Phase",
-      button: "Rr",
-    },
-    {
-      title: "Era Period",
-      button: "Rr",
-    },
-    {
-      title: "Block",
-      button: "Rr",
-    },
-    {
-      title: "APPROVE",
-      button: "LRlr",
-    },
-  ],
-});
-export default {
-  acceptTransaction,
-};
+    ],
+  });

package/src/families/ripple/platformAdapter.test.ts

@@ -0,0 +1,54 @@
+import xrp from "./platformAdapter";
+import { RippleTransaction as PlatformTransaction } from "@ledgerhq/live-app-sdk";
+import { FAMILIES } from "@ledgerhq/live-app-sdk";
+import BigNumber from "bignumber.js";
+import { Transaction } from "./types";
+
+describe("getPlatformTransactionSignFlowInfos", () => {
+  describe("should properly get infos for XRP platform tx", () => {
+    it("without fees provided", () => {
+      const xrpPlatformTx: PlatformTransaction = {
+        family: FAMILIES.RIPPLE,
+        amount: new BigNumber(100000),
+        recipient: "0xABCDEF",
+        tag: 1,
+      };
+
+      const expectedLiveTx: Partial<Transaction> = {
+        ...xrpPlatformTx,
+      };
+
+      const { canEditFees, hasFeesProvided, liveTx } =
+        xrp.getPlatformTransactionSignFlowInfos(xrpPlatformTx);
+
+      expect(canEditFees).toBe(true);
+
+      expect(hasFeesProvided).toBe(false);
+
+      expect(liveTx).toEqual(expectedLiveTx);
+    });
+
+    it("with fees provided", () => {
+      const xrpPlatformTx: PlatformTransaction = {
+        family: FAMILIES.RIPPLE,
+        amount: new BigNumber(100000),
+        recipient: "0xABCDEF",
+        fee: new BigNumber(300),
+        tag: 1,
+      };
+
+      const expectedLiveTx: Partial<Transaction> = {
+        ...xrpPlatformTx,
+      };
+
+      const { canEditFees, hasFeesProvided, liveTx } =
+        xrp.getPlatformTransactionSignFlowInfos(xrpPlatformTx);
+
+      expect(canEditFees).toBe(true);
+
+      expect(hasFeesProvided).toBe(true);
+
+      expect(liveTx).toEqual(expectedLiveTx);
+    });
+  });
+});

package/src/families/ripple/specs.ts

@@ -2,12 +2,15 @@ import expect from "expect";
 import invariant from "invariant";
 import type { Transaction } from "./types";
 import { getCryptoCurrencyById, parseCurrencyUnit } from "../../currencies";
-import { pickSiblings } from "../../bot/specs";
+import { botTest, pickSiblings } from "../../bot/specs";
 import type { AppSpec } from "../../bot/types";
 import { DeviceModelId } from "@ledgerhq/devices";
+import { acceptTransaction } from "./speculos-deviceActions";
+
 const currency = getCryptoCurrencyById("ripple");
 const minAmountCutoff = parseCurrencyUnit(currency.units[0], "0.1");
 const reserve = parseCurrencyUnit(currency.units[0], "20");
+
 const ripple: AppSpec<Transaction> = {
   name: "XRP",
   currency,
@@ -15,6 +18,7 @@ const ripple: AppSpec<Transaction> = {
     model: DeviceModelId.nanoS,
     appName: "XRP",
   },
+  genericDeviceAction: acceptTransaction,
   mutations: [
     {
       name: "move ~50%",
@@ -53,14 +57,17 @@ const ripple: AppSpec<Transaction> = {
       },
       test: ({ account, transaction, accountBeforeTransaction, operation }) => {
         if (transaction.tag) {
-          expect(operation.extra).toMatchObject({
-            tag: transaction.tag,
-          });
+          botTest("operation tag matches (in extra)", () =>
+            expect(operation.extra).toMatchObject({
+              tag: transaction.tag,
+            })
+          );
         }
 
-        // can be generalized!
-        expect(account.balance.toString()).toBe(
-          accountBeforeTransaction.balance.minus(operation.value).toString()
+        botTest("account balance moved with operation.value", () =>
+          expect(account.balance.toString()).toBe(
+            accountBeforeTransaction.balance.minus(operation.value).toString()
+          )
         );
       },
     },

package/src/families/ripple/speculos-deviceActions.ts

@@ -2,76 +2,75 @@ import type { DeviceAction } from "../../bot/types";
 import type { Transaction } from "./types";
 import { formatCurrencyUnit } from "../../currencies";
 import { deviceActionFlow } from "../../bot/specs";
-const acceptTransaction: DeviceAction<Transaction, any> = deviceActionFlow({
-  steps: [
-    {
-      title: "Transaction Type",
-      button: "Rr",
-      expectedValue: () => "Payment",
-    },
-    {
-      title: "Amount",
-      button: "Rr",
-      expectedValue: ({ account, status }) =>
-        formatCurrencyUnit(
-          {
-            ...account.unit,
-            code: account.currency.deviceTicker || account.unit.code,
-            prefixCode: true,
-          },
-          status.amount,
-          {
-            showCode: true,
-            disableRounding: true,
-            joinFragmentsSeparator: " ",
-          }
-        ).replace(/\s/g, " "),
-    },
-    {
-      title: "Fee",
-      button: "Rr",
-      expectedValue: ({ account, status }) =>
-        formatCurrencyUnit(
-          {
-            ...account.unit,
-            code: account.currency.deviceTicker || account.unit.code,
-            prefixCode: true,
-          },
-          status.estimatedFees,
-          {
-            showCode: true,
-            disableRounding: true,
-            joinFragmentsSeparator: " ",
-          }
-        ).replace(/\s/g, " "),
-    },
-    {
-      title: "Destination Tag",
-      button: "Rr",
-      expectedValue: ({ transaction }) => String(transaction.tag),
-    },
-    {
-      title: "Destination",
-      button: "Rr",
-      trimValue: true,
-      expectedValue: ({ transaction }) => transaction.recipient,
-    },
-    {
-      title: "Account",
-      button: "Rr",
-      trimValue: true,
-      expectedValue: ({ account }) => account.freshAddress,
-    },
-    {
-      title: "Accept",
-      button: "LRlr",
-    },
-    {
-      title: "Sign transaction",
-      button: "LRlr",
-    },
-  ],
-});
-export default {
-  acceptTransaction,
-};
+
+export const acceptTransaction: DeviceAction<Transaction, any> =
+  deviceActionFlow({
+    steps: [
+      {
+        title: "Transaction Type",
+        button: "Rr",
+        expectedValue: () => "Payment",
+      },
+      {
+        title: "Amount",
+        button: "Rr",
+        expectedValue: ({ account, status }) =>
+          formatCurrencyUnit(
+            {
+              ...account.unit,
+              code: account.currency.deviceTicker || account.unit.code,
+              prefixCode: true,
+            },
+            status.amount,
+            {
+              showCode: true,
+              disableRounding: true,
+              joinFragmentsSeparator: " ",
+            }
+          ).replace(/\s/g, " "),
+      },
+      {
+        title: "Fee",
+        button: "Rr",
+        expectedValue: ({ account, status }) =>
+          formatCurrencyUnit(
+            {
+              ...account.unit,
+              code: account.currency.deviceTicker || account.unit.code,
+              prefixCode: true,
+            },
+            status.estimatedFees,
+            {
+              showCode: true,
+              disableRounding: true,
+              joinFragmentsSeparator: " ",
+            }
+          ).replace(/\s/g, " "),
+      },
+      {
+        title: "Destination Tag",
+        button: "Rr",
+        expectedValue: ({ transaction }) => String(transaction.tag),
+      },
+      {
+        title: "Destination",
+        button: "Rr",
+        trimValue: true,
+        expectedValue: ({ transaction }) => transaction.recipient,
+      },
+      {
+        title: "Account",
+        button: "Rr",
+        trimValue: true,
+        expectedValue: ({ account }) => account.freshAddress,
+      },
+      {
+        title: "Accept",
+        button: "LRlr",
+      },
+      {
+        title: "Sign transaction",
+        button: "LRlr",
+      },
+    ],
+  });

package/src/families/solana/specs.ts

@@ -2,7 +2,7 @@ import invariant from "invariant";
 import expect from "expect";
 import { getCryptoCurrencyById } from "@ledgerhq/cryptoassets";
 import { DeviceModelId } from "@ledgerhq/devices";
-import { pickSiblings } from "../../bot/specs";
+import { botTest, pickSiblings } from "../../bot/specs";
 import { AppSpec, TransactionTestInput } from "../../bot/types";
 import { SolanaAccount, Transaction } from "./types";
 import {
@@ -25,6 +25,7 @@ const solana: AppSpec<Transaction> = {
     appVersion: "1.2.0",
     appName: "solana",
   },
+  genericDeviceAction: acceptTransferTransaction,
   testTimeout: 2 * 60 * 1000,
   currency: getCryptoCurrencyById("solana"),
   mutations: [
@@ -66,7 +67,9 @@ const solana: AppSpec<Transaction> = {
       },
       test: (input) => {
         const { account } = input;
-        expect(account.spendableBalance.toNumber()).toBe(0);
+        botTest("account balance should be zero", () =>
+          expect(account.spendableBalance.toNumber()).toBe(0)
+        );
         expectCorrectBalanceChange(input);
         expectCorrectMemo(input);
       },
@@ -142,7 +145,9 @@ const solana: AppSpec<Transaction> = {
           throw new Error("expected delegation not found in account resources");
         }
 
-        expect(transaction.amount.toNumber()).toBe(stake.delegation?.stake);
+        botTest("transaction amount is the stake amount", () =>
+          expect(transaction.amount.toNumber()).toBe(stake.delegation?.stake)
+        );
       },
     },
     {
@@ -204,7 +209,9 @@ const solana: AppSpec<Transaction> = {
           throw new Error("expected stake not found in account resources");
         }
 
-        expect(stake.activation.state).toBe("inactive");
+        botTest("activation state", () =>
+          expect(stake.activation.state).toBe("inactive")
+        );
       },
     },
     {
@@ -265,8 +272,9 @@ const solana: AppSpec<Transaction> = {
         if (stake === undefined) {
           throw new Error("expected stake not found in account resources");
         }
-
-        expect(stake.activation.state).toBe("deactivating");
+        botTest("activation state", () =>
+          expect(stake.activation.state).toBe("deactivating")
+        );
       },
     },
     {
@@ -335,7 +343,9 @@ const solana: AppSpec<Transaction> = {
           throw new Error("expected stake not found in account resources");
         }
 
-        expect(stake.activation.state).toBe("active");
+        botTest("activation state", () =>
+          expect(stake.activation.state).toBe("active")
+        );
       },
     },
     {
@@ -403,8 +413,9 @@ const solana: AppSpec<Transaction> = {
         if (stake === undefined) {
           throw new Error("expected stake not found in account resources");
         }
-
-        expect(stake.activation.state).toBe("activating");
+        botTest("activation state", () =>
+          expect(stake.activation.state).toBe("activating")
+        );
       },
     },
     {
@@ -462,7 +473,9 @@ const solana: AppSpec<Transaction> = {
           (s) => s.stakeAccAddr === stakeAccAddrUsedInTx
         );
 
-        expect(delegationExists).toBe(false);
+        botTest("delegation exists", () =>
+          expect(delegationExists).toBe(false)
+        );
       },
     },
   ],
@@ -485,9 +498,13 @@ function expectCorrectMemo(input: TransactionTestInput<Transaction>) {
   const { transaction, operation } = input;
   switch (transaction.model.kind) {
     case "transfer":
-    case "token.transfer":
-      expect(operation.extra.memo).toBe(transaction.model.uiState.memo);
+    case "token.transfer": {
+      const memo = transaction.model.uiState.memo;
+      botTest("memo matches in op extra", () =>
+        expect(operation.extra.memo).toBe(memo)
+      );
       break;
+    }
     case "token.createATA":
     case "stake.createAccount":
     case "stake.delegate":
@@ -502,8 +519,10 @@ function expectCorrectMemo(input: TransactionTestInput<Transaction>) {
 
 function expectCorrectBalanceChange(input: TransactionTestInput<Transaction>) {
   const { account, operation, accountBeforeTransaction } = input;
-  expect(account.balance.toNumber()).toBe(
-    accountBeforeTransaction.balance.minus(operation.value).toNumber()
+  botTest("account balance decreased with operation value", () =>
+    expect(account.balance.toNumber()).toBe(
+      accountBeforeTransaction.balance.minus(operation.value).toNumber()
+    )
   );
 }
 

package/src/families/solana/speculos-deviceActions.ts

@@ -230,8 +230,3 @@ export const acceptStakeWithdrawTransaction: DeviceAction<Transaction, any> =
 function throwUnexpectedTransaction(): never {
   throw new Error("unexpected or unprepared transaction");
 }
-
-export default {
-  acceptTransferTransaction,
-  acceptStakeCreateAccountTransaction,
-};

package/src/families/stellar/api/horizon.ts

@@ -3,7 +3,7 @@ import StellarSdk, {
   // @ts-expect-error stellar-sdk ts definition missing?
   AccountRecord,
   NotFoundError,
-  NetworkError,
+  NetworkError as StellarSdkNetworkError,
 } from "stellar-sdk";
 import { getEnv } from "../../../env";
 import { getCryptoCurrencyById, parseCurrencyUnit } from "../../../currencies";
@@ -14,7 +14,7 @@ import {
   rawOperationsToOperations,
   getReservedBalance,
 } from "../logic";
-import { NetworkDown, LedgerAPI4xx, LedgerAPI5xx } from "@ledgerhq/errors";
+import { LedgerAPI4xx, LedgerAPI5xx, NetworkError } from "@ledgerhq/errors";
 import { requestInterceptor, responseInterceptor } from "../../../network";
 import type { BalanceAsset } from "../types";
 import { NetworkCongestionLevel, Signer } from "../types";
@@ -127,8 +127,12 @@ export const fetchAccount = async (
     assets = account.balances?.filter((balance) => {
       return balance.asset_type !== "native";
     });
-  } catch (e) {
-    balance.balance = "0";
+  } catch (e: any) {
+    if (e instanceof NotFoundError || e?.response?.status === 400) {
+      balance.balance = "0";
+    } else {
+      throw new NetworkError();
+    }
   }
 
   const formattedBalance = parseCurrencyUnit(
@@ -205,11 +209,11 @@ export const fetchOperations = async ({
     }
 
     if (
-      e instanceof NetworkError ||
+      e instanceof StellarSdkNetworkError ||
       errorMsg.match(/ECONNRESET|ECONNREFUSED|ENOTFOUND|EPIPE|ETIMEDOUT/) ||
       errorMsg.match(/undefined is not an object/)
     ) {
-      throw new NetworkDown();
+      throw new NetworkError();
     }
 
     throw e;