@ledgerhq/live-common 27.0.0 → 27.0.1-next.0

package/src/families/ethereum/platformAdapter.test.ts

@@ -0,0 +1,112 @@
+import eth from "./platformAdapter";
+import { EthereumTransaction as PlatformTransaction } from "@ledgerhq/live-app-sdk";
+import { FAMILIES } from "@ledgerhq/live-app-sdk";
+import BigNumber from "bignumber.js";
+import { Transaction } from "./types";
+
+describe("getPlatformTransactionSignFlowInfos", () => {
+  describe("should properly get infos for ETH platform tx", () => {
+    it("without fees provided", () => {
+      const ethPlatformTx: PlatformTransaction = {
+        family: FAMILIES.ETHEREUM,
+        amount: new BigNumber(100000),
+        recipient: "0xABCDEF",
+      };
+
+      const expectedLiveTx: Partial<Transaction> = {
+        family: ethPlatformTx.family,
+        amount: ethPlatformTx.amount,
+        recipient: ethPlatformTx.recipient,
+      };
+
+      const { canEditFees, hasFeesProvided, liveTx } =
+        eth.getPlatformTransactionSignFlowInfos(ethPlatformTx);
+
+      expect(canEditFees).toBe(true);
+
+      expect(hasFeesProvided).toBe(false);
+
+      expect(liveTx).toEqual(expectedLiveTx);
+    });
+
+    it("with fees provided", () => {
+      const ethPlatformTx: PlatformTransaction = {
+        family: FAMILIES.ETHEREUM,
+        amount: new BigNumber(100000),
+        recipient: "0xABCDEF",
+        gasPrice: new BigNumber(15),
+        gasLimit: new BigNumber(21000),
+      };
+
+      const expectedLiveTx: Partial<Transaction> = {
+        family: ethPlatformTx.family,
+        amount: ethPlatformTx.amount,
+        recipient: ethPlatformTx.recipient,
+        gasPrice: ethPlatformTx.gasPrice,
+        userGasLimit: ethPlatformTx.gasLimit,
+        feesStrategy: "custom",
+      };
+
+      const { canEditFees, hasFeesProvided, liveTx } =
+        eth.getPlatformTransactionSignFlowInfos(ethPlatformTx);
+
+      expect(canEditFees).toBe(true);
+
+      expect(hasFeesProvided).toBe(true);
+
+      expect(liveTx).toEqual(expectedLiveTx);
+    });
+
+    test("with only gasPrice provided", () => {
+      const ethPlatformTx: PlatformTransaction = {
+        family: FAMILIES.ETHEREUM,
+        amount: new BigNumber(100000),
+        recipient: "0xABCDEF",
+        gasPrice: new BigNumber(15),
+      };
+
+      const expectedLiveTx: Partial<Transaction> = {
+        family: ethPlatformTx.family,
+        amount: ethPlatformTx.amount,
+        recipient: ethPlatformTx.recipient,
+        gasPrice: ethPlatformTx.gasPrice,
+        feesStrategy: "custom",
+      };
+
+      const { canEditFees, hasFeesProvided, liveTx } =
+        eth.getPlatformTransactionSignFlowInfos(ethPlatformTx);
+
+      expect(canEditFees).toBe(true);
+
+      expect(hasFeesProvided).toBe(true);
+
+      expect(liveTx).toEqual(expectedLiveTx);
+    });
+
+    test("with only gasLimit provided", () => {
+      const ethPlatformTx: PlatformTransaction = {
+        family: FAMILIES.ETHEREUM,
+        amount: new BigNumber(100000),
+        recipient: "0xABCDEF",
+        gasLimit: new BigNumber(21000),
+      };
+
+      const expectedLiveTx: Partial<Transaction> = {
+        family: ethPlatformTx.family,
+        amount: ethPlatformTx.amount,
+        recipient: ethPlatformTx.recipient,
+        userGasLimit: ethPlatformTx.gasLimit,
+        feesStrategy: "custom",
+      };
+
+      const { canEditFees, hasFeesProvided, liveTx } =
+        eth.getPlatformTransactionSignFlowInfos(ethPlatformTx);
+
+      expect(canEditFees).toBe(true);
+
+      expect(hasFeesProvided).toBe(true);
+
+      expect(liveTx).toEqual(expectedLiveTx);
+    });
+  });
+});

package/src/families/ethereum/specs.ts

@@ -13,12 +13,13 @@ import {
   getAccountCapabilities,
 } from "../../compound/logic";
 import { getSupplyMax } from "./modules/compound";
-import { pickSiblings } from "../../bot/specs";
+import { botTest, pickSiblings } from "../../bot/specs";
 import type { AppSpec } from "../../bot/types";
 import { getGasLimit } from "./transaction";
 import { DeviceModelId } from "@ledgerhq/devices";
 import { TokenCurrency } from "@ledgerhq/types-cryptoassets";
 import { CompoundAccountSummary } from "../../compound/types";
+import { acceptTransaction } from "./speculos-deviceActions";
 
 const testTimeout = 5 * 60 * 1000;
 
@@ -49,11 +50,15 @@ const ethereumBasicMutations = ({ maxAccount }) => [
       const estimatedGas = getGasLimit(transaction).times(
         transaction.gasPrice || 0
       );
-      expect(operation.fee.toNumber()).toBeLessThanOrEqual(
-        estimatedGas.toNumber()
+      botTest("operation fee is not exceeding estimated gas", () =>
+        expect(operation.fee.toNumber()).toBeLessThanOrEqual(
+          estimatedGas.toNumber()
+        )
       );
-      expect(account.balance.toString()).toBe(
-        accountBeforeTransaction.balance.minus(operation.value).toString()
+      botTest("account balance moved with operation value", () =>
+        expect(account.balance.toString()).toBe(
+          accountBeforeTransaction.balance.minus(operation.value).toString()
+        )
       );
     },
   },
@@ -121,6 +126,7 @@ const ethereum: AppSpec<Transaction> = {
     model: DeviceModelId.nanoS,
     appName: "Ethereum",
   },
+  genericDeviceAction: acceptTransaction,
   testTimeout,
   transactionCheck: ({ maxSpendable }) => {
     invariant(
@@ -159,7 +165,9 @@ const ethereum: AppSpec<Transaction> = {
       },
       test: (arg) => {
         const { capabilities } = getCompoundResult(arg);
-        expect((capabilities as any).enabledAmountIsUnlimited).toBe(true);
+        botTest("enabledAmountIsUnlimited is true", () =>
+          expect((capabilities as any).enabledAmountIsUnlimited).toBe(true)
+        );
       },
     },
     {
@@ -192,11 +200,13 @@ const ethereum: AppSpec<Transaction> = {
           "could not find compound summary for account %s",
           transaction.subAccountId
         );
-        expect(
-          (summary as CompoundAccountSummary).totalSupplied.gt(
-            previous.summary?.totalSupplied || new BigNumber(0)
-          )
-        ).toBe(true);
+        botTest("totalSupplied matches", () =>
+          expect(
+            (summary as CompoundAccountSummary).totalSupplied.gt(
+              previous.summary?.totalSupplied || new BigNumber(0)
+            )
+          ).toBe(true)
+        );
       },
     },
     {
@@ -248,16 +258,20 @@ const ethereum: AppSpec<Transaction> = {
         );
 
         if (arg.transaction.useAllAmount) {
-          expect((summary as CompoundAccountSummary).totalSupplied.eq(0)).toBe(
-            true
+          botTest("totalSupplies matches (2)", () =>
+            expect(
+              (summary as CompoundAccountSummary).totalSupplied.eq(0)
+            ).toBe(true)
           );
         } else {
-          expect(
-            (summary as CompoundAccountSummary).totalSupplied.lt(
-              (previous.summary as CompoundAccountSummary).totalSupplied ||
-                new BigNumber(0)
-            )
-          ).toBe(true);
+          botTest("totalSupplies matches (3)", () =>
+            expect(
+              (summary as CompoundAccountSummary).totalSupplied.lt(
+                (previous.summary as CompoundAccountSummary).totalSupplied ||
+                  new BigNumber(0)
+              )
+            ).toBe(true)
+          );
         }
       },
     },
@@ -291,7 +305,9 @@ const ethereum: AppSpec<Transaction> = {
       },
       test: (arg) => {
         const { capabilities } = getCompoundResult(arg);
-        expect((capabilities as any).enabledAmount.eq(0)).toBe(true);
+        botTest("enabledAmount is zero", () =>
+          expect((capabilities as any).enabledAmount.eq(0)).toBe(true)
+        );
       },
     },
     {
@@ -341,10 +357,14 @@ const ethereum: AppSpec<Transaction> = {
         invariant(erc20account, "erc20 acc is still here");
 
         if (transaction.useAllAmount) {
-          expect(erc20account.balance.toString()).toBe("0");
+          botTest("erc20 account is empty", () =>
+            expect(erc20account.balance.toString()).toBe("0")
+          );
         } else {
-          expect(erc20account.balance.toString()).toBe(
-            erc20accountBefore.balance.minus(transaction.amount).toString()
+          botTest("account balance moved with tx amount", () =>
+            expect(erc20account.balance.toString()).toBe(
+              erc20accountBefore.balance.minus(transaction.amount).toString()
+            )
           );
         }
       },
@@ -358,6 +378,7 @@ const ethereumClassic: AppSpec<Transaction> = {
     model: DeviceModelId.nanoS,
     appName: "Ethereum Classic",
   },
+  genericDeviceAction: acceptTransaction,
   dependency: "Ethereum",
   testTimeout,
   transactionCheck: ({ maxSpendable }) => {
@@ -382,6 +403,7 @@ const ethereumGoerli: AppSpec<Transaction> = {
     model: DeviceModelId.nanoS,
     appName: "Ethereum",
   },
+  genericDeviceAction: acceptTransaction,
   testTimeout,
   transactionCheck: ({ maxSpendable }) => {
     invariant(
@@ -406,6 +428,7 @@ const bsc: AppSpec<Transaction> = {
     model: DeviceModelId.nanoS,
     appName: "Binance Smart Chain",
   },
+  genericDeviceAction: acceptTransaction,
   dependency: "Ethereum",
   testTimeout,
   transactionCheck: ({ maxSpendable }) => {
@@ -453,6 +476,7 @@ const polygon: AppSpec<Transaction> = {
     model: DeviceModelId.nanoS,
     appName: "Polygon",
   },
+  genericDeviceAction: acceptTransaction,
   dependency: "Ethereum",
   testTimeout,
   transactionCheck: ({ maxSpendable }) => {

package/src/families/ethereum/speculos-deviceActions.ts

@@ -33,104 +33,102 @@ const maxFeesExpectedValue = ({ account, status }) =>
     }
   ).replace(/\s/g, " ");
 
-const acceptTransaction: DeviceAction<Transaction, any> = deviceActionFlow({
-  steps: [
-    {
-      title: "Review",
-      button: "Rr",
-    },
-    {
-      title: "Type",
-      button: "Rr",
-      expectedValue: ({ transaction }) => {
-        if (transaction.mode === "erc20.approve") return "Approve";
-        if (transaction.mode === "compound.supply") return "Lend Assets";
-        if (transaction.mode === "compound.withdraw") return "Redeem Assets";
-        return "";
+export const acceptTransaction: DeviceAction<Transaction, any> =
+  deviceActionFlow({
+    steps: [
+      {
+        title: "Review",
+        button: "Rr",
       },
-    },
-    {
-      title: "Amount",
-      button: "Rr",
-      expectedValue: ({ account, status, transaction }) => {
-        const a = transaction.subAccountId
-          ? subAccount(transaction.subAccountId, account)
-          : null;
+      {
+        title: "Type",
+        button: "Rr",
+        expectedValue: ({ transaction }) => {
+          if (transaction.mode === "erc20.approve") return "Approve";
+          if (transaction.mode === "compound.supply") return "Lend Assets";
+          if (transaction.mode === "compound.withdraw") return "Redeem Assets";
+          return "";
+        },
+      },
+      {
+        title: "Amount",
+        button: "Rr",
+        expectedValue: ({ account, status, transaction }) => {
+          const a = transaction.subAccountId
+            ? subAccount(transaction.subAccountId, account)
+            : null;
 
-        if (
-          transaction.mode === "erc20.approve" &&
-          transaction.useAllAmount &&
-          a
-        ) {
-          return "Unlimited " + a.token.ticker;
-        }
+          if (
+            transaction.mode === "erc20.approve" &&
+            transaction.useAllAmount &&
+            a
+          ) {
+            return "Unlimited " + a.token.ticker;
+          }
 
-        const unit = !a
-          ? {
-              ...account.unit,
+          const unit = !a
+            ? {
+                ...account.unit,
+                code: account.currency.deviceTicker || account.unit.code,
+              }
+            : (transaction.mode === "compound.withdraw" &&
+              transaction.useAllAmount
+                ? expectedCompoundToken(findCompoundToken(a.token))
+                : a.token
+              ).units[0];
+          const amount =
+            a &&
+            a.compoundBalance &&
+            transaction.mode === "compound.withdraw" &&
+            transaction.useAllAmount
+              ? a.compoundBalance
+              : status.amount;
+          return formatCurrencyUnit(
+            {
+              ...unit,
               code: account.currency.deviceTicker || account.unit.code,
+              prefixCode: true,
+            },
+            amount,
+            {
+              showCode: true,
+              disableRounding: true,
+              joinFragmentsSeparator: " ",
             }
-          : (transaction.mode === "compound.withdraw" &&
-            transaction.useAllAmount
-              ? expectedCompoundToken(findCompoundToken(a.token))
-              : a.token
-            ).units[0];
-        const amount =
-          a &&
-          a.compoundBalance &&
-          transaction.mode === "compound.withdraw" &&
-          transaction.useAllAmount
-            ? a.compoundBalance
-            : status.amount;
-        return formatCurrencyUnit(
-          {
-            ...unit,
-            code: account.currency.deviceTicker || account.unit.code,
-            prefixCode: true,
-          },
-          amount,
-          {
-            showCode: true,
-            disableRounding: true,
-            joinFragmentsSeparator: " ",
-          }
-        ).replace(/\s/g, " ");
+          ).replace(/\s/g, " ");
+        },
       },
-    },
-    {
-      title: "Contract",
-      button: "Rr",
-    },
-    {
-      title: "Network",
-      button: "Rr",
-    },
-    {
-      title: "Max fees",
-      button: "Rr",
-      expectedValue: maxFeesExpectedValue,
-    },
-    {
-      // Legacy (ETC..)
-      title: "Max Fees",
-      button: "Rr",
-      expectedValue: maxFeesExpectedValue,
-    },
-    {
-      title: "Address",
-      button: "Rr",
-      expectedValue: ({ transaction }) => transaction.recipient,
-    },
-    {
-      title: "Accept",
-      button: "LRlr",
-    },
-    {
-      title: "Approve",
-      button: "LRlr",
-    },
-  ],
-});
-export default {
-  acceptTransaction,
-};
+      {
+        title: "Contract",
+        button: "Rr",
+      },
+      {
+        title: "Network",
+        button: "Rr",
+      },
+      {
+        title: "Max fees",
+        button: "Rr",
+        expectedValue: maxFeesExpectedValue,
+      },
+      {
+        // Legacy (ETC..)
+        title: "Max Fees",
+        button: "Rr",
+        expectedValue: maxFeesExpectedValue,
+      },
+      {
+        title: "Address",
+        button: "Rr",
+        expectedValue: ({ transaction }) => transaction.recipient,
+      },
+      {
+        title: "Accept",
+        button: "LRlr",
+      },
+      {
+        title: "Approve",
+        button: "LRlr",
+      },
+    ],
+  });

package/src/families/filecoin/specs.ts

@@ -6,6 +6,7 @@ import type { Transaction } from "../../families/filecoin/types";
 import { getCryptoCurrencyById } from "../../currencies";
 import { pickSiblings } from "../../bot/specs";
 import type { AppSpec } from "../../bot/types";
+import { acceptTransaction } from "./speculos-deviceActions";
 
 const MIN_SAFE = new BigNumber(100000);
 const maxAccount = 6;
@@ -17,7 +18,7 @@ const filecoinSpecs: AppSpec<Transaction> = {
     model: DeviceModelId.nanoS,
     appName: "Filecoin",
   },
-
+  genericDeviceAction: acceptTransaction,
   testTimeout: 5 * 60 * 1000,
   transactionCheck: ({ maxSpendable }) => {
     invariant(maxSpendable.gt(MIN_SAFE), "balance is too low");

package/src/families/filecoin/speculos-deviceActions.ts

@@ -3,65 +3,64 @@ import type { Transaction } from "./types";
 import { deviceActionFlow } from "../../bot/specs";
 import { formatCurrencyUnit } from "../../currencies";
 
-const acceptTransaction: DeviceAction<Transaction, any> = deviceActionFlow({
-  steps: [
-    {
-      title: "To",
-      button: "Rr",
-      expectedValue: ({ transaction }) => transaction.recipient,
-    },
-    {
-      title: "From",
-      button: "Rr",
-      expectedValue: ({ account }) => account.freshAddress,
-    },
-    {
-      title: "Nonce",
-      button: "Rr",
-      expectedValue: ({ transaction }) => transaction.nonce.toString(),
-    },
-    {
-      title: "Value",
-      button: "Rr",
-      expectedValue: ({ account, status }) =>
-        formatCurrencyUnit(account.unit, status.amount, {
-          disableRounding: true,
-          showAllDigits: true,
-        }),
-    },
-    {
-      title: "Gas Limit",
-      button: "Rr",
-      expectedValue: ({ transaction }) => transaction.gasLimit.toFixed(),
-    },
-    {
-      title: "Gas Premium",
-      button: "Rr",
-      expectedValue: ({ account, transaction }) =>
-        formatCurrencyUnit(account.unit, transaction.gasPremium, {
-          disableRounding: true,
-          showAllDigits: true,
-        }),
-    },
-    {
-      title: "Gas Fee Cap",
-      button: "Rr",
-      expectedValue: ({ account, transaction }) =>
-        formatCurrencyUnit(account.unit, transaction.gasFeeCap, {
-          disableRounding: true,
-          showAllDigits: true,
-        }),
-    },
-    {
-      title: "Method",
-      button: "Rr",
-      expectedValue: () => "Transfer",
-    },
-    {
-      title: "APPROVE",
-      button: "LRlr",
-    },
-  ],
-});
-
-export default { acceptTransaction };
+export const acceptTransaction: DeviceAction<Transaction, any> =
+  deviceActionFlow({
+    steps: [
+      {
+        title: "To",
+        button: "Rr",
+        expectedValue: ({ transaction }) => transaction.recipient,
+      },
+      {
+        title: "From",
+        button: "Rr",
+        expectedValue: ({ account }) => account.freshAddress,
+      },
+      {
+        title: "Nonce",
+        button: "Rr",
+        expectedValue: ({ transaction }) => transaction.nonce.toString(),
+      },
+      {
+        title: "Value",
+        button: "Rr",
+        expectedValue: ({ account, status }) =>
+          formatCurrencyUnit(account.unit, status.amount, {
+            disableRounding: true,
+            showAllDigits: true,
+          }),
+      },
+      {
+        title: "Gas Limit",
+        button: "Rr",
+        expectedValue: ({ transaction }) => transaction.gasLimit.toFixed(),
+      },
+      {
+        title: "Gas Premium",
+        button: "Rr",
+        expectedValue: ({ account, transaction }) =>
+          formatCurrencyUnit(account.unit, transaction.gasPremium, {
+            disableRounding: true,
+            showAllDigits: true,
+          }),
+      },
+      {
+        title: "Gas Fee Cap",
+        button: "Rr",
+        expectedValue: ({ account, transaction }) =>
+          formatCurrencyUnit(account.unit, transaction.gasFeeCap, {
+            disableRounding: true,
+            showAllDigits: true,
+          }),
+      },
+      {
+        title: "Method",
+        button: "Rr",
+        expectedValue: () => "Transfer",
+      },
+      {
+        title: "APPROVE",
+        button: "LRlr",
+      },
+    ],
+  });

package/src/families/hedera/__snapshots__/bridge.integration.test.ts.snap

@@ -1,5 +1,60 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`hedera currency bridge scanAccounts hedera seed 1 1`] = `Array []`;
+exports[`hedera currency bridge scanAccounts hedera seed 1 1`] = `
+Array [
+  Object {
+    "balance": "99870000",
+    "currencyId": "hedera",
+    "derivationMode": "hederaBip44",
+    "freshAddress": "0.0.1040977",
+    "freshAddressPath": "44/3030",
+    "freshAddresses": Array [
+      Object {
+        "address": "0.0.1040977",
+        "derivationPath": "44/3030",
+      },
+    ],
+    "id": "js:2:hedera:0.0.1040977:hederaBip44",
+    "index": 0,
+    "name": "Hedera 1",
+    "nfts": undefined,
+    "operationsCount": 1,
+    "pendingOperations": Array [],
+    "seedIdentifier": "9e92a312233d5fd6b5a723875aeea2cea81a8e48ffc00341cff6dffcfd3ab7f2",
+    "spendableBalance": "99870000",
+    "starred": false,
+    "swapHistory": Array [],
+    "syncHash": undefined,
+    "unitMagnitude": 8,
+    "used": true,
+  },
+]
+`;
 
-exports[`hedera currency bridge scanAccounts hedera seed 1 2`] = `Array []`;
+exports[`hedera currency bridge scanAccounts hedera seed 1 2`] = `
+Array [
+  Array [
+    Object {
+      "accountId": "js:2:hedera:0.0.1040977:hederaBip44",
+      "blockHash": null,
+      "blockHeight": 5,
+      "contract": undefined,
+      "extra": Object {},
+      "fee": "163081",
+      "hash": "iQ_oLq-PEMlwmoSEZBXpeK_J9ENApLJnz-uGB3_1XVqtRnMU-0VvdKmJV3E8ig5J",
+      "id": "js:2:hedera:0.0.1040977:hederaBip44-iQ_oLq-PEMlwmoSEZBXpeK_J9ENApLJnz-uGB3_1XVqtRnMU-0VvdKmJV3E8ig5J-IN",
+      "operator": undefined,
+      "recipients": Array [
+        "0.0.1040977",
+      ],
+      "senders": Array [
+        "0.0.880760",
+      ],
+      "standard": undefined,
+      "tokenId": undefined,
+      "type": "IN",
+      "value": "99870000",
+    },
+  ],
+]
+`;