@ledgerhq/live-common 27.0.0 → 27.0.1-next.0

package/src/families/crypto_org/speculos-deviceActions.ts

@@ -2,62 +2,61 @@ import type { DeviceAction } from "../../bot/types";
 import type { Transaction } from "./types";
 import { deviceActionFlow } from "../../bot/specs";
 
-const acceptTransaction: DeviceAction<Transaction, any> = deviceActionFlow({
-  steps: [
-    {
-      title: "Review",
-      button: "Rr",
-    },
-    {
-      title: "Chain ID",
-      button: "Rr",
-      // TODO: add a expectedValue fn
-    },
-    {
-      title: "Account",
-      button: "Rr",
-      // TODO: add a expectedValue fn
-    },
-    {
-      title: "Sequence",
-      button: "Rr",
-      // TODO: add a expectedValue fn
-    },
-    {
-      title: "Type",
-      button: "Rr",
-      // TODO: add a expectedValue fn
-    },
-    {
-      title: "Amount",
-      button: "Rr",
-      // TODO: add a expectedValue fn
-    },
-    {
-      title: "From",
-      button: "Rr",
-      // TODO: add a expectedValue fn
-    },
-    {
-      title: "Fee",
-      button: "Rr",
-      // TODO: add a expectedValue fn
-    },
-    {
-      title: "Gas",
-      button: "Rr",
-      // TODO: add a expectedValue fn
-    },
-    {
-      title: "To",
-      button: "Rr",
-      expectedValue: ({ transaction }) => transaction.recipient,
-    },
-    {
-      title: "Approve",
-      button: "LRlr",
-    },
-  ],
-});
-
-export default { acceptTransaction };
+export const acceptTransaction: DeviceAction<Transaction, any> =
+  deviceActionFlow({
+    steps: [
+      {
+        title: "Review",
+        button: "Rr",
+      },
+      {
+        title: "Chain ID",
+        button: "Rr",
+        // TODO: add a expectedValue fn
+      },
+      {
+        title: "Account",
+        button: "Rr",
+        // TODO: add a expectedValue fn
+      },
+      {
+        title: "Sequence",
+        button: "Rr",
+        // TODO: add a expectedValue fn
+      },
+      {
+        title: "Type",
+        button: "Rr",
+        // TODO: add a expectedValue fn
+      },
+      {
+        title: "Amount",
+        button: "Rr",
+        // TODO: add a expectedValue fn
+      },
+      {
+        title: "From",
+        button: "Rr",
+        // TODO: add a expectedValue fn
+      },
+      {
+        title: "Fee",
+        button: "Rr",
+        // TODO: add a expectedValue fn
+      },
+      {
+        title: "Gas",
+        button: "Rr",
+        // TODO: add a expectedValue fn
+      },
+      {
+        title: "To",
+        button: "Rr",
+        expectedValue: ({ transaction }) => transaction.recipient,
+      },
+      {
+        title: "Approve",
+        button: "LRlr",
+      },
+    ],
+  });

package/src/families/elrond/specs.ts

@@ -1,14 +1,24 @@
 import type { Transaction } from "../../families/elrond/types";
 import invariant from "invariant";
 import { getCryptoCurrencyById } from "../../currencies";
-import { pickSiblings } from "../../bot/specs";
-import type { AppSpec } from "../../bot/types";
+import { botTest, pickSiblings } from "../../bot/specs";
+import type { AppSpec, TransactionTestInput } from "../../bot/types";
 import { toOperationRaw } from "../../account";
 import { DeviceModelId } from "@ledgerhq/devices";
 import BigNumber from "bignumber.js";
 import expect from "expect";
+import { acceptTransaction } from "./speculos-deviceActions";
 
 const ELROND_MIN_SAFE = new BigNumber(10000);
+const maxAccounts = 6;
+
+function expectCorrectBalanceChange(input: TransactionTestInput<Transaction>) {
+  const { account, operation, accountBeforeTransaction } = input;
+  expect(account.balance.toNumber()).toBe(
+    accountBeforeTransaction.balance.minus(operation.value).toNumber()
+  );
+}
+
 const elrondSpec: AppSpec<Transaction> = {
   name: "Elrond",
   currency: getCryptoCurrencyById("elrond"),
@@ -16,6 +26,7 @@ const elrondSpec: AppSpec<Transaction> = {
     model: DeviceModelId.nanoS,
     appName: "Elrond",
   },
+  genericDeviceAction: acceptTransaction,
   testTimeout: 2 * 60 * 1000,
   transactionCheck: ({ maxSpendable }) => {
     invariant(maxSpendable.gt(ELROND_MIN_SAFE), "balance is too low");
@@ -30,14 +41,17 @@ const elrondSpec: AppSpec<Transaction> = {
     delete opExpected.date;
     delete opExpected.blockHash;
     delete opExpected.blockHeight;
-    expect(toOperationRaw(operation)).toMatchObject(opExpected);
+    botTest("optimistic operation matches", () =>
+      expect(toOperationRaw(operation)).toMatchObject(opExpected)
+    );
   },
   mutations: [
     {
       name: "send 50%~",
       maxRun: 1,
       transaction: ({ account, siblings, bridge }) => {
-        const sibling = pickSiblings(siblings, 2);
+        invariant(account.spendableBalance.gt(0), "balance is 0");
+        const sibling = pickSiblings(siblings, maxAccounts);
         let amount = account.spendableBalance
           .div(1.9 + 0.2 * Math.random())
           .integerValue();
@@ -62,6 +76,9 @@ const elrondSpec: AppSpec<Transaction> = {
           ],
         };
       },
+      test: (input) => {
+        expectCorrectBalanceChange(input);
+      },
     },
   ],
 };

package/src/families/elrond/speculos-deviceActions.ts

@@ -2,45 +2,44 @@ import type { DeviceAction } from "../../bot/types";
 import type { Transaction } from "./types";
 import { deviceActionFlow } from "../../bot/specs";
 import { formatCurrencyUnit } from "../../currencies";
-const acceptTransaction: DeviceAction<Transaction, any> = deviceActionFlow({
-  steps: [
-    {
-      title: "Receiver",
-      button: "Rr",
-      expectedValue: ({ transaction }) => transaction.recipient,
-    },
-    {
-      title: "Amount",
-      button: "Rr",
-      expectedValue: ({ account, transaction }) =>
-        formatCurrencyUnit(account.unit, transaction.amount, {
-          showCode: true,
-          disableRounding: true,
-          joinFragmentsSeparator: " ",
-        })
-          .replace(/\s+/g, " ")
-          .replace("egld", "EGLD"), // FIXME
-    },
-    {
-      title: "Fee",
-      button: "Rr",
-      // TODO: add a expectedValue fn
-    },
-    {
-      title: "Data",
-      button: "Rr",
-    },
-    {
-      title: "Sign",
-      button: "LRlr",
-    },
-    {
-      title: "Network",
-      button: "Rr",
-      expectedValue: () => "Mainnet",
-    },
-  ],
-});
-export default {
-  acceptTransaction,
-};
+
+export const acceptTransaction: DeviceAction<Transaction, any> =
+  deviceActionFlow({
+    steps: [
+      {
+        title: "Receiver",
+        button: "Rr",
+        expectedValue: ({ transaction }) => transaction.recipient,
+      },
+      {
+        title: "Amount",
+        button: "Rr",
+        expectedValue: ({ account, transaction }) =>
+          formatCurrencyUnit(account.unit, transaction.amount, {
+            showCode: true,
+            disableRounding: true,
+            joinFragmentsSeparator: " ",
+          })
+            .replace(/\s+/g, " ")
+            .replace("egld", "EGLD"), // FIXME
+      },
+      {
+        title: "Fee",
+        button: "Rr",
+        // TODO: add a expectedValue fn
+      },
+      {
+        title: "Data",
+        button: "Rr",
+      },
+      {
+        title: "Sign",
+        button: "LRlr",
+      },
+      {
+        title: "Network",
+        button: "Rr",
+        expectedValue: () => "Mainnet",
+      },
+    ],
+  });