@indigoai-us/hq-cli 5.77.14 → 5.78.0

package/src/commands/pack-update-cache.test.ts

@@ -1,149 +0,0 @@
-import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
-import * as fs from 'fs';
-import * as os from 'os';
-import * as path from 'path';
-import { execFileSync } from 'child_process';
-
-vi.mock('child_process', () => ({
-  execFileSync: vi.fn(),
-  spawnSync: vi.fn(() => ({ status: 0 })),
-}));
-
-vi.mock('../utils/vault-api.js', () => ({
-  vaultApiFetchPublic: vi.fn(),
-}));
-
-const tmpHome = path.join(os.tmpdir(), `hq-pack-update-cache-${process.pid}`);
-
-beforeEach(() => {
-  fs.rmSync(tmpHome, { recursive: true, force: true });
-  fs.mkdirSync(tmpHome, { recursive: true });
-  vi.stubEnv('HOME', tmpHome);
-  vi.mocked(execFileSync).mockReset();
-});
-
-afterEach(() => {
-  vi.unstubAllEnvs();
-  vi.restoreAllMocks();
-  vi.unstubAllGlobals();
-  fs.rmSync(tmpHome, { recursive: true, force: true });
-});
-
-async function loadModule() {
-  vi.resetModules();
-  return await import('./pack-install.js');
-}
-
-describe('resolveLatest pack update cache', () => {
-  it('fetches npm registry metadata over HTTP once, then compares cached latest against the installed version at read time', async () => {
-    const fetchMock = vi.fn().mockResolvedValue({
-      ok: true,
-      json: async () => ({ version: '2.0.0' }),
-    } as unknown as Response);
-    vi.stubGlobal('fetch', fetchMock);
-
-    const { resolveLatest } = await loadModule();
-
-    const staleInstall = await resolveLatest('@scope/pack@1.0.0', '1.0.0', {
-      forceRefresh: true,
-    });
-    const currentInstall = await resolveLatest('@scope/pack@1.0.0', '2.0.0');
-
-    expect(staleInstall).toMatchObject({
-      transport: 'npm',
-      current: '1.0.0',
-      latest: '2.0.0',
-      updateAvailable: true,
-    });
-    expect(currentInstall).toMatchObject({
-      transport: 'npm',
-      current: '2.0.0',
-      latest: '2.0.0',
-      updateAvailable: false,
-    });
-    expect(fetchMock).toHaveBeenCalledTimes(1);
-    expect(vi.mocked(execFileSync)).not.toHaveBeenCalledWith(
-      'npm',
-      ['view', '@scope/pack', 'version'],
-      expect.anything(),
-    );
-    expect(fs.existsSync(path.join(tmpHome, '.hq', 'pack-update-cache.json'))).toBe(true);
-  });
-
-  it('bypasses a fresh npm cache entry when forceRefresh is set', async () => {
-    const fetchMock = vi
-      .fn()
-      .mockResolvedValueOnce({
-        ok: true,
-        json: async () => ({ version: '2.0.0' }),
-      } as unknown as Response)
-      .mockResolvedValueOnce({
-        ok: true,
-        json: async () => ({ version: '3.0.0' }),
-      } as unknown as Response);
-    vi.stubGlobal('fetch', fetchMock);
-
-    const { resolveLatest } = await loadModule();
-
-    await resolveLatest('@scope/pack@1.0.0', '1.0.0', { forceRefresh: true });
-    const refreshed = await resolveLatest('@scope/pack@1.0.0', '1.0.0', {
-      forceRefresh: true,
-    });
-
-    expect(refreshed).toMatchObject({
-      latest: '3.0.0',
-      updateAvailable: true,
-    });
-    expect(fetchMock).toHaveBeenCalledTimes(2);
-  });
-
-  it('shares git ls-remote probes by URL and ref within one process', async () => {
-    vi.mocked(execFileSync).mockImplementation((_cmd, args) => {
-      const argv = args as string[];
-      if (argv[1] === '--heads') return '';
-      if (argv[0] === 'ls-remote') return 'abcdef1234567890\tHEAD\n';
-      throw new Error(`unexpected command: ${argv.join(' ')}`);
-    });
-
-    const { resolveLatest } = await loadModule();
-
-    const first = await resolveLatest('https://example.test/repo.git#123456', '1.0.0');
-    const second = await resolveLatest('https://example.test/repo.git#123456', '1.0.0');
-
-    expect(first.latest).toBe('abcdef1234567890');
-    expect(second.latest).toBe('abcdef1234567890');
-    const lsRemoteCalls = vi
-      .mocked(execFileSync)
-      .mock.calls.filter(([cmd, args]) => cmd === 'git' && (args as string[])[0] === 'ls-remote');
-    expect(lsRemoteCalls).toHaveLength(2);
-  });
-
-  it('uses a fresh git disk cache entry without probing git for SHA-pinned sources', async () => {
-    const installedSha = '1111111111111111111111111111111111111111';
-    vi.mocked(execFileSync).mockImplementation((_cmd, args) => {
-      const argv = args as string[];
-      if (argv[0] === 'ls-remote') return 'abcdef1234567890\tHEAD\n';
-      throw new Error(`unexpected command: ${argv.join(' ')}`);
-    });
-
-    const firstModule = await loadModule();
-    await firstModule.resolveLatest(`https://example.test/repo.git#${installedSha}`, '1.0.0', {
-      forceRefresh: true,
-    });
-
-    vi.mocked(execFileSync).mockReset();
-    const secondModule = await loadModule();
-    const cached = await secondModule.resolveLatest(
-      `https://example.test/repo.git#${installedSha}`,
-      '1.0.0',
-    );
-
-    expect(cached).toMatchObject({
-      transport: 'git',
-      current: installedSha,
-      latest: 'abcdef1234567890',
-      updateAvailable: true,
-    });
-    expect(vi.mocked(execFileSync)).not.toHaveBeenCalled();
-  });
-});

package/src/commands/packs-update-api-key.test.ts

@@ -1,105 +0,0 @@
-// @vitest-environment node
-/**
- * Regression (Codex P1 follow-up on hq-cli#273): `hq packs update` un-wires a
- * pack's existing contributions BEFORE calling `installPack()` to re-wire
- * them. The Cognito-only `HQ_API_KEY` fail-closed gate added for `hq install`
- * must live ONLY at that top-level CLI route (pkg-install.ts) — NOT inside
- * the shared `installPack()` primitive `hq packs update` also calls. If it
- * lived inside `installPack()`, a vault-key session would un-wire a pack and
- * then throw before re-installing it, leaving the pack unwired with no
- * symlinks and no rollback.
- */
-import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
-import * as os from 'os';
-import { Command } from 'commander';
-
-const { listInstalledPacks, unwirePack, installPack, resolveLatest } = vi.hoisted(() => ({
-  listInstalledPacks: vi.fn(),
-  unwirePack: vi.fn(() => ({ unlinked: [], skipped: [] })),
-  installPack: vi.fn(async () => {}),
-  resolveLatest: vi.fn(async () => ({
-    transport: 'git',
-    current: 'aaa',
-    latest: 'bbb',
-    updateAvailable: true,
-  })),
-}));
-
-vi.mock('./pack-install.js', () => ({
-  classify: vi.fn(() => 'git'),
-  resolveLatest,
-  resolveLatestMarketplace: vi.fn(),
-  runScanPackages: vi.fn(),
-  installPack,
-}));
-
-vi.mock('../utils/pack-contributions.js', () => ({
-  contributionLinks: vi.fn(() => []),
-  linkStatus: vi.fn(() => 'live'),
-  listInstalledPacks,
-  findDependentPacks: vi.fn(() => []),
-  readPackManifest: vi.fn(() => ({ manifest: null })),
-  unwirePack,
-  unwirePackMcp: vi.fn(),
-  readHqVersion: vi.fn(() => '15.0.0'),
-  readRecommendedPackages: vi.fn(() => []),
-  packagesDir: vi.fn((root: string) => `${root}/core/packages`),
-}));
-
-// resolveRoot() falls back to findHqRoot() when --hq-root isn't passed; stub
-// it to a real, existing directory so packs.ts never chdir()s into one.
-vi.mock('../utils/manifest.js', () => ({
-  findHqRoot: vi.fn(() => os.tmpdir()),
-}));
-
-import { registerPacksCommand } from './packs.js';
-
-async function runUpdateCli(...args: string[]): Promise<void> {
-  const program = new Command();
-  program.exitOverride();
-  registerPacksCommand(program);
-  await program.parseAsync(['packs', 'update', ...args], { from: 'user' });
-}
-
-describe('hq packs update leaves no pack unwired under HQ_API_KEY', () => {
-  beforeEach(() => {
-    listInstalledPacks.mockReturnValue([
-      {
-        name: 'hq-pack-demo',
-        dir: '/tmp/hq/core/packages/hq-pack-demo',
-        manifest: {
-          name: 'hq-pack-demo',
-          version: '1.0.0',
-          source: 'https://example.com/demo.git#aaa',
-          contributes: { skills: ['demo'] },
-        },
-      },
-    ]);
-    unwirePack.mockClear();
-    installPack.mockClear();
-  });
-
-  afterEach(() => {
-    delete process.env.HQ_API_KEY;
-  });
-
-  it('still calls installPack after unwirePack when HQ_API_KEY is set', async () => {
-    process.env.HQ_API_KEY = 'hqk_probe';
-    await runUpdateCli('hq-pack-demo', '--json');
-
-    expect(unwirePack).toHaveBeenCalledTimes(1);
-    // The regression: installPack must run to completion right after
-    // unwirePack -- it must NOT throw due to a Cognito-only gate, which would
-    // leave the pack unwired with nothing re-installed in its place.
-    expect(installPack).toHaveBeenCalledTimes(1);
-    const unwireOrder = unwirePack.mock.invocationCallOrder[0];
-    const installOrder = installPack.mock.invocationCallOrder[0];
-    expect(unwireOrder).toBeLessThan(installOrder);
-  });
-
-  it('still updates without HQ_API_KEY set (baseline, unchanged behavior)', async () => {
-    await runUpdateCli('hq-pack-demo', '--json');
-    expect(unwirePack).toHaveBeenCalledTimes(1);
-    expect(installPack).toHaveBeenCalledTimes(1);
-  });
-});

package/src/commands/packs.test.ts

@@ -1,88 +0,0 @@
-/**
- * packs list view tests — guards the machine-facing `hq packs list --json`
- * shape consumed by the HQ Sync menubar app.
- *
- * US-005: `buildInstalledView` must surface a pack's `initialization` block so
- * the desktop "Installed" panel can render its get-started affordance. The
- * field is OPTIONAL — absent on legacy packs, in which case it is omitted from
- * the view entirely (no null noise in the JSON).
- */
-
-import { describe, it, expect } from 'vitest';
-import { buildInstalledView } from './packs.js';
-import type {
-  InstalledPack,
-  InstalledPackManifest,
-} from '../utils/pack-contributions.js';
-
-// ---------------------------------------------------------------------------
-// Fixtures
-// ---------------------------------------------------------------------------
-
-function fakeInstalledPack(
-  manifestOverrides: Partial<InstalledPackManifest>,
-): InstalledPack {
-  const manifest: InstalledPackManifest = {
-    name: 'hq-pack-test',
-    version: '1.0.0',
-    publisher: '@indigoai-us',
-    access: 'public',
-    requires: { hqCore: '>=12.0.0' },
-    contributes: { skills: ['email-assistant'] },
-    ...manifestOverrides,
-  } as InstalledPackManifest;
-  return {
-    name: 'hq-pack-test',
-    // A non-existent dir is fine — contributionLinks classifies missing links
-    // without throwing, and we never check updates (no network).
-    dir: '/tmp/does-not-exist/hq-pack-test',
-    manifest,
-  };
-}
-
-// `checkUpdates: false` keeps the call offline (no resolveLatest network hop).
-function build(pack: InstalledPack) {
-  return buildInstalledView('/tmp/does-not-exist', '12.0.0', pack, new Set(), false);
-}
-
-// ---------------------------------------------------------------------------
-// Tests
-// ---------------------------------------------------------------------------
-
-describe('buildInstalledView: initialization surfacing (US-005)', () => {
-  it('surfaces the initialization block when the pack declares one', () => {
-    const view = build(
-      fakeInstalledPack({
-        initialization: { entrypoint: 'email-assistant', prompt: 'hi there' },
-      }),
-    );
-    expect(view.initialization).toEqual({
-      entrypoint: 'email-assistant',
-      prompt: 'hi there',
-    });
-  });
-
-  it('surfaces initialization with no prompt (entrypoint only)', () => {
-    const view = build(
-      fakeInstalledPack({ initialization: { entrypoint: '/email-assistant' } }),
-    );
-    expect(view.initialization).toEqual({ entrypoint: '/email-assistant' });
-    expect(view.initialization).not.toHaveProperty('prompt');
-  });
-
-  it('omits the initialization field entirely when the pack declares none', () => {
-    const view = build(fakeInstalledPack({}));
-    expect(view.initialization).toBeUndefined();
-    expect(Object.prototype.hasOwnProperty.call(view, 'initialization')).toBe(false);
-  });
-
-  it('tolerates a malformed initialization block by omitting the field', () => {
-    const view = build(
-      fakeInstalledPack({
-        // An empty entrypoint is not a usable get-started target.
-        initialization: { entrypoint: '   ' },
-      }),
-    );
-    expect(view.initialization).toBeUndefined();
-  });
-});