@indigoai-us/hq-cli 5.77.14 → 5.78.0

package/src/utils/cognito-session.test.ts

@@ -1,328 +0,0 @@
-/**
- * Unit tests for resolveDefaultHqRoot — Cognito session helper bits that
- * don't need a live JWT or vault round-trip.
- */
-
-import { describe, it, expect, beforeEach, afterEach } from "vitest";
-import { mkdtempSync, realpathSync, rmSync, writeFileSync, mkdirSync } from "node:fs";
-import { tmpdir } from "node:os";
-import { join } from "node:path";
-
-import {
-  CLI_CLIENT_INFO,
-  buildVaultConfig,
-  resolveDefaultHqRoot,
-} from "./cognito-session.js";
-import { CLI_NAME, CLI_VERSION } from "../cli-version.js";
-
-describe("resolveDefaultHqRoot", () => {
-  let tmpRoot: string;
-  let origCwd: string;
-  let origEnv: string | undefined;
-  let origHome: string | undefined;
-
-  // `~/.hq` records (menubar.json/config.json) + discovery candidates are all
-  // keyed off os.homedir(), which honors $HOME on POSIX/macOS. Pin HOME to a
-  // clean tmp dir so every tier is hermetic — the real machine's HQ install
-  // can't leak into the fallback/discovery assertions below.
-  let fakeHome: string;
-
-  beforeEach(() => {
-    tmpRoot = mkdtempSync(join(tmpdir(), "hq-cli-resolveroot-"));
-    fakeHome = join(tmpRoot, "home");
-    mkdirSync(fakeHome, { recursive: true });
-    origCwd = process.cwd();
-    origEnv = process.env.HQ_ROOT;
-    origHome = process.env.HOME;
-    delete process.env.HQ_ROOT;
-    process.env.HOME = fakeHome;
-  });
-
-  afterEach(() => {
-    process.chdir(origCwd);
-    rmSync(tmpRoot, { recursive: true, force: true });
-    if (origEnv === undefined) delete process.env.HQ_ROOT;
-    else process.env.HQ_ROOT = origEnv;
-    if (origHome === undefined) delete process.env.HOME;
-    else process.env.HOME = origHome;
-  });
-
-  /** Write `~/.hq/<file>` (creating `~/.hq`) with the given JSON object. */
-  function writeHqConfig(file: string, obj: Record<string, unknown>): void {
-    const hqDir = join(fakeHome, ".hq");
-    mkdirSync(hqDir, { recursive: true });
-    writeFileSync(join(hqDir, file), JSON.stringify(obj));
-  }
-
-  it("priority 1: honors $HQ_ROOT env var (resolved to absolute path)", () => {
-    const explicit = join(tmpRoot, "explicit-target");
-    mkdirSync(explicit, { recursive: true });
-    process.env.HQ_ROOT = explicit;
-
-    expect(resolveDefaultHqRoot()).toBe(explicit);
-  });
-
-  it("priority 2: walks up from cwd to the nearest dir containing core.yaml AND companies/", () => {
-    const hqDir = join(tmpRoot, "Documents", "coding-projects", "hq");
-    const nested = join(hqDir, "companies", "sum-digital");
-    mkdirSync(nested, { recursive: true });
-    writeFileSync(join(hqDir, "core.yaml"), "version: 14.1.1\n");
-    // companies/ already exists (we mkdir'd nested inside it)
-
-    process.chdir(nested);
-    expect(resolveDefaultHqRoot()).toBe(realpathSync(hqDir));
-
-    process.chdir(hqDir);
-    expect(resolveDefaultHqRoot()).toBe(realpathSync(hqDir));
-  });
-
-  it("priority 2: SKIPS a nested core/core.yaml without a sibling companies/ dir (Codex P2 on hq#146)", () => {
-    // Recreates the live HQ layout: a real root has core.yaml + companies/,
-    // and the synced core/ subtree contains its own core.yaml (the template
-    // version-source-of-truth) but NO companies/. Single-marker detection
-    // would stop at <hqRoot>/core/ and silently miss the real content.
-    const hqDir = join(tmpRoot, "Documents", "coding-projects", "hq");
-    const innerCore = join(hqDir, "core");
-    const cwdInsideCore = join(innerCore, "knowledge");
-    mkdirSync(cwdInsideCore, { recursive: true });
-    mkdirSync(join(hqDir, "companies"), { recursive: true });
-    writeFileSync(join(hqDir, "core.yaml"), "version: 14.1.1\n");
-    writeFileSync(join(innerCore, "core.yaml"), "template-version: 14.1.1\n");
-
-    process.chdir(cwdInsideCore);
-    // Should walk PAST the inner core/core.yaml (no companies/ sibling) and
-    // resolve to the real hqDir.
-    expect(resolveDefaultHqRoot()).toBe(realpathSync(hqDir));
-  });
-
-  it("tier 6: falls back to ~/hq when nothing (env, cwd, ~/.hq records, discovery) resolves", () => {
-    const stranded = join(tmpRoot, "stranded");
-    mkdirSync(stranded, { recursive: true });
-    process.chdir(stranded);
-
-    const result = resolveDefaultHqRoot();
-    // No $HQ_ROOT, no core.yaml+companies/ above cwd, no ~/.hq records, no
-    // discoverable root under the (pinned) home → last-resort ~/hq.
-    expect(result).not.toBe(stranded);
-    expect(result).toBe(join(fakeHome, "hq"));
-  });
-
-  it("a dir with only core.yaml (no companies/) is NOT a valid HQ root (walk-up)", () => {
-    // core.yaml present but no companies/ sibling → not a root; with no other
-    // signal, fall through to ~/hq. This is the synced core/ subtree's shape.
-    const lonelyCoreYaml = join(tmpRoot, "lonely");
-    mkdirSync(lonelyCoreYaml, { recursive: true });
-    writeFileSync(join(lonelyCoreYaml, "core.yaml"), "");
-    process.chdir(lonelyCoreYaml);
-
-    const result = resolveDefaultHqRoot();
-    expect(result).not.toBe(lonelyCoreYaml);
-    expect(result).toBe(join(fakeHome, "hq"));
-  });
-
-  it("$HQ_ROOT wins over walking-up resolution", () => {
-    const walkable = join(tmpRoot, "walkable");
-    const explicit = join(tmpRoot, "explicit");
-    mkdirSync(join(walkable, "nested"), { recursive: true });
-    mkdirSync(join(walkable, "companies"), { recursive: true });
-    mkdirSync(explicit, { recursive: true });
-    writeFileSync(join(walkable, "core.yaml"), "");
-
-    process.chdir(join(walkable, "nested"));
-    process.env.HQ_ROOT = explicit;
-
-    expect(resolveDefaultHqRoot()).toBe(explicit);
-  });
-
-  // ── tiers 3–5: installer/menubar records + discovery (the feedback_3967e294
-  //    split-brain fix) ────────────────────────────────────────────────────
-  //
-  // REGRESSION: run from a cwd OUTSIDE any HQ tree with $HQ_ROOT unset. Before
-  // the fix the CLI fell straight to ~/hq and the sync engine created+filled a
-  // brand-new stub there, diverging from the AppBar's real root. It must now
-  // read ~/.hq/menubar.json → hqPath (the same record HQ Sync reads first).
-  it("tier 3: reads ~/.hq/menubar.json → hqPath from an unrelated cwd (feedback_3967e294)", () => {
-    const realRoot = join(tmpRoot, "Desktop", "HQ");
-    mkdirSync(realRoot, { recursive: true });
-    writeHqConfig("menubar.json", { machineId: "abc", hqPath: realRoot });
-
-    const stranded = join(tmpRoot, "some", "unrelated", "cwd");
-    mkdirSync(stranded, { recursive: true });
-    process.chdir(stranded);
-
-    expect(resolveDefaultHqRoot()).toBe(realRoot);
-  });
-
-  it("tier 4: reads ~/.hq/config.json → hqFolderPath when menubar.json is absent", () => {
-    const realRoot = join(tmpRoot, "Desktop", "HQ");
-    mkdirSync(realRoot, { recursive: true });
-    writeHqConfig("config.json", { hqFolderPath: realRoot });
-
-    const stranded = join(tmpRoot, "unrelated");
-    mkdirSync(stranded, { recursive: true });
-    process.chdir(stranded);
-
-    expect(resolveDefaultHqRoot()).toBe(realRoot);
-  });
-
-  it("tier 3 wins over tier 4: menubar.json hqPath beats config.json hqFolderPath", () => {
-    const fromMenubar = join(tmpRoot, "menubar-root");
-    const fromConfig = join(tmpRoot, "config-root");
-    mkdirSync(fromMenubar, { recursive: true });
-    mkdirSync(fromConfig, { recursive: true });
-    writeHqConfig("menubar.json", { hqPath: fromMenubar });
-    writeHqConfig("config.json", { hqFolderPath: fromConfig });
-
-    process.chdir(tmpRoot);
-    expect(resolveDefaultHqRoot()).toBe(fromMenubar);
-  });
-
-  it("an empty hqPath in menubar.json falls through to config.json (mirrors hq-sync)", () => {
-    const fromConfig = join(tmpRoot, "config-root");
-    mkdirSync(fromConfig, { recursive: true });
-    writeHqConfig("menubar.json", { hqPath: "" });
-    writeHqConfig("config.json", { hqFolderPath: fromConfig });
-
-    process.chdir(tmpRoot);
-    expect(resolveDefaultHqRoot()).toBe(fromConfig);
-  });
-
-  it("tier 2 (cwd walk-up) wins over tier 3 (menubar.json) — operate on the tree you're inside", () => {
-    // A user cd'd into a real HQ checkout must target THAT tree even when
-    // menubar.json points elsewhere — least-surprising for multi-checkout devs.
-    const insideRoot = join(tmpRoot, "checkout-a");
-    const nested = join(insideRoot, "companies", "acme");
-    mkdirSync(nested, { recursive: true });
-    mkdirSync(join(insideRoot, "core"), { recursive: true });
-    writeFileSync(
-      join(insideRoot, "core", "core.yaml"),
-      "version: 1\nhqVersion: \"15.0.0\"\n",
-    );
-    writeHqConfig("menubar.json", { hqPath: join(tmpRoot, "checkout-b") });
-
-    process.chdir(nested);
-    expect(resolveDefaultHqRoot()).toBe(realpathSync(insideRoot));
-  });
-
-  it("tier 2: walk-up detects a v14+/v15 root whose core.yaml lives at core/core.yaml", () => {
-    // hq-core v14 moved core.yaml from <root>/core.yaml to <root>/core/core.yaml.
-    // The walk-up must detect the modern layout (this was the second half of
-    // the bug — the CLI only checked the legacy root-level core.yaml).
-    const hqDir = join(tmpRoot, "Desktop", "HQ");
-    const nested = join(hqDir, "companies", "acme");
-    mkdirSync(nested, { recursive: true });
-    mkdirSync(join(hqDir, "core"), { recursive: true });
-    writeFileSync(
-      join(hqDir, "core", "core.yaml"),
-      "version: 1\nhqVersion: \"15.0.11\"\n",
-    );
-
-    process.chdir(nested);
-    expect(resolveDefaultHqRoot()).toBe(realpathSync(hqDir));
-  });
-
-  it("tier 5: discovers ~/HQ via a valid core/core.yaml signature when no ~/.hq records exist", () => {
-    // No $HQ_ROOT, no walk-up hit, no menubar/config records → discovery scans
-    // the well-known locations. ~/HQ with a schema-valid core/core.yaml wins.
-    const discovered = join(fakeHome, "HQ");
-    mkdirSync(join(discovered, "core"), { recursive: true });
-    writeFileSync(
-      join(discovered, "core", "core.yaml"),
-      "version: 1\nhqVersion: \"15.0.11\"\n",
-    );
-
-    const stranded = join(tmpRoot, "unrelated");
-    mkdirSync(stranded, { recursive: true });
-    process.chdir(stranded);
-
-    expect(resolveDefaultHqRoot()).toBe(discovered);
-  });
-
-  it("tier 5: discovery REJECTS a core.yaml lacking the version+hqVersion schema", () => {
-    // A stray core.yaml (from another tool) must not false-match — both fields
-    // are required, mirroring hq-sync's is_valid_hq_root.
-    const notHq = join(fakeHome, "HQ");
-    mkdirSync(join(notHq, "core"), { recursive: true });
-    writeFileSync(join(notHq, "core", "core.yaml"), "someOtherTool: true\n");
-
-    const stranded = join(tmpRoot, "unrelated");
-    mkdirSync(stranded, { recursive: true });
-    process.chdir(stranded);
-
-    // No valid discovery hit → tier 6 fallback.
-    expect(resolveDefaultHqRoot()).toBe(join(fakeHome, "hq"));
-  });
-
-  // ── onMissing: throw vs fallback ──────────────────────────────────────
-  //
-  // Default behavior (no opts) is fallback to ~/hq — preserves the
-  // pre-dedup module-load contract of `DEFAULT_HQ_ROOT = resolveDefaultHqRoot()`.
-  // Module-management commands (pkg-*, team-sync) opt into throw mode so a
-  // user invoking the command from outside an HQ gets a clear error instead
-  // of a silent default-path miss.
-  it("onMissing: 'throw' throws when no HQ root is found above cwd", () => {
-    const stranded = join(tmpRoot, "stranded");
-    mkdirSync(stranded, { recursive: true });
-    process.chdir(stranded);
-
-    expect(() => resolveDefaultHqRoot({ onMissing: "throw" })).toThrow(
-      /Could not find HQ root/i,
-    );
-  });
-
-  it("onMissing: 'throw' still honors $HQ_ROOT even though dir wouldn't otherwise be detected", () => {
-    // HQ_ROOT is treated as an explicit assertion by the caller — no
-    // walk-and-throw applies. Module-management commands run with
-    // HQ_ROOT=/abs/path should succeed regardless of cwd.
-    const explicit = join(tmpRoot, "explicit");
-    mkdirSync(explicit, { recursive: true });
-    process.env.HQ_ROOT = explicit;
-    process.chdir(tmpRoot);
-
-    expect(resolveDefaultHqRoot({ onMissing: "throw" })).toBe(explicit);
-  });
-
-  it("onMissing: 'throw' still resolves when cwd IS an HQ root", () => {
-    const hqDir = join(tmpRoot, "hq");
-    mkdirSync(join(hqDir, "companies"), { recursive: true });
-    writeFileSync(join(hqDir, "core.yaml"), "version: 14.1.1\n");
-
-    process.chdir(hqDir);
-    // realpath both sides: macOS /tmp -> /private/var/folders symlink would
-    // otherwise produce a spurious mismatch (same root cause as the two
-    // pre-existing failing `priority 2:` tests above).
-    expect(realpathSync(resolveDefaultHqRoot({ onMissing: "throw" }))).toBe(
-      realpathSync(hqDir),
-    );
-  });
-
-  it("default (no opts) falls back to ~/hq — back-compat with module-load DEFAULT_HQ_ROOT", () => {
-    // Regression pin: any code that imports `DEFAULT_HQ_ROOT` (resolved at
-    // module load) MUST NOT throw if the loader's cwd is outside an HQ.
-    // This contract pre-dates the onMissing parameter and several commands
-    // depend on it (commander.js .option() registration time).
-    const stranded = join(tmpRoot, "stranded");
-    mkdirSync(stranded, { recursive: true });
-    process.chdir(stranded);
-
-    expect(() => resolveDefaultHqRoot()).not.toThrow();
-  });
-});
-
-describe("CLI_CLIENT_INFO + buildVaultConfig", () => {
-  it("exposes the CLI's package name and version", () => {
-    expect(CLI_CLIENT_INFO.name).toBe(CLI_NAME);
-    expect(CLI_CLIENT_INFO.version).toBe(CLI_VERSION);
-    // Name should always be the @indigoai-us scoped slug — guard against accidental
-    // renames that would silently break server-side traffic attribution.
-    expect(CLI_NAME).toBe("@indigoai-us/hq-cli");
-    expect(CLI_VERSION).toMatch(/^\d+\.\d+\.\d+/);
-  });
-
-  it("buildVaultConfig stamps clientInfo onto the returned config", () => {
-    const cfg = buildVaultConfig("dummy-token");
-    expect(cfg.clientInfo).toBe(CLI_CLIENT_INFO);
-    expect(cfg.clientInfo?.name).toBe("@indigoai-us/hq-cli");
-    expect(cfg.clientInfo?.version).toBe(CLI_VERSION);
-  });
-});