@indigoai-us/hq-cli 5.77.14 → 5.78.0

package/src/commands/cloud.pull-all.test.ts

@@ -1,711 +0,0 @@
-/**
- * Unit tests for `pullAll` — the orchestrator behind `hq sync pull --all`.
- *
- * Mirrors the dependency-injection layout used in `cloud-provision.test.ts`:
- * the action handler in `cloud.ts` resolves a real `VaultClient` + `sync`,
- * but `pullAll` itself takes them as deps so we can exercise the fanout
- * logic without network or filesystem.
- *
- * Coverage:
- *   1. Happy path — companies + personal both fan out.
- *   2. Conflict strategy is forwarded to every sync() call.
- *   3. Per-company errors don't abort the rest of the fanout.
- *   4. No person entity → companies-only plan, no personal target.
- *   5. Empty memberships AND no person entity → no sync calls, clean result.
- *   6. Multiple person entities → canonical pick (oldest createdAt, uid tiebreak).
- *   7. hqRoot is forwarded verbatim to every sync() call.
- *   8. US-011 — narrow-hint banner emits per all-mode membership.
- *   9. US-011 — strict-mode refuses all-mode legs without --mode-all.
- *   10. US-011 — strict-mode + --mode-all proceeds.
- */
-
-import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
-
-import {
-  pullAll,
-  type PullAllDeps,
-  type PullAllVaultClient,
-  type SyncCallOptions,
-  type SyncCallResult,
-} from "./cloud.js";
-import { _resetShownForTests } from "../lib/narrow-hint-banner.js";
-
-// ── Helpers ─────────────────────────────────────────────────────────────────
-
-interface FakeMembership {
-  companyUid: string;
-}
-
-interface FakeEntity {
-  uid: string;
-  type: "person" | "company";
-  slug: string;
-  bucketName?: string;
-  createdAt: string;
-}
-
-function makeVaultClient(opts: {
-  memberships?: FakeMembership[];
-  persons?: FakeEntity[];
-  entitiesBySlug?: Record<string, { slug: string; name?: string }>;
-  failGetEntityFor?: Set<string>;
-}): PullAllVaultClient {
-  return {
-    listMyMemberships: vi
-      .fn<[], Promise<FakeMembership[]>>()
-      .mockResolvedValue(opts.memberships ?? []),
-    listPersonEntities: vi
-      .fn<[], Promise<FakeEntity[]>>()
-      .mockResolvedValue(opts.persons ?? []),
-    getEntity: vi
-      .fn<[string], Promise<{ slug?: string; name?: string } | null>>()
-      .mockImplementation(async (uid: string) => {
-        if (opts.failGetEntityFor?.has(uid)) {
-          throw new Error(`fake getEntity failure for ${uid}`);
-        }
-        return opts.entitiesBySlug?.[uid] ?? null;
-      }),
-  };
-}
-
-function makeSyncSpy(
-  perCallOverrides: Record<string, Partial<SyncCallResult> | Error> = {},
-): {
-  fn: PullAllDeps["sync"];
-  calls: SyncCallOptions[];
-} {
-  const calls: SyncCallOptions[] = [];
-  const fn: PullAllDeps["sync"] = vi
-    .fn<[SyncCallOptions], Promise<SyncCallResult>>()
-    .mockImplementation(async (options: SyncCallOptions) => {
-      calls.push(options);
-      const override = perCallOverrides[options.company];
-      if (override instanceof Error) {
-        throw override;
-      }
-      return {
-        filesDownloaded: 0,
-        bytesDownloaded: 0,
-        filesSkipped: 0,
-        conflicts: 0,
-        conflictPaths: [],
-        aborted: false,
-        ...override,
-      };
-    });
-  return { fn, calls };
-}
-
-// ── 1. Happy path ───────────────────────────────────────────────────────────
-
-describe("pullAll", () => {
-  it("syncs every membership plus the canonical person entity", async () => {
-    const vaultClient = makeVaultClient({
-      memberships: [
-        { companyUid: "cmp_acme" },
-        { companyUid: "cmp_globex" },
-      ],
-      persons: [
-        {
-          uid: "psn_alice",
-          type: "person",
-          slug: "alice",
-          bucketName: "hq-vault-psn-alice",
-          createdAt: "2026-01-01T00:00:00Z",
-        },
-      ],
-      entitiesBySlug: {
-        cmp_acme: { slug: "acme", name: "Acme" },
-        cmp_globex: { slug: "globex", name: "Globex" },
-      },
-    });
-    const sync = makeSyncSpy({
-      cmp_acme: { filesDownloaded: 3, bytesDownloaded: 300 },
-      cmp_globex: { filesDownloaded: 1, bytesDownloaded: 50 },
-      psn_alice: { filesDownloaded: 7, bytesDownloaded: 700 },
-    });
-
-    const result = await pullAll(
-      { hqRoot: "/tmp/hq", onConflict: "abort" },
-      { vaultClient, sync: sync.fn },
-    );
-
-    expect(sync.calls).toHaveLength(3);
-    expect(sync.calls[0]).toMatchObject({
-      company: "cmp_acme",
-      hqRoot: "/tmp/hq",
-      onConflict: "abort",
-    });
-    expect(sync.calls[1]).toMatchObject({ company: "cmp_globex" });
-    expect(sync.calls[2]).toMatchObject({
-      company: "psn_alice",
-      personalMode: true,
-      journalSlug: "__hq_personal_vault__",
-    });
-
-    expect(result.attempted).toBe(3);
-    expect(result.filesDownloaded).toBe(11);
-    expect(result.bytesDownloaded).toBe(1050);
-    expect(result.errors).toEqual([]);
-    expect(result.perCompany.map((row) => row.slug)).toEqual([
-      "acme",
-      "globex",
-      "personal",
-    ]);
-  });
-
-  // ── 1b. DEV-1768: real scope is threaded into the actual pull ─────────────
-
-  it("threads the resolved syncMode + prefixSet into sync() (no all-mode seed)", async () => {
-    const vaultClient = makeVaultClient({
-      memberships: [{ companyUid: "cmp_a" }],
-      entitiesBySlug: { cmp_a: { slug: "acme" } },
-    });
-    const sync = makeSyncSpy();
-    const resolveScope = vi.fn(async (_uid: string, _slug: string) => ({
-      syncMode: "shared" as const,
-      prefixSet: ["knowledge/", "policies/"],
-    }));
-
-    await pullAll(
-      { hqRoot: "/tmp/hq" },
-      { vaultClient, sync: sync.fn, resolveScope },
-    );
-
-    // Resolver invoked with the company's UID + resolved slug.
-    expect(resolveScope).toHaveBeenCalledWith("cmp_a", "acme");
-    // ...and the result is forwarded to the ACTUAL pull, not just the banner.
-    const companyCall = sync.calls.find((c) => c.company === "cmp_a");
-    expect(companyCall?.syncMode).toBe("shared");
-    expect(companyCall?.prefixSet).toEqual(["knowledge/", "policies/"]);
-  });
-
-  // ── 1c. Sessions-exclusion: excludePrefixes is threaded into sync() ───────
-  //
-  // Guards the "session transcripts never sync DOWN" invariant on the CLI path:
-  // a company OWNER's STS scope is wide enough to read `sessions/` keys, so if
-  // the 4-site scope→sync-options mapping dropped `excludePrefixes` the CLI
-  // would bulk-download everyone's full-content session transcripts to local
-  // disk. This asserts the resolver's excludePrefixes reaches the SyncCallOptions
-  // handed to sync(); it FAILS if any mapping site drops the field.
-  it("threads the resolved excludePrefixes into sync() (sessions never pull DOWN)", async () => {
-    const vaultClient = makeVaultClient({
-      memberships: [{ companyUid: "cmp_a" }],
-      entitiesBySlug: { cmp_a: { slug: "acme" } },
-    });
-    const sync = makeSyncSpy();
-    // hq-cloud derives excludePrefixes on the resolved scope.
-    const resolveScope = vi.fn(async (_uid: string, _slug: string) => ({
-      syncMode: "shared" as const,
-      prefixSet: ["knowledge/", "policies/"],
-      excludePrefixes: ["sessions/"],
-    }));
-
-    await pullAll(
-      { hqRoot: "/tmp/hq" },
-      { vaultClient, sync: sync.fn, resolveScope },
-    );
-
-    const companyCall = sync.calls.find((c) => c.company === "cmp_a");
-    expect(companyCall?.excludePrefixes).toEqual(["sessions/"]);
-    // Sibling scope fields still flow — excludePrefixes rides alongside them.
-    expect(companyCall?.syncMode).toBe("shared");
-    expect(companyCall?.prefixSet).toEqual(["knowledge/", "policies/"]);
-  });
-
-  it("omits excludePrefixes when the resolved scope carries none", async () => {
-    const vaultClient = makeVaultClient({
-      memberships: [{ companyUid: "cmp_a" }],
-      entitiesBySlug: { cmp_a: { slug: "acme" } },
-    });
-    const sync = makeSyncSpy();
-    const resolveScope = vi.fn(async () => ({
-      syncMode: "shared" as const,
-      prefixSet: ["knowledge/"],
-    }));
-
-    await pullAll(
-      { hqRoot: "/tmp/hq" },
-      { vaultClient, sync: sync.fn, resolveScope },
-    );
-
-    const companyCall = sync.calls.find((c) => c.company === "cmp_a");
-    expect(companyCall?.excludePrefixes).toBeUndefined();
-  });
-
-  it("passes no prefixSet for an all-mode membership (full pull preserved)", async () => {
-    const vaultClient = makeVaultClient({
-      memberships: [{ companyUid: "cmp_a" }],
-      entitiesBySlug: { cmp_a: { slug: "acme" } },
-    });
-    const sync = makeSyncSpy();
-    const resolveScope = vi.fn(async () => ({ syncMode: "all" as const }));
-
-    await pullAll(
-      { hqRoot: "/tmp/hq" },
-      { vaultClient, sync: sync.fn, resolveScope },
-    );
-
-    const companyCall = sync.calls.find((c) => c.company === "cmp_a");
-    expect(companyCall?.syncMode).toBe("all");
-    expect(companyCall?.prefixSet).toBeUndefined();
-  });
-
-  it("forwards forceScopeShrink to company legs when set", async () => {
-    const vaultClient = makeVaultClient({
-      memberships: [{ companyUid: "cmp_a" }],
-      entitiesBySlug: { cmp_a: { slug: "acme" } },
-    });
-    const sync = makeSyncSpy();
-    const resolveScope = vi.fn(async () => ({
-      syncMode: "shared" as const,
-      prefixSet: ["knowledge/"],
-    }));
-
-    await pullAll(
-      { hqRoot: "/tmp/hq", forceScopeShrink: true },
-      { vaultClient, sync: sync.fn, resolveScope },
-    );
-
-    const companyCall = sync.calls.find((c) => c.company === "cmp_a");
-    expect(companyCall?.forceScopeShrink).toBe(true);
-  });
-
-  // ── 2. Conflict strategy passthrough ──────────────────────────────────────
-
-  it("forwards --on-conflict to every sync() call", async () => {
-    const vaultClient = makeVaultClient({
-      memberships: [{ companyUid: "cmp_acme" }],
-      persons: [
-        {
-          uid: "psn_alice",
-          type: "person",
-          slug: "alice",
-          createdAt: "2026-01-01T00:00:00Z",
-        },
-      ],
-    });
-    const sync = makeSyncSpy();
-
-    await pullAll(
-      { hqRoot: "/tmp/hq", onConflict: "overwrite" },
-      { vaultClient, sync: sync.fn },
-    );
-
-    for (const call of sync.calls) {
-      expect(call.onConflict).toBe("overwrite");
-    }
-  });
-
-  // ── 3. Per-company error isolation ────────────────────────────────────────
-
-  it("continues past a per-company sync failure and reports it in errors[]", async () => {
-    const vaultClient = makeVaultClient({
-      memberships: [
-        { companyUid: "cmp_acme" },
-        { companyUid: "cmp_globex" },
-      ],
-      persons: [
-        {
-          uid: "psn_alice",
-          type: "person",
-          slug: "alice",
-          createdAt: "2026-01-01T00:00:00Z",
-        },
-      ],
-      entitiesBySlug: {
-        cmp_acme: { slug: "acme" },
-        cmp_globex: { slug: "globex" },
-      },
-    });
-    const sync = makeSyncSpy({
-      cmp_globex: new Error("STS denied"),
-    });
-
-    const result = await pullAll(
-      { hqRoot: "/tmp/hq" },
-      { vaultClient, sync: sync.fn },
-    );
-
-    expect(sync.calls.map((c) => c.company)).toEqual([
-      "cmp_acme",
-      "cmp_globex",
-      "psn_alice",
-    ]);
-    expect(result.attempted).toBe(3);
-    expect(result.errors).toEqual([
-      { company: "globex", message: "STS denied" },
-    ]);
-    const globexRow = result.perCompany.find((r) => r.slug === "globex");
-    expect(globexRow?.error).toBe("STS denied");
-    expect(globexRow?.result).toBeUndefined();
-  });
-
-  // ── 4. No person entity ────────────────────────────────────────────────────
-
-  it("omits the personal target when listPersonEntities returns []", async () => {
-    const vaultClient = makeVaultClient({
-      memberships: [{ companyUid: "cmp_acme" }],
-      persons: [],
-      entitiesBySlug: { cmp_acme: { slug: "acme" } },
-    });
-    const sync = makeSyncSpy();
-
-    const result = await pullAll(
-      { hqRoot: "/tmp/hq" },
-      { vaultClient, sync: sync.fn },
-    );
-
-    expect(sync.calls).toHaveLength(1);
-    expect(sync.calls[0].company).toBe("cmp_acme");
-    expect(sync.calls[0].personalMode).toBeUndefined();
-    expect(result.perCompany.map((r) => r.slug)).toEqual(["acme"]);
-  });
-
-  // ── 5. No memberships and no person entity ────────────────────────────────
-
-  it("returns cleanly with zero attempts when there is nothing to sync", async () => {
-    const vaultClient = makeVaultClient({});
-    const sync = makeSyncSpy();
-
-    const result = await pullAll(
-      { hqRoot: "/tmp/hq" },
-      { vaultClient, sync: sync.fn },
-    );
-
-    expect(sync.calls).toEqual([]);
-    expect(result).toEqual({
-      attempted: 0,
-      filesDownloaded: 0,
-      bytesDownloaded: 0,
-      conflicts: 0,
-      errors: [],
-      perCompany: [],
-    });
-  });
-
-  // ── 6. Canonical-person tiebreak ──────────────────────────────────────────
-
-  it("picks the oldest person entity, breaking ties by uid", async () => {
-    const vaultClient = makeVaultClient({
-      memberships: [],
-      persons: [
-        {
-          uid: "psn_zzz",
-          type: "person",
-          slug: "alice-zzz",
-          createdAt: "2026-01-01T00:00:00Z",
-        },
-        {
-          uid: "psn_aaa",
-          type: "person",
-          slug: "alice-aaa",
-          createdAt: "2026-01-01T00:00:00Z",
-        },
-        {
-          uid: "psn_old",
-          type: "person",
-          slug: "alice-old",
-          createdAt: "2025-06-01T00:00:00Z",
-        },
-      ],
-    });
-    const sync = makeSyncSpy();
-
-    await pullAll({ hqRoot: "/tmp/hq" }, { vaultClient, sync: sync.fn });
-
-    expect(sync.calls).toHaveLength(1);
-    expect(sync.calls[0].company).toBe("psn_old");
-    expect(sync.calls[0].personalMode).toBe(true);
-    expect(sync.calls[0].journalSlug).toBe("__hq_personal_vault__");
-  });
-
-  // ── 8/9/10. US-011 narrow-hint banner ─────────────────────────────────────
-
-  describe("narrow-hint banner (US-011)", () => {
-    let stderrSpy: ReturnType<typeof vi.spyOn>;
-    let captured: string[];
-
-    beforeEach(() => {
-      _resetShownForTests();
-      captured = [];
-      stderrSpy = vi
-        .spyOn(process.stderr, "write")
-        .mockImplementation((chunk: string | Uint8Array) => {
-          captured.push(typeof chunk === "string" ? chunk : chunk.toString());
-          return true;
-        });
-    });
-
-    afterEach(() => {
-      stderrSpy.mockRestore();
-      delete process.env.HQ_SYNC_NARROW_HINT;
-      delete process.env.HQ_SYNC_NARROW_HINT_LEVEL;
-    });
-
-    function makeVaultClientWithSyncConfig(opts: {
-      memberships: Array<{ companyUid: string; membershipKey: string }>;
-      syncModes: Record<string, "shared" | "all" | "custom">;
-      entitiesBySlug?: Record<string, { slug: string; name?: string }>;
-    }): PullAllVaultClient {
-      return {
-        listMyMemberships: vi.fn().mockResolvedValue(opts.memberships),
-        listPersonEntities: vi.fn().mockResolvedValue([]),
-        getEntity: vi
-          .fn()
-          .mockImplementation(async (uid: string) =>
-            opts.entitiesBySlug?.[uid] ?? null,
-          ),
-        getMembershipSyncConfig: vi
-          .fn()
-          .mockImplementation(async (membershipKey: string) => {
-            const m = opts.memberships.find(
-              (m) => m.membershipKey === membershipKey,
-            );
-            const companyUid = m?.companyUid ?? "";
-            return {
-              membershipId: membershipKey,
-              syncMode: opts.syncModes[companyUid] ?? "all",
-            };
-          }),
-      };
-    }
-
-    it("emits one hint per all-mode membership and skips shared/custom", async () => {
-      const vaultClient = makeVaultClientWithSyncConfig({
-        memberships: [
-          { companyUid: "cmp_acme", membershipKey: "psn_1#cmp_acme" },
-          { companyUid: "cmp_globex", membershipKey: "psn_1#cmp_globex" },
-          { companyUid: "cmp_init", membershipKey: "psn_1#cmp_init" },
-        ],
-        syncModes: {
-          cmp_acme: "all",
-          cmp_globex: "shared",
-          cmp_init: "custom",
-        },
-        entitiesBySlug: {
-          cmp_acme: { slug: "acme" },
-          cmp_globex: { slug: "globex" },
-          cmp_init: { slug: "init" },
-        },
-      });
-      const sync = makeSyncSpy();
-
-      const result = await pullAll(
-        { hqRoot: "/tmp/hq", narrowHintLevel: "hint" },
-        { vaultClient, sync: sync.fn },
-      );
-
-      expect(result.errors).toEqual([]);
-      expect(result.attempted).toBe(3);
-      // sync ran for all three (no strict refusal at 'hint' level)
-      expect(sync.calls).toHaveLength(3);
-
-      const joined = captured.join("");
-      expect(joined).toMatch(/switch to shared-mode sync/i);
-      // exactly one banner line — only cmp_acme is on 'all'
-      const bannerLines = captured.filter((c) => /shared-mode sync/i.test(c));
-      expect(bannerLines).toHaveLength(1);
-    });
-
-    it("strict-mode refuses all-mode legs and short-circuits sync()", async () => {
-      const vaultClient = makeVaultClientWithSyncConfig({
-        memberships: [
-          { companyUid: "cmp_acme", membershipKey: "psn_1#cmp_acme" },
-          { companyUid: "cmp_globex", membershipKey: "psn_1#cmp_globex" },
-        ],
-        syncModes: {
-          cmp_acme: "all",
-          cmp_globex: "shared",
-        },
-        entitiesBySlug: {
-          cmp_acme: { slug: "acme" },
-          cmp_globex: { slug: "globex" },
-        },
-      });
-      const sync = makeSyncSpy();
-
-      const result = await pullAll(
-        { hqRoot: "/tmp/hq", narrowHintLevel: "strict" },
-        { vaultClient, sync: sync.fn },
-      );
-
-      // acme refused (no sync() call), globex still synced
-      expect(sync.calls.map((c) => c.company)).toEqual(["cmp_globex"]);
-      expect(result.errors).toEqual([
-        {
-          company: "acme",
-          message: expect.stringContaining("Refusing to pull all-mode"),
-        },
-      ]);
-    });
-
-    it("strict-mode + modeAllOverride lets all-mode legs proceed", async () => {
-      const vaultClient = makeVaultClientWithSyncConfig({
-        memberships: [
-          { companyUid: "cmp_acme", membershipKey: "psn_1#cmp_acme" },
-        ],
-        syncModes: { cmp_acme: "all" },
-        entitiesBySlug: { cmp_acme: { slug: "acme" } },
-      });
-      const sync = makeSyncSpy();
-
-      const result = await pullAll(
-        {
-          hqRoot: "/tmp/hq",
-          narrowHintLevel: "strict",
-          modeAllOverride: true,
-        },
-        { vaultClient, sync: sync.fn },
-      );
-
-      expect(sync.calls).toHaveLength(1);
-      expect(result.errors).toEqual([]);
-    });
-
-    it("HQ_SYNC_NARROW_HINT=off suppresses the banner", async () => {
-      process.env.HQ_SYNC_NARROW_HINT = "off";
-      const vaultClient = makeVaultClientWithSyncConfig({
-        memberships: [
-          { companyUid: "cmp_acme", membershipKey: "psn_1#cmp_acme" },
-        ],
-        syncModes: { cmp_acme: "all" },
-        entitiesBySlug: { cmp_acme: { slug: "acme" } },
-      });
-      const sync = makeSyncSpy();
-
-      await pullAll(
-        { hqRoot: "/tmp/hq", narrowHintLevel: "hint" },
-        { vaultClient, sync: sync.fn },
-      );
-
-      const joined = captured.join("");
-      expect(joined).not.toMatch(/switch to shared-mode sync/i);
-      expect(sync.calls).toHaveLength(1);
-    });
-  });
-
-  // ── 7. hqRoot passthrough ─────────────────────────────────────────────────
-
-  it("forwards hqRoot verbatim to every sync() call", async () => {
-    const vaultClient = makeVaultClient({
-      memberships: [{ companyUid: "cmp_acme" }],
-      persons: [
-        {
-          uid: "psn_alice",
-          type: "person",
-          slug: "alice",
-          createdAt: "2026-01-01T00:00:00Z",
-        },
-      ],
-    });
-    const sync = makeSyncSpy();
-
-    await pullAll(
-      { hqRoot: "/Users/me/scratch/hq" },
-      { vaultClient, sync: sync.fn },
-    );
-
-    for (const call of sync.calls) {
-      expect(call.hqRoot).toBe("/Users/me/scratch/hq");
-    }
-  });
-
-  // ── 11. skipPersonal — fanout omits the canonical-person leg ──────────────
-  //
-  // Mirrors the upstream `hq-sync-runner --skip-personal` flag (hq-cloud
-  // 5.25.0) plumbed through to the CLI as `hq sync pull --all --no-personal`.
-  // When the option is true, `pullAll` must (a) skip the canonical-person
-  // bucket even when one exists, and (b) leave companies untouched.
-
-  it("skipPersonal=true omits the personal leg even when a person entity exists", async () => {
-    const vaultClient = makeVaultClient({
-      memberships: [
-        { companyUid: "cmp_acme" },
-        { companyUid: "cmp_globex" },
-      ],
-      persons: [
-        {
-          uid: "psn_alice",
-          type: "person",
-          slug: "alice",
-          bucketName: "hq-vault-psn-alice",
-          createdAt: "2026-01-01T00:00:00Z",
-        },
-      ],
-      entitiesBySlug: {
-        cmp_acme: { slug: "acme" },
-        cmp_globex: { slug: "globex" },
-      },
-    });
-    const sync = makeSyncSpy();
-
-    const result = await pullAll(
-      { hqRoot: "/tmp/hq", skipPersonal: true },
-      { vaultClient, sync: sync.fn },
-    );
-
-    expect(sync.calls.map((c) => c.company)).toEqual([
-      "cmp_acme",
-      "cmp_globex",
-    ]);
-    for (const call of sync.calls) {
-      expect(call.personalMode).toBeUndefined();
-      expect(call.journalSlug).toBeUndefined();
-    }
-    expect(result.attempted).toBe(2);
-    expect(result.perCompany.map((r) => r.slug)).toEqual(["acme", "globex"]);
-  });
-
-  it("skipPersonal omitted/false keeps the personal leg in the fanout (baseline)", async () => {
-    const vaultClient = makeVaultClient({
-      memberships: [{ companyUid: "cmp_acme" }],
-      persons: [
-        {
-          uid: "psn_alice",
-          type: "person",
-          slug: "alice",
-          createdAt: "2026-01-01T00:00:00Z",
-        },
-      ],
-      entitiesBySlug: { cmp_acme: { slug: "acme" } },
-    });
-    const sync = makeSyncSpy();
-
-    await pullAll(
-      { hqRoot: "/tmp/hq" },
-      { vaultClient, sync: sync.fn },
-    );
-
-    expect(sync.calls.map((c) => c.company)).toEqual([
-      "cmp_acme",
-      "psn_alice",
-    ]);
-    expect(sync.calls[1].personalMode).toBe(true);
-    expect(sync.calls[1].journalSlug).toBe("__hq_personal_vault__");
-  });
-
-  it("skipPersonal=true with empty memberships produces zero sync calls", async () => {
-    const vaultClient = makeVaultClient({
-      memberships: [],
-      persons: [
-        {
-          uid: "psn_alice",
-          type: "person",
-          slug: "alice",
-          createdAt: "2026-01-01T00:00:00Z",
-        },
-      ],
-    });
-    const sync = makeSyncSpy();
-
-    const result = await pullAll(
-      { hqRoot: "/tmp/hq", skipPersonal: true },
-      { vaultClient, sync: sync.fn },
-    );
-
-    expect(sync.calls).toEqual([]);
-    expect(result.attempted).toBe(0);
-    expect(result.perCompany).toEqual([]);
-  });
-});