@herb-tools/linter 0.8.9 → 0.9.0

package/src/rules/html-no-nested-links.ts

@@ -1,4 +1,5 @@
-import { BaseRuleVisitor, getTagName } from "./rule-utils.js"
+import { BaseRuleVisitor } from "./rule-utils.js"
+import { getTagLocalName } from "@herb-tools/core"
 import { ParserRule } from "../types.js"
 
 import type { UnboundLintOffense, LintContext, FullRuleConfig } from "../types.js"
@@ -21,30 +22,38 @@ class NestedLinkVisitor extends BaseRuleVisitor {
   }
 
   visitHTMLElementNode(node: HTMLElementNode): void {
-    if (!node.open_tag || node.open_tag.type !== "AST_HTML_OPEN_TAG_NODE") {
+    if (!node.open_tag) {
       super.visitHTMLElementNode(node)
       return
     }
 
-    const openTag = node.open_tag as HTMLOpenTagNode
-    const tagName = getTagName(openTag)
+    switch (node.open_tag.type) {
+      case "AST_HTML_OPEN_TAG_NODE": {
+        const openTag = node.open_tag
+        const tagName = getTagLocalName(openTag)
 
-    if (tagName !== "a") {
-      super.visitHTMLElementNode(node)
-      return
-    }
+        if (tagName !== "a") {
+          super.visitHTMLElementNode(node)
+          return
+        }
 
-    // If we're already inside a link, this is a nested link
-    this.checkNestedLink(openTag)
+        this.checkNestedLink(openTag)
 
-    this.linkStack.push(openTag)
-    super.visitHTMLElementNode(node)
-    this.linkStack.pop()
+        this.linkStack.push(openTag)
+        super.visitHTMLElementNode(node)
+        this.linkStack.pop()
+        break
+      }
+
+      case "AST_HTML_CONDITIONAL_OPEN_TAG_NODE":
+        super.visitHTMLElementNode(node)
+        break
+    }
   }
 
   // Handle self-closing <a> tags (though they're not valid HTML, they might exist)
   visitHTMLOpenTagNode(node: HTMLOpenTagNode): void {
-    const tagName = getTagName(node)
+    const tagName = getTagLocalName(node)
 
     if (tagName === "a" && node.is_void) {
       this.checkNestedLink(node)
@@ -55,7 +64,7 @@ class NestedLinkVisitor extends BaseRuleVisitor {
 }
 
 export class HTMLNoNestedLinksRule extends ParserRule {
-  name = "html-no-nested-links"
+  static ruleName = "html-no-nested-links"
 
   get defaultConfig(): FullRuleConfig {
     return {
@@ -65,7 +74,7 @@ export class HTMLNoNestedLinksRule extends ParserRule {
   }
 
   check(result: ParseResult, context?: Partial<LintContext>): UnboundLintOffense[] {
-    const visitor = new NestedLinkVisitor(this.name, context)
+    const visitor = new NestedLinkVisitor(this.ruleName, context)
     visitor.visit(result.value)
     return visitor.offenses
   }

package/src/rules/html-no-positive-tab-index.ts

@@ -20,17 +20,17 @@ class NoPositiveTabIndexVisitor extends AttributeVisitorMixin {
 }
 
 export class HTMLNoPositiveTabIndexRule extends ParserRule {
-  name = "html-no-positive-tab-index"
+  static ruleName = "html-no-positive-tab-index"
 
   get defaultConfig(): FullRuleConfig {
     return {
       enabled: true,
-      severity: "error"
+      severity: "warning"
     }
   }
 
   check(result: ParseResult, context?: Partial<LintContext>): UnboundLintOffense[] {
-    const visitor = new NoPositiveTabIndexVisitor(this.name, context)
+    const visitor = new NoPositiveTabIndexVisitor(this.ruleName, context)
 
     visitor.visit(result.value)
 

package/src/rules/html-no-self-closing.ts

@@ -1,6 +1,6 @@
 import { ParserRule, BaseAutofixContext, Mutable } from "../types.js"
 import { isVoidElement, findParent, BaseRuleVisitor } from "./rule-utils.js"
-import { getTagName, isWhitespaceNode, Location, HTMLCloseTagNode } from "@herb-tools/core"
+import { getTagName, getTagLocalName, isWhitespaceNode, Location, HTMLCloseTagNode } from "@herb-tools/core"
 
 import type { UnboundLintOffense, LintContext, LintOffense, FullRuleConfig } from "../types.js"
 import type { Node, HTMLOpenTagNode, HTMLElementNode, SerializedToken, ParseResult } from "@herb-tools/core"
@@ -13,7 +13,7 @@ interface NoSelfClosingAutofixContext extends BaseAutofixContext {
 
 class NoSelfClosingVisitor extends BaseRuleVisitor<NoSelfClosingAutofixContext> {
   visitHTMLElementNode(node: HTMLElementNode): void {
-    if (getTagName(node) === "svg") {
+    if (getTagLocalName(node) === "svg") {
       this.visit(node.open_tag)
     } else {
       this.visitChildNodes(node)
@@ -40,7 +40,7 @@ class NoSelfClosingVisitor extends BaseRuleVisitor<NoSelfClosingAutofixContext>
 
 export class HTMLNoSelfClosingRule extends ParserRule<NoSelfClosingAutofixContext> {
   static autocorrectable = true
-  name = "html-no-self-closing"
+  static ruleName = "html-no-self-closing"
 
   get defaultConfig(): FullRuleConfig {
     return {
@@ -51,7 +51,7 @@ export class HTMLNoSelfClosingRule extends ParserRule<NoSelfClosingAutofixContex
   }
 
   check(result: ParseResult, context?: Partial<LintContext>): UnboundLintOffense<NoSelfClosingAutofixContext>[] {
-    const visitor = new NoSelfClosingVisitor(this.name, context)
+    const visitor = new NoSelfClosingVisitor(this.ruleName, context)
 
     visitor.visit(result.value)
 
@@ -62,7 +62,7 @@ export class HTMLNoSelfClosingRule extends ParserRule<NoSelfClosingAutofixContex
     if (!offense.autofixContext) return null
 
     const { node, tagName, isVoid } = offense.autofixContext
-    const { tag_closing } = node
+    const { tag_closing } = node
 
     if (!tag_closing) return null
 

package/src/rules/html-no-space-in-tag.ts

@@ -1,4 +1,4 @@
-import { Token, Location, WhitespaceNode } from "@herb-tools/core"
+import { Token, WhitespaceNode, createWhitespaceNode } from "@herb-tools/core"
 import { ParserRule, BaseAutofixContext } from "../types.js"
 
 import { findParent, BaseRuleVisitor } from "./rule-utils.js"
@@ -15,7 +15,7 @@ const MESSAGES = {
 } as const
 
 interface HTMLNoSpaceInTagAutofixContext extends BaseAutofixContext {
-  node: WhitespaceNode | HTMLOpenTagNode
+  node: WhitespaceNode | HTMLOpenTagNode
   message: string
 }
 
@@ -144,7 +144,7 @@ class HTMLNoSpaceInTagVisitor extends BaseRuleVisitor<HTMLNoSpaceInTagAutofixCon
 export class HTMLNoSpaceInTagRule extends ParserRule<HTMLNoSpaceInTagAutofixContext> {
   // TODO: enable and fix autofix
   static autocorrectable = false
-  name = "html-no-space-in-tag"
+  static ruleName = "html-no-space-in-tag"
 
   get defaultConfig(): FullRuleConfig {
     return {
@@ -154,7 +154,7 @@ export class HTMLNoSpaceInTagRule extends ParserRule<HTMLNoSpaceInTagAutofixCont
   }
 
   check(result: ParseResult, context?: Partial<LintContext>): UnboundLintOffense<HTMLNoSpaceInTagAutofixContext>[] {
-    const visitor = new HTMLNoSpaceInTagVisitor(this.name, context)
+    const visitor = new HTMLNoSpaceInTagVisitor(this.ruleName, context)
 
     visitor.visit(result.value)
 
@@ -168,10 +168,7 @@ export class HTMLNoSpaceInTagRule extends ParserRule<HTMLNoSpaceInTagAutofixCont
     if (!node) return null
 
     if (isHTMLOpenTagNode(node)) {
-      const token = Token.from({ type: "TOKEN_WHITESPACE", value: " ", range: [0, 0], location: Location.zero })
-      const whitespace = new WhitespaceNode({ type: "AST_WHITESPACE_NODE", value: token, location: Location.zero, errors: [] })
-
-      node.children.push(whitespace)
+      node.children.push(createWhitespaceNode())
 
       return result
     }

package/src/rules/html-no-title-attribute.ts

@@ -1,5 +1,6 @@
 import { ParserRule } from "../types.js"
-import { BaseRuleVisitor, getTagName, hasAttribute } from "./rule-utils.js"
+import { BaseRuleVisitor } from "./rule-utils.js"
+import { hasAttribute, getTagLocalName } from "@herb-tools/core"
 
 import type { UnboundLintOffense, LintContext, FullRuleConfig } from "../types.js"
 import type { HTMLOpenTagNode, ParseResult } from "@herb-tools/core"
@@ -13,7 +14,7 @@ class NoTitleAttributeVisitor extends BaseRuleVisitor {
   }
 
   private checkTitleAttribute(node: HTMLOpenTagNode): void {
-    const tagName = getTagName(node)
+    const tagName = getTagLocalName(node)
 
     if (!tagName || this.ALLOWED_ELEMENTS_WITH_TITLE.has(tagName)) {
       return
@@ -29,17 +30,17 @@ class NoTitleAttributeVisitor extends BaseRuleVisitor {
 }
 
 export class HTMLNoTitleAttributeRule extends ParserRule {
-  name = "html-no-title-attribute"
+  static ruleName = "html-no-title-attribute"
 
   get defaultConfig(): FullRuleConfig {
     return {
       enabled: false,
-      severity: "error"
+      severity: "warning"
     }
   }
 
   check(result: ParseResult, context?: Partial<LintContext>): UnboundLintOffense[] {
-    const visitor = new NoTitleAttributeVisitor(this.name, context)
+    const visitor = new NoTitleAttributeVisitor(this.ruleName, context)
 
     visitor.visit(result.value)
 

package/src/rules/html-no-underscores-in-attribute-names.ts

@@ -47,7 +47,7 @@ class HTMLNoUnderscoresInAttributeNamesVisitor extends AttributeVisitorMixin {
 }
 
 export class HTMLNoUnderscoresInAttributeNamesRule extends ParserRule {
-  name = "html-no-underscores-in-attribute-names"
+  static ruleName = "html-no-underscores-in-attribute-names"
 
   get defaultConfig(): FullRuleConfig {
     return {
@@ -57,7 +57,7 @@ export class HTMLNoUnderscoresInAttributeNamesRule extends ParserRule {
   }
 
   check(result: ParseResult, context?: Partial<LintContext>): UnboundLintOffense[] {
-    const visitor = new HTMLNoUnderscoresInAttributeNamesVisitor(this.name, context)
+    const visitor = new HTMLNoUnderscoresInAttributeNamesVisitor(this.ruleName, context)
 
     visitor.visit(result.value)
 

package/src/rules/html-require-closing-tags.ts

@@ -0,0 +1,41 @@
+import { ParserRule } from "../types.js"
+import { BaseRuleVisitor } from "./rule-utils.js"
+
+import type { UnboundLintOffense, LintContext, FullRuleConfig } from "../types.js"
+import type { HTMLOmittedCloseTagNode, ParseResult, ParserOptions } from "@herb-tools/core"
+
+class RequireClosingTagsVisitor extends BaseRuleVisitor {
+  visitHTMLOmittedCloseTagNode(node: HTMLOmittedCloseTagNode): void {
+    const tagName = node.tag_name?.value
+    if (!tagName) return
+
+    this.addOffense(
+      `Missing explicit closing tag for \`<${tagName}>\`. Use \`</${tagName}>\` instead of relying on implicit tag closing.`,
+      node.location
+    )
+  }
+}
+
+export class HTMLRequireClosingTagsRule extends ParserRule {
+  static autocorrectable = false
+  static ruleName = "html-require-closing-tags"
+
+  get defaultConfig(): FullRuleConfig {
+    return {
+      enabled: true,
+      severity: "error",
+    }
+  }
+
+  get parserOptions(): Partial<ParserOptions> {
+    return { strict: false }
+  }
+
+  check(result: ParseResult, context?: Partial<LintContext>): UnboundLintOffense[] {
+    const visitor = new RequireClosingTagsVisitor(this.ruleName, context)
+
+    visitor.visit(result.value)
+
+    return visitor.offenses
+  }
+}

package/src/rules/html-tag-name-lowercase.ts

@@ -1,6 +1,6 @@
 import { ParserRule, BaseAutofixContext, Mutable } from "../types.js"
 import { BaseRuleVisitor, findParent } from "./rule-utils.js"
-import { isNode, getTagName, HTMLOpenTagNode, isHTMLElementNode } from "@herb-tools/core"
+import { isNode, getTagName, getTagLocalName, HTMLOpenTagNode, isHTMLElementNode, isHTMLCloseTagNode, getOpenTag } from "@herb-tools/core"
 
 import type { UnboundLintOffense, LintOffense, LintContext, FullRuleConfig } from "../types.js"
 import type { HTMLElementNode, HTMLCloseTagNode, ParseResult, XMLDeclarationNode, Node } from "@herb-tools/core"
@@ -26,9 +26,12 @@ class XMLDeclarationChecker extends BaseRuleVisitor {
 
 class TagNameLowercaseVisitor extends BaseRuleVisitor<TagNameAutofixContext> {
   visitHTMLElementNode(node: HTMLElementNode): void {
-    if (getTagName(node).toLowerCase() === "svg") {
-      this.checkTagName(node.open_tag)
-      this.checkTagName(node.close_tag)
+    if (getTagLocalName(node) === "svg") {
+      this.checkTagName(getOpenTag(node))
+
+      if (node.close_tag && isHTMLCloseTagNode(node.close_tag)) {
+        this.checkTagName(node.close_tag)
+      }
     } else {
       super.visitHTMLElementNode(node)
     }
@@ -70,7 +73,7 @@ class TagNameLowercaseVisitor extends BaseRuleVisitor<TagNameAutofixContext> {
 
 export class HTMLTagNameLowercaseRule extends ParserRule<TagNameAutofixContext> {
   static autocorrectable = true
-  name = "html-tag-name-lowercase"
+  static ruleName = "html-tag-name-lowercase"
 
   get defaultConfig(): FullRuleConfig {
     return {
@@ -81,7 +84,7 @@ export class HTMLTagNameLowercaseRule extends ParserRule<TagNameAutofixContext>
   }
 
   isEnabled(result: ParseResult, _context?: Partial<LintContext>): boolean {
-    const checker = new XMLDeclarationChecker(this.name)
+    const checker = new XMLDeclarationChecker(this.ruleName)
 
     checker.visit(result.value)
 
@@ -89,7 +92,7 @@ export class HTMLTagNameLowercaseRule extends ParserRule<TagNameAutofixContext>
   }
 
   check(result: ParseResult, context?: Partial<LintContext>): UnboundLintOffense<TagNameAutofixContext>[] {
-    const visitor = new TagNameLowercaseVisitor(this.name, context)
+    const visitor = new TagNameLowercaseVisitor(this.ruleName, context)
 
     visitor.visit(result.value)
 
@@ -115,8 +118,10 @@ export class HTMLTagNameLowercaseRule extends ParserRule<TagNameAutofixContext>
         closeTag.tag_name!.value = correctedTagName
         break
       case "AST_HTML_CLOSE_TAG_NODE":
-        const openTag = parentElement.open_tag as Mutable<HTMLOpenTagNode>
-        openTag.tag_name!.value = correctedTagName
+        const openTag = getOpenTag(parentElement) as Mutable<HTMLOpenTagNode> | null
+        if (openTag?.tag_name) {
+          openTag.tag_name.value = correctedTagName
+        }
         break
       default:
         break

package/src/rules/index.ts

@@ -5,15 +5,29 @@ export * from "./herb-disable-comment-base.js"
 
 export * from "./erb-comment-syntax.js"
 export * from "./erb-no-case-node-children.js"
+export * from "./erb-no-inline-case-conditions.js"
+export * from "./erb-no-conditional-open-tag.js"
+export * from "./erb-no-duplicate-branch-elements.js"
 export * from "./erb-no-empty-tags.js"
 export * from "./erb-no-extra-newline.js"
 export * from "./erb-no-extra-whitespace-inside-tags.js"
 export * from "./erb-no-output-control-flow.js"
+export * from "./erb-no-then-in-control-flow.js"
 export * from "./erb-no-silent-tag-in-attribute-name.js"
+export * from "./erb-no-trailing-whitespace.js"
 export * from "./erb-prefer-image-tag-helper.js"
 export * from "./erb-require-trailing-newline.js"
 export * from "./erb-require-whitespace-inside-tags.js"
+export * from "./erb-no-javascript-tag-helper.js"
+export * from "./erb-no-raw-output-in-attribute-value.js"
+export * from "./erb-no-statement-in-script.js"
+export * from "./erb-no-unsafe-js-attribute.js"
+export * from "./erb-no-unsafe-raw.js"
+export * from "./erb-no-unsafe-script-interpolation.js"
 export * from "./erb-right-trim.js"
+export * from "./erb-no-output-in-attribute-position.js"
+export * from "./erb-no-output-in-attribute-name.js"
+export * from "./erb-no-instance-variables-in-partials.js"
 export * from "./erb-strict-locals-comment-syntax.js"
 export * from "./erb-strict-locals-required.js"
 
@@ -24,6 +38,7 @@ export * from "./herb-disable-comment-missing-rules.js"
 export * from "./herb-disable-comment-malformed.js"
 export * from "./herb-disable-comment-unnecessary.js"
 
+export * from "./html-allowed-script-type.js"
 export * from "./html-anchor-require-href.js"
 export * from "./html-aria-label-is-well-formatted.js"
 export * from "./html-aria-level-must-be-valid.js"
@@ -34,12 +49,15 @@ export * from "./html-attribute-equals-spacing.js"
 export * from "./html-attribute-values-require-quotes.js"
 export * from "./html-avoid-both-disabled-and-aria-disabled.js"
 export * from "./html-body-only-elements.js"
+export * from "./html-details-has-summary.js"
 export * from "./html-boolean-attributes-no-value.js"
 export * from "./html-head-only-elements.js"
 export * from "./html-iframe-has-title.js"
 export * from "./html-img-require-alt.js"
 export * from "./html-input-require-autocomplete.js"
 export * from "./html-navigation-has-label.js"
+export * from "./html-no-abstract-roles.js"
+export * from "./html-no-aria-hidden-on-body.js"
 export * from "./html-no-aria-hidden-on-focusable.js"
 export * from "./html-no-block-inside-inline.js"
 export * from "./html-no-duplicate-attributes.js"
@@ -53,6 +71,7 @@ export * from "./html-no-self-closing.js"
 export * from "./html-no-space-in-tag.js"
 export * from "./html-no-title-attribute.js"
 export * from "./html-no-underscores-in-attribute-names.js"
+export * from "./html-require-closing-tags.js"
 export * from "./html-tag-name-lowercase.js"
 
 export * from "./svg-tag-name-capitalization.js"

package/src/rules/parser-no-errors.ts

@@ -4,7 +4,7 @@ import type { LintOffense, FullRuleConfig } from "../types.js"
 import type { ParseResult, HerbError } from "@herb-tools/core"
 
 export class ParserNoErrorsRule extends ParserRule {
-  name = "parser-no-errors"
+  static ruleName = "parser-no-errors"
 
   get defaultConfig(): FullRuleConfig {
     return {
@@ -24,8 +24,8 @@ export class ParserNoErrorsRule extends ParserRule {
       message: `${error.message} (\`${error.type}\`)`,
       location: error.location,
       severity: error.severity,
-      rule: this.name,
-      code: this.name,
+      rule: this.ruleName,
+      code: this.ruleName,
       source: "linter"
     }
   }