@herb-tools/linter 0.8.9 → 0.9.0

package/src/rules/html-anchor-require-href.ts

@@ -1,33 +1,89 @@
-import { BaseRuleVisitor, getTagName, hasAttribute } from "./rule-utils.js"
+import { BaseRuleVisitor } from "./rule-utils.js"
+import { getAttribute, getStaticAttributeValue, getTagLocalName, isERBOpenTagNode, isHTMLOpenTagNode, isRubyLiteralNode, filterHTMLAttributeNodes, findAttributeByName } from "@herb-tools/core"
 
 import { ParserRule } from "../types.js"
 import type { UnboundLintOffense, LintContext, FullRuleConfig } from "../types.js"
-import type { HTMLOpenTagNode, ParseResult } from "@herb-tools/core"
+import type { HTMLElementNode, HTMLAttributeNode, ParseResult, ParserOptions } from "@herb-tools/core"
 
-class AnchorRechireHrefVisitor extends BaseRuleVisitor {
-  visitHTMLOpenTagNode(node: HTMLOpenTagNode): void {
+class AnchorRequireHrefVisitor extends BaseRuleVisitor {
+  visitHTMLElementNode(node: HTMLElementNode): void {
     this.checkATag(node)
-    super.visitHTMLOpenTagNode(node)
+    super.visitHTMLElementNode(node)
   }
 
-  private checkATag(node: HTMLOpenTagNode): void {
-    const tagName = getTagName(node)
+  private checkATag(node: HTMLElementNode): void {
+    const tagName = getTagLocalName(node)
 
     if (tagName !== "a") {
       return
     }
 
-    if (!hasAttribute(node, "href")) {
+    const hrefAttribute = this.getHrefAttribute(node)
+
+    if (!hrefAttribute) {
       this.addOffense(
-        "Add an `href` attribute to `<a>` to ensure it is focusable and accessible.",
+        "Add an `href` attribute to `<a>` to ensure it is focusable and accessible. Links should navigate somewhere. If you need a clickable element without navigation, use a `<button>` instead.",
         node.tag_name!.location,
       )
+
+      return
+    }
+
+    const hrefValue = getStaticAttributeValue(hrefAttribute)
+
+    if (hrefValue === "#") {
+      this.addOffense(
+        'Avoid `href="#"` on `<a>`. `href="#"` does not navigate anywhere, scrolls the page to the top, and adds `#` to the URL. If you need a clickable element without navigation, use a `<button>` instead.',
+        hrefAttribute.location,
+      )
+
+      return
+    }
+
+    if (hrefValue !== null && hrefValue.startsWith("javascript:void")) {
+      this.addOffense(
+        'Avoid `javascript:void(0)` in `href` on `<a>`. Links should navigate somewhere. If you need a clickable element without navigation, use a `<button>` instead.',
+        hrefAttribute.location,
+      )
+
+      return
+    }
+
+    if (this.hasNilHrefValue(hrefAttribute)) {
+      this.addOffense(
+        "Avoid passing `nil` as the URL for `link_to`. Links should navigate somewhere. If you need a clickable element without navigation, use a `<button>` instead.",
+        hrefAttribute.location,
+      )
     }
   }
+
+  private hasNilHrefValue(hrefAttribute: HTMLAttributeNode): boolean {
+    const valueNode = hrefAttribute.value
+
+    if (!valueNode) return false
+
+    return valueNode.children.some(child =>
+      isRubyLiteralNode(child) && child.content === "url_for(nil)"
+    )
+  }
+
+  private getHrefAttribute(node: HTMLElementNode): HTMLAttributeNode | null {
+    const openTag = node.open_tag
+
+    if (isHTMLOpenTagNode(openTag)) {
+      return getAttribute(openTag, "href")
+    }
+
+    if (isERBOpenTagNode(openTag)) {
+      return findAttributeByName(filterHTMLAttributeNodes(openTag.children), "href")
+    }
+
+    return null
+  }
 }
 
 export class HTMLAnchorRequireHrefRule extends ParserRule {
-  name = "html-anchor-require-href"
+  static ruleName = "html-anchor-require-href"
 
   get defaultConfig(): FullRuleConfig {
     return {
@@ -36,8 +92,14 @@ export class HTMLAnchorRequireHrefRule extends ParserRule {
     }
   }
 
+  get parserOptions(): Partial<ParserOptions> {
+    return {
+      action_view_helpers: true,
+    }
+  }
+
   check(result: ParseResult, context?: Partial<LintContext>): UnboundLintOffense[] {
-    const visitor = new AnchorRechireHrefVisitor(this.name, context)
+    const visitor = new AnchorRequireHrefVisitor(this.ruleName, context)
 
     visitor.visit(result.value)
 

package/src/rules/html-aria-attribute-must-be-valid.ts

@@ -25,17 +25,17 @@ class AriaAttributeMustBeValid extends AttributeVisitorMixin {
 }
 
 export class HTMLAriaAttributeMustBeValid extends ParserRule {
-  name = "html-aria-attribute-must-be-valid"
+  static ruleName = "html-aria-attribute-must-be-valid"
 
   get defaultConfig(): FullRuleConfig {
     return {
       enabled: true,
-      severity: "error"
+      severity: "warning"
     }
   }
 
   check(result: ParseResult, context?: Partial<LintContext>): UnboundLintOffense[] {
-    const visitor = new AriaAttributeMustBeValid(this.name, context)
+    const visitor = new AriaAttributeMustBeValid(this.ruleName, context)
 
     visitor.visit(result.value)
 

package/src/rules/html-aria-label-is-well-formatted.ts

@@ -44,17 +44,17 @@ class AriaLabelIsWellFormattedVisitor extends AttributeVisitorMixin {
 }
 
 export class HTMLAriaLabelIsWellFormattedRule extends ParserRule {
-  name = "html-aria-label-is-well-formatted"
+  static ruleName = "html-aria-label-is-well-formatted"
 
   get defaultConfig(): FullRuleConfig {
     return {
       enabled: true,
-      severity: "error"
+      severity: "warning"
     }
   }
 
   check(result: ParseResult, context?: Partial<LintContext>): UnboundLintOffense[] {
-    const visitor = new AriaLabelIsWellFormattedVisitor(this.name, context)
+    const visitor = new AriaLabelIsWellFormattedVisitor(this.ruleName, context)
 
     visitor.visit(result.value)
 

package/src/rules/html-aria-level-must-be-valid.ts

@@ -63,17 +63,17 @@ class HTMLAriaLevelMustBeValidVisitor extends AttributeVisitorMixin {
 }
 
 export class HTMLAriaLevelMustBeValidRule extends ParserRule {
-  name = "html-aria-level-must-be-valid"
+  static ruleName = "html-aria-level-must-be-valid"
 
   get defaultConfig(): FullRuleConfig {
     return {
       enabled: true,
-      severity: "error"
+      severity: "warning"
     }
   }
 
   check(result: ParseResult, context?: Partial<LintContext>): UnboundLintOffense[] {
-    const visitor = new HTMLAriaLevelMustBeValidVisitor(this.name, context)
+    const visitor = new HTMLAriaLevelMustBeValidVisitor(this.ruleName, context)
 
     visitor.visit(result.value)
 

package/src/rules/html-aria-role-heading-requires-level.ts

@@ -1,5 +1,6 @@
 import { ParserRule } from "../types.js"
-import { AttributeVisitorMixin, getAttributeName, getAttributes, StaticAttributeStaticValueParams } from "./rule-utils.js"
+import { AttributeVisitorMixin, StaticAttributeStaticValueParams } from "./rule-utils.js"
+import { getAttributeName, getAttributes } from "@herb-tools/core"
 
 import type { UnboundLintOffense, LintContext, FullRuleConfig } from "../types.js"
 import type { ParseResult } from "@herb-tools/core"
@@ -20,17 +21,17 @@ class AriaRoleHeadingRequiresLevel extends AttributeVisitorMixin {
 }
 
 export class HTMLAriaRoleHeadingRequiresLevelRule extends ParserRule {
-  name = "html-aria-role-heading-requires-level"
+  static ruleName = "html-aria-role-heading-requires-level"
 
   get defaultConfig(): FullRuleConfig {
     return {
       enabled: true,
-      severity: "error"
+      severity: "warning"
     }
   }
 
   check(result: ParseResult, context?: Partial<LintContext>): UnboundLintOffense[] {
-    const visitor = new AriaRoleHeadingRequiresLevel(this.name, context)
+    const visitor = new AriaRoleHeadingRequiresLevel(this.ruleName, context)
 
     visitor.visit(result.value)
 

package/src/rules/html-aria-role-must-be-valid.ts

@@ -18,17 +18,17 @@ class AriaRoleMustBeValid extends AttributeVisitorMixin {
 }
 
 export class HTMLAriaRoleMustBeValidRule extends ParserRule {
-  name = "html-aria-role-must-be-valid"
+  static ruleName = "html-aria-role-must-be-valid"
 
   get defaultConfig(): FullRuleConfig {
     return {
       enabled: true,
-      severity: "error"
+      severity: "warning"
     }
   }
 
   check(result: ParseResult, context?: Partial<LintContext>): UnboundLintOffense[] {
-    const visitor = new AriaRoleMustBeValid(this.name, context)
+    const visitor = new AriaRoleMustBeValid(this.ruleName, context)
 
     visitor.visit(result.value)
 

package/src/rules/html-attribute-double-quotes.ts

@@ -1,6 +1,6 @@
 import { ParserRule, BaseAutofixContext, Mutable } from "../types.js"
-import { AttributeVisitorMixin, StaticAttributeStaticValueParams, StaticAttributeDynamicValueParams, getAttributeValueQuoteType, hasAttributeValue } from "./rule-utils.js"
-import { filterLiteralNodes } from "@herb-tools/core"
+import { AttributeVisitorMixin, StaticAttributeStaticValueParams, StaticAttributeDynamicValueParams } from "./rule-utils.js"
+import { filterLiteralNodes, getAttributeValueQuoteType, hasAttributeValue } from "@herb-tools/core"
 
 import type { UnboundLintOffense, LintOffense, LintContext, FullRuleConfig } from "../types.js"
 import type { ParseResult, HTMLAttributeNode } from "@herb-tools/core"
@@ -44,7 +44,7 @@ class AttributeDoubleQuotesVisitor extends AttributeVisitorMixin<AttributeDouble
 
 export class HTMLAttributeDoubleQuotesRule extends ParserRule<AttributeDoubleQuotesAutofixContext> {
   static autocorrectable = true
-  name = "html-attribute-double-quotes"
+  static ruleName = "html-attribute-double-quotes"
 
   get defaultConfig(): FullRuleConfig {
     return {
@@ -54,7 +54,7 @@ export class HTMLAttributeDoubleQuotesRule extends ParserRule<AttributeDoubleQuo
   }
 
   check(result: ParseResult, context?: Partial<LintContext>): UnboundLintOffense<AttributeDoubleQuotesAutofixContext>[] {
-    const visitor = new AttributeDoubleQuotesVisitor(this.name, context)
+    const visitor = new AttributeDoubleQuotesVisitor(this.ruleName, context)
 
     visitor.visit(result.value)
 

package/src/rules/html-attribute-equals-spacing.ts

@@ -34,7 +34,7 @@ class HTMLAttributeEqualsSpacingVisitor extends BaseRuleVisitor<AttributeEqualsS
 
 export class HTMLAttributeEqualsSpacingRule extends ParserRule<AttributeEqualsSpacingAutofixContext> {
   static autocorrectable = true
-  name = "html-attribute-equals-spacing"
+  static ruleName = "html-attribute-equals-spacing"
 
   get defaultConfig(): FullRuleConfig {
     return {
@@ -44,7 +44,7 @@ export class HTMLAttributeEqualsSpacingRule extends ParserRule<AttributeEqualsSp
   }
 
   check(result: ParseResult, context?: Partial<LintContext>): UnboundLintOffense<AttributeEqualsSpacingAutofixContext>[] {
-    const visitor = new HTMLAttributeEqualsSpacingVisitor(this.name, context)
+    const visitor = new HTMLAttributeEqualsSpacingVisitor(this.ruleName, context)
 
     visitor.visit(result.value)
 

package/src/rules/html-attribute-values-require-quotes.ts

@@ -52,7 +52,7 @@ class AttributeValuesRequireQuotesVisitor extends AttributeVisitorMixin<Attribut
 
 export class HTMLAttributeValuesRequireQuotesRule extends ParserRule<AttributeValuesRequireQuotesAutofixContext> {
   static autocorrectable = true
-  name = "html-attribute-values-require-quotes"
+  static ruleName = "html-attribute-values-require-quotes"
 
   get defaultConfig(): FullRuleConfig {
     return {
@@ -62,7 +62,7 @@ export class HTMLAttributeValuesRequireQuotesRule extends ParserRule<AttributeVa
   }
 
   check(result: ParseResult, context?: Partial<LintContext>): UnboundLintOffense<AttributeValuesRequireQuotesAutofixContext>[] {
-    const visitor = new AttributeValuesRequireQuotesVisitor(this.name, context)
+    const visitor = new AttributeValuesRequireQuotesVisitor(this.ruleName, context)
 
     visitor.visit(result.value)
 

package/src/rules/html-avoid-both-disabled-and-aria-disabled.ts

@@ -1,8 +1,9 @@
 import { ParserRule } from "../types.js"
-import { BaseRuleVisitor, getTagName, hasAttribute, getAttributes, findAttributeByName } from "./rule-utils.js"
+import { BaseRuleVisitor } from "./rule-utils.js"
+import { isHTMLAttributeValueNode, isERBContentNode, getAttributes, findAttributeByName, hasAttribute, getTagLocalName } from "@herb-tools/core"
 
 import type { UnboundLintOffense, LintContext, FullRuleConfig } from "../types.js"
-import type { HTMLOpenTagNode, HTMLAttributeValueNode, ParseResult, Node } from "@herb-tools/core"
+import type { HTMLOpenTagNode, ParseResult } from "@herb-tools/core"
 
 const ELEMENTS_WITH_NATIVE_DISABLED_ATTRIBUTE_SUPPORT = new Set([
   "button", "fieldset", "input", "optgroup", "option", "select", "textarea"
@@ -15,7 +16,7 @@ class AvoidBothDisabledAndAriaDisabledVisitor extends BaseRuleVisitor {
   }
 
   private checkElement(node: HTMLOpenTagNode): void {
-    const tagName = getTagName(node)
+    const tagName = getTagLocalName(node)
 
     if (!tagName || !ELEMENTS_WITH_NATIVE_DISABLED_ATTRIBUTE_SUPPORT.has(tagName)) {
       return
@@ -43,27 +44,25 @@ class AvoidBothDisabledAndAriaDisabledVisitor extends BaseRuleVisitor {
     if (!attribute) return false
 
     const valueNode = attribute.value
-    if (!valueNode || valueNode.type !== "AST_HTML_ATTRIBUTE_VALUE_NODE") return false
+    if (!isHTMLAttributeValueNode(valueNode)) return false
+    if (!valueNode.children) return false
 
-    const htmlValueNode = valueNode as HTMLAttributeValueNode
-    if (!htmlValueNode.children) return false
-
-    return htmlValueNode.children.some((child: Node) => child.type === "AST_ERB_CONTENT_NODE")
+    return valueNode.children.some(isERBContentNode)
   }
 }
 
 export class HTMLAvoidBothDisabledAndAriaDisabledRule extends ParserRule {
-  name = "html-avoid-both-disabled-and-aria-disabled"
+  static ruleName = "html-avoid-both-disabled-and-aria-disabled"
 
   get defaultConfig(): FullRuleConfig {
     return {
       enabled: true,
-      severity: "error"
+      severity: "warning"
     }
   }
 
   check(result: ParseResult, context?: Partial<LintContext>): UnboundLintOffense[] {
-    const visitor = new AvoidBothDisabledAndAriaDisabledVisitor(this.name, context)
+    const visitor = new AvoidBothDisabledAndAriaDisabledVisitor(this.ruleName, context)
 
     visitor.visit(result.value)
 

package/src/rules/html-body-only-elements.ts

@@ -1,5 +1,6 @@
 import { ParserRule } from "../types.js"
-import { BaseRuleVisitor, getTagName, isBodyOnlyTag } from "./rule-utils.js"
+import { BaseRuleVisitor, isBodyOnlyTag } from "./rule-utils.js"
+import { getTagLocalName } from "@herb-tools/core"
 
 import type { UnboundLintOffense, LintContext, FullRuleConfig } from "../types.js"
 import type { HTMLElementNode, ParseResult } from "@herb-tools/core"
@@ -8,7 +9,7 @@ class HTMLBodyOnlyElementsVisitor extends BaseRuleVisitor {
   private elementStack: string[] = []
 
   visitHTMLElementNode(node: HTMLElementNode): void {
-    const tagName = getTagName(node.open_tag)?.toLowerCase()
+    const tagName = getTagLocalName(node)
     if (!tagName) return
 
     this.checkBodyOnlyElement(node, tagName)
@@ -40,7 +41,7 @@ class HTMLBodyOnlyElementsVisitor extends BaseRuleVisitor {
 
 export class HTMLBodyOnlyElementsRule extends ParserRule {
   static autocorrectable = false
-  name = "html-body-only-elements"
+  static ruleName = "html-body-only-elements"
 
   get defaultConfig(): FullRuleConfig {
     return {
@@ -51,7 +52,7 @@ export class HTMLBodyOnlyElementsRule extends ParserRule {
   }
 
   check(result: ParseResult, context?: Partial<LintContext>): UnboundLintOffense[] {
-    const visitor = new HTMLBodyOnlyElementsVisitor(this.name, context)
+    const visitor = new HTMLBodyOnlyElementsVisitor(this.ruleName, context)
 
     visitor.visit(result.value)
 

package/src/rules/html-boolean-attributes-no-value.ts

@@ -1,5 +1,6 @@
 import { ParserRule, BaseAutofixContext, Mutable } from "../types.js"
-import { AttributeVisitorMixin, StaticAttributeStaticValueParams, StaticAttributeDynamicValueParams, isBooleanAttribute, hasAttributeValue } from "./rule-utils.js"
+import { AttributeVisitorMixin, StaticAttributeStaticValueParams, StaticAttributeDynamicValueParams, isBooleanAttribute } from "./rule-utils.js"
+import { hasAttributeValue } from "@herb-tools/core"
 import { IdentityPrinter } from "@herb-tools/printer"
 
 import type { UnboundLintOffense, LintOffense, LintContext, FullRuleConfig } from "../types.js"
@@ -34,7 +35,7 @@ class BooleanAttributesNoValueVisitor extends AttributeVisitorMixin<BooleanAttri
 
 export class HTMLBooleanAttributesNoValueRule extends ParserRule<BooleanAttributeAutofixContext> {
   static autocorrectable = true
-  name = "html-boolean-attributes-no-value"
+  static ruleName = "html-boolean-attributes-no-value"
 
   get defaultConfig(): FullRuleConfig {
     return {
@@ -44,7 +45,7 @@ export class HTMLBooleanAttributesNoValueRule extends ParserRule<BooleanAttribut
   }
 
   check(result: ParseResult, context?: Partial<LintContext>): UnboundLintOffense<BooleanAttributeAutofixContext>[] {
-    const visitor = new BooleanAttributesNoValueVisitor(this.name, context)
+    const visitor = new BooleanAttributesNoValueVisitor(this.ruleName, context)
 
     visitor.visit(result.value)
 

package/src/rules/html-details-has-summary.ts

@@ -0,0 +1,69 @@
+import { BaseRuleVisitor } from "./rule-utils.js"
+import { getTagLocalName, isHTMLElementNode } from "@herb-tools/core"
+
+import { ParserRule } from "../types.js"
+import type { UnboundLintOffense, LintContext, FullRuleConfig } from "../types.js"
+import type { HTMLElementNode, ParseResult, ParserOptions } from "@herb-tools/core"
+
+class DetailsHasSummaryVisitor extends BaseRuleVisitor {
+  visitHTMLElementNode(node: HTMLElementNode): void {
+    this.checkDetailsElement(node)
+    super.visitHTMLElementNode(node)
+  }
+
+  private checkDetailsElement(node: HTMLElementNode): void {
+    const tagName = getTagLocalName(node)
+
+    if (tagName !== "details") {
+      return
+    }
+
+    if (!this.hasDirectSummaryChild(node)) {
+      this.addOffense(
+        "`<details>` element must have a direct `<summary>` child element.",
+        node.location,
+      )
+    }
+  }
+
+  private hasDirectSummaryChild(node: HTMLElementNode): boolean {
+    if (!node.body || node.body.length === 0) {
+      return false
+    }
+
+    for (const child of node.body) {
+      if (isHTMLElementNode(child)) {
+        const childTagName = getTagLocalName(child)
+
+        if (childTagName === "summary") {
+          return true
+        }
+      }
+    }
+
+    return false
+  }
+}
+
+export class HTMLDetailsHasSummaryRule extends ParserRule {
+  static ruleName = "html-details-has-summary"
+
+  get defaultConfig(): FullRuleConfig {
+    return {
+      enabled: true,
+      severity: "warning"
+    }
+  }
+
+  get parserOptions(): Partial<ParserOptions> {
+    return {
+      action_view_helpers: true,
+    }
+  }
+
+  check(result: ParseResult, context?: Partial<LintContext>): UnboundLintOffense[] {
+    const visitor = new DetailsHasSummaryVisitor(this.ruleName, context)
+    visitor.visit(result.value)
+    return visitor.offenses
+  }
+}

package/src/rules/html-head-only-elements.ts

@@ -1,5 +1,6 @@
 import { ParserRule } from "../types"
-import { BaseRuleVisitor, getTagName, isHeadOnlyTag, hasAttribute } from "./rule-utils"
+import { BaseRuleVisitor, isHeadOnlyTag } from "./rule-utils"
+import { hasAttribute, getTagLocalName } from "@herb-tools/core"
 
 import type { ParseResult, HTMLElementNode } from "@herb-tools/core"
 import type { UnboundLintOffense, LintContext, FullRuleConfig } from "../types"
@@ -8,7 +9,7 @@ class HeadOnlyElementsVisitor extends BaseRuleVisitor {
   private elementStack: string[] = []
 
   visitHTMLElementNode(node: HTMLElementNode): void {
-    const tagName = getTagName(node)?.toLowerCase()
+    const tagName = getTagLocalName(node)
     if (!tagName) return
 
     this.checkHeadOnlyElement(node, tagName)
@@ -33,7 +34,7 @@ class HeadOnlyElementsVisitor extends BaseRuleVisitor {
   }
 
   private hasItempropAttribute(node: HTMLElementNode): boolean {
-    return hasAttribute(node.open_tag, "itemprop")
+    return hasAttribute(node, "itemprop")
   }
 
   private get insideHead(): boolean {
@@ -51,7 +52,7 @@ class HeadOnlyElementsVisitor extends BaseRuleVisitor {
 
 export class HTMLHeadOnlyElementsRule extends ParserRule {
   static autocorrectable = false
-  name = "html-head-only-elements"
+  static ruleName = "html-head-only-elements"
 
   get defaultConfig(): FullRuleConfig {
     return {
@@ -62,7 +63,7 @@ export class HTMLHeadOnlyElementsRule extends ParserRule {
   }
 
   check(result: ParseResult, context?: Partial<LintContext>): UnboundLintOffense[] {
-    const visitor = new HeadOnlyElementsVisitor(this.name, context)
+    const visitor = new HeadOnlyElementsVisitor(this.ruleName, context)
 
     visitor.visit(result.value)
 

package/src/rules/html-iframe-has-title.ts

@@ -1,5 +1,6 @@
 import { ParserRule } from "../types.js"
-import { BaseRuleVisitor, getTagName, getAttribute, getAttributeValue } from "./rule-utils.js"
+import { BaseRuleVisitor } from "./rule-utils.js"
+import { getStaticAttributeValue, getAttribute, getAttributeValue, getTagLocalName } from "@herb-tools/core"
 
 import type { UnboundLintOffense, LintContext, FullRuleConfig } from "../types.js"
 import type { HTMLOpenTagNode, ParseResult } from "@herb-tools/core"
@@ -11,18 +12,14 @@ class IframeHasTitleVisitor extends BaseRuleVisitor {
   }
 
   private checkIframeElement(node: HTMLOpenTagNode): void {
-    const tagName = getTagName(node)
+    const tagName = getTagLocalName(node)
 
     if (tagName !== "iframe") {
       return
     }
 
-    const ariaHiddenAttribute = getAttribute(node, "aria-hidden")
-    if (ariaHiddenAttribute) {
-      const ariaHiddenValue = getAttributeValue(ariaHiddenAttribute)
-      if (ariaHiddenValue === "true") {
-        return
-      }
+    if (getStaticAttributeValue(node, "aria-hidden") === "true") {
+      return
     }
 
     const attribute = getAttribute(node, "title")
@@ -48,17 +45,17 @@ class IframeHasTitleVisitor extends BaseRuleVisitor {
 }
 
 export class HTMLIframeHasTitleRule extends ParserRule {
-  name = "html-iframe-has-title"
+  static ruleName = "html-iframe-has-title"
 
   get defaultConfig(): FullRuleConfig {
     return {
       enabled: true,
-      severity: "error"
+      severity: "warning"
     }
   }
 
   check(result: ParseResult, context?: Partial<LintContext>): UnboundLintOffense[] {
-    const visitor = new IframeHasTitleVisitor(this.name, context)
+    const visitor = new IframeHasTitleVisitor(this.ruleName, context)
 
     visitor.visit(result.value)
 

package/src/rules/html-img-require-alt.ts

@@ -1,4 +1,5 @@
-import { BaseRuleVisitor, getTagName, hasAttribute } from "./rule-utils.js"
+import { BaseRuleVisitor } from "./rule-utils.js"
+import { hasAttribute, getAttribute, hasAttributeValue, getTagLocalName } from "@herb-tools/core"
 
 import { ParserRule } from "../types.js"
 import type { UnboundLintOffense, LintContext, FullRuleConfig } from "../types.js"
@@ -11,7 +12,7 @@ class ImgRequireAltVisitor extends BaseRuleVisitor {
   }
 
   private checkImgTag(node: HTMLOpenTagNode): void {
-    const tagName = getTagName(node)
+    const tagName = getTagLocalName(node)
 
     if (tagName !== "img") {
       return
@@ -22,22 +23,32 @@ class ImgRequireAltVisitor extends BaseRuleVisitor {
         'Missing required `alt` attribute on `<img>` tag. Add `alt=""` for decorative images or `alt="description"` for informative images.',
         node.tag_name!.location
       )
+      return
+    }
+
+    const altAttribute = getAttribute(node, "alt")
+
+    if (altAttribute && !hasAttributeValue(altAttribute)) {
+      this.addOffense(
+        'The `alt` attribute has no value. Add `alt=""` for decorative images or `alt="description"` for informative images.',
+        altAttribute.location
+      )
     }
   }
 }
 
 export class HTMLImgRequireAltRule extends ParserRule {
-  name = "html-img-require-alt"
+  static ruleName = "html-img-require-alt"
 
   get defaultConfig(): FullRuleConfig {
     return {
       enabled: true,
-      severity: "error"
+      severity: "warning"
     }
   }
 
   check(result: ParseResult, context?: Partial<LintContext>): UnboundLintOffense[] {
-    const visitor = new ImgRequireAltVisitor(this.name, context)
+    const visitor = new ImgRequireAltVisitor(this.ruleName, context)
     visitor.visit(result.value)
     return visitor.offenses
   }