@herb-tools/linter 0.8.9 → 0.9.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +5 -5
- package/dist/{src/cli → cli}/argument-parser.js +15 -2
- package/dist/cli/argument-parser.js.map +1 -0
- package/dist/{src/cli → cli}/file-processor.js +155 -9
- package/dist/cli/file-processor.js.map +1 -0
- package/dist/cli/file-url.js +6 -0
- package/dist/cli/file-url.js.map +1 -0
- package/dist/cli/formatters/base-formatter.js.map +1 -0
- package/dist/{src/cli → cli}/formatters/detailed-formatter.js +16 -19
- package/dist/cli/formatters/detailed-formatter.js.map +1 -0
- package/dist/cli/formatters/github-actions-formatter.js.map +1 -0
- package/dist/cli/formatters/index.js.map +1 -0
- package/dist/cli/formatters/json-formatter.js.map +1 -0
- package/dist/cli/formatters/simple-formatter.js +54 -0
- package/dist/cli/formatters/simple-formatter.js.map +1 -0
- package/dist/cli/index.js.map +1 -0
- package/dist/cli/lint-worker.js +143 -0
- package/dist/cli/lint-worker.js.map +1 -0
- package/dist/cli/output-manager.js.map +1 -0
- package/dist/{src/cli → cli}/summary-reporter.js +13 -16
- package/dist/cli/summary-reporter.js.map +1 -0
- package/dist/{src/cli.js → cli.js} +5 -3
- package/dist/cli.js.map +1 -0
- package/dist/{src/custom-rule-loader.js → custom-rule-loader.js} +20 -4
- package/dist/custom-rule-loader.js.map +1 -0
- package/dist/herb-disable-comment-utils.js.map +1 -0
- package/dist/herb-lint.js +60648 -17513
- package/dist/herb-lint.js.map +1 -1
- package/dist/index.cjs +2621 -934
- package/dist/index.cjs.map +1 -1
- package/dist/index.js +2554 -873
- package/dist/index.js.map +1 -1
- package/dist/lint-worker.js +71462 -0
- package/dist/lint-worker.js.map +1 -0
- package/dist/linter-ignore.js.map +1 -0
- package/dist/{src/linter.js → linter.js} +89 -74
- package/dist/linter.js.map +1 -0
- package/dist/loader.cjs +31206 -7834
- package/dist/loader.cjs.map +1 -1
- package/dist/loader.js +31168 -7802
- package/dist/loader.js.map +1 -1
- package/dist/parse-cache.js +30 -0
- package/dist/parse-cache.js.map +1 -0
- package/dist/rules/actionview-no-silent-helper.js +45 -0
- package/dist/rules/actionview-no-silent-helper.js.map +1 -0
- package/dist/{src/rules → rules}/erb-comment-syntax.js +2 -2
- package/dist/rules/erb-comment-syntax.js.map +1 -0
- package/dist/{src/rules → rules}/erb-no-case-node-children.js +2 -2
- package/dist/rules/erb-no-case-node-children.js.map +1 -0
- package/dist/rules/erb-no-conditional-html-element.js +38 -0
- package/dist/rules/erb-no-conditional-html-element.js.map +1 -0
- package/dist/rules/erb-no-conditional-open-tag.js +24 -0
- package/dist/rules/erb-no-conditional-open-tag.js.map +1 -0
- package/dist/rules/erb-no-duplicate-branch-elements.js +245 -0
- package/dist/rules/erb-no-duplicate-branch-elements.js.map +1 -0
- package/dist/{src/rules → rules}/erb-no-empty-tags.js +2 -2
- package/dist/rules/erb-no-empty-tags.js.map +1 -0
- package/dist/{src/rules → rules}/erb-no-extra-newline.js +4 -21
- package/dist/rules/erb-no-extra-newline.js.map +1 -0
- package/dist/{src/rules → rules}/erb-no-extra-whitespace-inside-tags.js +39 -13
- package/dist/rules/erb-no-extra-whitespace-inside-tags.js.map +1 -0
- package/dist/rules/erb-no-inline-case-conditions.js +40 -0
- package/dist/rules/erb-no-inline-case-conditions.js.map +1 -0
- package/dist/rules/erb-no-instance-variables-in-partials.js +67 -0
- package/dist/rules/erb-no-instance-variables-in-partials.js.map +1 -0
- package/dist/rules/erb-no-interpolated-class-names.js +47 -0
- package/dist/rules/erb-no-interpolated-class-names.js.map +1 -0
- package/dist/rules/erb-no-javascript-tag-helper.js +34 -0
- package/dist/rules/erb-no-javascript-tag-helper.js.map +1 -0
- package/dist/{src/rules → rules}/erb-no-output-control-flow.js +9 -12
- package/dist/rules/erb-no-output-control-flow.js.map +1 -0
- package/dist/rules/erb-no-output-in-attribute-name.js +30 -0
- package/dist/rules/erb-no-output-in-attribute-name.js.map +1 -0
- package/dist/rules/erb-no-output-in-attribute-position.js +30 -0
- package/dist/rules/erb-no-output-in-attribute-position.js.map +1 -0
- package/dist/rules/erb-no-raw-output-in-attribute-value.js +35 -0
- package/dist/rules/erb-no-raw-output-in-attribute-value.js.map +1 -0
- package/dist/{src/rules → rules}/erb-no-silent-tag-in-attribute-name.js +2 -2
- package/dist/rules/erb-no-silent-tag-in-attribute-name.js.map +1 -0
- package/dist/rules/erb-no-statement-in-script.js +58 -0
- package/dist/rules/erb-no-statement-in-script.js.map +1 -0
- package/dist/rules/erb-no-then-in-control-flow.js +45 -0
- package/dist/rules/erb-no-then-in-control-flow.js.map +1 -0
- package/dist/rules/erb-no-trailing-whitespace.js +138 -0
- package/dist/rules/erb-no-trailing-whitespace.js.map +1 -0
- package/dist/rules/erb-no-unsafe-js-attribute.js +36 -0
- package/dist/rules/erb-no-unsafe-js-attribute.js.map +1 -0
- package/dist/rules/erb-no-unsafe-raw.js +63 -0
- package/dist/rules/erb-no-unsafe-raw.js.map +1 -0
- package/dist/rules/erb-no-unsafe-script-interpolation.js +54 -0
- package/dist/rules/erb-no-unsafe-script-interpolation.js.map +1 -0
- package/dist/{src/rules → rules}/erb-prefer-image-tag-helper.js +5 -4
- package/dist/rules/erb-prefer-image-tag-helper.js.map +1 -0
- package/dist/{src/rules → rules}/erb-require-trailing-newline.js +2 -2
- package/dist/rules/erb-require-trailing-newline.js.map +1 -0
- package/dist/{src/rules → rules}/erb-require-whitespace-inside-tags.js +39 -15
- package/dist/rules/erb-require-whitespace-inside-tags.js.map +1 -0
- package/dist/{src/rules → rules}/erb-right-trim.js +2 -2
- package/dist/rules/erb-right-trim.js.map +1 -0
- package/dist/{src/rules → rules}/erb-strict-locals-comment-syntax.js +5 -5
- package/dist/rules/erb-strict-locals-comment-syntax.js.map +1 -0
- package/dist/{src/rules → rules}/erb-strict-locals-required.js +2 -2
- package/dist/rules/erb-strict-locals-required.js.map +1 -0
- package/dist/rules/file-utils.js.map +1 -0
- package/dist/rules/herb-disable-comment-base.js.map +1 -0
- package/dist/{src/rules → rules}/herb-disable-comment-malformed.js +2 -2
- package/dist/rules/herb-disable-comment-malformed.js.map +1 -0
- package/dist/{src/rules → rules}/herb-disable-comment-missing-rules.js +2 -2
- package/dist/rules/herb-disable-comment-missing-rules.js.map +1 -0
- package/dist/{src/rules → rules}/herb-disable-comment-no-duplicate-rules.js +2 -2
- package/dist/rules/herb-disable-comment-no-duplicate-rules.js.map +1 -0
- package/dist/{src/rules → rules}/herb-disable-comment-no-redundant-all.js +2 -2
- package/dist/rules/herb-disable-comment-no-redundant-all.js.map +1 -0
- package/dist/{src/rules → rules}/herb-disable-comment-unnecessary.js +2 -2
- package/dist/rules/herb-disable-comment-unnecessary.js.map +1 -0
- package/dist/{src/rules → rules}/herb-disable-comment-valid-rule-name.js +2 -2
- package/dist/rules/herb-disable-comment-valid-rule-name.js.map +1 -0
- package/dist/rules/html-allowed-script-type.js +57 -0
- package/dist/rules/html-allowed-script-type.js.map +1 -0
- package/dist/rules/html-anchor-require-href.js +68 -0
- package/dist/rules/html-anchor-require-href.js.map +1 -0
- package/dist/{src/rules → rules}/html-aria-attribute-must-be-valid.js +3 -3
- package/dist/rules/html-aria-attribute-must-be-valid.js.map +1 -0
- package/dist/{src/rules → rules}/html-aria-label-is-well-formatted.js +3 -3
- package/dist/rules/html-aria-label-is-well-formatted.js.map +1 -0
- package/dist/{src/rules → rules}/html-aria-level-must-be-valid.js +3 -3
- package/dist/rules/html-aria-level-must-be-valid.js.map +1 -0
- package/dist/{src/rules → rules}/html-aria-role-heading-requires-level.js +5 -4
- package/dist/rules/html-aria-role-heading-requires-level.js.map +1 -0
- package/dist/{src/rules → rules}/html-aria-role-must-be-valid.js +3 -3
- package/dist/rules/html-aria-role-must-be-valid.js.map +1 -0
- package/dist/{src/rules → rules}/html-attribute-double-quotes.js +4 -4
- package/dist/rules/html-attribute-double-quotes.js.map +1 -0
- package/dist/{src/rules → rules}/html-attribute-equals-spacing.js +2 -2
- package/dist/rules/html-attribute-equals-spacing.js.map +1 -0
- package/dist/{src/rules → rules}/html-attribute-values-require-quotes.js +2 -2
- package/dist/rules/html-attribute-values-require-quotes.js.map +1 -0
- package/dist/{src/rules → rules}/html-avoid-both-disabled-and-aria-disabled.js +9 -9
- package/dist/rules/html-avoid-both-disabled-and-aria-disabled.js.map +1 -0
- package/dist/{src/rules → rules}/html-body-only-elements.js +5 -4
- package/dist/rules/html-body-only-elements.js.map +1 -0
- package/dist/{src/rules → rules}/html-boolean-attributes-no-value.js +4 -3
- package/dist/rules/html-boolean-attributes-no-value.js.map +1 -0
- package/dist/rules/html-details-has-summary.js +52 -0
- package/dist/rules/html-details-has-summary.js.map +1 -0
- package/dist/{src/rules → rules}/html-head-only-elements.js +6 -5
- package/dist/rules/html-head-only-elements.js.map +1 -0
- package/dist/{src/rules → rules}/html-iframe-has-title.js +8 -11
- package/dist/rules/html-iframe-has-title.js.map +1 -0
- package/dist/{src/rules → rules}/html-img-require-alt.js +11 -5
- package/dist/rules/html-img-require-alt.js.map +1 -0
- package/dist/{src/rules → rules}/html-input-require-autocomplete.js +7 -10
- package/dist/rules/html-input-require-autocomplete.js.map +1 -0
- package/dist/{src/rules → rules}/html-navigation-has-label.js +6 -5
- package/dist/rules/html-navigation-has-label.js.map +1 -0
- package/dist/rules/html-no-abstract-roles.js +29 -0
- package/dist/rules/html-no-abstract-roles.js.map +1 -0
- package/dist/rules/html-no-aria-hidden-on-body.js +42 -0
- package/dist/rules/html-no-aria-hidden-on-body.js.map +1 -0
- package/dist/{src/rules → rules}/html-no-aria-hidden-on-focusable.js +6 -5
- package/dist/rules/html-no-aria-hidden-on-focusable.js.map +1 -0
- package/dist/{src/rules → rules}/html-no-block-inside-inline.js +6 -9
- package/dist/rules/html-no-block-inside-inline.js.map +1 -0
- package/dist/{src/rules → rules}/html-no-duplicate-attributes.js +4 -3
- package/dist/rules/html-no-duplicate-attributes.js.map +1 -0
- package/dist/{src/rules → rules}/html-no-duplicate-ids.js +14 -11
- package/dist/rules/html-no-duplicate-ids.js.map +1 -0
- package/dist/{src/rules → rules}/html-no-duplicate-meta-names.js +22 -20
- package/dist/rules/html-no-duplicate-meta-names.js.map +1 -0
- package/dist/{src/rules → rules}/html-no-empty-attributes.js +2 -2
- package/dist/rules/html-no-empty-attributes.js.map +1 -0
- package/dist/rules/html-no-empty-headings.js +98 -0
- package/dist/rules/html-no-empty-headings.js.map +1 -0
- package/dist/{src/rules → rules}/html-no-nested-links.js +23 -15
- package/dist/rules/html-no-nested-links.js.map +1 -0
- package/dist/{src/rules → rules}/html-no-positive-tab-index.js +3 -3
- package/dist/rules/html-no-positive-tab-index.js.map +1 -0
- package/dist/{src/rules → rules}/html-no-self-closing.js +4 -4
- package/dist/rules/html-no-self-closing.js.map +1 -0
- package/dist/{src/rules → rules}/html-no-space-in-tag.js +4 -6
- package/dist/rules/html-no-space-in-tag.js.map +1 -0
- package/dist/{src/rules → rules}/html-no-title-attribute.js +6 -5
- package/dist/rules/html-no-title-attribute.js.map +1 -0
- package/dist/{src/rules → rules}/html-no-underscores-in-attribute-names.js +2 -2
- package/dist/rules/html-no-underscores-in-attribute-names.js.map +1 -0
- package/dist/rules/html-require-closing-tags.js +29 -0
- package/dist/rules/html-require-closing-tags.js.map +1 -0
- package/dist/{src/rules → rules}/html-tag-name-lowercase.js +13 -9
- package/dist/rules/html-tag-name-lowercase.js.map +1 -0
- package/dist/{src/rules → rules}/index.js +19 -0
- package/dist/rules/index.js.map +1 -0
- package/dist/{src/rules → rules}/parser-no-errors.js +3 -3
- package/dist/rules/parser-no-errors.js.map +1 -0
- package/dist/{src/rules → rules}/rule-utils.js +141 -219
- package/dist/rules/rule-utils.js.map +1 -0
- package/dist/rules/string-utils.js.map +1 -0
- package/dist/{src/rules → rules}/svg-tag-name-capitalization.js +7 -6
- package/dist/rules/svg-tag-name-capitalization.js.map +1 -0
- package/dist/rules/turbo-permanent-require-id.js +34 -0
- package/dist/rules/turbo-permanent-require-id.js.map +1 -0
- package/dist/{src/rules.js → rules.js} +56 -10
- package/dist/rules.js.map +1 -0
- package/dist/types/cli/argument-parser.d.ts +1 -0
- package/dist/types/cli/file-processor.d.ts +13 -0
- package/dist/types/cli/file-url.d.ts +1 -0
- package/dist/types/cli/index.d.ts +1 -0
- package/dist/types/cli/lint-worker.d.ts +34 -0
- package/dist/types/custom-rule-loader.d.ts +4 -0
- package/dist/types/index.d.ts +1 -0
- package/dist/types/linter.d.ts +13 -6
- package/dist/types/parse-cache.d.ts +9 -0
- package/dist/types/{src/rules/html-aria-level-must-be-valid.d.ts → rules/actionview-no-silent-helper.d.ts} +4 -3
- package/dist/types/rules/erb-comment-syntax.d.ts +1 -1
- package/dist/types/rules/erb-no-case-node-children.d.ts +1 -1
- package/dist/types/{src/rules/herb-disable-comment-malformed.d.ts → rules/erb-no-conditional-html-element.d.ts} +3 -3
- package/dist/types/{src/rules/erb-prefer-image-tag-helper.d.ts → rules/erb-no-conditional-open-tag.d.ts} +3 -3
- package/dist/types/rules/erb-no-duplicate-branch-elements.d.ts +17 -0
- package/dist/types/rules/erb-no-empty-tags.d.ts +1 -1
- package/dist/types/rules/erb-no-extra-newline.d.ts +1 -1
- package/dist/types/rules/erb-no-extra-whitespace-inside-tags.d.ts +1 -1
- package/dist/types/{src/rules/html-no-duplicate-attributes.d.ts → rules/erb-no-inline-case-conditions.d.ts} +4 -3
- package/dist/types/rules/erb-no-instance-variables-in-partials.d.ts +10 -0
- package/dist/types/{src/rules/html-no-aria-hidden-on-focusable.d.ts → rules/erb-no-interpolated-class-names.d.ts} +2 -2
- package/dist/types/{src/rules/html-aria-attribute-must-be-valid.d.ts → rules/erb-no-javascript-tag-helper.d.ts} +2 -2
- package/dist/types/rules/erb-no-output-control-flow.d.ts +1 -1
- package/dist/types/{src/rules/erb-no-silent-tag-in-attribute-name.d.ts → rules/erb-no-output-in-attribute-name.d.ts} +2 -2
- package/dist/types/{src/rules/herb-disable-comment-missing-rules.d.ts → rules/erb-no-output-in-attribute-position.d.ts} +2 -2
- package/dist/types/{src/rules/erb-no-empty-tags.d.ts → rules/erb-no-raw-output-in-attribute-value.d.ts} +2 -2
- package/dist/types/rules/erb-no-silent-tag-in-attribute-name.d.ts +1 -1
- package/dist/types/{src/rules/html-navigation-has-label.d.ts → rules/erb-no-statement-in-script.d.ts} +2 -2
- package/dist/types/rules/erb-no-then-in-control-flow.d.ts +9 -0
- package/dist/types/rules/erb-no-trailing-whitespace.d.ts +19 -0
- package/dist/types/{src/rules/html-no-positive-tab-index.d.ts → rules/erb-no-unsafe-js-attribute.d.ts} +2 -2
- package/dist/types/{src/rules/erb-no-case-node-children.d.ts → rules/erb-no-unsafe-raw.d.ts} +2 -2
- package/dist/types/rules/erb-no-unsafe-script-interpolation.d.ts +8 -0
- package/dist/types/rules/erb-prefer-image-tag-helper.d.ts +1 -1
- package/dist/types/rules/erb-require-trailing-newline.d.ts +1 -1
- package/dist/types/rules/erb-require-whitespace-inside-tags.d.ts +1 -1
- package/dist/types/rules/erb-right-trim.d.ts +1 -1
- package/dist/types/rules/erb-strict-locals-comment-syntax.d.ts +1 -1
- package/dist/types/rules/erb-strict-locals-required.d.ts +1 -1
- package/dist/types/rules/herb-disable-comment-malformed.d.ts +1 -1
- package/dist/types/rules/herb-disable-comment-missing-rules.d.ts +1 -1
- package/dist/types/rules/herb-disable-comment-no-duplicate-rules.d.ts +1 -1
- package/dist/types/rules/herb-disable-comment-no-redundant-all.d.ts +1 -1
- package/dist/types/rules/herb-disable-comment-unnecessary.d.ts +1 -1
- package/dist/types/rules/herb-disable-comment-valid-rule-name.d.ts +1 -1
- package/dist/types/{src/rules/html-anchor-require-href.d.ts → rules/html-allowed-script-type.d.ts} +2 -2
- package/dist/types/rules/html-anchor-require-href.d.ts +3 -2
- package/dist/types/rules/html-aria-attribute-must-be-valid.d.ts +1 -1
- package/dist/types/rules/html-aria-label-is-well-formatted.d.ts +1 -1
- package/dist/types/rules/html-aria-level-must-be-valid.d.ts +1 -1
- package/dist/types/rules/html-aria-role-heading-requires-level.d.ts +1 -1
- package/dist/types/rules/html-aria-role-must-be-valid.d.ts +1 -1
- package/dist/types/rules/html-attribute-double-quotes.d.ts +1 -1
- package/dist/types/rules/html-attribute-equals-spacing.d.ts +1 -1
- package/dist/types/rules/html-attribute-values-require-quotes.d.ts +1 -1
- package/dist/types/rules/html-avoid-both-disabled-and-aria-disabled.d.ts +1 -1
- package/dist/types/rules/html-body-only-elements.d.ts +1 -1
- package/dist/types/rules/html-boolean-attributes-no-value.d.ts +1 -1
- package/dist/types/{src/rules/html-no-empty-attributes.d.ts → rules/html-details-has-summary.d.ts} +4 -3
- package/dist/types/rules/html-head-only-elements.d.ts +1 -1
- package/dist/types/rules/html-iframe-has-title.d.ts +1 -1
- package/dist/types/rules/html-img-require-alt.d.ts +1 -1
- package/dist/types/rules/html-input-require-autocomplete.d.ts +1 -1
- package/dist/types/rules/html-navigation-has-label.d.ts +1 -1
- package/dist/types/{src/rules/html-no-empty-headings.d.ts → rules/html-no-abstract-roles.d.ts} +2 -2
- package/dist/types/{src/rules/erb-no-output-control-flow.d.ts → rules/html-no-aria-hidden-on-body.d.ts} +3 -3
- package/dist/types/rules/html-no-aria-hidden-on-focusable.d.ts +1 -1
- package/dist/types/rules/html-no-block-inside-inline.d.ts +1 -1
- package/dist/types/rules/html-no-duplicate-attributes.d.ts +1 -1
- package/dist/types/rules/html-no-duplicate-ids.d.ts +1 -1
- package/dist/types/rules/html-no-duplicate-meta-names.d.ts +1 -1
- package/dist/types/rules/html-no-empty-attributes.d.ts +1 -1
- package/dist/types/rules/html-no-empty-headings.d.ts +1 -1
- package/dist/types/rules/html-no-nested-links.d.ts +1 -1
- package/dist/types/rules/html-no-positive-tab-index.d.ts +1 -1
- package/dist/types/rules/html-no-self-closing.d.ts +1 -1
- package/dist/types/rules/html-no-space-in-tag.d.ts +1 -1
- package/dist/types/rules/html-no-title-attribute.d.ts +1 -1
- package/dist/types/rules/html-no-underscores-in-attribute-names.d.ts +1 -1
- package/dist/types/{src/rules/html-body-only-elements.d.ts → rules/html-require-closing-tags.d.ts} +4 -3
- package/dist/types/rules/html-tag-name-lowercase.d.ts +1 -1
- package/dist/types/rules/index.d.ts +19 -0
- package/dist/types/rules/parser-no-errors.d.ts +1 -1
- package/dist/types/rules/rule-utils.d.ts +35 -88
- package/dist/types/rules/svg-tag-name-capitalization.d.ts +1 -1
- package/dist/types/{src/rules/html-aria-role-must-be-valid.d.ts → rules/turbo-permanent-require-id.d.ts} +2 -2
- package/dist/types/types.d.ts +25 -7
- package/dist/types/urls.d.ts +1 -0
- package/dist/{src/types.js → types.js} +53 -0
- package/dist/types.js.map +1 -0
- package/dist/urls.js +5 -0
- package/dist/urls.js.map +1 -0
- package/docs/rules/README.md +23 -2
- package/docs/rules/actionview-no-silent-helper.md +57 -0
- package/docs/rules/erb-no-conditional-html-element.md +90 -0
- package/docs/rules/erb-no-conditional-open-tag.md +130 -0
- package/docs/rules/erb-no-duplicate-branch-elements.md +98 -0
- package/docs/rules/erb-no-inline-case-conditions.md +85 -0
- package/docs/rules/erb-no-instance-variables-in-partials.md +43 -0
- package/docs/rules/erb-no-interpolated-class-names.md +57 -0
- package/docs/rules/erb-no-javascript-tag-helper.md +33 -0
- package/docs/rules/erb-no-output-in-attribute-name.md +38 -0
- package/docs/rules/erb-no-output-in-attribute-position.md +60 -0
- package/docs/rules/erb-no-raw-output-in-attribute-value.md +37 -0
- package/docs/rules/erb-no-statement-in-script.md +68 -0
- package/docs/rules/erb-no-then-in-control-flow.md +86 -0
- package/docs/rules/erb-no-trailing-whitespace.md +69 -0
- package/docs/rules/erb-no-unsafe-js-attribute.md +41 -0
- package/docs/rules/erb-no-unsafe-raw.md +47 -0
- package/docs/rules/erb-no-unsafe-script-interpolation.md +73 -0
- package/docs/rules/html-allowed-script-type.md +59 -0
- package/docs/rules/html-anchor-require-href.md +19 -6
- package/docs/rules/html-details-has-summary.md +46 -0
- package/docs/rules/html-img-require-alt.md +5 -3
- package/docs/rules/html-no-abstract-roles.md +74 -0
- package/docs/rules/html-no-aria-hidden-on-body.md +44 -0
- package/docs/rules/html-require-closing-tags.md +142 -0
- package/docs/rules/parser-no-errors.md +4 -17
- package/docs/rules/turbo-permanent-require-id.md +41 -0
- package/package.json +12 -11
- package/src/cli/argument-parser.ts +20 -2
- package/src/cli/file-processor.ts +189 -10
- package/src/cli/file-url.ts +6 -0
- package/src/cli/formatters/detailed-formatter.ts +19 -21
- package/src/cli/formatters/simple-formatter.ts +23 -13
- package/src/cli/index.ts +2 -0
- package/src/cli/lint-worker.ts +208 -0
- package/src/cli/summary-reporter.ts +14 -15
- package/src/cli.ts +5 -3
- package/src/custom-rule-loader.ts +20 -5
- package/src/herb-disable-comment-utils.ts +0 -3
- package/src/index.ts +1 -0
- package/src/linter.ts +98 -79
- package/src/parse-cache.ts +39 -0
- package/src/rules/actionview-no-silent-helper.ts +58 -0
- package/src/rules/erb-comment-syntax.ts +2 -2
- package/src/rules/erb-no-case-node-children.ts +2 -2
- package/src/rules/erb-no-conditional-html-element.ts +53 -0
- package/src/rules/erb-no-conditional-open-tag.ts +37 -0
- package/src/rules/erb-no-duplicate-branch-elements.ts +320 -0
- package/src/rules/erb-no-empty-tags.ts +2 -2
- package/src/rules/erb-no-extra-newline.ts +5 -25
- package/src/rules/erb-no-extra-whitespace-inside-tags.ts +45 -15
- package/src/rules/erb-no-inline-case-conditions.ts +54 -0
- package/src/rules/erb-no-instance-variables-in-partials.ts +101 -0
- package/src/rules/erb-no-interpolated-class-names.ts +65 -0
- package/src/rules/erb-no-javascript-tag-helper.ts +47 -0
- package/src/rules/erb-no-output-control-flow.ts +10 -10
- package/src/rules/erb-no-output-in-attribute-name.ts +39 -0
- package/src/rules/erb-no-output-in-attribute-position.ts +39 -0
- package/src/rules/erb-no-raw-output-in-attribute-value.ts +47 -0
- package/src/rules/erb-no-silent-tag-in-attribute-name.ts +2 -2
- package/src/rules/erb-no-statement-in-script.ts +82 -0
- package/src/rules/erb-no-then-in-control-flow.ts +62 -0
- package/src/rules/erb-no-trailing-whitespace.ts +187 -0
- package/src/rules/erb-no-unsafe-js-attribute.ts +47 -0
- package/src/rules/erb-no-unsafe-raw.ts +83 -0
- package/src/rules/erb-no-unsafe-script-interpolation.ts +76 -0
- package/src/rules/erb-prefer-image-tag-helper.ts +5 -4
- package/src/rules/erb-require-trailing-newline.ts +2 -2
- package/src/rules/erb-require-whitespace-inside-tags.ts +42 -18
- package/src/rules/erb-right-trim.ts +2 -2
- package/src/rules/erb-strict-locals-comment-syntax.ts +5 -5
- package/src/rules/erb-strict-locals-required.ts +2 -2
- package/src/rules/herb-disable-comment-malformed.ts +2 -2
- package/src/rules/herb-disable-comment-missing-rules.ts +2 -2
- package/src/rules/herb-disable-comment-no-duplicate-rules.ts +2 -2
- package/src/rules/herb-disable-comment-no-redundant-all.ts +2 -2
- package/src/rules/herb-disable-comment-unnecessary.ts +2 -2
- package/src/rules/herb-disable-comment-valid-rule-name.ts +2 -2
- package/src/rules/html-allowed-script-type.ts +84 -0
- package/src/rules/html-anchor-require-href.ts +73 -11
- package/src/rules/html-aria-attribute-must-be-valid.ts +3 -3
- package/src/rules/html-aria-label-is-well-formatted.ts +3 -3
- package/src/rules/html-aria-level-must-be-valid.ts +3 -3
- package/src/rules/html-aria-role-heading-requires-level.ts +5 -4
- package/src/rules/html-aria-role-must-be-valid.ts +3 -3
- package/src/rules/html-attribute-double-quotes.ts +4 -4
- package/src/rules/html-attribute-equals-spacing.ts +2 -2
- package/src/rules/html-attribute-values-require-quotes.ts +2 -2
- package/src/rules/html-avoid-both-disabled-and-aria-disabled.ts +10 -11
- package/src/rules/html-body-only-elements.ts +5 -4
- package/src/rules/html-boolean-attributes-no-value.ts +4 -3
- package/src/rules/html-details-has-summary.ts +69 -0
- package/src/rules/html-head-only-elements.ts +6 -5
- package/src/rules/html-iframe-has-title.ts +8 -11
- package/src/rules/html-img-require-alt.ts +16 -5
- package/src/rules/html-input-require-autocomplete.ts +7 -10
- package/src/rules/html-navigation-has-label.ts +6 -5
- package/src/rules/html-no-abstract-roles.ts +40 -0
- package/src/rules/html-no-aria-hidden-on-body.ts +58 -0
- package/src/rules/html-no-aria-hidden-on-focusable.ts +6 -5
- package/src/rules/html-no-block-inside-inline.ts +7 -13
- package/src/rules/html-no-duplicate-attributes.ts +4 -3
- package/src/rules/html-no-duplicate-ids.ts +16 -13
- package/src/rules/html-no-duplicate-meta-names.ts +20 -19
- package/src/rules/html-no-empty-attributes.ts +2 -2
- package/src/rules/html-no-empty-headings.ts +44 -58
- package/src/rules/html-no-nested-links.ts +25 -16
- package/src/rules/html-no-positive-tab-index.ts +3 -3
- package/src/rules/html-no-self-closing.ts +5 -5
- package/src/rules/html-no-space-in-tag.ts +5 -8
- package/src/rules/html-no-title-attribute.ts +6 -5
- package/src/rules/html-no-underscores-in-attribute-names.ts +2 -2
- package/src/rules/html-require-closing-tags.ts +41 -0
- package/src/rules/html-tag-name-lowercase.ts +14 -9
- package/src/rules/index.ts +19 -0
- package/src/rules/parser-no-errors.ts +3 -3
- package/src/rules/rule-utils.ts +162 -279
- package/src/rules/svg-tag-name-capitalization.ts +10 -10
- package/src/rules/turbo-permanent-require-id.ts +49 -0
- package/src/rules.ts +60 -10
- package/src/types.ts +76 -7
- package/src/urls.ts +5 -0
- package/dist/package.json +0 -65
- package/dist/src/cli/argument-parser.js.map +0 -1
- package/dist/src/cli/file-processor.js.map +0 -1
- package/dist/src/cli/formatters/base-formatter.js.map +0 -1
- package/dist/src/cli/formatters/detailed-formatter.js.map +0 -1
- package/dist/src/cli/formatters/github-actions-formatter.js.map +0 -1
- package/dist/src/cli/formatters/index.js.map +0 -1
- package/dist/src/cli/formatters/json-formatter.js.map +0 -1
- package/dist/src/cli/formatters/simple-formatter.js +0 -44
- package/dist/src/cli/formatters/simple-formatter.js.map +0 -1
- package/dist/src/cli/index.js.map +0 -1
- package/dist/src/cli/output-manager.js.map +0 -1
- package/dist/src/cli/summary-reporter.js.map +0 -1
- package/dist/src/cli.js.map +0 -1
- package/dist/src/custom-rule-loader.js.map +0 -1
- package/dist/src/herb-disable-comment-utils.js.map +0 -1
- package/dist/src/herb-lint.js +0 -5
- package/dist/src/herb-lint.js.map +0 -1
- package/dist/src/index.js +0 -5
- package/dist/src/index.js.map +0 -1
- package/dist/src/linter-ignore.js.map +0 -1
- package/dist/src/linter.js.map +0 -1
- package/dist/src/loader.js +0 -17
- package/dist/src/loader.js.map +0 -1
- package/dist/src/rules/erb-comment-syntax.js.map +0 -1
- package/dist/src/rules/erb-no-case-node-children.js.map +0 -1
- package/dist/src/rules/erb-no-empty-tags.js.map +0 -1
- package/dist/src/rules/erb-no-extra-newline.js.map +0 -1
- package/dist/src/rules/erb-no-extra-whitespace-inside-tags.js.map +0 -1
- package/dist/src/rules/erb-no-output-control-flow.js.map +0 -1
- package/dist/src/rules/erb-no-silent-tag-in-attribute-name.js.map +0 -1
- package/dist/src/rules/erb-prefer-image-tag-helper.js.map +0 -1
- package/dist/src/rules/erb-require-trailing-newline.js.map +0 -1
- package/dist/src/rules/erb-require-whitespace-inside-tags.js.map +0 -1
- package/dist/src/rules/erb-right-trim.js.map +0 -1
- package/dist/src/rules/erb-strict-locals-comment-syntax.js.map +0 -1
- package/dist/src/rules/erb-strict-locals-required.js.map +0 -1
- package/dist/src/rules/file-utils.js.map +0 -1
- package/dist/src/rules/herb-disable-comment-base.js.map +0 -1
- package/dist/src/rules/herb-disable-comment-malformed.js.map +0 -1
- package/dist/src/rules/herb-disable-comment-missing-rules.js.map +0 -1
- package/dist/src/rules/herb-disable-comment-no-duplicate-rules.js.map +0 -1
- package/dist/src/rules/herb-disable-comment-no-redundant-all.js.map +0 -1
- package/dist/src/rules/herb-disable-comment-unnecessary.js.map +0 -1
- package/dist/src/rules/herb-disable-comment-valid-rule-name.js.map +0 -1
- package/dist/src/rules/html-anchor-require-href.js +0 -32
- package/dist/src/rules/html-anchor-require-href.js.map +0 -1
- package/dist/src/rules/html-aria-attribute-must-be-valid.js.map +0 -1
- package/dist/src/rules/html-aria-label-is-well-formatted.js.map +0 -1
- package/dist/src/rules/html-aria-level-must-be-valid.js.map +0 -1
- package/dist/src/rules/html-aria-role-heading-requires-level.js.map +0 -1
- package/dist/src/rules/html-aria-role-must-be-valid.js.map +0 -1
- package/dist/src/rules/html-attribute-double-quotes.js.map +0 -1
- package/dist/src/rules/html-attribute-equals-spacing.js.map +0 -1
- package/dist/src/rules/html-attribute-values-require-quotes.js.map +0 -1
- package/dist/src/rules/html-avoid-both-disabled-and-aria-disabled.js.map +0 -1
- package/dist/src/rules/html-body-only-elements.js.map +0 -1
- package/dist/src/rules/html-boolean-attributes-no-value.js.map +0 -1
- package/dist/src/rules/html-head-only-elements.js.map +0 -1
- package/dist/src/rules/html-iframe-has-title.js.map +0 -1
- package/dist/src/rules/html-img-require-alt.js.map +0 -1
- package/dist/src/rules/html-input-require-autocomplete.js.map +0 -1
- package/dist/src/rules/html-navigation-has-label.js.map +0 -1
- package/dist/src/rules/html-no-aria-hidden-on-focusable.js.map +0 -1
- package/dist/src/rules/html-no-block-inside-inline.js.map +0 -1
- package/dist/src/rules/html-no-duplicate-attributes.js.map +0 -1
- package/dist/src/rules/html-no-duplicate-ids.js.map +0 -1
- package/dist/src/rules/html-no-duplicate-meta-names.js.map +0 -1
- package/dist/src/rules/html-no-empty-attributes.js.map +0 -1
- package/dist/src/rules/html-no-empty-headings.js +0 -115
- package/dist/src/rules/html-no-empty-headings.js.map +0 -1
- package/dist/src/rules/html-no-nested-links.js.map +0 -1
- package/dist/src/rules/html-no-positive-tab-index.js.map +0 -1
- package/dist/src/rules/html-no-self-closing.js.map +0 -1
- package/dist/src/rules/html-no-space-in-tag.js.map +0 -1
- package/dist/src/rules/html-no-title-attribute.js.map +0 -1
- package/dist/src/rules/html-no-underscores-in-attribute-names.js.map +0 -1
- package/dist/src/rules/html-tag-name-lowercase.js.map +0 -1
- package/dist/src/rules/index.js.map +0 -1
- package/dist/src/rules/parser-no-errors.js.map +0 -1
- package/dist/src/rules/rule-utils.js.map +0 -1
- package/dist/src/rules/string-utils.js.map +0 -1
- package/dist/src/rules/svg-tag-name-capitalization.js.map +0 -1
- package/dist/src/rules.js.map +0 -1
- package/dist/src/types.js.map +0 -1
- package/dist/tsconfig.tsbuildinfo +0 -1
- package/dist/types/src/cli/argument-parser.d.ts +0 -25
- package/dist/types/src/cli/file-processor.d.ts +0 -43
- package/dist/types/src/cli/formatters/base-formatter.d.ts +0 -6
- package/dist/types/src/cli/formatters/detailed-formatter.d.ts +0 -13
- package/dist/types/src/cli/formatters/github-actions-formatter.d.ts +0 -17
- package/dist/types/src/cli/formatters/index.d.ts +0 -5
- package/dist/types/src/cli/formatters/json-formatter.d.ts +0 -48
- package/dist/types/src/cli/formatters/simple-formatter.d.ts +0 -8
- package/dist/types/src/cli/index.d.ts +0 -5
- package/dist/types/src/cli/output-manager.d.ts +0 -32
- package/dist/types/src/cli/summary-reporter.d.ts +0 -28
- package/dist/types/src/cli.d.ts +0 -28
- package/dist/types/src/custom-rule-loader.d.ts +0 -62
- package/dist/types/src/herb-disable-comment-utils.d.ts +0 -69
- package/dist/types/src/herb-lint.d.ts +0 -2
- package/dist/types/src/index.d.ts +0 -4
- package/dist/types/src/linter-ignore.d.ts +0 -12
- package/dist/types/src/linter.d.ts +0 -133
- package/dist/types/src/loader.d.ts +0 -20
- package/dist/types/src/rules/erb-comment-syntax.d.ts +0 -14
- package/dist/types/src/rules/erb-no-extra-newline.d.ts +0 -14
- package/dist/types/src/rules/erb-no-extra-whitespace-inside-tags.d.ts +0 -18
- package/dist/types/src/rules/erb-require-trailing-newline.d.ts +0 -9
- package/dist/types/src/rules/erb-require-whitespace-inside-tags.d.ts +0 -18
- package/dist/types/src/rules/erb-right-trim.d.ts +0 -14
- package/dist/types/src/rules/erb-strict-locals-comment-syntax.d.ts +0 -9
- package/dist/types/src/rules/erb-strict-locals-required.d.ts +0 -9
- package/dist/types/src/rules/file-utils.d.ts +0 -13
- package/dist/types/src/rules/herb-disable-comment-base.d.ts +0 -37
- package/dist/types/src/rules/herb-disable-comment-no-duplicate-rules.d.ts +0 -8
- package/dist/types/src/rules/herb-disable-comment-no-redundant-all.d.ts +0 -8
- package/dist/types/src/rules/herb-disable-comment-unnecessary.d.ts +0 -8
- package/dist/types/src/rules/herb-disable-comment-valid-rule-name.d.ts +0 -8
- package/dist/types/src/rules/html-aria-label-is-well-formatted.d.ts +0 -8
- package/dist/types/src/rules/html-aria-role-heading-requires-level.d.ts +0 -8
- package/dist/types/src/rules/html-attribute-double-quotes.d.ts +0 -15
- package/dist/types/src/rules/html-attribute-equals-spacing.d.ts +0 -14
- package/dist/types/src/rules/html-attribute-values-require-quotes.d.ts +0 -15
- package/dist/types/src/rules/html-avoid-both-disabled-and-aria-disabled.d.ts +0 -8
- package/dist/types/src/rules/html-boolean-attributes-no-value.d.ts +0 -14
- package/dist/types/src/rules/html-head-only-elements.d.ts +0 -9
- package/dist/types/src/rules/html-iframe-has-title.d.ts +0 -8
- package/dist/types/src/rules/html-img-require-alt.d.ts +0 -8
- package/dist/types/src/rules/html-input-require-autocomplete.d.ts +0 -8
- package/dist/types/src/rules/html-no-block-inside-inline.d.ts +0 -8
- package/dist/types/src/rules/html-no-duplicate-ids.d.ts +0 -8
- package/dist/types/src/rules/html-no-duplicate-meta-names.d.ts +0 -9
- package/dist/types/src/rules/html-no-nested-links.d.ts +0 -8
- package/dist/types/src/rules/html-no-self-closing.d.ts +0 -16
- package/dist/types/src/rules/html-no-space-in-tag.d.ts +0 -16
- package/dist/types/src/rules/html-no-title-attribute.d.ts +0 -8
- package/dist/types/src/rules/html-no-underscores-in-attribute-names.d.ts +0 -8
- package/dist/types/src/rules/html-tag-name-lowercase.d.ts +0 -18
- package/dist/types/src/rules/index.d.ts +0 -54
- package/dist/types/src/rules/parser-no-errors.d.ts +0 -9
- package/dist/types/src/rules/rule-utils.d.ts +0 -351
- package/dist/types/src/rules/string-utils.d.ts +0 -15
- package/dist/types/src/rules/svg-tag-name-capitalization.d.ts +0 -16
- package/dist/types/src/rules.d.ts +0 -2
- package/dist/types/src/types.d.ts +0 -190
- /package/dist/{src/cli → cli}/formatters/base-formatter.js +0 -0
- /package/dist/{src/cli → cli}/formatters/github-actions-formatter.js +0 -0
- /package/dist/{src/cli → cli}/formatters/index.js +0 -0
- /package/dist/{src/cli → cli}/formatters/json-formatter.js +0 -0
- /package/dist/{src/cli → cli}/index.js +0 -0
- /package/dist/{src/cli → cli}/output-manager.js +0 -0
- /package/dist/{src/herb-disable-comment-utils.js → herb-disable-comment-utils.js} +0 -0
- /package/dist/{src/linter-ignore.js → linter-ignore.js} +0 -0
- /package/dist/{src/rules → rules}/file-utils.js +0 -0
- /package/dist/{src/rules → rules}/herb-disable-comment-base.js +0 -0
- /package/dist/{src/rules → rules}/string-utils.js +0 -0
|
@@ -0,0 +1,30 @@
|
|
|
1
|
+
import { DEFAULT_PARSER_OPTIONS } from "@herb-tools/core";
|
|
2
|
+
import { DEFAULT_LINTER_PARSER_OPTIONS } from "./types.js";
|
|
3
|
+
export class ParseCache {
|
|
4
|
+
herb;
|
|
5
|
+
cache = new Map();
|
|
6
|
+
constructor(herb) {
|
|
7
|
+
this.herb = herb;
|
|
8
|
+
}
|
|
9
|
+
get(source, parserOptions = {}) {
|
|
10
|
+
const effectiveOptions = this.resolveOptions(parserOptions);
|
|
11
|
+
const key = source + JSON.stringify(effectiveOptions);
|
|
12
|
+
let result = this.cache.get(key);
|
|
13
|
+
if (!result) {
|
|
14
|
+
result = this.herb.parse(source, effectiveOptions);
|
|
15
|
+
this.cache.set(key, result);
|
|
16
|
+
}
|
|
17
|
+
return result;
|
|
18
|
+
}
|
|
19
|
+
clear() {
|
|
20
|
+
this.cache.clear();
|
|
21
|
+
}
|
|
22
|
+
resolveOptions(parserOptions) {
|
|
23
|
+
return {
|
|
24
|
+
...DEFAULT_PARSER_OPTIONS,
|
|
25
|
+
...DEFAULT_LINTER_PARSER_OPTIONS,
|
|
26
|
+
...parserOptions
|
|
27
|
+
};
|
|
28
|
+
}
|
|
29
|
+
}
|
|
30
|
+
//# sourceMappingURL=parse-cache.js.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"parse-cache.js","sourceRoot":"","sources":["../src/parse-cache.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,sBAAsB,EAAE,MAAM,kBAAkB,CAAA;AACzD,OAAO,EAAE,6BAA6B,EAAE,MAAM,YAAY,CAAA;AAI1D,MAAM,OAAO,UAAU;IACb,IAAI,CAAa;IACjB,KAAK,GAAG,IAAI,GAAG,EAAuB,CAAA;IAE9C,YAAY,IAAiB;QAC3B,IAAI,CAAC,IAAI,GAAG,IAAI,CAAA;IAClB,CAAC;IAED,GAAG,CAAC,MAAc,EAAE,gBAAwC,EAAE;QAC5D,MAAM,gBAAgB,GAAG,IAAI,CAAC,cAAc,CAAC,aAAa,CAAC,CAAA;QAC3D,MAAM,GAAG,GAAG,MAAM,GAAG,IAAI,CAAC,SAAS,CAAC,gBAAgB,CAAC,CAAA;QAErD,IAAI,MAAM,GAAG,IAAI,CAAC,KAAK,CAAC,GAAG,CAAC,GAAG,CAAC,CAAA;QAEhC,IAAI,CAAC,MAAM,EAAE,CAAC;YACZ,MAAM,GAAG,IAAI,CAAC,IAAI,CAAC,KAAK,CAAC,MAAM,EAAE,gBAAgB,CAAC,CAAA;YAClD,IAAI,CAAC,KAAK,CAAC,GAAG,CAAC,GAAG,EAAE,MAAM,CAAC,CAAA;QAC7B,CAAC;QAED,OAAO,MAAM,CAAA;IACf,CAAC;IAED,KAAK;QACH,IAAI,CAAC,KAAK,CAAC,KAAK,EAAE,CAAA;IACpB,CAAC;IAED,cAAc,CAAC,aAAqC;QAClD,OAAO;YACL,GAAG,sBAAsB;YACzB,GAAG,6BAA6B;YAChC,GAAG,aAAa;SACjB,CAAA;IACH,CAAC;CACF"}
|
|
@@ -0,0 +1,45 @@
|
|
|
1
|
+
import { ParserRule } from "../types.js";
|
|
2
|
+
import { BaseRuleVisitor } from "./rule-utils.js";
|
|
3
|
+
import { isERBOpenTagNode, isERBOutputNode } from "@herb-tools/core";
|
|
4
|
+
class ActionViewNoSilentHelperVisitor extends BaseRuleVisitor {
|
|
5
|
+
visitHTMLElementNode(node) {
|
|
6
|
+
this.checkActionViewHelper(node);
|
|
7
|
+
super.visitHTMLElementNode(node);
|
|
8
|
+
}
|
|
9
|
+
checkActionViewHelper(node) {
|
|
10
|
+
if (!node.element_source || node.element_source === "HTML")
|
|
11
|
+
return;
|
|
12
|
+
if (!isERBOpenTagNode(node.open_tag))
|
|
13
|
+
return;
|
|
14
|
+
if (isERBOutputNode(node.open_tag))
|
|
15
|
+
return;
|
|
16
|
+
const tagOpening = node.open_tag.tag_opening?.value;
|
|
17
|
+
if (!tagOpening)
|
|
18
|
+
return;
|
|
19
|
+
const helperName = node.element_source.includes("#")
|
|
20
|
+
? node.element_source.split("#").pop()
|
|
21
|
+
: node.element_source;
|
|
22
|
+
this.addOffense(`Avoid using \`${tagOpening} %>\` with \`${helperName}\`. Use \`<%= %>\` to ensure the helper's output is rendered.`, node.open_tag.location);
|
|
23
|
+
}
|
|
24
|
+
}
|
|
25
|
+
export class ActionViewNoSilentHelperRule extends ParserRule {
|
|
26
|
+
static ruleName = "actionview-no-silent-helper";
|
|
27
|
+
get defaultConfig() {
|
|
28
|
+
return {
|
|
29
|
+
enabled: true,
|
|
30
|
+
severity: "error"
|
|
31
|
+
};
|
|
32
|
+
}
|
|
33
|
+
get parserOptions() {
|
|
34
|
+
return {
|
|
35
|
+
track_whitespace: true,
|
|
36
|
+
action_view_helpers: true,
|
|
37
|
+
};
|
|
38
|
+
}
|
|
39
|
+
check(result, context) {
|
|
40
|
+
const visitor = new ActionViewNoSilentHelperVisitor(this.ruleName, context);
|
|
41
|
+
visitor.visit(result.value);
|
|
42
|
+
return visitor.offenses;
|
|
43
|
+
}
|
|
44
|
+
}
|
|
45
|
+
//# sourceMappingURL=actionview-no-silent-helper.js.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"actionview-no-silent-helper.js","sourceRoot":"","sources":["../../src/rules/actionview-no-silent-helper.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,UAAU,EAAE,MAAM,aAAa,CAAA;AACxC,OAAO,EAAE,eAAe,EAAE,MAAM,iBAAiB,CAAA;AACjD,OAAO,EAAE,gBAAgB,EAAE,eAAe,EAAE,MAAM,kBAAkB,CAAA;AAKpE,MAAM,+BAAgC,SAAQ,eAAe;IAC3D,oBAAoB,CAAC,IAAqB;QACxC,IAAI,CAAC,qBAAqB,CAAC,IAAI,CAAC,CAAA;QAChC,KAAK,CAAC,oBAAoB,CAAC,IAAI,CAAC,CAAA;IAClC,CAAC;IAEO,qBAAqB,CAAC,IAAqB;QACjD,IAAI,CAAC,IAAI,CAAC,cAAc,IAAI,IAAI,CAAC,cAAc,KAAK,MAAM;YAAE,OAAM;QAClE,IAAI,CAAC,gBAAgB,CAAC,IAAI,CAAC,QAAQ,CAAC;YAAE,OAAM;QAC5C,IAAI,eAAe,CAAC,IAAI,CAAC,QAAQ,CAAC;YAAE,OAAM;QAE1C,MAAM,UAAU,GAAG,IAAI,CAAC,QAAQ,CAAC,WAAW,EAAE,KAAK,CAAA;QAEnD,IAAI,CAAC,UAAU;YAAE,OAAM;QAEvB,MAAM,UAAU,GAAG,IAAI,CAAC,cAAc,CAAC,QAAQ,CAAC,GAAG,CAAC;YAClD,CAAC,CAAC,IAAI,CAAC,cAAc,CAAC,KAAK,CAAC,GAAG,CAAC,CAAC,GAAG,EAAE;YACtC,CAAC,CAAC,IAAI,CAAC,cAAc,CAAA;QAEvB,IAAI,CAAC,UAAU,CACb,iBAAiB,UAAU,gBAAgB,UAAU,+DAA+D,EACpH,IAAI,CAAC,QAAQ,CAAC,QAAQ,CACvB,CAAA;IACH,CAAC;CACF;AAED,MAAM,OAAO,4BAA6B,SAAQ,UAAU;IAC1D,MAAM,CAAC,QAAQ,GAAG,6BAA6B,CAAA;IAE/C,IAAI,aAAa;QACf,OAAO;YACL,OAAO,EAAE,IAAI;YACb,QAAQ,EAAE,OAAO;SAClB,CAAA;IACH,CAAC;IAED,IAAI,aAAa;QACf,OAAO;YACL,gBAAgB,EAAE,IAAI;YACtB,mBAAmB,EAAE,IAAI;SAC1B,CAAA;IACH,CAAC;IAED,KAAK,CAAC,MAAmB,EAAE,OAA8B;QACvD,MAAM,OAAO,GAAG,IAAI,+BAA+B,CAAC,IAAI,CAAC,QAAQ,EAAE,OAAO,CAAC,CAAA;QAE3E,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,KAAK,CAAC,CAAA;QAE3B,OAAO,OAAO,CAAC,QAAQ,CAAA;IACzB,CAAC"}
|
|
@@ -16,7 +16,7 @@ class ERBCommentSyntaxVisitor extends BaseRuleVisitor {
|
|
|
16
16
|
}
|
|
17
17
|
export class ERBCommentSyntax extends ParserRule {
|
|
18
18
|
static autocorrectable = true;
|
|
19
|
-
|
|
19
|
+
static ruleName = "erb-comment-syntax";
|
|
20
20
|
get defaultConfig() {
|
|
21
21
|
return {
|
|
22
22
|
enabled: true,
|
|
@@ -24,7 +24,7 @@ export class ERBCommentSyntax extends ParserRule {
|
|
|
24
24
|
};
|
|
25
25
|
}
|
|
26
26
|
check(result, context) {
|
|
27
|
-
const visitor = new ERBCommentSyntaxVisitor(this.
|
|
27
|
+
const visitor = new ERBCommentSyntaxVisitor(this.ruleName, context);
|
|
28
28
|
visitor.visit(result.value);
|
|
29
29
|
return visitor.offenses;
|
|
30
30
|
}
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"erb-comment-syntax.js","sourceRoot":"","sources":["../../src/rules/erb-comment-syntax.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,eAAe,EAAE,MAAM,iBAAiB,CAAA;AACjD,OAAO,EAAE,UAAU,EAA+B,MAAM,aAAa,CAAA;AASrE,MAAM,uBAAwB,SAAQ,eAA+C;IACnF,mBAAmB,CAAC,IAAoB;QACtC,MAAM,OAAO,GAAG,IAAI,CAAC,OAAO,EAAE,KAAK,IAAI,EAAE,CAAA;QAEzC,IAAI,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,EAAE,CAAC;YAC1B,MAAM,UAAU,GAAG,IAAI,CAAC,WAAW,EAAE,KAAK,CAAA;YAE1C,IAAI,OAAO,CAAC,QAAQ,CAAC,cAAc,CAAC,EAAE,CAAC;gBACrC,IAAI,CAAC,UAAU,CACb,4BAA4B,UAAU,2GAA2G,EACjJ,IAAI,CAAC,QAAQ,EACb,EAAE,IAAI,EAAE,CACT,CAAA;YACH,CAAC;iBAAM,CAAC;gBACN,IAAI,CAAC,UAAU,CACb,4BAA4B,UAAU,0EAA0E,EAChH,IAAI,CAAC,QAAQ,EACb,EAAE,IAAI,EAAE,CACT,CAAA;YACH,CAAC;QACH,CAAC;IACH,CAAC;CACF;AAED,MAAM,OAAO,gBAAiB,SAAQ,UAA0C;IAC9E,MAAM,CAAC,eAAe,GAAG,IAAI,CAAA;IAC7B,MAAM,CAAC,QAAQ,GAAG,oBAAoB,CAAA;IAEtC,IAAI,aAAa;QACf,OAAO;YACL,OAAO,EAAE,IAAI;YACb,QAAQ,EAAE,OAAO;SAClB,CAAA;IACH,CAAC;IAED,KAAK,CAAC,MAAmB,EAAE,OAA8B;QACvD,MAAM,OAAO,GAAG,IAAI,uBAAuB,CAAC,IAAI,CAAC,QAAQ,EAAE,OAAO,CAAC,CAAA;QAEnE,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,KAAK,CAAC,CAAA;QAE3B,OAAO,OAAO,CAAC,QAAQ,CAAA;IACzB,CAAC;IAED,OAAO,CAAC,OAAoD,EAAE,MAAmB,EAAE,QAA+B;QAChH,IAAI,CAAC,OAAO,CAAC,cAAc;YAAE,OAAO,IAAI,CAAA;QAExC,MAAM,EAAE,IAAI,EAAE,GAAG,OAAO,CAAC,cAAc,CAAA;QAEvC,IAAI,CAAC,IAAI,CAAC,WAAW;YAAE,OAAO,IAAI,CAAA;QAClC,IAAI,CAAC,IAAI,CAAC,OAAO;YAAE,OAAO,IAAI,CAAA;QAE9B,IAAI,CAAC,WAAW,CAAC,KAAK,GAAG,KAAK,CAAA;QAE9B,MAAM,OAAO,GAAG,IAAI,CAAC,OAAO,CAAC,KAAK,CAAA;QAClC,MAAM,KAAK,GAAG,OAAO,CAAC,KAAK,CAAC,QAAQ,CAAC,CAAA;QAErC,IAAI,KAAK,EAAE,CAAC;YACV,IAAI,CAAC,OAAO,CAAC,KAAK,GAAG,OAAO,CAAC,SAAS,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,CAAA;QACzD,CAAC;QAED,OAAO,MAAM,CAAA;IACf,CAAC"}
|
|
@@ -36,7 +36,7 @@ class ERBNoCaseNodeChildrenVisitor extends BaseRuleVisitor {
|
|
|
36
36
|
}
|
|
37
37
|
}
|
|
38
38
|
export class ERBNoCaseNodeChildrenRule extends ParserRule {
|
|
39
|
-
|
|
39
|
+
static ruleName = "erb-no-case-node-children";
|
|
40
40
|
get defaultConfig() {
|
|
41
41
|
return {
|
|
42
42
|
enabled: true,
|
|
@@ -44,7 +44,7 @@ export class ERBNoCaseNodeChildrenRule extends ParserRule {
|
|
|
44
44
|
};
|
|
45
45
|
}
|
|
46
46
|
check(result, context) {
|
|
47
|
-
const visitor = new ERBNoCaseNodeChildrenVisitor(this.
|
|
47
|
+
const visitor = new ERBNoCaseNodeChildrenVisitor(this.ruleName, context);
|
|
48
48
|
visitor.visit(result.value);
|
|
49
49
|
return visitor.offenses;
|
|
50
50
|
}
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"erb-no-case-node-children.js","sourceRoot":"","sources":["../../src/rules/erb-no-case-node-children.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,eAAe,EAAE,MAAM,iBAAiB,CAAA;AACjD,OAAO,EAAE,UAAU,EAAE,MAAM,aAAa,CAAA;AACxC,OAAO,EAAE,gBAAgB,EAAE,aAAa,EAAE,cAAc,EAAE,aAAa,EAAE,SAAS,EAAE,MAAM,kBAAkB,CAAA;AAC5G,OAAO,EAAE,eAAe,EAAE,MAAM,qBAAqB,CAAA;AAKrD,MAAM,4BAA6B,SAAQ,eAAe;IACxD,gBAAgB,CAAC,IAAiB;QAChC,IAAI,CAAC,qBAAqB,CAAC,IAAI,EAAE,MAAM,CAAC,CAAA;QACxC,IAAI,CAAC,eAAe,CAAC,IAAI,CAAC,CAAA;IAC5B,CAAC;IAED,qBAAqB,CAAC,IAAsB;QAC1C,IAAI,CAAC,qBAAqB,CAAC,IAAI,EAAE,IAAI,CAAC,CAAA;QACtC,IAAI,CAAC,eAAe,CAAC,IAAI,CAAC,CAAA;IAC5B,CAAC;IAEO,qBAAqB,CAAC,IAAoC,EAAE,IAAY;QAC9E,IAAI,CAAC,IAAI,CAAC,QAAQ,IAAI,IAAI,CAAC,QAAQ,CAAC,MAAM,KAAK,CAAC;YAAE,OAAM;QAExD,MAAM,QAAQ,GAAG,eAAe,CAAC,YAAY,CAAC,IAAI,CAAC,CAAA;QACnD,MAAM,cAAc,GAAG,IAAI,CAAC,UAAU,EAAE,CAAC,CAAC,CAAC,CAAA;QAC3C,MAAM,aAAa,GAAG,cAAc,IAAI,SAAS,CAAC,cAAc,CAAC,CAAC,CAAC,CAAC,eAAe,CAAC,YAAY,CAAC,cAAc,CAAC,CAAC,CAAC,CAAC,MAAM,IAAI,SAAS,CAAA;QAEtI,KAAK,MAAM,KAAK,IAAI,IAAI,CAAC,QAAQ,EAAE,CAAC;YAClC,IAAI,CAAC,IAAI,CAAC,gBAAgB,CAAC,KAAK,CAAC,EAAE,CAAC;gBAClC,MAAM,SAAS,GAAG,eAAe,CAAC,KAAK,CAAC,KAAK,CAAC,CAAC,IAAI,EAAE,CAAA;gBAErD,IAAI,CAAC,UAAU,CACb,kBAAkB,SAAS,gBAAgB,QAAQ,YAAY,aAAa,sEAAsE,EAClJ,KAAK,CAAC,QAAQ,CACf,CAAA;YACH,CAAC;QACH,CAAC;IACH,CAAC;IAEO,gBAAgB,CAAC,IAAU;QACjC,IAAI,gBAAgB,CAAC,IAAI,CAAC;YAAE,OAAO,IAAI,CAAA;QACvC,IAAI,aAAa,CAAC,IAAI,CAAC;YAAE,OAAO,IAAI,CAAA;QAEpC,IAAI,aAAa,CAAC,IAAI,CAAC,IAAI,cAAc,CAAC,IAAI,CAAC,EAAE,CAAC;YAChD,OAAO,OAAO,CAAC,IAAI,CAAC,IAAI,CAAC,OAAO,CAAC,CAAA;QACnC,CAAC;QAED,OAAO,KAAK,CAAA;IACd,CAAC;CACF;AAED,MAAM,OAAO,yBAA0B,SAAQ,UAAU;IACvD,MAAM,CAAC,QAAQ,GAAG,2BAA2B,CAAA;IAE7C,IAAI,aAAa;QACf,OAAO;YACL,OAAO,EAAE,IAAI;YACb,QAAQ,EAAE,OAAO;SAClB,CAAA;IACH,CAAC;IAED,KAAK,CAAC,MAAmB,EAAE,OAA8B;QACvD,MAAM,OAAO,GAAG,IAAI,4BAA4B,CAAC,IAAI,CAAC,QAAQ,EAAE,OAAO,CAAC,CAAA;QAExE,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,KAAK,CAAC,CAAA;QAE3B,OAAO,OAAO,CAAC,QAAQ,CAAA;IACzB,CAAC"}
|
|
@@ -0,0 +1,38 @@
|
|
|
1
|
+
import dedent from "dedent";
|
|
2
|
+
import { ParserRule } from "../types.js";
|
|
3
|
+
import { BaseRuleVisitor } from "./rule-utils.js";
|
|
4
|
+
class ERBNoConditionalHTMLElementRuleVisitor extends BaseRuleVisitor {
|
|
5
|
+
visitHTMLConditionalElementNode(node) {
|
|
6
|
+
const tagName = node.tag_name?.value || "element";
|
|
7
|
+
const condition = node.condition || "condition";
|
|
8
|
+
const suggestion = dedent `
|
|
9
|
+
Consider using a \`capture\` block instead:
|
|
10
|
+
|
|
11
|
+
<% content = capture do %>
|
|
12
|
+
... your content here ...
|
|
13
|
+
<% end %>
|
|
14
|
+
|
|
15
|
+
<%= ${condition} ? content_tag(:${tagName}, content) : content %>
|
|
16
|
+
`;
|
|
17
|
+
this.addOffense(dedent `
|
|
18
|
+
Avoid opening and closing \`<${tagName}>\` tags in separate conditional blocks with the same condition. \
|
|
19
|
+
This pattern is difficult to read and maintain. ${suggestion}
|
|
20
|
+
`, node.location);
|
|
21
|
+
this.visitChildNodes(node);
|
|
22
|
+
}
|
|
23
|
+
}
|
|
24
|
+
export class ERBNoConditionalHTMLElementRule extends ParserRule {
|
|
25
|
+
static ruleName = "erb-no-conditional-html-element";
|
|
26
|
+
get defaultConfig() {
|
|
27
|
+
return {
|
|
28
|
+
enabled: true,
|
|
29
|
+
severity: "error"
|
|
30
|
+
};
|
|
31
|
+
}
|
|
32
|
+
check(result, context) {
|
|
33
|
+
const visitor = new ERBNoConditionalHTMLElementRuleVisitor(this.ruleName, context);
|
|
34
|
+
visitor.visit(result.value);
|
|
35
|
+
return visitor.offenses;
|
|
36
|
+
}
|
|
37
|
+
}
|
|
38
|
+
//# sourceMappingURL=erb-no-conditional-html-element.js.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"erb-no-conditional-html-element.js","sourceRoot":"","sources":["../../src/rules/erb-no-conditional-html-element.ts"],"names":[],"mappings":"AAAA,OAAO,MAAM,MAAM,QAAQ,CAAA;AAE3B,OAAO,EAAE,UAAU,EAAE,MAAM,aAAa,CAAA;AACxC,OAAO,EAAE,eAAe,EAAE,MAAM,iBAAiB,CAAA;AAKjD,MAAM,sCAAuC,SAAQ,eAAe;IAClE,+BAA+B,CAAC,IAAgC;QAC9D,MAAM,OAAO,GAAG,IAAI,CAAC,QAAQ,EAAE,KAAK,IAAI,SAAS,CAAA;QACjD,MAAM,SAAS,GAAG,IAAI,CAAC,SAAS,IAAI,WAAW,CAAA;QAE/C,MAAM,UAAU,GAAG,MAAM,CAAA;;;;;;;cAOf,SAAS,mBAAmB,OAAO;KAC5C,CAAA;QAED,IAAI,CAAC,UAAU,CACb,MAAM,CAAA;uCAC2B,OAAO;0DACY,UAAU;OAC7D,EACD,IAAI,CAAC,QAAQ,CACd,CAAA;QAED,IAAI,CAAC,eAAe,CAAC,IAAI,CAAC,CAAA;IAC5B,CAAC;CACF;AAED,MAAM,OAAO,+BAAgC,SAAQ,UAAU;IAC7D,MAAM,CAAC,QAAQ,GAAG,iCAAiC,CAAA;IAEnD,IAAI,aAAa;QACf,OAAO;YACL,OAAO,EAAE,IAAI;YACb,QAAQ,EAAE,OAAO;SAClB,CAAA;IACH,CAAC;IAED,KAAK,CAAC,MAAmB,EAAE,OAA8B;QACvD,MAAM,OAAO,GAAG,IAAI,sCAAsC,CAAC,IAAI,CAAC,QAAQ,EAAE,OAAO,CAAC,CAAA;QAElF,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,KAAK,CAAC,CAAA;QAE3B,OAAO,OAAO,CAAC,QAAQ,CAAA;IACzB,CAAC"}
|
|
@@ -0,0 +1,24 @@
|
|
|
1
|
+
import { ParserRule } from "../types.js";
|
|
2
|
+
import { BaseRuleVisitor } from "./rule-utils.js";
|
|
3
|
+
class ERBNoConditionalOpenTagRuleVisitor extends BaseRuleVisitor {
|
|
4
|
+
visitHTMLConditionalOpenTagNode(node) {
|
|
5
|
+
const tagName = node.tag_name?.value || "element";
|
|
6
|
+
this.addOffense(`Avoid using ERB conditionals to split the open and closing tag of \`<${tagName}>\` element.`, node.location);
|
|
7
|
+
this.visitChildNodes(node);
|
|
8
|
+
}
|
|
9
|
+
}
|
|
10
|
+
export class ERBNoConditionalOpenTagRule extends ParserRule {
|
|
11
|
+
static ruleName = "erb-no-conditional-open-tag";
|
|
12
|
+
get defaultConfig() {
|
|
13
|
+
return {
|
|
14
|
+
enabled: true,
|
|
15
|
+
severity: "error"
|
|
16
|
+
};
|
|
17
|
+
}
|
|
18
|
+
check(result, context) {
|
|
19
|
+
const visitor = new ERBNoConditionalOpenTagRuleVisitor(this.ruleName, context);
|
|
20
|
+
visitor.visit(result.value);
|
|
21
|
+
return visitor.offenses;
|
|
22
|
+
}
|
|
23
|
+
}
|
|
24
|
+
//# sourceMappingURL=erb-no-conditional-open-tag.js.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"erb-no-conditional-open-tag.js","sourceRoot":"","sources":["../../src/rules/erb-no-conditional-open-tag.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,UAAU,EAAE,MAAM,aAAa,CAAA;AACxC,OAAO,EAAE,eAAe,EAAE,MAAM,iBAAiB,CAAA;AAKjD,MAAM,kCAAmC,SAAQ,eAAe;IAC9D,+BAA+B,CAAC,IAAgC;QAC9D,MAAM,OAAO,GAAG,IAAI,CAAC,QAAQ,EAAE,KAAK,IAAI,SAAS,CAAA;QAEjD,IAAI,CAAC,UAAU,CACb,wEAAwE,OAAO,cAAc,EAC7F,IAAI,CAAC,QAAQ,CACd,CAAA;QAED,IAAI,CAAC,eAAe,CAAC,IAAI,CAAC,CAAA;IAC5B,CAAC;CACF;AAED,MAAM,OAAO,2BAA4B,SAAQ,UAAU;IACzD,MAAM,CAAC,QAAQ,GAAG,6BAA6B,CAAA;IAE/C,IAAI,aAAa;QACf,OAAO;YACL,OAAO,EAAE,IAAI;YACb,QAAQ,EAAE,OAAO;SAClB,CAAA;IACH,CAAC;IAED,KAAK,CAAC,MAAmB,EAAE,OAA8B;QACvD,MAAM,OAAO,GAAG,IAAI,kCAAkC,CAAC,IAAI,CAAC,QAAQ,EAAE,OAAO,CAAC,CAAA;QAE9E,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,KAAK,CAAC,CAAA;QAE3B,OAAO,OAAO,CAAC,QAAQ,CAAA;IACzB,CAAC"}
|
|
@@ -0,0 +1,245 @@
|
|
|
1
|
+
import { ParserRule } from "../types.js";
|
|
2
|
+
import { BaseRuleVisitor } from "./rule-utils.js";
|
|
3
|
+
import { IdentityPrinter } from "@herb-tools/printer";
|
|
4
|
+
import { isHTMLElementNode, isERBIfNode, isERBElseNode, isERBUnlessNode, isERBCaseNode, isERBWhenNode, isEquivalentElement, isPureWhitespaceNode, findParentArray, removeNodeFromArray, replaceNodeWithBody, createLiteral, HTMLElementNode, Location, } from "@herb-tools/core";
|
|
5
|
+
function getSignificantNodes(statements) {
|
|
6
|
+
return statements.filter(node => !isPureWhitespaceNode(node));
|
|
7
|
+
}
|
|
8
|
+
function allEquivalentElements(nodes) {
|
|
9
|
+
if (nodes.length < 2)
|
|
10
|
+
return false;
|
|
11
|
+
if (!nodes.every(node => isHTMLElementNode(node)))
|
|
12
|
+
return false;
|
|
13
|
+
const first = nodes[0];
|
|
14
|
+
return nodes.slice(1).every(node => isEquivalentElement(first, node));
|
|
15
|
+
}
|
|
16
|
+
function collectBranchesFromIf(node) {
|
|
17
|
+
const branches = [];
|
|
18
|
+
let current = node.subsequent;
|
|
19
|
+
branches.push(node.statements);
|
|
20
|
+
while (current) {
|
|
21
|
+
if (isERBElseNode(current)) {
|
|
22
|
+
branches.push(current.statements);
|
|
23
|
+
return branches;
|
|
24
|
+
}
|
|
25
|
+
if (isERBIfNode(current)) {
|
|
26
|
+
branches.push(current.statements);
|
|
27
|
+
current = current.subsequent;
|
|
28
|
+
}
|
|
29
|
+
else {
|
|
30
|
+
break;
|
|
31
|
+
}
|
|
32
|
+
}
|
|
33
|
+
return null;
|
|
34
|
+
}
|
|
35
|
+
function collectBranchesFromUnless(node) {
|
|
36
|
+
if (!node.else_clause)
|
|
37
|
+
return null;
|
|
38
|
+
return [node.statements, node.else_clause.statements];
|
|
39
|
+
}
|
|
40
|
+
function collectBranchesFromCase(node) {
|
|
41
|
+
if (!node.else_clause)
|
|
42
|
+
return null;
|
|
43
|
+
const branches = [];
|
|
44
|
+
for (const condition of node.conditions) {
|
|
45
|
+
if (isERBWhenNode(condition)) {
|
|
46
|
+
branches.push(condition.statements);
|
|
47
|
+
}
|
|
48
|
+
}
|
|
49
|
+
branches.push(node.else_clause.statements);
|
|
50
|
+
return branches;
|
|
51
|
+
}
|
|
52
|
+
function collectBranches(node) {
|
|
53
|
+
if (isERBIfNode(node))
|
|
54
|
+
return collectBranchesFromIf(node);
|
|
55
|
+
if (isERBUnlessNode(node))
|
|
56
|
+
return collectBranchesFromUnless(node);
|
|
57
|
+
if (isERBCaseNode(node))
|
|
58
|
+
return collectBranchesFromCase(node);
|
|
59
|
+
return null;
|
|
60
|
+
}
|
|
61
|
+
function findCommonPrefixCount(branches, minLength) {
|
|
62
|
+
let count = 0;
|
|
63
|
+
for (let index = 0; index < minLength; index++) {
|
|
64
|
+
const nodesAtIndex = branches.map(branch => branch[index]);
|
|
65
|
+
if (allEquivalentElements(nodesAtIndex)) {
|
|
66
|
+
count++;
|
|
67
|
+
}
|
|
68
|
+
else {
|
|
69
|
+
break;
|
|
70
|
+
}
|
|
71
|
+
}
|
|
72
|
+
return count;
|
|
73
|
+
}
|
|
74
|
+
function findCommonSuffixCount(branches, minLength, prefixCount) {
|
|
75
|
+
let count = 0;
|
|
76
|
+
for (let offset = 0; offset < minLength - prefixCount; offset++) {
|
|
77
|
+
const nodesAtOffset = branches.map(branch => branch[branch.length - 1 - offset]);
|
|
78
|
+
if (allEquivalentElements(nodesAtOffset)) {
|
|
79
|
+
count++;
|
|
80
|
+
}
|
|
81
|
+
else {
|
|
82
|
+
break;
|
|
83
|
+
}
|
|
84
|
+
}
|
|
85
|
+
return count;
|
|
86
|
+
}
|
|
87
|
+
function createWrapper(template, body) {
|
|
88
|
+
return new HTMLElementNode({
|
|
89
|
+
type: "AST_HTML_ELEMENT_NODE",
|
|
90
|
+
open_tag: template.open_tag,
|
|
91
|
+
tag_name: template.tag_name,
|
|
92
|
+
body,
|
|
93
|
+
close_tag: template.close_tag,
|
|
94
|
+
is_void: template.is_void,
|
|
95
|
+
element_source: template.element_source,
|
|
96
|
+
location: Location.zero,
|
|
97
|
+
errors: [],
|
|
98
|
+
});
|
|
99
|
+
}
|
|
100
|
+
class ERBNoDuplicateBranchElementsVisitor extends BaseRuleVisitor {
|
|
101
|
+
processedIfNodes = new Set();
|
|
102
|
+
visitERBIfNode(node) {
|
|
103
|
+
if (this.processedIfNodes.has(node)) {
|
|
104
|
+
this.visitChildNodes(node);
|
|
105
|
+
return;
|
|
106
|
+
}
|
|
107
|
+
this.checkConditionalNode(node);
|
|
108
|
+
this.visitChildNodes(node);
|
|
109
|
+
}
|
|
110
|
+
visitERBUnlessNode(node) {
|
|
111
|
+
this.checkConditionalNode(node);
|
|
112
|
+
this.visitChildNodes(node);
|
|
113
|
+
}
|
|
114
|
+
visitERBCaseNode(node) {
|
|
115
|
+
this.checkConditionalNode(node);
|
|
116
|
+
this.visitChildNodes(node);
|
|
117
|
+
}
|
|
118
|
+
checkConditionalNode(node) {
|
|
119
|
+
const branches = collectBranches(node);
|
|
120
|
+
if (!branches)
|
|
121
|
+
return;
|
|
122
|
+
if (isERBIfNode(node)) {
|
|
123
|
+
this.markSubsequentIfNodesAsProcessed(node);
|
|
124
|
+
}
|
|
125
|
+
const state = { isFirstOffense: true };
|
|
126
|
+
this.checkBranches(branches, node, state);
|
|
127
|
+
}
|
|
128
|
+
markSubsequentIfNodesAsProcessed(node) {
|
|
129
|
+
let current = node.subsequent;
|
|
130
|
+
while (current) {
|
|
131
|
+
if (isERBIfNode(current)) {
|
|
132
|
+
this.processedIfNodes.add(current);
|
|
133
|
+
current = current.subsequent;
|
|
134
|
+
}
|
|
135
|
+
else {
|
|
136
|
+
break;
|
|
137
|
+
}
|
|
138
|
+
}
|
|
139
|
+
}
|
|
140
|
+
checkBranches(branches, conditionalNode, state) {
|
|
141
|
+
const significantBranches = branches.map(getSignificantNodes);
|
|
142
|
+
if (significantBranches.some(branch => branch.length === 0))
|
|
143
|
+
return;
|
|
144
|
+
const minLength = Math.min(...significantBranches.map(branch => branch.length));
|
|
145
|
+
const prefixCount = findCommonPrefixCount(significantBranches, minLength);
|
|
146
|
+
const suffixCount = findCommonSuffixCount(significantBranches, minLength, prefixCount);
|
|
147
|
+
for (let index = 0; index < prefixCount; index++) {
|
|
148
|
+
const elements = significantBranches.map(branch => branch[index]);
|
|
149
|
+
this.reportAndRecurse(elements, conditionalNode, state);
|
|
150
|
+
}
|
|
151
|
+
for (let offset = 0; offset < suffixCount; offset++) {
|
|
152
|
+
const elements = significantBranches.map(branch => branch[branch.length - 1 - offset]);
|
|
153
|
+
this.reportAndRecurse(elements, conditionalNode, state);
|
|
154
|
+
}
|
|
155
|
+
}
|
|
156
|
+
reportAndRecurse(elements, conditionalNode, state) {
|
|
157
|
+
const bodies = elements.map(element => element.body);
|
|
158
|
+
const bodiesMatch = elements.every(element => IdentityPrinter.print(element) === IdentityPrinter.print(elements[0]));
|
|
159
|
+
for (const element of elements) {
|
|
160
|
+
const printed = IdentityPrinter.print(element.open_tag);
|
|
161
|
+
const autofixContext = state.isFirstOffense
|
|
162
|
+
? { node: conditionalNode }
|
|
163
|
+
: undefined;
|
|
164
|
+
this.addOffense(`The \`${printed}\` element is duplicated across all branches of this conditional and can be moved outside.`, bodiesMatch ? element.location : (element?.open_tag?.location || element.location), autofixContext);
|
|
165
|
+
state.isFirstOffense = false;
|
|
166
|
+
}
|
|
167
|
+
if (!bodiesMatch && bodies.every(body => body.length > 0)) {
|
|
168
|
+
this.checkBranches(bodies, conditionalNode, state);
|
|
169
|
+
}
|
|
170
|
+
}
|
|
171
|
+
}
|
|
172
|
+
export class ERBNoDuplicateBranchElementsRule extends ParserRule {
|
|
173
|
+
static ruleName = "erb-no-duplicate-branch-elements";
|
|
174
|
+
static autocorrectable = true;
|
|
175
|
+
static reindentAfterAutofix = true;
|
|
176
|
+
get defaultConfig() {
|
|
177
|
+
return {
|
|
178
|
+
enabled: true,
|
|
179
|
+
severity: "warning",
|
|
180
|
+
};
|
|
181
|
+
}
|
|
182
|
+
check(result, context) {
|
|
183
|
+
const visitor = new ERBNoDuplicateBranchElementsVisitor(this.ruleName, context);
|
|
184
|
+
visitor.visit(result.value);
|
|
185
|
+
return visitor.offenses;
|
|
186
|
+
}
|
|
187
|
+
autofix(offense, result) {
|
|
188
|
+
if (!offense.autofixContext)
|
|
189
|
+
return null;
|
|
190
|
+
const conditionalNode = offense.autofixContext.node;
|
|
191
|
+
const branches = collectBranches(conditionalNode);
|
|
192
|
+
if (!branches)
|
|
193
|
+
return null;
|
|
194
|
+
const significantBranches = branches.map(getSignificantNodes);
|
|
195
|
+
if (significantBranches.some(branch => branch.length === 0))
|
|
196
|
+
return null;
|
|
197
|
+
const minLength = Math.min(...significantBranches.map(branch => branch.length));
|
|
198
|
+
const prefixCount = findCommonPrefixCount(significantBranches, minLength);
|
|
199
|
+
const suffixCount = findCommonSuffixCount(significantBranches, minLength, prefixCount);
|
|
200
|
+
if (prefixCount === 0 && suffixCount === 0)
|
|
201
|
+
return null;
|
|
202
|
+
const parentInfo = findParentArray(result.value, conditionalNode);
|
|
203
|
+
if (!parentInfo)
|
|
204
|
+
return null;
|
|
205
|
+
let { array: parentArray, index: conditionalIndex } = parentInfo;
|
|
206
|
+
let hasWrapped = false;
|
|
207
|
+
const hoistElement = (elements, position) => {
|
|
208
|
+
const bodiesMatch = elements.every(element => IdentityPrinter.print(element) === IdentityPrinter.print(elements[0]));
|
|
209
|
+
if (bodiesMatch) {
|
|
210
|
+
for (let i = 0; i < branches.length; i++) {
|
|
211
|
+
removeNodeFromArray(branches[i], elements[i]);
|
|
212
|
+
}
|
|
213
|
+
if (position === "before") {
|
|
214
|
+
parentArray.splice(conditionalIndex, 0, elements[0]);
|
|
215
|
+
conditionalIndex++;
|
|
216
|
+
}
|
|
217
|
+
else {
|
|
218
|
+
parentArray.splice(conditionalIndex + 1, 0, elements[0]);
|
|
219
|
+
}
|
|
220
|
+
}
|
|
221
|
+
else {
|
|
222
|
+
if (hasWrapped)
|
|
223
|
+
return;
|
|
224
|
+
for (let i = 0; i < branches.length; i++) {
|
|
225
|
+
replaceNodeWithBody(branches[i], elements[i]);
|
|
226
|
+
}
|
|
227
|
+
const wrapper = createWrapper(elements[0], [createLiteral("\n"), conditionalNode, createLiteral("\n")]);
|
|
228
|
+
parentArray[conditionalIndex] = wrapper;
|
|
229
|
+
parentArray = wrapper.body;
|
|
230
|
+
conditionalIndex = 1;
|
|
231
|
+
hasWrapped = true;
|
|
232
|
+
}
|
|
233
|
+
};
|
|
234
|
+
for (let index = 0; index < prefixCount; index++) {
|
|
235
|
+
const elements = significantBranches.map(branch => branch[index]);
|
|
236
|
+
hoistElement(elements, "before");
|
|
237
|
+
}
|
|
238
|
+
for (let offset = 0; offset < suffixCount; offset++) {
|
|
239
|
+
const elements = significantBranches.map(branch => branch[branch.length - 1 - offset]);
|
|
240
|
+
hoistElement(elements, "after");
|
|
241
|
+
}
|
|
242
|
+
return result;
|
|
243
|
+
}
|
|
244
|
+
}
|
|
245
|
+
//# sourceMappingURL=erb-no-duplicate-branch-elements.js.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"erb-no-duplicate-branch-elements.js","sourceRoot":"","sources":["../../src/rules/erb-no-duplicate-branch-elements.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,UAAU,EAAE,MAAM,aAAa,CAAA;AACxC,OAAO,EAAE,eAAe,EAAE,MAAM,iBAAiB,CAAA;AACjD,OAAO,EAAE,eAAe,EAAE,MAAM,qBAAqB,CAAA;AAErD,OAAO,EACL,iBAAiB,EACjB,WAAW,EACX,aAAa,EACb,eAAe,EACf,aAAa,EACb,aAAa,EACb,mBAAmB,EACnB,oBAAoB,EACpB,eAAe,EACf,mBAAmB,EACnB,mBAAmB,EACnB,aAAa,EACb,eAAe,EACf,QAAQ,GACT,MAAM,kBAAkB,CAAA;AAYzB,SAAS,mBAAmB,CAAC,UAAkB;IAC7C,OAAO,UAAU,CAAC,MAAM,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC,oBAAoB,CAAC,IAAI,CAAC,CAAC,CAAA;AAC/D,CAAC;AAED,SAAS,qBAAqB,CAAC,KAAa;IAC1C,IAAI,KAAK,CAAC,MAAM,GAAG,CAAC;QAAE,OAAO,KAAK,CAAA;IAClC,IAAI,CAAC,KAAK,CAAC,KAAK,CAAC,IAAI,CAAC,EAAE,CAAC,iBAAiB,CAAC,IAAI,CAAC,CAAC;QAAE,OAAO,KAAK,CAAA;IAE/D,MAAM,KAAK,GAAG,KAAK,CAAC,CAAC,CAAC,CAAA;IAEtB,OAAO,KAAK,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC,IAAI,CAAC,EAAE,CAAC,mBAAmB,CAAC,KAAK,EAAE,IAAuB,CAAC,CAAC,CAAA;AAC1F,CAAC;AAED,SAAS,qBAAqB,CAAC,IAAe;IAC5C,MAAM,QAAQ,GAAa,EAAE,CAAA;IAC7B,IAAI,OAAO,GAAmC,IAAI,CAAC,UAAU,CAAA;IAE7D,QAAQ,CAAC,IAAI,CAAC,IAAI,CAAC,UAAU,CAAC,CAAA;IAE9B,OAAO,OAAO,EAAE,CAAC;QACf,IAAI,aAAa,CAAC,OAAO,CAAC,EAAE,CAAC;YAC3B,QAAQ,CAAC,IAAI,CAAC,OAAO,CAAC,UAAU,CAAC,CAAA;YACjC,OAAO,QAAQ,CAAA;QACjB,CAAC;QAED,IAAI,WAAW,CAAC,OAAO,CAAC,EAAE,CAAC;YACzB,QAAQ,CAAC,IAAI,CAAC,OAAO,CAAC,UAAU,CAAC,CAAA;YACjC,OAAO,GAAG,OAAO,CAAC,UAAU,CAAA;QAC9B,CAAC;aAAM,CAAC;YACN,MAAK;QACP,CAAC;IACH,CAAC;IAED,OAAO,IAAI,CAAA;AACb,CAAC;AAED,SAAS,yBAAyB,CAAC,IAAmB;IACpD,IAAI,CAAC,IAAI,CAAC,WAAW;QAAE,OAAO,IAAI,CAAA;IAElC,OAAO,CAAC,IAAI,CAAC,UAAU,EAAE,IAAI,CAAC,WAAW,CAAC,UAAU,CAAC,CAAA;AACvD,CAAC;AAED,SAAS,uBAAuB,CAAC,IAAiB;IAChD,IAAI,CAAC,IAAI,CAAC,WAAW;QAAE,OAAO,IAAI,CAAA;IAElC,MAAM,QAAQ,GAAa,EAAE,CAAA;IAE7B,KAAK,MAAM,SAAS,IAAI,IAAI,CAAC,UAAU,EAAE,CAAC;QACxC,IAAI,aAAa,CAAC,SAAS,CAAC,EAAE,CAAC;YAC7B,QAAQ,CAAC,IAAI,CAAC,SAAS,CAAC,UAAU,CAAC,CAAA;QACrC,CAAC;IACH,CAAC;IAED,QAAQ,CAAC,IAAI,CAAC,IAAI,CAAC,WAAW,CAAC,UAAU,CAAC,CAAA;IAE1C,OAAO,QAAQ,CAAA;AACjB,CAAC;AAED,SAAS,eAAe,CAAC,IAAqB;IAC5C,IAAI,WAAW,CAAC,IAAI,CAAC;QAAE,OAAO,qBAAqB,CAAC,IAAI,CAAC,CAAA;IACzD,IAAI,eAAe,CAAC,IAAI,CAAC;QAAE,OAAO,yBAAyB,CAAC,IAAI,CAAC,CAAA;IACjE,IAAI,aAAa,CAAC,IAAI,CAAC;QAAE,OAAO,uBAAuB,CAAC,IAAI,CAAC,CAAA;IAE7D,OAAO,IAAI,CAAA;AACb,CAAC;AAED,SAAS,qBAAqB,CAAC,QAAkB,EAAE,SAAiB;IAClE,IAAI,KAAK,GAAG,CAAC,CAAA;IAEb,KAAK,IAAI,KAAK,GAAG,CAAC,EAAE,KAAK,GAAG,SAAS,EAAE,KAAK,EAAE,EAAE,CAAC;QAC/C,MAAM,YAAY,GAAG,QAAQ,CAAC,GAAG,CAAC,MAAM,CAAC,EAAE,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,CAAA;QAE1D,IAAI,qBAAqB,CAAC,YAAY,CAAC,EAAE,CAAC;YACxC,KAAK,EAAE,CAAA;QACT,CAAC;aAAM,CAAC;YACN,MAAK;QACP,CAAC;IACH,CAAC;IAED,OAAO,KAAK,CAAA;AACd,CAAC;AAED,SAAS,qBAAqB,CAAC,QAAkB,EAAE,SAAiB,EAAE,WAAmB;IACvF,IAAI,KAAK,GAAG,CAAC,CAAA;IAEb,KAAK,IAAI,MAAM,GAAG,CAAC,EAAE,MAAM,GAAG,SAAS,GAAG,WAAW,EAAE,MAAM,EAAE,EAAE,CAAC;QAChE,MAAM,aAAa,GAAG,QAAQ,CAAC,GAAG,CAAC,MAAM,CAAC,EAAE,CAAC,MAAM,CAAC,MAAM,CAAC,MAAM,GAAG,CAAC,GAAG,MAAM,CAAC,CAAC,CAAA;QAEhF,IAAI,qBAAqB,CAAC,aAAa,CAAC,EAAE,CAAC;YACzC,KAAK,EAAE,CAAA;QACT,CAAC;aAAM,CAAC;YACN,MAAK;QACP,CAAC;IACH,CAAC;IAED,OAAO,KAAK,CAAA;AACd,CAAC;AAED,SAAS,aAAa,CAAC,QAAyB,EAAE,IAAY;IAC5D,OAAO,IAAI,eAAe,CAAC;QACzB,IAAI,EAAE,uBAAuB;QAC7B,QAAQ,EAAE,QAAQ,CAAC,QAAQ;QAC3B,QAAQ,EAAE,QAAQ,CAAC,QAAQ;QAC3B,IAAI;QACJ,SAAS,EAAE,QAAQ,CAAC,SAAS;QAC7B,OAAO,EAAE,QAAQ,CAAC,OAAO;QACzB,cAAc,EAAE,QAAQ,CAAC,cAAc;QACvC,QAAQ,EAAE,QAAQ,CAAC,IAAI;QACvB,MAAM,EAAE,EAAE;KACX,CAAC,CAAA;AACJ,CAAC;AAED,MAAM,mCAAoC,SAAQ,eAA8C;IACtF,gBAAgB,GAAG,IAAI,GAAG,EAAQ,CAAA;IAE1C,cAAc,CAAC,IAAe;QAC5B,IAAI,IAAI,CAAC,gBAAgB,CAAC,GAAG,CAAC,IAAI,CAAC,EAAE,CAAC;YACpC,IAAI,CAAC,eAAe,CAAC,IAAI,CAAC,CAAA;YAC1B,OAAM;QACR,CAAC;QAED,IAAI,CAAC,oBAAoB,CAAC,IAAI,CAAC,CAAA;QAC/B,IAAI,CAAC,eAAe,CAAC,IAAI,CAAC,CAAA;IAC5B,CAAC;IAED,kBAAkB,CAAC,IAAmB;QACpC,IAAI,CAAC,oBAAoB,CAAC,IAAI,CAAC,CAAA;QAC/B,IAAI,CAAC,eAAe,CAAC,IAAI,CAAC,CAAA;IAC5B,CAAC;IAED,gBAAgB,CAAC,IAAiB;QAChC,IAAI,CAAC,oBAAoB,CAAC,IAAI,CAAC,CAAA;QAC/B,IAAI,CAAC,eAAe,CAAC,IAAI,CAAC,CAAA;IAC5B,CAAC;IAEO,oBAAoB,CAAC,IAAqB;QAChD,MAAM,QAAQ,GAAG,eAAe,CAAC,IAAI,CAAC,CAAA;QACtC,IAAI,CAAC,QAAQ;YAAE,OAAM;QAErB,IAAI,WAAW,CAAC,IAAI,CAAC,EAAE,CAAC;YACtB,IAAI,CAAC,gCAAgC,CAAC,IAAI,CAAC,CAAA;QAC7C,CAAC;QAED,MAAM,KAAK,GAAG,EAAE,cAAc,EAAE,IAAI,EAAE,CAAA;QACtC,IAAI,CAAC,aAAa,CAAC,QAAQ,EAAE,IAAI,EAAE,KAAK,CAAC,CAAA;IAC3C,CAAC;IAEO,gCAAgC,CAAC,IAAe;QACtD,IAAI,OAAO,GAAmC,IAAI,CAAC,UAAU,CAAA;QAE7D,OAAO,OAAO,EAAE,CAAC;YACf,IAAI,WAAW,CAAC,OAAO,CAAC,EAAE,CAAC;gBACzB,IAAI,CAAC,gBAAgB,CAAC,GAAG,CAAC,OAAO,CAAC,CAAA;gBAClC,OAAO,GAAG,OAAO,CAAC,UAAU,CAAA;YAC9B,CAAC;iBAAM,CAAC;gBACN,MAAK;YACP,CAAC;QACH,CAAC;IACH,CAAC;IAEO,aAAa,CAAC,QAAkB,EAAE,eAAgC,EAAE,KAAkC;QAC5G,MAAM,mBAAmB,GAAG,QAAQ,CAAC,GAAG,CAAC,mBAAmB,CAAC,CAAA;QAC7D,IAAI,mBAAmB,CAAC,IAAI,CAAC,MAAM,CAAC,EAAE,CAAC,MAAM,CAAC,MAAM,KAAK,CAAC,CAAC;YAAE,OAAM;QAEnE,MAAM,SAAS,GAAG,IAAI,CAAC,GAAG,CAAC,GAAG,mBAAmB,CAAC,GAAG,CAAC,MAAM,CAAC,EAAE,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,CAAA;QAC/E,MAAM,WAAW,GAAG,qBAAqB,CAAC,mBAAmB,EAAE,SAAS,CAAC,CAAA;QACzE,MAAM,WAAW,GAAG,qBAAqB,CAAC,mBAAmB,EAAE,SAAS,EAAE,WAAW,CAAC,CAAA;QAEtF,KAAK,IAAI,KAAK,GAAG,CAAC,EAAE,KAAK,GAAG,WAAW,EAAE,KAAK,EAAE,EAAE,CAAC;YACjD,MAAM,QAAQ,GAAG,mBAAmB,CAAC,GAAG,CAAC,MAAM,CAAC,EAAE,CAAC,MAAM,CAAC,KAAK,CAAoB,CAAC,CAAA;YACpF,IAAI,CAAC,gBAAgB,CAAC,QAAQ,EAAE,eAAe,EAAE,KAAK,CAAC,CAAA;QACzD,CAAC;QAED,KAAK,IAAI,MAAM,GAAG,CAAC,EAAE,MAAM,GAAG,WAAW,EAAE,MAAM,EAAE,EAAE,CAAC;YACpD,MAAM,QAAQ,GAAG,mBAAmB,CAAC,GAAG,CAAC,MAAM,CAAC,EAAE,CAAC,MAAM,CAAC,MAAM,CAAC,MAAM,GAAG,CAAC,GAAG,MAAM,CAAoB,CAAC,CAAA;YACzG,IAAI,CAAC,gBAAgB,CAAC,QAAQ,EAAE,eAAe,EAAE,KAAK,CAAC,CAAA;QACzD,CAAC;IACH,CAAC;IAEO,gBAAgB,CAAC,QAA2B,EAAE,eAAgC,EAAE,KAAkC;QACxH,MAAM,MAAM,GAAG,QAAQ,CAAC,GAAG,CAAC,OAAO,CAAC,EAAE,CAAC,OAAO,CAAC,IAAI,CAAC,CAAA;QACpD,MAAM,WAAW,GAAG,QAAQ,CAAC,KAAK,CAAC,OAAO,CAAC,EAAE,CAAC,eAAe,CAAC,KAAK,CAAC,OAAO,CAAC,KAAK,eAAe,CAAC,KAAK,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,CAAC,CAAA;QAEpH,KAAK,MAAM,OAAO,IAAI,QAAQ,EAAE,CAAC;YAC/B,MAAM,OAAO,GAAG,eAAe,CAAC,KAAK,CAAC,OAAO,CAAC,QAAQ,CAAC,CAAA;YACvD,MAAM,cAAc,GAAG,KAAK,CAAC,cAAc;gBACzC,CAAC,CAAC,EAAE,IAAI,EAAE,eAA2C,EAAE;gBACvD,CAAC,CAAC,SAAS,CAAA;YAEb,IAAI,CAAC,UAAU,CACb,SAAS,OAAO,4FAA4F,EAC5G,WAAW,CAAC,CAAC,CAAC,OAAO,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,OAAO,EAAE,QAAQ,EAAE,QAAQ,IAAI,OAAO,CAAC,QAAQ,CAAC,EAClF,cAAc,CACf,CAAA;YAED,KAAK,CAAC,cAAc,GAAG,KAAK,CAAA;QAC9B,CAAC;QAED,IAAI,CAAC,WAAW,IAAI,MAAM,CAAC,KAAK,CAAC,IAAI,CAAC,EAAE,CAAC,IAAI,CAAC,MAAM,GAAG,CAAC,CAAC,EAAE,CAAC;YAC1D,IAAI,CAAC,aAAa,CAAC,MAAM,EAAE,eAAe,EAAE,KAAK,CAAC,CAAA;QACpD,CAAC;IACH,CAAC;CACF;AAED,MAAM,OAAO,gCAAiC,SAAQ,UAAyC;IAC7F,MAAM,CAAC,QAAQ,GAAG,kCAAkC,CAAA;IACpD,MAAM,CAAC,eAAe,GAAG,IAAI,CAAA;IAC7B,MAAM,CAAC,oBAAoB,GAAG,IAAI,CAAA;IAElC,IAAI,aAAa;QACf,OAAO;YACL,OAAO,EAAE,IAAI;YACb,QAAQ,EAAE,SAAS;SACpB,CAAA;IACH,CAAC;IAED,KAAK,CAAC,MAAmB,EAAE,OAA8B;QACvD,MAAM,OAAO,GAAG,IAAI,mCAAmC,CAAC,IAAI,CAAC,QAAQ,EAAE,OAAO,CAAC,CAAA;QAE/E,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,KAAK,CAAC,CAAA;QAE3B,OAAO,OAAO,CAAC,QAAQ,CAAA;IACzB,CAAC;IAED,OAAO,CAAC,OAAmD,EAAE,MAAmB;QAC9E,IAAI,CAAC,OAAO,CAAC,cAAc;YAAE,OAAO,IAAI,CAAA;QAExC,MAAM,eAAe,GAAG,OAAO,CAAC,cAAc,CAAC,IAAI,CAAA;QACnD,MAAM,QAAQ,GAAG,eAAe,CAAC,eAAkC,CAAC,CAAA;QACpE,IAAI,CAAC,QAAQ;YAAE,OAAO,IAAI,CAAA;QAE1B,MAAM,mBAAmB,GAAG,QAAQ,CAAC,GAAG,CAAC,mBAAmB,CAAC,CAAA;QAC7D,IAAI,mBAAmB,CAAC,IAAI,CAAC,MAAM,CAAC,EAAE,CAAC,MAAM,CAAC,MAAM,KAAK,CAAC,CAAC;YAAE,OAAO,IAAI,CAAA;QAExE,MAAM,SAAS,GAAG,IAAI,CAAC,GAAG,CAAC,GAAG,mBAAmB,CAAC,GAAG,CAAC,MAAM,CAAC,EAAE,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,CAAA;QAC/E,MAAM,WAAW,GAAG,qBAAqB,CAAC,mBAAmB,EAAE,SAAS,CAAC,CAAA;QACzE,MAAM,WAAW,GAAG,qBAAqB,CAAC,mBAAmB,EAAE,SAAS,EAAE,WAAW,CAAC,CAAA;QAEtF,IAAI,WAAW,KAAK,CAAC,IAAI,WAAW,KAAK,CAAC;YAAE,OAAO,IAAI,CAAA;QAEvD,MAAM,UAAU,GAAG,eAAe,CAAC,MAAM,CAAC,KAAK,EAAE,eAAkC,CAAC,CAAA;QACpF,IAAI,CAAC,UAAU;YAAE,OAAO,IAAI,CAAA;QAE5B,IAAI,EAAE,KAAK,EAAE,WAAW,EAAE,KAAK,EAAE,gBAAgB,EAAE,GAAG,UAAU,CAAA;QAChE,IAAI,UAAU,GAAG,KAAK,CAAA;QAEtB,MAAM,YAAY,GAAG,CAAC,QAA2B,EAAE,QAA4B,EAAQ,EAAE;YACvF,MAAM,WAAW,GAAG,QAAQ,CAAC,KAAK,CAAC,OAAO,CAAC,EAAE,CAAC,eAAe,CAAC,KAAK,CAAC,OAAO,CAAC,KAAK,eAAe,CAAC,KAAK,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,CAAC,CAAA;YAEpH,IAAI,WAAW,EAAE,CAAC;gBAChB,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,QAAQ,CAAC,MAAM,EAAE,CAAC,EAAE,EAAE,CAAC;oBACzC,mBAAmB,CAAC,QAAQ,CAAC,CAAC,CAAW,EAAE,QAAQ,CAAC,CAAC,CAAC,CAAC,CAAA;gBACzD,CAAC;gBAED,IAAI,QAAQ,KAAK,QAAQ,EAAE,CAAC;oBAC1B,WAAW,CAAC,MAAM,CAAC,gBAAgB,EAAE,CAAC,EAAE,QAAQ,CAAC,CAAC,CAAC,CAAC,CAAA;oBACpD,gBAAgB,EAAE,CAAA;gBACpB,CAAC;qBAAM,CAAC;oBACN,WAAW,CAAC,MAAM,CAAC,gBAAgB,GAAG,CAAC,EAAE,CAAC,EAAE,QAAQ,CAAC,CAAC,CAAC,CAAC,CAAA;gBAC1D,CAAC;YACH,CAAC;iBAAM,CAAC;gBACN,IAAI,UAAU;oBAAE,OAAM;gBAEtB,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,QAAQ,CAAC,MAAM,EAAE,CAAC,EAAE,EAAE,CAAC;oBACzC,mBAAmB,CAAC,QAAQ,CAAC,CAAC,CAAW,EAAE,QAAQ,CAAC,CAAC,CAAC,CAAC,CAAA;gBACzD,CAAC;gBAED,MAAM,OAAO,GAAG,aAAa,CAAC,QAAQ,CAAC,CAAC,CAAC,EAAE,CAAC,aAAa,CAAC,IAAI,CAAC,EAAE,eAAkC,EAAE,aAAa,CAAC,IAAI,CAAC,CAAC,CAAC,CAAA;gBAE1H,WAAW,CAAC,gBAAgB,CAAC,GAAG,OAAO,CAAA;gBACvC,WAAW,GAAG,OAAO,CAAC,IAAc,CAAA;gBACpC,gBAAgB,GAAG,CAAC,CAAA;gBACpB,UAAU,GAAG,IAAI,CAAA;YACnB,CAAC;QACH,CAAC,CAAA;QAED,KAAK,IAAI,KAAK,GAAG,CAAC,EAAE,KAAK,GAAG,WAAW,EAAE,KAAK,EAAE,EAAE,CAAC;YACjD,MAAM,QAAQ,GAAG,mBAAmB,CAAC,GAAG,CAAC,MAAM,CAAC,EAAE,CAAC,MAAM,CAAC,KAAK,CAAoB,CAAC,CAAA;YACpF,YAAY,CAAC,QAAQ,EAAE,QAAQ,CAAC,CAAA;QAClC,CAAC;QAED,KAAK,IAAI,MAAM,GAAG,CAAC,EAAE,MAAM,GAAG,WAAW,EAAE,MAAM,EAAE,EAAE,CAAC;YACpD,MAAM,QAAQ,GAAG,mBAAmB,CAAC,GAAG,CAAC,MAAM,CAAC,EAAE,CAAC,MAAM,CAAC,MAAM,CAAC,MAAM,GAAG,CAAC,GAAG,MAAM,CAAoB,CAAC,CAAA;YACzG,YAAY,CAAC,QAAQ,EAAE,OAAO,CAAC,CAAA;QACjC,CAAC;QAED,OAAO,MAAM,CAAA;IACf,CAAC"}
|
|
@@ -14,7 +14,7 @@ class ERBNoEmptyTagsVisitor extends BaseRuleVisitor {
|
|
|
14
14
|
}
|
|
15
15
|
}
|
|
16
16
|
export class ERBNoEmptyTagsRule extends ParserRule {
|
|
17
|
-
|
|
17
|
+
static ruleName = "erb-no-empty-tags";
|
|
18
18
|
get defaultConfig() {
|
|
19
19
|
return {
|
|
20
20
|
enabled: true,
|
|
@@ -22,7 +22,7 @@ export class ERBNoEmptyTagsRule extends ParserRule {
|
|
|
22
22
|
};
|
|
23
23
|
}
|
|
24
24
|
check(result, context) {
|
|
25
|
-
const visitor = new ERBNoEmptyTagsVisitor(this.
|
|
25
|
+
const visitor = new ERBNoEmptyTagsVisitor(this.ruleName, context);
|
|
26
26
|
visitor.visit(result.value);
|
|
27
27
|
return visitor.offenses;
|
|
28
28
|
}
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"erb-no-empty-tags.js","sourceRoot":"","sources":["../../src/rules/erb-no-empty-tags.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,eAAe,EAAE,MAAM,iBAAiB,CAAA;AAEjD,OAAO,EAAE,UAAU,EAAE,MAAM,aAAa,CAAA;AAIxC,MAAM,qBAAsB,SAAQ,eAAe;IACjD,mBAAmB,CAAC,IAAoB;QACtC,IAAI,CAAC,eAAe,CAAC,IAAI,CAAC,CAAA;QAE1B,MAAM,EAAE,OAAO,EAAE,WAAW,EAAE,GAAG,IAAI,CAAA;QAErC,IAAI,CAAC,OAAO;YAAE,OAAM;QACpB,IAAI,WAAW,EAAE,KAAK,KAAK,EAAE;YAAE,OAAM;QACrC,IAAI,OAAO,CAAC,KAAK,CAAC,IAAI,EAAE,CAAC,MAAM,GAAG,CAAC;YAAE,OAAM;QAE3C,IAAI,CAAC,UAAU,CACb,oEAAoE,EACpE,IAAI,CAAC,QAAQ,CACd,CAAA;IACH,CAAC;CACF;AAED,MAAM,OAAO,kBAAmB,SAAQ,UAAU;IAChD,MAAM,CAAC,QAAQ,GAAG,mBAAmB,CAAA;IAErC,IAAI,aAAa;QACf,OAAO;YACL,OAAO,EAAE,IAAI;YACb,QAAQ,EAAE,OAAO;SAClB,CAAA;IACH,CAAC;IAED,KAAK,CAAC,MAAmB,EAAE,OAA8B;QACvD,MAAM,OAAO,GAAG,IAAI,qBAAqB,CAAC,IAAI,CAAC,QAAQ,EAAE,OAAO,CAAC,CAAA;QAEjE,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,KAAK,CAAC,CAAA;QAE3B,OAAO,OAAO,CAAC,QAAQ,CAAA;IACzB,CAAC"}
|
|
@@ -1,23 +1,6 @@
|
|
|
1
|
-
import {
|
|
1
|
+
import { Location } from "@herb-tools/core";
|
|
2
|
+
import { BaseSourceRuleVisitor, positionFromOffset } from "./rule-utils.js";
|
|
2
3
|
import { SourceRule } from "../types.js";
|
|
3
|
-
import { Location, Position } from "@herb-tools/core";
|
|
4
|
-
function positionFromOffset(source, offset) {
|
|
5
|
-
let line = 1;
|
|
6
|
-
let column = 0;
|
|
7
|
-
let currentOffset = 0;
|
|
8
|
-
for (let i = 0; i < source.length && currentOffset < offset; i++) {
|
|
9
|
-
const char = source[i];
|
|
10
|
-
currentOffset++;
|
|
11
|
-
if (char === "\n") {
|
|
12
|
-
line++;
|
|
13
|
-
column = 0;
|
|
14
|
-
}
|
|
15
|
-
else {
|
|
16
|
-
column++;
|
|
17
|
-
}
|
|
18
|
-
}
|
|
19
|
-
return new Position(line, column);
|
|
20
|
-
}
|
|
21
4
|
class ERBNoExtraNewLineVisitor extends BaseSourceRuleVisitor {
|
|
22
5
|
visitSource(source) {
|
|
23
6
|
if (source.length === 0)
|
|
@@ -41,7 +24,7 @@ class ERBNoExtraNewLineVisitor extends BaseSourceRuleVisitor {
|
|
|
41
24
|
}
|
|
42
25
|
export class ERBNoExtraNewLineRule extends SourceRule {
|
|
43
26
|
static autocorrectable = true;
|
|
44
|
-
|
|
27
|
+
static ruleName = "erb-no-extra-newline";
|
|
45
28
|
get defaultConfig() {
|
|
46
29
|
return {
|
|
47
30
|
enabled: true,
|
|
@@ -49,7 +32,7 @@ export class ERBNoExtraNewLineRule extends SourceRule {
|
|
|
49
32
|
};
|
|
50
33
|
}
|
|
51
34
|
check(source, context) {
|
|
52
|
-
const visitor = new ERBNoExtraNewLineVisitor(this.
|
|
35
|
+
const visitor = new ERBNoExtraNewLineVisitor(this.ruleName, context);
|
|
53
36
|
visitor.visit(source);
|
|
54
37
|
return visitor.offenses;
|
|
55
38
|
}
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"erb-no-extra-newline.js","sourceRoot":"","sources":["../../src/rules/erb-no-extra-newline.ts"],"names":[],"mappings":"AAAA,OAAO,EAAa,QAAQ,EAAE,MAAM,kBAAkB,CAAA;AAEtD,OAAO,EAAE,qBAAqB,EAAE,kBAAkB,EAAE,MAAM,iBAAiB,CAAA;AAC3E,OAAO,EAAE,UAAU,EAAE,MAAM,aAAa,CAAA;AAQxC,MAAM,wBAAyB,SAAQ,qBAAsD;IACjF,WAAW,CAAC,MAAc;QAClC,IAAI,MAAM,CAAC,MAAM,KAAK,CAAC;YAAE,OAAM;QAE/B,MAAM,KAAK,GAAG,SAAS,CAAA;QAEvB,IAAI,KAA6B,CAAA;QAEjC,OAAO,CAAC,KAAK,GAAG,KAAK,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC,KAAK,IAAI,EAAE,CAAC;YAC7C,MAAM,WAAW,GAAG,KAAK,CAAC,KAAK,GAAG,CAAC,CAAA;YACnC,MAAM,SAAS,GAAG,KAAK,CAAC,KAAK,GAAG,KAAK,CAAC,CAAC,CAAC,CAAC,MAAM,CAAA;YAC/C,MAAM,KAAK,GAAG,kBAAkB,CAAC,MAAM,EAAE,WAAW,CAAC,CAAA;YACrD,MAAM,GAAG,GAAG,kBAAkB,CAAC,MAAM,EAAE,SAAS,CAAC,CAAA;YACjD,MAAM,QAAQ,GAAG,IAAI,QAAQ,CAAC,KAAK,EAAE,GAAG,CAAC,CAAA;YAEzC,MAAM,UAAU,GAAG,KAAK,CAAC,CAAC,CAAC,CAAC,MAAM,GAAG,CAAC,CAAA;YAEtC,IAAI,CAAC,UAAU,CACb,qCAAqC,UAAU,UAAU,UAAU,KAAK,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,OAAO,kDAAkD,EAC9I,QAAQ,EACR;gBACE,IAAI,EAAE,IAAmB;gBACzB,WAAW;gBACX,SAAS;aACV,CACF,CAAA;QACH,CAAC;IACH,CAAC;CACF;AAED,MAAM,OAAO,qBAAsB,SAAQ,UAAU;IACnD,MAAM,CAAC,eAAe,GAAG,IAAI,CAAA;IAC7B,MAAM,CAAC,QAAQ,GAAG,sBAAsB,CAAA;IAExC,IAAI,aAAa;QACf,OAAO;YACL,OAAO,EAAE,IAAI;YACb,QAAQ,EAAE,OAAO;SAClB,CAAA;IACH,CAAC;IAED,KAAK,CAAC,MAAc,EAAE,OAA8B;QAClD,MAAM,OAAO,GAAG,IAAI,wBAAwB,CAAC,IAAI,CAAC,QAAQ,EAAE,OAAO,CAAC,CAAA;QAEpE,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,CAAA;QAErB,OAAO,OAAO,CAAC,QAAQ,CAAA;IACzB,CAAC;IAED,OAAO,CAAC,OAAqD,EAAE,MAAc,EAAE,QAA+B;QAC5G,IAAI,CAAC,OAAO,CAAC,cAAc;YAAE,OAAO,IAAI,CAAA;QAExC,MAAM,EAAE,WAAW,EAAE,SAAS,EAAE,GAAG,OAAO,CAAC,cAAc,CAAA;QAEzD,MAAM,MAAM,GAAG,MAAM,CAAC,SAAS,CAAC,CAAC,EAAE,WAAW,CAAC,CAAA;QAC/C,MAAM,KAAK,GAAG,MAAM,CAAC,SAAS,CAAC,SAAS,CAAC,CAAA;QAEzC,OAAO,MAAM,GAAG,KAAK,CAAA;IACvB,CAAC"}
|
|
@@ -11,16 +11,39 @@ class ERBNoExtraWhitespaceInsideTagsVisitor extends BaseRuleVisitor {
|
|
|
11
11
|
if (this.hasExtraLeadingWhitespace(value)) {
|
|
12
12
|
this.reportWhitespace(node, openTag, closeTag, value, "start", 0, `Remove extra whitespace after \`${openTag.value}\`.`, "after-open");
|
|
13
13
|
}
|
|
14
|
-
if (openTag.value === "<%#"
|
|
15
|
-
const
|
|
16
|
-
if (
|
|
17
|
-
|
|
14
|
+
if (openTag.value === "<%#") {
|
|
15
|
+
const prefix = this.getCommentedTagPrefix(value);
|
|
16
|
+
if (prefix) {
|
|
17
|
+
const afterPrefix = value.substring(prefix.length);
|
|
18
|
+
const tag = `<%#${prefix}`;
|
|
19
|
+
const hasExtraWhitespace = afterPrefix.match(/^\s{2,}/) && !afterPrefix.startsWith(" \n") && !afterPrefix.startsWith("\n");
|
|
20
|
+
if (hasExtraWhitespace) {
|
|
21
|
+
this.reportWhitespace(node, openTag, closeTag, value, "start", prefix.length, `Remove extra whitespace after \`${tag}\`. This looks like a temporarily commented ERB tag.`, "after-comment-equals", "info");
|
|
22
|
+
}
|
|
23
|
+
else {
|
|
24
|
+
this.addOffense(`\`${tag}\` looks like a temporarily commented ERB tag.`, openTag.location, { node, openTag, closeTag, content: value, fixType: "after-comment-equals", unsafe: true }, "info");
|
|
25
|
+
}
|
|
18
26
|
}
|
|
19
27
|
}
|
|
20
28
|
if (this.hasExtraTrailingWhitespace(value)) {
|
|
21
29
|
this.reportWhitespace(node, openTag, closeTag, value, "end", 0, `Remove extra whitespace before \`${closeTag.value}\`.`, "before-close");
|
|
22
30
|
}
|
|
23
31
|
}
|
|
32
|
+
getCommentedTagPrefix(content) {
|
|
33
|
+
if (content.startsWith("graphql"))
|
|
34
|
+
return "graphql";
|
|
35
|
+
if (content.startsWith("%="))
|
|
36
|
+
return "%=";
|
|
37
|
+
if (content.startsWith("=="))
|
|
38
|
+
return "==";
|
|
39
|
+
if (content.startsWith("%"))
|
|
40
|
+
return "%";
|
|
41
|
+
if (content.startsWith("="))
|
|
42
|
+
return "=";
|
|
43
|
+
if (content.startsWith("-"))
|
|
44
|
+
return "-";
|
|
45
|
+
return null;
|
|
46
|
+
}
|
|
24
47
|
hasExtraLeadingWhitespace(content) {
|
|
25
48
|
return content.startsWith(" ") && !content.startsWith(" \n");
|
|
26
49
|
}
|
|
@@ -41,20 +64,21 @@ class ERBNoExtraWhitespaceInsideTagsVisitor extends BaseRuleVisitor {
|
|
|
41
64
|
return Location.from(contentLocation.end.line, contentLocation.end.column - length, contentLocation.end.line, contentLocation.end.column);
|
|
42
65
|
}
|
|
43
66
|
}
|
|
44
|
-
reportWhitespace(node, openTag, closeTag, content, position, offset, message, fixType) {
|
|
67
|
+
reportWhitespace(node, openTag, closeTag, content, position, offset, message, fixType, severity, unsafe) {
|
|
45
68
|
const location = this.getWhitespaceLocation(node, content, position, offset);
|
|
46
69
|
this.addOffense(message, location, {
|
|
47
70
|
node,
|
|
48
71
|
openTag,
|
|
49
72
|
closeTag,
|
|
50
73
|
content,
|
|
51
|
-
fixType
|
|
52
|
-
|
|
74
|
+
fixType,
|
|
75
|
+
unsafe,
|
|
76
|
+
}, severity);
|
|
53
77
|
}
|
|
54
78
|
}
|
|
55
79
|
export class ERBNoExtraWhitespaceRule extends ParserRule {
|
|
56
80
|
static autocorrectable = true;
|
|
57
|
-
|
|
81
|
+
static ruleName = "erb-no-extra-whitespace-inside-tags";
|
|
58
82
|
get defaultConfig() {
|
|
59
83
|
return {
|
|
60
84
|
enabled: true,
|
|
@@ -62,7 +86,7 @@ export class ERBNoExtraWhitespaceRule extends ParserRule {
|
|
|
62
86
|
};
|
|
63
87
|
}
|
|
64
88
|
check(result, context) {
|
|
65
|
-
const visitor = new ERBNoExtraWhitespaceInsideTagsVisitor(this.
|
|
89
|
+
const visitor = new ERBNoExtraWhitespaceInsideTagsVisitor(this.ruleName, context);
|
|
66
90
|
visitor.visit(result.value);
|
|
67
91
|
return visitor.offenses;
|
|
68
92
|
}
|
|
@@ -80,12 +104,14 @@ export class ERBNoExtraWhitespaceRule extends ParserRule {
|
|
|
80
104
|
case "after-open":
|
|
81
105
|
node.content.value = content.replace(/^\s{2,}/, " ");
|
|
82
106
|
break;
|
|
83
|
-
case "after-comment-equals":
|
|
84
|
-
|
|
85
|
-
|
|
86
|
-
|
|
107
|
+
case "after-comment-equals": {
|
|
108
|
+
const prefix = content.startsWith("graphql") ? "graphql" : content.startsWith("%=") ? "%=" : content.startsWith("==") ? "==" : content.startsWith("%") ? "%" : content.startsWith("=") ? "=" : content.startsWith("-") ? "-" : null;
|
|
109
|
+
if (prefix) {
|
|
110
|
+
const afterPrefix = content.substring(prefix.length);
|
|
111
|
+
node.content.value = prefix + " " + afterPrefix.replace(/^\s{2,}/, "");
|
|
87
112
|
}
|
|
88
113
|
break;
|
|
114
|
+
}
|
|
89
115
|
default:
|
|
90
116
|
return null;
|
|
91
117
|
}
|