@gloom-sh/terminal 0.18.5 → 0.19.1

package/src/portfolio/position-quantity.ts

@@ -23,21 +23,27 @@ function tradesInWholeUnits(ticker: TickerRecord): boolean {
 }
 
 /**
- * Why a typed size cannot be stored as read: a dot and three digits (`1.250`)
- * on a listing held in whole units, where it is far likelier the thousands
- * grouping many locales write (1,250 shares) than a quarter of a share, so the
- * command asks which, as it does for `1,250`. Null for any other size, and
- * for a listing that may be held in fractions, where `1.250` is 1.25.
+ * Why a typed size cannot be stored as read: a dot and three digits (`1.000`,
+ * `1.250`), which is as likely the thousands grouping many locales write
+ * (1,000 shares, as cash reads `1.000`) as a fraction of a share, so the
+ * command asks which, as it does for `1,250`. On a listing held in whole
+ * units the thousands reading is the only one that can be held, and the
+ * message says so. Null for any other size (`0.500`, `12.25`).
  */
-export function wholeUnitQuantityProblem(
+export function ambiguousQuantityProblem(
   typed: string,
   ticker: TickerRecord,
   options: { label?: PositionQuantityLabel; listing?: string } = {},
 ): string | null {
   const reading = thousandsDotReadings(typed);
-  if (!reading || !tradesInWholeUnits(ticker)) return null;
+  if (!reading) return null;
   const label = options.label ?? positionQuantityLabel(ticker);
   const listing = options.listing ?? ticker.metadata.ticker;
-  const because = `${listing} trades in whole ${label === "Contracts" ? "contracts" : "shares"}`;
-  return `${label} ${ambiguousNumberMessage(typed, reading, { because })}.`;
+  const because = tradesInWholeUnits(ticker)
+    ? `${listing} trades in whole ${label === "Contracts" ? "contracts" : "shares"}`
+    : undefined;
+  // The fraction typed so it does not read two ways itself: 1.234 asks again, 1.2340 does not.
+  const fraction = String(reading.decimal);
+  const decimalAs = thousandsDotReadings(fraction) ? `${fraction}0` : fraction;
+  return `${label} ${ambiguousNumberMessage(typed, reading, { because, decimalAs })}.`;
 }

package/src/remote/resources.ts

@@ -110,7 +110,8 @@ export function createRemoteResources({
       }));
     }
     if (resource === "app://pane-templates") {
-      return [...pluginRegistry.paneTemplates.values()].map((template) => ({
+      // An unlisted function (`listed: false`) is left out, as of every list.
+      return [...pluginRegistry.paneTemplates.values()].filter((template) => template.listed !== false).map((template) => ({
         id: template.id,
         paneId: template.paneId,
         label: template.label,

package/src/renderers/dom/data-table/row.tsx

@@ -457,6 +457,32 @@ function WebDataTableRowInner<
 
 function CellText({ cell, column, color }: { cell: DataTableCell; column: DataTableColumn; color: string }) {
   const style = clippedCellTextStyle(column, color, cell.attributes ?? TextAttributes.NONE);
+  if (cell.note) {
+    const text = (
+      <div
+        style={{
+          display: "flex",
+          flexWrap: "wrap",
+          alignContent: "flex-start",
+          justifyContent: contentJustifyForAlign(column.align),
+          columnGap: "var(--gloom-space-sm)",
+          width: "100%",
+          height: "100%",
+          minWidth: 0,
+          overflow: "hidden",
+        }}
+      >
+        <span title={cell.text} style={{ ...style, width: "auto", flex: "0 1 auto", minWidth: 0 }}>{cell.text}</span>
+        <span data-gloom-role="data-table-cell-note" style={{ ...cellTextStyle(CSS_TEXT_DIM, TextAttributes.NONE), flex: "none" }}>{cell.note}</span>
+      </div>
+    );
+    return cell.leading === undefined ? text : (
+      <div style={{ display: "flex", alignItems: "center", gap: LABEL_GAP_PX, width: "100%", height: "100%", minWidth: 0, overflow: "hidden" }}>
+        <Leading>{cell.leading}</Leading>
+        {text}
+      </div>
+    );
+  }
   if (cell.leading === undefined) return <span title={cell.text} style={style}>{cell.text}</span>;
   return (
     <div

package/src/renderers/dom/desktop/icons.tsx

@@ -165,6 +165,13 @@ const ICONS: Record<IconName, ReactNode> = {
       <path d="M7.3 2.9l1.8 1.8" stroke="currentColor" strokeWidth="1.1" />
     </>
   ),
+  // An envelope: a message written to you.
+  mail: (
+    <>
+      <rect x="1.5" y="2.75" width="9" height="6.5" rx="1.1" stroke="currentColor" strokeWidth="1.1" />
+      <path d="M2 3.4 6 6.5l4-3.1" stroke="currentColor" strokeWidth="1.1" strokeLinecap="round" strokeLinejoin="round" />
+    </>
+  ),
   restore: (
     <>
       <rect x="2" y="4" width="6" height="6" rx="0.8" stroke="currentColor" strokeWidth="1.1" />

package/src/renderers/dom/desktop/list-view.tsx

@@ -27,6 +27,7 @@ function DefaultDesktopRow({
   stacked: boolean;
 }) {
   const colors = useThemeColors();
+  if (item.kind === "heading") return <Text fg={colors.textMuted}>{item.label}</Text>;
   return (
     <Box
       flexDirection="row"
@@ -142,6 +143,7 @@ export function WebListView({
   const rowHoverBg = hoverBgColor ?? hoverBg(colors);
   const selectedItem = selectedIndex >= 0 ? items[selectedIndex] : undefined;
   const activeScrollIndex = scrollIndex ?? selectedIndex;
+  const headingAboveSelection = items[activeScrollIndex - 1]?.kind === "heading";
   const rowStride = rowHeight + rowGap;
   const tabStopIndex = selectedIndex >= 0 && items[selectedIndex] && !items[selectedIndex].disabled
     ? selectedIndex : items.findIndex((item) => !item.disabled);
@@ -176,14 +178,14 @@ export function WebListView({
     if (!scrollBox) return;
     const safeIndex = Math.min(activeScrollIndex, items.length - 1);
     const viewportHeight = Math.max(scrollBox.viewport?.height ?? 0, 1);
-    const rowTop = safeIndex * rowStride;
-    const rowBottom = rowTop + rowHeight;
+    const rowTop = Math.max(0, safeIndex - (headingAboveSelection ? 1 : 0)) * rowStride;
+    const rowBottom = safeIndex * rowStride + rowHeight;
     if (rowTop < scrollBox.scrollTop) {
       scrollBox.scrollTo(rowTop);
     } else if (rowBottom > scrollBox.scrollTop + viewportHeight) {
       scrollBox.scrollTo(rowBottom - viewportHeight);
     }
-  }, [activeScrollIndex, autoScrollToIndex, items.length, rowHeight, rowStride, scrolls]);
+  }, [activeScrollIndex, autoScrollToIndex, headingAboveSelection, items.length, rowHeight, rowStride, scrolls]);
 
   useEffect(() => {
     if (!scrolls) return;
@@ -202,7 +204,7 @@ export function WebListView({
     const list = document.getElementById(listDomId);
     const active = document.activeElement;
     if (!list || !active || !list.contains(active) || isEditableKeyboardTarget(active)) return;
-    const row = list.querySelectorAll<HTMLElement>('[role="option"]')[selectedIndex];
+    const row = list.querySelector<HTMLElement>(`[data-gloom-list-index="${selectedIndex}"]`);
     if (row && !row.contains(active)) row.focus({ preventScroll: scrolls });
   }, [listDomId, scrolls, selectedIndex]);
 
@@ -246,10 +248,11 @@ export function WebListView({
             onActivate?.(item, index);
           }}
           data-gloom-role="desktop-list-row"
-          role="option"
-          aria-selected={selected}
-          aria-disabled={disabled || undefined}
-          tabIndex={index === tabStopIndex ? 0 : -1}
+          data-gloom-list-index={index}
+          role={item.kind === "heading" ? "presentation" : "option"}
+          aria-selected={item.kind === "heading" ? undefined : selected}
+          aria-disabled={item.kind === "heading" ? undefined : disabled || undefined}
+          tabIndex={item.kind === "heading" ? undefined : index === tabStopIndex ? 0 : -1}
           onKeyDown={(event: React.KeyboardEvent<HTMLElement>) => {
             if (disabled) return;
             if (event.key === " " || (event.key === "Enter" && !checkboxRows)) {
@@ -267,8 +270,8 @@ export function WebListView({
             while (items[nextIndex]?.disabled) nextIndex += direction;
             if (!items[nextIndex]) return;
             onSelect?.(nextIndex);
-            const rows = event.currentTarget.parentElement?.querySelectorAll<HTMLElement>('[role="option"]');
-            rows?.[nextIndex]?.focus();
+            const row = event.currentTarget.parentElement?.querySelector<HTMLElement>(`[data-gloom-list-index="${nextIndex}"]`);
+            row?.focus();
           }}
           style={listRowStyle(selected, disabled, colors, selection === "frame")}
         >

package/src/renderers/dom/desktop/query-bar.tsx

@@ -1,6 +1,7 @@
 /** @jsxImportSource react */
 import { useCallback, useContext, useEffect, useLayoutEffect, useRef, useState, type CSSProperties, type ReactNode } from "react";
 import type { HostQueryBarItem, HostQueryBarProps } from "../../../ui/host";
+import { withChoiceGroupHeadings } from "../../../components/ui/choice-groups";
 import { WebPopover } from "./popover";
 import { WebMenu } from "./menu";
 import { useHorizontalOverflow } from "../host/overflow-fade";
@@ -75,15 +76,16 @@ function QueryMenu({ item, onClose }: { item: HostQueryBarItem; onClose: () => v
     <WebMenu
       label={item.label}
       selection={item.kind === "multi" ? "multi" : "single"}
-      items={item.options.map((option) => ({
+      items={withChoiceGroupHeadings(item.options.map((option) => ({
         id: option.value,
         label: option.label,
+        group: option.group,
         description: option.description,
         disabled: option.disabled,
         selected: item.kind === "select" ? option.selected : undefined,
         checked: item.kind === "multi" ? option.selected : undefined,
         color: option.color,
-      }))}
+      })))}
       onSelect={(value) => {
         item.onSelect(value);
         if (item.kind === "select") onClose();

package/src/renderers/dom/desktop/select-field.tsx

@@ -5,6 +5,7 @@ import { WEB_CELL_HEIGHT } from "../../../theme/font-scale";
 import { Box } from "../../../ui";
 import { MenuPopover } from "../../../components/ui/menu";
 import type { SelectFieldHandle, SelectFieldProps } from "../../../components/ui/select-field";
+import { withChoiceGroupHeadings } from "../../../components/ui/choice-groups";
 import { WebIcon } from "./icons";
 import { isInsideDialogSurface } from "../host/focus-scope";
 
@@ -136,13 +137,14 @@ export function WebSelectField({
         minWidth={typeof resolvedWidth === "number" ? Math.max(160, resolvedWidth) : 170}
         items={[
           ...(showUnset ? [{ id: UNSET_VALUE, label: "Unset", selected: true, disabled: true }] : []),
-          ...options.map((option) => ({
+          ...withChoiceGroupHeadings(options.map((option) => ({
             id: option.value,
             label: option.label,
+            group: option.group,
             description: option.description,
             disabled: option.disabled,
             selected: option.value === value,
-          })),
+          }))),
         ]}
         onSelect={(id) => {
           if (id !== UNSET_VALUE && id !== value) onChange(id);

package/src/renderers/dom/host/chart-surface.tsx

@@ -168,6 +168,27 @@ const ChartVectors = memo(function ChartVectors({ vectors }: { vectors: readonly
           />
         ))
         : [])}
+      {vectors.map((shape) => shape.label && shape.points[0]
+        ? (
+          <div
+            key={`${shape.id}:label`}
+            style={{
+              position: "absolute",
+              left: `${shape.points[0].x * 100}%`,
+              top: `${shape.points[0].y * 100}%`,
+              transform: "translate(2px, -100%)",
+              color: shape.color,
+              fontSize: "var(--gloom-type-caption)",
+              lineHeight: 1.2,
+              whiteSpace: "nowrap",
+              pointerEvents: "none",
+              zIndex: 10,
+            }}
+          >
+            {shape.label}
+          </div>
+        )
+        : null)}
     </>
   );
 });

package/src/renderers/electrobun/bun/desktop/app-name.ts

@@ -3,7 +3,7 @@ import { access, lstat, readFile, readlink, rename, rm, symlink } from "fs/promi
 import { basename, dirname, isAbsolute, join, relative, resolve } from "path";
 import { HOMEBREW_PREFIXES, macCommandFolders } from "../../../../updater/command-names";
 import { logFailure } from "../../../../utils/log-failure";
-import { DESKTOP_APP_IDENTIFIER, DESKTOP_APP_NAME, LEGACY_DESKTOP_APP_NAME } from "../../shared/app-name";
+import { DESKTOP_APP_NAME, isDesktopAppIdentifier, LEGACY_DESKTOP_APP_NAME } from "../../shared/app-name";
 
 /**
  * A Mac install from before the rename is `Gloomberb.app`, and its updater
@@ -171,7 +171,7 @@ export async function renameLegacyMacApp(options: MacAppNameOptions): Promise<Ma
 
   const renamed = join(dirname(bundle), APP_BUNDLE);
   const occupied = await exists(renamed);
-  if (occupied && await bundleIdentifier(renamed) !== DESKTOP_APP_IDENTIFIER) return { kind: "skipped", reason: "name-taken" };
+  if (occupied && !isDesktopAppIdentifier(await bundleIdentifier(renamed))) return { kind: "skipped", reason: "name-taken" };
   const links = await movableLinks(bundle, options);
   if (!links) return { kind: "skipped", reason: "command-folder-not-writable" };
 
@@ -209,7 +209,7 @@ export async function removeLegacyMacApp(options: MacAppNameOptions): Promise<st
   const bundle = runningBundle(options.execPath);
   if (!bundle || basename(bundle) !== APP_BUNDLE) return null;
   const legacy = join(dirname(bundle), LEGACY_APP_BUNDLE);
-  if (!(await exists(legacy)) || await bundleIdentifier(legacy) !== DESKTOP_APP_IDENTIFIER) return null;
+  if (!(await exists(legacy)) || !isDesktopAppIdentifier(await bundleIdentifier(legacy))) return null;
   if (await managedByHomebrew(options.homebrewPrefixes ?? HOMEBREW_PREFIXES)) return null;
   const links = await movableLinks(legacy, options);
   if (!links) return null;

package/src/renderers/electrobun/bun/desktop/backend.ts

@@ -16,11 +16,14 @@ import { startRemoteControlServer, type RemoteControlServer } from "../../../../
 import type { RemoteControlRequest, RemoteControlResponse } from "../../../../remote/types";
 import { installCrashReporter } from "../../../../telemetry/crash-reports";
 import { createNodeCrashReporterHost } from "../../../../telemetry/crash-reports-node";
+import { installStallReporter, parseStallEvent, recordStall } from "../../../../telemetry/stall-reports";
+import { createNodeStallReporterHost } from "../../../../telemetry/stall-reports-node";
 import { installUpdateFailureReporter, reviewLastUpdateAttempt } from "../../../../telemetry/update-failures";
 import { createNodeUpdateFailureHost } from "../../../../telemetry/update-failures-node";
 import type { AppConfig } from "../../../../types/config";
 import { linkDesktopCommands } from "../../../../updater/command-names";
 import { debugLog } from "../../../../utils/debug-log";
+import { setStallSink, startMainThreadStallMonitor } from "../../../../utils/main-thread-stall";
 import type { DesktopSharedStateSnapshot } from "../../../../types/desktop-window";
 import type {
   ContextMenuSelectMessage,
@@ -156,6 +159,10 @@ export class DesktopBackend {
       }));
       reviewLastUpdateAttempt();
       void removeUpdateAsides();
+      // Desktop has no Debug Log: freezes of this process and of its windows go to the stall log in the data folder.
+      installStallReporter(createNodeStallReporterHost({ getDataDir: () => this.config?.dataDir ?? null }));
+      setStallSink((event) => recordStall("app", event));
+      startMainThreadStallMonitor();
     }
     // The native menu shows the same accelerators the keys use, so a rebind
     // rebuilds it.
@@ -259,6 +266,10 @@ export class DesktopBackend {
           "host.restart": (message) => {
             this.restart(message);
           },
+          "runtime.stall": (message) => {
+            const event = parseStallEvent(message);
+            if (event) recordStall("window", event);
+          },
         },
       },
     });
@@ -341,16 +352,14 @@ export class DesktopBackend {
       execPath: process.execPath,
       argv: process.argv,
     });
-    try {
-      scheduleDesktopRelaunch();
-    } catch (error) {
-      this.restartInProgress = false;
-      console.error("[desktop-recovery] failed to schedule restart", summarizeError(error));
-      throw error;
-    }
-    this.detachedWindows.closeAll();
-    this.teardownServices();
-    Utils.quit();
+    scheduleDesktopRelaunch().then(
+      // As a quit does: an app whose windows are gone ends at once on Windows.
+      () => this.quit(),
+      (error: unknown) => {
+        this.restartInProgress = false;
+        console.error("[desktop-recovery] failed to schedule restart", summarizeError(error));
+      },
+    );
   }
 
   private syncConfigAccessors(): void {
@@ -555,6 +564,7 @@ export class DesktopBackend {
       case "host.exit":
       case "host.windowControl":
       case "host.windowFullscreen":
+      case "host.startWindowDrag":
       case "host.openExternal":
       case "host.copyText":
       case "host.focusWindow":
@@ -564,6 +574,7 @@ export class DesktopBackend {
       case "host.notify":
       case "host.showContextMenu":
       case "host.saveBootFrame":
+      case "host.saveViewIds":
       case "host.setAppBadge":
         return handleDesktopHostRequest(this, rpc, request);
       case "update.check":

package/src/renderers/electrobun/bun/desktop/host-requests.ts

@@ -10,9 +10,11 @@ import { safeExternalUrl } from "../../../../utils/external-url";
 import { getContextMenuRequestId, normalizeContextMenuItems } from "../context-menu/normalize";
 import { MAIN_WINDOW_RPC_KEY } from "../window/focus";
 import { applyDesktopWindowControl } from "../window/controls";
+import { startSystemWindowMove } from "../window/windows-native";
 import { saveTextFileToDownloads } from "../../../../utils/save-text-file";
 import { setAppBadge } from "./app-badge";
 import { desktopBootFramePath, saveDesktopBootFrame } from "../window/boot-frame";
+import { saveDesktopViewIds } from "./view-ids";
 import type { DesktopBackend, DesktopRpc } from "./backend";
 
 function normalizeText(value: unknown): string | undefined {
@@ -110,6 +112,13 @@ export async function handleDesktopHostRequest(
     }
     case "host.windowFullscreen":
       return isWindowFullscreen(backend, backend.rpcs.getRpcWindowKey(rpc));
+    case "host.startWindowDrag": {
+      const targetWindow = windowForRpcKey(backend, backend.rpcs.getRpcWindowKey(rpc));
+      if (!targetWindow?.ptr || !startSystemWindowMove(targetWindow.ptr)) {
+        throw new Error("This window cannot be moved by the system.");
+      }
+      return null;
+    }
     case "host.openExternal": {
       if (typeof request.payload.url !== "string") {
         throw new Error("host.openExternal requires a URL.");
@@ -162,6 +171,12 @@ export async function handleDesktopHostRequest(
         session: backend.config !== null,
       });
       return null;
+    case "host.saveViewIds":
+      // The main window's view keeps them; its popped-out panes share its storage.
+      if (backend.rpcs.getRpcWindowKey(rpc) === MAIN_WINDOW_RPC_KEY && backend.config) {
+        saveDesktopViewIds(backend.config.dataDir, request.payload.ids);
+      }
+      return null;
     case "host.setAppBadge":
       // One badge for the app, from the main window; a popped-out pane's view
       // has its own chat state and must not overwrite it.

package/src/renderers/electrobun/bun/desktop/initialization.ts

@@ -24,6 +24,7 @@ import type { CapabilityRegistry } from "../../../../capabilities";
 import { telemetryOptedOut } from "../../../../telemetry/crash-reports";
 import { describeNodeOs, readOrCreateInstallId } from "../../../../telemetry/crash-reports-node";
 import type { DesktopBackend, DesktopRpc } from "./backend";
+import { readDesktopViewIds } from "./view-ids";
 
 interface DesktopWindowTarget {
   kind: "main" | "detached";
@@ -94,6 +95,7 @@ function buildInitializationPayload(
       homeDir: homedir(),
       optedOut: telemetryOptedOut(process.env),
     },
+    viewIds: readDesktopViewIds(config.dataDir),
   };
 }