@forgeax/engine-render 0.1.20 → 0.1.23

package/src/record/skybox-post-pass.ts

@@ -2,6 +2,8 @@ import type { ResolveContext } from '@forgeax/engine-render-graph';
 import { RhiError, type RhiRenderPassEncoder, type TextureView } from '@forgeax/engine-rhi';
 import { toShared } from '@forgeax/engine-types';
 import { buildBeginRenderPassDescriptor } from '../pipeline-spec';
+import { FXAA_POST_PROCESS_ID } from '../render-contract';
+import { resolveOutputDither } from '../render-pipeline';
 import type { BloomFrameReceipts } from './frame-snapshot';
 import { getOrCreateFromChain } from './mesh-ssbo';
 import type { _InternalRenderPipelineContext } from './render-context';
@@ -579,19 +581,29 @@ export function recordFxaaPass(
     fxaaActive &&
     pipelineState.perPassResources.fxaaPipeline !== null &&
     pipelineState.perPassResources.fxaaBindGroupLayout !== null &&
-    pipelineState.perPassResources.fxaaSampler !== null
+    pipelineState.perPassResources.fxaaSampler !== null &&
+    runtime.getPostProcessParamsBuffer !== undefined
   ) {
     const inputView = resolve.resolve('ldrColor') as TextureView | undefined;
     if (inputView === undefined) return;
 
-    // Compose the 2-entry FXAA BindGroup (input texture + sampler). The
+    const fxaaParams = runtime.getPostProcessParamsBuffer(FXAA_POST_PROCESS_ID);
+    if (fxaaParams === undefined) return;
+    const params = new Float32Array(4);
+    params[0] = resolveOutputDither(c.frameState.installedPipelineConfig) ? 1 : 0;
+    const paramsWrite = runtime.device.queue.writeBuffer(fxaaParams, 0, params);
+    if (!paramsWrite.ok) throw paramsWrite.error;
+
+    // Compose the 3-entry FXAA BindGroup (input texture + sampler + params).
     // graph view identity changes when the graph reallocates on resize, so
-    // the identity-keyed cache rebuilds against the live target.
+    // the identity-keyed cache rebuilds against the live target. The params
+    // buffer is also a key so a device recovery cannot retain a bind group
+    // pointing at the retired resource.
     const fxaaBglLayout = pipelineState.perPassResources.fxaaBindGroupLayout;
     const fxaaSampler = pipelineState.perPassResources.fxaaSampler;
     const fxaaBg = getOrCreateFromChain(
       c.frameState.postProcessBgCache,
-      [inputView],
+      [inputView, fxaaParams],
       'fxaa',
       () => {
         const fxaaBgRes = runtime.device.createBindGroup({
@@ -609,6 +621,10 @@ export function recordFxaaPass(
               binding: 1,
               resource: { kind: 'sampler', value: fxaaSampler },
             },
+            {
+              binding: 2,
+              resource: { kind: 'buffer', value: { buffer: fxaaParams } },
+            },
           ],
         });
         if (!fxaaBgRes.ok) throw fxaaBgRes.error;