@event4u/agent-config 9.7.0 → 9.9.0

package/src/scripts/ai_council/orchestrator.ts

@@ -67,6 +67,7 @@ import {
 } from './prompts.js';
 import { count_dissenters, dissent_quota_met, is_near_duplicate } from './debate_gates.js';
 import { parse_stance_line, render_vote_tally, tally_stances } from './stance_tally.js';
+import { CHAIRMAN_FIELDS_ADDENDUM, render_deanonymization_block } from './blind_review.js';
 
 // ── Python-format / stdlib parity helpers ────────────────────────────────
 //
@@ -428,6 +429,20 @@ export interface ConsultOptions {
     on_stance_repair?: ((member: string) => boolean) | null;
     /** Receives each stance-repair response so the caller can account its cost. */
     on_stance_repair_result?: ((r: CouncilResponse) => void) | null;
+    /**
+     * Ü2 (road-to-council-blind-review Phase 1): per-member system-prompt
+     * suffix appended AFTER the base/advisor system prompt — e.g. a stance
+     * framing sentence from `blind_review.assign_stances`. This module stays
+     * stance-agnostic on purpose: the caller supplies plain text keyed by
+     * member name. Default `null` → byte-identical to today.
+     */
+    member_prompt_suffix?: Map<string, string> | null;
+    /**
+     * Ü2 outsider-seat ablation: member names in this set get `project: null`
+     * in their system-prompt build (question + artefact only, no project
+     * context). Default `null` → byte-identical to today.
+     */
+    no_project_context_members?: ReadonlySet<string> | null;
 }
 
 /**
@@ -514,6 +529,8 @@ export function consult(
             project,
             original_ask,
             advisor_plans,
+            member_prompt_suffix: opts.member_prompt_suffix ?? null,
+            no_project_context_members: opts.no_project_context_members ?? null,
             split: suffix_for_round
                 ? { stable: question.user_prompt, suffix: suffix_for_round }
                 : null,
@@ -589,6 +606,10 @@ interface RunRoundOptions {
      * full concatenation (estimates + persistence unchanged).
      */
     split?: { stable: string; suffix: string } | null;
+    /** Ü2 — see `ConsultOptions.member_prompt_suffix`. */
+    member_prompt_suffix?: Map<string, string> | null;
+    /** Ü2 — see `ConsultOptions.no_project_context_members`. */
+    no_project_context_members?: ReadonlySet<string> | null;
 }
 
 /** Run a single round; mutate `spent` with cumulative totals. */
@@ -604,6 +625,8 @@ function _run_round(
     const project = opts.project;
     const original_ask = opts.original_ask;
     const plans = opts.advisor_plans ?? new Map<string, AdvisorPlan>();
+    const member_prompt_suffix = opts.member_prompt_suffix ?? null;
+    const no_project_context_members = opts.no_project_context_members ?? null;
     const base_system_prompt = system_prompt_for(question.mode, {
         project,
         original_ask,
@@ -611,10 +634,22 @@ function _run_round(
 
     const _system_prompt_for_member = (m: ExternalAIClient): string => {
         const plan = plans.get(m.name);
+        // Ü2 outsider-seat ablation: this member's system prompt is built
+        // WITHOUT project context (question + artefact only). Everyone else
+        // is unaffected — `use_project === project` short-circuits back to
+        // the precomputed `base_system_prompt` when no set is provided.
+        const use_project = no_project_context_members?.has(m.name) ? null : project;
+        let base: string;
         if (plan === undefined) {
-            return base_system_prompt;
+            base =
+                use_project === project
+                    ? base_system_prompt
+                    : system_prompt_for(question.mode, { project: use_project, original_ask });
+        } else {
+            base = advisor_system_prompt(plan.persona_text, { project: use_project, original_ask });
         }
-        return advisor_system_prompt(plan.persona_text, { project, original_ask });
+        const suffix = member_prompt_suffix?.get(m.name);
+        return suffix ? `${base}\n\n${suffix}` : base;
     };
 
     const results: CouncilResponse[] = [];
@@ -1716,6 +1751,21 @@ export interface RenderOptions {
      * slot, prefixed by the visible annotation. Absent/null → byte-identical.
      */
     chairman?: { member: string | null; annotation: string; text: string | null } | null;
+    /**
+     * Ü3 (road-to-council-blind-review Phase 1): when true, the synthesis
+     * template gains the two mandatory chairman fields (Collective blind
+     * spot / One-line verdict). Default `false` → byte-identical.
+     */
+    chairman_fields?: boolean;
+    /**
+     * Ü1 host-path blind render (road-to-council-blind-review Phase 1): when
+     * set, response blocks are headed by their blind label (`## Response A`)
+     * instead of `## <provider> · <model>`, and a de-anonymization map is
+     * appended AFTER the synthesis slot. Only meaningful when no member
+     * chairman ran — the member-chairman path embeds its own de-anon block
+     * directly in `chairman.text`. Default `null` → byte-identical.
+     */
+    blind?: { label_to_source: ReadonlyMap<string, string> } | null;
 }
 
 /**
@@ -1744,6 +1794,15 @@ export function render(responses: CouncilResponse[], opts: RenderOptions = {}):
     const consensus = opts.consensus ?? null;
     const peer_review = opts.peer_review ?? null;
     const explain_confidence = opts.explain_confidence ?? null;
+    // Ü1 host-path blind render: reverse the persisted `label -> provider:model`
+    // map so each response block can look up its own blind label by source.
+    const blind = opts.blind ?? null;
+    const source_to_label =
+        blind !== null
+            ? new Map<string, string>(
+                  Array.from(blind.label_to_source.entries()).map(([label, source]) => [source, label]),
+              )
+            : null;
 
     const blocks: string[] = [];
     const explain =
@@ -1759,7 +1818,8 @@ export function render(responses: CouncilResponse[], opts: RenderOptions = {}):
         blocks.push(_render_consensus(consensus.bucket, explain));
     }
     for (const r of responses) {
-        const header = `## ${r.provider} · ${r.model}`;
+        const blind_label = source_to_label?.get(`${r.provider}:${r.model}`) ?? null;
+        const header = blind_label !== null ? `## ${blind_label}` : `## ${r.provider} · ${r.model}`;
         if (r.error) {
             blocks.push(`${header}\n\n*ERROR:* \`${r.error}\``);
             continue;
@@ -1782,6 +1842,11 @@ export function render(responses: CouncilResponse[], opts: RenderOptions = {}):
         const addendum = peer_review_synthesis_addendum();
         template = template ? `${template}\n${addendum}` : _pyLStrip(addendum);
     }
+    if (opts.chairman_fields === true) {
+        // Ü3: two mandatory trailing sections, composed after any peer-review
+        // addendum so both extensions stack predictably.
+        template = template ? `${template}\n\n${CHAIRMAN_FIELDS_ADDENDUM}` : CHAIRMAN_FIELDS_ADDENDUM;
+    }
     let body: string;
     if (template) {
         body = template;
@@ -1808,6 +1873,11 @@ export function render(responses: CouncilResponse[], opts: RenderOptions = {}):
         blocks.push(render_vote_tally(tally));
     }
     blocks.push(`## Convergence / Divergence\n\n${body}`);
+    if (blind !== null) {
+        // Ü1: de-anonymization AFTER the synthesis slot — blind is only at
+        // decision time, never the archive.
+        blocks.push(render_deanonymization_block('### De-anonymization map', blind.label_to_source));
+    }
     return blocks.join('\n\n---\n\n');
 }
 

package/src/scripts/ai_team/review_gate.ts

@@ -25,16 +25,14 @@
  *      the same `AGENT_CONFIG_NO_EVENTS_LOG` kill-switch, no free-form
  *      content — verdict enum + counter only, PII-excluded by construction).
  *
- * Composition point (documented, not yet manifest-wired): the minimal
- * call-site is `src/scripts/team_review_gate_hook.ts`, a `stop` concern in
- * the dispatcher shape. Claude Code gives sibling Stop hooks no view of the
- * plugin gate's own stdout, so the hook reads the gate verdict from the
- * plugin's persisted job record (`jobs/<id>.json` → `result.rawOutput`,
- * title `Codex Stop Gate Review`) — see `find_latest_gate_transcript`.
- * Registering the concern in `src/scripts/hook_manifest.yaml` (claude/
- * cowork `stop`, after `chat-history`) is the one remaining wiring step;
- * it drags the manifest lint + installer + tests/hooks snapshot surface and
- * is deliberately left to the orchestrator. With
+ * Composition point (manifest-wired): the minimal call-site is
+ * `src/scripts/team_review_gate_hook.ts`, a `stop` concern in the
+ * dispatcher shape, registered in `src/scripts/hook_manifest.yaml` under
+ * `claude.stop` (after `chat-history`). Claude Code gives sibling Stop
+ * hooks no view of the plugin gate's own stdout, so the hook reads the
+ * gate verdict from the plugin's persisted job record (`jobs/<id>.json` →
+ * `result.rawOutput`, title `Codex Stop Gate Review`) — see
+ * `find_latest_gate_transcript`. With
  * `ai_team.review_gate.managed: false` (default) every entry point here is
  * a no-op — byte-identical pre-Phase-4 behavior.
  */

package/src/scripts/ai_team/team_dispatch.ts

@@ -64,6 +64,42 @@ export class TeamDisabledError extends TeamDispatchError {
     }
 }
 
+/**
+ * Thrown by `assert_delegate_allowed` when `ai_team.enabled` is true but the
+ * second opt-in (`ai_team.allow_delegate`) is not. `/team delegate` is the
+ * only wrapper that hands WRITE access to the second model, so it is
+ * double-gated; `enabled: true` alone is never delegate authorization.
+ */
+export class TeamDelegateDisabledError extends TeamDispatchError {
+    constructor() {
+        super(
+            '`/team delegate` is disabled (`ai_team.allow_delegate: false`, the shipped ' +
+                'default). It is the only team-mode wrapper that hands write access to ' +
+                'the second model, so it needs its own opt-in: set both ' +
+                '`ai_team.enabled: true` and `ai_team.allow_delegate: true` in ' +
+                '`.agent-settings.yml` — see docs/contracts/ai-team-config.md.',
+        );
+        this.name = 'TeamDelegateDisabledError';
+    }
+}
+
+/**
+ * Deterministic mirror of the `/team delegate` double gate: throws
+ * `TeamDisabledError` unless `ai_team.enabled`, then
+ * `TeamDelegateDisabledError` unless `ai_team.allow_delegate`. The command
+ * doc's prose gates instruct the agent; this guard is the machine-checkable
+ * contract (`--delegate-gate` CLI mode) tests pin against.
+ */
+export function assert_delegate_allowed(config?: AiTeamConfig, cwd?: string | null): void {
+    const cfg = config ?? load_ai_team_config({ cwd: cwd ?? null });
+    if (!cfg.enabled) {
+        throw new TeamDisabledError();
+    }
+    if (!cfg.allow_delegate) {
+        throw new TeamDelegateDisabledError();
+    }
+}
+
 // ── repo-context bundle (READ-ONLY) ─────────────────────────────────────
 
 /**
@@ -572,6 +608,18 @@ export function run_team_review(opts: RunTeamReviewOptions = {}): TeamReviewRunR
 // ── CLI entry ───────────────────────────────────────────────────────────
 
 function _main(argv: string[]): number {
+    if (argv.includes('--delegate-gate')) {
+        try {
+            assert_delegate_allowed();
+            return 0;
+        } catch (exc) {
+            if (exc instanceof TeamDispatchError) {
+                process.stderr.write(`${exc.message}\n`);
+                return 2;
+            }
+            throw exc;
+        }
+    }
     const manual = argv.includes('--manual');
     try {
         const result = run_team_review({ manual });

package/src/scripts/audit_adr_coverage.ts

@@ -57,8 +57,34 @@ export const AREAS: Record<string, AreaMeta> = {
         contract: 'smoke-contracts.md',
         scope: 'Per-tier smoke contracts, baseline locks, regression gates.',
     },
+    memory: {
+        contract: 'memory-visibility-v1.md',
+        scope: 'Memory / knowledge surfaces. RETIRED area — its single ADR is superseded by the agent-memory-layer removal; listed so the directory is audited rather than invisible.',
+    },
 };
 
+/**
+ * Area directories present on disk but absent from `AREAS`.
+ *
+ * `docs/adrs/memory/` sat on disk unlisted, and therefore unaudited, for an
+ * unknown period: the audit iterates a hardcoded inventory and had no way to
+ * notice a directory nobody told it about. Adding `memory` fixes the instance —
+ * this fixes the class. A coverage audit blind to a whole area is the same defect
+ * shape as a gate watching a path that no longer exists.
+ */
+export function unlistedAreaDirs(adrsRoot: string): string[] {
+    try {
+        return fs
+            .readdirSync(adrsRoot, { withFileTypes: true })
+            .filter((e) => e.isDirectory())
+            .map((e) => e.name)
+            .filter((n) => !(n in AREAS))
+            .sort();
+    } catch {
+        return [];
+    }
+}
+
 // ^(\d{4})-([a-z0-9-]+)\.md$
 const NAMED = /^(\d{4})-([a-z0-9-]+)\.md$/;
 // ^---\n(.*?)\n---  (DOTALL)
@@ -252,6 +278,13 @@ export function cmd_report(): number {
 export function cmd_check(): number {
     let hard = 0;
     let warn = 0;
+    for (const dir of unlistedAreaDirs(ADR_ROOT)) {
+        process.stderr.write(
+            `❌ ${dir}/: area directory exists on disk but is absent from AREAS — it is not audited at all. ` +
+                `Add it to the inventory (or delete the directory).\n`,
+        );
+        hard += 1;
+    }
     for (const [area, meta] of Object.entries(AREAS)) {
         const [adrs, errs] = scan_area(area);
         for (const e of errs) {

package/src/scripts/audit_initial_context.ts

@@ -81,7 +81,7 @@ export const BUDGETS: Record<string, number | null> = {
     'rules.gpt': null,
     'skill_catalog.gpt': 12_500, // always-scanned skill descriptions (skills_core_source, 258); current ~10,999
     'command_catalog.gpt': 5_800, // always-scanned command catalog; current ~5,005
-    'mcp_schemas.gpt': 4_250, // per-connected-client MCP tool schemas; current ~3,694 after the council-gated run_tests exec pilot (598a8a49f) — re-anchored current + ~15% per this cap's own policy
+    'mcp_schemas.gpt': 5_570, // per-connected-client MCP tool schemas; current ~4,839 after Phase 3 of road-to-credible-install (stub-honesty description marker on 12 stubs + readOnlyHint annotations on 19 implemented tools) — re-anchored current + ~15% per this cap's own policy
 };
 
 /**