@devrik-tools/claude-gates 0.1.2 → 0.2.0

package/plugins/gates/hooks/gates/mandatory-flow/index.mjs

@@ -1,166 +1,180 @@
-// mandatory-flow — denies an implementation delegation when there is no live task
-// pointer on disk backed by a contract file. Declaring pipeline stages in prose (what
-// implementation-pipeline.mjs checks) is not the same as a live task actually existing
-// on disk; this gate checks the disk fact, not the prompt's wording. Migrated from
-// ~/.claude/hooks/guard-flujo-obligatorio.mjs.
-//
-// ── What a project can configure (params) ───────────────────────────────────────────
-//   activePointerPath   path (relative to the project root) to the file naming the
-//                        active task/pipeline slug.
-//   exemptSubagents      subagent types exempt outright (read-only pipeline stages).
-//                        Replaces the built-in list wholesale.
-// The defaults live here, in the source, so a project reads them and knows exactly what
-// its override replaces.
-//
-// ── Off by default, and quiet outside its narrow trigger ───────────────────────────
-// Only STANDARD/HIGH-RISK implementation delegations, on non-exempt subagents, not
-// about the harness itself, reach the disk check.
-
-import { existsSync, readFileSync } from 'node:fs';
-import { join } from 'node:path';
-import { runGate, deny, TOOL_GROUPS } from '../../lib/hook-io.mjs';
-
-const GATE_ID = 'mandatory-flow';
-const CONFIG_KEY = 'requireLiveTaskWhenImplementing';
-
-const DELEGATION_TOOLS = new Set(TOOL_GROUPS.delegation);
-
-const DEFAULT_ACTIVE_POINTER_PATH = join('.ai', 'pipeline', 'ACTIVA');
-
-const DEFAULT_EXEMPT_SUBAGENTS = [
-  'explore',
-  'plan',
-  'scout',
-  'revision',
-  'contraste',
-  'test-planner',
-  'qa',
-  'ui',
-  'ux',
-];
-
-/** Contract files that count as evidence a task's contract exists on disk. */
-const TASK_CONTRACT_FILES = [
-  'asserts.md',
-  'task.json',
-  'spec.md',
-  'requirements.md',
-  'acceptance.md',
-];
-
-function withWordBoundary(alternation) {
-  return new RegExp(
-    `(?:^|[^\\p{L}\\p{N}_])(?:${alternation})(?:[^\\p{L}\\p{N}_]|$)`,
-    'iu',
-  );
-}
-
-const IMPLEMENTATION_VERBS = withWordBoundary(
-  'implementa|implementar|implement(á|é)|agreg(a|á)|agregar|añad(e|í)|añadir|cre(a|á)|crear|' +
-    'arregl(a|á)|arreglar|cambi(a|á)|cambiar|migr(a|á)|migrar|' +
-    'corrige|corregir|correg(í|ir)|constru(ye|í)|construir|modific(a|á)|modificar|' +
-    'refactoriz(a|á)|refactorizar|elimin(a|á)|eliminar|reescrib(e|í)|reescribir|desplieg(a|á)|desplegar|' +
-    'escrib(í|e)|escribir|implement\\w*|writ(?:e|ing)|creat\\w*|fix\\w*|build\\w*|refactor\\w*|migrat\\w*|' +
-    'add\\w*|remov\\w*|delet\\w*|modify|modifies|modifying|rewrit\\w*',
-);
-
-/** Declared LEVEL near the word "level"/"classification" in Spanish or English, matching
- * the plugin-wide convention (see risk-level.mjs). */
-const DEMANDING_LEVEL_PATTERN =
-  /(nivel|level|clasificaci[oó]n|classification)[^\n]{0,25}?\b(STANDARD|HIGH-RISK)\b/iu;
-const EXEMPT_LEVEL_PATTERN =
-  /(nivel|level|clasificaci[oó]n|classification)[^\n]{0,25}?\b(QUESTION|MICRO)\b/iu;
-
-const HARNESS_PATTERN =
-  /(\.claude[\\/]|hooks[\\/]|plugins[\\/]gates|settings\.json|[\\/]agents[\\/]\w|[\\/]rules[\\/]\w|[\\/]skills[\\/]\w)/i;
-
-function isExempt(toolInput, prompt, exemptSubagents) {
-  const subagentType = String(
-    toolInput.subagent_type ?? toolInput.subagentType ?? '',
-  ).toLowerCase();
-  if (exemptSubagents.includes(subagentType)) return true;
-  if (EXEMPT_LEVEL_PATTERN.test(prompt)) return true;
-  if (!DEMANDING_LEVEL_PATTERN.test(prompt)) return true;
-  if (!IMPLEMENTATION_VERBS.test(prompt)) return true;
-  if (HARNESS_PATTERN.test(prompt)) return true;
-  return false;
-}
-
-function hasTaskContract(taskDirectory) {
-  return TASK_CONTRACT_FILES.some((file) => {
-    try {
-      return existsSync(join(taskDirectory, file));
-    } catch {
-      return false;
-    }
-  });
-}
-
-/** The pointer file's trimmed content, or '' when it cannot be read. */
-function readSlug(pointerPath) {
-  try {
-    return readFileSync(pointerPath, 'utf8').trim();
-  } catch {
-    return '';
-  }
-}
-
-/** Denies for whichever of the three live-task facts is missing, or does nothing. */
-function checkLiveTask(pointerPath) {
-  if (!existsSync(pointerPath)) {
-    deny(
-      GATE_ID,
-      `This delegation is going to implement, but there is no live task: ${pointerPath} ` +
-        'does not exist. Start a task pointing to it before delegating, or declare ' +
-        'LEVEL: QUESTION/MICRO if this is not implementation.',
-    );
-  }
-
-  const slug = readSlug(pointerPath);
-  if (!slug) {
-    deny(
-      GATE_ID,
-      `${pointerPath} exists but is empty. An active-task pointer with no slug is not ` +
-        'a live task. Write the task slug into it before delegating.',
-    );
-  }
-
-  const taskDirectory = join(process.cwd(), '.ai', 'pipeline', slug);
-  if (!hasTaskContract(taskDirectory)) {
-    deny(
-      GATE_ID,
-      `The active task '${slug}' has no contract on disk: none of ` +
-        `${TASK_CONTRACT_FILES.join(', ')} exists under ${taskDirectory}. ` +
-        'Write the contract before implementing.',
-    );
-  }
-}
-
-runGate(
-  {
-    id: GATE_ID,
-    configKey: CONFIG_KEY,
-    enabledByDefault: false,
-    defaultParams: {
-      activePointerPath: DEFAULT_ACTIVE_POINTER_PATH,
-      exemptSubagents: DEFAULT_EXEMPT_SUBAGENTS,
-    },
-  },
-  ({ toolName, toolInput, parameters }) => {
-    if (!DELEGATION_TOOLS.has(toolName)) return;
-
-    const prompt = String(
-      toolInput.prompt ?? toolInput.Prompt ?? toolInput.task ?? '',
-    );
-    if (!prompt.trim()) return;
-
-    const exemptSubagents =
-      parameters.exemptSubagents ?? DEFAULT_EXEMPT_SUBAGENTS;
-    if (isExempt(toolInput, prompt, exemptSubagents)) return;
-
-    const activePointerPath = String(
-      parameters.activePointerPath ?? DEFAULT_ACTIVE_POINTER_PATH,
-    );
-    checkLiveTask(join(process.cwd(), activePointerPath));
-  },
-);
+// mandatory-flow — denies an implementation delegation when there is no live task
+// pointer on disk backed by a contract file. Declaring pipeline stages in prose (what
+// implementation-pipeline.mjs checks) is not the same as a live task actually existing
+// on disk; this gate checks the disk fact, not the prompt's wording. Migrated from
+// ~/.claude/hooks/guard-flujo-obligatorio.mjs.
+//
+// ── What a project can configure (params) ───────────────────────────────────────────
+//   activePointerPath   path (relative to the project root) to the file naming the
+//                        active task/pipeline slug.
+//   exemptSubagents      subagent types exempt outright (read-only pipeline stages).
+//                        Replaces the built-in list wholesale.
+// The defaults live here, in the source, so a project reads them and knows exactly what
+// its override replaces.
+//
+// ── Off by default, and quiet outside its narrow trigger ───────────────────────────
+// Only STANDARD/HIGH-RISK implementation delegations, on non-exempt subagents, not
+// about the harness itself, reach the disk check.
+
+import { existsSync, readFileSync } from 'node:fs';
+import { join, normalize, sep } from 'node:path';
+import {
+  runGate,
+  deny,
+  toolInGroups,
+  delegationPromptOf,
+} from '../../lib/hook-io.mjs';
+
+const GATE_ID = 'mandatory-flow';
+const CONFIG_KEY = 'requireLiveTaskWhenImplementing';
+
+const DEFAULT_ACTIVE_POINTER_PATH = join('.ai', 'pipeline', 'ACTIVA');
+
+const DEFAULT_EXEMPT_SUBAGENTS = [
+  'explore',
+  'plan',
+  'scout',
+  'revision',
+  'contraste',
+  'test-planner',
+  'qa',
+  'ui',
+  'ux',
+];
+
+/** Contract files that count as evidence a task's contract exists on disk. */
+const TASK_CONTRACT_FILES = [
+  'asserts.md',
+  'task.json',
+  'spec.md',
+  'requirements.md',
+  'acceptance.md',
+];
+
+function withWordBoundary(alternation) {
+  return new RegExp(
+    `(?:^|[^\\p{L}\\p{N}_])(?:${alternation})(?:[^\\p{L}\\p{N}_]|$)`,
+    'iu',
+  );
+}
+
+const IMPLEMENTATION_VERBS = withWordBoundary(
+  'implementa|implementar|implement(á|é)|agreg(a|á)|agregar|añad(e|í)|añadir|cre(a|á)|crear|' +
+    'arregl(a|á)|arreglar|cambi(a|á)|cambiar|migr(a|á)|migrar|' +
+    'corrige|corregir|correg(í|ir)|constru(ye|í)|construir|modific(a|á)|modificar|' +
+    'refactoriz(a|á)|refactorizar|elimin(a|á)|eliminar|reescrib(e|í)|reescribir|desplieg(a|á)|desplegar|' +
+    'escrib(í|e)|escribir|implement\\w*|writ(?:e|ing)|creat\\w*|fix\\w*|build\\w*|refactor\\w*|migrat\\w*|' +
+    'add\\w*|remov\\w*|delet\\w*|modify|modifies|modifying|rewrit\\w*',
+);
+
+/** Declared LEVEL near the word "level"/"classification" in Spanish or English, matching
+ * the plugin-wide convention (see risk-level.mjs). */
+const DEMANDING_LEVEL_PATTERN =
+  /(nivel|level|clasificaci[oó]n|classification)[^\n]{0,25}?\b(STANDARD|HIGH-RISK)\b/iu;
+const EXEMPT_LEVEL_PATTERN =
+  /(nivel|level|clasificaci[oó]n|classification)[^\n]{0,25}?\b(QUESTION|MICRO)\b/iu;
+
+const HARNESS_PATTERN =
+  /(\.claude[\\/]|hooks[\\/]|plugins[\\/]gates|settings\.json|[\\/]agents[\\/]\w|[\\/]rules[\\/]\w|[\\/]skills[\\/]\w)/i;
+
+function isExempt(toolInput, prompt, exemptSubagents) {
+  const subagentType = String(
+    toolInput.subagent_type ?? toolInput.subagentType ?? '',
+  ).toLowerCase();
+  if (exemptSubagents.includes(subagentType)) return true;
+  if (EXEMPT_LEVEL_PATTERN.test(prompt)) return true;
+  if (!DEMANDING_LEVEL_PATTERN.test(prompt)) return true;
+  if (!IMPLEMENTATION_VERBS.test(prompt)) return true;
+  if (HARNESS_PATTERN.test(prompt)) return true;
+  return false;
+}
+
+function hasTaskContract(taskDirectory) {
+  return TASK_CONTRACT_FILES.some((file) => {
+    try {
+      return existsSync(join(taskDirectory, file));
+    } catch {
+      return false;
+    }
+  });
+}
+
+/** The pointer file's trimmed content, or '' when it cannot be read or the slug
+ * attempts path traversal. A slug is a directory name, not a path: rejecting any
+ * segment separator or '..' closes off `join(cwd, '.ai', 'pipeline', slug)` escaping
+ * that directory to accept an unrelated file elsewhere on disk as the task contract. */
+function readSlug(pointerPath) {
+  let raw;
+  try {
+    raw = readFileSync(pointerPath, 'utf8').trim();
+  } catch {
+    return '';
+  }
+  if (!raw) return '';
+  const normalized = normalize(raw);
+  const hasTraversal = normalized
+    .split(/[\\/]/)
+    .some((segment) => segment === '..' || segment === '.');
+  if (hasTraversal || normalized.includes(sep) || normalized.includes('/')) {
+    return '';
+  }
+  return normalized;
+}
+
+/** Denies for whichever of the three live-task facts is missing, or does nothing. */
+function checkLiveTask(pointerPath) {
+  if (!existsSync(pointerPath)) {
+    deny(
+      GATE_ID,
+      `This delegation is going to implement, but there is no live task: ${pointerPath} ` +
+        'does not exist. Start a task pointing to it before delegating, or declare ' +
+        'LEVEL: QUESTION/MICRO if this is not implementation.',
+    );
+  }
+
+  const slug = readSlug(pointerPath);
+  if (!slug) {
+    deny(
+      GATE_ID,
+      `${pointerPath} exists but is empty. An active-task pointer with no slug is not ` +
+        'a live task. Write the task slug into it before delegating.',
+    );
+  }
+
+  const taskDirectory = join(process.cwd(), '.ai', 'pipeline', slug);
+  if (!hasTaskContract(taskDirectory)) {
+    deny(
+      GATE_ID,
+      `The active task '${slug}' has no contract on disk: none of ` +
+        `${TASK_CONTRACT_FILES.join(', ')} exists under ${taskDirectory}. ` +
+        'Write the contract before implementing.',
+    );
+  }
+}
+
+runGate(
+  {
+    id: GATE_ID,
+    configKey: CONFIG_KEY,
+    enabledByDefault: false,
+    defaultParams: {
+      activePointerPath: DEFAULT_ACTIVE_POINTER_PATH,
+      exemptSubagents: DEFAULT_EXEMPT_SUBAGENTS,
+    },
+  },
+  ({ toolName, toolInput, parameters }) => {
+    if (!toolInGroups(toolName, ['delegation'])) return;
+
+    const prompt = delegationPromptOf(toolInput);
+    if (!prompt.trim()) return;
+
+    const exemptSubagents =
+      parameters.exemptSubagents ?? DEFAULT_EXEMPT_SUBAGENTS;
+    if (isExempt(toolInput, prompt, exemptSubagents)) return;
+
+    const activePointerPath = String(
+      parameters.activePointerPath ?? DEFAULT_ACTIVE_POINTER_PATH,
+    );
+    checkLiveTask(join(process.cwd(), activePointerPath));
+  },
+);

package/plugins/gates/hooks/gates/neutral-spanish/index.mjs

@@ -1,85 +1,79 @@
-import { runGate, warn } from '../../lib/hook-io.mjs';
-
-const GATE_ID = 'neutral-spanish';
-const CONFIG_KEY = 'warnNonNeutralSpanish';
-
-const MAX_REPORTED_MARKERS = 8;
-
-// Data strings, not identifiers — never add these to a cSpell dictionary.
-const DEFAULT_REGIONAL_MARKERS = [
-  'tenés',
-  'podés',
-  'querés',
-  'sabés',
-  'hacés',
-  'decís',
-  'venís',
-  'sos',
-  'fijate',
-  'mirá',
-  'pará',
-  'esperá',
-  'dale',
-  'mandale',
-  'contame',
-  'fíjate vos',
-  'acá',
-  'allá',
-  'laburo',
-  'laburar',
-  'quilombo',
-  'posta',
-  'che',
-  'boludo',
-  'pibe',
-  'guita',
-  'al pedo',
-  'un toque',
-  'capaz que',
-  'de una',
-];
-
-function extractText(toolName, toolInput) {
-  if (toolName === 'Write') return String(toolInput?.content ?? '');
-  if (toolName === 'Edit') return String(toolInput?.new_string ?? '');
-  if (toolName === 'MultiEdit' && Array.isArray(toolInput?.edits)) {
-    return toolInput.edits
-      .map((edit) => String(edit?.new_string ?? ''))
-      .join('\n');
-  }
-  return '';
-}
-
-runGate(
-  {
-    id: GATE_ID,
-    configKey: CONFIG_KEY,
-    enabledByDefault: true,
-    defaultParams: {
-      regionalMarkers: DEFAULT_REGIONAL_MARKERS,
-    },
-  },
-  ({ toolName, toolInput, parameters }) => {
-    const text = extractText(toolName, toolInput).toLowerCase();
-    if (!text) return;
-
-    const hits = [];
-    for (const marker of parameters.regionalMarkers) {
-      const escaped = marker.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
-      // \p{L} (any Unicode letter) as the non-boundary class, instead of a hand-written
-      // accented-character set, so accented word boundaries are handled correctly without
-      // spelling out literal accented characters in the source (the project keeps its
-      // spell-check dictionary untouched, so no word list may lean on this being a string).
-      const pattern = new RegExp(`(^|[^\\p{L}])${escaped}([^\\p{L}]|$)`, 'iu');
-      if (pattern.test(text)) hits.push(marker);
-    }
-
-    if (hits.length === 0) return;
-
-    const unique = [...new Set(hits)].slice(0, MAX_REPORTED_MARKERS);
-    warn(
-      GATE_ID,
-      `Text being written contains regional Spanish markers: ${unique.join(', ')}. Prefer neutral Spanish unless this is a literal quote or data.`,
-    );
-  },
-);
+import { runGate, warn, toolInGroups, writtenContentOf } from '../../lib/hook-io.mjs';
+
+const GATE_ID = 'neutral-spanish';
+const CONFIG_KEY = 'warnNonNeutralSpanish';
+
+const MAX_REPORTED_MARKERS = 8;
+
+// Data strings, not identifiers — never add these to a cSpell dictionary.
+const DEFAULT_REGIONAL_MARKERS = [
+  'tenés',
+  'podés',
+  'querés',
+  'sabés',
+  'hacés',
+  'decís',
+  'venís',
+  'sos',
+  'fijate',
+  'mirá',
+  'pará',
+  'esperá',
+  'dale',
+  'mandale',
+  'contame',
+  'fíjate vos',
+  'acá',
+  'allá',
+  'laburo',
+  'laburar',
+  'quilombo',
+  'posta',
+  'che',
+  'boludo',
+  'pibe',
+  'guita',
+  'al pedo',
+  'un toque',
+  'capaz que',
+  'de una',
+];
+
+function extractText(toolName, toolInput) {
+  if (!toolInGroups(toolName, ['write'])) return '';
+  return writtenContentOf(toolInput);
+}
+
+runGate(
+  {
+    id: GATE_ID,
+    configKey: CONFIG_KEY,
+    enabledByDefault: true,
+    defaultParams: {
+      regionalMarkers: DEFAULT_REGIONAL_MARKERS,
+    },
+  },
+  ({ toolName, toolInput, parameters }) => {
+    const text = extractText(toolName, toolInput).toLowerCase();
+    if (!text) return;
+
+    const hits = [];
+    for (const marker of parameters.regionalMarkers) {
+      const escaped = marker.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
+      // \p{L} (any Unicode letter) as the non-boundary class, instead of a hand-written
+      // accented-character set, so accented word boundaries are handled correctly without
+      // spelling out literal accented characters in the source (the project keeps its
+      // spell-check dictionary untouched, so no word list may lean on this being a string).
+      const pattern = new RegExp(`(^|[^\\p{L}])${escaped}([^\\p{L}]|$)`, 'iu');
+      if (pattern.test(text)) hits.push(marker);
+    }
+
+    if (hits.length === 0) return;
+
+    const unique = [...new Set(hits)].slice(0, MAX_REPORTED_MARKERS);
+    warn(
+      GATE_ID,
+      `Text being written contains regional Spanish markers: ${unique.join(', ')}. Prefer neutral Spanish unless this is a literal quote or data.`,
+    );
+  },
+);

package/plugins/gates/hooks/gates/neutral-spanish/neutral-spanish.edge.test.mjs

@@ -0,0 +1,80 @@
+import assert from 'node:assert/strict';
+import { execFileSync } from 'node:child_process';
+import { mkdtempSync, mkdirSync, writeFileSync } from 'node:fs';
+import { tmpdir } from 'node:os';
+import { dirname, join } from 'node:path';
+import { test } from 'node:test';
+import { fileURLToPath } from 'node:url';
+
+const GATE = join(dirname(fileURLToPath(import.meta.url)), 'index.mjs');
+
+function runGate(payload, { config } = {}) {
+  const project = mkdtempSync(join(tmpdir(), 'neutral-spanish-edge-'));
+  mkdirSync(join(project, '.git'));
+  if (config) {
+    mkdirSync(join(project, '.ai'));
+    writeFileSync(join(project, '.ai', 'config.json'), JSON.stringify(config));
+  }
+  const out = execFileSync(process.execPath, [GATE], {
+    input: JSON.stringify(payload),
+    encoding: 'utf8',
+    cwd: project,
+    env: { ...process.env, HOME: project, USERPROFILE: project },
+  });
+  return out.trim() ? JSON.parse(out.trim()) : null;
+}
+
+function isWarn(result) {
+  return result?.hookSpecificOutput?.additionalContext !== undefined;
+}
+
+// FIXED: extractText() now gates on toolInGroups(toolName, ['write']) and reads through
+// writtenContentOf() (lib/hook-io.mjs), which covers NotebookEdit's new_source field.
+test('FIXED: NotebookEdit carrying regional Spanish is detected', () => {
+  const payload = {
+    tool_name: 'NotebookEdit',
+    tool_input: {
+      notebook_path: '/repo/notebook.ipynb',
+      cell_id: 'abc',
+      new_source: 'vos tenés que revisar esto, dale',
+      cell_type: 'markdown',
+    },
+  };
+  assert.ok(isWarn(runGate(payload)), 'gate now detects regional Spanish written via NotebookEdit');
+});
+
+// FIXED: write_to_file is recognized by toolInGroups(toolName, ['write']) (native name in
+// TOOL_GROUPS.write) and its `content` field is read through writtenContentOf().
+test('FIXED: write_to_file with regional Spanish content is detected', () => {
+  const payload = {
+    tool_name: 'write_to_file',
+    tool_input: {
+      file_path: '/repo/notes.md',
+      content: 'che, mirá el laburo que hicimos acá',
+    },
+  };
+  assert.ok(isWarn(runGate(payload)), 'gate now detects regional Spanish written via write_to_file');
+});
+
+// EDGE CASE 3: false-positive check on legitimate neutral words that are substrings-adjacent
+// to markers. "sos" (voseo for "you are") is in the marker list; verify a word that merely
+// CONTAINS "sos" as a substring (e.g. "sospecha", "hermosos") is NOT flagged, since the
+// pattern uses \p{L} boundaries.
+test('OK: word boundary prevents false positive on words containing a marker as substring', () => {
+  const result = runGate({
+    tool_name: 'Write',
+    tool_input: { file_path: '/repo/notes.md', content: 'Tengo una sospecha sobre estos hermosos resultados.' },
+  });
+  assert.equal(result, null, 'false positive: "sos" matched inside sospecha/hermosos');
+});
+
+// EDGE CASE 4: "dale" is in the marker list as Rioplatense slang, but is this over-broad?
+// "dale" only appears as that exact word — check it correctly fires only for that token,
+// not, e.g., as part of "dalear" or similar. This confirms no over-matching regression.
+test('OK: marker "dale" does not fire on a word merely containing it', () => {
+  const result = runGate({
+    tool_name: 'Write',
+    tool_input: { file_path: '/repo/notes.md', content: 'Actualiza el dataleer o el dalext.' },
+  });
+  assert.equal(result, null, 'false positive: "dale" matched inside a longer word');
+});