@danielgindi/selectbox 2.0.4 → 2.0.6

package/dist/lib.umd.js

@@ -1,5 +1,5 @@
 /*!
- * @danielgindi/selectbox 2.0.4
+ * @danielgindi/selectbox 2.0.6
  * git://github.com/danielgindi/selectbox.git
  */
 (function (global, factory) {
@@ -1212,11 +1212,10 @@
           if (!Array.isArray(filteredItems)) {
             if (term) {
               const matcher = new RegExp(escapeRegex(term), 'i');
-              const labelProp = p.labelProp;
 
               filteredItems = p.items.filter((x) => {
                 if (!filterGroups && x._group) return true;
-                return matcher.test(x[labelProp]);
+                return matcher.test(x.label);
               });
             } else {
               filteredItems = null;
@@ -1490,6 +1489,8 @@
 
         // Calculate virtual viewport size
         if (p.virtualListHelper.isVirtual()) {
+          // Avoid extremely high size which will cause laying out the whole list
+          menuEl.style.height = Math.min(el.clientHeight, document.body.clientHeight) + 'px';
           p.virtualListHelper.render();
         }
 
@@ -3651,7 +3652,6 @@
           p.resizeObserver.observe(p.el);
         }
 
-        if (o.filterFn)
         this.setFilterFn(o.filterFn);
 
         this.setItems(o.items);
@@ -4445,6 +4445,10 @@
         const p = this._p;
         if (p.filterFn === fn)
         return this;
+
+        // Do not keep this reference, as far as the user is concerned - he/she did not set a custom filter.
+        p.filterFn = fn;
+
         if (!fn) {
           // Add search by multi-item label
           fn = (items, term) => {
@@ -4458,7 +4462,8 @@
             });
           };
         }
-        p.filterFn = fn;
+
+        p.actualFilterFn = fn;
         p.dropList?.setFilterFn(fn);
         return this;
       }
@@ -5062,8 +5067,8 @@
           filterThrottleWindow: p.filterThrottleWindow,
           filterOnEmptyTerm: p.filterOnEmptyTerm,
           filterGroups: p.treatGroupSelectionAsItems,
-          filterEmptyGroups: p.treatGroupSelectionAsItems,
-          filterFn: p.filterFn,
+          filterEmptyGroups: !p.treatGroupSelectionAsItems,
+          filterFn: p.actualFilterFn,
 
           positionOptionsProvider: () => this._getDropListPositionOptions(),