@danielgindi/selectbox 2.0.4 → 2.0.6

package/dist/lib.es6.js

@@ -1,5 +1,5 @@
 /*!
- * @danielgindi/selectbox 2.0.4
+ * @danielgindi/selectbox 2.0.6
  * git://github.com/danielgindi/selectbox.git
  */
 import { createElement, closestUntil, setElementAttrs, next, prev } from '@danielgindi/dom-utils/lib/Dom';
@@ -1214,11 +1214,10 @@ class DropList {
             if (!Array.isArray(filteredItems)) {
                 if (term) {
                     const matcher = new RegExp(escapeRegex(term), 'i');
-                    const labelProp = p.labelProp;
 
                     filteredItems = p.items.filter(x => {
                         if (!filterGroups && x._group) return true;
-                        return matcher.test(x[labelProp]);
+                        return matcher.test(x.label);
                     });
                 } else {
                     filteredItems = null;
@@ -1492,6 +1491,8 @@ class DropList {
 
         // Calculate virtual viewport size
         if (p.virtualListHelper.isVirtual()) {
+            // Avoid extremely high size which will cause laying out the whole list
+            menuEl.style.height = Math.min(el.clientHeight, document.body.clientHeight) + 'px';
             p.virtualListHelper.render();
         }
 
@@ -3653,8 +3654,7 @@ class SelectBox {
             p.resizeObserver.observe(p.el);
         }
 
-        if (o.filterFn)
-            this.setFilterFn(o.filterFn);
+        this.setFilterFn(o.filterFn);
 
         this.setItems(o.items);
         delete o.items; // we do not need this in memory anymore
@@ -4447,6 +4447,10 @@ class SelectBox {
         const p = this._p;
         if (p.filterFn === fn)
             return this;
+
+        // Do not keep this reference, as far as the user is concerned - he/she did not set a custom filter.
+        p.filterFn = fn;
+
         if (!fn) {
             // Add search by multi-item label
             fn = (items, term) => {
@@ -4460,7 +4464,8 @@ class SelectBox {
                 });
             };
         }
-        p.filterFn = fn;
+
+        p.actualFilterFn = fn;
         p.dropList?.setFilterFn(fn);
         return this;
     }
@@ -5064,8 +5069,8 @@ class SelectBox {
             filterThrottleWindow: p.filterThrottleWindow,
             filterOnEmptyTerm: p.filterOnEmptyTerm,
             filterGroups: p.treatGroupSelectionAsItems,
-            filterEmptyGroups: p.treatGroupSelectionAsItems,
-            filterFn: p.filterFn,
+            filterEmptyGroups: !p.treatGroupSelectionAsItems,
+            filterFn: p.actualFilterFn,
 
             positionOptionsProvider: () => this._getDropListPositionOptions(),