@danielgindi/selectbox 2.0.4 → 2.0.6

package/lib/DropList.js

@@ -1186,11 +1186,10 @@ class DropList {
             if (!Array.isArray(filteredItems)) {
                 if (term) {
                     const matcher = new RegExp(escapeRegex(term), 'i');
-                    const labelProp = p.labelProp;
 
                     filteredItems = p.items.filter(x => {
                         if (!filterGroups && x._group) return true;
-                        return matcher.test(x[labelProp]);
+                        return matcher.test(x.label);
                     });
                 } else {
                     filteredItems = null;
@@ -1464,6 +1463,8 @@ class DropList {
 
         // Calculate virtual viewport size
         if (p.virtualListHelper.isVirtual()) {
+            // Avoid extremely high size which will cause laying out the whole list
+            menuEl.style.height = Math.min(el.clientHeight, document.body.clientHeight) + 'px';
             p.virtualListHelper.render();
         }
 

package/lib/SelectBox.js

@@ -380,8 +380,7 @@ class SelectBox {
             p.resizeObserver.observe(p.el);
         }
 
-        if (o.filterFn)
-            this.setFilterFn(o.filterFn);
+        this.setFilterFn(o.filterFn);
 
         this.setItems(o.items);
         delete o.items; // we do not need this in memory anymore
@@ -1174,6 +1173,10 @@ class SelectBox {
         const p = this._p;
         if (p.filterFn === fn)
             return this;
+
+        // Do not keep this reference, as far as the user is concerned - he/she did not set a custom filter.
+        p.filterFn = fn;
+
         if (!fn) {
             // Add search by multi-item label
             fn = (items, term) => {
@@ -1187,7 +1190,8 @@ class SelectBox {
                 });
             };
         }
-        p.filterFn = fn;
+
+        p.actualFilterFn = fn;
         p.dropList?.setFilterFn(fn);
         return this;
     }
@@ -1791,8 +1795,8 @@ class SelectBox {
             filterThrottleWindow: p.filterThrottleWindow,
             filterOnEmptyTerm: p.filterOnEmptyTerm,
             filterGroups: p.treatGroupSelectionAsItems,
-            filterEmptyGroups: p.treatGroupSelectionAsItems,
-            filterFn: p.filterFn,
+            filterEmptyGroups: !p.treatGroupSelectionAsItems,
+            filterFn: p.actualFilterFn,
 
             positionOptionsProvider: () => this._getDropListPositionOptions(),
 

package/package.json

@@ -1,63 +1,63 @@
-{
-  "name": "@danielgindi/selectbox",
-  "version": "2.0.4",
-  "description": "A collection of dom utilities. So you can work natively with the dom without dom frameworks.",
-  "main": "dist/lib.cjs.min.js",
-  "module": "lib/index.js",
-  "broswer": "dist/lib.umd.min.js",
-  "author": {
-    "name": "Daniel Cohen Gindi",
-    "email": "danielgindi@gmail.com"
-  },
-  "repository": {
-    "type": "git",
-    "url": "git://github.com/danielgindi/selectbox.git"
-  },
-  "directories": {
-    "dist": "dist",
-    "lib": "lib"
-  },
-  "scripts": {
-    "build": "npm run lint && node ./scripts/build.js",
-    "lint": "eslint -f codeframe ./",
-    "lint-fix": "eslint -f codeframe --fix ./",
-    "prepublishOnly": "npm run build",
-    "prepare": "husky"
-  },
-  "bugs": {
-    "url": "https://github.com/danielgindi/selectbox/issues"
-  },
-  "homepage": "https://github.com/danielgindi/selectbox#readme",
-  "license": "MIT",
-  "devDependencies": {
-    "@babel/core": "^7.26.9",
-    "@babel/preset-env": "^7.26.9",
-    "@babel/runtime": "^7.26.9",
-    "@eslint/eslintrc": "^3.2.0",
-    "@eslint/js": "^9.20.0",
-    "@rollup/plugin-babel": "^6.0.4",
-    "@rollup/plugin-commonjs": "^28.0.2",
-    "@rollup/plugin-node-resolve": "^16.0.0",
-    "@rollup/plugin-terser": "^0.4.4",
-    "core-js": "^3.40.0",
-    "eslint": "^9.20.1",
-    "eslint-formatter-codeframe": "^7.32.1",
-    "eslint-plugin-vue": "^9.32.0",
-    "fs-extra": "^11.3.0",
-    "globals": "^15.15.0",
-    "husky": "^9.1.7",
-    "pinst": "^3.0.0",
-    "rollup": "^4.34.8",
-    "sass": "^1.85.0"
-  },
-  "dependencies": {
-    "@danielgindi/dom-utils": "^1.0.11",
-    "@danielgindi/virtual-list-helper": "^1.0.13",
-    "fast-deep-equal": "^3.1.3",
-    "keycode-js": "^3.1.0",
-    "mitt": "^3.0.1"
-  },
-  "peerDependencies": {
-    "vue": "^2.* || ^3.*"
-  }
-}
+{
+  "name": "@danielgindi/selectbox",
+  "version": "2.0.6",
+  "description": "A collection of dom utilities. So you can work natively with the dom without dom frameworks.",
+  "main": "dist/lib.cjs.min.js",
+  "module": "lib/index.js",
+  "broswer": "dist/lib.umd.min.js",
+  "author": {
+    "name": "Daniel Cohen Gindi",
+    "email": "danielgindi@gmail.com"
+  },
+  "repository": {
+    "type": "git",
+    "url": "git://github.com/danielgindi/selectbox.git"
+  },
+  "directories": {
+    "dist": "dist",
+    "lib": "lib"
+  },
+  "scripts": {
+    "build": "npm run lint && node ./scripts/build.js",
+    "lint": "eslint -f codeframe ./",
+    "lint-fix": "eslint -f codeframe --fix ./",
+    "prepublishOnly": "npm run build",
+    "prepare": "husky"
+  },
+  "bugs": {
+    "url": "https://github.com/danielgindi/selectbox/issues"
+  },
+  "homepage": "https://github.com/danielgindi/selectbox#readme",
+  "license": "MIT",
+  "devDependencies": {
+    "@babel/core": "^7.26.9",
+    "@babel/preset-env": "^7.26.9",
+    "@babel/runtime": "^7.26.9",
+    "@eslint/eslintrc": "^3.2.0",
+    "@eslint/js": "^9.20.0",
+    "@rollup/plugin-babel": "^6.0.4",
+    "@rollup/plugin-commonjs": "^28.0.2",
+    "@rollup/plugin-node-resolve": "^16.0.0",
+    "@rollup/plugin-terser": "^0.4.4",
+    "core-js": "^3.40.0",
+    "eslint": "^9.20.1",
+    "eslint-formatter-codeframe": "^7.32.1",
+    "eslint-plugin-vue": "^9.32.0",
+    "fs-extra": "^11.3.0",
+    "globals": "^15.15.0",
+    "husky": "^9.1.7",
+    "pinst": "^3.0.0",
+    "rollup": "^4.34.8",
+    "sass": "^1.85.0"
+  },
+  "dependencies": {
+    "@danielgindi/dom-utils": "^1.0.11",
+    "@danielgindi/virtual-list-helper": "^1.0.13",
+    "fast-deep-equal": "^3.1.3",
+    "keycode-js": "^3.1.0",
+    "mitt": "^3.0.1"
+  },
+  "peerDependencies": {
+    "vue": "^2.* || ^3.*"
+  }
+}