@cosmicdrift/kumiko-renderer 0.327.0 → 0.328.1

package/src/components/__tests__/render-field-number-unit.test.tsx

@@ -1,227 +0,0 @@
-// Editable number-field unit-of-measure suffix (static or sibling-field
-// reference). Complements render-field-unit-format.test.tsx, which only
-// covers the pre-existing read-only `format: "unit"` FieldRenderer path —
-// this feature is display-only decoration on the editable Input widget,
-// never a value conversion.
-
-import { describe, expect, test } from "bun:test";
-import {
-  buildAppSchema,
-  createRegistry,
-  defineFeature,
-} from "@cosmicdrift/kumiko-framework/engine";
-import type {
-  EntityDefinition,
-  EntityEditScreenDefinition,
-} from "@cosmicdrift/kumiko-framework/ui-types";
-import { computeEditViewModel, type EditFieldViewModel } from "@cosmicdrift/kumiko-headless";
-import { render } from "@testing-library/react";
-import type { ComponentType, ReactNode } from "react";
-import { createStaticLocaleResolver, LocaleProvider } from "../../i18n";
-import { type CorePrimitives, type InputProps, PrimitivesProvider } from "../../primitives";
-import { RenderField } from "../render-field";
-
-let captured: InputProps | undefined;
-const captureInput: ComponentType<InputProps> = (props) => {
-  captured = props;
-  return null;
-};
-const noop = (): ReactNode => null;
-const passChildren = ({ children }: { readonly children?: ReactNode }): ReactNode => children;
-
-const testPrimitives: CorePrimitives = {
-  Button: noop,
-  Banner: noop,
-  Field: passChildren,
-  Input: captureInput,
-  DataTable: noop,
-  Form: noop,
-  Section: noop,
-  Card: noop,
-  Grid: noop,
-  GridCell: noop,
-  Text: noop,
-  Heading: noop,
-  Dialog: noop,
-  Modal: noop,
-  Lightbox: noop,
-  ConfigSourceBadge: noop,
-  ConfigCascadeView: noop,
-  Link: noop,
-};
-
-function buildEntity(
-  mileageUnit: string | { readonly field: string } | undefined,
-): EntityDefinition {
-  return {
-    fields: {
-      mileage: {
-        type: "number",
-        required: false,
-        ...(mileageUnit !== undefined && { unit: mileageUnit }),
-      },
-      mileageUnit: { type: "text", required: false },
-    },
-  } as EntityDefinition;
-}
-
-function buildScreen(): EntityEditScreenDefinition {
-  return {
-    id: "vehicle-edit",
-    type: "entityEdit",
-    entity: "vehicle",
-    layout: { sections: [{ columns: 1, fields: ["mileage", "mileageUnit"] }] },
-  } as EntityEditScreenDefinition;
-}
-
-function mileageField(
-  entity: EntityDefinition,
-  values: Record<string, unknown>,
-): EditFieldViewModel {
-  const vm = computeEditViewModel({
-    screen: buildScreen(),
-    entity,
-    values,
-    translate: (key) => key,
-    featureName: "fleet",
-  });
-  const section = vm.sections[0];
-  if (section === undefined || section.kind !== "fields") {
-    throw new Error("expected a fields section");
-  }
-  const field = section.fields.find((f) => f.field === "mileage");
-  if (field === undefined) throw new Error("expected a mileage field");
-  return field;
-}
-
-function currentInput(): InputProps {
-  if (captured === undefined) throw new Error("expected an Input to be captured");
-  return captured;
-}
-
-function renderMileageField(
-  entity: EntityDefinition,
-  values: Record<string, unknown>,
-  row?: Record<string, unknown>,
-): InputProps {
-  captured = undefined;
-  render(
-    <LocaleProvider resolver={createStaticLocaleResolver({ locale: "en-US" })}>
-      <PrimitivesProvider value={testPrimitives}>
-        <RenderField
-          field={mileageField(entity, values)}
-          onChange={() => {}}
-          {...(row !== undefined && { row })}
-        />
-      </PrimitivesProvider>
-    </LocaleProvider>,
-  );
-  if (captured === undefined) throw new Error("mileage field did not render an Input");
-  return captured;
-}
-
-describe("RenderField — editable number unit suffix", () => {
-  test("static unit resolves onto Input.unit, value stays untouched", () => {
-    const field = renderMileageField(buildEntity("km"), { mileage: 58 });
-    expect(field.kind).toBe("number");
-    if (field.kind !== "number") return;
-    expect(field.unit).toBe("km");
-    expect(field.value).toBe(58);
-  });
-
-  test("no unit configured: Input.unit is undefined", () => {
-    const field = renderMileageField(buildEntity(undefined), { mileage: 58 });
-    expect(field.kind).toBe("number");
-    if (field.kind !== "number") return;
-    expect(field.unit).toBeUndefined();
-  });
-
-  test("sibling-field unit resolves from the live row and updates when the sibling changes", () => {
-    const entity = buildEntity({ field: "mileageUnit" });
-    captured = undefined;
-    const { rerender } = render(
-      <LocaleProvider resolver={createStaticLocaleResolver({ locale: "en-US" })}>
-        <PrimitivesProvider value={testPrimitives}>
-          <RenderField
-            field={mileageField(entity, { mileage: 58, mileageUnit: "mi" })}
-            onChange={() => {}}
-            row={{ mileage: 58, mileageUnit: "mi" }}
-          />
-        </PrimitivesProvider>
-      </LocaleProvider>,
-    );
-    const first = currentInput();
-    if (first.kind !== "number") throw new Error("expected a number Input");
-    expect(first.unit).toBe("mi");
-
-    captured = undefined;
-    rerender(
-      <LocaleProvider resolver={createStaticLocaleResolver({ locale: "en-US" })}>
-        <PrimitivesProvider value={testPrimitives}>
-          <RenderField
-            field={mileageField(entity, { mileage: 58, mileageUnit: "km" })}
-            onChange={() => {}}
-            row={{ mileage: 58, mileageUnit: "km" }}
-          />
-        </PrimitivesProvider>
-      </LocaleProvider>,
-    );
-    const second = currentInput();
-    if (second.kind !== "number") throw new Error("expected a number Input");
-    expect(second.unit).toBe("km");
-  });
-
-  test("missing sibling field: no suffix, no crash, no guessed default", () => {
-    const entity = buildEntity({ field: "mileageUnit" });
-    const field = renderMileageField(entity, { mileage: 58 }, { mileage: 58 });
-    expect(field.kind).toBe("number");
-    if (field.kind !== "number") return;
-    expect(field.unit).toBeUndefined();
-  });
-
-  test("empty-string sibling value: no suffix, no guessed default", () => {
-    const entity = buildEntity({ field: "mileageUnit" });
-    const field = renderMileageField(
-      entity,
-      { mileage: 58, mileageUnit: "" },
-      {
-        mileage: 58,
-        mileageUnit: "",
-      },
-    );
-    expect(field.kind).toBe("number");
-    if (field.kind !== "number") return;
-    expect(field.unit).toBeUndefined();
-  });
-});
-
-describe("RenderField — number unit through the shipped client schema", () => {
-  function projectedVehicleEntity(
-    mileageUnit: string | { readonly field: string },
-  ): EntityDefinition {
-    const feature = defineFeature("fleet", (r) => {
-      r.entity("vehicle", buildEntity(mileageUnit));
-    });
-    const app = buildAppSchema(createRegistry([feature]));
-    const entity = app.features[0]?.entities["vehicle"];
-    if (entity === undefined) throw new Error("expected the projected vehicle entity");
-    // Mirrors the browser-injection pipeline, which ships the schema as JSON.
-    return JSON.parse(JSON.stringify(entity)) as EntityDefinition;
-  }
-
-  test("static unit survives buildAppSchema and reaches Input.unit", () => {
-    const field = renderMileageField(projectedVehicleEntity("mi"), { mileage: 58 });
-    if (field.kind !== "number") throw new Error("expected a number Input");
-    expect(field.unit).toBe("mi");
-  });
-
-  test("sibling-field unit survives buildAppSchema and resolves from the row", () => {
-    const field = renderMileageField(
-      projectedVehicleEntity({ field: "mileageUnit" }),
-      { mileage: 58, mileageUnit: "km" },
-      { mileage: 58, mileageUnit: "km" },
-    );
-    if (field.kind !== "number") throw new Error("expected a number Input");
-    expect(field.unit).toBe("km");
-  });
-});

package/src/components/__tests__/render-field-password-format.test.tsx

@@ -1,101 +0,0 @@
-// fw#2548: TextFieldDef.format "password" is a pure render hint — the
-// editable widget masks the input, and the read-only display never shows
-// the plaintext value.
-
-import { describe, expect, test } from "bun:test";
-import type { EditFieldViewModel } from "@cosmicdrift/kumiko-headless";
-import { render } from "@testing-library/react";
-import type { ComponentType, ReactNode } from "react";
-import { createStaticLocaleResolver, LocaleProvider } from "../../i18n";
-import {
-  type CorePrimitives,
-  type InputProps,
-  PrimitivesProvider,
-  type TextProps,
-} from "../../primitives";
-import { RenderField } from "../render-field";
-
-let capturedInput: InputProps | undefined;
-const captureInput: ComponentType<InputProps> = (props) => {
-  capturedInput = props;
-  return null;
-};
-let capturedText: TextProps | undefined;
-const captureText: ComponentType<TextProps> = (props) => {
-  capturedText = props;
-  return null;
-};
-const noop = (): ReactNode => null;
-const passChildren = ({ children }: { readonly children?: ReactNode }): ReactNode => children;
-
-const testPrimitives: CorePrimitives = {
-  Button: noop,
-  Banner: noop,
-  Field: passChildren,
-  Input: captureInput,
-  DataTable: noop,
-  Form: noop,
-  Section: noop,
-  Card: noop,
-  Grid: noop,
-  GridCell: noop,
-  Text: captureText,
-  Heading: noop,
-  Dialog: noop,
-  Modal: noop,
-  Lightbox: noop,
-  ConfigSourceBadge: noop,
-  ConfigCascadeView: noop,
-  Link: noop,
-};
-
-function textField(overrides: Partial<EditFieldViewModel> = {}): EditFieldViewModel {
-  return {
-    field: "apiToken",
-    label: "API token",
-    type: "text",
-    value: "s3cr3t",
-    visible: true,
-    readOnly: false,
-    required: false,
-    ...overrides,
-  };
-}
-
-function renderField(field: EditFieldViewModel, valueDisplay?: "form" | "text"): void {
-  capturedInput = undefined;
-  capturedText = undefined;
-  render(
-    <LocaleProvider resolver={createStaticLocaleResolver({ locale: "en-US" })}>
-      <PrimitivesProvider value={testPrimitives}>
-        <RenderField
-          field={field}
-          onChange={() => {}}
-          {...(valueDisplay !== undefined && { valueDisplay })}
-        />
-      </PrimitivesProvider>
-    </LocaleProvider>,
-  );
-}
-
-describe("RenderField — format: 'password'", () => {
-  test("editable password field renders Input kind=password", () => {
-    renderField(textField({ format: "password" }));
-    expect(capturedInput?.kind).toBe("password");
-  });
-
-  test("a plain text field (no format) still renders Input kind=text", () => {
-    renderField(textField());
-    expect(capturedInput?.kind).toBe("text");
-  });
-
-  test("read-only password field shows a fixed mask, never the plaintext", () => {
-    renderField(textField({ format: "password", readOnly: true }), "text");
-    expect(capturedText?.children).toBe("••••••••");
-  });
-
-  test("read-only password field with an empty value shows the empty placeholder, not the mask", () => {
-    renderField(textField({ format: "password", readOnly: true, value: "" }), "text");
-    expect(capturedText?.children).toBe("—");
-  });
-});

package/src/components/__tests__/render-field-select-display.test.tsx

@@ -1,134 +0,0 @@
-// SelectFieldDef.display travels the whole declarative chain (#2711):
-// EntityDefinition → computeEditViewModel → RenderField → InputProps. Without
-// it an app can only hope its labels fall under the renderer's heuristic.
-
-import { describe, expect, test } from "bun:test";
-import type {
-  EntityDefinition,
-  EntityEditScreenDefinition,
-} from "@cosmicdrift/kumiko-framework/ui-types";
-import { computeEditViewModel, type EditFieldViewModel } from "@cosmicdrift/kumiko-headless";
-import { render } from "@testing-library/react";
-import type { ComponentType, ReactNode } from "react";
-import { createStaticLocaleResolver, LocaleProvider } from "../../i18n";
-import { type CorePrimitives, type InputProps, PrimitivesProvider } from "../../primitives";
-import { RenderField } from "../render-field";
-
-let captured: InputProps | undefined;
-const captureInput: ComponentType<InputProps> = (props) => {
-  captured = props;
-  return null;
-};
-const noop = (): ReactNode => null;
-const passChildren = ({ children }: { readonly children?: ReactNode }): ReactNode => children;
-
-const testPrimitives: CorePrimitives = {
-  Button: noop,
-  Banner: noop,
-  Field: passChildren,
-  Input: captureInput,
-  DataTable: noop,
-  Form: noop,
-  Section: noop,
-  Card: noop,
-  Grid: noop,
-  GridCell: noop,
-  Text: noop,
-  Heading: noop,
-  Dialog: noop,
-  Modal: noop,
-  Lightbox: noop,
-  ConfigSourceBadge: noop,
-  ConfigCascadeView: noop,
-  Link: noop,
-};
-
-const AREAS = ["jobs", "mail", "search", "events", "tenants"] as const;
-
-function buildEntity(display: "radio" | "dropdown" | undefined): EntityDefinition {
-  return {
-    fields: {
-      area: {
-        type: "select",
-        required: false,
-        options: AREAS,
-        ...(display !== undefined && { display }),
-      },
-      tags: {
-        type: "multiSelect",
-        required: false,
-        options: AREAS,
-        display: "checkboxes",
-      },
-    },
-  } as EntityDefinition;
-}
-
-const editScreen: EntityEditScreenDefinition = {
-  id: "ticket-edit",
-  type: "entityEdit",
-  entity: "ticket",
-  layout: { sections: [{ columns: 1, fields: ["area", "tags"] }] },
-} as EntityEditScreenDefinition;
-
-function viewModelField(entity: EntityDefinition, fieldName: string): EditFieldViewModel {
-  const vm = computeEditViewModel({
-    screen: editScreen,
-    entity,
-    values: { area: "jobs", tags: [] },
-    translate: (key) => key,
-    featureName: "helpdesk",
-  });
-  const section = vm.sections[0];
-  if (section === undefined || section.kind !== "fields") {
-    throw new Error("expected a fields section");
-  }
-  const field = section.fields.find((f) => f.field === fieldName);
-  if (field === undefined) throw new Error(`expected a ${fieldName} field`);
-  return field;
-}
-
-function renderField(field: EditFieldViewModel): InputProps {
-  captured = undefined;
-  render(
-    <LocaleProvider resolver={createStaticLocaleResolver({ locale: "en-US" })}>
-      <PrimitivesProvider value={testPrimitives}>
-        <RenderField field={field} onChange={() => {}} />
-      </PrimitivesProvider>
-    </LocaleProvider>,
-  );
-  if (captured === undefined) throw new Error("field did not render an Input");
-  return captured;
-}
-
-describe("RenderField — select display request", () => {
-  test('display: "radio" on the field definition reaches the Input', () => {
-    const field = viewModelField(buildEntity("radio"), "area");
-    expect(field.display).toBe("radio");
-    const input = renderField(field);
-    expect(input.kind).toBe("select");
-    if (input.kind !== "select") return;
-    expect(input.display).toBe("radio");
-  });
-
-  test('display: "dropdown" on the field definition reaches the Input', () => {
-    const input = renderField(viewModelField(buildEntity("dropdown"), "area"));
-    expect(input.kind).toBe("select");
-    if (input.kind !== "select") return;
-    expect(input.display).toBe("dropdown");
-  });
-
-  test("no display on the field definition leaves the Input to its own default", () => {
-    const field = viewModelField(buildEntity(undefined), "area");
-    expect(field.display).toBeUndefined();
-    const input = renderField(field);
-    expect(input.kind).toBe("select");
-    if (input.kind !== "select") return;
-    expect(input.display).toBeUndefined();
-  });
-
-  test('multiSelect keeps its own "checkboxes" display untouched', () => {
-    const field = viewModelField(buildEntity("radio"), "tags");
-    expect(field.display).toBe("checkboxes");
-  });
-});

package/src/components/__tests__/render-field-unit-format.test.tsx

@@ -1,107 +0,0 @@
-// fw#2187: readOnly fields with an explicit `field.renderer: { format: "unit" }`
-// must render through applyFormatSpec's unit case, and default to the
-// LocaleProvider's App-Locale when the FormatSpec itself carries no `locale`
-// — same posture as render-field-app-locale.test.tsx for money/date inputs,
-// but for the FieldRendererOutput (readOnly + declared renderer) path, which
-// that file doesn't cover.
-//
-// Capture-Text instead of a real primitive, same pattern as
-// render-field-app-locale.test.tsx (Capture-Input there).
-
-import { describe, expect, test } from "bun:test";
-import type { EditFieldViewModel } from "@cosmicdrift/kumiko-headless";
-import { render } from "@testing-library/react";
-import type { ComponentType, ReactNode } from "react";
-import { createStaticLocaleResolver, LocaleProvider } from "../../i18n";
-import { type CorePrimitives, PrimitivesProvider, type TextProps } from "../../primitives";
-import { RenderField } from "../render-field";
-
-let captured: TextProps | undefined;
-const captureText: ComponentType<TextProps> = (props) => {
-  captured = props;
-  return null;
-};
-const noop = (): ReactNode => null;
-const passChildren = ({ children }: { readonly children?: ReactNode }): ReactNode => children;
-
-const testPrimitives: CorePrimitives = {
-  Button: noop,
-  Banner: noop,
-  Field: passChildren,
-  Input: noop,
-  DataTable: noop,
-  Form: noop,
-  Section: noop,
-  Card: noop,
-  Grid: noop,
-  GridCell: noop,
-  Text: captureText,
-  Heading: noop,
-  Dialog: noop,
-  Modal: noop,
-  Lightbox: noop,
-  ConfigSourceBadge: noop,
-  ConfigCascadeView: noop,
-  Link: noop,
-};
-
-function livingSpaceField(
-  renderer: EditFieldViewModel["renderer"],
-  value: unknown = 58,
-): EditFieldViewModel {
-  return {
-    field: "livingSpace",
-    label: "Wohnfläche",
-    type: "decimal",
-    value,
-    visible: true,
-    readOnly: true,
-    required: false,
-    renderer,
-  };
-}
-
-function renderUnderLocale(locale: string, field: EditFieldViewModel): void {
-  captured = undefined;
-  render(
-    <LocaleProvider resolver={createStaticLocaleResolver({ locale })}>
-      <PrimitivesProvider value={testPrimitives}>
-        <RenderField field={field} onChange={() => {}} />
-      </PrimitivesProvider>
-    </LocaleProvider>,
-  );
-}
-
-describe("RenderField — unit-FormatSpec (fw#2187)", () => {
-  test("m2 rendert Zahl + m²-Suffix, locale-formatiert über das App-Locale", () => {
-    renderUnderLocale("de-DE", livingSpaceField({ format: "unit", unit: "m2" }));
-    expect(captured?.children).toBe("58 m²");
-  });
-
-  test("ein anderes App-Locale ändert die Zahl-Formatierung (en-US: Punkt statt Komma)", () => {
-    renderUnderLocale("en-US", livingSpaceField({ format: "unit", unit: "m2" }, 58.5));
-    expect(captured?.children).toBe("58.5 m²");
-  });
-
-  test("CLDR-sanktionierte Unit (km) rendert über Intl.NumberFormat(style:'unit')", () => {
-    renderUnderLocale("en-US", livingSpaceField({ format: "unit", unit: "km" }, 3));
-    expect(captured?.children).toBe("3 km");
-  });
-
-  test("explizites renderer.locale gewinnt gegen das App-Locale", () => {
-    renderUnderLocale("en-US", livingSpaceField({ format: "unit", unit: "m2", locale: "de-DE" }));
-    expect(captured?.children).toBe("58 m²");
-  });
-});
-
-describe("RenderField — App-Locale an FieldRendererOutput durchreichen (fw#2187)", () => {
-  test("number-FormatSpec ohne eigenes locale bekommt das App-Locale (de-DE, Komma statt Punkt)", () => {
-    renderUnderLocale("de-DE", livingSpaceField({ format: "number" }, 1234.5));
-    expect(captured?.children).toBe("1.234,5");
-  });
-
-  test("explicit locale: undefined still falls back to App-Locale (#2332)", () => {
-    renderUnderLocale("de-DE", livingSpaceField({ format: "number", locale: undefined }, 1234.5));
-    expect(captured?.children).toBe("1.234,5");
-  });
-});