@cosmicdrift/kumiko-renderer 0.327.0 → 0.328.1

package/src/app/__tests__/projection-list-bad-shape.test.tsx

@@ -1,152 +0,0 @@
-// fw#2216: a projectionList query handler that doesn't honor the PagedRows
-// contract ({ rows, nextCursor }) used to fall through `rowsQuery.data?.rows
-// ?? []` and silently render an empty table with HTTP 200 (prod bug on
-// /session-list). This renders the real path (KumikoScreen →
-// ProjectionListBody → RenderList) under a stub dispatcher returning a bare
-// array, and proves the renderer-level shape guard surfaces an error banner
-// instead of an empty list — plus that a correctly-shaped response still
-// renders rows.
-
-import { describe, expect, test } from "bun:test";
-import type { ProjectionListScreenDefinition } from "@cosmicdrift/kumiko-framework/ui-types";
-import type { Dispatcher } from "@cosmicdrift/kumiko-headless";
-import { render, waitFor } from "@testing-library/react";
-import type { ComponentType, ReactNode } from "react";
-import { DispatcherProvider } from "../../context/dispatcher-context";
-import { createStaticLocaleResolver, LocaleProvider } from "../../i18n";
-import { kumikoDefaultTranslations } from "../../i18n-defaults";
-import {
-  type BannerProps,
-  type CorePrimitives,
-  type DataTableProps,
-  PrimitivesProvider,
-} from "../../primitives";
-import type { FeatureSchema } from "../feature-schema";
-import { KumikoScreen } from "../kumiko-screen";
-import type { NavApi } from "../nav";
-import { NavProvider } from "../nav";
-
-let capturedProps: DataTableProps | undefined;
-const captureDataTable: ComponentType<DataTableProps> = (props) => {
-  capturedProps = props;
-  return null;
-};
-const getCapturedProps = (): DataTableProps | undefined => capturedProps;
-const noop = (): ReactNode => null;
-const passChildren = ({ children }: { readonly children?: ReactNode }): ReactNode => children;
-
-// passChildren would drop testId — the bad-shape test asserts on which
-// banner rendered, so it needs a real (if minimal) wrapper element.
-const TestBanner: ComponentType<BannerProps> = ({ children, testId }) => (
-  <div data-testid={testId}>{children}</div>
-);
-
-const testPrimitives: CorePrimitives = {
-  Button: noop,
-  Banner: TestBanner,
-  Field: passChildren,
-  Input: noop,
-  DataTable: captureDataTable,
-  Form: passChildren,
-  Section: passChildren,
-  Card: passChildren,
-  Grid: passChildren,
-  GridCell: passChildren,
-  Text: passChildren,
-  Heading: noop,
-  Dialog: noop,
-  Modal: noop,
-  Lightbox: noop,
-  ConfigSourceBadge: noop,
-  ConfigCascadeView: noop,
-  Link: noop,
-};
-
-function stubDispatcher(queryResult: unknown): Dispatcher {
-  return {
-    write: (async () => ({ isSuccess: true, data: {} })) as unknown as Dispatcher["write"],
-    query: (async () => ({ isSuccess: true, data: queryResult })) as unknown as Dispatcher["query"],
-    batch: (async () => ({ isSuccess: true, results: [] })) as unknown as Dispatcher["batch"],
-    statusStore: {
-      getState: () => "online",
-      subscribe: () => () => {},
-    } as unknown as Dispatcher["statusStore"],
-    async *stream() {},
-    pendingWrites: () => [],
-    pendingFiles: () => [],
-  };
-}
-
-function buildSchema(screen: ProjectionListScreenDefinition): FeatureSchema {
-  return {
-    featureName: "ledger",
-    entities: {},
-    screens: [screen],
-  } as FeatureSchema;
-}
-
-const nav: NavApi = {
-  route: { screenId: "ledger:screen:schedule-list" },
-  navigate: () => {},
-  replace: () => {},
-  hrefFor: () => "",
-  searchParams: {},
-  setSearchParams: () => {},
-};
-
-function renderProjectionList(
-  screen: ProjectionListScreenDefinition,
-  queryResult: unknown,
-): ReturnType<typeof render> {
-  return render(
-    <LocaleProvider
-      resolver={createStaticLocaleResolver({ locale: "de-DE" })}
-      fallbackBundles={[kumikoDefaultTranslations]}
-    >
-      <DispatcherProvider dispatcher={stubDispatcher(queryResult)}>
-        <NavProvider value={nav}>
-          <PrimitivesProvider value={testPrimitives}>
-            <KumikoScreen schema={buildSchema(screen)} qn="ledger:screen:schedule-list" />
-          </PrimitivesProvider>
-        </NavProvider>
-      </DispatcherProvider>
-    </LocaleProvider>,
-  );
-}
-
-const screen: ProjectionListScreenDefinition = {
-  id: "schedule-list",
-  type: "projectionList",
-  query: "ledger:query:schedule:list",
-  columns: ["description"],
-};
-
-describe("ProjectionListBody — PagedRows shape guard (fw#2216)", () => {
-  test("a bare-array query response renders the bad-shape error banner, not an empty table", async () => {
-    capturedProps = undefined;
-    const { container } = renderProjectionList(screen, [{ id: "1", description: "acme" }]);
-
-    const banner = await waitFor(() => {
-      const el = container.querySelector('[data-testid="kumiko-screen-projection-list-bad-shape"]');
-      if (el === null) throw new Error("bad-shape banner not rendered");
-      return el;
-    });
-    expect(banner.textContent).toContain("schedule-list");
-    expect(banner.textContent).toContain("ledger:query:schedule:list");
-    expect(getCapturedProps()).toBeUndefined();
-  });
-
-  test("a correct { rows, nextCursor } response renders the rows, no error banner", async () => {
-    capturedProps = undefined;
-    const { container } = renderProjectionList(screen, {
-      rows: [{ id: "1", description: "acme" }],
-      nextCursor: null,
-    });
-
-    await waitFor(() => expect(getCapturedProps()).toBeDefined());
-    expect(getCapturedProps()?.rows).toHaveLength(1);
-    expect(
-      container.querySelector('[data-testid="kumiko-screen-projection-list-bad-shape"]'),
-    ).toBeNull();
-  });
-});

package/src/app/__tests__/projection-list-reference-column.test.tsx

@@ -1,219 +0,0 @@
-// fw#2662: projectionList columns have no EntityDefinition to carry a real
-// "reference" field type (the shim hardcodes every field as "text"), so a
-// declared reference column used to render the raw GUID. This renders the
-// real path (KumikoScreen -> ProjectionListScreen -> RenderList ->
-// useReferenceLookup) under a stub dispatcher, and reads the resolved cell
-// text back off the reference column's injected runtime renderer.
-
-import { describe, expect, test } from "bun:test";
-import type {
-  ListColumnSpec,
-  ProjectionListScreenDefinition,
-} from "@cosmicdrift/kumiko-framework/ui-types";
-import type { Dispatcher, RuntimeRenderer } from "@cosmicdrift/kumiko-headless";
-import { render, waitFor } from "@testing-library/react";
-import type { ComponentType, ReactNode } from "react";
-import { DispatcherProvider } from "../../context/dispatcher-context";
-import { createStaticLocaleResolver, LocaleProvider } from "../../i18n";
-import { kumikoDefaultTranslations } from "../../i18n-defaults";
-import { type CorePrimitives, type DataTableProps, PrimitivesProvider } from "../../primitives";
-import type { FeatureSchema } from "../feature-schema";
-import { KumikoScreen } from "../kumiko-screen";
-import type { NavApi } from "../nav";
-import { NavProvider } from "../nav";
-
-const SYSTEM_TENANT_ID = "00000000-0000-4000-8000-000000000000";
-const REAL_TENANT_ID = "11111111-1111-4111-8111-111111111111";
-const SYSTEM_USER_ID = "00000000-0000-0000-0000-000000000000";
-const REAL_USER_ID = "22222222-2222-4222-8222-222222222222";
-const DELETED_USER_ID = "33333333-3333-4333-8333-333333333333";
-
-let capturedProps: DataTableProps | undefined;
-const captureDataTable: ComponentType<DataTableProps> = (props) => {
-  capturedProps = props;
-  return null;
-};
-const getCapturedProps = (): DataTableProps | undefined => capturedProps;
-const noop = (): ReactNode => null;
-const passChildren = ({ children }: { readonly children?: ReactNode }): ReactNode => children;
-
-const testPrimitives: CorePrimitives = {
-  Button: noop,
-  Banner: passChildren,
-  Field: passChildren,
-  Input: noop,
-  DataTable: captureDataTable,
-  Form: passChildren,
-  Section: passChildren,
-  Card: passChildren,
-  Grid: passChildren,
-  GridCell: passChildren,
-  Text: passChildren,
-  Heading: noop,
-  Dialog: noop,
-  Modal: noop,
-  Lightbox: noop,
-  ConfigSourceBadge: noop,
-  ConfigCascadeView: noop,
-  Link: noop,
-};
-
-function stubDispatcher(): Dispatcher {
-  return {
-    write: (async () => ({ isSuccess: true, data: {} })) as unknown as Dispatcher["write"],
-    query: (async (type: string) => {
-      if (type === "delivery:query:log:list") {
-        return {
-          isSuccess: true,
-          data: {
-            rows: [
-              { id: "row-1", tenantId: REAL_TENANT_ID, createdBy: REAL_USER_ID },
-              { id: "row-2", tenantId: SYSTEM_TENANT_ID, createdBy: SYSTEM_USER_ID },
-              { id: "row-3", tenantId: REAL_TENANT_ID, createdBy: DELETED_USER_ID },
-            ],
-            nextCursor: null,
-          },
-        };
-      }
-      // tenant:tenant resolves through the tenant directory, not the
-      // SystemAdmin-only tenant:query:tenant:list a TenantAdmin can't call
-      // (fw#3142).
-      if (type === "tenant:query:tenant-directory") {
-        return {
-          isSuccess: true,
-          data: { rows: [{ id: REAL_TENANT_ID, label: "Acme Inc" }], nextCursor: null },
-        };
-      }
-      // user:user resolves through the tenant-scoped member directory, not the
-      // SystemAdmin-only user:query:user:list a TenantAdmin can't call (fw#3107).
-      if (type === "tenant:query:member-directory") {
-        return {
-          isSuccess: true,
-          data: { rows: [{ id: REAL_USER_ID, label: "Ada Lovelace" }], nextCursor: null },
-        };
-      }
-      return { isSuccess: true, data: { rows: [], nextCursor: null } };
-    }) as unknown as Dispatcher["query"],
-    batch: (async () => ({ isSuccess: true, results: [] })) as unknown as Dispatcher["batch"],
-    statusStore: {
-      getState: () => "online",
-      subscribe: () => () => {},
-    } as unknown as Dispatcher["statusStore"],
-    async *stream() {},
-    pendingWrites: () => [],
-    pendingFiles: () => [],
-  };
-}
-
-function buildSchema(screen: ProjectionListScreenDefinition): FeatureSchema {
-  return {
-    featureName: "delivery",
-    entities: {},
-    screens: [screen],
-  } as FeatureSchema;
-}
-
-const TENANT_COLUMN: ListColumnSpec = {
-  field: "tenantId",
-  label: "delivery.log.col.tenantId",
-  refEntity: "tenant:tenant",
-  refLabelField: "name",
-};
-
-// Mirrors the audit-log actor column (fw#3103).
-const ACTOR_COLUMN: ListColumnSpec = {
-  field: "createdBy",
-  label: "audit.log.col.actor",
-  refEntity: "user:user",
-  refLabelField: "displayName",
-};
-
-const staticNav: NavApi = {
-  route: { screenId: "delivery:screen:log" },
-  navigate: () => {},
-  replace: () => {},
-  hrefFor: () => "",
-  searchParams: {},
-  setSearchParams: () => {},
-};
-
-function renderLogScreen(column: ListColumnSpec = TENANT_COLUMN): void {
-  const screen: ProjectionListScreenDefinition = {
-    id: "log",
-    type: "projectionList",
-    query: "delivery:query:log:list",
-    columns: [column],
-  };
-  render(
-    <LocaleProvider
-      resolver={createStaticLocaleResolver({ locale: "en" })}
-      fallbackBundles={[kumikoDefaultTranslations]}
-    >
-      <DispatcherProvider dispatcher={stubDispatcher()}>
-        <NavProvider value={staticNav}>
-          <PrimitivesProvider value={testPrimitives}>
-            <KumikoScreen schema={buildSchema(screen)} qn="delivery:screen:log" />
-          </PrimitivesProvider>
-        </NavProvider>
-      </DispatcherProvider>
-    </LocaleProvider>,
-  );
-}
-
-function referenceRenderer(field = "tenantId"): RuntimeRenderer {
-  const col = getCapturedProps()?.columns.find((c) => c.field === field);
-  if (typeof col?.renderer !== "function") throw new Error("reference column has no renderer yet");
-  return col.renderer as RuntimeRenderer;
-}
-
-describe("projectionList reference column resolves labels (fw#2662)", () => {
-  test("a real tenant id resolves to its name instead of the raw GUID", async () => {
-    capturedProps = undefined;
-    renderLogScreen();
-
-    await waitFor(() => {
-      expect(referenceRenderer()(REAL_TENANT_ID, { tenantId: REAL_TENANT_ID })).toBe("Acme Inc");
-    });
-  });
-
-  test("SYSTEM_TENANT_ID resolves to the system label instead of the raw GUID", async () => {
-    capturedProps = undefined;
-    renderLogScreen();
-
-    await waitFor(() => {
-      expect(referenceRenderer()(SYSTEM_TENANT_ID, { tenantId: SYSTEM_TENANT_ID })).toBe("System");
-    });
-  });
-});
-
-describe("actor column resolves display names (fw#3103)", () => {
-  const actorCell = (id: string): unknown => referenceRenderer("createdBy")(id, { createdBy: id });
-
-  test("a real user id resolves to the display name", async () => {
-    capturedProps = undefined;
-    renderLogScreen(ACTOR_COLUMN);
-
-    await waitFor(() => {
-      expect(actorCell(REAL_USER_ID)).toBe("Ada Lovelace");
-    });
-  });
-
-  test("SYSTEM_USER_ID resolves to the system label", async () => {
-    capturedProps = undefined;
-    renderLogScreen(ACTOR_COLUMN);
-
-    await waitFor(() => {
-      expect(actorCell(SYSTEM_USER_ID)).toBe("System");
-    });
-  });
-
-  test("an unresolvable actor (deleted user) falls back to the raw id without throwing", async () => {
-    capturedProps = undefined;
-    renderLogScreen(ACTOR_COLUMN);
-
-    await waitFor(() => {
-      expect(actorCell(REAL_USER_ID)).toBe("Ada Lovelace");
-    });
-    expect(actorCell(DELETED_USER_ID)).toBe(DELETED_USER_ID);
-  });
-});

package/src/app/__tests__/projection-list-search-sort.test.tsx

@@ -1,212 +0,0 @@
-// fw#2165: ProjectionListBody used to fetch with a hardcoded empty payload —
-// search/sort/pagination were rendered but had no effect. This renders the
-// real path (KumikoScreen → ProjectionListScreen → ProjectionListBody →
-// RenderList) under a stub dispatcher that records every query() call, and a
-// stateful NavProvider so setSearchParams actually re-renders — proving the
-// URL-state → payload wiring for the two capabilities buildAppSchema derives
-// per-screen (searchable, sortable).
-
-import { describe, expect, test } from "bun:test";
-import type { ProjectionListScreenDefinition } from "@cosmicdrift/kumiko-framework/ui-types";
-import type { Dispatcher } from "@cosmicdrift/kumiko-headless";
-import { act, render, waitFor } from "@testing-library/react";
-import { type ComponentType, type ReactNode, useState } from "react";
-import { DispatcherProvider } from "../../context/dispatcher-context";
-import { createStaticLocaleResolver, LocaleProvider } from "../../i18n";
-import { kumikoDefaultTranslations } from "../../i18n-defaults";
-import { type CorePrimitives, type DataTableProps, PrimitivesProvider } from "../../primitives";
-import type { FeatureSchema } from "../feature-schema";
-import { KumikoScreen } from "../kumiko-screen";
-import type { NavApi } from "../nav";
-import { NavProvider } from "../nav";
-
-let capturedProps: DataTableProps | undefined;
-const captureDataTable: ComponentType<DataTableProps> = (props) => {
-  capturedProps = props;
-  return null;
-};
-// Indirection defeats TS narrowing `capturedProps` to `undefined` at read
-// sites — the compiler can't see that `captureDataTable` (a React render
-// callback) reassigns it between the reset and the read.
-const getCapturedProps = (): DataTableProps | undefined => capturedProps;
-const noop = (): ReactNode => null;
-const passChildren = ({ children }: { readonly children?: ReactNode }): ReactNode => children;
-
-const testPrimitives: CorePrimitives = {
-  Button: noop,
-  Banner: passChildren,
-  Field: passChildren,
-  Input: noop,
-  DataTable: captureDataTable,
-  Form: passChildren,
-  Section: passChildren,
-  Card: passChildren,
-  Grid: passChildren,
-  GridCell: passChildren,
-  Text: passChildren,
-  Heading: noop,
-  Dialog: noop,
-  Modal: noop,
-  Lightbox: noop,
-  ConfigSourceBadge: noop,
-  ConfigCascadeView: noop,
-  Link: noop,
-};
-
-let queryCalls: Array<{ readonly type: string; readonly payload: unknown }> = [];
-
-function stubDispatcher(): Dispatcher {
-  return {
-    write: (async () => ({ isSuccess: true, data: {} })) as unknown as Dispatcher["write"],
-    query: (async (type: string, payload: unknown) => {
-      queryCalls.push({ type, payload });
-      return { isSuccess: true, data: { rows: [], nextCursor: null } };
-    }) as unknown as Dispatcher["query"],
-    batch: (async () => ({ isSuccess: true, results: [] })) as unknown as Dispatcher["batch"],
-    statusStore: {
-      getState: () => "online",
-      subscribe: () => () => {},
-    } as unknown as Dispatcher["statusStore"],
-    async *stream() {},
-    pendingWrites: () => [],
-    pendingFiles: () => [],
-  };
-}
-
-function buildSchema(screen: ProjectionListScreenDefinition): FeatureSchema {
-  return {
-    featureName: "ledger",
-    entities: {},
-    screens: [screen],
-  } as FeatureSchema;
-}
-
-// Stateful nav so setSearchParams (called by useListUrlState) actually
-// re-renders the tree — a plain mock object wouldn't trigger React.
-function StatefulNav({
-  initialParams,
-  children,
-}: {
-  readonly initialParams: Record<string, string>;
-  readonly children: ReactNode;
-}): ReactNode {
-  const [params, setParams] = useState<Record<string, string>>(initialParams);
-  const value: NavApi = {
-    route: { screenId: "ledger:screen:schedule-list" },
-    navigate: () => {},
-    replace: () => {},
-    hrefFor: () => "",
-    searchParams: params,
-    setSearchParams: (updates) => {
-      setParams((prev) => {
-        const next = { ...prev };
-        for (const [k, v] of Object.entries(updates)) {
-          if (v === null) delete next[k];
-          else next[k] = v;
-        }
-        return next;
-      });
-    },
-  };
-  return <NavProvider value={value}>{children}</NavProvider>;
-}
-
-function renderProjectionList(
-  screen: ProjectionListScreenDefinition,
-  initialParams: Record<string, string> = {},
-): void {
-  render(
-    <LocaleProvider
-      resolver={createStaticLocaleResolver({ locale: "de-DE" })}
-      fallbackBundles={[kumikoDefaultTranslations]}
-    >
-      <DispatcherProvider dispatcher={stubDispatcher()}>
-        <StatefulNav initialParams={initialParams}>
-          <PrimitivesProvider value={testPrimitives}>
-            <KumikoScreen schema={buildSchema(screen)} qn="ledger:screen:schedule-list" />
-          </PrimitivesProvider>
-        </StatefulNav>
-      </DispatcherProvider>
-    </LocaleProvider>,
-  );
-}
-
-describe("ProjectionListBody — search/sort capability wiring (fw#2165)", () => {
-  test("search-capable screen: a URL search term lands in the query payload", async () => {
-    queryCalls = [];
-    renderProjectionList(
-      {
-        id: "schedule-list",
-        type: "projectionList",
-        query: "ledger:query:schedule:list",
-        columns: ["description"],
-        searchable: true,
-      },
-      { "schedule-list.q": "acme" },
-    );
-
-    await waitFor(() => expect(queryCalls.length).toBeGreaterThan(0));
-    expect(queryCalls[0]?.payload).toMatchObject({ search: "acme" });
-  });
-
-  test("non-search-capable screen: the same URL search term is NOT sent (schema doesn't accept it)", async () => {
-    queryCalls = [];
-    renderProjectionList(
-      {
-        id: "schedule-list",
-        type: "projectionList",
-        query: "ledger:query:schedule:list",
-        columns: ["description"],
-        searchable: false,
-      },
-      { "schedule-list.q": "acme" },
-    );
-
-    await waitFor(() => expect(queryCalls.length).toBeGreaterThan(0));
-    expect(queryCalls[0]?.payload).not.toHaveProperty("search");
-  });
-
-  test("sort-capable screen: the column is rendered sortable, and a header click updates state and payload", async () => {
-    queryCalls = [];
-    capturedProps = undefined;
-    renderProjectionList({
-      id: "schedule-list",
-      type: "projectionList",
-      query: "ledger:query:schedule:list",
-      columns: ["description"],
-      sortable: true,
-      defaultSort: { field: "description", dir: "asc" },
-    });
-
-    await waitFor(() => expect(capturedProps).toBeDefined());
-    const sortableProps = getCapturedProps();
-    if (sortableProps === undefined) throw new Error("DataTable was not rendered");
-    // Column-click affordance is only wired when the query schema accepts
-    // sort — DefaultDataTable gates the header click on col.sortable.
-    expect(sortableProps.columns.find((c) => c.field === "description")?.sortable).toBe(true);
-
-    const countBeforeClick = queryCalls.length;
-    await act(async () => {
-      capturedProps?.onSortChange?.({ field: "description", dir: "desc" });
-    });
-
-    await waitFor(() => expect(queryCalls.length).toBeGreaterThan(countBeforeClick));
-    const lastPayload = queryCalls[queryCalls.length - 1]?.payload;
-    expect(lastPayload).toMatchObject({ sort: "description", sortDirection: "desc" });
-  });
-
-  test("non-sort-capable screen: the column is rendered NOT sortable", async () => {
-    capturedProps = undefined;
-    renderProjectionList({
-      id: "schedule-list",
-      type: "projectionList",
-      query: "ledger:query:schedule:list",
-      columns: ["description"],
-    });
-
-    await waitFor(() => expect(capturedProps).toBeDefined());
-    const notSortableProps = getCapturedProps();
-    if (notSortableProps === undefined) throw new Error("DataTable was not rendered");
-    expect(notSortableProps.columns.find((c) => c.field === "description")?.sortable).toBe(false);
-  });
-});

package/src/app/__tests__/qualified-names.test.ts

@@ -1,37 +0,0 @@
-// Qualified-Name Pure-Logik Tests (Phase 1, test-luecken-integration, Tier 1).
-//
-// lastSegment (qn.ts) ist die Inverse von qualifyScreenId/qualifyNavId
-// (kumiko-screen.tsx) — Schema speichert QN-Form, der Renderer/die URL
-// nutzt Short-Form. Roundtrip pinnt diese Symmetrie.
-
-import { describe, expect, test } from "bun:test";
-import { qualifyNavId, qualifyScreenId } from "../kumiko-screen";
-import { lastSegment } from "../qn";
-
-describe("lastSegment", () => {
-  test("nimmt den letzten ':'-getrennten Teil", () => {
-    expect(lastSegment("tasks:screen:task-list")).toBe("task-list");
-    expect(lastSegment("a:b")).toBe("b");
-  });
-
-  test("String ohne ':' bleibt unverändert (Short-Form passt durch)", () => {
-    expect(lastSegment("task-list")).toBe("task-list");
-    expect(lastSegment("")).toBe("");
-  });
-
-  test("trailing ':' → leerer Suffix", () => {
-    expect(lastSegment("a:")).toBe("");
-  });
-});
-
-describe("qualifyScreenId / qualifyNavId", () => {
-  test("baut featureName:screen:id bzw. featureName:nav:id", () => {
-    expect(qualifyScreenId("tasks", "task-list")).toBe("tasks:screen:task-list");
-    expect(qualifyNavId("tasks", "main")).toBe("tasks:nav:main");
-  });
-
-  test("lastSegment ist die Inverse von qualify*", () => {
-    expect(lastSegment(qualifyScreenId("tasks", "task-list"))).toBe("task-list");
-    expect(lastSegment(qualifyNavId("tasks", "main"))).toBe("main");
-  });
-});