@cosmicdrift/kumiko-renderer 0.327.0 → 0.328.1

package/src/app/__tests__/content-editors.test.tsx

@@ -1,128 +0,0 @@
-import { describe, expect, test } from "bun:test";
-import type { ContentEditorFormat } from "@cosmicdrift/kumiko-types/nav";
-import { render, screen } from "@testing-library/react";
-import type { ComponentType, ReactNode } from "react";
-import { type CorePrimitives, type InputProps, PrimitivesProvider } from "../../primitives";
-import {
-  CONTENT_EDITOR_ELEMENT_ID,
-  type ContentEditorProps,
-  ContentEditorsProvider,
-  TextareaContentEditor,
-  useContentEditor,
-} from "../content-editors";
-
-const captureInput: ComponentType<InputProps> = (props) => {
-  if (props.kind !== "textarea") return null;
-  return (
-    <textarea
-      data-testid="ca-textarea"
-      id={props.id}
-      value={props.value}
-      disabled={props.disabled}
-      readOnly={props.readOnly}
-      onChange={() => {}}
-    />
-  );
-};
-
-const noop = (): ReactNode => null;
-const passChildren = ({ children }: { readonly children?: ReactNode }): ReactNode => children;
-
-const testPrimitives: CorePrimitives = {
-  Button: noop,
-  Banner: passChildren,
-  Field: passChildren,
-  Input: captureInput,
-  DataTable: noop,
-  Form: passChildren,
-  Section: passChildren,
-  Card: passChildren,
-  Grid: passChildren,
-  GridCell: passChildren,
-  Text: passChildren,
-  Heading: noop,
-  Dialog: noop,
-  Modal: noop,
-  Lightbox: noop,
-  ConfigSourceBadge: noop,
-  ConfigCascadeView: noop,
-  Link: noop,
-};
-
-function RichEditor({ value }: ContentEditorProps): ReactNode {
-  return <div data-testid="ca-rich">{value}</div>;
-}
-
-function Wrapper({ children }: { readonly children: ReactNode }): ReactNode {
-  return <PrimitivesProvider value={testPrimitives}>{children}</PrimitivesProvider>;
-}
-
-function Probe({ contentFormat }: { readonly contentFormat?: ContentEditorFormat }): ReactNode {
-  const Editor = useContentEditor(contentFormat);
-  return (
-    <Editor
-      id={CONTENT_EDITOR_ELEMENT_ID}
-      value="hello"
-      onChange={() => {}}
-      variables={[]}
-      readOnly={false}
-    />
-  );
-}
-
-describe("useContentEditor", () => {
-  test("no editor registered for the format → falls back to the textarea", () => {
-    render(<Probe contentFormat="plain" />, { wrapper: Wrapper });
-    expect(screen.getByTestId("ca-textarea")).toBeTruthy();
-    expect(screen.getByTestId("ca-textarea").id).toBe(CONTENT_EDITOR_ELEMENT_ID);
-  });
-
-  test("undefined contentFormat behaves like plain", () => {
-    render(<Probe />, { wrapper: Wrapper });
-    expect(screen.getByTestId("ca-textarea")).toBeTruthy();
-  });
-
-  test("an app-registered editor for the format wins over the textarea fallback", () => {
-    render(
-      <ContentEditorsProvider value={{ rich: RichEditor }}>
-        <Probe contentFormat="rich" />
-      </ContentEditorsProvider>,
-      { wrapper: Wrapper },
-    );
-    expect(screen.getByTestId("ca-rich").textContent).toBe("hello");
-    expect(screen.queryByTestId("ca-textarea")).toBeNull();
-  });
-
-  test("a registered editor only applies to its own format — other formats stay on the fallback", () => {
-    render(
-      <ContentEditorsProvider value={{ rich: RichEditor }}>
-        <Probe contentFormat="plain" />
-      </ContentEditorsProvider>,
-      { wrapper: Wrapper },
-    );
-    expect(screen.getByTestId("ca-textarea")).toBeTruthy();
-    expect(screen.queryByTestId("ca-rich")).toBeNull();
-  });
-});
-
-describe("TextareaContentEditor", () => {
-  test("passes value + readOnly through to the primitives Input as real readOnly, not disabled", () => {
-    // A disabled textarea isn't focusable/selectable in most browsers — a
-    // non-admin viewing read-only content couldn't select/copy it. readOnly
-    // keeps the field focusable and selectable while blocking edits.
-    render(
-      <TextareaContentEditor
-        id={CONTENT_EDITOR_ELEMENT_ID}
-        value="draft"
-        onChange={() => {}}
-        variables={[]}
-        readOnly={true}
-      />,
-      { wrapper: Wrapper },
-    );
-    const el = screen.getByTestId("ca-textarea") as HTMLTextAreaElement;
-    expect(el.value).toBe("draft");
-    expect(el.readOnly).toBe(true);
-    expect(el.disabled).toBe(false);
-  });
-});

package/src/app/__tests__/content-preview.test.tsx

@@ -1,184 +0,0 @@
-import { describe, expect, test } from "bun:test";
-import { render, screen } from "@testing-library/react";
-import type { ComponentType, ReactNode } from "react";
-import { type CorePrimitives, type InputProps, PrimitivesProvider } from "../../primitives";
-import { type ContentEditorProps, ContentEditorsProvider } from "../content-editors";
-import { ContentPreview, substituteVariables } from "../content-preview";
-
-const noop = (): ReactNode => null;
-const passChildren = ({ children }: { readonly children?: ReactNode }): ReactNode => children;
-
-const captureInput: ComponentType<InputProps> = (props) => {
-  if (props.kind !== "textarea") return null;
-  return (
-    <textarea data-testid="cp-textarea" value={props.value} disabled={props.disabled} readOnly />
-  );
-};
-
-const testPrimitives: CorePrimitives = {
-  Button: noop,
-  Banner: passChildren,
-  Field: passChildren,
-  Input: captureInput,
-  DataTable: noop,
-  Form: passChildren,
-  Section: passChildren,
-  Card: passChildren,
-  Grid: passChildren,
-  GridCell: passChildren,
-  Text: passChildren,
-  Heading: noop,
-  Dialog: noop,
-  Modal: noop,
-  Lightbox: noop,
-  ConfigSourceBadge: noop,
-  ConfigCascadeView: noop,
-  Link: noop,
-};
-
-function Wrapper({ children }: { readonly children: ReactNode }): ReactNode {
-  return <PrimitivesProvider value={testPrimitives}>{children}</PrimitivesProvider>;
-}
-
-describe("substituteVariables", () => {
-  test("replaces every {{name}} with its example value", () => {
-    expect(
-      substituteVariables("Hi {{customerName}}, order {{orderId}} shipped.", {
-        customerName: "Max Mustermann",
-        orderId: "A-1042",
-      }),
-    ).toBe("Hi Max Mustermann, order A-1042 shipped.");
-  });
-
-  test("a name with no example value stays as the literal placeholder", () => {
-    expect(substituteVariables("Hi {{customerName}}", {})).toBe("Hi {{customerName}}");
-    expect(substituteVariables("Hi {{constructor}}", {})).toBe("Hi {{constructor}}");
-  });
-
-  test("no variables in the content → content passes through unchanged", () => {
-    expect(substituteVariables("Just plain text.", { customerName: "Max" })).toBe(
-      "Just plain text.",
-    );
-  });
-});
-
-describe("ContentPreview", () => {
-  test("rich format escapes attribute-breaking quotes in substituted values", () => {
-    function RichEditor({ value }: ContentEditorProps): ReactNode {
-      // biome-ignore lint/security/noDangerouslySetInnerHtml: XSS regression fixture for escapeHtml
-      return <div data-testid="rich" dangerouslySetInnerHTML={{ __html: value }} />;
-    }
-    render(
-      <Wrapper>
-        <ContentEditorsProvider value={{ rich: RichEditor }}>
-          <ContentPreview
-            content={'<a href="{{url}}">x</a>'}
-            variables={{ url: '" onerror="x' }}
-            contentFormat="rich"
-          />
-        </ContentEditorsProvider>
-      </Wrapper>,
-    );
-    const html = screen.getByTestId("rich").innerHTML;
-    expect(html).toContain("&quot;");
-    expect(html).not.toContain('onerror="x');
-  });
-
-  test("renders the format's registered editor read-only, with variables substituted", () => {
-    function RichEditor({ value, readOnly }: ContentEditorProps): ReactNode {
-      return (
-        <div data-testid="cp-rich" data-readonly={readOnly}>
-          {value}
-        </div>
-      );
-    }
-
-    render(
-      <ContentEditorsProvider value={{ rich: RichEditor }}>
-        <ContentPreview
-          content="Hallo {{customerName}}"
-          variables={{ customerName: "Max Mustermann" }}
-          contentFormat="rich"
-        />
-      </ContentEditorsProvider>,
-      { wrapper: Wrapper },
-    );
-
-    const el = screen.getByTestId("cp-rich");
-    expect(el.textContent).toBe("Hallo Max Mustermann");
-    expect(el.dataset["readonly"]).toBe("true");
-  });
-
-  test("no editor registered for the format → falls back to the textarea, still substituted", () => {
-    render(
-      <ContentPreview
-        content="Hi {{orderId}}"
-        variables={{ orderId: "A-1042" }}
-        contentFormat="plain"
-      />,
-      { wrapper: Wrapper },
-    );
-
-    const el = screen.getByTestId("cp-textarea") as HTMLTextAreaElement;
-    expect(el.value).toBe("Hi A-1042");
-    expect(el.readOnly).toBe(true);
-    expect(el.disabled).toBe(false);
-  });
-
-  test("rich format: an example value with markup characters is escaped, not injected as HTML", () => {
-    function RichEditor({ value }: ContentEditorProps): ReactNode {
-      // biome-ignore lint/security/noDangerouslySetInnerHtml: proves the substituted value is escaped, not injected — the whole point of this test.
-      return <div data-testid="cp-rich" dangerouslySetInnerHTML={{ __html: value }} />;
-    }
-
-    render(
-      <ContentEditorsProvider value={{ rich: RichEditor }}>
-        <ContentPreview
-          content="Preis: {{price}}"
-          variables={{ price: "<b>0</b> & up" }}
-          contentFormat="rich"
-        />
-      </ContentEditorsProvider>,
-      { wrapper: Wrapper },
-    );
-
-    const el = screen.getByTestId("cp-rich");
-    expect(el.querySelector("b")).toBeNull();
-    expect(el.textContent).toBe("Preis: <b>0</b> & up");
-  });
-
-  // Known limitation: escaping is keyed off the *declared* format, not the
-  // actually-resolved editor. If "rich" is declared but no rich editor is
-  // registered, useContentEditor falls back to the plain textarea and the
-  // markup-safe escaping (only applied for contentFormat === "rich") never
-  // ran for the plain path — entities show up literal instead of rendered.
-  // Pinned here rather than fixed: fixing it needs a per-editor
-  // `rendersHtml` flag threaded through content-editors.tsx.
-  test("rich format with no registered editor → falls back to the textarea, entities shown literally", () => {
-    render(
-      <ContentPreview
-        content="Preis: {{price}}"
-        variables={{ price: "<b>0</b> & up" }}
-        contentFormat="rich"
-      />,
-      { wrapper: Wrapper },
-    );
-
-    const el = screen.getByTestId("cp-textarea") as HTMLTextAreaElement;
-    expect(el.value).toBe("Preis: &lt;b&gt;0&lt;/b&gt; &amp; up");
-  });
-
-  test("plain format: an example value with markup characters passes through unescaped", () => {
-    render(
-      <ContentPreview
-        content="Preis: {{price}}"
-        variables={{ price: "<b>0</b>" }}
-        contentFormat="plain"
-      />,
-      { wrapper: Wrapper },
-    );
-
-    const el = screen.getByTestId("cp-textarea") as HTMLTextAreaElement;
-    expect(el.value).toBe("Preis: <b>0</b>");
-  });
-});

package/src/app/__tests__/entity-edit-create-search-params.test.tsx

@@ -1,236 +0,0 @@
-// Issue #1680: navigate params on entityEdit-create were documented as
-// "will be read" but EntityEditCreateBody never consulted nav.searchParams —
-// only buildInitialValues(entity.fields). A rowAction navigate with params
-// to an entityEdit target therefore opened an empty form with no boot error.
-// This test renders the real create path (KumikoScreen → EntityEditScreen →
-// EntityEditCreateBody → RenderEdit → RenderField) under a NavProvider with
-// searchParams set and asserts the input is prefilled — not just the helper
-// in isolation.
-import { describe, expect, test } from "bun:test";
-import type {
-  EntityDefinition,
-  EntityEditScreenDefinition,
-} from "@cosmicdrift/kumiko-framework/ui-types";
-import type { Dispatcher } from "@cosmicdrift/kumiko-headless";
-import { act, render } from "@testing-library/react";
-import { type ComponentType, type ReactNode, useState } from "react";
-import { DispatcherProvider } from "../../context/dispatcher-context";
-import { createStaticLocaleResolver, LocaleProvider } from "../../i18n";
-import { type CorePrimitives, type InputProps, PrimitivesProvider } from "../../primitives";
-import type { FeatureSchema } from "../feature-schema";
-import { KumikoScreen } from "../kumiko-screen";
-import { type NavApi, NavProvider, type NavTarget, useNavigateWithInitialValues } from "../nav";
-
-const captured: Record<string, InputProps | undefined> = {};
-const captureInput: ComponentType<InputProps> = (props) => {
-  captured[props.name] = props;
-  return null;
-};
-const noop = (): ReactNode => null;
-const passChildren = ({ children }: { readonly children?: ReactNode }): ReactNode => children;
-
-const testPrimitives: CorePrimitives = {
-  Button: noop,
-  Banner: passChildren,
-  Field: passChildren,
-  Input: captureInput,
-  DataTable: noop,
-  Form: passChildren,
-  Section: passChildren,
-  Card: passChildren,
-  Grid: passChildren,
-  GridCell: passChildren,
-  Text: passChildren,
-  Heading: noop,
-  Dialog: noop,
-  Modal: noop,
-  Lightbox: noop,
-  ConfigSourceBadge: noop,
-  ConfigCascadeView: noop,
-  Link: noop,
-};
-
-function stubDispatcher(): Dispatcher {
-  return {
-    write: (async () => ({ isSuccess: true, data: {} })) as unknown as Dispatcher["write"],
-    query: (async () => ({ isSuccess: true, data: {} })) as unknown as Dispatcher["query"],
-    batch: (async () => ({ isSuccess: true, results: [] })) as unknown as Dispatcher["batch"],
-    statusStore: {
-      getState: () => "online",
-      subscribe: () => () => {},
-    } as unknown as Dispatcher["statusStore"],
-    async *stream() {},
-    pendingWrites: () => [],
-    pendingFiles: () => [],
-  };
-}
-
-function buildSchema(urlPrefillFields: readonly string[] | undefined): FeatureSchema {
-  const entity: EntityDefinition = {
-    fields: {
-      name: { type: "text", maxLength: 200, required: false, searchable: false, sortable: false },
-      floorCount: { type: "number", required: false, sortable: false },
-      ownerEmail: { type: "text", maxLength: 200, required: false, searchable: false },
-      accessCode: {
-        type: "text",
-        maxLength: 200,
-        required: false,
-        searchable: false,
-        sensitive: true,
-      },
-    },
-  };
-  const screen: EntityEditScreenDefinition = {
-    id: "unit-edit",
-    type: "entityEdit",
-    entity: "unit",
-    layout: {
-      sections: [{ columns: 1, fields: ["name", "floorCount", "ownerEmail", "accessCode"] }],
-    },
-    ...(urlPrefillFields !== undefined && { urlPrefillFields }),
-  };
-  return {
-    featureName: "housing",
-    entities: { unit: entity },
-    screens: [screen],
-  } as FeatureSchema;
-}
-
-function staticNav(searchParams: Record<string, string>): NavApi {
-  return {
-    route: { screenId: "housing:unit-edit" },
-    navigate: () => {},
-    replace: () => {},
-    hrefFor: () => "",
-    searchParams,
-    setSearchParams: () => {},
-  };
-}
-
-function renderWithNav(nav: NavApi, schema: FeatureSchema): void {
-  render(
-    <LocaleProvider resolver={createStaticLocaleResolver({ locale: "de-DE" })}>
-      <DispatcherProvider dispatcher={stubDispatcher()}>
-        <NavProvider value={nav}>
-          <PrimitivesProvider value={testPrimitives}>
-            <KumikoScreen schema={schema} qn="housing:screen:unit-edit" />
-          </PrimitivesProvider>
-        </NavProvider>
-      </DispatcherProvider>
-    </LocaleProvider>,
-  );
-}
-
-function resetCaptured(): void {
-  for (const key of Object.keys(captured)) delete captured[key];
-}
-
-describe("EntityEditCreateBody — navigate params as initial values (#1680)", () => {
-  test("URL searchParams from rowAction navigate prefill the create form", () => {
-    resetCaptured();
-    renderWithNav(
-      staticNav({ name: "Erdgeschoss", floorCount: "3" }),
-      buildSchema(["name", "floorCount"]),
-    );
-
-    expect(captured["name"]?.value).toBe("Erdgeschoss");
-    expect(captured["floorCount"]?.value).toBe(3);
-  });
-
-  test("without a matching searchParam the field keeps its default (empty)", () => {
-    resetCaptured();
-    renderWithNav(staticNav({}), buildSchema(["name"]));
-
-    expect(captured["name"]?.value).toBe("");
-  });
-
-  test("a crafted link cannot prefill a field outside urlPrefillFields", () => {
-    resetCaptured();
-    renderWithNav(
-      staticNav({ name: "Erdgeschoss", ownerEmail: "attacker@example.com" }),
-      buildSchema(["name"]),
-    );
-
-    expect(captured["name"]?.value).toBe("Erdgeschoss");
-    expect(captured["ownerEmail"]?.value).toBe("");
-  });
-
-  test("a screen without urlPrefillFields takes nothing from the URL", () => {
-    resetCaptured();
-    renderWithNav(staticNav({ name: "Erdgeschoss" }), buildSchema(undefined));
-
-    expect(captured["name"]?.value).toBe("");
-  });
-
-  test("a sensitive field stays empty even when urlPrefillFields names it", () => {
-    resetCaptured();
-    renderWithNav(staticNav({ accessCode: "1234" }), buildSchema(["accessCode"]));
-
-    expect(captured["accessCode"]?.value).toBe("");
-  });
-});
-
-describe("EntityEditCreateBody — useNavigateWithInitialValues", () => {
-  function HandoffApp({
-    schema,
-    initialValues,
-  }: {
-    readonly schema: FeatureSchema;
-    readonly initialValues: Readonly<Record<string, unknown>>;
-  }): ReactNode {
-    const [screenId, setScreenId] = useState("home");
-    const nav: NavApi = {
-      route: { screenId },
-      navigate: (target: NavTarget) => {
-        if ("screenId" in target) setScreenId(target.screenId);
-      },
-      replace: () => {},
-      hrefFor: () => "",
-      searchParams: {},
-      setSearchParams: () => {
-        throw new Error("the handoff must not write the query string");
-      },
-    };
-    return (
-      <LocaleProvider resolver={createStaticLocaleResolver({ locale: "de-DE" })}>
-        <DispatcherProvider dispatcher={stubDispatcher()}>
-          <NavProvider value={nav}>
-            <PrimitivesProvider value={testPrimitives}>
-              {screenId === "unit-edit" ? (
-                <KumikoScreen schema={schema} qn="housing:screen:unit-edit" />
-              ) : (
-                <Opener initialValues={initialValues} />
-              )}
-            </PrimitivesProvider>
-          </NavProvider>
-        </DispatcherProvider>
-      </LocaleProvider>
-    );
-  }
-
-  let openForm: (() => void) | undefined;
-  function Opener({
-    initialValues,
-  }: {
-    readonly initialValues: Readonly<Record<string, unknown>>;
-  }): ReactNode {
-    const navigateWithInitialValues = useNavigateWithInitialValues();
-    openForm = () => navigateWithInitialValues({ screenId: "unit-edit" }, initialValues);
-    return null;
-  }
-
-  test("handed-off values prefill fields outside urlPrefillFields, but never a sensitive one", () => {
-    resetCaptured();
-    render(
-      <HandoffApp
-        schema={buildSchema([])}
-        initialValues={{ ownerEmail: "owner@example.com", floorCount: "2", accessCode: "1234" }}
-      />,
-    );
-    act(() => openForm?.());
-
-    expect(captured["ownerEmail"]?.value).toBe("owner@example.com");
-    expect(captured["floorCount"]?.value).toBe(2);
-    expect(captured["accessCode"]?.value).toBe("");
-  });
-});