@consiliency/agent-board-schema 1.59.0 → 1.63.0

package/tests/agent_board_own_post_not_delivered.test.sql

@@ -0,0 +1,490 @@
+-- OWN POST NOT DELIVERED pgTAP (Consiliency/message-board#608, migration 20261010000100).
+--
+-- The owner's rule (2026-10-03): an agent does not receive its own room post as an inbox item,
+-- and its own writes do not wake it. The wake side reads v_agent_wake_recovery, so "no inbox item
+-- for the author" is asserted on that view, as the author, through a real authenticated session.
+--
+-- THE CLASS COMES FROM THE CATALOG (AGENTS.md rule 1). A recipient set can reach its own sender in
+-- two ways, and each is derived from pg_proc so a new site fails here BY NAME:
+--   * a BOARD expansion -- OPN-01 finds every inbox_items inserter; OPN-02 every caller of it that
+--     reads board_memberships; OPN-03 the callers that do not (asserted positively, OPN-18..22, 29, 33);
+--   * a DESCRIPTOR expansion -- OPN-34 finds every caller of the descriptor resolver; the only one that
+--     delivers is _addressing_agent_ids_or_raise, asserted through both its overload callers (OPN-25..32).
+-- Each member is asserted behaviourally, as an authenticated session; each exemption POSITIVELY.
+--
+-- Mutation controls (measured 2026-10-03, each run counting all 40 assertions):
+--   * post_board_message writes the author's row visible_in_inbox = true    -> OPN-06, 07, 09, 10, 14
+--   * post_board_message skips the author's row entirely                    -> OPN-09, 13
+--   * post_board_message counts the author in delivered_recipient_count     -> OPN-05
+--   * _queue_inbox_callbacks loses its visible_in_inbox filter              -> OPN-10
+--   * create_tasking_delivery writes the creator's row visible_in_inbox     -> OPN-16
+--   * create_tasking_delivery skips the creator (the round-1 shape)         -> OPN-16, 24
+--   * the board loop demotes an explicit self-listing (the round-2 shape)   -> OPN-35, 39 (abort), 37, 40
+--   * the board loop skips an explicitly listed creator (round-3 T1 shape)  -> OPN-40
+--   * _addressing_agent_ids_or_raise keeps the sender for a set descriptor  -> OPN-28, 30, 32
+--   * ... and drops it even when named explicitly                           -> OPN-31, 38
+--   * a new function that calls _upsert_inbox_item over board_memberships   -> OPN-02
+--   * a new caller of _resolve_addressing_recipient_rows                    -> OPN-34
+--   (create_tasking_delivery counting its creator is pinned by inbox_rpcs and v2_invariants.)
+-- TAP numbers follow EMISSION order, not labels (OPN-34 is emitted last): cite by label.
+--
+-- HAND-COUNTED plan: OPN-01..OPN-40 = 40 assertions. The runner checks the emitted count.
+create extension if not exists pgtap with schema extensions;
+set search_path = extensions, public, agent_board;
+
+begin;
+
+select plan(40);
+
+-- ---------------------------------------------------------------------------
+-- The class, derived from pg_proc.
+-- ---------------------------------------------------------------------------
+select is(
+  (select array_agg(p.proname::text order by p.proname)
+     from pg_proc p join pg_namespace n on n.oid = p.pronamespace
+    where n.nspname = 'agent_board'
+      and agent_board_test.stripped_body(p.oid) ~ agent_board_test.stmt_re('insert into|merge into', 'inbox_items')),
+  array['_upsert_inbox_item'],
+  'OPN-01: _upsert_inbox_item is the only function that inserts into inbox_items');
+
+select is(
+  (select array_agg(p.proname::text order by p.proname)
+     from pg_proc p join pg_namespace n on n.oid = p.pronamespace
+    where n.nspname = 'agent_board'
+      and agent_board_test.stripped_body(p.oid) ~ agent_board_test.call_re('_upsert_inbox_item')
+      and agent_board_test.stripped_body(p.oid) ~ agent_board_test.qname_re('board_memberships')
+      and p.proname <> '_upsert_inbox_item'),
+  array['create_tasking_delivery', 'post_board_message'],
+  'OPN-02: the board-expanding delivery writers are exactly the two this file asserts behaviourally');
+
+select is(
+  (select array_agg(p.proname::text order by p.proname)
+     from pg_proc p join pg_namespace n on n.oid = p.pronamespace
+    where n.nspname = 'agent_board'
+      and agent_board_test.stripped_body(p.oid) ~ agent_board_test.call_re('_upsert_inbox_item')
+      and agent_board_test.stripped_body(p.oid) !~ agent_board_test.qname_re('board_memberships')
+      and p.proname <> '_upsert_inbox_item'),
+  array['send_direct_message', 'send_multicast_message'],
+  'OPN-03: the non-expanding delivery writers are exactly the two exemptions asserted below');
+
+-- ---------------------------------------------------------------------------
+-- Fixture: author A, member B; board AB (A owner, B joined) and board S (A alone).
+-- ---------------------------------------------------------------------------
+create temp table _opn (
+  a_user uuid, b_user uuid,
+  a_agent uuid, b_agent uuid,
+  board_ab uuid, board_s uuid, thread uuid, thread_unlinked uuid, thread_unlinked2 uuid
+) on commit drop;
+create temp table _opn_post (message_id uuid, board_id uuid, delivered_recipient_count integer,
+  callback_outbox_count integer, created_at timestamptz) on commit drop;
+create temp table _opn_sole (like _opn_post) on commit drop;
+create temp table _opn_task (task_id uuid, task_event_id uuid, delivered_recipient_count integer,
+  inbox_item_count integer, callback_outbox_count integer, created_at timestamptz,
+  updated_at timestamptz) on commit drop;
+create temp table _opn_self_task (like _opn_task) on commit drop;
+create temp table _opn_sole_task (like _opn_task) on commit drop;
+create temp table _opn_desc_task (like _opn_task) on commit drop;
+create temp table _opn_both_task (like _opn_task) on commit drop;
+create temp table _opn_both_sole (like _opn_task) on commit drop;
+create temp table _opn_multi (message_id uuid, delivered_recipient_count integer, inbox_item_count integer,
+  callback_outbox_count integer, created_at timestamptz) on commit drop;
+create temp table _opn_group (like _opn_multi) on commit drop;
+create temp table _opn_group_self (like _opn_multi) on commit drop;
+create temp table _opn_nested (like _opn_multi) on commit drop;
+create temp table _opn_direct (message_id uuid, delivery_recipient_id uuid, inbox_item_id uuid,
+  callback_outbox_count integer, created_at timestamptz) on commit drop;
+grant all on table _opn, _opn_post, _opn_sole, _opn_task, _opn_self_task, _opn_multi,
+  _opn_sole_task, _opn_desc_task, _opn_group, _opn_group_self, _opn_direct, _opn_both_task, _opn_nested, _opn_both_sole
+  to authenticated, service_role;
+
+do $$
+declare
+  v_a_user uuid := public.ensure_github_user('opn-author', 'opn-author@example.test', 'opn-author', 'OPN Author');
+  v_b_user uuid := public.ensure_github_user('opn-member', 'opn-member@example.test', 'opn-member', 'OPN Member');
+  v_a uuid := '76080000-0000-4000-8000-000000000001';
+  v_b uuid := '76080000-0000-4000-8000-000000000002';
+  v_thread uuid := '76080000-0000-4000-8000-000000000010';
+  v_thread_unlinked uuid := '76080000-0000-4000-8000-000000000011';
+  v_thread_unlinked2 uuid := '76080000-0000-4000-8000-000000000012';
+  v_board_ab uuid;
+  v_board_s uuid;
+  v_endpoint uuid;
+begin
+  -- Both agents are in the group alias `opn-team` and carry the role `opn-role`, so a set-naming
+  -- descriptor resolves to BOTH of them -- the author included -- before the #608 rule applies.
+  insert into agent_board.agents(id, agent_type, handle, display_name, status, auth_user_id, owner_user_id, metadata)
+  values
+    (v_a, 'agent', 'opn-author', 'OPN Author', 'active', v_a_user, v_a_user, '{"groupAliases":["opn-team","opn-solo"],"roles":["opn-role"]}'::jsonb),
+    (v_b, 'agent', 'opn-member', 'OPN Member', 'active', v_b_user, v_b_user, '{"groupAliases":["opn-team"],"roles":["opn-role"]}'::jsonb);
+
+  insert into agent_board.threads(id, thread_type, created_by_agent_id, subject)
+  values (v_thread, 'coordination', v_a, 'OPN thread'),
+         (v_thread_unlinked, 'coordination', v_a, 'OPN unlinked thread'),
+         (v_thread_unlinked2, 'coordination', v_a, 'OPN second unlinked thread');
+
+  select board_id into v_board_ab
+    from agent_board.create_board(v_a, 'opn-board-ab', 'OPN AB', 'two members', '{}'::jsonb, 'private');
+  perform agent_board.join_board(v_board_ab, v_b, 'joined', v_a, '{}'::jsonb);
+  select board_id into v_board_s
+    from agent_board.create_board(v_a, 'opn-board-s', 'OPN S', 'author alone', '{}'::jsonb, 'private');
+
+  -- Both agents subscribe their own inbox to delivered callbacks: B's is the positive control
+  -- for OPN-10, so a zero for A cannot come from a fixture that queues nothing for anyone.
+  select endpoint_id into v_endpoint from agent_board.register_callback_endpoint(v_a, 'https://example.test/opn-a', '{}'::jsonb);
+  perform agent_board.verify_callback_endpoint(v_endpoint, v_a, '{"controlProofRef":"opn/a"}'::jsonb);
+  perform agent_board.subscribe_callback_endpoint(v_endpoint, v_a, 'own_inbox', 'inbox.item.delivered', null, '{}'::jsonb);
+  select endpoint_id into v_endpoint from agent_board.register_callback_endpoint(v_b, 'https://example.test/opn-b', '{}'::jsonb);
+  perform agent_board.verify_callback_endpoint(v_endpoint, v_b, '{"controlProofRef":"opn/b"}'::jsonb);
+  perform agent_board.subscribe_callback_endpoint(v_endpoint, v_b, 'own_inbox', 'inbox.item.delivered', null, '{}'::jsonb);
+
+  insert into _opn values (v_a_user, v_b_user, v_a, v_b, v_board_ab, v_board_s, v_thread, v_thread_unlinked, v_thread_unlinked2);
+end;
+$$;
+
+-- ---------------------------------------------------------------------------
+-- A posts to AB, through its own authenticated session.
+-- ---------------------------------------------------------------------------
+select set_config('request.jwt.claim.role', 'authenticated', true);
+select set_config('request.jwt.claim.sub', (select a_user::text from _opn), true);
+set local role authenticated;
+
+select lives_ok(
+  $$ insert into _opn_post
+       select * from agent_board.post_board_message(
+         (select thread from _opn), null, (select board_ab from _opn),
+         'opn post', 'the author posts to a two-member board', 'comment', 'medium', null, '{}'::jsonb) $$,
+  'OPN-04: the author can post to a board it owns');
+
+select is((select delivered_recipient_count from _opn_post), 1,
+  'OPN-05: delivered_recipient_count counts the other member only, not the author');
+
+select is(
+  (select count(*)::int from agent_board.v_agent_wake_recovery
+    where source_message_id = (select message_id from _opn_post)),
+  0,
+  'OPN-06: the author''s own post is not in the author''s v_agent_wake_recovery');
+
+select is(
+  (select count(*)::int from agent_board.v_agent_inbox
+    where source_message_id = (select message_id from _opn_post)
+      and recipient_agent_id = (select a_agent from _opn)),
+  0,
+  'OPN-07: the author''s own post is not in the author''s v_agent_inbox');
+
+reset role;
+select set_config('request.jwt.claim.sub', (select b_user::text from _opn), true);
+set local role authenticated;
+
+select is(
+  (select count(*)::int from agent_board.v_agent_wake_recovery
+    where source_message_id = (select message_id from _opn_post)),
+  1,
+  'OPN-08: the other member does receive the post as an unhandled item');
+
+reset role;
+select set_config('request.jwt.claim.role', '', true);
+select set_config('request.jwt.claim.sub', '', true);
+
+select is(
+  (select array_agg(array[ii.visible_in_inbox, ii.visible_in_board_feed])
+     from agent_board.inbox_items ii
+    where ii.source_message_id = (select message_id from _opn_post)
+      and ii.recipient_agent_id = (select a_agent from _opn)),
+  array[array[false, true]],
+  'OPN-09: the author keeps exactly one row for its post, and it is feed-only');
+
+select is(
+  (select count(*)::int from agent_board.callback_outbox_events
+    where source_message_id = (select message_id from _opn_post)
+      and event_category = 'inbox.item.delivered'
+      and recipient_agent_id = (select a_agent from _opn)),
+  0,
+  'OPN-10: no own_inbox delivered callback is queued to the author for its own post');
+
+select is(
+  (select count(*)::int from agent_board.callback_outbox_events
+    where source_message_id = (select message_id from _opn_post)
+      and event_category = 'inbox.item.delivered'
+      and recipient_agent_id = (select b_agent from _opn)),
+  1,
+  'OPN-11: the other member''s own_inbox delivered callback is queued (control for OPN-10)');
+
+-- ---------------------------------------------------------------------------
+-- A posts to S, where it is the only member: the post must stay in the feed.
+-- ---------------------------------------------------------------------------
+select set_config('request.jwt.claim.role', 'authenticated', true);
+select set_config('request.jwt.claim.sub', (select a_user::text from _opn), true);
+set local role authenticated;
+
+select lives_ok(
+  $$ insert into _opn_sole
+       select * from agent_board.post_board_message(
+         (select thread from _opn), null, (select board_s from _opn),
+         'opn sole post', 'the author posts to a board it is alone on', 'comment', 'medium', null, '{}'::jsonb) $$,
+  'OPN-12: the author can post to a board it is the only member of');
+
+select is(
+  (select count(*)::int from agent_board.v_board_feed
+    where message_id = (select message_id from _opn_sole)),
+  1,
+  'OPN-13: a post on a board whose only member is its author is still in that board''s feed');
+
+select is(
+  (select count(*)::int from agent_board.v_agent_wake_recovery
+    where source_message_id = (select message_id from _opn_sole)),
+  0,
+  'OPN-14: the sole-member post is not in the author''s v_agent_wake_recovery either');
+
+-- ---------------------------------------------------------------------------
+-- A creates a board-wide task on AB.
+-- ---------------------------------------------------------------------------
+select lives_ok(
+  $$ insert into _opn_task
+       select * from agent_board.create_tasking_delivery(
+         (select thread from _opn), null, 'opn task', 'a board-wide task', null,
+         (select board_ab from _opn), 'medium', 'distributed', null, '{}'::jsonb) $$,
+  'OPN-15: the creator can deliver a task to its board');
+
+reset role;
+select set_config('request.jwt.claim.role', '', true);
+select set_config('request.jwt.claim.sub', '', true);
+
+select is(
+  (select array_agg(array[ii.visible_in_inbox, ii.visible_in_board_feed])
+     from agent_board.inbox_items ii
+    where ii.source_task_id = (select task_id from _opn_task)
+      and ii.recipient_agent_id = (select a_agent from _opn)),
+  array[array[false, true]],
+  'OPN-16: the board fan-out of a task gives its creator one feed-only row, not an inbox item');
+
+select is(
+  (select count(*)::int from agent_board.inbox_items
+    where source_task_id = (select task_id from _opn_task)
+      and recipient_agent_id = (select b_agent from _opn)
+      and visible_in_inbox),
+  1,
+  'OPN-17: the board fan-out of a task delivers it to the other member');
+
+-- ---------------------------------------------------------------------------
+-- Exemptions, asserted positively: the explicit-recipient paths deliver what the caller lists.
+-- ---------------------------------------------------------------------------
+select set_config('request.jwt.claim.role', 'authenticated', true);
+select set_config('request.jwt.claim.sub', (select a_user::text from _opn), true);
+set local role authenticated;
+
+select lives_ok(
+  $$ insert into _opn_multi
+       select * from agent_board.send_multicast_message(
+         (select thread from _opn), null, array[(select b_agent from _opn)],
+         'opn multicast', 'listed recipients only', 'comment', 'medium', null, '{}'::jsonb) $$,
+  'OPN-18: the author can multicast to a listed recipient');
+
+select lives_ok(
+  $$ insert into _opn_self_task
+       select * from agent_board.create_tasking_delivery(
+         (select thread from _opn), null, 'opn self task', 'the creator lists itself',
+         array[(select a_agent from _opn)], null, 'medium', 'distributed', null, '{}'::jsonb) $$,
+  'OPN-19: the creator can list itself as an explicit task recipient');
+
+reset role;
+select set_config('request.jwt.claim.role', '', true);
+select set_config('request.jwt.claim.sub', '', true);
+
+select is(
+  (select array_agg(recipient_agent_id order by recipient_agent_id)
+     from agent_board.inbox_items
+    where source_message_id = (select message_id from _opn_multi)),
+  array[(select b_agent from _opn)],
+  'OPN-20: a multicast delivers to exactly the listed recipients, so not to an unlisted author');
+
+select is(
+  (select count(*)::int from agent_board.inbox_items
+    where source_task_id = (select task_id from _opn_self_task)
+      and recipient_agent_id = (select a_agent from _opn)
+      and visible_in_inbox),
+  1,
+  'OPN-21: an explicit recipient list naming the creator still delivers to it');
+
+select is(
+  (select delivered_recipient_count from _opn_self_task),
+  1,
+  'OPN-22: the explicit self-addressed task counts its one listed recipient');
+
+-- ---------------------------------------------------------------------------
+-- Round 1 of the PR #615 board: the creator-only task, the descriptor expansions, a direct send.
+-- ---------------------------------------------------------------------------
+select set_config('request.jwt.claim.role', 'authenticated', true);
+select set_config('request.jwt.claim.sub', (select a_user::text from _opn), true);
+set local role authenticated;
+
+-- A board-wide task on a board whose only member is its creator. Skipping the creator's delivery
+-- would skip the only write that stamps threads.board_id (OBSGATE #78), leaving the thread on the
+-- access-only branch of post_message's observer gate. Mutation: exclude the creator from the loop.
+select lives_ok(
+  $$ insert into _opn_sole_task
+       select * from agent_board.create_tasking_delivery(
+         (select thread_unlinked from _opn), null, 'opn sole task', 'creator alone', null,
+         (select board_s from _opn), 'medium', 'distributed', null, '{}'::jsonb) $$,
+  'OPN-23: the creator can deliver a task to a board it is alone on');
+
+reset role;
+select set_config('request.jwt.claim.role', '', true);
+select set_config('request.jwt.claim.sub', '', true);
+
+select is(
+  (select board_id from agent_board.threads where id = (select thread_unlinked from _opn)),
+  (select board_s from _opn),
+  'OPN-24: a creator-only board task still links its thread to the board');
+
+select set_config('request.jwt.claim.role', 'authenticated', true);
+select set_config('request.jwt.claim.sub', (select a_user::text from _opn), true);
+set local role authenticated;
+
+-- A multicast to a group alias the author belongs to.
+select lives_ok(
+  $$ insert into _opn_group
+       select * from agent_board.send_multicast_message(
+         (select thread from _opn), null, '[{"kind":"group_alias","groupAlias":"opn-team"}]'::jsonb,
+         'addressing_v1', 'opn group', 'to a group the author is in', 'comment', 'medium', null, '{}'::jsonb) $$,
+  'OPN-25: the author can multicast to a group alias it belongs to');
+
+-- The same group, plus an explicit agent_id naming the author AFTER it: the explicit mention wins.
+select lives_ok(
+  $$ insert into _opn_group_self
+       select * from agent_board.send_multicast_message(
+         (select thread from _opn), null,
+         jsonb_build_array(
+           jsonb_build_object('kind', 'group_alias', 'groupAlias', 'opn-team'),
+           jsonb_build_object('kind', 'agent_id', 'agentId', (select a_agent from _opn)::text)),
+         'addressing_v1', 'opn group self', 'the group, and the author by id', 'comment', 'medium', null, '{}'::jsonb) $$,
+  'OPN-26: the author can multicast to a group and name itself explicitly');
+
+-- A task to a role selector the creator carries.
+select lives_ok(
+  $$ insert into _opn_desc_task
+       select * from agent_board.create_tasking_delivery(
+         (select thread from _opn), null, 'opn role task', 'to a role the creator has',
+         '[{"kind":"role_selector","role":"opn-role"}]'::jsonb, null, 'addressing_v1',
+         'medium', 'distributed', null, '{}'::jsonb) $$,
+  'OPN-27: the creator can deliver a task to a role selector it matches');
+
+-- A group whose only member is the sender resolves to nobody else: refused, not self-delivered.
+select throws_ok(
+  $$ select * from agent_board.send_multicast_message(
+       (select thread from _opn), null, '[{"kind":"group_alias","groupAlias":"opn-solo"}]'::jsonb,
+       'addressing_v1', 'opn solo', 'a group of one', 'comment', 'medium', null, '{}'::jsonb) $$,
+  '22023',
+  'recipient descriptors resolved only the sender',
+  'OPN-28: a set descriptor that resolves only to the sender is refused');
+
+select lives_ok(
+  $$ insert into _opn_direct
+       select * from agent_board.send_direct_message(
+         (select thread from _opn), null, (select b_agent from _opn),
+         'opn direct', 'to the member', 'comment', 'medium', null, '{}'::jsonb) $$,
+  'OPN-29: the author can send a direct message');
+
+reset role;
+select set_config('request.jwt.claim.role', '', true);
+select set_config('request.jwt.claim.sub', '', true);
+
+select is(
+  (select array_agg(recipient_agent_id order by recipient_agent_id)
+     from agent_board.inbox_items
+    where source_message_id = (select message_id from _opn_group)),
+  array[(select b_agent from _opn)],
+  'OPN-30: a group alias the author belongs to delivers to the other member only');
+
+select is(
+  (select array_agg(recipient_agent_id order by recipient_agent_id)
+     from agent_board.inbox_items
+    where source_message_id = (select message_id from _opn_group_self)
+      and visible_in_inbox),
+  array[(select a_agent from _opn), (select b_agent from _opn)],
+  'OPN-31: an explicit agent_id naming the author delivers to it even beside a group that contains it');
+
+select is(
+  (select array_agg(recipient_agent_id order by recipient_agent_id)
+     from agent_board.inbox_items
+    where source_task_id = (select task_id from _opn_desc_task)),
+  array[(select b_agent from _opn)],
+  'OPN-32: a role selector the creator matches delivers the task to the other member only');
+
+select is(
+  (select array_agg(recipient_agent_id order by recipient_agent_id)
+     from agent_board.inbox_items
+    where source_message_id = (select message_id from _opn_direct)),
+  array[(select b_agent from _opn)],
+  'OPN-33: a direct message delivers to exactly its recipient');
+
+-- Round 2 of the PR #615 board: the creator lists itself AND targets a board it is on. Both loops
+-- reach the same delivery row; the board loop must not demote the explicit one (which aborted the
+-- whole task on inbox_items_visibility_shape). And an explicit self-mention nested in an
+-- explicit_set, by handle, beside a group that contains the author.
+select set_config('request.jwt.claim.role', 'authenticated', true);
+select set_config('request.jwt.claim.sub', (select a_user::text from _opn), true);
+set local role authenticated;
+
+select lives_ok(
+  $$ insert into _opn_both_task
+       select * from agent_board.create_tasking_delivery(
+         (select thread from _opn), null, 'opn both task', 'the creator lists itself and its board',
+         array[(select a_agent from _opn)], (select board_ab from _opn), 'medium', 'distributed', null, '{}'::jsonb) $$,
+  'OPN-35: the creator can list itself and target a board it is on, in one task');
+
+select lives_ok(
+  $$ insert into _opn_nested
+       select * from agent_board.send_multicast_message(
+         (select thread from _opn), null,
+         '[{"kind":"group_alias","groupAlias":"opn-team"},{"kind":"explicit_set","recipients":[{"kind":"agent_handle","handle":"opn-author"}]}]'::jsonb,
+         'addressing_v1', 'opn nested', 'a group, and the author by handle inside an explicit set', 'comment', 'medium', null, '{}'::jsonb) $$,
+  'OPN-36: the author can multicast to a group and name itself by handle inside an explicit_set');
+
+-- Round 3 (correctness T1): the creator lists itself AND targets a board it is ALONE on, from an
+-- unlinked thread. A fix that skipped the creator in the board loop would pass every assertion above
+-- and leave this thread unlinked.
+select lives_ok(
+  $$ insert into _opn_both_sole
+       select * from agent_board.create_tasking_delivery(
+         (select thread_unlinked2 from _opn), null, 'opn both sole', 'the creator lists itself; board of one',
+         array[(select a_agent from _opn)], (select board_s from _opn), 'medium', 'distributed', null, '{}'::jsonb) $$,
+  'OPN-39: the creator can list itself and target a board it is alone on');
+
+reset role;
+select set_config('request.jwt.claim.role', '', true);
+select set_config('request.jwt.claim.sub', '', true);
+
+select is(
+  (select board_id from agent_board.threads where id = (select thread_unlinked2 from _opn)),
+  (select board_s from _opn),
+  'OPN-40: that task still links its thread to the board');
+
+select is(
+  (select array_agg(array[ii.visible_in_inbox::text, (ii.recipient_agent_id = (select a_agent from _opn))::text] order by ii.recipient_agent_id)
+     from agent_board.inbox_items ii
+    where ii.source_task_id = (select task_id from _opn_both_task)),
+  array[array['true', 'true'], array['true', 'false']],
+  'OPN-37: an explicit self-listing survives a board fan-out the creator is in, and the other member is reached');
+
+select is(
+  (select array_agg(recipient_agent_id order by recipient_agent_id)
+     from agent_board.inbox_items
+    where source_message_id = (select message_id from _opn_nested)
+      and visible_in_inbox),
+  array[(select a_agent from _opn), (select b_agent from _opn)],
+  'OPN-38: an agent_handle naming the author inside an explicit_set is an explicit self-mention');
+
+-- The descriptor class, from the catalog: every function that resolves recipient descriptors does so
+-- through _resolve_addressing_recipient_rows, and the only callers of it are the resolver itself
+-- (explicit_set recursion), the read-only resolve_recipients, and _addressing_agent_ids_or_raise --
+-- the one delivery path, where the #608 rule lives. A new caller that delivers fails this by name.
+select is(
+  (select array_agg(p.proname::text order by p.proname)
+     from pg_proc p join pg_namespace n on n.oid = p.pronamespace
+    where n.nspname = 'agent_board'
+      and agent_board_test.stripped_body(p.oid) ~ agent_board_test.call_re('_resolve_addressing_recipient_rows')),
+  array['_addressing_agent_ids_or_raise', '_resolve_addressing_recipient_rows', 'resolve_recipients'],
+  'OPN-34: descriptor expansion reaches a delivery only through _addressing_agent_ids_or_raise');
+
+select * from finish();
+rollback;

package/tests/agent_board_rolereset.test.sql

@@ -265,6 +265,12 @@ select is(
 -- behavioural assertion above, because the UPDATE is never reached with a non-active row
 -- unless an eviction lands between the pre-check and the UPDATE (the TOCTOU window).
 -- Both review seats flagged this independently; assert the predicate structurally.
+--
+-- #674 rewrote this from `>= 2` to `= 3` ON PURPOSE (plan-674 D5, Gemini G001). The step-6
+-- pre-check is now ONE locked statement that also LEFT JOINs the grantor's active row, so the
+-- body carries the predicate exactly three times: the target in step 6, the grantor join in
+-- step 6, and the UPDATE. `>= 2` would stay green if either step-6 site were deleted, and a
+-- later fourth reader would hide behind it; `= 3` turns red on either, forcing re-review.
 select ok(
   (select (
      select count(*) from regexp_matches(
@@ -272,11 +278,11 @@ select ok(
        -- the column qualified or bare (`bm.membership_state` is the UPDATE's spelling)
        agent_board_test.re(agent_board_test.col_ref_frag('membership_state')
                            || '\s+' || agent_board_test.ci_re('in') || '\s*\(\s*''joined''\s*,\s*''subscribed''\s*\)'),
-       'g')) >= 2
+       'g')) = 3
      from pg_proc p join pg_namespace n on n.oid = p.pronamespace
     where n.nspname = 'agent_board' and p.proname = 'grant_board_role'
     limit 1),
-  'grant_board_role carries the active-state predicate TWICE (pre-check + UPDATE, the TOCTOU half)');
+  'grant_board_role carries the active-state predicate exactly THREE times (#674: step-6 target, step-6 grantor join, UPDATE -- the TOCTOU half)');
 
 -- 16. STRUCTURAL: the clamp lives in the mutator, not in a trigger. A BEFORE UPDATE
 -- trigger on board_memberships would also fire for the four raw-insert seeders and

package/tests/agent_board_roomdeleg_lane_b.test.sql

@@ -65,7 +65,7 @@ select set_config('request.jwt.claim.sub', (select root_user from _lb_fx)::text,
 -- M3: the self-service write stamps scope_attestation='self_declared' (advisory).
 -- M1: require_child_signing_key is PINNED true even though false was requested.
 -- M2a: max_active_children null is CLAMPED to the non-null default (5).
--- M6a: child_ttl_ceiling 12h is accepted and stored; max_depth pinned 1.
+-- M6a: child_ttl_ceiling 12h is accepted and stored; SIDSCHEMA allows depth two.
 select lives_ok(
   format($$ select agent_board.upsert_delegation_policy(%L::uuid, 'root_minted', jsonb_build_array('scope:a'), null, interval '12 hours', false) $$,
     (select root from _lb_fx)),
@@ -78,14 +78,14 @@ select is((select require_child_signing_key from agent_board.delegation_policies
 select is((select max_active_children from agent_board.delegation_policies where root_agent_id = (select root from _lb_fx) and revoked_at is null order by created_at desc limit 1),
   5, 'M2a: null max_active_children clamped to non-null default 5');
 select is((select max_depth from agent_board.delegation_policies where root_agent_id = (select root from _lb_fx) and revoked_at is null order by created_at desc limit 1),
-  1, 'max_depth pinned 1');
+  2, 'SIDSCHEMA max_depth supports depth two');
 select is((select child_ttl_ceiling from agent_board.delegation_policies where root_agent_id = (select root from _lb_fx) and revoked_at is null order by created_at desc limit 1),
   interval '12 hours', 'M6: within-cap ttl (12h) stored');
 
 -- M2b/M2c: out-of-range child cap rejected (both ends).
 select throws_ok(
-  format($$ select agent_board.upsert_delegation_policy(%L::uuid, 'root_minted', jsonb_build_array('scope:a'), 26) $$, (select root from _lb_fx)),
-  '22023', null, 'M2b: max_active_children 26 (> 25) rejected');
+  format($$ select agent_board.upsert_delegation_policy(%L::uuid, 'root_minted', jsonb_build_array('scope:a'), 201) $$, (select root from _lb_fx)),
+  '22023', null, 'M2b: max_active_children 201 (> 200) rejected');
 select throws_ok(
   format($$ select agent_board.upsert_delegation_policy(%L::uuid, 'root_minted', jsonb_build_array('scope:a'), 0) $$, (select root from _lb_fx)),
   '22023', null, 'M2c: max_active_children 0 (< 1) rejected');
@@ -131,10 +131,10 @@ select ok(not has_function_privilege('anon',
   'agent_board.upsert_delegation_policy(uuid, text, jsonb, integer, interval, boolean)', 'EXECUTE'),
   'M5: anon may NOT EXECUTE upsert_delegation_policy');
 select ok(not has_function_privilege('authenticated',
-  'agent_board.mint_delegated_child(uuid, text, jsonb, text, interval, boolean)', 'EXECUTE'),
+  'agent_board.mint_delegated_child(uuid, text, jsonb, text, interval, boolean, text, text, text, jsonb, jsonb, uuid)', 'EXECUTE'),
   'M5: mint_delegated_child stays service_role-only — authenticated has NO EXECUTE (deferred to #138)');
 select ok(not has_function_privilege('anon',
-  'agent_board.mint_delegated_child(uuid, text, jsonb, text, interval, boolean)', 'EXECUTE'),
+  'agent_board.mint_delegated_child(uuid, text, jsonb, text, interval, boolean, text, text, text, jsonb, jsonb, uuid)', 'EXECUTE'),
   'M5: anon may NOT EXECUTE mint_delegated_child');
 
 select set_config('request.jwt.claim.role', '', true);

package/tests/agent_board_rowid.test.sql

@@ -518,15 +518,17 @@ select is(
     '_upsert_board_membership_state',
     'create_tasking_delivery',
     'join_board',
+    'link_session_alias',
     'list_board_members',
     'list_board_pending_memberships',
     'list_my_board_requests',
     'post_board_message',
+    'readmit_session_identity',
     'request_join_board',
     'resolve_board_request',
     'update_board_membership'
   ]::text[],
-  'live catalog exposes nine membership readers plus two task/message idempotency readers');
+  'live catalog exposes every membership total-order reader, including SID link/readmission, plus task/message readers');
 
 -- 3-10. COUNT-EQUALITY, never substring containment.
 select is(