@cohortapp/agent-sdk 2.17.0 → 2.18.5

package/scripts/local-triggers/generate-plists.test.mjs

@@ -1,456 +0,0 @@
-/**
- * generate-plists.test.mjs — Coverage for scripts/local-triggers/generate-plists.sh
- *
- * Builds a fixture agent repo (minimal config/agent.ts + script tree),
- * runs the generator, and asserts every emitted plist matches the
- * cadence-bus architecture marker and never references the legacy
- * run-trigger.sh spawn-per-tick pattern.
- */
-
-import { test } from "node:test";
-import assert from "node:assert/strict";
-import { promises as fsp } from "fs";
-import { readFileSync, readdirSync, writeFileSync, mkdirSync, copyFileSync, existsSync } from "node:fs";
-import { tmpdir } from "os";
-import { join, resolve, dirname } from "path";
-import { fileURLToPath } from "node:url";
-import { spawnSync } from "node:child_process";
-
-const __dirname = dirname(fileURLToPath(import.meta.url));
-const MAESTRO_ROOT = resolve(__dirname, "..", "..");
-const GENERATOR = resolve(__dirname, "generate-plists.sh");
-
-async function makeAgent(firstName) {
-  const root = join(
-    tmpdir(),
-    `plist-test-${process.pid}-${Date.now()}-${Math.random().toString(36).slice(2, 8)}`
-  );
-  await fsp.mkdir(root, { recursive: true });
-
-  // Minimal agent identity.
-  await fsp.mkdir(join(root, "config"), { recursive: true });
-  writeFileSync(
-    join(root, "config/agent.ts"),
-    `export const AGENT = { firstName: '${firstName}', lastName: 'Tester' };\n`
-  );
-  writeFileSync(join(root, "package.json"), '{"name":"t"}');
-
-  // Copy the scripts the generator references.
-  await fsp.mkdir(join(root, "scripts/local-triggers"), { recursive: true });
-  await fsp.mkdir(join(root, "scripts/daemon"), { recursive: true });
-  await fsp.mkdir(join(root, "scripts/cadence"), { recursive: true });
-  // The generator now derives the standard cadence set from the canonical
-  // STANDARD_CADENCES in lib/cadences.mjs (SoT), so the fixture needs the
-  // module + its local import chain (capability → archetype).
-  await fsp.mkdir(join(root, "lib"), { recursive: true });
-  for (const m of ["lib/cadences.mjs", "lib/capability.mjs", "lib/archetype.mjs"]) {
-    copyFileSync(join(MAESTRO_ROOT, m), join(root, m));
-  }
-  copyFileSync(GENERATOR, join(root, "scripts/local-triggers/generate-plists.sh"));
-  copyFileSync(
-    join(MAESTRO_ROOT, "scripts/local-triggers/run-trigger.sh"),
-    join(root, "scripts/local-triggers/run-trigger.sh"),
-  );
-  copyFileSync(
-    join(MAESTRO_ROOT, "scripts/daemon/launchd-wrapper.sh"),
-    join(root, "scripts/daemon/launchd-wrapper.sh"),
-  );
-  copyFileSync(
-    join(MAESTRO_ROOT, "scripts/daemon/launchd-wrapper-generic.sh"),
-    join(root, "scripts/daemon/launchd-wrapper-generic.sh"),
-  );
-  copyFileSync(
-    join(MAESTRO_ROOT, "scripts/cadence/launchd-cadence-wrapper.sh"),
-    join(root, "scripts/cadence/launchd-cadence-wrapper.sh"),
-  );
-  copyFileSync(
-    join(MAESTRO_ROOT, "scripts/cadence/launchd-socket-mode-wrapper.sh"),
-    join(root, "scripts/cadence/launchd-socket-mode-wrapper.sh"),
-  );
-  copyFileSync(
-    join(MAESTRO_ROOT, "scripts/cadence/enqueue-cadence-tick.mjs"),
-    join(root, "scripts/cadence/enqueue-cadence-tick.mjs"),
-  );
-
-  // Make scripts executable.
-  for (const p of [
-    "scripts/local-triggers/generate-plists.sh",
-    "scripts/local-triggers/run-trigger.sh",
-    "scripts/daemon/launchd-wrapper.sh",
-    "scripts/daemon/launchd-wrapper-generic.sh",
-    "scripts/cadence/launchd-cadence-wrapper.sh",
-    "scripts/cadence/launchd-socket-mode-wrapper.sh",
-  ]) {
-    await fsp.chmod(join(root, p), 0o755);
-  }
-  return root;
-}
-
-async function rmRoot(path) {
-  try { await fsp.rm(path, { recursive: true, force: true }); } catch { /* */ }
-}
-
-function runGenerator(agentRoot) {
-  return spawnSync("/bin/bash", [join(agentRoot, "scripts/local-triggers/generate-plists.sh")], {
-    cwd: agentRoot,
-    encoding: "utf-8",
-    env: { ...process.env },
-  });
-}
-
-function listPlists(agentRoot) {
-  const dir = join(agentRoot, "scripts/local-triggers/plists");
-  return readdirSync(dir).filter((n) => n.endsWith(".plist"));
-}
-
-// ---------------------------------------------------------------------------
-// Tests
-// ---------------------------------------------------------------------------
-
-test("generator emits 25 standard plists with the agent's first name", async () => {
-  // Standard inventory (cadence-bus v1 + slack-socket-mode v1), with NO
-  // config/.cadence-plists.tsv present (no archetype cadences):
-  //   daemon, session, poll-relay, slack-socket, autoupdate (5 infra), PLUS one trigger plist per
-  //   STANDARD_CADENCES entry in lib/cadences.mjs (the SoT):
-  //   inbox-processor, backlog-executor, meeting-prep, meeting-action-capture,
-  //   daily-morning-brief, daily-midday-sweep, daily-evening-wrap,
-  //   quarterly-self-assessment, org-pulse, skill-curator (10), PLUS the
-  //   economics/scheduling cadences nightly-cost-reconcile, fleet-cost-digest,
-  //   org-cost-sync, monitoring-alerts, dynamic-jobs (5), PLUS the SP10
-  //   messaging-inbound cadence (1), PLUS the 2026-07 Directory & Design
-  //   stewards directory-hygiene + brand-steward (2), PLUS the D3 self-directed
-  //   loop goal-steward (1), PLUS the 2026-08 DR cadence nightly-backup (1).
-  //   = 5 infra + 20 trigger = 25 total. (The `session` job — the front-door
-  //   Claude Code session under scripts/session/supervisor.sh — joined the
-  //   infra set 2026-09-08; see docs/superpowers/specs/2026-09-08-front-door-session-design.md §3.1.)
-  // org-pulse used to be declared standard but was OMITTED by the old hardcoded
-  // list (it never got a plist); deriving from the SoT fixes that drift.
-  // The former weekly-* cadences are still ARCHETYPE-DRIVEN (function × altitude),
-  // emitted from config/.cadence-plists.tsv (scripts/setup/generate-cadences.mjs).
-  const root = await makeAgent("alice");
-  try {
-    const r = runGenerator(root);
-    assert.equal(r.status, 0, r.stderr);
-    const plists = listPlists(root);
-    assert.equal(plists.length, 25, `expected 25 standard plists; got ${plists.join(",")}`);
-    assert.ok(plists.includes("ai.maestro.alice-session.plist"),
-      `session (front-door) plist missing; got ${plists.join(",")}`);
-    assert.ok(plists.includes("ai.maestro.alice-autoupdate.plist"),
-      `autoupdate plist missing; got ${plists.join(",")}`);
-    assert.ok(plists.includes("ai.maestro.alice-messaging-inbound.plist"),
-      "messaging-inbound (SP10 standard cadence) must get a SoT-derived plist");
-    assert.ok(plists.includes("ai.maestro.alice-nightly-backup.plist"),
-      "nightly-backup (the DR cadence) must be scheduled, not left to a human to remember");
-    for (const id of ["directory-hygiene", "brand-steward"]) {
-      assert.ok(plists.includes(`ai.maestro.alice-${id}.plist`),
-        `Directory/Design steward "${id}" must get a SoT-derived plist; got ${plists.join(",")}`);
-    }
-    assert.ok(plists.includes("ai.maestro.alice-org-pulse.plist"),
-      "org-pulse (declared standard) must get a plist now it's SoT-derived");
-    // The newly-wired economics/scheduling cadences each get a plist.
-    for (const id of ["nightly-cost-reconcile", "fleet-cost-digest", "org-cost-sync", "dynamic-jobs"]) {
-      assert.ok(plists.includes(`ai.maestro.alice-${id}.plist`),
-        `economics cadence "${id}" must get a SoT-derived plist; got ${plists.join(",")}`);
-    }
-    for (const p of plists) {
-      assert.match(p, /^ai\.maestro\.alice-/);
-    }
-  } finally { await rmRoot(root); }
-});
-
-test("every cadence resolved by resolveCadences() gets a generated plist (incl. org-pulse)", async () => {
-  // Single-source-of-truth guarantee: the launchd plist set is derived from the
-  // canonical cadence resolution, so a cadence declared in lib/cadences.mjs can
-  // never silently lack a job (the org-pulse-never-fires class of bug).
-  const root = await makeAgent("hana");
-  try {
-    // Drive the archetype TSV too, so we cover standard + archetype in one pass.
-    const { resolveCadences } = await import(join(MAESTRO_ROOT, "lib/cadences.mjs"));
-    const cadences = await resolveCadences({ function: "technical-leader", altitude: "c-suite" });
-    // Emit the archetype (non-standard) cadences via the TSV, exactly as
-    // generate-cadences.mjs does (id|interval| / id||base64(sched)).
-    const tsvLines = [];
-    for (const c of cadences) {
-      if (c.scope === "standard") continue;
-      if (typeof c.interval === "number") tsvLines.push(`${c.id}|${c.interval}|`);
-      else if (c.calendar) {
-        const cal = c.calendar;
-        let x = "";
-        if (cal.weekday != null) x += `        <key>Weekday</key>\n        <integer>${cal.weekday}</integer>\n`;
-        if (cal.day != null) x += `        <key>Day</key>\n        <integer>${cal.day}</integer>\n`;
-        x += `        <key>Hour</key>\n        <integer>${cal.hour ?? 9}</integer>\n        <key>Minute</key>\n        <integer>${cal.minute ?? 0}</integer>`;
-        tsvLines.push(`${c.id}||${Buffer.from(x, "utf-8").toString("base64")}`);
-      }
-    }
-    writeFileSync(join(root, "config/.cadence-plists.tsv"), tsvLines.join("\n") + (tsvLines.length ? "\n" : ""));
-
-    const r = runGenerator(root);
-    assert.equal(r.status, 0, r.stderr);
-    const plists = new Set(listPlists(root));
-    for (const c of cadences) {
-      // skill-curator has a calendar; every resolved cadence here has a
-      // schedule, so each must produce exactly one trigger plist.
-      const label = `ai.maestro.hana-${c.id}.plist`;
-      assert.ok(plists.has(label), `resolved cadence "${c.id}" (${c.scope}) has no plist; got ${[...plists].join(",")}`);
-    }
-    // Spot-check the specific regression: org-pulse is standard and present.
-    assert.ok(plists.has("ai.maestro.hana-org-pulse.plist"), "org-pulse must be present");
-  } finally { await rmRoot(root); }
-});
-
-test("archetype cadences from config/.cadence-plists.tsv emit extra trigger plists", async () => {
-  const root = await makeAgent("erin");
-  try {
-    const calXml = "        <key>Weekday</key>\n        <integer>3</integer>\n        <key>Hour</key>\n        <integer>10</integer>\n        <key>Minute</key>\n        <integer>0</integer>";
-    const tsv =
-      `engineering-health||${Buffer.from(calXml, "utf-8").toString("base64")}\n` +
-      `quality-pulse|1800|\n`;
-    writeFileSync(join(root, "config/.cadence-plists.tsv"), tsv);
-    const r = runGenerator(root);
-    assert.equal(r.status, 0, r.stderr);
-    const plists = listPlists(root);
-    assert.equal(plists.length, 27, `expected 25 standard + 2 archetype; got ${plists.join(",")}`);
-    const dir = join(root, "scripts/local-triggers/plists");
-    const eng = readFileSync(join(dir, "ai.maestro.erin-engineering-health.plist"), "utf-8");
-    assert.match(eng, /<key>Weekday<\/key>\s*<integer>3<\/integer>/); // base64 schedule decoded
-    assert.match(eng, /enqueue-cadence-tick\.mjs/);
-    const qp = readFileSync(join(dir, "ai.maestro.erin-quality-pulse.plist"), "utf-8");
-    assert.match(qp, /<integer>1800<\/integer>/); // interval path
-  } finally { await rmRoot(root); }
-});
-
-test("every trigger plist carries the cadence-bus architecture marker", async () => {
-  const root = await makeAgent("bob");
-  try {
-    runGenerator(root);
-    const dir = join(root, "scripts/local-triggers/plists");
-    for (const name of listPlists(root)) {
-      const body = readFileSync(join(dir, name), "utf-8");
-      assert.match(body, /maestro-plist-arch: cadence-bus/, `${name} missing arch marker`);
-    }
-  } finally { await rmRoot(root); }
-});
-
-test("NO trigger plist invokes run-trigger.sh", async () => {
-  const root = await makeAgent("carol");
-  try {
-    runGenerator(root);
-    const dir = join(root, "scripts/local-triggers/plists");
-    for (const name of listPlists(root)) {
-      const body = readFileSync(join(dir, name), "utf-8");
-      // Exception: the daemon/session/poll-relay/slack-socket/autoupdate plists
-      // don't run cadence triggers at all (daemon + session + slack-socket are
-      // KeepAlive workers; poll-relay is a 5s poller; autoupdate is an hourly SDK
-      // self-updater). The trigger plists must invoke enqueue-cadence-tick.mjs.
-      if (name.endsWith("-daemon.plist") || name.endsWith("-session.plist") ||
-          name.endsWith("-poll-relay.plist") ||
-          name.endsWith("-slack-socket.plist") || name.endsWith("-autoupdate.plist")) {
-        continue;
-      }
-      assert.ok(!body.includes("run-trigger.sh"),
-        `${name} still references run-trigger.sh:\n${body}`);
-      assert.ok(body.includes("enqueue-cadence-tick.mjs"),
-        `${name} should invoke enqueue script`);
-    }
-  } finally { await rmRoot(root); }
-});
-
-test("trigger plists pass --source=launchd to the enqueue script", async () => {
-  const root = await makeAgent("dana");
-  try {
-    runGenerator(root);
-    const dir = join(root, "scripts/local-triggers/plists");
-    const triggerPlist = join(dir, "ai.maestro.dana-inbox-processor.plist");
-    const body = readFileSync(triggerPlist, "utf-8");
-    assert.match(body, /<string>--source=launchd<\/string>/);
-    assert.match(body, /<string>inbox-processor<\/string>/);
-    // StartInterval 300 (every 5 min).
-    assert.match(body, /<integer>300<\/integer>/);
-  } finally { await rmRoot(root); }
-});
-
-test("interval trigger plists pass --interval=<seconds> for the at-most-once gate (WS4)", async () => {
-  const root = await makeAgent("gita");
-  try {
-    runGenerator(root);
-    const dir = join(root, "scripts/local-triggers/plists");
-    // StartInterval cadence: --interval mirrors the interval seconds.
-    const inbox = readFileSync(join(dir, "ai.maestro.gita-inbox-processor.plist"), "utf-8");
-    assert.match(inbox, /<string>--interval=300<\/string>/);
-    // Calendar cadence (daily): carries a daily catch-up interval so an outage
-    // spanning the trigger time fast-forwards to exactly one catch-up tick.
-    const morning = readFileSync(join(dir, "ai.maestro.gita-daily-morning-brief.plist"), "utf-8");
-    assert.match(morning, /<string>--interval=86400<\/string>/);
-    // Still a StartCalendarInterval-driven plist (wall-clock trigger unchanged).
-    assert.match(morning, /<key>StartCalendarInterval<\/key>/);
-  } finally { await rmRoot(root); }
-});
-
-test("economics/scheduling cadences emit plists with the right schedule + enqueue wiring", async () => {
-  const root = await makeAgent("nadia");
-  try {
-    runGenerator(root);
-    const dir = join(root, "scripts/local-triggers/plists");
-    // nightly-cost-reconcile: calendar 03:30, daily catch-up, enqueue wiring.
-    const reconcile = readFileSync(join(dir, "ai.maestro.nadia-nightly-cost-reconcile.plist"), "utf-8");
-    assert.match(reconcile, /<key>StartCalendarInterval<\/key>/);
-    assert.match(reconcile, /<key>Hour<\/key>\s*<integer>3<\/integer>/);
-    assert.match(reconcile, /<key>Minute<\/key>\s*<integer>30<\/integer>/);
-    assert.match(reconcile, /<string>--interval=86400<\/string>/); // daily catch-up
-    assert.match(reconcile, /enqueue-cadence-tick\.mjs/);
-    assert.match(reconcile, /<string>nightly-cost-reconcile<\/string>/);
-    // fleet-cost-digest: calendar 07:00.
-    const digest = readFileSync(join(dir, "ai.maestro.nadia-fleet-cost-digest.plist"), "utf-8");
-    assert.match(digest, /<key>Hour<\/key>\s*<integer>7<\/integer>/);
-    // org-cost-sync: hourly StartInterval.
-    const sync = readFileSync(join(dir, "ai.maestro.nadia-org-cost-sync.plist"), "utf-8");
-    assert.match(sync, /<key>StartInterval<\/key>\s*<integer>3600<\/integer>/);
-    assert.match(sync, /<string>--interval=3600<\/string>/);
-    // dynamic-jobs: 60s StartInterval.
-    const jobs = readFileSync(join(dir, "ai.maestro.nadia-dynamic-jobs.plist"), "utf-8");
-    assert.match(jobs, /<key>StartInterval<\/key>\s*<integer>60<\/integer>/);
-    assert.match(jobs, /<string>--interval=60<\/string>/);
-  } finally { await rmRoot(root); }
-});
-
-test("daemon plist remains a KeepAlive job (not a cadence enqueue)", async () => {
-  const root = await makeAgent("erin");
-  try {
-    runGenerator(root);
-    const path = join(root, "scripts/local-triggers/plists/ai.maestro.erin-daemon.plist");
-    const body = readFileSync(path, "utf-8");
-    // KeepAlive switched 1.9.2 from plain `<true/>` to a dict with
-    // SuccessfulExit:false / Crashed:true so emergency-stop doesn't trigger
-    // a restart treadmill but real crashes still do.
-    assert.match(body, /<key>KeepAlive<\/key>/);
-    assert.match(body, /<key>SuccessfulExit<\/key>\s*<false\/>/);
-    assert.match(body, /<key>Crashed<\/key>\s*<true\/>/);
-    assert.match(body, /launchd-wrapper\.sh/);
-    assert.ok(!body.includes("enqueue-cadence-tick.mjs"),
-      "daemon plist should not enqueue ticks — it IS the consumer");
-  } finally { await rmRoot(root); }
-});
-
-test("session plist is a KeepAlive job running scripts/session/supervisor.sh with its own log paths", async () => {
-  // The front-door session (design §3.1): launchd keeps the supervisor alive
-  // with the same SuccessfulExit:false / Crashed:true semantics as the daemon
-  // — a clean exit 0 (second supervisor, emergency-stop) is NOT restarted, a
-  // crash or the supervisor's deliberate exit 75 IS, throttled to 30s so a
-  // broken transcript cannot thrash launchd. Logs go to logs/session/ so the
-  // session's launchd output never interleaves with the daemon's.
-  const root = await makeAgent("ivy");
-  try {
-    runGenerator(root);
-    const path = join(root, "scripts/local-triggers/plists/ai.maestro.ivy-session.plist");
-    const body = readFileSync(path, "utf-8");
-    assert.match(body, /<key>Label<\/key>\s*<string>ai\.maestro\.ivy-session<\/string>/);
-    assert.match(body, new RegExp(`<string>${root.replace(/[.*+?^${}()|[\]\\]/g, "\\$&")}/scripts/session/supervisor\\.sh</string>`),
-      "ProgramArguments must run scripts/session/supervisor.sh from the agent dir");
-    assert.match(body, /<key>KeepAlive<\/key>/);
-    assert.match(body, /<key>SuccessfulExit<\/key>\s*<false\/>/);
-    assert.match(body, /<key>Crashed<\/key>\s*<true\/>/);
-    assert.match(body, /<key>RunAtLoad<\/key>\s*<true\/>/);
-    assert.match(body, /<key>ThrottleInterval<\/key>\s*<integer>30<\/integer>/);
-    assert.match(body, /<key>StandardOutPath<\/key>\s*<string>[^<]*\/logs\/session\/launchd-stdout\.log<\/string>/);
-    assert.match(body, /<key>StandardErrorPath<\/key>\s*<string>[^<]*\/logs\/session\/launchd-stderr\.log<\/string>/);
-    assert.ok(!body.includes("logs/daemon/"), "session plist must not log into the daemon's log dir");
-    assert.ok(!body.includes("enqueue-cadence-tick.mjs"), "session plist is a worker, not a cadence enqueue");
-    assert.ok(!body.includes("boot-claude-session"), "the Terminal.app boot script is retired");
-    // launchd creates the log file but not its directory: the generator must.
-    assert.ok(existsSync(join(root, "logs", "session")), "logs/session/ must exist after generation");
-    // The daemon plist is untouched by the addition.
-    const daemon = readFileSync(join(root, "scripts/local-triggers/plists/ai.maestro.ivy-daemon.plist"), "utf-8");
-    assert.match(daemon, /logs\/daemon\/launchd-stdout\.log/);
-  } finally { await rmRoot(root); }
-});
-
-test("generator reads firstName from agent.json when agent.ts is type-only (SOT layout)", async () => {
-  // Reproduce the SOT layout where agent.ts only declares interfaces
-  // (containing `firstName: string;` as a type, not a value) and the
-  // actual identity lives in agent.json. The legacy resolver matched the
-  // interface line and produced labels like
-  // `ai.maestro.  firstname:   string;-…` — guard against regression.
-  const root = join(
-    tmpdir(),
-    `plist-sot-test-${process.pid}-${Date.now()}-${Math.random().toString(36).slice(2, 8)}`
-  );
-  await fsp.mkdir(root, { recursive: true });
-  // Manually wire the same fixture-builder used by other tests, except
-  // overwrite agent.ts to look like a type-only TypeScript file and add
-  // a real agent.json.
-  await fsp.mkdir(join(root, "config"), { recursive: true });
-  writeFileSync(
-    join(root, "config/agent.ts"),
-    `// Type declarations only — value lives in agent.json
-export interface PrincipalConfig { firstName: string; }
-export interface AgentConfig { firstName: string; }
-`,
-  );
-  writeFileSync(
-    join(root, "config/agent.json"),
-    JSON.stringify({ firstName: "Sigrid", lastName: "Test" }) + "\n",
-  );
-  writeFileSync(join(root, "package.json"), '{"name":"t"}');
-
-  await fsp.mkdir(join(root, "scripts/local-triggers"), { recursive: true });
-  await fsp.mkdir(join(root, "scripts/daemon"), { recursive: true });
-  await fsp.mkdir(join(root, "scripts/cadence"), { recursive: true });
-  // Same set of helper scripts as makeAgent().
-  const { copyFileSync } = await import("node:fs");
-  copyFileSync(GENERATOR, join(root, "scripts/local-triggers/generate-plists.sh"));
-  copyFileSync(
-    join(MAESTRO_ROOT, "scripts/local-triggers/run-trigger.sh"),
-    join(root, "scripts/local-triggers/run-trigger.sh"),
-  );
-  copyFileSync(
-    join(MAESTRO_ROOT, "scripts/daemon/launchd-wrapper.sh"),
-    join(root, "scripts/daemon/launchd-wrapper.sh"),
-  );
-  copyFileSync(
-    join(MAESTRO_ROOT, "scripts/daemon/launchd-wrapper-generic.sh"),
-    join(root, "scripts/daemon/launchd-wrapper-generic.sh"),
-  );
-  copyFileSync(
-    join(MAESTRO_ROOT, "scripts/cadence/launchd-cadence-wrapper.sh"),
-    join(root, "scripts/cadence/launchd-cadence-wrapper.sh"),
-  );
-  copyFileSync(
-    join(MAESTRO_ROOT, "scripts/cadence/launchd-socket-mode-wrapper.sh"),
-    join(root, "scripts/cadence/launchd-socket-mode-wrapper.sh"),
-  );
-  copyFileSync(
-    join(MAESTRO_ROOT, "scripts/cadence/enqueue-cadence-tick.mjs"),
-    join(root, "scripts/cadence/enqueue-cadence-tick.mjs"),
-  );
-  await fsp.chmod(join(root, "scripts/local-triggers/generate-plists.sh"), 0o755);
-
-  try {
-    const r = runGenerator(root);
-    assert.equal(r.status, 0, r.stderr);
-    const plists = listPlists(root);
-    assert.ok(plists.length >= 1);
-    for (const p of plists) {
-      assert.match(p, /^ai\.maestro\.sigrid-/, `expected "sigrid" label, got: ${p}`);
-      assert.ok(!p.includes("string"),
-        `label leaked the TypeScript type: ${p}`);
-    }
-  } finally { await rmRoot(root); }
-});
-
-test("regeneration clears stale plists", async () => {
-  const root = await makeAgent("frank");
-  try {
-    // Plant a stale plist for a long-gone agent — intentionally using the legacy
-    // ai.adaptic.* namespace to confirm pre-rename plists are also cleared on regen.
-    const dir = join(root, "scripts/local-triggers/plists");
-    mkdirSync(dir, { recursive: true });
-    writeFileSync(join(dir, "ai.adaptic.OLD-AGENT-stale.plist"), "<plist/>");
-    runGenerator(root);
-    const remaining = listPlists(root);
-    assert.ok(!remaining.includes("ai.adaptic.OLD-AGENT-stale.plist"),
-      "generator must clear stale plists");
-    for (const p of remaining) {
-      assert.match(p, /^ai\.maestro\.frank-/);
-    }
-  } finally { await rmRoot(root); }
-});

package/scripts/media-generation/brand-clause.test.mjs

@@ -1,135 +0,0 @@
-/**
- * brand-clause.test.mjs — generated imagery must not be branded for a company
- * that does not exist.
- *
- * WHAT BROKE
- *   `buildDefaultPrompt()` appended, to EVERY illustration prompt on EVERY
- *   deployment: "IMPORTANT: This is for <one fictional company>, an
- *   institutional-grade AI asset management platform." — while `spec.style`,
- *   `spec.mood` and `spec.colorPalette` three lines above were already
- *   parameterised correctly. `gemini-image-client.mjs` then closed every
- *   refinement pass with "... and <that company>'s brand aesthetic
- *   requirements", re-asserting a brand the module cannot know.
- *
- * WHAT THESE TESTS PIN
- *   1. GROUNDED — the brand sentence is built from config/company.json (name,
- *      tagline, description, industry) and config/brand-assets.yaml
- *      (usage_rules), which bin/maestro.mjs generates per agent.
- *   2. EMPTY — nothing configured ⇒ NO brand clause is emitted at all. The
- *      craft direction (which names no company) survives, because it is true on
- *      any deployment. An unbranded illustration is a correct outcome.
- *
- * HOW IT RUNS
- *   generate-assets.mjs imports "dotenv/config" and gemini-image-client.mjs
- *   imports "@google/genai" — neither is a dependency of this package, so
- *   neither module can be imported in-process. The renderers are pure, so we
- *   lift their REAL source and evaluate it.
- *
- * Run: node --test scripts/media-generation/brand-clause.test.mjs
- */
-
-"use strict";
-
-import { test } from "node:test";
-import assert from "node:assert/strict";
-import { readFileSync } from "node:fs";
-
-const ASSETS_SRC = readFileSync(new URL("./generate-assets.mjs", import.meta.url), "utf8");
-const GEMINI_SRC = readFileSync(new URL("./gemini-image-client.mjs", import.meta.url), "utf8");
-
-function extractFunction(src, name, file) {
-  const re = new RegExp(`(?:export\\s+)?function\\s+${name}\\s*\\(`);
-  const m = re.exec(src);
-  assert.ok(m, `${file} no longer defines ${name}() — update this test deliberately`);
-  const open = src.indexOf("{", m.index + m[0].length - 1);
-  let depth = 0;
-  for (let i = open; i < src.length; i++) {
-    if (src[i] === "{") depth++;
-    else if (src[i] === "}" && --depth === 0) return src.slice(m.index, i + 1).replace(/^export\s+/, "");
-  }
-  throw new Error(`unbalanced braces extracting ${name}`);
-}
-
-const assetNames = ["configuredStr", "buildBrandClause", "buildDefaultPrompt"];
-const assets = new Function(
-  `${assetNames.map((n) => extractFunction(ASSETS_SRC, n, "generate-assets.mjs")).join("\n\n")}\n` +
-    `return { ${assetNames.join(", ")} };`,
-)();
-const gemini = new Function(
-  `${extractFunction(GEMINI_SRC, "buildRefinementPrompt", "gemini-image-client.mjs")}\nreturn { buildRefinementPrompt };`,
-)();
-
-const { buildBrandClause, buildDefaultPrompt } = assets;
-const { buildRefinementPrompt } = gemini;
-
-const SPEC = { title: "Depot network", purpose: "Board deck cover", elements: ["a map"] };
-
-// ── GROUNDED ────────────────────────────────────────────────────────────────
-
-test("grounded: the brand sentence is built from config/company.json", () => {
-  const clause = buildBrandClause(
-    { name: "Meridian Freight", tagline: "Cold chain, unbroken", industry: "Logistics" },
-    {},
-  );
-  assert.equal(clause, "This is for Meridian Freight — Cold chain, unbroken.");
-});
-
-test("grounded: description or industry stands in when there is no tagline", () => {
-  assert.match(buildBrandClause({ name: "Meridian Freight", description: "Regional logistics." }, {}), /— Regional logistics\./);
-  assert.match(buildBrandClause({ name: "Meridian Freight", industry: "Logistics" }, {}), /— Logistics\./);
-  assert.equal(buildBrandClause({ name: "Meridian Freight" }, {}), "This is for Meridian Freight.");
-});
-
-test("grounded: config/brand-assets.yaml usage_rules pass through verbatim", () => {
-  const clause = buildBrandClause(
-    { name: "Meridian Freight" },
-    { usage_rules: { never: "stretch, rotate, recolour, or modify the assets" } },
-  );
-  assert.match(clause, /Never stretch, rotate, recolour, or modify the assets\./);
-});
-
-test("grounded: the brand clause reaches the prompt", () => {
-  const prompt = buildDefaultPrompt(SPEC, "This is for Meridian Freight — Cold chain, unbroken.");
-  assert.match(prompt, /IMPORTANT: This is for Meridian Freight — Cold chain, unbroken\./);
-  assert.match(prompt, /premium, restrained, and sophisticated/, "craft direction survives");
-});
-
-// ── EMPTY — no config, no brand claim ───────────────────────────────────────
-
-test("empty: the scaffold's UNCONFIGURED company yields NO brand clause", () => {
-  assert.equal(buildBrandClause({ name: "UNCONFIGURED", tagline: "", description: "", industry: "" }, {}), "");
-});
-
-test("empty: a missing/garbage config yields NO brand clause", () => {
-  assert.equal(buildBrandClause({}, {}), "");
-  assert.equal(buildBrandClause(null, null), "");
-  assert.equal(buildBrandClause(undefined, undefined), "");
-});
-
-test("empty: with no brand clause the prompt names NO company at all", () => {
-  const prompt = buildDefaultPrompt(SPEC, "");
-  assert.doesNotMatch(prompt, /This is for/);
-  assert.doesNotMatch(prompt, /UNCONFIGURED/);
-  // The company-agnostic craft direction is still stated — it is true anywhere.
-  assert.match(prompt, /IMPORTANT: The illustration must feel premium, restrained, and sophisticated\./);
-  assert.match(prompt, /Create an illustration for: Depot network/);
-});
-
-test("empty: buildDefaultPrompt defaults to no brand clause when called with one argument", () => {
-  assert.doesNotMatch(buildDefaultPrompt(SPEC), /This is for/);
-});
-
-// ── The refinement pass re-asserts nothing ──────────────────────────────────
-
-test("the refinement prompt preserves the brand STATED ABOVE, it does not name one", () => {
-  const out = buildRefinementPrompt("ORIGINAL PROMPT BODY", "fix the horizon line");
-  assert.match(out, /ORIGINAL PROMPT BODY/);
-  assert.match(out, /fix the horizon line/);
-  assert.match(out, /every brand and style requirement stated above/);
-});
-
-test("neither media-generation source carries a hardcoded brand", () => {
-  assert.doesNotMatch(ASSETS_SRC, /\bNorthwind\b/i);
-  assert.doesNotMatch(GEMINI_SRC, /\bNorthwind\b/i);
-  assert.doesNotMatch(ASSETS_SRC, /institutional-grade AI asset management/i);
-});