@cohortapp/agent-sdk 2.17.0 → 2.18.5

package/lib/org/board.test.mjs

@@ -1,187 +0,0 @@
-/**
- * board.test.mjs — agent-side board ops routing + the read-only YAML projection
- * writer. Ops are verified against an injected client (no network); the
- * projection writer is verified against a real tmp dir (atomic write).
- *
- * Run: node --test lib/org/board.test.mjs
- */
-"use strict";
-
-import { test } from "node:test";
-import assert from "node:assert/strict";
-import { mkdtempSync, rmSync, existsSync, readFileSync } from "node:fs";
-import { tmpdir } from "node:os";
-import { join } from "node:path";
-
-import {
-  createItem, claimItem, completeItem, decompose, assign, link, ready, mine,
-  buildProjection, writeProjection, writeReadyProjection,
-} from "./board.mjs";
-import { okFrame, errFrame, BOARD_STATUS } from "./protocol.mjs";
-
-function tmp() { return mkdtempSync(join(tmpdir(), "org-board-")); }
-const CONN = { base: "https://org.cohortapp.com", token: "tok" };
-
-/** A fake client that records which helper was called with what. */
-function fakeClient(map = {}) {
-  const calls = [];
-  const make = (name) => async (params, opts) => {
-    calls.push({ name, params, opts });
-    return (map[name] || (() => okFrame(null)))(params, opts);
-  };
-  return {
-    calls,
-    createItem: make("createItem"),
-    claimItem: make("claimItem"),
-    completeItem: make("completeItem"),
-    boardDecompose: make("boardDecompose"),
-    boardAssign: make("boardAssign"),
-    boardLink: make("boardLink"),
-    listReady: make("listReady"),
-    listMine: make("listMine"),
-  };
-}
-
-// --- ops route to the right client helpers ---------------------------------
-
-test("board ops route to their client helpers, forwarding conn opts", async () => {
-  const client = fakeClient();
-  const o = { client, ...CONN, idempotencyKey: "k" };
-  await createItem({ id: "i1", title: "t" }, o);
-  await claimItem({ itemId: "i1" }, o);
-  await completeItem({ itemId: "i1", proof: { url: "x" } }, o);
-  await decompose({ itemId: "i1", children: [{ title: "c" }] }, o);
-  await assign({ itemId: "i1", assignee: "bob" }, o);
-  await link({ fromItemId: "i1", toItemId: "i2", type: "blocks" }, o);
-  await ready(o);
-  assert.deepEqual(client.calls.map((c) => c.name), [
-    "createItem", "claimItem", "completeItem", "boardDecompose", "boardAssign", "boardLink", "listReady",
-  ]);
-  // conn opts are forwarded (base/token/idempotencyKey) on a side-effecting call
-  const claim = client.calls.find((c) => c.name === "claimItem");
-  assert.equal(claim.opts.base, CONN.base);
-  assert.equal(claim.opts.token, CONN.token);
-  assert.equal(claim.opts.idempotencyKey, "k");
-});
-
-test("decompose/assign surface the server's GOVERNANCE_NOT_READY frame untouched", async () => {
-  const client = fakeClient({
-    boardDecompose: () => errFrame("GOVERNANCE_NOT_READY", "decision_rights empty"),
-    boardAssign: () => errFrame("GOVERNANCE_NOT_READY", "decision_rights empty"),
-  });
-  const d = await decompose({ itemId: "i1", children: [] }, { client, ...CONN });
-  assert.equal(d.ok, false);
-  assert.equal(d.error.code, "GOVERNANCE_NOT_READY");
-  const a = await assign({ itemId: "i1", assignee: "bob" }, { client, ...CONN });
-  assert.equal(a.error.code, "GOVERNANCE_NOT_READY");
-});
-
-test("ready: returns the items array (fail-open [] handled by the client)", async () => {
-  const client = fakeClient({ listReady: () => [{ id: "r1" }, { id: "r2" }] });
-  assert.deepEqual(await ready({ client, ...CONN }), [{ id: "r1" }, { id: "r2" }]);
-});
-
-// --- projection: pure builder ----------------------------------------------
-
-test("buildProjection: groups by status, counts, stamps metadata", () => {
-  const items = [
-    { id: "a", title: "A", status: "ready", priority: "high" },
-    { id: "b", title: "B", status: "running", assignee_agent: "bob" },
-    { id: "c", title: "C", status: "done" },
-  ];
-  const doc = buildProjection(items, { board: "growth", generatedAt: "2026-06-11T00:00:00Z", cursorHead: 42 });
-  assert.equal(doc.schemaVersion, 1);
-  assert.equal(doc.board, "growth");
-  assert.equal(doc.generatedAt, "2026-06-11T00:00:00Z");
-  assert.equal(doc.cursorHead, 42);
-  assert.equal(doc.count, 3);
-  assert.equal(doc.byStatus.ready, 1);
-  assert.equal(doc.byStatus.running, 1);
-  assert.equal(doc.byStatus.done, 1);
-  // every canonical status present (even at zero) so the view is stable
-  for (const s of BOARD_STATUS) assert.ok(s in doc.byStatus);
-  // assignee projected from assignee_agent; id/title/status normalised
-  assert.equal(doc.items[1].assignee, "bob");
-});
-
-test("buildProjection: normalises id aliases and never leaks lease/token fields", () => {
-  const doc = buildProjection([
-    { itemId: "x1", title: "X", status: "ready", lease_token: "SECRET", token: "SECRET2" },
-  ]);
-  const it = doc.items[0];
-  assert.equal(it.id, "x1");
-  assert.ok(!("lease_token" in it), "lease_token must not appear on a read surface");
-  assert.ok(!("token" in it), "token must not appear on a read surface");
-});
-
-test("buildProjection: unknown status buckets under _other (no silent drop)", () => {
-  const doc = buildProjection([{ id: "z", title: "Z", status: "weird-future-status" }]);
-  assert.equal(doc.byStatus._other, 1);
-  assert.equal(doc.count, 1);
-});
-
-// --- projection: writer ----------------------------------------------------
-
-test("writeProjection: writes a read-only YAML with provenance header; parses back", async () => {
-  const root = tmp();
-  try {
-    const items = [{ id: "a", title: "Ship it", status: "ready" }];
-    const path = await writeProjection(root, items, { board: "self", generatedAt: "2026-06-11T00:00:00Z" });
-    assert.equal(path, join(root, "state", "org", "board", "self.yaml"));
-    assert.ok(existsSync(path));
-    const raw = readFileSync(path, "utf8");
-    assert.match(raw, /DERIVED, READ-ONLY/);
-    assert.match(raw, /DO NOT hand-edit/);
-    // round-trips through the YAML parser
-    const m = await import("js-yaml");
-    const doc = (m.default || m).load(raw);
-    assert.equal(doc.board, "self");
-    assert.equal(doc.count, 1);
-    assert.equal(doc.items[0].id, "a");
-  } finally { rmSync(root, { recursive: true, force: true }); }
-});
-
-test("writeProjection: sanitises the board name into the filename", async () => {
-  const root = tmp();
-  try {
-    const path = await writeProjection(root, [], { board: "growth/../etc" });
-    assert.ok(path.endsWith(join("state", "org", "board", "growth_.._etc.yaml")));
-  } finally { rmSync(root, { recursive: true, force: true }); }
-});
-
-test("writeProjection: no agentRoot → null (fail-open)", async () => {
-  assert.equal(await writeProjection("", [{ id: "a" }]), null);
-});
-
-test("writeReadyProjection: pulls board.ready and writes ready.yaml", async () => {
-  const root = tmp();
-  try {
-    const client = fakeClient({ listReady: () => [{ id: "r1", title: "do", status: "ready" }] });
-    const path = await writeReadyProjection(root, { client, ...CONN, generatedAt: "2026-06-11T00:00:00Z" });
-    assert.equal(path, join(root, "state", "org", "board", "ready.yaml"));
-    const m = await import("js-yaml");
-    const doc = (m.default || m).load(readFileSync(path, "utf8"));
-    assert.equal(doc.board, "ready");
-    assert.equal(doc.items[0].id, "r1");
-  } finally { rmSync(root, { recursive: true, force: true }); }
-});
-
-test("writeReadyProjection: down server (empty ready) writes an empty projection", async () => {
-  const root = tmp();
-  try {
-    const client = fakeClient({ listReady: () => [] });
-    const path = await writeReadyProjection(root, { client, ...CONN });
-    const m = await import("js-yaml");
-    const doc = (m.default || m).load(readFileSync(path, "utf8"));
-    assert.equal(doc.count, 0);
-  } finally { rmSync(root, { recursive: true, force: true }); }
-});
-
-test("mine: routes to client.listMine, forwarding conn opts (fail-open [] handled by the client)", async () => {
-  const client = fakeClient({ listMine: () => [{ itemId: "m1" }] });
-  assert.deepEqual(await mine({ client, ...CONN }), [{ itemId: "m1" }]);
-  // listMine takes ONE argument (the conn opts), like listReady.
-  const c = client.calls.find((x) => x.name === "listMine");
-  assert.equal(c.params.base, CONN.base);
-  assert.equal(c.params.token, CONN.token);
-});

package/lib/org/bootstrap-context.test.mjs

@@ -1,153 +0,0 @@
-/**
- * bootstrap-context.test.mjs — assemble the agent's org context in one pass,
- * fail-open per part, and persist/load it via the atomic FS util. Uses an
- * injected fetchImpl that routes by URL (no network).
- * Run: node --test lib/org/bootstrap-context.test.mjs
- */
-"use strict";
-
-import { test } from "node:test";
-import assert from "node:assert/strict";
-import { mkdtempSync, mkdirSync, existsSync, readFileSync } from "node:fs";
-import { tmpdir } from "node:os";
-import { join } from "node:path";
-
-import { bootstrapContext, persistOrgContext, loadOrgContext, bootstrapAndPersist, ORG_CONTEXT_REL } from "./bootstrap-context.mjs";
-
-const BASE = "https://org.cohortapp.com";
-
-const PROFILE = { slug: "robin", kind: "AI_AGENT", displayName: "Robin Vega", agentEmail: "robin@example.com", escalationPath: "CTO then CEO" };
-const CHART = { ok: true, nodes: [{ slug: "robin", displayName: "Robin Vega" }], edges: [{ kind: "reporting", from: "layla", to: "robin", type: "SOLID" }] };
-const REL = { ok: true, member: { slug: "robin" }, reportingLine: { manager: { slug: "layla", displayName: "Layla" } }, reports: [{ member: { slug: "kai", displayName: "Kai" }, style: "SOLID" }], governance: [] };
-const STRATEGY = { ok: true, strategy: { slug: "strategy", northStar: { goal: "win" }, phases: [], streams: [{ code: "S1", name: "Growth", raci: [{ role: "Accountable", member: { slug: "robin", displayName: "Robin Vega" } }] }] } };
-const HIERARCHY = { members: [{ slug: "robin" }, { slug: "layla" }], reporting: [{ from: "layla", to: "robin" }] };
-const DECISIONS = { decisions: [{ id: "D1", title: "Adopt postgres", status: "adopted" }] };
-const POLICY = { bundleId: "policy-1", version: 3 };
-const BOARD = { items: [{ id: "T1", title: "Do the thing" }] };
-
-/**
- * A fetch that routes by URL. `failing` is a Set of keys to make return non-ok.
- * Keys: profile, chart, relationships, strategy, hierarchy, decisions, policy, board.
- */
-function routerFetch(failing = new Set()) {
-  const calls = [];
-  const reply = (key, body) => {
-    if (failing.has(key)) {
-      return { ok: false, status: 503, headers: { get: () => undefined }, json: async () => ({ ok: false, error: { code: "INTERNAL", message: "down" } }) };
-    }
-    return { ok: true, status: 200, headers: { get: () => undefined }, json: async () => body };
-  };
-  const impl = async (url) => {
-    calls.push(String(url));
-    const u = String(url);
-    if (u.includes("/api/v1/org/whoami") || u.includes("/api/v1/org/members/")) return reply("profile", PROFILE);
-    if (u.includes("/api/v1/org/chart")) return reply("chart", CHART);
-    if (u.includes("/api/v1/org/relationships")) return reply("relationships", REL);
-    if (u.includes("/api/v1/org/strategy")) return reply("strategy", STRATEGY);
-    if (u.includes("/v1/hierarchy")) return reply("hierarchy", HIERARCHY);
-    if (u.includes("/v1/decision.list")) return reply("decisions", DECISIONS);
-    if (u.includes("/v1/policy")) return reply("policy", POLICY);
-    if (u.includes("/v1/board.ready")) return reply("board", BOARD);
-    return { ok: false, status: 404, headers: { get: () => undefined }, json: async () => ({ ok: false, error: { code: "NOT_FOUND", message: "x" } }) };
-  };
-  impl.calls = calls;
-  return impl;
-}
-
-function tmpRoot() {
-  const root = mkdtempSync(join(tmpdir(), "maestro-bootstrap-"));
-  mkdirSync(join(root, "config"), { recursive: true });
-  return root;
-}
-
-test("bootstrapContext: happy path populates every part", async () => {
-  const f = routerFetch();
-  const ctx = await bootstrapContext({ base: BASE, apiKey: "key", orgId: "acme", agentId: "robin", fetchImpl: f });
-  assert.equal(ctx.profile.slug, "robin");
-  assert.equal(ctx.chart.nodes.length, 1);
-  assert.equal(ctx.relationships.reportingLine.manager.slug, "layla");
-  assert.equal(ctx.strategy.streams[0].code, "S1");
-  assert.equal(ctx.hierarchy.members.length, 2);
-  assert.equal(ctx.decisions[0].id, "D1");
-  assert.equal(ctx.policy.bundleId, "policy-1");
-  assert.equal(ctx.board[0].id, "T1");
-});
-
-test("bootstrapContext: relationships uses agentId; chart/strategy slug-scoped", async () => {
-  const f = routerFetch();
-  await bootstrapContext({ base: BASE, apiKey: "key", orgId: "acme", agentId: "robin", fetchImpl: f });
-  assert.ok(f.calls.some((u) => u === `${BASE}/api/v1/org/relationships?orgId=acme&member=robin`));
-  assert.ok(f.calls.some((u) => u === `${BASE}/api/v1/org/chart?orgId=acme`));
-  assert.ok(f.calls.some((u) => u === `${BASE}/api/v1/org/strategy?orgId=acme`));
-});
-
-test("bootstrapContext: each part is independently fail-open (object → null, array → [])", async () => {
-  const failing = new Set(["chart", "relationships", "strategy", "hierarchy", "policy"]);
-  const f = routerFetch(failing);
-  const ctx = await bootstrapContext({ base: BASE, apiKey: "key", orgId: "acme", agentId: "robin", fetchImpl: f });
-  // profile/decisions/board still succeed
-  assert.equal(ctx.profile.slug, "robin");
-  assert.equal(ctx.decisions[0].id, "D1");
-  assert.equal(ctx.board[0].id, "T1");
-  // failed object parts → null
-  assert.equal(ctx.chart, null);
-  assert.equal(ctx.relationships, null);
-  assert.equal(ctx.strategy, null);
-  assert.equal(ctx.hierarchy, null);
-  assert.equal(ctx.policy, null);
-});
-
-test("bootstrapContext: total failure → all-null/empty, never throws", async () => {
-  const all = new Set(["profile", "chart", "relationships", "strategy", "hierarchy", "decisions", "policy", "board"]);
-  const ctx = await bootstrapContext({ base: BASE, apiKey: "key", orgId: "acme", agentId: "robin", fetchImpl: routerFetch(all) });
-  assert.equal(ctx.profile, null);
-  assert.equal(ctx.chart, null);
-  assert.equal(ctx.relationships, null);
-  assert.equal(ctx.strategy, null);
-  assert.equal(ctx.hierarchy, null);
-  assert.deepEqual(ctx.decisions, []);
-  assert.equal(ctx.policy, null);
-  assert.deepEqual(ctx.board, []);
-});
-
-test("bootstrapContext: missing base/creds → all-null/empty (no fetch)", async () => {
-  const ctx = await bootstrapContext({ orgId: "acme", fetchImpl: routerFetch() });
-  assert.equal(ctx.profile, null);
-  assert.equal(ctx.chart, null);
-  assert.deepEqual(ctx.decisions, []);
-  assert.deepEqual(ctx.board, []);
-});
-
-test("bootstrapContext: relationships skipped when no member slug resolvable", async () => {
-  // whoami fails → no profile.slug, no agentId → relationships not even attempted.
-  const f = routerFetch(new Set(["profile"]));
-  const ctx = await bootstrapContext({ base: BASE, apiKey: "key", orgId: "acme", fetchImpl: f });
-  assert.equal(ctx.relationships, null);
-  assert.ok(!f.calls.some((u) => u.includes("/api/v1/org/relationships")));
-});
-
-test("persistOrgContext + loadOrgContext: atomic round-trip with fetchedAt", () => {
-  const root = tmpRoot();
-  const ctx = { profile: { slug: "robin" }, chart: null, decisions: [], board: [] };
-  const path = persistOrgContext(root, ctx);
-  assert.equal(path, join(root, ORG_CONTEXT_REL));
-  assert.ok(existsSync(path));
-  const loaded = loadOrgContext(root);
-  assert.equal(loaded.profile.slug, "robin");
-  assert.ok(typeof loaded.fetchedAt === "string" && loaded.fetchedAt.length > 0);
-  const onDisk = JSON.parse(readFileSync(path, "utf8"));
-  assert.equal(onDisk.profile.slug, "robin");
-});
-
-test("loadOrgContext: absent file → null (fail-open)", () => {
-  const root = tmpRoot();
-  assert.equal(loadOrgContext(root), null);
-});
-
-test("bootstrapAndPersist: returns {ctx, path} and writes the cache", async () => {
-  const root = tmpRoot();
-  const { ctx, path } = await bootstrapAndPersist(root, { base: BASE, apiKey: "key", orgId: "acme", agentId: "robin", fetchImpl: routerFetch() });
-  assert.equal(ctx.profile.slug, "robin");
-  assert.ok(existsSync(path));
-  assert.equal(loadOrgContext(root).profile.slug, "robin");
-});