@cohortapp/agent-sdk 2.17.0 → 2.18.5

package/lib/cli/inbox.test.mjs

@@ -1,230 +0,0 @@
-/**
- * inbox.test.mjs — `maestro inbox list|show|claim|reply|done|defer` (design
- * §3.3): the session's CLI over the SAME inbox state machine the daemon uses
- * (scripts/poller/utils.mjs markers + lib/session/inbox-claims markers).
- *
- * Everything with an effect outside the inbox directory is injected: the
- * delivery seam (`deliver`), message-history hydration, the clock and stdout.
- */
-
-import { test } from "node:test";
-import assert from "node:assert/strict";
-import { mkdtempSync, rmSync, mkdirSync, writeFileSync, readdirSync, readFileSync } from "node:fs";
-import { join } from "node:path";
-import { tmpdir } from "node:os";
-
-import { runInbox, parseUntil } from "./inbox.mjs";
-
-const T0 = Date.parse("2026-09-08T10:00:00.000Z");
-const ITEM = (id, content = "can you send me the deck?") => `id: "${id}"
-service: "cohort"
-channel: "dm/olivia"
-channel_id: "ch_1"
-channel_kind: "DM"
-sender: "Olivia Chen"
-timestamp: "2026-09-08T09:59:00.000Z"
-subject: ""
-content: |
-  ${content}
-raw_ref: "${id}"
-`;
-
-function root() {
-  const dir = mkdtempSync(join(tmpdir(), "maestro-cli-inbox-"));
-  mkdirSync(join(dir, "state", "inbox", "cohort"), { recursive: true });
-  mkdirSync(join(dir, "state", "inbox", "slack"), { recursive: true });
-  return dir;
-}
-function rm(dir) { try { rmSync(dir, { recursive: true, force: true }); } catch { /* */ } }
-function plant(dir, service, name, body) { writeFileSync(join(dir, "state", "inbox", service, name), body); }
-function ls(dir, service = "cohort") { return readdirSync(join(dir, "state", "inbox", service)).sort(); }
-
-/** Run the CLI with captured stdout; returns { code, out (parsed JSON or raw) }. */
-async function run(dir, argv, deps = {}) {
-  let out = "";
-  const code = await runInbox(argv, { agentRoot: dir, now: T0, stdout: (s) => { out += s; }, ...deps });
-  let parsed = out;
-  try { parsed = JSON.parse(out); } catch { /* raw text (help) */ }
-  return { code, out: parsed, raw: out };
-}
-
-test("list: pending items as JSON across services; --service narrows; --new hides session claims; previews are bounded", async () => {
-  const dir = root();
-  try {
-    plant(dir, "cohort", "2026-09-08T09-59-00-000Z-c-1.yaml", ITEM("c-1", "x".repeat(600)));
-    plant(dir, "cohort", "2026-09-08T09-58-00-000Z-c-0.yaml.processed", ITEM("c-0"));
-    plant(dir, "cohort", "2026-09-08T09-57-00-000Z-c-old.yaml.dispatched", ITEM("c-old"));   // daemon-owned: hidden
-    plant(dir, "cohort", "2026-09-08T09-56-00-000Z-c-mine.yaml.dispatched", ITEM("c-mine") + 'claimed_by: "session"\nclaimed_at: "2026-09-08T09:56:30.000Z"\n');
-    plant(dir, "slack", "2026-09-08T09-55-00-000Z-s-1.yaml", ITEM("s-1").replace('service: "cohort"', 'service: "slack"'));
-
-    const all = await run(dir, ["list"]);
-    assert.equal(all.code, 0);
-    // Chronological (timestamp, then id) — every planted item shares one stamp here.
-    assert.deepEqual(all.out.map((i) => [i.id, i.service, i.state]), [["c-1", "cohort", "new"], ["c-mine", "cohort", "claimed"], ["s-1", "slack", "new"]]);
-    const c1 = all.out.find((i) => i.id === "c-1");
-    assert.equal(c1.sender, "Olivia Chen");
-    assert.equal(c1.channel_id, "ch_1");
-    assert.ok(c1.preview.length <= 240, "preview is bounded");
-    assert.ok(c1.path.endsWith("c-1.yaml"));
-    assert.equal(all.out.find((i) => i.id === "c-mine").claimedAt, "2026-09-08T09:56:30.000Z");
-
-    const cohort = await run(dir, ["list", "--service", "cohort"]);
-    assert.deepEqual(cohort.out.map((i) => i.id), ["c-1", "c-mine"]);
-    const fresh = await run(dir, ["list", "--new"]);
-    assert.deepEqual(fresh.out.map((i) => i.id), ["c-1", "s-1"]);
-    const none = await run(dir, ["list", "--service", "telegram"]);
-    assert.deepEqual(none.out, []);
-  } finally { rm(dir); }
-});
-
-test("show: the full parsed item + state + markers; hydrates history when the body is empty (fail-open)", async () => {
-  const dir = root();
-  try {
-    plant(dir, "cohort", "2026-09-08T09-59-00-000Z-c-1.yaml", ITEM("c-1"));
-    const r = await run(dir, ["show", "c-1"]);
-    assert.equal(r.code, 0);
-    assert.equal(r.out.item.id, "c-1");
-    assert.equal(r.out.item.content, "can you send me the deck?");
-    assert.equal(r.out.item.is_dm, true, "channel_kind DM → enriched as a DM, the way the daemon's responder sees it");
-    assert.equal(r.out.state, "new");
-    assert.equal(r.out.service, "cohort");
-    assert.equal(r.out.history, undefined, "no hydration needed when the body is present");
-
-    // Empty body → hydrate via messaging.history through the injected seam.
-    plant(dir, "cohort", "2026-09-08T09-59-30-000Z-c-2.yaml", ITEM("c-2", "").replace("content: |\n  \n", 'content: ""\n'));
-    const calls = [];
-    const r2 = await run(dir, ["show", "c-2"], { fetchHistory: async (params) => { calls.push(params); return [{ id: "m1", body: "the actual ask" }]; } });
-    assert.equal(r2.code, 0);
-    assert.equal(calls.length, 1);
-    assert.equal(calls[0].channel, "ch_1");
-    assert.deepEqual(r2.out.history, [{ id: "m1", body: "the actual ask" }]);
-    // A throwing history seam never breaks show.
-    const r3 = await run(dir, ["show", "c-2"], { fetchHistory: async () => { throw new Error("offline"); } });
-    assert.equal(r3.code, 0);
-    assert.deepEqual(r3.out.history, []);
-    const missing = await run(dir, ["show", "ghost"]);
-    assert.equal(missing.code, 1);
-    assert.equal(missing.out.ok, false);
-  } finally { rm(dir); }
-});
-
-test("claim → reply → done: the daemon-shared state machine, with reply routed through deliver()", async () => {
-  const dir = root();
-  try {
-    plant(dir, "cohort", "2026-09-08T09-59-00-000Z-c-1.yaml", ITEM("c-1"));
-    const c = await run(dir, ["claim", "c-1"]);
-    assert.equal(c.code, 0);
-    assert.equal(c.out.ok, true);
-    assert.deepEqual(ls(dir), ["2026-09-08T09-59-00-000Z-c-1.yaml.dispatched"]);
-    assert.match(readFileSync(c.out.path, "utf-8"), /claimed_by: "session"/);
-    const twice = await run(dir, ["claim", "c-1"]);
-    assert.equal(twice.code, 1);
-    assert.equal(twice.out.error, "not-claimable");
-
-    const sends = [];
-    const deliver = async (item, text, o) => { sends.push({ item, text, o }); return { sent: true, via: "org-messaging", channel: item.channel_id }; };
-    const r = await run(dir, ["reply", "c-1", "--text", "On its way."], { deliver });
-    assert.equal(r.code, 0);
-    assert.equal(r.out.sent, true);
-    assert.equal(sends.length, 1);
-    assert.equal(sends[0].text, "On its way.");
-    assert.equal(sends[0].item.id, "c-1");
-    assert.equal(sends[0].item.service, "cohort");
-    assert.equal(sends[0].item.channel_id, "ch_1");
-    assert.equal(sends[0].item.is_dm, true, "the item is enriched the way the daemon's responder sees it");
-    assert.equal(sends[0].o.kind, "reply");
-    // A successful reply is recorded ON the item so the assurance sweep never re-answers it.
-    assert.match(readFileSync(c.out.path, "utf-8"), /replied_at: "2026-09-08T10:00:00\.000Z"/);
-    assert.match(readFileSync(c.out.path, "utf-8"), /claimed_by: "session"/, "the claim survives the reply stamp");
-
-    // --file reads the reply body from disk.
-    writeFileSync(join(dir, "reply.md"), "Attached below.\n");
-    const rf = await run(dir, ["reply", "c-1", "--file", join(dir, "reply.md")], { deliver });
-    assert.equal(rf.code, 0);
-    assert.equal(sends[1].text, "Attached below.");
-    // A failed delivery is reported and exits 1 — the item is NOT marked done.
-    const bad = await run(dir, ["reply", "c-1", "--text", "x"], { deliver: async () => ({ sent: false, via: null, error: "send-gate blocked" }) });
-    assert.equal(bad.code, 1);
-    assert.equal(bad.out.error, "send-gate blocked");
-    assert.deepEqual(ls(dir), ["2026-09-08T09-59-00-000Z-c-1.yaml.dispatched"]);
-    // Empty text is refused before touching the seam.
-    const empty = await run(dir, ["reply", "c-1", "--text", "   "], { deliver });
-    assert.equal(empty.code, 1);
-    assert.equal(sends.length, 2);
-
-    const d = await run(dir, ["done", "c-1"]);
-    assert.equal(d.code, 0);
-    assert.equal(d.out.ok, true);
-    assert.deepEqual(ls(dir), ["2026-09-08T09-59-00-000Z-c-1.yaml.processed"]);
-    const again = await run(dir, ["done", "c-1"]);
-    assert.equal(again.code, 1, "already terminal");
-  } finally { rm(dir); }
-});
-
-test("defer: --until accepts +30m / +2h / ISO; parks the item with reason; the sweep reopens it when due", async () => {
-  const dir = root();
-  try {
-    assert.equal(parseUntil("+30m", T0), T0 + 30 * 60_000);
-    assert.equal(parseUntil("+2h", T0), T0 + 2 * 3_600_000);
-    assert.equal(parseUntil("+1d", T0), T0 + 86_400_000);
-    assert.equal(parseUntil("2026-09-08T12:00:00Z", T0), Date.parse("2026-09-08T12:00:00Z"));
-    assert.equal(parseUntil("soon", T0), null);
-    assert.equal(parseUntil("+5x", T0), null);
-
-    plant(dir, "cohort", "2026-09-08T09-59-00-000Z-c-1.yaml", ITEM("c-1"));
-    const r = await run(dir, ["defer", "c-1", "--until", "+30m", "--reason", "waiting on finance"]);
-    assert.equal(r.code, 0);
-    assert.equal(r.out.ok, true);
-    assert.equal(r.out.until, new Date(T0 + 30 * 60_000).toISOString());
-    assert.deepEqual(ls(dir), ["2026-09-08T09-59-00-000Z-c-1.yaml.deferred"]);
-    assert.match(readFileSync(r.out.path, "utf-8"), /deferred_reason: "waiting on finance"/);
-    const bad = await run(dir, ["defer", "c-1", "--until", "whenever"]);
-    assert.equal(bad.code, 1);
-    const noUntil = await run(dir, ["defer", "c-1"]);
-    assert.equal(noUntil.code, 1);
-    // A parked item can still be finished: .deferred → .processed, markers stripped.
-    const d = await run(dir, ["done", "c-1"]);
-    assert.equal(d.code, 0);
-    assert.deepEqual(ls(dir), ["2026-09-08T09-59-00-000Z-c-1.yaml.processed"]);
-    assert.doesNotMatch(readFileSync(join(dir, "state/inbox/cohort", ls(dir)[0]), "utf-8"), /deferred_until/);
-  } finally { rm(dir); }
-});
-
-test("usage: unknown/missing subcommand prints help and exits 1; ids are required", async () => {
-  const dir = root();
-  try {
-    const h = await run(dir, []);
-    assert.equal(h.code, 1);
-    assert.match(h.raw, /maestro inbox (list|show)/);
-    assert.equal((await run(dir, ["bogus"])).code, 1);
-    const noId = await run(dir, ["show"]);
-    assert.equal(noId.code, 1);
-    assert.equal(noId.out.ok, false);
-  } finally { rm(dir); }
-});
-
-test("claim/done touch ONLY the named item: look-alike ids (m1 vs m10) are never renamed alongside it", async () => {
-  const dir = root();
-  try {
-    for (const id of ["cohort-m1", "cohort-m10", "cohort-m11"]) plant(dir, "cohort", `2026-09-08T09-59-00-000Z-${id}.yaml`, ITEM(id));
-    const c = await run(dir, ["claim", "cohort-m1"]);
-    assert.equal(c.code, 0);
-    assert.deepEqual(ls(dir), [
-      "2026-09-08T09-59-00-000Z-cohort-m1.yaml.dispatched",
-      "2026-09-08T09-59-00-000Z-cohort-m10.yaml",
-      "2026-09-08T09-59-00-000Z-cohort-m11.yaml",
-    ]);
-    const d = await run(dir, ["done", "cohort-m1"]);
-    assert.equal(d.code, 0);
-    assert.equal(d.out.renamed, 1);
-    assert.deepEqual(ls(dir), [
-      "2026-09-08T09-59-00-000Z-cohort-m1.yaml.processed",
-      "2026-09-08T09-59-00-000Z-cohort-m10.yaml",
-      "2026-09-08T09-59-00-000Z-cohort-m11.yaml",
-    ]);
-    // A truncated id that could mean several items is refused, not guessed.
-    const amb = await run(dir, ["claim", "m1"]);
-    assert.equal(amb.code, 1);
-    assert.equal(amb.out.error, "not-found");
-  } finally { rm(dir); }
-});

package/lib/cli/session-ack.test.mjs

@@ -1,63 +0,0 @@
-/**
- * session-ack.test.mjs — `maestro session ack <tickId>` moves a handoff to
- * done/ (design §3.4). The function form is what WP-M3's session CLI calls.
- */
-
-import { test } from "node:test";
-import assert from "node:assert/strict";
-import { mkdtempSync, rmSync, existsSync, readFileSync } from "node:fs";
-import { join } from "node:path";
-import { tmpdir } from "node:os";
-
-import { writeHandoff, handoffPaths, listHandoffs } from "../session/handoffs.mjs";
-import { ackHandoff, runSessionAck } from "./session-ack.mjs";
-
-const T0 = Date.parse("2026-09-08T10:00:00.000Z");
-function root() { return mkdtempSync(join(tmpdir(), "maestro-session-ack-")); }
-function rm(dir) { try { rmSync(dir, { recursive: true, force: true }); } catch { /* */ } }
-async function run(dir, argv) {
-  let out = "";
-  const code = await runSessionAck(argv, { agentRoot: dir, now: T0 + 60_000, stdout: (s) => { out += s; } });
-  let parsed = out;
-  try { parsed = JSON.parse(out); } catch { /* usage text */ }
-  return { code, out: parsed, raw: out };
-}
-
-test("ackHandoff: acks an open handoff (function form for the session CLI); idempotent; unknown → not-found", () => {
-  const dir = root();
-  try {
-    writeHandoff(dir, { tickId: "evt-1", cadence: "goal-steward", mode: "escalate", promptPath: "/p" }, { now: T0 });
-    const r = ackHandoff({ agentRoot: dir, tickId: "evt-1", resultPath: "/tmp/r.md", now: T0 + 1000 });
-    assert.equal(r.ok, true);
-    assert.deepEqual(listHandoffs(dir), []);
-    const done = JSON.parse(readFileSync(join(handoffPaths(dir).done, "evt-1.json"), "utf-8"));
-    assert.equal(done.status, "acked");
-    assert.equal(done.resultPath, "/tmp/r.md");
-    assert.equal(ackHandoff({ agentRoot: dir, tickId: "evt-1" }).already, true);
-    assert.equal(ackHandoff({ agentRoot: dir, tickId: "evt-x" }).error, "not-found");
-    assert.equal(ackHandoff({ agentRoot: dir }).ok, false);
-  } finally { rm(dir); }
-});
-
-test("runSessionAck: CLI form prints JSON and exits 0/1; --list shows open handoffs; usage without an id", async () => {
-  const dir = root();
-  try {
-    writeHandoff(dir, { tickId: "evt-2", cadence: "daily-morning-brief", mode: "escalate", promptPath: "/p" }, { now: T0 });
-    const l = await run(dir, ["--list"]);
-    assert.equal(l.code, 0);
-    assert.deepEqual(l.out.map((h) => h.tickId), ["evt-2"]);
-    assert.equal(l.out[0].path, undefined, "no absolute ledger path in the listing");
-    const ok = await run(dir, ["evt-2", "--result", "/tmp/out.md", "--note", "done"]);
-    assert.equal(ok.code, 0);
-    assert.equal(ok.out.ok, true);
-    assert.equal(ok.out.tickId, "evt-2");
-    assert.equal(existsSync(join(handoffPaths(dir).done, "evt-2.json")), true);
-    assert.equal(JSON.parse(readFileSync(join(handoffPaths(dir).done, "evt-2.json"), "utf-8")).note, "done");
-    const missing = await run(dir, ["evt-nope"]);
-    assert.equal(missing.code, 1);
-    assert.equal(missing.out.error, "not-found");
-    const usage = await run(dir, []);
-    assert.equal(usage.code, 1);
-    assert.match(usage.raw, /maestro session ack/);
-  } finally { rm(dir); }
-});