@codeyam/codeyam-cli 0.1.0-staging.b8a55ba → 0.1.0-staging.bd4126b

package/analyzer-template/packages/analyze/src/lib/files/analyze/analyzeEntities/prepareDataStructures.ts

@@ -4,19 +4,27 @@ import { awsLog, awsLogDebugLevel } from '~codeyam/utils';
 import measureAndReportExecutionTime from '../../../utils/measureAndReportExecutionTime';
 
 import {
+  deduplicateFunctionSchemas,
+  detectWrapperRequirements,
   fillInDirectSchemaGapsAndUnknowns,
   generateEntityDataStructure,
-  deduplicateFunctionSchemas,
+  getConditionalUsages,
   getEquivalentSignatureVariables,
   getFunctionSignature,
   getReturnValue,
   getSourceEquivalencies,
   getUsageEquivalencies,
-  getConditionalUsages,
-  detectWrapperRequirements,
+  getConditionalEffects,
+  getCompoundConditionals,
+  getChildBoundaryGatingConditions,
+  getJsxRenderingUsages,
+  skipWorkerPool,
 } from '~codeyam/ai';
 import type { AnalysisOptions } from '../analyzeEntities';
 
+// Set to true to process entities one at a time for easier debugging.
+const DEBUG_SEQUENTIAL_EXECUTION = false;
+
 // VERSION MARKER: server-only-detection-v2 (2025-12-28)
 // This version includes automatic detection of "use server" and "server-only" files
 // and runs server-only detection even for cached entities
@@ -31,254 +39,268 @@ export default async function prepareEntityDataStructures(
   projectAnalyzer: ProjectAnalyzer,
   options: AnalysisOptions,
 ): Promise<void> {
-  // Process entities in parallel for speed
-  await Promise.all(
-    Array.from(allEntities).map(async (entity) => {
-      // Check if already has cached data structure (unless force is set)
-      const hasCache = !!entity.metadata?.isolatedDataStructure;
-      const shouldRegenerateDataStructure =
-        !hasCache || options.force || options.forceAll;
-
-      // PHASE 1: Generate data structure (only for non-cached entities or when forced)
-      // Wrapped in its own try-catch so PHASE 2 always runs even if this fails
-      if (shouldRegenerateDataStructure) {
-        try {
-          const fileAnalyzer = projectAnalyzer.getFileAnalyzerByPath(
-            entity.resolvedFilePath ?? entity.filePath,
+  const processEntity = async (entity: Entity) => {
+    // Check if already has cached data structure (unless force is set)
+    const hasCache = !!entity.metadata?.isolatedDataStructure;
+    const shouldRegenerateDataStructure =
+      !hasCache || options.force || options.forceAll;
+
+    // PHASE 1: Generate data structure (only for non-cached entities or when forced)
+    // Wrapped in its own try-catch so PHASE 2 always runs even if this fails
+    if (shouldRegenerateDataStructure) {
+      try {
+        const fileAnalyzer = projectAnalyzer.getFileAnalyzerByPath(
+          entity.resolvedFilePath ?? entity.filePath,
+        );
+        if (!fileAnalyzer) {
+          awsLog(
+            `CodeYam: prepareEntityDataStructures: FileAnalyzer not found`,
+            {
+              entityFilePath: entity.filePath,
+              entityName: entity.name,
+            },
           );
-          if (!fileAnalyzer) {
-            awsLog(
-              `CodeYam: prepareEntityDataStructures: FileAnalyzer not found`,
-              {
-                entityFilePath: entity.filePath,
-                entityName: entity.name,
-              },
-            );
+          // Still continue to PHASE 2 for server-only detection
+        } else {
+          const dataStructureInfo =
+            await getEntityDataStructureAndFunctionCalls({
+              entity,
+              fileAnalyzer,
+            });
+
+          if (!dataStructureInfo?.isolatedDataStructure) {
+            // Data structure generation failed - entity will proceed with empty schemas
+            // This is okay - the entity can still be analyzed, just without detailed type info
+            if (['visual', 'library'].includes(entity.entityType)) {
+              // we'd really expect these to have data structures
+              awsLog(
+                `CodeYam: prepareEntityDataStructures: Failed to generate data structure for ${entity.filePath}:${entity.name}`,
+              );
+            }
             // Still continue to PHASE 2 for server-only detection
           } else {
-            const dataStructureInfo =
-              await getEntityDataStructureAndFunctionCalls({
-                entity,
-                fileAnalyzer,
-              });
-
-            if (!dataStructureInfo?.isolatedDataStructure) {
-              // Data structure generation failed - entity will proceed with empty schemas
-              // This is okay - the entity can still be analyzed, just without detailed type info
-              if (['visual', 'library'].includes(entity.entityType)) {
-                // we'd really expect these to have data structures
-                awsLog(
-                  `CodeYam: prepareEntityDataStructures: Failed to generate data structure for ${entity.filePath}:${entity.name}`,
-                );
+            const { isolatedDataStructure, functionCalls, callVariableNames } =
+              dataStructureInfo;
+
+            // Store data structure in entity metadata
+            entity.metadata ||= {};
+
+            // Deep clone dependencySchemas to avoid shared references
+            // We need to clone because getReturnValue() returns direct references to schema objects
+            // and multiple entities might reference the same dependency
+            const clonedDependencySchemas: typeof isolatedDataStructure.dependencySchemas =
+              {};
+            for (const filePath in isolatedDataStructure.dependencySchemas) {
+              clonedDependencySchemas[filePath] = {};
+              for (const entityName in isolatedDataStructure.dependencySchemas[
+                filePath
+              ]) {
+                const depSchema =
+                  isolatedDataStructure.dependencySchemas[filePath][entityName];
+                clonedDependencySchemas[filePath][entityName] = {
+                  signatureSchema: { ...depSchema.signatureSchema },
+                  returnValueSchema: { ...depSchema.returnValueSchema },
+                  usageEquivalencies: depSchema.usageEquivalencies,
+                  sourceEquivalencies: depSchema.sourceEquivalencies,
+                };
               }
-              // Still continue to PHASE 2 for server-only detection
-            } else {
-              const {
-                isolatedDataStructure,
-                functionCalls,
-                callVariableNames,
-              } = dataStructureInfo;
-
-              // Store data structure in entity metadata
-              entity.metadata ||= {};
-
-              // Deep clone dependencySchemas to avoid shared references
-              // We need to clone because getReturnValue() returns direct references to schema objects
-              // and multiple entities might reference the same dependency
-              const clonedDependencySchemas: typeof isolatedDataStructure.dependencySchemas =
-                {};
-              for (const filePath in isolatedDataStructure.dependencySchemas) {
-                clonedDependencySchemas[filePath] = {};
-                for (const entityName in isolatedDataStructure
-                  .dependencySchemas[filePath]) {
-                  const depSchema =
-                    isolatedDataStructure.dependencySchemas[filePath][
-                      entityName
-                    ];
-                  clonedDependencySchemas[filePath][entityName] = {
-                    signatureSchema: { ...depSchema.signatureSchema },
-                    returnValueSchema: { ...depSchema.returnValueSchema },
-                    usageEquivalencies: depSchema.usageEquivalencies,
-                    sourceEquivalencies: depSchema.sourceEquivalencies,
-                  };
-                }
+            }
+
+            // LOGGING: Track dependencySchemas entity names for debugging :: format issues
+            const allEntityNames: string[] = [];
+            for (const filePath in clonedDependencySchemas) {
+              for (const entityName in clonedDependencySchemas[filePath]) {
+                allEntityNames.push(`${filePath}:${entityName}`);
               }
+            }
+            entity.metadata.isolatedDataStructure = {
+              signatureSchema: deduplicateFunctionSchemas(
+                isolatedDataStructure.signatureSchema,
+              ),
+              returnValueSchema: deduplicateFunctionSchemas(
+                isolatedDataStructure.returnValueSchema,
+              ),
+              equivalentSignatureVariables:
+                isolatedDataStructure.equivalentSignatureVariables,
+              dependencySchemas: clonedDependencySchemas,
+              environmentVariables: isolatedDataStructure.environmentVariables,
+              // Use enriched conditional usages with source tracing from analysis
+              conditionalUsages: isolatedDataStructure.conditionalUsages,
+              // Include conditional effects for execution flow generation
+              conditionalEffects: isolatedDataStructure.conditionalEffects,
+              // Include compound conditionals for complete execution flow generation
+              compoundConditionals: isolatedDataStructure.compoundConditionals,
+              // Include root entity's equivalencies for merge step
+              usageEquivalencies: isolatedDataStructure.usageEquivalencies,
+              sourceEquivalencies: isolatedDataStructure.sourceEquivalencies,
+              // Include child boundary gating conditions for child component flow merging
+              childBoundaryGatingConditions:
+                isolatedDataStructure.childBoundaryGatingConditions,
+              // Include JSX rendering usages for array size and text length flow generation
+              jsxRenderingUsages: isolatedDataStructure.jsxRenderingUsages,
+            };
+
+            // Detect wrapper requirements (Context providers, etc.)
+            const wrapperRequirements = detectWrapperRequirements({
+              entity,
+              fileAnalyzer,
+            });
+            if (wrapperRequirements.length > 0) {
+              entity.metadata.wrapperRequirements = wrapperRequirements;
+            }
 
-              entity.metadata.isolatedDataStructure = {
-                signatureSchema: deduplicateFunctionSchemas(
-                  isolatedDataStructure.signatureSchema,
-                ),
-                returnValueSchema: deduplicateFunctionSchemas(
-                  isolatedDataStructure.returnValueSchema,
-                ),
-                equivalentSignatureVariables:
-                  isolatedDataStructure.equivalentSignatureVariables,
-                dependencySchemas: clonedDependencySchemas,
-                environmentVariables:
-                  isolatedDataStructure.environmentVariables,
-                // Use enriched conditional usages with source tracing from analysis
-                conditionalUsages: isolatedDataStructure.conditionalUsages,
-                // Include root entity's equivalencies for merge step
-                usageEquivalencies: isolatedDataStructure.usageEquivalencies,
-                sourceEquivalencies: isolatedDataStructure.sourceEquivalencies,
-              };
-
-              // Detect wrapper requirements (Context providers, etc.)
-              const wrapperRequirements = detectWrapperRequirements({
-                entity,
-                fileAnalyzer,
-              });
-              if (wrapperRequirements.length > 0) {
-                entity.metadata.wrapperRequirements = wrapperRequirements;
+            // Annotate imported exports with function call information
+            const importedExports = entity.metadata.importedExports ?? [];
+            for (const importedExport of importedExports) {
+              const relevantCalls = functionCalls[importedExport.name];
+              if (relevantCalls) {
+                importedExport.calls = relevantCalls;
               }
+              const relevantVariableNames =
+                callVariableNames[importedExport.name];
+              if (relevantVariableNames) {
+                importedExport.callVariableNames = relevantVariableNames;
+              }
+            }
 
-              // Annotate imported exports with function call information
-              const importedExports = entity.metadata.importedExports ?? [];
-              for (const importedExport of importedExports) {
-                const relevantCalls = functionCalls[importedExport.name];
+            // Annotate node module imports with function call information
+            for (const [path, infos] of Object.entries(
+              entity.metadata.nodeModuleImports ?? {},
+            )) {
+              for (const info of infos) {
+                const relevantCalls = functionCalls[info.name];
                 if (relevantCalls) {
-                  importedExport.calls = relevantCalls;
+                  info.calls = relevantCalls;
                 }
-                const relevantVariableNames =
-                  callVariableNames[importedExport.name];
+                const relevantVariableNames = callVariableNames[info.name];
                 if (relevantVariableNames) {
-                  importedExport.callVariableNames = relevantVariableNames;
-                }
-              }
-
-              // Annotate node module imports with function call information
-              for (const [path, infos] of Object.entries(
-                entity.metadata.nodeModuleImports ?? {},
-              )) {
-                for (const info of infos) {
-                  const relevantCalls = functionCalls[info.name];
-                  if (relevantCalls) {
-                    info.calls = relevantCalls;
-                  }
-                  const relevantVariableNames = callVariableNames[info.name];
-                  if (relevantVariableNames) {
-                    info.callVariableNames = relevantVariableNames;
-                  }
+                  info.callVariableNames = relevantVariableNames;
                 }
               }
             }
           }
-        } catch (phase1Error) {
-          console.warn(
-            `CodeYam: prepareEntityDataStructures: PHASE 1 error for ${entity.filePath}:${entity.name}:`,
-            phase1Error,
-          );
-          // Continue to PHASE 2 - server-only detection should still run
         }
+      } catch (phase1Error) {
+        console.warn(
+          `CodeYam: prepareEntityDataStructures: PHASE 1 error for ${entity.filePath}:${entity.name}:`,
+          phase1Error,
+        );
+        // Continue to PHASE 2 - server-only detection should still run
       }
+    }
 
-      try {
-        // PHASE 2: Server-only detection and isMocked determination
-        // This runs for ALL entities, even those with cached data structures
-        // because server-only detection may have been added after the entity was cached
-        const importedExports = entity.metadata?.importedExports ?? [];
-        const mockedDependencies = determineMockedDependencies(entity);
-        for (const importedExport of importedExports) {
-          // Skip if already has a definitive isMocked value (true or false, not null)
-          // But re-check if isMocked is null or undefined - this handles previously cached entities
-          if (
-            importedExport.isMocked === true ||
-            importedExport.isMocked === false
-          ) {
-            console.log(
-              `CodeYam: [${entity.name}] SKIP ${importedExport.name} - already has isMocked=${importedExport.isMocked}`,
-            );
-            continue;
-          }
-
-          // Never mock visual components - they render UI and should use real implementation
-          if (importedExport.entityType === 'visual') {
-            console.log(
-              `CodeYam: [${entity.name}] SKIP ${importedExport.name} - visual component, setting isMocked=false`,
-            );
-            importedExport.isMocked = false;
-            continue;
-          }
-
-          // Always mock imports from server-only files ("use server" or import "server-only")
-          // These files contain Server Actions or server-only code that cannot run on the client
-          const importedFilePath =
-            importedExport.resolvedFilePath ?? importedExport.filePath;
-          const importedFileAnalyzer =
-            projectAnalyzer.getFileAnalyzerByPath(importedFilePath);
-          // Use sourceFile.getText() which is always available, unlike file.content which is lazy-loaded
-          const importedFileContent =
-            importedFileAnalyzer?.sourceFile?.getText();
-
-          const isServerOnly = importedFileContent
-            ? isServerOnlyFile(importedFileContent)
-            : false;
-          console.log(
-            `CodeYam: [${entity.name}] CHECK ${importedExport.name} from ${importedFilePath}:`,
-            {
-              hasFileAnalyzer: !!importedFileAnalyzer,
-              hasSourceFile: !!importedFileAnalyzer?.sourceFile,
-              hasFileContent: !!importedFileContent,
-              contentFirst50Chars: importedFileContent
-                ?.substring(0, 50)
-                ?.replace(/\n/g, '\\n'),
-              isServerOnly,
-            },
-          );
+    try {
+      // PHASE 2: Server-only detection and isMocked determination
+      // This runs for ALL entities, even those with cached data structures
+      // because server-only detection may have been added after the entity was cached
+      const importedExports = entity.metadata?.importedExports ?? [];
+      const mockedDependencies = determineMockedDependencies(entity);
+      for (const importedExport of importedExports) {
+        // Skip if already has a definitive isMocked value (true or false, not null)
+        // But re-check if isMocked is null or undefined - this handles previously cached entities
+        if (
+          importedExport.isMocked === true ||
+          importedExport.isMocked === false
+        ) {
+          continue;
+        }
 
-          if (importedFileContent && isServerOnly) {
-            console.log(
-              `CodeYam: [${entity.name}] ✓ MARKING ${importedExport.name} as isMocked=true (server-only file detected)`,
-            );
-            importedExport.isMocked = true;
-            continue;
-          }
+        // Never mock visual components - they render UI and should use real implementation
+        if (importedExport.entityType === 'visual') {
+          importedExport.isMocked = false;
+          continue;
+        }
 
-          const matchesMockedDep = mockedDependencies.some(
-            (dep) =>
-              dep.filePath === importedExport.filePath &&
-              dep.entityName === importedExport.name,
-          );
-          importedExport.isMocked = matchesMockedDep;
-          console.log(
-            `CodeYam: [${entity.name}] ${importedExport.name} isMocked=${matchesMockedDep} (from mockedDependencies)`,
-          );
+        // Always mock imports from server-only files ("use server" or import "server-only")
+        // These files contain Server Actions or server-only code that cannot run on the client
+        const importedFilePath =
+          importedExport.resolvedFilePath ?? importedExport.filePath;
+        const importedFileAnalyzer =
+          projectAnalyzer.getFileAnalyzerByPath(importedFilePath);
+        // Use sourceFile.getText() which is always available, unlike file.content which is lazy-loaded
+        const importedFileContent = importedFileAnalyzer?.sourceFile?.getText();
+
+        const isServerOnly = importedFileContent
+          ? isServerOnlyFile(importedFileContent)
+          : false;
+
+        if (importedFileContent && isServerOnly) {
+          importedExport.isMocked = true;
+          continue;
         }
 
-        // Browser globals that should always be mocked (they make network calls)
-        const alwaysMockedBrowserGlobals = ['fetch', 'EventSource'];
-
-        for (const [path, infos] of Object.entries(
-          entity.metadata?.nodeModuleImports ?? {},
-        )) {
-          for (const info of infos) {
-            if (info.isMocked === undefined || info.isMocked === null) {
-              // Browser globals should always be mocked
-              if (alwaysMockedBrowserGlobals.includes(path)) {
-                info.isMocked = true;
-              } else {
-                // Check if this dependency should be mocked
-                // Match both exact entityName and variable-qualified entityNames
-                // e.g., "useFetcher" matches "useFetcher" OR "useFetcher::userFetcher"
-                info.isMocked = mockedDependencies.some(
-                  (dep) =>
-                    dep.filePath === path &&
-                    (dep.entityName === info.name ||
-                      dep.entityName.startsWith(info.name + '::')),
-                );
-              }
+        const matchesMockedDep = mockedDependencies.some(
+          (dep) =>
+            dep.filePath === importedExport.filePath &&
+            dep.entityName === importedExport.name,
+        );
+        importedExport.isMocked = matchesMockedDep;
+      }
+
+      // Browser globals that should always be mocked (they make network calls)
+      const alwaysMockedBrowserGlobals = ['fetch', 'EventSource'];
+
+      for (const [path, infos] of Object.entries(
+        entity.metadata?.nodeModuleImports ?? {},
+      )) {
+        for (const info of infos) {
+          if (info.isMocked === undefined || info.isMocked === null) {
+            // Browser globals should always be mocked
+            if (alwaysMockedBrowserGlobals.includes(path)) {
+              info.isMocked = true;
+            } else {
+              // Check if this dependency should be mocked
+              // Match both exact entityName and variable-qualified entityNames
+              // e.g., "useFetcher" matches "useFetcher" OR "useFetcher::userFetcher"
+              info.isMocked = mockedDependencies.some(
+                (dep) =>
+                  dep.filePath === path &&
+                  (dep.entityName === info.name ||
+                    dep.entityName.startsWith(info.name + '::')),
+              );
             }
           }
         }
-      } catch (error) {
-        console.warn(
-          `CodeYam: prepareEntityDataStructures: Error preparing ${entity.filePath}:${entity.name}:`,
-          error,
-        );
-        // Continue with other entities - this one will have empty schemas
       }
-    }),
-  );
+    } catch (error) {
+      console.warn(
+        `CodeYam: prepareEntityDataStructures: Error preparing ${entity.filePath}:${entity.name}:`,
+        error,
+      );
+      // Continue with other entities - this one will have empty schemas
+    }
+  };
+
+  const entities = Array.from(allEntities);
+
+  // The worker thread creates its own ProjectAnalyzer (ts.Program) on first use,
+  // which takes 50-70s. For small entity counts the overhead far exceeds the actual
+  // processing time (<2s). Skip the worker and run on the main thread instead,
+  // reusing the existing ProjectAnalyzer.
+  const entitiesNeedingGeneration = entities.filter(
+    (e) =>
+      !e.metadata?.isolatedDataStructure || options.force || options.forceAll,
+  ).length;
+  const WORKER_ENTITY_THRESHOLD = 500;
+  if (entitiesNeedingGeneration < WORKER_ENTITY_THRESHOLD) {
+    console.log(
+      `CodeYam: Skipping worker thread for DS prep (${entitiesNeedingGeneration} entities < ${WORKER_ENTITY_THRESHOLD} threshold)`,
+    );
+    skipWorkerPool();
+  }
+
+  const sequential =
+    DEBUG_SEQUENTIAL_EXECUTION || options.sequentialDataStructurePrep;
+
+  if (sequential) {
+    // Sequential execution for debugging - process one entity at a time
+    for (const entity of entities) {
+      await processEntity(entity);
+    }
+  } else {
+    // Parallel execution for speed
+    await Promise.all(entities.map(processEntity));
+  }
 }
 
 /**
@@ -328,19 +350,33 @@ async function getEntityDataStructureAndFunctionCalls({
         functionName: importedExport.name,
       });
 
-      // If no signature found, this function doesn't exist in the analysis
-      if (!signatureSchema) {
-        return acc;
-      }
-
       const returnValueSchema = getReturnValue(dataStructure, {
         functionName: importedExport.name,
       });
 
+      // If neither signature nor return value found, check if this function has matching
+      // external function calls. External functions (like useLoaderData from react-router)
+      // don't have entries in functionResults, so getReturnValue returns null for them.
+      // But their return values ARE traced in externalFunctionCalls via perVariableSchemas.
+      // We need to check for matching calls before skipping.
+      if (!signatureSchema && !returnValueSchema) {
+        const hasMatchingExternalCall =
+          dataStructure.externalFunctionCalls?.some(
+            (fc) =>
+              fc.name === importedExport.name ||
+              fc.name.startsWith(importedExport.name + '<'),
+          );
+
+        // Only skip if there are no matching external function calls
+        if (!hasMatchingExternalCall) {
+          return acc;
+        }
+      }
+
       // Clone schemas before deduplication to avoid mutating shared references
       // getReturnValue() and getFunctionSignature() return direct references, so we need
       // to clone them before passing to deduplicateFunctionSchemas (which may mutate)
-      const clonedSignatureSchema = { ...signatureSchema };
+      const clonedSignatureSchema = { ...(signatureSchema ?? {}) };
       const clonedReturnValueSchema = { ...(returnValueSchema ?? {}) };
 
       acc[importedExport.filePath] ||= {};
@@ -365,32 +401,105 @@ async function getEntityDataStructureAndFunctionCalls({
           fc.name.startsWith(importedExport.name + '<'),
       );
 
-      // Track how many times each variable name has been seen across ALL matching calls
-      // This handles the case where multiple parameterized calls (e.g., useFetcher<ConfigData>,
-      // useFetcher<SettingsData>) assign to the same variable name
-      const varNameCounts: Record<string, number> = {};
-
       for (const efc of matchingCalls) {
-        // Check if this call has perVariableSchemas (multiple calls with same signature)
+        // Check if this call has perVariableSchemas (multiple calls with variable tracking)
         if (efc?.perVariableSchemas) {
-          for (const [varName, perVarSchema] of Object.entries(
-            efc.perVariableSchemas,
-          )) {
-            // Track occurrences of this variable name
-            const occurrence = varNameCounts[varName] ?? 0;
-            varNameCounts[varName] = occurrence + 1;
-
-            // Use indexed key if variable name is reused (e.g., fetcher, fetcher[1])
-            const indexedVarName =
-              occurrence === 0 ? varName : `${varName}[${occurrence}]`;
-            const qualifiedKey = `${importedExport.name}::${indexedVarName}`;
-            acc[importedExport.filePath][qualifiedKey] = {
+          // Check if perVariableSchemas has indexed keys (e.g., "fetcher[1]") which indicates
+          // variable reuse with DIFFERENT call signatures (e.g., let fetcher = useFetcher<A>(); fetcher = useFetcher<B>();)
+          // In this case, we need to create SEPARATE entries for each call signature.
+          const perVarKeys = Object.keys(efc.perVariableSchemas);
+          const hasIndexedKeys = perVarKeys.some((key) => /\[\d+\]$/.test(key));
+
+          if (
+            hasIndexedKeys &&
+            efc.callSignatureToVariable &&
+            efc.allCallSignatures
+          ) {
+            // Variable reuse case: create separate entries for each call signature
+            // Map from call signature to its variable key in perVariableSchemas
+            // e.g., useFetcher<ConfigData>() -> 'fetcher', useFetcher<SettingsData>() -> 'fetcher[1]'
+            const varNameCounts: Record<string, number> = {};
+            for (const callSig of efc.allCallSignatures) {
+              const varName = efc.callSignatureToVariable[callSig];
+              if (!varName) continue;
+
+              // Track occurrence count for this variable name
+              const occurrence = varNameCounts[varName] ?? 0;
+              varNameCounts[varName] = occurrence + 1;
+
+              // Get the key in perVariableSchemas (indexed if reused)
+              const perVarKey =
+                occurrence === 0 ? varName : `${varName}[${occurrence}]`;
+              const varSchema = efc.perVariableSchemas[perVarKey];
+
+              if (varSchema && Object.keys(varSchema).length > 0) {
+                // Create entry with this call signature as the key
+                const rewrittenSchema: Record<string, string> = {};
+                rewrittenSchema[`${callSig}.functionCallReturnValue`] =
+                  'object';
+
+                for (const [path, type] of Object.entries(varSchema)) {
+                  const rewrittenPath = path.startsWith(callSig)
+                    ? path
+                    : `${callSig}.${path}`;
+                  rewrittenSchema[rewrittenPath] = type;
+                }
+
+                acc[importedExport.filePath][callSig] = {
+                  signatureSchema: deduplicateFunctionSchemas({
+                    ...signatureSchema,
+                  }),
+                  returnValueSchema:
+                    deduplicateFunctionSchemas(rewrittenSchema),
+                  usageEquivalencies:
+                    getUsageEquivalencies(dataStructure, importedExport.name) ??
+                    {},
+                  sourceEquivalencies:
+                    getSourceEquivalencies(
+                      dataStructure,
+                      importedExport.name,
+                    ) ?? {},
+                };
+              }
+            }
+          } else {
+            // Destructuring case: const { a, b, c } = useLoaderData()
+            // Merge all variable schemas into a single entry with the call signature as key
+            const callSignatureKey = efc.callSignature;
+
+            // Merge all variable schemas by prepending the call signature to each path.
+            // perVariableSchemas paths are like "functionCallReturnValue.entities.sha"
+            // We need to prefix them with the call signature to get:
+            // "useLoaderData<typeof loader>().functionCallReturnValue.entities.sha"
+            const mergedReturnValueSchema: Record<string, string> = {};
+
+            // Set the top-level return value as object since it contains named properties
+            mergedReturnValueSchema[
+              `${callSignatureKey}.functionCallReturnValue`
+            ] = 'object';
+
+            for (const [varName, perVarSchema] of Object.entries(
+              efc.perVariableSchemas,
+            )) {
+              for (const [path, type] of Object.entries(perVarSchema)) {
+                // Only prepend the call signature if the path doesn't already have it.
+                // perVariableSchemas paths may already include the call signature prefix
+                // (e.g., "useCustomSizes(projectSlug).functionCallReturnValue.customSizes")
+                // depending on how they were built. If so, use the path as-is.
+                const rewrittenPath = path.startsWith(callSignatureKey)
+                  ? path
+                  : `${callSignatureKey}.${path}`;
+                mergedReturnValueSchema[rewrittenPath] = type;
+              }
+            }
+
+            acc[importedExport.filePath][callSignatureKey] = {
               signatureSchema: deduplicateFunctionSchemas({
                 ...signatureSchema,
               }),
-              returnValueSchema: deduplicateFunctionSchemas({
-                ...perVarSchema,
-              }),
+              returnValueSchema: deduplicateFunctionSchemas(
+                mergedReturnValueSchema,
+              ),
               usageEquivalencies:
                 getUsageEquivalencies(dataStructure, importedExport.name) ?? {},
               sourceEquivalencies:
@@ -400,18 +509,11 @@ async function getEntityDataStructureAndFunctionCalls({
           }
         } else if (efc?.receivingVariableNames?.length === 1) {
           // For parameterized calls like useFetcher<UserData>(), each is a separate entry
-          // with a single receivingVariableName. Create a variable-qualified entry using
-          // the specific return value for this parameterized call.
+          // with a single receivingVariableName. Use the call signature as the key.
           const varName = efc.receivingVariableNames[0];
 
-          // Track occurrences of this variable name across all efc entries
-          const occurrence = varNameCounts[varName] ?? 0;
-          varNameCounts[varName] = occurrence + 1;
-
-          // Use indexed key if variable name is reused (e.g., fetcher, fetcher[1])
-          const indexedVarName =
-            occurrence === 0 ? varName : `${varName}[${occurrence}]`;
-          const qualifiedKey = `${importedExport.name}::${indexedVarName}`;
+          // Use the call signature as the key (e.g., "useFetcher<UserData>()")
+          const callSignatureKey = efc.callSignature;
 
           // PREFER perVariableSchemas over getReturnValue() when available
           // perVariableSchemas has the SPECIFIC schema for this parameterized call,
@@ -434,7 +536,7 @@ async function getEntityDataStructureAndFunctionCalls({
             parameterizedReturnValue &&
             Object.keys(parameterizedReturnValue).length > 0
           ) {
-            acc[importedExport.filePath][qualifiedKey] = {
+            acc[importedExport.filePath][callSignatureKey] = {
               signatureSchema: deduplicateFunctionSchemas({
                 ...signatureSchema,
               }),
@@ -471,6 +573,42 @@ async function getEntityDataStructureAndFunctionCalls({
     },
   );
 
+  // Add same-file child components to dependencySchemas.
+  // Same-file components (e.g., AgentCard defined in the same file as AgentTranscriptsPage)
+  // appear in externalFunctionCalls and functionResults but NOT in importedExports or
+  // nodeModuleImports. Without this, their signatures are missing from dependencySchemas
+  // and enrichArrayTypesFromChildSignatures can't find child component field accesses.
+  const allDependencyNames = new Set(allDependencies.map((d) => d.name));
+
+  for (const efc of dataStructure.externalFunctionCalls) {
+    // Skip if already covered by importedExports or nodeModuleImports
+    if (allDependencyNames.has(efc.name)) continue;
+
+    const signatureSchema = getFunctionSignature(dataStructure, {
+      functionName: efc.name,
+    });
+
+    const returnValueSchema = getReturnValue(dataStructure, {
+      functionName: efc.name,
+    });
+
+    // Only add if we have signature or return value data
+    if (!signatureSchema && !returnValueSchema) continue;
+
+    const clonedSignatureSchema = { ...(signatureSchema ?? {}) };
+    const clonedReturnValueSchema = { ...(returnValueSchema ?? {}) };
+
+    const entityFilePath = entity.filePath;
+    dependencySchemas[entityFilePath] ||= {};
+    dependencySchemas[entityFilePath][efc.name] = {
+      signatureSchema: deduplicateFunctionSchemas(clonedSignatureSchema),
+      returnValueSchema: deduplicateFunctionSchemas(clonedReturnValueSchema),
+      usageEquivalencies: getUsageEquivalencies(dataStructure, efc.name) ?? {},
+      sourceEquivalencies:
+        getSourceEquivalencies(dataStructure, efc.name) ?? {},
+    };
+  }
+
   const rawReturnValue =
     getReturnValue(dataStructure, { fillInUnknowns: false }) ?? {};
 
@@ -483,23 +621,54 @@ async function getEntityDataStructureAndFunctionCalls({
   // Get enriched conditional usages with source tracing
   const conditionalUsages = getConditionalUsages(dataStructure);
 
+  // Get conditional effects (setter calls inside conditionals)
+  const conditionalEffects = getConditionalEffects(dataStructure);
+
+  // Get compound conditionals (grouped conditions that must all be true)
+  const compoundConditionals = getCompoundConditionals(dataStructure);
   const rawUsageEquivalencies = getUsageEquivalencies(dataStructure);
   const rawSourceEquivalencies = getSourceEquivalencies(dataStructure);
 
+  // Get child boundary gating conditions for child component flow merging
+  const childBoundaryGatingConditions =
+    getChildBoundaryGatingConditions(dataStructure);
+
+  // Get JSX rendering usages for array size and text length flow generation
+  const jsxRenderingUsages = getJsxRenderingUsages(dataStructure);
+
+  const equivalentSignatureVariables =
+    getEquivalentSignatureVariables(dataStructure);
+
   const isolatedDataStructure = {
     signatureSchema: deduplicateFunctionSchemas(clonedRawSignature),
     returnValueSchema: deduplicateFunctionSchemas(clonedRawReturnValue),
-    equivalentSignatureVariables:
-      getEquivalentSignatureVariables(dataStructure),
+    equivalentSignatureVariables,
     dependencySchemas,
     environmentVariables: dataStructure.environmentVariables,
     conditionalUsages:
       Object.keys(conditionalUsages).length > 0 ? conditionalUsages : undefined,
+    // Include conditional effects for execution flow generation
+    conditionalEffects:
+      conditionalEffects.length > 0 ? conditionalEffects : undefined,
+    // Include compound conditionals for complete execution flow generation
+    // These capture grouped conditions like (a || b) && !c && !d
+    compoundConditionals:
+      compoundConditionals.length > 0 ? compoundConditionals : undefined,
     // Include root entity's equivalencies so they can be used during merge.
     // These show how the parent's data flows to/from child components.
     // E.g., for SurveysList, usageEquivalencies shows surveys[] → SurveyCard().signature[0].survey
     usageEquivalencies: rawUsageEquivalencies ?? {},
     sourceEquivalencies: rawSourceEquivalencies ?? {},
+    // Include child boundary gating conditions for child component flow merging
+    // Maps child component names to the conditions that must be true for them to render
+    childBoundaryGatingConditions:
+      Object.keys(childBoundaryGatingConditions).length > 0
+        ? childBoundaryGatingConditions
+        : undefined,
+    // Include JSX rendering usages for array size and text length flow generation
+    // These track arrays rendered via .map() and strings interpolated in JSX
+    jsxRenderingUsages:
+      jsxRenderingUsages.length > 0 ? jsxRenderingUsages : undefined,
   };
 
   const functionCalls: Record<string, string[]> = {};
@@ -557,6 +726,7 @@ async function getEntityDataStructureAndFunctionCalls({
       ) {
         variableNames.push(...aggregatedReceivingVariableNames);
       }
+
       if (variableNames.length > 0) {
         callVariableNames[entityName] = variableNames;
       }
@@ -754,9 +924,21 @@ export function determineMockedDependencies(entity: Entity) {
       // A schema with only "EntityName(): function" just indicates the entity is callable,
       // it doesn't mean there's actual return data to mock
       const hasReturnValue = hasActualReturnValueData(entityReturnValueSchema);
-      const complexReturnValue = Object.values(
-        entityReturnValueSchema ?? {},
-      ).some((value) => value === 'object' || value === 'array');
+      // Check for complex return types (object/array), accounting for nullable types
+      // e.g., 'object', 'object | null', 'array | undefined' should all count as complex.
+      // Also detect when functionCallReturnValue has nested child properties — this
+      // proves it's a structured type even if its declared type is still 'unknown'.
+      const returnValueKeys = Object.keys(entityReturnValueSchema ?? {});
+      const complexReturnValue =
+        Object.values(entityReturnValueSchema ?? {}).some((value) => {
+          const baseType = value?.split(' | ')[0];
+          return baseType === 'object' || baseType === 'array';
+        }) ||
+        returnValueKeys.some(
+          (key) =>
+            key.includes('functionCallReturnValue.') ||
+            key.includes('functionCallReturnValue['),
+        );
 
       // Check if this is a validation function that should always be mocked
       const isValidationFn = isValidationFunction(entityName);
@@ -776,14 +958,28 @@ export function determineMockedDependencies(entity: Entity) {
         entityReturnValueSchema,
       );
 
+      // Check if returnValueSchema is completely empty (no traced calls at all)
+      // This indicates a side-effect function that we couldn't trace
+      const returnValueSchemaEmpty =
+        Object.keys(entityReturnValueSchema ?? {}).length === 0;
+
       const entityShouldBeMocked =
         !onlyHasJsxComponents &&
         (isValidationFn ||
           hasChainedCallsWithNoReturn ||
+          // If entity takes no args AND has return value, it reads from external source
+          // Examples: useParams(), useAuth(), getConfig()
+          (emptySignature && hasReturnValue) ||
+          // If entity takes no args AND returnValueSchema is completely empty,
+          // it's a side-effect function calling external services
+          // Examples: logPageView(), initializeAnalytics(), trackEvent()
+          // NOTE: We don't mock entities that have function markers but no return value
+          // (like React components: FileProvider() has 'function' type but no return data)
+          (emptySignature && returnValueSchemaEmpty) ||
           ((signatureHasFunctions || returnValueHasFunctions) &&
             hasReturnValue &&
-            ((emptySignature && hasReturnValue) ||
-              (!complexSignature && complexReturnValue))));
+            !complexSignature &&
+            complexReturnValue));
 
       if (entityShouldBeMocked) {
         mockedEntities.push({