@codeyam/codeyam-cli 0.1.0-staging.15d0f46 → 0.1.0-staging.1669d45

package/analyzer-template/packages/ai/src/lib/astScopes/types.ts

@@ -142,9 +142,108 @@ export interface VariablePath {
   segments: PathSegment[];
 }
 
+/**
+ * Represents the effect of a setter call within a conditional block.
+ * This tracks what state changes occur when specific conditions are met.
+ *
+ * Example: if (data.success) { setShowModal(true); }
+ * - condition: data.success = truthy
+ * - effect: setShowModal called with true
+ */
+export interface ConditionalEffect {
+  /**
+   * Single condition that controls this effect.
+   * Use this for simple if statements with a single condition.
+   */
+  condition?: {
+    /** The path being checked (e.g., "data.success") */
+    path: string;
+    /** Type of condition check */
+    conditionType: 'truthiness' | 'comparison' | 'switch';
+    /** Values being compared against (for comparison/switch) */
+    comparedValues?: string[];
+    /** The value required for this effect to occur */
+    requiredValue: string | boolean;
+  };
+
+  /**
+   * Multiple conditions that all must be true for this effect.
+   * Use this for compound conditions (a && b && c).
+   */
+  conditions?: Array<{
+    /** The path being checked */
+    path: string;
+    /** Type of condition check */
+    conditionType: 'truthiness' | 'comparison' | 'switch';
+    /** Values being compared against */
+    comparedValues?: string[];
+    /** The value required for this condition to be true */
+    requiredValue: string | boolean;
+  }>;
+
+  /**
+   * The effect that occurs when the condition(s) are met.
+   */
+  effect: {
+    /** Type of effect - currently only 'setter' for useState setters */
+    type: 'setter';
+    /** The state variable name (e.g., "showModal" from [showModal, setShowModal]) */
+    stateVariable: string;
+    /** The setter function name (e.g., "setShowModal") */
+    setterName: string;
+    /** The value being set (literal or expression text) */
+    value: string;
+    /** The type of value being set */
+    valueType: 'string' | 'number' | 'boolean' | 'null' | 'dynamic';
+  };
+
+  /**
+   * Source location for this conditional effect
+   */
+  sourceLocation?: {
+    lineNumber: number;
+    column: number;
+    codeSnippet: string;
+  };
+}
+
 /**
  * Results of AST-based scope analysis
  */
+
+/**
+ * Operation types for derived variables.
+ * - notNull/isNull: null checks (x !== null, x === null)
+ * - equals/notEquals: value comparisons (x === 'value', x !== 'value')
+ * - or/and: logical combinations (a || b, a && b)
+ * - arrayIncludes/arraySome/arrayEvery: array predicate methods
+ */
+export type DerivedVariableOperation =
+  | 'notNull'
+  | 'isNull'
+  | 'equals'
+  | 'notEquals'
+  | 'or'
+  | 'and'
+  | 'arrayIncludes'
+  | 'arraySome'
+  | 'arrayEvery';
+
+/**
+ * Information about how a variable was derived from other variables.
+ * Used to trace derived boolean variables back to their data sources.
+ */
+export interface DerivedVariableInfo {
+  /** For single-source derivations (notNull, equals, array predicates, etc.) */
+  sourcePath?: string;
+  /** For multi-source derivations (or, and) */
+  sourcePaths?: string[];
+  /** The operation that derived this variable */
+  operation: DerivedVariableOperation;
+  /** For comparison operations, the value being compared to */
+  comparedValue?: string;
+}
+
 export interface AstScopeAnalysisResult {
   // Variable structure map (variable path -> type)
   structure: Record<string, string>;
@@ -159,6 +258,22 @@ export interface AstScopeAnalysisResult {
   // Maps attribute path to array of conditional usages
   conditionalUsages: Record<string, ConditionalUsage[]>;
 
+  // Compound conditionals grouped by chain (all conditions must be true together)
+  compoundConditionals?: CompoundConditional[];
+
+  // Conditional effects - tracks what setter calls happen inside conditionals
+  // This allows us to determine what data conditions must be true for different state changes
+  conditionalEffects: ConditionalEffect[];
+
+  // Derived variables - variables computed from boolean expressions
+  // Maps variable name to derivation info (e.g., hasAnalysis -> { sourcePath: 'analysis', operation: 'notNull' })
+  derivedVariables?: Record<string, DerivedVariableInfo>;
+
+  // Child boundary gating conditions - tracks which conditions must be true for a child component to render
+  // Maps child component name to array of conditional usages that gate its rendering
+  // Example: {hasAnalysis && <ScenarioViewer />} → { ScenarioViewer: [{ path: 'hasAnalysis', ... }] }
+  childBoundaryGatingConditions?: Record<string, ConditionalUsage[]>;
+
   // Whether the analysis is complete enough to skip LLM calls
   isComplete: boolean;
 
@@ -191,6 +306,89 @@ export interface ConditionalUsage {
    * Where this conditional usage occurs
    */
   location: 'if' | 'ternary' | 'logical-and' | 'switch';
+
+  /**
+   * Source location information for this conditional usage
+   */
+  sourceLocation?: {
+    /** Line number (1-based) */
+    lineNumber: number;
+    /** Column number (0-based) */
+    column: number;
+    /** The code snippet containing this conditional */
+    codeSnippet: string;
+  };
+
+  /** Unique ID for this compound conditional chain (shared by all conditions in same && chain) */
+  chainId?: string;
+  /** Position in the chain (0 = leftmost) */
+  chainPosition?: number;
+  /** Total number of conditions in this chain */
+  chainLength?: number;
+  /** The full original expression (e.g., "a && b && c") */
+  chainExpression?: string;
+  /** Whether this condition is negated (e.g., !foo) */
+  isNegated?: boolean;
+  /**
+   * Whether this conditional controls JSX rendering.
+   * True when the conditional appears in a JSX expression like {cond && <Component />}
+   * or {cond ? <A /> : <B />}. Used to identify high-impact execution flows.
+   */
+  controlsJsxRendering?: boolean;
+
+  /**
+   * Information about how this variable was derived from other variables.
+   * Used to trace derived boolean variables back to their data sources.
+   *
+   * Examples:
+   * - `const hasAnalysis = analysis !== null` → { sourcePath: 'analysis', operation: 'notNull' }
+   * - `const isLoading = status === 'loading'` → { sourcePath: 'status', operation: 'equals', comparedValue: 'loading' }
+   * - `const isBusy = isRunning || isQueued` → { operation: 'or', sourcePaths: ['isRunning', 'isQueued'] }
+   */
+  derivedFrom?: {
+    /** For single-source derivations (notNull, equals, array predicates, etc.) */
+    sourcePath?: string;
+    /** For multi-source derivations (or, and) */
+    sourcePaths?: string[];
+    /** The operation that derived this variable */
+    operation: DerivedVariableOperation;
+    /** For comparison operations, the value being compared to */
+    comparedValue?: string;
+  };
+}
+
+/**
+ * Represents a compound conditional (e.g., a && b && c) where all conditions
+ * must be satisfied together for a code path to execute.
+ */
+export interface CompoundConditional {
+  /** Unique identifier for this compound conditional */
+  chainId: string;
+  /** The full expression (e.g., "scenarios.length > 0 && !displayState.isQueued") */
+  expression: string;
+  /** Individual conditions in order */
+  conditions: {
+    path: string;
+    conditionType: 'truthiness' | 'comparison' | 'switch';
+    comparedValues?: string[];
+    isNegated: boolean;
+    /** Required value for this condition to be true */
+    requiredValue?: string | boolean;
+  }[];
+  /** Where this compound conditional occurs */
+  location: 'if' | 'ternary' | 'logical-and' | 'switch';
+  /** Source location for the entire compound expression */
+  sourceLocation: {
+    lineNumber: number;
+    column: number;
+    codeSnippet: string;
+  };
+  /**
+   * Whether this compound conditional controls JSX rendering.
+   * True when the conditional appears in a JSX expression like {a && b && <Component />}
+   * Used to identify high-impact execution flows.
+   */
+  controlsJsxRendering?: boolean;
 }
 
 /**
@@ -318,7 +516,41 @@ export interface AnalysisContext {
   // Get all conditional usages
   getConditionalUsages(): Record<string, ConditionalUsage[]>;
 
+  // Add a gating condition for a child component
+  // Called when we see patterns like: {hasAnalysis && <ChildComponent />}
+  addChildBoundaryGatingCondition(
+    childComponentName: string,
+    gatingCondition: ConditionalUsage,
+  ): void;
+
+  // Get all child boundary gating conditions
+  getChildBoundaryGatingConditions(): Record<string, ConditionalUsage[]>;
+
+  // Record a derived variable and its source expression
+  // Called when we see patterns like: const hasAnalysis = analysis !== null
+  addDerivedVariable(
+    variableName: string,
+    derivationInfo: {
+      sourcePath?: string;
+      sourcePaths?: string[];
+      operation: DerivedVariableOperation;
+      comparedValue?: string;
+    },
+  ): void;
+
+  // Add a compound conditional for key attribute dependency detection
+  addCompoundConditional(compound: CompoundConditional): void;
+
+  // Get all compound conditionals
+  getCompoundConditionals(): CompoundConditional[];
+
   // Update a schema type, typically used when switch statements reveal
   // the valid values for a parameter (creating a union type)
   updateSchemaType(path: string | StructuredPath, newType: string): void;
+
+  // Add a conditional effect (setter call inside a conditional)
+  addConditionalEffect(effect: ConditionalEffect): void;
+
+  // Get all conditional effects
+  getConditionalEffects(): ConditionalEffect[];
 }

package/analyzer-template/packages/ai/src/lib/checkAllAttributes.ts

@@ -1,25 +1,44 @@
-export default function checkAllAttributes(data: { [key: string]: unknown }) {
-  for (const key of Object.keys(data || {})) {
+export default function checkAllAttributes(
+  data: { [key: string]: unknown } | unknown,
+): unknown {
+  // Handle non-object values (strings, numbers, etc.) - return them as-is
+  if (data === null || data === undefined) {
+    return data;
+  }
+  if (typeof data !== 'object') {
+    return data;
+  }
+  // Handle arrays - recurse into each element
+  if (Array.isArray(data)) {
+    return data.map((item) => checkAllAttributes(item));
+  }
+
+  const obj = data as { [key: string]: unknown };
+  for (const key of Object.keys(obj)) {
     try {
-      if (data[key] === undefined) {
-        delete data[key];
+      if (obj[key] === undefined) {
+        delete obj[key];
         continue;
       }
 
-      if (typeof data[key] === 'object') {
-        checkAllAttributes(data[key] as { [key: string]: unknown });
-      } else if (typeof data[key] === 'string') {
-        data[key] = (data[key] as string).replace(/\n/g, '\\n');
+      if (Array.isArray(obj[key])) {
+        obj[key] = (obj[key] as unknown[]).map((item) =>
+          checkAllAttributes(item),
+        );
+      } else if (typeof obj[key] === 'object' && obj[key] !== null) {
+        checkAllAttributes(obj[key]);
+      } else if (typeof obj[key] === 'string') {
+        obj[key] = (obj[key] as string).replace(/\n/g, '\\n');
       }
     } catch (e) {
       console.error('Error checking all attributes', {
         key,
-        data,
+        data: obj,
         error: e,
       });
       throw e;
     }
   }
 
-  return data;
+  return obj;
 }

package/analyzer-template/packages/ai/src/lib/completionCall.ts

@@ -447,9 +447,25 @@ async function replayLlmCall(
 
     if (!matchingCalls || matchingCalls.length === 0) {
       const availableTypes = Object.keys(callsByType).join(', ');
-      throw new Error(
-        `No captured LLM call found for type '${type}'. Available types: ${availableTypes}`,
+      console.warn(
+        `CodeYam Test: No captured LLM call found for type '${type}'. Available types: ${availableTypes}`,
       );
+      // Return empty response - callers should handle gracefully
+      // This allows new LLM call types to be added without breaking existing fixtures
+      return {
+        finishReason: 'stop',
+        completion: '{}',
+        stats: {
+          model: 'fixture-fallback',
+          prompt_type: type,
+          system_message: '',
+          prompt_text: '',
+          response: '{}',
+          input_tokens: 0,
+          output_tokens: 0,
+          cost: 0,
+        },
+      };
     }
 
     // Track call count per type and cycle through multiple responses