@codeyam/codeyam-cli 0.1.0-staging.15d0f46 → 0.1.0-staging.1669d45

package/analyzer-template/packages/analyze/src/lib/files/scenarios/generateChangesScenarioData.ts

@@ -38,7 +38,7 @@ export default async function generateChangesScenarioData({
   const fullStructure = analysis.metadata.scenariosDataStructure;
   const structure: Analysis['metadata']['scenariosDataStructure'] = {
     arguments: fullStructure.arguments ?? [],
-    dataForMocks: gatherDataForMocks(analysis, dependentAnalyses),
+    dataForMocks: gatherDataForMocks(analysis, dependentAnalyses, entity.name),
   };
 
   for (const key in fullStructure.dataForMocks) {

package/analyzer-template/packages/analyze/src/lib/files/scenarios/generateChangesScenarios.ts

@@ -5,15 +5,11 @@ import {
   Entity,
   DEFAULT_SCENARIO_NAME,
 } from '~codeyam/types';
-import deepEqual from '../../utils/deepEqual';
 import measureAndReportExecutionTime from '../../utils/measureAndReportExecutionTime';
-import {
-  AI,
-  generateChangesEntityScenarios,
-  generateChangesEntityKeyAttributes,
-} from '~codeyam/ai';
+import { AI, generateChangesEntityScenarios } from '~codeyam/ai';
 import { awsLog } from '~codeyam/utils';
 import detectChangedDataStructureFields from './detectChangedDataStructureFields';
+import generateExecutionFlows from './generateExecutionFlows';
 
 export interface GenerateChangesScenariosArgs {
   previousAnalysis: Analysis;
@@ -40,8 +36,8 @@ export default async function generateChangesScenarios({
 
   const existingScenarios = (previousAnalysis.scenarios ?? []).filter(
     (s) =>
-      (error ? s.metadata.error : !s.metadata.error) &&
-      !s.metadata.sameAsDefault,
+      (error ? s.metadata?.error : !s.metadata?.error) &&
+      !s.metadata?.sameAsDefault,
   );
   const commitDiff = commit.files.find(
     (f) => f.fileName === entity.filePath,
@@ -87,8 +83,7 @@ export default async function generateChangesScenarios({
           name: DEFAULT_SCENARIO_NAME,
           description: 'The only external state the component can be in.',
           metadata: {
-            dataMapping: {},
-            keyAttributeInstructions: {},
+            coveredFlows: [],
           },
         },
       ];
@@ -96,53 +91,20 @@ export default async function generateChangesScenarios({
     return;
   }
 
-  // if (!analysis.metadata.keyAttributes) {
-  const existingKeyAttributes = (
-    previousAnalysis.metadata?.keyAttributes ?? []
-  ).filter(
-    (keyAttribute, index, self) =>
-      self.findIndex((ka) => ka.internalPath === keyAttribute.internalPath) ===
-      index,
-  );
-
-  const {
-    result: { keyAttributes, llmCall: keyAttributesLLMCall },
-  } = await measureAndReportExecutionTime(
-    () =>
-      generateChangesEntityKeyAttributes({
-        entity,
-        existingKeyAttributes,
-        analysis,
-        commitDiff,
-        model,
-      }),
-    `Generating changes entity key attributes`,
-    updateProgress,
-  );
-
-  analysis.metadata.keyAttributes = keyAttributes;
-
-  if (keyAttributesLLMCall) {
-    analysis.metadata.llmCalls ||= [];
-    analysis.metadata.llmCalls.push({
-      name: `generateChangesEntityKeyAttributes`,
-      id: keyAttributesLLMCall.id,
+  // Generate execution flows if not already present
+  if (!analysis.metadata.executionFlows) {
+    await generateExecutionFlows({
+      entity,
+      analysis,
+      model,
+      updateProgress,
+      dependentAnalyses,
     });
   }
-  // }
 
-  const addedKeyAttributes = analysis.metadata.keyAttributes?.filter(
-    (ka) =>
-      !previousAnalysis.metadata.keyAttributes?.find(
-        (ka2) => ka.internalPath === ka2.internalPath,
-      ),
-  );
-  const removedKeyAttributes = previousAnalysis.metadata.keyAttributes?.filter(
-    (ka) =>
-      !analysis.metadata.keyAttributes.find(
-        (ka2) => ka.internalPath === ka2.internalPath,
-      ),
-  );
+  // Get previous execution flows for comparison
+  const previousExecutionFlows =
+    previousAnalysis.metadata?.executionFlows ?? [];
 
   // Detect which specific data structure fields changed
   const changedDataStructureFields = detectChangedDataStructureFields(
@@ -156,10 +118,8 @@ export default async function generateChangesScenarios({
     () =>
       generateChangesEntityScenarios({
         entity,
-        keyAttributes: analysis.metadata.keyAttributes,
-        addedKeyAttributes,
-        removedKeyAttributes,
-        dependentAnalyses,
+        executionFlows: analysis.metadata.executionFlows,
+        previousExecutionFlows,
         existingScenarios,
         commitDiff,
         analysis,
@@ -175,10 +135,13 @@ export default async function generateChangesScenarios({
   for (const scenario of scenarios) {
     if (
       scenario.previousVersionId &&
-      !scenario.metadata.revisedFromPreviousVersion
+      !scenario.metadata?.revisedFromPreviousVersion
     ) {
       if (dataStructureChanged) {
-        scenario.metadata.revisedFromPreviousVersion = true;
+        scenario.metadata = {
+          ...scenario.metadata,
+          revisedFromPreviousVersion: true,
+        };
         continue;
       }
 
@@ -186,7 +149,10 @@ export default async function generateChangesScenarios({
         (s) => s.name === scenario.name,
       );
       if (!existingScenarioStatus || existingScenarioStatus.error) {
-        scenario.metadata.revisedFromPreviousVersion = true;
+        scenario.metadata = {
+          ...scenario.metadata,
+          revisedFromPreviousVersion: true,
+        };
       }
     }
   }
@@ -210,7 +176,7 @@ export default async function generateChangesScenarios({
 
     if (analysis.scenarios) {
       for (const existingScenario of analysis.scenarios.filter((s) =>
-        error ? !!s.metadata.error : !s.metadata.error,
+        error ? !!s.metadata?.error : !s.metadata?.error,
       )) {
         const scenarioIndex = scenarios.findIndex(
           (s) => s.name === existingScenario.name,

package/analyzer-template/packages/analyze/src/lib/files/scenarios/generateDataStructure.ts

@@ -9,10 +9,13 @@ import {
   fillInDirectSchemaGapsAndUnknowns,
   deduplicateFunctionSchemas,
   clearAttributesFromMapping,
+  mergeJsonTypeDefinitions,
 } from '~codeyam/ai';
 import mergeInDependentDataStructure from './mergeInDependentDataStructure';
 import { awsLog } from '~codeyam/utils';
 import gatherDataForMocks from './gatherDataForMocks';
+import enrichArrayTypesFromChildSignatures from './enrichArrayTypesFromChildSignatures';
+import enrichUnknownTypesFromSourceEquivalencies from './enrichUnknownTypesFromSourceEquivalencies';
 
 export interface GenerateDataStructureArgs {
   entity: Entity;
@@ -26,7 +29,9 @@ export default function generateDataStructure({
   analysis,
 }: GenerateDataStructureArgs) {
   try {
-    if (!['visual', 'library'].includes(entity.entityType)) return analysis;
+    if (!['visual', 'library'].includes(entity.entityType)) {
+      return analysis;
+    }
 
     awsLog('CodeYam: Generating data structure for', {
       filePath: entity.filePath,
@@ -109,55 +114,6 @@ export default function generateDataStructure({
         const relevantDependencyAnalysis =
           dependentAnalyses[lookupPath]?.[importedExport.name];
 
-        // DEBUG: Track buildBranchFileMap and fileComparisons
-        if (
-          importedExport.name === 'buildBranchFileMap' ||
-          entity.name === 'GitView'
-        ) {
-          console.log('🔍 DEBUG generateDataStructure:', {
-            entityName: entity.name,
-            importedExportName: importedExport.name,
-            lookupPath,
-            hasAnalysis: !!relevantDependencyAnalysis,
-            signatureSchema:
-              relevantDependencyAnalysis?.metadata?.mergedDataStructure
-                ?.signatureSchema,
-            dependencySchemas: relevantDependencyAnalysis?.metadata
-              ?.mergedDataStructure?.dependencySchemas
-              ? Object.keys(
-                  relevantDependencyAnalysis.metadata.mergedDataStructure
-                    .dependencySchemas,
-                )
-              : null,
-          });
-          if (
-            relevantDependencyAnalysis?.metadata?.mergedDataStructure
-              ?.signatureSchema
-          ) {
-            const sig =
-              relevantDependencyAnalysis.metadata.mergedDataStructure
-                .signatureSchema;
-            console.log(
-              '🔍 DEBUG buildBranchFileMap signature keys:',
-              Object.keys(sig),
-            );
-            // Look for fileComparisons in the signature
-            for (const key of Object.keys(sig)) {
-              if (
-                key.includes('fileComparisons') ||
-                key.includes('entityDiff')
-              ) {
-                console.log(
-                  '🔍 DEBUG Found relevant key:',
-                  key,
-                  '=',
-                  JSON.stringify(sig[key], null, 2),
-                );
-              }
-            }
-          }
-        }
-
         if (!relevantDependencyAnalysis) {
           // console.info(
           //   'CodeYam Warn: No relevant dependency analysis found for importedExport',
@@ -207,6 +163,252 @@ export default function generateDataStructure({
         return acc;
       }, {} as ReadonlyAnalysisMap);
 
+    // For non-mocked child components (like visual components), include their mocked
+    // dependencies in allImportedExports. This ensures that when a parent component
+    // renders a child that uses the same hook with different destructure patterns,
+    // both patterns get separate mock data keys.
+    //
+    // Example: DashboardPage uses QuotesTableCompact (child, not mocked).
+    // Both use useFlags hook but destructure different properties:
+    // - DashboardPage: const { enableNewAdminDashboard } = useFlags()
+    // - QuotesTableCompact: const { flagShowReferenceIdOnQuoteTable } = useFlags()
+    // We need mock data keys for BOTH destructure patterns.
+    //
+    // We need to traverse the ENTIRE dependency tree recursively because nested
+    // child components (e.g., QuotesTableCompact inside AdminDashboard inside
+    // DashboardPage) also have mocked dependencies that need mock data keys.
+
+    // Collect child dependency schemas to merge after mergeInDependentDataStructure
+    // This ensures that when we look up schemas for child imports in gatherDataForMocks,
+    // the child's schemas are available in mergedDataStructure.dependencySchemas.
+    type DependencySchemas = NonNullable<
+      Analysis['metadata']['mergedDataStructure']
+    >['dependencySchemas'];
+    const childDependencySchemas: DependencySchemas = {};
+
+    // Helper function to add mocked imports from an entity to allImportedExports
+    const addMockedImportsFromEntity = (childEntity: Entity | undefined) => {
+      if (!childEntity?.metadata) return;
+
+      // Add child's mocked nodeModuleImports
+      const childNodeModuleImports = childEntity.metadata.nodeModuleImports;
+      if (childNodeModuleImports) {
+        for (const moduleName of Object.keys(childNodeModuleImports)) {
+          const moduleImports = childNodeModuleImports[moduleName] || [];
+          for (const imported of moduleImports) {
+            if (!imported.isMocked) continue;
+
+            // Check if this import already exists in allImportedExports
+            const existingImport = allImportedExports.find(
+              (existing) =>
+                existing.filePath === moduleName &&
+                existing.name === imported.name,
+            );
+
+            if (existingImport) {
+              // Merge callVariableNames if the same dependency exists with different patterns
+              if (imported.callVariableNames && imported.calls) {
+                existingImport.calls = existingImport.calls || [];
+                existingImport.callVariableNames =
+                  existingImport.callVariableNames || [];
+
+                // Add each call/variable pair that doesn't already exist
+                for (let i = 0; i < imported.calls.length; i++) {
+                  const call = imported.calls[i];
+                  const varName = imported.callVariableNames[i];
+                  if (!varName) continue;
+
+                  // Check if this specific callVariableName already exists
+                  if (!existingImport.callVariableNames.includes(varName)) {
+                    existingImport.calls.push(call);
+                    existingImport.callVariableNames.push(varName);
+                  }
+                }
+              }
+            } else {
+              // Add new import
+              allImportedExports.push({
+                filePath: moduleName,
+                name: imported.name,
+                isDefault: imported.isDefault,
+                isMocked: imported.isMocked,
+                calls: imported.calls ? [...imported.calls] : undefined,
+                callVariableNames: imported.callVariableNames
+                  ? [...imported.callVariableNames]
+                  : undefined,
+              });
+            }
+          }
+        }
+      }
+
+      // Add child's mocked importedExports
+      const childImportedExports = childEntity.metadata.importedExports;
+      if (childImportedExports) {
+        for (const imported of childImportedExports) {
+          if (!imported.isMocked) continue;
+
+          // Check if this import already exists in allImportedExports
+          const existingImport = allImportedExports.find(
+            (existing) =>
+              existing.filePath === imported.filePath &&
+              existing.name === imported.name,
+          );
+
+          if (existingImport) {
+            // Merge callVariableNames if the same dependency exists with different patterns
+            if (imported.callVariableNames && imported.calls) {
+              existingImport.calls = existingImport.calls || [];
+              existingImport.callVariableNames =
+                existingImport.callVariableNames || [];
+
+              // Add each call/variable pair that doesn't already exist
+              for (let i = 0; i < imported.calls.length; i++) {
+                const call = imported.calls[i];
+                const varName = imported.callVariableNames[i];
+                if (!varName) continue;
+
+                // Check if this specific callVariableName already exists
+                if (!existingImport.callVariableNames.includes(varName)) {
+                  existingImport.calls.push(call);
+                  existingImport.callVariableNames.push(varName);
+                }
+              }
+            }
+          } else {
+            // Add new import
+            allImportedExports.push({
+              filePath: imported.filePath,
+              name: imported.name,
+              isDefault: imported.isDefault,
+              isMocked: imported.isMocked,
+              calls: imported.calls ? [...imported.calls] : undefined,
+              callVariableNames: imported.callVariableNames
+                ? [...imported.callVariableNames]
+                : undefined,
+            });
+          }
+        }
+      }
+    };
+
+    // Recursive function to traverse the dependency tree
+    const processedAnalyses = new Set<string>();
+    const traverseDependencyTree = (analyses: ReadonlyAnalysisMap) => {
+      for (const filePath in analyses) {
+        for (const name in analyses[filePath]) {
+          const analysisKey = `${filePath}:${name}`;
+          if (processedAnalyses.has(analysisKey)) continue;
+          processedAnalyses.add(analysisKey);
+
+          const childAnalysis = analyses[filePath][name];
+          const childEntity = childAnalysis?.entity;
+
+          // Add mocked imports from this child entity
+          addMockedImportsFromEntity(childEntity as Entity | undefined);
+
+          // Recursively process this child's non-mocked children
+          // via their mergedDataStructure's nested dependentAnalyses
+          const childMergedDataStructure =
+            childAnalysis?.metadata?.mergedDataStructure;
+
+          // Collect the child's dependency schemas for merging later.
+          // This ensures schemas for child imports are available in gatherDataForMocks.
+          if (childMergedDataStructure?.dependencySchemas) {
+            for (const schemaFilePath in childMergedDataStructure.dependencySchemas) {
+              for (const schemaName in childMergedDataStructure
+                .dependencySchemas[schemaFilePath]) {
+                childDependencySchemas[schemaFilePath] ||= {};
+                const existingSchema =
+                  childDependencySchemas[schemaFilePath][schemaName];
+                const newSchema =
+                  childMergedDataStructure.dependencySchemas[schemaFilePath][
+                    schemaName
+                  ];
+
+                if (existingSchema) {
+                  // Merge schemas if the same dependency exists from multiple children
+                  childDependencySchemas[schemaFilePath][schemaName] = {
+                    signatureSchema: {
+                      ...existingSchema.signatureSchema,
+                      ...newSchema.signatureSchema,
+                    },
+                    returnValueSchema: mergeJsonTypeDefinitions(
+                      existingSchema.returnValueSchema as Record<
+                        string,
+                        unknown
+                      >,
+                      newSchema.returnValueSchema as Record<string, unknown>,
+                    ) as Record<string, string>,
+                  };
+                } else {
+                  childDependencySchemas[schemaFilePath][schemaName] = {
+                    signatureSchema: { ...newSchema.signatureSchema },
+                    returnValueSchema: { ...newSchema.returnValueSchema },
+                  };
+                }
+              }
+            }
+          }
+
+          // Also collect the child's OWN signatureSchema for enrichment.
+          // This allows enrichArrayTypesFromChildSignatures to find what fields
+          // non-mocked child components expect on their props (e.g., SurveyCard
+          // expecting survey.createdAt, survey.updatedAt, etc.)
+          if (childMergedDataStructure?.signatureSchema) {
+            childDependencySchemas[filePath] ||= {};
+            const existingSchema = childDependencySchemas[filePath][name];
+            if (existingSchema) {
+              childDependencySchemas[filePath][name] = {
+                signatureSchema: {
+                  ...existingSchema.signatureSchema,
+                  ...childMergedDataStructure.signatureSchema,
+                },
+                returnValueSchema: existingSchema.returnValueSchema,
+              };
+            } else {
+              childDependencySchemas[filePath][name] = {
+                signatureSchema: {
+                  ...childMergedDataStructure.signatureSchema,
+                },
+                returnValueSchema: {},
+              };
+            }
+          }
+
+          if (childMergedDataStructure?.dependencySchemas) {
+            // We need to find non-mocked child components in the dependency tree
+            // These would be in the child's importedExports that are NOT mocked
+            const childImportedExports =
+              childEntity?.metadata?.importedExports ?? [];
+            const nonMockedChildDeps: ReadonlyAnalysisMap = {};
+
+            for (const dep of childImportedExports) {
+              if (dep.isMocked) continue;
+              if (dep.entityType !== 'visual') continue;
+
+              // Try to find this dependency in dependentAnalyses
+              const depFilePath = dep.resolvedFilePath ?? dep.filePath;
+              const depName = dep.resolvedName ?? dep.name;
+
+              if (dependentAnalyses[depFilePath]?.[depName]) {
+                nonMockedChildDeps[depFilePath] ||= {};
+                nonMockedChildDeps[depFilePath][depName] =
+                  dependentAnalyses[depFilePath][depName];
+              }
+            }
+
+            if (Object.keys(nonMockedChildDeps).length > 0) {
+              traverseDependencyTree(nonMockedChildDeps);
+            }
+          }
+        }
+      }
+    };
+
+    // Start traversal from direct non-mocked children
+    traverseDependencyTree(nonMockedDependentAnalyses);
+
     // console.info(
     //   'CODEYAM DEBUG: start merge',
     //   JSON.stringify(
@@ -239,42 +441,39 @@ export default function generateDataStructure({
       dependencySchemas: isolatedDataStructure?.dependencySchemas || {},
     });
 
-    // DEBUG: Check merged result for GitView
-    if (entity.name === 'GitView') {
-      console.log(
-        '🔍 DEBUG GitView mergedDataStructure dependency schemas:',
-        Object.keys(mergedDataStructure.dependencySchemas || {}),
-      );
-      for (const filePath of Object.keys(
-        mergedDataStructure.dependencySchemas || {},
-      )) {
-        for (const depName of Object.keys(
-          mergedDataStructure.dependencySchemas[filePath] || {},
-        )) {
-          const depSchema =
-            mergedDataStructure.dependencySchemas[filePath][depName];
-          console.log(
-            `🔍 DEBUG Merged dep ${filePath}/${depName} signature keys:`,
-            Object.keys(depSchema.signatureSchema || {}),
-          );
-          // Look for fileComparisons
-          for (const key of Object.keys(depSchema.signatureSchema || {})) {
-            if (key.includes('fileComparisons') || key.includes('entityDiff')) {
-              console.log(
-                '🔍 DEBUG MERGED Found relevant key:',
-                key,
-                '=',
-                JSON.stringify(depSchema.signatureSchema[key], null, 2),
-              );
-            }
-          }
+    mergedDataStructure.environmentVariables =
+      isolatedDataStructure.environmentVariables || [];
+
+    // Merge collected child dependency schemas into mergedDataStructure.
+    // This ensures that when gatherDataForMocks looks up schemas for child imports,
+    // the child's schemas are available.
+    for (const schemaFilePath in childDependencySchemas) {
+      for (const schemaName in childDependencySchemas[schemaFilePath]) {
+        mergedDataStructure.dependencySchemas[schemaFilePath] ||= {};
+        const existingSchema =
+          mergedDataStructure.dependencySchemas[schemaFilePath][schemaName];
+        const childSchema = childDependencySchemas[schemaFilePath][schemaName];
+
+        if (existingSchema) {
+          // Merge schemas - child schemas add to parent schemas
+          mergedDataStructure.dependencySchemas[schemaFilePath][schemaName] = {
+            signatureSchema: {
+              ...existingSchema.signatureSchema,
+              ...childSchema.signatureSchema,
+            },
+            returnValueSchema: mergeJsonTypeDefinitions(
+              existingSchema.returnValueSchema as Record<string, unknown>,
+              childSchema.returnValueSchema as Record<string, unknown>,
+            ) as Record<string, string>,
+          };
+        } else {
+          // No existing schema - just add the child's schema
+          mergedDataStructure.dependencySchemas[schemaFilePath][schemaName] =
+            childSchema;
         }
       }
     }
 
-    mergedDataStructure.environmentVariables =
-      isolatedDataStructure.environmentVariables || [];
-
     // console.info(
     //   'CODEYAM DEBUG: end merge',
     //   JSON.stringify(
@@ -326,63 +525,30 @@ export default function generateDataStructure({
     analysis.metadata ||= {};
     analysis.metadata.mergedDataStructure = mergedDataStructure;
 
-    const dataForMocks = gatherDataForMocks(
+    // Enrich mocked dependency array types with fields from child component signatures
+    // This ensures that when getSurveysAction returns { data: array }, and SurveyCard
+    // expects survey.updatedAt, the array element type includes updatedAt
+    enrichArrayTypesFromChildSignatures(
       allImportedExports,
       mergedDataStructure.dependencySchemas,
     );
 
-    // DEBUG: Check dataForMocks for GitView
-    if (entity.name === 'GitView') {
-      console.log(
-        '🔍 DEBUG GitView dataForMocks keys:',
-        Object.keys(dataForMocks),
-      );
-      for (const key of Object.keys(dataForMocks)) {
-        if (
-          key.includes('buildBranchFileMap') ||
-          key.includes('fileComparisons') ||
-          key.includes('entityDiff')
-        ) {
-          console.log(
-            '🔍 DEBUG dataForMocks relevant key:',
-            key,
-            '=',
-            JSON.stringify(dataForMocks[key], null, 2),
-          );
-        }
-      }
-    }
-
-    // console.info(
-    //   'CODEYAM DEBUG: dataForMocks',
-    //   JSON.stringify(
-    //     {
-    //       filePath: entity.filePath,
-    //       entityName: entity.name,
-    //       dataForMocks,
-    //     },
-    //     null,
-    //     2,
-    //   ),
-    // );
+    // Enrich mocked dependency unknown types using sourceEquivalencies
+    // When a mocked dependency returns unknown, but that data flows to a child component
+    // with a known type, propagate the type back to the mocked dependency.
+    // This prevents fillInDirectSchemaGapsAndUnknowns from guessing incorrectly
+    // (e.g., 'data' becoming 'number' because pluralize thinks it's plural)
+    enrichUnknownTypesFromSourceEquivalencies(
+      isolatedDataStructure.dependencySchemas || {},
+      mergedDataStructure.dependencySchemas,
+      allImportedExports,
+    );
 
-    // Log union types in signatureSchema before processing
-    const unionTypeEntries = Object.entries(
-      mergedDataStructure.signatureSchema,
-    ).filter(
-      ([_, value]) =>
-        typeof value === 'string' &&
-        value.includes("'") &&
-        value.includes(' | '),
+    const dataForMocks = gatherDataForMocks(
+      allImportedExports,
+      mergedDataStructure.dependencySchemas,
+      { entityName: entity.name },
     );
-    if (unionTypeEntries.length > 0) {
-      console.log(
-        `[UNION-TYPE] generateDataStructure for ${entity.name}: Found union types in signatureSchema:`,
-      );
-      unionTypeEntries.forEach(([key, value]) => {
-        console.log(`[UNION-TYPE]   "${key}": ${value}`);
-      });
-    }
 
     const finalizedArgumentsSchema = fillInDirectSchemaGapsAndUnknowns({
       schema: { ...mergedDataStructure.signatureSchema },