@ckeditor/ckeditor5-table 34.2.0 → 35.1.0

package/lang/translations/vi.po

@@ -150,112 +150,112 @@ msgstr "Căn lề"
 
 msgctxt "The label used by assistive technologies describing a toolbar that allows configuring the horizontal text alignment in a table cell."
 msgid "Horizontal text alignment toolbar"
-msgstr ""
+msgstr "Thanh công cụ căn chỉnh văn bản theo chiều ngang"
 
 msgctxt "The label used by assistive technologies describing a toolbar that allows configuring the vertical text alignment in a table cell."
 msgid "Vertical text alignment toolbar"
-msgstr ""
+msgstr "Thanh công cụ căn chỉnh văn bản theo chiều dọc"
 
 msgctxt "The label used by assistive technologies describing a toolbar that allows configuring the alignment of a table."
 msgid "Table alignment toolbar"
-msgstr ""
+msgstr "Thanh công cụ căn chỉnh bảng"
 
 msgctxt "The label for the border style dropdown when no style is applied to a table or a table cell."
 msgid "None"
-msgstr ""
+msgstr "Không có kiểu nào"
 
 msgctxt "The label for the border style dropdown when the solid border is applied to a table or a table cell."
 msgid "Solid"
-msgstr ""
+msgstr "Dạng nét liền"
 
 msgctxt "The label for the border style dropdown when the dotted border is applied to a table or a table cell."
 msgid "Dotted"
-msgstr ""
+msgstr "Dạng chấm"
 
 msgctxt "The label for the border style dropdown when the dashed border is applied to a table or a table cell."
 msgid "Dashed"
-msgstr ""
+msgstr "Dạng đường đứt nét"
 
 msgctxt "The label for the border style dropdown when the double border is applied to a table or a table cell."
 msgid "Double"
-msgstr ""
+msgstr "Dạng nét đôi"
 
 msgctxt "The label for the border style dropdown when the groove border is applied to a table or a table cell."
 msgid "Groove"
-msgstr ""
+msgstr "Dạng đường rãnh"
 
 msgctxt "The label for the border style dropdown when the ridge border is applied to a table or a table cell."
 msgid "Ridge"
-msgstr ""
+msgstr "Dạng gờ"
 
 msgctxt "The label for the border style dropdown when the inset border is applied to a table or a table cell."
 msgid "Inset"
-msgstr ""
+msgstr "Dạng chìm"
 
 msgctxt "The label for the border style dropdown when the outset border is applied to a table or a table cell."
 msgid "Outset"
-msgstr ""
+msgstr "Dạng nổi"
 
 msgctxt "The label used by assistive technologies describing a button that aligns the table cell text to the left."
 msgid "Align cell text to the left"
-msgstr ""
+msgstr "Căn chỉnh văn bản trong ô về bên trái"
 
 msgctxt "The label used by assistive technologies describing a button that aligns the table cell text to the center."
 msgid "Align cell text to the center"
-msgstr ""
+msgstr "Căn chỉnh văn bản trong ô vào chính giữa"
 
 msgctxt "The label used by assistive technologies describing a button that aligns the table cell text to the right."
 msgid "Align cell text to the right"
-msgstr ""
+msgstr "Căn chỉnh văn bản trong ô về bên phải"
 
 msgctxt "The label used by assistive technologies describing a button that justifies the table cell text."
 msgid "Justify cell text"
-msgstr ""
+msgstr "Căn đều văn bản trong ô"
 
 msgctxt "The label used by assistive technologies describing a button that aligns the table cell text to the top."
 msgid "Align cell text to the top"
-msgstr ""
+msgstr "Căn chỉnh văn bản trong ô lên trên cùng"
 
 msgctxt "The label used by assistive technologies describing a button that aligns the table cell text to the middle."
 msgid "Align cell text to the middle"
-msgstr ""
+msgstr "Căn chỉnh văn bản trong ô vào giữa"
 
 msgctxt "The label used by assistive technologies describing a button that aligns the table cell text to the bottom."
 msgid "Align cell text to the bottom"
-msgstr ""
+msgstr "Căn chỉnh văn bản trong ô xuống dưới cùng"
 
 msgctxt "The label used by assistive technologies describing a button that aligns the table to the left."
 msgid "Align table to the left"
-msgstr ""
+msgstr "Căn chỉnh bảng về phía bên trái"
 
 msgctxt "The label used by assistive technologies describing a button that centers the table."
 msgid "Center table"
-msgstr ""
+msgstr "Căn chỉnh bảng vào chính giữa"
 
 msgctxt "The label used by assistive technologies describing a button that aligns the table to the right."
 msgid "Align table to the right"
-msgstr ""
+msgstr "Căn chỉnh bảng về phía bên phải"
 
 msgctxt "The localized error string that can be displayed next to color (background, border) fields that have an invalid value"
 msgid "The color is invalid. Try \"#FF0000\" or \"rgb(255,0,0)\" or \"red\"."
-msgstr ""
+msgstr "Màu này không hợp lệ. Hãy thử \"#FF0000\" hoặc \"rgb(255,0,0)\" hoặc \"red\"."
 
 msgctxt "The localized error string that can be displayed next to length (padding, border width) fields that have an invalid value."
 msgid "The value is invalid. Try \"10px\" or \"2em\" or simply \"2\"."
-msgstr ""
+msgstr "Giá trị này không hợp lệ. Hãy thử \"10px\" hoặc \"2em\" hoặc chỉ \"2\"."
 
 msgctxt "The label used by assistive technologies describing a button that opens a color picker, where user can choose a configured color for a certain properties (eg.: background color, color, border-color etc.)."
 msgid "Color picker"
-msgstr ""
+msgstr "Bộ chọn màu"
 
 msgctxt "The button label for the table toolbar hiding caption attached to the table."
 msgid "Toggle caption off"
-msgstr ""
+msgstr "Ẩn chú thích"
 
 msgctxt "The button label for the table toolbar showing caption attached to the table."
 msgid "Toggle caption on"
-msgstr ""
+msgstr "Hiện chú thích"
 
 msgctxt "The placeholder text for the table caption displayed when the caption is empty."
 msgid "Enter table caption"
-msgstr ""
+msgstr "Nhập chú thích cho bảng"

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ckeditor/ckeditor5-table",
-  "version": "34.2.0",
+  "version": "35.1.0",
   "description": "Table feature for CKEditor 5.",
   "keywords": [
     "ckeditor",
@@ -12,34 +12,34 @@
   ],
   "main": "src/index.js",
   "dependencies": {
-    "ckeditor5": "^34.2.0",
+    "ckeditor5": "^35.1.0",
     "lodash-es": "^4.17.15"
   },
   "devDependencies": {
-    "@ckeditor/ckeditor5-alignment": "^34.2.0",
-    "@ckeditor/ckeditor5-basic-styles": "^34.2.0",
-    "@ckeditor/ckeditor5-block-quote": "^34.2.0",
-    "@ckeditor/ckeditor5-clipboard": "^34.2.0",
-    "@ckeditor/ckeditor5-core": "^34.2.0",
+    "@ckeditor/ckeditor5-alignment": "^35.1.0",
+    "@ckeditor/ckeditor5-basic-styles": "^35.1.0",
+    "@ckeditor/ckeditor5-block-quote": "^35.1.0",
+    "@ckeditor/ckeditor5-clipboard": "^35.1.0",
+    "@ckeditor/ckeditor5-core": "^35.1.0",
     "@ckeditor/ckeditor5-dev-utils": "^30.0.0",
-    "@ckeditor/ckeditor5-editor-classic": "^34.2.0",
-    "@ckeditor/ckeditor5-engine": "^34.2.0",
-    "@ckeditor/ckeditor5-highlight": "^34.2.0",
-    "@ckeditor/ckeditor5-horizontal-line": "^34.2.0",
-    "@ckeditor/ckeditor5-html-support": "^34.2.0",
-    "@ckeditor/ckeditor5-image": "^34.2.0",
-    "@ckeditor/ckeditor5-indent": "^34.2.0",
-    "@ckeditor/ckeditor5-link": "^34.2.0",
-    "@ckeditor/ckeditor5-list": "^34.2.0",
-    "@ckeditor/ckeditor5-media-embed": "^34.2.0",
-    "@ckeditor/ckeditor5-paragraph": "^34.2.0",
-    "@ckeditor/ckeditor5-theme-lark": "^34.2.0",
-    "@ckeditor/ckeditor5-typing": "^34.2.0",
-    "@ckeditor/ckeditor5-ui": "^34.2.0",
-    "@ckeditor/ckeditor5-undo": "^34.2.0",
-    "@ckeditor/ckeditor5-utils": "^34.2.0",
-    "@ckeditor/ckeditor5-widget": "^34.2.0",
-    "@ckeditor/ckeditor5-source-editing": "^34.2.0",
+    "@ckeditor/ckeditor5-editor-classic": "^35.1.0",
+    "@ckeditor/ckeditor5-engine": "^35.1.0",
+    "@ckeditor/ckeditor5-highlight": "^35.1.0",
+    "@ckeditor/ckeditor5-horizontal-line": "^35.1.0",
+    "@ckeditor/ckeditor5-html-support": "^35.1.0",
+    "@ckeditor/ckeditor5-image": "^35.1.0",
+    "@ckeditor/ckeditor5-indent": "^35.1.0",
+    "@ckeditor/ckeditor5-link": "^35.1.0",
+    "@ckeditor/ckeditor5-list": "^35.1.0",
+    "@ckeditor/ckeditor5-media-embed": "^35.1.0",
+    "@ckeditor/ckeditor5-paragraph": "^35.1.0",
+    "@ckeditor/ckeditor5-theme-lark": "^35.1.0",
+    "@ckeditor/ckeditor5-typing": "^35.1.0",
+    "@ckeditor/ckeditor5-ui": "^35.1.0",
+    "@ckeditor/ckeditor5-undo": "^35.1.0",
+    "@ckeditor/ckeditor5-utils": "^35.1.0",
+    "@ckeditor/ckeditor5-widget": "^35.1.0",
+    "@ckeditor/ckeditor5-source-editing": "^35.1.0",
     "json-diff": "^0.5.4",
     "webpack": "^5.58.1",
     "webpack-cli": "^4.9.0"
@@ -62,7 +62,8 @@
     "src",
     "theme",
     "build",
-    "ckeditor5-metadata.json"
+    "ckeditor5-metadata.json",
+    "CHANGELOG.md"
   ],
   "scripts": {
     "dll:build": "webpack"

package/src/tablecaption/tablecaptionui.js

@@ -63,6 +63,8 @@ export default class TableCaptionUI extends Plugin {
 						writer.addClass( 'table__caption_highlighted', figcaptionElement );
 					} );
 				}
+
+				editor.editing.view.focus();
 			} );
 
 			return view;

package/src/tablecellproperties/ui/tablecellpropertiesview.js

@@ -247,7 +247,7 @@ export default class TableCellPropertiesView extends View {
 		 * A toolbar with buttons that allow changing the horizontal text alignment in a table cell.
 		 *
 		 * @readonly
-		 * @member {module:ui/toolbar/toolbar~ToolbarView}
+		 * @member {module:ui/toolbar/toolbarview~ToolbarView}
 		 */
 		this.horizontalAlignmentToolbar = horizontalAlignmentToolbar;
 
@@ -255,7 +255,7 @@ export default class TableCellPropertiesView extends View {
 		 * A toolbar with buttons that allow changing the vertical text alignment in a table cell.
 		 *
 		 * @readonly
-		 * @member {module:ui/toolbar/toolbar~ToolbarView}
+		 * @member {module:ui/toolbar/toolbarview~ToolbarView}
 		 */
 		this.verticalAlignmentToolbar = verticalAlignmentToolbar;
 

package/src/tablecolumnresize/constants.js

@@ -7,8 +7,6 @@
  * @module table/tablecolumnresize/constants
  */
 
-/* istanbul ignore file */
-
 /**
  * The minimum column width given as a percentage value. Used in situations when the table is not yet rendered, so it is impossible to
  * calculate how many percentage of the table width would be {@link ~COLUMN_MIN_WIDTH_IN_PIXELS minimum column width in pixels}.

package/src/tablecolumnresize/converters.js

@@ -7,35 +7,34 @@
  * @module table/tablecolumnresize/converters
  */
 
-/* istanbul ignore file */
-
-import { getNumberOfColumn } from './utils';
+import { normalizeColumnWidths } from './utils';
 
 /**
  * Returns a helper for converting a view `<colgroup>` and `<col>` elements to the model table `columnWidths` attribute.
  *
  * Only the inline width, provided as a percentage value, in the `<col>` element is taken into account. If there are not enough `<col>`
- * elements matching this condition, the special value 'auto' is returned. It indicates that the width of a column will be automatically
+ * elements matching this condition, the special value `auto` is returned. It indicates that the width of a column will be automatically
  * calculated in the
- * {@link module:table/tablecolumnresize/tablecolumnresizeediting~TableColumnResizeEditing#_setupPostFixer post-fixer}, depending
+ * {@link module:table/tablecolumnresize/tablecolumnresizeediting~TableColumnResizeEditing#_registerPostFixer post-fixer}, depending
  * on the available table space.
  *
- * @param {module:core/editor/editor~Editor} editor The editor instance.
+ * @param {module:core/plugin~Plugin} tableUtilsPlugin The {@link module:table/tableutils~TableUtils} plugin instance.
  * @returns {Function} Conversion helper.
  */
-export function upcastColgroupElement( editor ) {
+export function upcastColgroupElement( tableUtilsPlugin ) {
 	return dispatcher => dispatcher.on( 'element:colgroup', ( evt, data, conversionApi ) => {
-		const modelTable = data.modelCursor.findAncestor( 'table' );
+		const viewColgroupElement = data.viewItem;
 
-		if ( !modelTable ) {
+		if ( !conversionApi.consumable.test( viewColgroupElement, { name: true } ) ) {
 			return;
 		}
 
-		const modelWriter = conversionApi.writer;
-		const viewColgroupElement = data.viewItem;
-		const numberOfColumns = getNumberOfColumn( modelTable, editor );
+		conversionApi.consumable.consume( viewColgroupElement, { name: true } );
 
-		const columnWidthsAttribute = [ ...Array( numberOfColumns ).keys() ]
+		const modelTable = data.modelCursor.findAncestor( 'table' );
+		const numberOfColumns = tableUtilsPlugin.getColumns( modelTable );
+
+		let columnWidths = [ ...Array( numberOfColumns ).keys() ]
 			.map( columnIndex => {
 				const viewChild = viewColgroupElement.getChild( columnIndex );
 
@@ -50,10 +49,13 @@ export function upcastColgroupElement( editor ) {
 				}
 
 				return viewColWidth;
-			} )
-			.join( ',' );
+			} );
+
+		if ( columnWidths.includes( 'auto' ) ) {
+			columnWidths = normalizeColumnWidths( columnWidths ).map( width => width + '%' );
+		}
 
-		modelWriter.setAttribute( 'columnWidths', columnWidthsAttribute, modelTable );
+		conversionApi.writer.setAttribute( 'columnWidths', columnWidths.join( ',' ), modelTable );
 	} );
 }
 
@@ -71,11 +73,14 @@ export function downcastTableColumnWidthsAttribute() {
 			.find( viewChild => viewChild.is( 'element', 'table' ) );
 
 		if ( data.attributeNewValue ) {
-			if ( data.attributeNewValue !== data.attributeOldValue ) {
-				insertColgroupElement( viewWriter, viewTable, data.attributeNewValue );
-			}
+			// If new value is the same as the old, the operation is not applied (see the `writer.setAttributeOnItem()`).
+			// OTOH the model element has the attribute already applied, so we can't compare the values.
+			// Hence we need to just recreate the <colgroup> element every time.
+			insertColgroupElement( viewWriter, viewTable, data.attributeNewValue );
+			viewWriter.addClass( 'ck-table-resized', viewTable );
 		} else {
 			removeColgroupElement( viewWriter, viewTable );
+			viewWriter.removeClass( 'ck-table-resized', viewTable );
 		}
 	} );
 }
@@ -86,7 +91,7 @@ export function downcastTableColumnWidthsAttribute() {
 // @private
 // @param {module:engine/view/downcastwriter~DowncastWriter} viewWriter View writer instance.
 // @param {module:engine/view/element~Element} viewTable View table.
-// @param {String} columnWidthsAttribute Column width attribute from model table.
+// @param {String} columnWidthsAttribute Column widths attribute from model table.
 function insertColgroupElement( viewWriter, viewTable, columnWidthsAttribute ) {
 	const columnWidths = columnWidthsAttribute.split( ',' );
 
@@ -94,10 +99,10 @@ function insertColgroupElement( viewWriter, viewTable, columnWidthsAttribute ) {
 
 	if ( !viewColgroupElement ) {
 		viewColgroupElement = viewWriter.createContainerElement( 'colgroup' );
-	}
-
-	for ( const viewChild of [ ...viewColgroupElement.getChildren() ] ) {
-		viewWriter.remove( viewChild );
+	} else {
+		for ( const viewChild of [ ...viewColgroupElement.getChildren() ] ) {
+			viewWriter.remove( viewChild );
+		}
 	}
 
 	for ( const columnIndex of Array( columnWidths.length ).keys() ) {
@@ -118,9 +123,5 @@ function insertColgroupElement( viewWriter, viewTable, columnWidthsAttribute ) {
 function removeColgroupElement( viewWriter, viewTable ) {
 	const viewColgroupElement = [ ...viewTable.getChildren() ].find( viewElement => viewElement.is( 'element', 'colgroup' ) );
 
-	if ( !viewColgroupElement ) {
-		return;
-	}
-
 	viewWriter.remove( viewColgroupElement );
 }