@cesium/engine 26.0.0 → 26.2.0

package/Source/Scene/SnapFramebuffer.js

@@ -0,0 +1,121 @@
+import BoundingRectangle from "../Core/BoundingRectangle.js";
+import defined from "../Core/defined.js";
+import destroyObject from "../Core/destroyObject.js";
+import PixelFormat from "../Core/PixelFormat.js";
+import FramebufferManager from "../Renderer/FramebufferManager.js";
+import PassState from "../Renderer/PassState.js";
+import PixelDatatype from "../Renderer/PixelDatatype.js";
+
+/**
+ * @private
+ */
+function SnapFramebuffer(context) {
+  const passState = new PassState(context);
+  passState.blendingEnabled = false;
+  passState.scissorTest = {
+    enabled: true,
+    rectangle: new BoundingRectangle(),
+  };
+  passState.viewport = new BoundingRectangle();
+
+  this._context = context;
+  this._fb = new FramebufferManager({
+    depthStencil: true,
+    pixelDatatype: PixelDatatype.FLOAT,
+    pixelFormat: PixelFormat.RGBA,
+  });
+  this._passState = passState;
+}
+
+function getSnapObjectsFromPixels(context, pixels, width, height) {
+  const max = Math.max(width, height);
+  const length = max * max;
+  const halfWidth = Math.floor(width * 0.5);
+  const halfHeight = Math.floor(height * 0.5);
+
+  let x = 0;
+  let y = 0;
+  let dx = 0;
+  let dy = -1;
+
+  const results = [];
+  for (let i = 0; i < length; ++i) {
+    if (
+      -halfWidth <= x &&
+      x <= halfWidth &&
+      -halfHeight <= y &&
+      y <= halfHeight
+    ) {
+      const index = 4 * ((halfHeight - y) * width + x + halfWidth);
+
+      const pickColor = pixels[index];
+      const object = context.getObjectByPickColor(pickColor);
+      if (defined(object)) {
+        results.push({
+          object: object,
+          isEdge: pixels[index + 1] > 0.0,
+          depth: pixels[index + 2],
+          x: x,
+          y: y,
+        });
+      }
+    }
+
+    if (x === y || (x < 0 && -x === y) || (x > 0 && x === 1 - y)) {
+      const temp = dx;
+      dx = -dy;
+      dy = temp;
+    }
+
+    x += dx;
+    y += dy;
+  }
+
+  return results;
+}
+
+SnapFramebuffer.prototype.begin = function (screenSpaceRectangle, viewport) {
+  const context = this._context;
+  const { width, height } = viewport;
+
+  BoundingRectangle.clone(
+    screenSpaceRectangle,
+    this._passState.scissorTest.rectangle,
+  );
+
+  this._fb.update(context, width, height);
+  this._passState.framebuffer = this._fb.framebuffer;
+
+  this._passState.viewport.width = width;
+  this._passState.viewport.height = height;
+
+  return this._passState;
+};
+
+SnapFramebuffer.prototype.end = function (screenSpaceRectangle) {
+  const width = screenSpaceRectangle.width ?? 1.0;
+  const height = screenSpaceRectangle.height ?? 1.0;
+
+  const context = this._context;
+  const pixels = context.readPixels({
+    x: screenSpaceRectangle.x,
+    y: screenSpaceRectangle.y,
+    width: width,
+    height: height,
+    pixelDatatype: PixelDatatype.FLOAT,
+    framebuffer: this._fb.framebuffer,
+  });
+
+  return getSnapObjectsFromPixels(context, pixels, width, height);
+};
+
+SnapFramebuffer.prototype.isDestroyed = function () {
+  return false;
+};
+
+SnapFramebuffer.prototype.destroy = function () {
+  this._fb.destroy();
+  return destroyObject(this);
+};
+
+export default SnapFramebuffer;

package/Source/Scene/Snapping.js

@@ -0,0 +1,184 @@
+import BoundingRectangle from "../Core/BoundingRectangle.js";
+import Cartesian2 from "../Core/Cartesian2.js";
+import Cartesian3 from "../Core/Cartesian3.js";
+import Check from "../Core/Check.js";
+import defined from "../Core/defined.js";
+import oneTimeWarning from "../Core/oneTimeWarning.js";
+import Ray from "../Core/Ray.js";
+import { pickBegin, pickEnd } from "./Picking.js";
+import SnapFramebuffer from "./SnapFramebuffer.js";
+
+/**
+ * Implementation of {@link Scene#snap}: snap-to-geometry picking.
+ *
+ * A snapping pass is an offscreen pick render (it reuses the pick render
+ * machinery via <code>pickBegin</code>/<code>pickEnd</code>) that targets a
+ * dedicated RGBA32F framebuffer instead of the RGBA8 pick framebuffer. Each
+ * pixel carries a fuller payload than a pick color:
+ * <ul>
+ *   <li>R: pick ID (uint32)</li>
+ *   <li>G: isEdge flag (0.0/1.0)</li>
+ *   <li>B: linear eye-space depth (meters)</li>
+ *   <li>A: unused</li>
+ * </ul>
+ * The payload expression is built in PickingPipelineStage (DrawCommand.snapId)
+ * and compiled into a snap-derived shader by
+ * DerivedCommand.createSnapDerivedCommand. Only commands with a
+ * <code>snapId</code> (i.e. Model-pipeline primitives) render during a
+ * snapping pass.
+ *
+ * @namespace Snapping
+ *
+ * @private
+ */
+const Snapping = {};
+
+const scratchRectangle = new BoundingRectangle(0.0, 0.0, 3.0, 3.0);
+const scratchSnapCoord = new Cartesian2();
+const scratchSnapRay = new Ray();
+const scratchSnapOffset = new Cartesian3();
+
+// Radius around the crosshair, in pixels, used to sample the nearest surface
+// (the occluder the cursor is on).
+const SNAP_OCCLUDER_RADIUS_PIXELS = 3.0;
+
+// An edge more than this fraction deeper than that surface is treated as
+// occluded by it (the edge is only visible because it pokes through a gap in a
+// nearer silhouette), so snap doesn't punch through to geometry behind the
+// object the cursor is on.
+const SNAP_OCCLUSION_TOLERANCE = 0.1;
+
+function cursorDist(hit) {
+  return Math.sqrt(hit.x * hit.x + hit.y * hit.y);
+}
+
+function selectBestHit(hits) {
+  // Depth of the nearest surface under the crosshair; edges well behind it are
+  // occluded by the object the cursor is on and must not win.
+  let occluderDepth = Number.POSITIVE_INFINITY;
+  for (const hit of hits) {
+    if (!hit.isEdge && cursorDist(hit) <= SNAP_OCCLUDER_RADIUS_PIXELS) {
+      occluderDepth = Math.min(occluderDepth, hit.depth);
+    }
+  }
+  const maxEdgeDepth = occluderDepth * (1.0 + SNAP_OCCLUSION_TOLERANCE);
+
+  // Edges outrank surfaces, but only edges in front of (or at) the occluder;
+  // otherwise fall back to the closest surface. Within the chosen group the
+  // hit closest to the crosshair wins.
+  const visible = hits.filter(
+    (hit) => !hit.isEdge || hit.depth <= maxEdgeDepth,
+  );
+  const wantEdge = visible.some((hit) => hit.isEdge);
+  const group = visible.filter((hit) => hit.isEdge === wantEdge);
+  return group.reduce((best, hit) =>
+    cursorDist(hit) < cursorDist(best) ? hit : best,
+  );
+}
+
+// Unproject a snap hit's eye-space depth (channel B of the snap framebuffer,
+// written by the snap shader at the edge fragment itself) into a world
+// position.
+function snapHitToWorld(scene, windowPosition, hit) {
+  const coords = scratchSnapCoord;
+  coords.x = windowPosition.x + hit.x;
+  coords.y = windowPosition.y + hit.y;
+
+  const ray = scene.camera.getPickRay(coords, scratchSnapRay);
+  if (!defined(ray)) {
+    return undefined;
+  }
+
+  // hit.depth is perpendicular distance from the camera plane along the view
+  // direction; convert to distance along the (non-axis-aligned) pick ray.
+  const cos = Cartesian3.dot(ray.direction, scene.camera.directionWC);
+  if (cos <= 0.0) {
+    return undefined;
+  }
+  const t = hit.depth / cos;
+
+  const offset = Cartesian3.multiplyByScalar(
+    ray.direction,
+    t,
+    scratchSnapOffset,
+  );
+  return Cartesian3.add(ray.origin, offset, new Cartesian3());
+}
+
+/**
+ * Returns the best snap target in a screen-space region around
+ * <code>windowPosition</code>. See {@link Scene#snap} for the public API.
+ *
+ * @param {Scene} scene
+ * @param {Cartesian2} windowPosition Window coordinates at the center of the search region.
+ * @param {object} [options] Object with the following properties:
+ * @param {number} [options.width=25] Width of the search region in pixels.
+ * @param {number} [options.height=options.width] Height of the search region in pixels.
+ * @returns {SceneSnapResult | undefined}
+ *
+ * @private
+ */
+Snapping.snap = function (scene, windowPosition, options) {
+  //>>includeStart('debug', pragmas.debug);
+  Check.defined("windowPosition", windowPosition);
+  //>>includeEnd('debug');
+
+  const width = options?.width ?? 25;
+  const height = options?.height ?? width;
+
+  const { context, defaultView } = scene;
+
+  // The snap framebuffer is RGBA32F; rendering to it requires float color
+  // attachment support.
+  if (!context.colorBufferFloat) {
+    oneTimeWarning(
+      "snap-color-buffer-float",
+      "Scene.snap requires the EXT_color_buffer_float extension, which is not supported on this platform.",
+    );
+    return undefined;
+  }
+
+  // Created lazily so applications that never snap pay no framebuffer cost.
+  if (!defined(defaultView.snapFramebuffer)) {
+    defaultView.snapFramebuffer = new SnapFramebuffer(context);
+  }
+  const snapFramebuffer = defaultView.snapFramebuffer;
+
+  const drawingBufferRectangle = scratchRectangle;
+  pickBegin(scene, windowPosition, drawingBufferRectangle, width, height, {
+    framebuffer: snapFramebuffer,
+    snap: true,
+  });
+  const hits = snapFramebuffer.end(drawingBufferRectangle);
+  pickEnd(scene);
+
+  if (hits.length === 0) {
+    return undefined;
+  }
+
+  const best = selectBestHit(hits);
+  if (!defined(best)) {
+    return undefined;
+  }
+
+  const position = snapHitToWorld(scene, windowPosition, best);
+  if (!defined(position)) {
+    return undefined;
+  }
+
+  return {
+    object: best.object,
+    isEdge: best.isEdge,
+    position: position,
+    screenPosition: new Cartesian2(
+      windowPosition.x + best.x,
+      windowPosition.y + best.y,
+    ),
+  };
+};
+
+// Exposed for testing.
+Snapping._selectBestHit = selectBestHit;
+Snapping._snapHitToWorld = snapHitToWorld;
+
+export default Snapping;

package/Source/Scene/TerrainFillMesh.js

@@ -823,6 +823,7 @@ function createFillMesh(tileProvider, frameState, tile, vertexArraysToDestroy) {
   GlobeSurfaceTile.initialize(
     tile,
     tileProvider.terrainProvider,
+    tileProvider.vectorProvider,
     tileProvider._imageryLayers,
   );
 
@@ -1243,7 +1244,7 @@ function createFillMesh(tileProvider, frameState, tile, vertexArraysToDestroy) {
 
     indices[indexOut++] = centerIndex;
     indices[indexOut++] = i;
-    indices[indexOut++] = 0;
+    indices[indexOut] = 0;
 
     const westIndicesSouthToNorth = [];
     for (i = southwestIndex; i >= northwestIndex; --i) {
@@ -1800,7 +1801,7 @@ function addEdgeMesh(
   heightRange,
 ) {
   // Handle copying edges across the anti-meridian.
-  let sourceRectangle = edgeTile.rectangle;
+  let sourceRectangle;
   if (tileEdge === TileEdge.EAST && terrainFillMesh.tile.x === 0) {
     sourceRectangle = Rectangle.clone(
       edgeTile.rectangle,

package/Source/Scene/UrlTemplate3DTilesDataProvider.js

@@ -41,7 +41,7 @@ const scratchIntersectionRectangle = new Rectangle();
  * Base provider for URL-template vector sources that are rendered through a
  * runtime-generated 3D Tiles tileset.
  *
- * @private
+ * @experimental This feature is not final and is subject to change without Cesium's standard deprecation policy.
  */
 class UrlTemplate3DTilesDataProvider {
   /**

package/Source/Scene/Vector3DTileContent.js

@@ -402,8 +402,8 @@ function initialize(content, arrayBuffer, byteOffset) {
   byteOffset += sizeOfUint32;
   const polylinePositionByteLength = view.getUint32(byteOffset, true);
   byteOffset += sizeOfUint32;
-  const pointsPositionByteLength = view.getUint32(byteOffset, true);
-  byteOffset += sizeOfUint32;
+  // Ignore pointsPositionByteLength
+  byteOffset += sizeOfUint32; // For pointsPositionByteLength
 
   const featureTableJson = getJsonFromTypedArray(
     uint8Array,
@@ -687,7 +687,6 @@ function initialize(content, arrayBuffer, byteOffset) {
       byteOffset,
       numberOfPoints * 3,
     );
-    byteOffset += pointsPositionByteLength;
     content._points = new Vector3DTilePoints({
       positions: pointPositions,
       batchIds: batchIds.points,

package/Source/Scene/VectorGltf3DTileContent.js

@@ -18,6 +18,7 @@ import createVectorTileBuffersFromModelComponents from "./Model/createVectorTile
 import defined from "../Core/defined.js";
 import destroyObject from "../Core/destroyObject.js";
 import DeveloperError from "../Core/DeveloperError.js";
+import { isHeightReferenceClamp } from "./HeightReference.js";
 
 /** @import BufferPrimitive from "./BufferPrimitive.js"; */
 /** @import BufferPrimitiveCollection from "./BufferPrimitiveCollection.js"; */
@@ -319,6 +320,9 @@ class VectorGltf3DTileContent {
    * @param {FrameState} frameState
    */
   update(_tileset, frameState) {
+    const tileset = this._tileset;
+    const vectorProvider = tileset._scene?.vectorProvider;
+
     if (defined(this._model) && !this._ready) {
       const model = this._model;
       model.modelMatrix = this._tile.computedTransform;
@@ -337,13 +341,24 @@ class VectorGltf3DTileContent {
       scratchTileModelMatrix,
     );
 
+    // Only bake collections selected to render this frame (avoids duplicates).
+    const isSelected =
+      defined(vectorProvider) &&
+      this._tile._selectedFrame === frameState.frameNumber;
+
     for (let i = 0; i < this._collections.length; i++) {
+      const collection = this._collections[i];
       Matrix4.multiplyTransformation(
         scratchTileModelMatrix,
         this._collectionLocalMatrices[i],
-        this._collections[i].modelMatrix,
+        collection.modelMatrix,
       );
-      this._collections[i].update(frameState);
+
+      if (!isHeightReferenceClamp(tileset._heightReference)) {
+        collection.update(frameState);
+      } else if (isSelected) {
+        vectorProvider.markSelected(collection, frameState.frameNumber);
+      }
     }
   }
 
@@ -362,9 +377,14 @@ class VectorGltf3DTileContent {
   }
 
   destroy() {
+    const vectorProvider = this._tileset._scene?.vectorProvider;
+
     this._model?.destroy();
     this._model = undefined;
-    this._collections.forEach((collection) => collection.destroy());
+    for (const collection of this._collections) {
+      vectorProvider?.remove(collection);
+      collection.destroy();
+    }
     this._collections.length = 0;
     return destroyObject(this);
   }

package/Source/Scene/View.js

@@ -11,6 +11,7 @@ import Pass from "../Renderer/Pass.js";
 import PassState from "../Renderer/PassState.js";
 import Camera from "./Camera.js";
 import EdgeFramebuffer from "./EdgeFramebuffer.js";
+import PlanarFillIdFramebuffer from "./PlanarFillIdFramebuffer.js";
 import FrustumCommands from "./FrustumCommands.js";
 import GlobeDepth from "./GlobeDepth.js";
 import GlobeTranslucencyFramebuffer from "./GlobeTranslucencyFramebuffer.js";
@@ -62,9 +63,11 @@ function View(scene, camera, viewport) {
   this.viewport = viewport;
   this.passState = passState;
   this.pickFramebuffer = new PickFramebuffer(context);
+  this.snapFramebuffer = undefined;
   this.pickDepthFramebuffer = new PickDepthFramebuffer();
   this.sceneFramebuffer = new SceneFramebuffer();
   this.edgeFramebuffer = new EdgeFramebuffer();
+  this.planarFillIdFramebuffer = new PlanarFillIdFramebuffer();
   this.globeDepth = globeDepth;
   this.globeTranslucencyFramebuffer = new GlobeTranslucencyFramebuffer();
   this.oit = oit;
@@ -211,15 +214,11 @@ function updateFrustums(view, scene, near, far) {
       curNear = Math.max(near, Math.pow(farToNearRatio, m) * near);
       curFar = Math.min(far, farToNearRatio * curNear);
     }
-    let frustumCommands = frustumCommandsList[m];
-    if (!defined(frustumCommands)) {
-      frustumCommands = frustumCommandsList[m] = new FrustumCommands(
-        curNear,
-        curFar,
-      );
+    if (!defined(frustumCommandsList[m])) {
+      frustumCommandsList[m] = new FrustumCommands(curNear, curFar);
     } else {
-      frustumCommands.near = curNear;
-      frustumCommands.far = curFar;
+      frustumCommandsList[m].near = curNear;
+      frustumCommandsList[m].far = curFar;
     }
   }
 }
@@ -443,11 +442,14 @@ View.prototype.createPotentiallyVisibleSet = function (scene) {
 
 View.prototype.destroy = function () {
   this.pickFramebuffer = this.pickFramebuffer && this.pickFramebuffer.destroy();
+  this.snapFramebuffer = this.snapFramebuffer && this.snapFramebuffer.destroy();
   this.pickDepthFramebuffer =
     this.pickDepthFramebuffer && this.pickDepthFramebuffer.destroy();
   this.sceneFramebuffer =
     this.sceneFramebuffer && this.sceneFramebuffer.destroy();
   this.edgeFramebuffer = this.edgeFramebuffer && this.edgeFramebuffer.destroy();
+  this.planarFillIdFramebuffer =
+    this.planarFillIdFramebuffer && this.planarFillIdFramebuffer.destroy();
   this.globeDepth = this.globeDepth && this.globeDepth.destroy();
   this.oit = this.oit && this.oit.destroy();
   this.translucentTileClassification =

package/Source/Scene/VoxelTraversal.js

@@ -602,7 +602,7 @@ function updateKeyframeNodes(that, frameState) {
         that._primitive.tileFailed.raiseEvent();
         continue;
       }
-      let addNodeIndex = 0;
+      let addNodeIndex;
       if (megatexture.isFull()) {
         // If the megatexture is full, try removing a discardable node with the lowest priority.
         addNodeIndex = keyframeNodesInMegatextureCount - 1 - destroyedCount;

package/Source/Scene/createElevationBandMaterial.js

@@ -202,7 +202,7 @@ function createLayeredEntries(layers) {
   const layeredEntries = preprocess(layers);
 
   let entriesAccumNext = [];
-  let entriesAccumCurr = [];
+  let entriesAccumCurr;
   let i;
 
   function addEntry(height, color) {

package/Source/Scene/findMeshoptExtension.js

@@ -0,0 +1,23 @@
+import defined from "../Core/defined.js";
+
+/**
+ * Returns the meshopt compression extension object, KHR_meshopt_compression or
+ * EXT_meshopt_compression, on a glTF bufferView or buffer. If both are present,
+ * KHR is preferred.
+ * @param {object} gltfObject A glTF bufferView or buffer.
+ * @returns {object|undefined} The meshopt extension object, or undefined.
+ * @private
+ */
+function findMeshoptExtension(gltfObject) {
+  const extensions = gltfObject?.extensions;
+  if (!defined(extensions)) {
+    return undefined;
+  }
+
+  return (
+    extensions["KHR_meshopt_compression"] ??
+    extensions["EXT_meshopt_compression"]
+  );
+}
+
+export default findMeshoptExtension;

package/Source/Scene/renderBufferPointCollection.js

@@ -109,6 +109,8 @@ function renderBufferPointCollection(collection, frameState, renderContext) {
   if (collection._dirtyCount > 0) {
     const { attributeArrays } = renderContext;
 
+    const positionHighArray = attributeArrays.positionHigh;
+    const positionLowArray = attributeArrays.positionLow;
     const pickColorArray = attributeArrays.pickColor;
     const showSizeColorAlphaArray = attributeArrays.showSizeColorAlpha;
     const outlineWidthColorAlphaArray = attributeArrays.outlineWidthColorAlpha;
@@ -125,12 +127,10 @@ function renderBufferPointCollection(collection, frameState, renderContext) {
       if (useFloat64) {
         point.getPosition(cartesian);
         EncodedCartesian3.fromCartesian(cartesian, encodedCartesian);
-        attributeArrays.positionHigh[i * 3] = encodedCartesian.high.x;
-        attributeArrays.positionHigh[i * 3 + 1] = encodedCartesian.high.y;
-        attributeArrays.positionHigh[i * 3 + 2] = encodedCartesian.high.z;
-        attributeArrays.positionLow[i * 3] = encodedCartesian.low.x;
-        attributeArrays.positionLow[i * 3 + 1] = encodedCartesian.low.y;
-        attributeArrays.positionLow[i * 3 + 2] = encodedCartesian.low.z;
+        // @ts-expect-error https://github.com/CesiumGS/cesium/pull/13302
+        Cartesian3.pack(encodedCartesian.high, positionHighArray, i * 3);
+        // @ts-expect-error https://github.com/CesiumGS/cesium/pull/13302
+        Cartesian3.pack(encodedCartesian.low, positionLowArray, i * 3);
       }
 
       point.getMaterial(material);
@@ -150,9 +150,14 @@ function renderBufferPointCollection(collection, frameState, renderContext) {
 
       outlineWidthColorAlphaArray[i * 3] = material.outlineWidth;
       outlineWidthColorAlphaArray[i * 3 + 1] = AttributeCompression.encodeRGB8(
-        material.outlineColor,
+        // When outlineWidth=0, overwrite outlineColor to prevent subpixel bleeding.
+        material.outlineWidth > 0 ? material.outlineColor : material.color,
       );
-      outlineWidthColorAlphaArray[i * 3 + 2] = material.outlineColor.alpha;
+      outlineWidthColorAlphaArray[i * 3 + 2] =
+        // When outlineWidth=0, overwrite outlineAlpha to prevent subpixel bleeding.
+        material.outlineWidth > 0
+          ? material.outlineColor.alpha
+          : material.color.alpha;
 
       point._dirty = false;
     }
@@ -301,8 +306,7 @@ function renderBufferPointCollection(collection, frameState, renderContext) {
 
   frameState.commandList.push(command);
 
-  collection._dirtyCount = 0;
-  collection._dirtyOffset = 0;
+  collection._makeClean();
 
   return renderContext;
 }

package/Source/Scene/renderBufferPolygonCollection.js

@@ -73,7 +73,7 @@ const polygon = new BufferPolygon();
 const material = new BufferPolygonMaterial();
 const pickColor = new Color();
 const cartesian = new Cartesian3();
-const encodedCartesian = new EncodedCartesian3();
+const encodedC = new EncodedCartesian3();
 
 /**
  * @param {BufferPolygonCollection} collection
@@ -118,6 +118,8 @@ function renderBufferPolygonCollection(collection, frameState, renderContext) {
     const { attributeArrays } = renderContext;
     const { _dirtyOffset, _dirtyCount } = collection;
 
+    const positionHighArray = attributeArrays.positionHigh;
+    const positionLowArray = attributeArrays.positionLow;
     const indexArray = renderContext.indexArray;
     const pickColorArray = attributeArrays.pickColor;
     const showColorAlphaArray = attributeArrays.showColorAlpha;
@@ -152,19 +154,13 @@ function renderBufferPolygonCollection(collection, frameState, renderContext) {
       // Update vertex arrays.
       for (let j = 0, jl = polygon.vertexCount; j < jl; j++) {
         if (useFloat64) {
-          // @ts-expect-error TODO(tsd-jsdoc): See https://github.com/CesiumGS/cesium/pull/13302.
+          // @ts-expect-error https://github.com/CesiumGS/cesium/pull/13302
           Cartesian3.fromArray(cartesianArray, j * 3, cartesian);
-          EncodedCartesian3.fromCartesian(cartesian, encodedCartesian);
-
-          attributeArrays.positionHigh[vOffset * 3] = encodedCartesian.high.x;
-          attributeArrays.positionHigh[vOffset * 3 + 1] =
-            encodedCartesian.high.y;
-          attributeArrays.positionHigh[vOffset * 3 + 2] =
-            encodedCartesian.high.z;
-
-          attributeArrays.positionLow[vOffset * 3] = encodedCartesian.low.x;
-          attributeArrays.positionLow[vOffset * 3 + 1] = encodedCartesian.low.y;
-          attributeArrays.positionLow[vOffset * 3 + 2] = encodedCartesian.low.z;
+          EncodedCartesian3.fromCartesian(cartesian, encodedC);
+          // @ts-expect-error https://github.com/CesiumGS/cesium/pull/13302
+          Cartesian3.pack(encodedC.high, positionHighArray, vOffset * 3);
+          // @ts-expect-error https://github.com/CesiumGS/cesium/pull/13302
+          Cartesian3.pack(encodedC.low, positionLowArray, vOffset * 3);
         }
 
         pickColorArray[vOffset * 4] = Color.floatToByte(pickColor.red);
@@ -336,8 +332,7 @@ function renderBufferPolygonCollection(collection, frameState, renderContext) {
 
   frameState.commandList.push(command);
 
-  collection._dirtyCount = 0;
-  collection._dirtyOffset = 0;
+  collection._makeClean();
 
   return renderContext;
 }