@bongos/core 1.24.29 → 1.24.31

package/modules/hall-ui/public/hall-render.js

@@ -22,7 +22,7 @@
   'use strict';
 
   window.OTBHallRender = function createHallRender(ctx) {
-    const { API, RANK_ORDER, api, brandWorld, curLabel, emptyRow, fmtDate, getJSON, loadNextUp, mins, normalizeRank, pct, postJSON, rankLabel, rankWeight, signClasses, toast, usd } = ctx;
+    const { API, RANK_ORDER, api, brandWorld, curLabel, emptyRow, fmtDate, getJSON, mins, normalizeRank, pct, postJSON, rankLabel, rankWeight, signClasses, toast, usd } = ctx;
     const { escapeHtml, $, fmtNum, moduleOn } = window.OTB;
 
   const RANK_UNLOCKS = {
@@ -273,69 +273,40 @@
     return v === 'open' || v === 'invite_only' ? v : 'apply';
   }
 
-  // One landing per door: open → sign in and you're in; invite_only → nothing to
-  // apply for, sign in once invited; apply → the request form.
+  // The signed-out page is one centred card (task: sign-in redesign): the
+  // sign-in button leads in every mode, and the door below it is the only part
+  // that depends on joinability — open → nothing to do, invite_only → nothing
+  // to apply for, apply → the request form, folded behind a disclosure so the
+  // card stays a sign-in screen rather than a form.
   function landingDoorHtml(mode) {
-    const hub = `This is the builders' hub for ${brandWorld()} — where builders claim work, earn ${curLabel()}, and see what they have accomplished.`;
     const admitter = escapeHtml(rankLabel('archon'));
-    const signIn = `<p class="landing__cta"><a class="landing__btn" href="${API}/auth/web/start">Sign in with GitHub</a></p>`;
     if (mode === 'open') {
       return `
-          <p class="landing__lede">${hub} Anyone with a GitHub account can join: sign in and you're in, starting at the newcomer rank.</p>
-          <div class="landing__request" id="landing-request">
-            <h3 class="landing__request-h">New here — sign in to join</h3>
-            <p class="landing__request-lede">No request and no invite needed. Sign in with GitHub, and a step-by-step guide takes you the rest of the way.</p>
-            ${signIn}
-          </div>`;
+          <p class="landing__door" id="landing-request">New here? Signing in creates your account.</p>`;
     }
     if (mode === 'invite_only') {
       return `
-          <p class="landing__lede">${hub} This project is invite-only: the ${admitter} invites each builder, and there is nothing to apply for here.</p>
-          <div class="landing__request" id="landing-request">
-            <h3 class="landing__request-h">Invited? Sign in</h3>
-            <p class="landing__request-lede">If the ${admitter} has invited you, sign in with GitHub and you're in. If not, ask them for an invite — this project doesn't take requests.</p>
-            ${signIn}
-          </div>`;
+          <p class="landing__door" id="landing-request">Invite-only — there is nothing to apply for here.</p>`;
     }
     return `
-          <p class="landing__lede">
-            ${hub} Access is
-            invite-based: an Archon approves each new builder. To begin, request
-            access below.
-          </p>
-
-          <div class="landing__request" id="landing-request">
-            <h3 class="landing__request-h">New here — request access</h3>
-            <p class="landing__request-lede">
-              Leave your GitHub username and an Archon will let you in. No coding
-              needed to start — once you're approved, sign in with GitHub and a
-              step-by-step guide takes you the rest of the way.
-            </p>
-            <form class="landing__form" id="access-request-form" novalidate>
-              <label class="landing__field">
-                <span>GitHub username <span class="landing__req-mark" aria-hidden="true">*</span></span>
-                <input type="text" id="ar-login" name="github_login" autocomplete="username"
-                       placeholder="e.g. octocat" maxlength="40" required>
-              </label>
-              <label class="landing__field">
-                <span>Your name <span class="landing__opt">(optional)</span></span>
-                <input type="text" id="ar-name" name="display_name" autocomplete="name"
-                       placeholder="So the Archon knows who you are" maxlength="100">
-              </label>
-              <label class="landing__field">
-                <span>A word on why <span class="landing__opt">(optional)</span></span>
-                <input type="text" id="ar-note" name="note"
-                       placeholder="How you got here, what you'd build" maxlength="500">
-              </label>
-              <p class="landing__form-hint">
-                No GitHub account yet? Make a free one at
-                <a href="https://github.com/signup" target="_blank" rel="noopener noreferrer">github.com</a>
-                first — your username is all we need.
-              </p>
-              <button type="submit" class="landing__btn landing__btn--request" id="ar-submit">Request access</button>
-              <p class="landing__request-status" id="ar-status" aria-live="polite"></p>
-            </form>
-          </div>`;
+          <details class="landing__disclosure">
+            <summary class="landing__summary">New here? Request access</summary>
+            <div class="landing__request" id="landing-request">
+              <form class="landing__form" id="access-request-form" novalidate>
+                <label class="landing__field">
+                  <span>GitHub username</span>
+                  <input type="text" id="ar-login" name="github_login" autocomplete="username"
+                         placeholder="e.g. octocat" maxlength="40" required>
+                </label>
+                <label class="landing__field">
+                  <span>Why you'd like in <span class="landing__opt">(optional)</span></span>
+                  <input type="text" id="ar-note" name="note" maxlength="500">
+                </label>
+                <button type="submit" class="landing__btn landing__btn--quiet landing__btn--block" id="ar-submit">Request access</button>
+                <p class="landing__request-status" id="ar-status" aria-live="polite"></p>
+              </form>
+            </div>
+          </details>`;
   }
 
   // task 1002835: a karma vote on a peer's ship was a vote on a title alone.
@@ -360,28 +331,39 @@
     }
     return `<span class="acclaim__evidence">${parts.join(' · ')}</span>`;
   }
-  // The RETURNING builder's door (task 1002851). `open` and `invite_only`
-  // already render a real .landing__btn sign-in inside the primary door, so a
-  // second button there would be a third scattered path rather than a clearer
-  // one — those modes keep the prose note alone. Only the `apply` door, whose
-  // primary control is the request FORM, left signing in as a footnote link.
-  // It gets a real button: the request button's geometry so it reads as a
-  // control, a quieter fill so the request path still leads for the strangers
-  // who are most of this page's traffic.
-  function returningDoorHtml(mode) {
-    if (mode !== 'apply') return '';
+  // The sign-in itself — the card's one primary control, in every mode, so a
+  // returning builder never hunts for it below a form (task 1002851's intent).
+  function returningDoorHtml() {
     return `
-          <div class="landing__returning" id="landing-returning">
-            <h3 class="landing__request-h">Already a member?</h3>
-            <p class="landing__request-lede">You've been approved before — sign in and pick up where you left off.</p>
-            <p class="landing__cta"><a class="landing__btn landing__btn--quiet" href="${API}/auth/web/start">Sign in with GitHub</a></p>
-          </div>`;
+          <a class="landing__btn landing__btn--block" id="landing-signin" href="${API}/auth/web/start">
+            <svg class="landing__gh" viewBox="0 0 16 16" width="18" height="18" aria-hidden="true"><path fill="currentColor" d="M8 0C3.58 0 0 3.58 0 8c0 3.54 2.29 6.53 5.47 7.59.4.07.55-.17.55-.38 0-.19-.01-.82-.01-1.49-2.01.37-2.53-.49-2.69-.94-.09-.23-.48-.94-.82-1.13-.28-.15-.68-.52-.01-.53.63-.01 1.08.58 1.23.82.72 1.21 1.87.87 2.33.66.07-.52.28-.87.51-1.07-1.78-.2-3.64-.89-3.64-3.95 0-.87.31-1.59.82-2.15-.08-.2-.36-1.02.08-2.12 0 0 .67-.21 2.2.82.64-.18 1.32-.27 2-.27.68 0 1.36.09 2 .27 1.53-1.04 2.2-.82 2.2-.82.44 1.1.16 1.92.08 2.12.51.56.82 1.27.82 2.15 0 3.07-1.87 3.75-3.65 3.95.29.25.54.73.54 1.48 0 1.07-.01 1.93-.01 2.2 0 .21.15.46.55.38A8.013 8.013 0 0016 8c0-4.42-3.58-8-8-8z"/></svg>
+            Sign in with GitHub
+          </a>`;
+  }
+
+  // The project's mark, as the sidebar draws it: the pack's own logo when it has
+  // one (theme.logo, ADR 0358), otherwise the Cloud Bongos ring-and-moon.
+  function landingLogoHtml() {
+    const b = window.__BRANDING__ || {};
+    const logo = b.theme && b.theme.logo;
+    return logo
+      ? `<img class="landing__logo" src="${escapeHtml(logo)}" alt="" width="56" height="56" decoding="async">`
+      : '<svg class="landing__logo" viewBox="0 0 200 200" aria-hidden="true"><path class="landing__ring" d="M137 31 A78 78 0 1 0 170 66" fill="none" stroke-width="15" stroke-linecap="round"/><circle class="landing__planet" cx="100" cy="100" r="55"/><circle cx="156" cy="46" r="12" fill="#fb9569"/></svg>';
+  }
+
+  // Strip the hall's chrome (rail, top bar, foot) for the signed-out card —
+  // html[data-door="out"], styled in style.css. The test vm has no
+  // documentElement, hence the guard.
+  function markSignedOut() {
+    const root = document.documentElement;
+    if (root && root.dataset) root.dataset.door = 'out';
   }
 
   function renderLanding() {
-    // task 1723: collapse the shell nav to the signed-out minimum (Home + a
-    // Sign-in button). Cosmetic — the server gates every page regardless.
+    // task 1723: collapse the shell nav to the signed-out minimum. Cosmetic —
+    // the server gates every page regardless.
     window.OTBShell?.applyAccess({ authed: false });
+    markSignedOut();
 
     const welcome = $('#welcome-line');
     if (welcome) welcome.textContent = '';
@@ -390,20 +372,12 @@
     if (landing) {
       landing.hidden = false;
       const mode = joinabilityMode();
-      // On the apply door the sign-in is a real button above, so the note keeps
-      // only the privacy sentence — one sign-in path per landing, never two.
-      const signInNote = mode === 'apply'
-        ? ''
-        : `Already a member? <a href="${API}/auth/web/start">Sign in with GitHub</a>. `;
       landing.innerHTML = `
-        <div class="scroll landing">
-          <h2 class="scroll__h">Welcome</h2>
-          ${landingDoorHtml(mode)}
+        <div class="landing">
+          ${landingLogoHtml()}
+          <h2 class="landing__title">${brandWorld()}</h2>
           ${returningDoorHtml(mode)}
-
-          <p class="landing__signin-note">
-            ${signInNote}We store only your GitHub login, avatar, and the work you ship.
-          </p>
+          ${landingDoorHtml(mode)}
         </div>
       `;
       wireAccessRequestForm();
@@ -419,6 +393,7 @@
   // deleted. Say so, and offer the way out: sign out, then sign in again.
   function renderSessionRefused(code) {
     window.OTBShell?.applyAccess({ authed: false });
+    markSignedOut();
     const landing = $('#landing-root');
     if (!landing) return;
     landing.hidden = false;
@@ -427,11 +402,12 @@
       ? `This account has been switched off, so it cannot open the hall. If that is a mistake, ask the ${admitter} to switch it back on.`
       : 'This sign-in is no longer accepted, so the hall cannot open with it.';
     landing.innerHTML = `
-      <div class="scroll landing">
-        <h2 class="scroll__h">You can't get in with this account</h2>
+      <div class="landing">
+        ${landingLogoHtml()}
+        <h2 class="landing__title">You can't get in with this account</h2>
         <p class="landing__request-lede">${why}</p>
         <p class="landing__request-lede">Sign out, then sign in with the GitHub account you use now. A new account needs the ${admitter}'s approval first.</p>
-        <p class="landing__cta"><button type="button" class="landing__btn" id="refused-signout">Sign out</button></p>
+        <button type="button" class="landing__btn landing__btn--block" id="refused-signout">Sign out</button>
       </div>
     `;
     $('#refused-signout')?.addEventListener('click', () => {
@@ -603,14 +579,6 @@
       const el = document.getElementById(id);
       if (el) el.textContent = text;
     };
-    setText('stat-credits', fmtNum(builder.total_credits));
-    setText('stat-karma', fmtNum(karmaTotal));
-    setText('stat-karma-sub', karmaTrendText);
-    const statRank = document.getElementById('stat-rank');
-    if (statRank) statRank.innerHTML = builder.rank ? renderRankBadge(normalizeRank(builder.rank), { tip: false }) : '—';
-    setText('stat-rank-sub', rollPlace ? [`#${rollPlace.place} on the leaderboard`, rolePlaceText(rollPlace)].filter(Boolean).join(' · ') : '');
-    const statsSection = document.getElementById('home-stats');
-    if (statsSection && !ctx.newcomerGated) statsSection.hidden = false;
 
     // task 1003464: the Home card as the mock draws it — an identity LINE and a
     // three-row fact ledger. The mock repeats Credits and the place even though
@@ -635,7 +603,7 @@
           <dl class="home-facts home-facts--grid">
             <div><dt>${escapeHtml(curLabel(true))}</dt><dd>${fmtNum(builder.total_credits)}</dd></div>
             <div><dt>Karma</dt><dd>${fmtNum(karmaTotal)}</dd></div>
-            <div><dt>Shipped</dt><dd id="standing-shipped">${escapeHtml((document.getElementById('stat-shipped') || {}).textContent || '—')}</dd></div>
+            <div><dt>Shipped</dt><dd id="standing-shipped">${shipState.seen ? fmtNum(shipState.total) : '—'}</dd></div>
             <div><dt>Leaderboard place</dt><dd>${place}</dd></div>
           </dl>
           <dl class="home-facts">
@@ -716,39 +684,15 @@
   }
 
   // task 1003464: the greeting IS Home's one h1 (the mock opens with it).
-  // task 1004780: it has no sub-line any more. The version tab under the banner
-  // shows how far the version is and Next up shows the ready work, so a sentence
-  // repeating both was redundant (owner, 2026-10-23).
+  // task 1004780: it has no sub-line any more (owner, 2026-10-23); since task
+  // 1005054 the city under it (home-city.js) is how far the project has come.
   const greetingWord = (hour) => (hour < 12 ? 'Good morning' : (hour < 18 ? 'Good afternoon' : 'Good evening'));
-  // The version the tab is about: the one being built with the most work in it.
-  function currentVersion(progress) {
-    const rows = progress && Array.isArray(progress.progress) ? progress.progress : [];
-    return rows.filter((r) => r && r.status === 'building')
-      .sort((a, b) => (Number(b.total_count) || 0) - (Number(a.total_count) || 0))[0] || null;
-  }
-  // task 1004774: the version tab under the Home banner, drawn as a bar.
-  // Hidden while no version is being built.
-  function renderVersionTab(v) {
-    const tab = document.getElementById('home-version');
-    if (!tab) return;
-    if (!v) { tab.hidden = true; return; }
-    const pct = Math.max(0, Math.min(100, Math.round(Number(v.percent_complete) || 0)));
-    const name = document.getElementById('home-version-name');
-    const fill = document.getElementById('home-version-fill');
-    const pctEl = document.getElementById('home-version-pct');
-    if (name) name.textContent = v.version_id;
-    if (fill) fill.style.width = `${pct}%`;
-    if (pctEl) pctEl.textContent = `${pct}% complete`;
-    tab.setAttribute('aria-label', `${v.version_id} is ${pct} percent complete`);
-    tab.hidden = false;
-  }
   function renderGreeting() {
     const h1 = document.getElementById('hall-h1');
     const builder = ctx.lastMeState && ctx.lastMeState.builder;
     if (h1 && builder) {
       h1.textContent = `${greetingWord(new Date().getHours())}, ${builder.display_name || builder.github_login || 'builder'}`;
     }
-    renderVersionTab(currentVersion(ctx.lastProgressState));
   }
   const ONBOARDING_STAGE_ORDER = [
     'auth_complete',
@@ -1096,28 +1040,9 @@
     const countEl = $('#ships-count');
     const pagerEl = $('#ships-pager');
 
-    // task 1723: Home mirrors — the shipped-count stat tile and the compact
-    // 5-row recent-work table are fed from the same feed. Guarded writes.
-    const statShipped = document.getElementById('stat-shipped');
-    if (statShipped) statShipped.textContent = fmtNum(shipState.total);
-    // task 1004774: the Standing hover card carries the same count.
+    // task 1004774: the Standing hover card carries the shipped count.
     const standingShipped = document.getElementById('standing-shipped');
     if (standingShipped) standingShipped.textContent = fmtNum(shipState.total);
-    const homeRecent = document.querySelector('#home-recent-table tbody');
-    if (homeRecent) {
-      const latest = sortShips(shipState.recent, 'recent').slice(0, HOME_SHIPS_LIMIT);
-      homeRecent.innerHTML = latest.length
-        ? latest.map((s) => `
-          <tr>
-            <td class="ledger__num">#${s.id}</td>
-            <td>${escapeHtml(s.title)}</td>
-            <td class="ledger__drachmae">${fmtNum(window.OTBBranding?.taskCreditValue?.(s) ?? s.credits_reward)}</td>
-            <td class="ledger__date">${fmtDate(s.shipped_at)}</td>
-          </tr>`).join('')
-        : emptyRow(4, 'Nothing shipped yet. Claim a task on the Work board to get started.');
-    }
-    const homeRecentSection = document.getElementById('home-recent');
-    if (homeRecentSection && !ctx.newcomerGated) homeRecentSection.hidden = false;
 
     // The ledger waits for its own fetch (loadShipLedger); until then it keeps its placeholder.
     const all = shipState.all;
@@ -1378,31 +1303,7 @@
     return `#${p.role.place} as ${ROLE_AS[p.role.craft]}`;
   }
 
-  // task 1003459 — the Claim button on each Home "Next up" row, through the
-  // hall's ONE claim action (task 1003458) rather than a third hand-rolled
-  // POST /claims. Lives here, not builders.js, because that file is at the
-  // 1,500-line ratchet (hall-ui/CLAUDE.md: "growth in the page half has to be
-  // paid for; new pure helper → the lib/renderer"). refresh re-fetches the
-  // two-row slice so a claimed task drops out of it immediately.
-  function wireNextUpClaim() {
-    const claimAction = window.OTBClaimAction.makeClaimAction({ postJSON, toast, API, refresh: loadNextUp });
-    $('#home-next-list')?.addEventListener('click', (e) => {
-      const btn = e.target.closest('.next-up__claim');
-      if (!btn || btn.disabled) return;
-      const taskId = btn.dataset.taskId;
-      btn.disabled = true;
-      btn.textContent = '…';
-      claimAction.claim(taskId).then((out) => {
-        // A redirect to sign-in is already navigating away; re-enabling here
-        // would just invite a click that can't land.
-        if (!out.ok && !out.redirected) {
-          btn.disabled = false;
-          btn.textContent = 'Claim';
-        }
-      });
-    });
-  }
 
-    return { acclaimEvidenceHtml, analyticsState, lbState, mountHallWidgets, renderCurveBody, renderGreeting, renderLanding, renderSessionRefused, renderNav, renderOnboarding, renderProfile, renderRecentShips, renderWelcomeCore, HOME_SHIPS_LIMIT, loadShipLedger, populateShipVersionFilter, setRecentShips, shipState, shipsPager, welcomeDismissalKey, wireNextUpClaim };
+    return { acclaimEvidenceHtml, analyticsState, lbState, mountHallWidgets, renderCurveBody, renderGreeting, renderLanding, renderSessionRefused, renderNav, renderOnboarding, renderProfile, renderRecentShips, renderWelcomeCore, HOME_SHIPS_LIMIT, loadShipLedger, populateShipVersionFilter, setRecentShips, shipState, shipsPager, welcomeDismissalKey };
   };
 })();

package/modules/hall-ui/public/hall-widgets.js

@@ -62,29 +62,8 @@
     '<p class="ledger__note" id="onboarding-status" hidden></p>',
     { view: 'home', zone: 'home-banner', labelledby: 'onboarding-h', hiddenByDefault: true });
 
-  // 0c. Quick stats — headline numbers for the Home dashboard (task 1723).
-  // Filled by builders.js: credits + karma + rank from /me (renderProfile),
-  // shipped count once the ships feed settles (renderRecentShips).
-  // task 2169: each tile is a LINK — the stat row doubles as the fastest
-  // navigation on the page (Credits → the economy doc, Shipped/Karma → the
-  // Standing sections that explain them, Rank → the ladder).
-  w('home-stats', 'Overview', 15,
-    '<h2 id="home-stats-h" class="sr-only">Overview</h2>' +
-    '<div class="stat-row" id="home-stats-row">' +
-      '<a class="stat-tile" href="/drachmae"><span class="stat-tile__label" data-currency-label="caps">Credits</span><span class="stat-tile__num" id="stat-credits">—</span></a>' +
-      '<a class="stat-tile" href="#accomplishments-work"><span class="stat-tile__label">Shipped</span><span class="stat-tile__num" id="stat-shipped">—</span><span class="stat-tile__sub" id="stat-shipped-sub"></span></a>' +
-      '<a class="stat-tile" href="#accomplishments-karma"><span class="stat-tile__label">Karma</span><span class="stat-tile__num" id="stat-karma">—</span><span class="stat-tile__sub" id="stat-karma-sub"></span></a>' +
-      '<a class="stat-tile" href="/ranks"><span class="stat-tile__label">Rank</span><span class="stat-tile__num stat-tile__num--badge" id="stat-rank">—</span><span class="stat-tile__sub" id="stat-rank-sub"></span></a>' +
-    '</div>' +
-    // task 1004774: the version tab under the banner — how far the version being
-    // built has come. hall-render.js renderGreeting fills it from the same
-    // progress read as the greeting's sub-line; hidden until there is a version.
-    '<a class="version-tab" id="home-version" href="/roadmap" hidden>' +
-      '<span class="version-tab__name" id="home-version-name"></span>' +
-      '<span class="version-tab__bar" aria-hidden="true"><span class="version-tab__fill" id="home-version-fill"></span></span>' +
-      '<span class="version-tab__pct" id="home-version-pct"></span>' +
-    '</a>',
-    { view: 'home', zone: 'home-stats', sectionClass: 'scroll scroll--bare', labelledby: 'home-stats-h', hiddenByDefault: true });
+  // (task 1005054: the quick-stats strip and the version tab left Home. The
+  //  zone they held, home-stats, is the project city's — home-city.js.)
 
   // (task 1004774: the Standing summary is no longer a Home card. It is the
   // chip at the top right of the page head — index.html #hall-standing — whose
@@ -97,28 +76,8 @@
   // goal-inbox.js owns (#attention-ideas), the single landing place for every
   // actionable item. builders.js still gates the /inbox fetch to Metic+.)
 
-  // 0e. Your work — "what's my next action" + the compact recent table
-  // (task 1723; grown by task 2184). The Next-up slice surfaces the top of the
-  // claimable queue (builders.js loadNextUp fills it; hidden when the feed is
-  // gated or empty), then the 5-row recent-ships table below it.
-  w('home-recent', 'Your work', 28,
-    '<h2 id="home-recent-h" class="scroll__h">Your work</h2>' +
-    // task 1004774: Next up and Recently shipped sit side by side (stacking
-    // again on a phone); when Next up is hidden, shipped takes the full width.
-    '<div class="home-split">' +
-    '<div class="home-split__col" id="home-next" hidden>' +
-      '<h3 class="ginbox__sec-h">Next up — ready to claim</h3>' +
-      '<ul class="next-up" id="home-next-list"></ul>' +
-      '<p class="next-up__foot"><a href="/work" id="home-next-foot">See all ready work →</a></p>' +
-    '</div>' +
-    '<div class="home-split__col">' +
-    '<h3 class="ginbox__sec-h" id="home-recent-subh" hidden>Recently shipped</h3>' +
-    '<table class="ledger" id="home-recent-table"><thead><tr><th>№</th><th>Work</th><th data-currency-label="caps">Credits</th><th>Shipped</th></tr></thead>' +
-    '<tbody><tr><td colspan="4" class="ledger__empty"><span class="hall-loading" role="status">Loading…</span></td></tr></tbody></table>' +
-    '<p class="card-foot"><a href="#accomplishments-work">All your work →</a></p>' +
-    '</div>' +
-    '</div>',
-    { view: 'home', zone: 'home-main', labelledby: 'home-recent-h', hiddenByDefault: true });
+  // (task 1005054: Your work — Next up and Recently shipped — left Home; ready
+  //  work is the Work board's and your history is Accomplishments'.)
 
   // 0f. The founding wall (task 1004424) — everyone who joined while the project was
   // being founded, founder first, each with their mark. Hidden until the founding