@bongos/core 1.24.29 → 1.24.31

package/tests/claim_from_task_and_home.mjs

@@ -86,16 +86,10 @@ await test('task.html\'s cache-bust moved for task.js', () => {
   assert.match(taskHtml, /task\.js\?v=2026-09-28-taskclaim/);
 });
 
-// == Home's "Next up" rows ====================================================
-
-await test('hall-render.js constructs the shared claim action for Home\'s Next-up row', () => {
-  // Lives in hall-render.js, not builders.js: builders.js sits at the
-  // 1,500-line fitness ratchet (hall-ui/CLAUDE.md — growth goes in the
-  // lib/renderer, not the page).
-  assert.match(hallRenderJs, /function wireNextUpClaim\(\)/);
-  assert.match(hallRenderJs, /makeClaimAction\(\{/);
-  assert.match(hallRenderJs, /window\.OTBClaimAction/);
-});
+// == Home ====================================================================
+// task 1005054: Home's "Next up" rows left with the "Your work" card (the project
+// city took its place), so Home carries no claim button and no claim action.
+// Claiming lives on the task page above and on the Work board.
 
 await test('the shared postJSON carries { status, data } — the contract claim-action.js reads', () => {
   const m = buildersJs.match(/async function postJSON\(path, body\) \{[\s\S]*?\n {2}\}/);
@@ -103,46 +97,17 @@ await test('the shared postJSON carries { status, data } — the contract claim-
   assert.match(m[0], /err\.data\s*=/, 'postJSON must set err.data or every refusal here falls through to the generic line');
 });
 
-await test('each Next-up row renders a Claim button carrying its task id', () => {
-  const m = buildersJs.match(/list\.innerHTML = rows\.map\(\(t\) => \{[\s\S]*?\n {6}\}\)\.join\(''\);/);
-  assert.ok(m, 'loadNextUp row template not found');
-  assert.match(m[0], /class="[^"]*next-up__claim[^"]*"/);
-  assert.match(m[0], /data-task-id="\$\{escapeHtml\(String\(t\.id\)\)\}"/);
-});
-
-await test('the Next-up Claim button routes through claimAction.claim, not a raw POST', () => {
-  const m = hallRenderJs.match(/function wireNextUpClaim\(\) \{[\s\S]*?\n {2}\}/);
-  assert.ok(m, 'wireNextUpClaim not found');
-  assert.match(m[0], /\$\('#home-next-list'\)\?\.addEventListener\('click'/);
-  assert.match(m[0], /claimAction\.claim\(taskId\)/);
-});
-
-await test('builders.js wires the Next-up claim action rather than hand-rolling it', () => {
+await test('Home hand-rolls no claim: no POST /claims, no leftover Next-up wiring', () => {
   assert.doesNotMatch(buildersJs, /postJSON\(\s*`\$\{API\}\/claims/);
-  assert.match(buildersJs, /wireNextUpClaim\(\)/, 'builders.js must call the renderer\'s wiring');
+  assert.doesNotMatch(buildersJs + hallRenderJs, /wireNextUpClaim|home-next-list|next-up__claim/);
+  assert.doesNotMatch(indexHtml, /claim-action\.js/, 'Home has no claim button, so it loads no claim action');
 });
 
-await test('the claim wiring landed in the renderer, not back over the 1,500-line ratchet', () => {
-  // Not a second copy of fitness.js's own gate (scripts/bongos/fitness-ratchets.js)
-  // — this is the reason wireNextUpClaim moved to hall-render.js in the first
-  // place (see its own comment): a regression here explains WHY that file grew,
-  // not just THAT some file grew.
+await test('the page halves stay under the 1,500-line ratchet', () => {
   for (const [name, src] of [['builders.js', buildersJs], ['hall-render.js', hallRenderJs]]) {
     const lines = src.split('\n').length;
     assert.ok(lines <= 1500, `${name} is ${lines} lines — over the fitness ratchet`);
   }
 });
 
-await test('index.html loads claim-action.js before builders.js', () => {
-  const shared = indexHtml.indexOf('claim-action.js');
-  const after = indexHtml.indexOf('builders.js?v=');
-  assert.ok(shared > -1, 'index.html must load claim-action.js');
-  assert.ok(after > shared, 'builders.js must load AFTER claim-action.js');
-});
-
-await test('index.html\'s cache-bust moved for builders.js', () => {
-  assert.doesNotMatch(indexHtml, /builders\.js\?v=2026-06-27-r75/, 'the old bust is still there');
-  assert.match(indexHtml, /builders\.js\?v=2026-09-28-nextupclaim/);
-});
-
 summary();

package/tests/hall_board_world.mjs

@@ -303,13 +303,14 @@ test('the system notices are inbox LINES, first in the card, and counted by its
   }
 });
 
-test('the greeting reads /me and the public progress (for the version tab), and builders.js feeds both', () => {
-  assert.match(buildersJs, /getJSON\(`\$\{API\}\/public\/progress`\)/, 'Home fetches the public progress once');
+test('the greeting reads /me only; the version tab and its progress read left Home', () => {
+  // task 1005054: the version tab left with the stats strip, so Home no longer
+  // fetches /public/progress; the project city (home-city.js) draws how far it is.
+  assert.doesNotMatch(buildersJs, /\/public\/progress/, 'Home no longer fetches the public progress');
   assert.doesNotMatch(buildersJs, /getJSON\(`\$\{API\}\/tasks\/claimable`/,
     'no unbounded claimable fetch on Home');
-  assert.match(buildersJs, /get lastProgressState\(\)/, 'the renderer reads progress through a getter, so it cannot freeze at boot');
-  assert.doesNotMatch(buildersJs, /lastClaimableCount/, 'the greeting no longer needs the claimable count (task 1004780)');
-  assert.equal((buildersJs.match(/renderGreeting\(\)/g) || []).length, 2, 'rendered after /me and after progress — each as it lands');
+  assert.doesNotMatch(buildersJs, /lastProgressState|lastClaimableCount/, 'the greeting needs neither the progress nor the claimable count');
+  assert.equal((buildersJs.match(/renderGreeting\(\)/g) || []).length, 1, 'rendered once, as soon as /me answers');
 });
 
 // Boot hall-render.js against a stub DOM and a ctx of getters (the way
@@ -368,16 +369,13 @@ const ME = {
 const LEADERBOARD = [{ github_login: 'a', total_credits: 20000 }, { github_login: 'percy', total_credits: 14441 }, { github_login: 'b', total_credits: 3 }, { github_login: 'c', total_credits: 1 }];
 const PROGRESS = { progress: [{ version_id: 'BONGOS-V1', status: 'building', total_count: 605, percent_complete: 75 }, { version_id: 'V2', status: 'planning', total_count: 9000, percent_complete: 0 }] };
 
-test('RUN: the greeting names the builder, and the version tab carries how far the version is', () => {
+test('RUN: the greeting names the builder, and writes nothing else', () => {
+  // task 1005054: the version tab left Home with the stats strip; how far the
+  // project has come is the city under the greeting (home-city.js).
   const { api, el } = bootHallRender({ me: ME, progress: PROGRESS });
   api.renderGreeting();
   assert.match(el('hall-h1').textContent, /^Good (morning|afternoon|evening), Percy Jackson$/);
-  assert.equal(el('home-version-name').textContent, 'BONGOS-V1', 'the building version, not the bigger planning one');
-  assert.equal(el('home-version-pct').textContent, '75% complete');
-  assert.equal(el('home-version').hidden, false);
-  const none = bootHallRender({ me: ME });
-  none.api.renderGreeting();
-  assert.equal(none.el('home-version').hidden, true, 'no progress yet: no tab');
+  assert.equal(el('home-version').textContent || '', '', 'no version tab is drawn');
 });
 
 test('RUN: the Standing card carries the three facts, the place as "2nd of 4", and no banner', () => {

package/tests/hall_builders_page_pass.mjs

@@ -117,42 +117,33 @@ function renderLandingHtml(joinability) {
   return html();
 }
 
-test('A: the apply door gives signing in a real button, not a footnote link', () => {
+// The sign-in redesign made the sign-in button the card's one primary control
+// in EVERY mode; only the door beneath it depends on joinability.
+const SIGNIN = /class="landing__btn landing__btn--block" id="landing-signin" href="\/api\/bongos\/auth\/web\/start"/;
+const signInCount = (html) => (html.match(/href="\/api\/bongos\/auth\/web\/start"/g) || []).length;
+
+test('A: the apply door leads with sign-in and folds the request form under it', () => {
   const html = renderLandingHtml('apply');
-  assert.match(html, /landing__returning/, 'the apply door renders a returning-builder block');
-  assert.match(
-    html,
-    /class="landing__btn landing__btn--quiet" href="\/api\/bongos\/auth\/web\/start"/,
-    'that block carries a real sign-in control in the quiet fill',
-  );
-  // The whole point of the change: the footnote link is GONE from this door, so
-  // there is exactly one sign-in path and it is the button.
-  assert.ok(
-    !/Already a member\? <a /.test(html),
-    'the apply door no longer repeats sign-in as a prose link under the form',
-  );
-  assert.match(html, /We store only your GitHub login/, 'the privacy sentence survives the note');
-  // Two controls total: request access, and sign in. Not three.
-  assert.equal(countButtons(html), 2, 'the apply door carries the request button and the sign-in button');
+  assert.match(html, SIGNIN, 'sign-in is a real primary button');
+  assert.equal(signInCount(html), 1, 'exactly one sign-in path — never a second prose link');
+  assert.match(html, /<details class="landing__disclosure">[\s\S]*id="access-request-form"/, 'the request form sits behind a disclosure');
+  assert.ok(html.indexOf('landing-signin') < html.indexOf('access-request-form'), 'sign-in comes first');
+  assert.equal(countButtons(html), 2, 'two controls: sign in, and request access');
 });
 
-test('A: the two doors that already had a sign-in button do not grow a second', () => {
+test('A: the open and invite-only doors carry one sign-in control and no form', () => {
   for (const mode of ['open', 'invite_only']) {
     const html = renderLandingHtml(mode);
-    assert.ok(
-      !/landing__returning/.test(html),
-      `the ${mode} door does not add a returning block — its primary door already signs you in`,
-    );
-    assert.equal(countButtons(html), 1, `the ${mode} door carries exactly one sign-in control`);
-    assert.match(html, /Already a member\? <a /, `the ${mode} door keeps its prose note for returning builders`);
+    assert.match(html, SIGNIN, `the ${mode} door signs in with the same button`);
+    assert.equal(signInCount(html), 1, `the ${mode} door has exactly one sign-in path`);
+    assert.ok(!/access-request-form/.test(html), `the ${mode} door has nothing to apply with`);
+    assert.equal(countButtons(html), 1, `the ${mode} door carries exactly one control`);
   }
 });
 
 test('A: an older branding pack with no joinability falls back to the apply door', () => {
-  // joinabilityMode() treats anything but open/invite_only as 'apply', so the
-  // button must follow that fallback — not sit behind a field an older pack
-  // never sent.
-  assert.match(renderLandingHtml(null), /landing__returning/);
+  // joinabilityMode() treats anything but open/invite_only as 'apply'.
+  assert.match(renderLandingHtml(null), /id="access-request-form"/);
 });
 
 test('A: the quiet fill is a defined variant, not an inline colour', () => {

package/tests/hall_home_ships_bounded.mjs

@@ -122,14 +122,15 @@ function loadRender({ view = 'home' } = {}) {
 
 const homePage = (total, firstId = 3000) => ({ ships: [ship(firstId), ship(firstId - 1)], total });
 
-test('Home: the count and the five-row table come from the small page, with no ledger fetch', async () => {
+test('Home: the Standing chip\'s count comes from the small page, with no ledger fetch', async () => {
+  // task 1005054: the Shipped tile and the five-row table left Home with the stats
+  // strip and "Your work"; the small page still feeds the Standing chip's count.
   const { r, el, fetched } = loadRender();
   assert.equal(r.HOME_SHIPS_LIMIT, 5);
   r.setRecentShips(homePage(3000));
   await new Promise((done) => setTimeout(done, 0));
   assert.deepEqual(fetched, [], 'Home never asks for the full history');
-  assert.equal(el('stat-shipped').textContent, '3000', 'the Shipped tile shows the server total, not rows held');
-  assert.match(el('home-recent-table tbody').innerHTML, /#3000[\s\S]*#2999/);
+  assert.equal(el('standing-shipped').textContent, '3000', 'the chip shows the server total, not rows held');
   assert.equal(el('recent-ships tbody').innerHTML, '', 'the ledger is untouched until its view opens');
 });
 

package/tests/hall_loading.mjs

@@ -83,7 +83,7 @@ test('the page loaders step aside by themselves, and never show without :has()',
   assert.match(STYLE, /\.hall-loading--wait, \.hall-loading--zones \{ display: none; \}/);
   assert.match(STYLE, /@supports selector\(:has\(a\)\) \{\s*\.hall-loading--wait:not\(:has\(~ :not\(\[hidden\], script, template, style\)\)\) \{ display: flex; \}\s*\.hall-loading--zones:not\(:has\(~ :not\(\[hidden\]\) > :not\(\[hidden\], script, template, style\)\)\) \{ display: flex; \}\s*\}/);
   // A page whose sections all start [hidden] carries the --wait loader FIRST in its main.
-  for (const page of ['board-room', 'deploy', 'fleet', 'gate', 'government', 'market-watch-settings', 'project-settings', 'sessions']) {
+  for (const page of ['board-room', 'deploy', 'fleet', 'gate', 'government', 'project-settings', 'sessions']) {
     const html = read(`${page}.html`);
     const main = html.slice(html.indexOf('<main id="hall-main">'));
     const first = main.replace(/<main id="hall-main">\s*(<!--[\s\S]*?-->\s*)*/, '');

package/tests/hall_nav.mjs

@@ -321,9 +321,16 @@ test('sidebar groups read by audience, in order', () => {
   // the steering surfaces because that is what it is — the owner's third release gate.
   // 'fleet' (task 1001949) follows it at the metic floor of `provisioning.fleet.manage`:
   // what each hosted project costs is an operator surface, like the rest of this group.
-  // 'market-watch-settings' (task 1004938) is the owner's Market Watch switch and AI cap,
-  // archon like its four routes, and dropped where the market-watch module is off.
-  assert.deepEqual(nav[4].items.map((i) => i.id), ['watch', 'gate', 'sessions', 'project-settings', 'deploy', 'fleet', 'market-watch-settings', 'government']);
+  // 'market-watch-settings' (task 1004938) LEFT the group in task 1005045: the owner saw
+  // "Market Watch" twice and had to guess which was which (owner decision 2026-11-03,
+  // idea 1001310). The settings are an owner-only Settings tab on /market-watch now.
+  assert.deepEqual(nav[4].items.map((i) => i.id), ['watch', 'gate', 'sessions', 'project-settings', 'deploy', 'fleet', 'government']);
+  // task 1005045: and no label is left twice anywhere in the sidebar, so the next pair
+  // fails here instead of in front of the owner.
+  const labels = [...boot().sidebarHtml.matchAll(/<a class="nav-item" [^>]*>[\s\S]*?<span class="nav-item__label">([^<]*)<\/span>/g)].map((m) => m[1]);
+  assert.ok(labels.includes('Market Watch'), 'the labels were actually read');
+  assert.deepEqual(labels.filter((l, i) => labels.indexOf(l) !== i), [], 'every sidebar label is said once');
+  assert.ok(!nav.flatMap((g) => g.items).some((i) => i.href === '/market-watch-settings'), 'no item points at the retired settings page');
 });
 
 test('Economy lives in Docs and points at the reward-schedule page', () => {
@@ -755,7 +762,7 @@ test('no glyph path data reads as an IP address to the release leak scan', () =>
 // block (task 1004713). These drive the real shell and the real gov-positions.js.
 
 const tick = () => new Promise((resolve) => setImmediate(resolve));
-const GOVERNING = ['board-room', 'city', 'watch', 'gate', 'sessions', 'project-settings', 'deploy', 'fleet', 'market-watch-settings', 'government'];
+const GOVERNING = ['board-room', 'city', 'watch', 'gate', 'sessions', 'project-settings', 'deploy', 'fleet', 'government'];
 const lead = (building, title) => ({ kind: 'lead', seat: 'lead:' + building, building, title });
 const block = (held) => ({ held, title: held.length ? held[0].title : null, has_position: held.length > 0 });
 

package/tests/hall_page_gate_map.mjs

@@ -56,10 +56,11 @@ const ORACLE = {
   // settings. Every read behind it is the viewer's own (GET /me, /me/* prefs,
   // /specialities) and requireBuilder, so sign-in is the whole gate.
   '/builders/my-agents': 'requireBuilderPage',
-  // task 1004938: the owner's Market Watch settings. Its read and writes are
-  // owner-only (atom + owner seat) (tests/market_watch_settings.mjs proves the 403s), and the
-  // shell carries no data, so sign-in is the page tier and the routes are the wall.
-  '/builders/market-watch-settings': 'requireBuilderPage',
+  // Gone (task 1005045, owner decision 2026-11-03): the owner's Market Watch settings
+  // (task 1004938) are an owner-only Settings tab on /market-watch now, and the old URL
+  // 302s to /market-watch#settings before any gate runs. A redirect is not a page; the
+  // four settings routes keep their own owner-only wall (tests/market_watch_settings.mjs).
+  '/builders/market-watch-settings': null,
   // task 1004939: the Market Watch home and tracked-item pages. Every member of the
   // project reads them; both reads are requireBuilder, so sign-in is the whole gate.
   '/builders/market-watch': 'requireBuilderPage',
@@ -347,6 +348,8 @@ const GONE_PAGES = {
   // Task 1003444 — the owner deleted the hall's cross-project directory; the hub
   // community page (task 1003363) is its home, and /people redirects to /roster.
   '/builders/people': 'task 1003444 — the hall has no cross-project directory; /people redirects to /roster',
+  // Task 1005045 — one sidebar item for Market Watch: its settings are a tab on the page.
+  '/builders/market-watch-settings': 'task 1005045 — the settings are the Settings tab on /market-watch; the old URL redirects there',
 };
 
 test('a row that is null because the page left the hall serves no page', () => {

package/tests/home_bounded_reads.mjs

@@ -28,7 +28,6 @@ const require = createRequire(import.meta.url);
 const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
 const read = (rel) => fs.readFileSync(path.join(ROOT, rel), 'utf8');
 const BUILDERS_JS = read('modules/hall-ui/public/builders.js');
-const WIDGETS_JS = read('modules/hall-ui/public/hall-widgets.js');
 const ROUTE = read('modules/lifecycle/routes/tasks.js');
 const DB_TASKS = read('modules/lifecycle/db-tasks.js');
 
@@ -48,26 +47,24 @@ await test('no Home read downloads a feed and slices it in the browser', () => {
   // DISPLAYED is fine; narrowing what was FETCHED is the bug, and the two look
   // identical at the call site — which is why this is a test and not a code review.
   const src = noComments(BUILDERS_JS);
-  for (const fn of ['loadNextUp', 'loadTriageInbox']) {
-    const from = src.indexOf(`function ${fn}(`);
-    assert.ok(from > 0, `${fn} must exist`);
-    const body = src.slice(from, src.indexOf('\n  }\n', from));
-    const name = fn;
-    const url = body.match(/\$\{API\}\/[^`'"]+/);
-    assert.ok(url, `${name} must issue a request`);
-    assert.match(url[0], /[?&]limit=\d+/, `${name} must ask the server for its page size`);
-  }
+  const from = src.indexOf('function loadTriageInbox(');
+  assert.ok(from > 0, 'loadTriageInbox must exist');
+  const body = src.slice(from, src.indexOf('\n  }\n', from));
+  const url = body.match(/\$\{API\}\/[^`'"]+/);
+  assert.ok(url, 'loadTriageInbox must issue a request');
+  assert.match(url[0], /[?&]limit=\d+/, 'loadTriageInbox must ask the server for its page size');
 });
 
-await test('the two cards ask for exactly the rows they draw', () => {
-  assert.match(BUILDERS_JS, /\$\{API\}\/tasks\/claimable\?limit=5/, 'Next up draws five rows, level with Recently shipped');
-  assert.match(BUILDERS_JS, /\$\{API\}\/inbox\?limit=5/, 'the triage card draws five');
-  // …and no longer re-slices what came back.
-  const src = noComments(BUILDERS_JS);
-  const from = src.indexOf('function loadNextUp(');
-  const body = src.slice(from, src.indexOf('\n  }\n', from));
-  assert.ok(body.length > 0, 'loadNextUp body found');
-  assert.doesNotMatch(body, /\.slice\(0,\s*2\)/, 'the client-side slice is gone');
+await test('the project city asks for ONE weekly summary, and the Next-up read left with its card', () => {
+  // task 1005054: Home's body is the project city. It draws from one bounded read
+  // the server counts per week (modules/lifecycle/home-city.js), never a task feed;
+  // the Next-up card and its GET /tasks/claimable read left Home with "Your work".
+  const CITY_JS = noComments(read('modules/hall-ui/public/home-city.js'));
+  const reads = [...CITY_JS.matchAll(/api\.request\('GET',\s*`([^`]+)`/g)].map((m) => m[1]);
+  assert.deepEqual(reads, ['${API}/home/city?weeks=${WEEKS}'], 'one read, asked for its window');
+  assert.doesNotMatch(CITY_JS, /\/tasks|claimable|recent-ships/, 'the city never downloads a feed');
+  assert.doesNotMatch(noComments(BUILDERS_JS), /function loadNextUp\(|tasks\/claimable/, 'Home no longer reads the claimable feed');
+  assert.match(BUILDERS_JS, /\$\{API\}\/inbox\?limit=5/, 'the triage card still draws five');
 });
 
 // ---------------------------------------------------------------------------
@@ -153,16 +150,4 @@ await test('the limit is applied AFTER the JS post-filters, not as a SQL LIMIT',
   assert.match(routeBody, /feed\.slice\(0, claimLimit\)/, 'the slice happens on the finished feed');
 });
 
-// ---------------------------------------------------------------------------
-// 4. what the reader sees
-// ---------------------------------------------------------------------------
-
-await test('the foot names the queue the two rows came off', () => {
-  assert.match(WIDGETS_JS, /id="home-next-foot"/, 'the link has an id to write into');
-  assert.match(BUILDERS_JS, /See all \$\{fmtNum\(total\)\} ready work/);
-  // Silent rather than wrong when the count is missing or not larger than what is
-  // shown: "See all 2" under two rows is noise, and a guessed number is worse.
-  assert.match(BUILDERS_JS, /Number\.isFinite\(total\) && total > rows\.length/);
-});
-
 summary();