@bongos/core 1.21.174 → 1.21.176

package/modules/hall-ui/public/blockers.html

@@ -4,14 +4,16 @@
   <meta charset="utf-8">
   <meta name="viewport" content="width=device-width, initial-scale=1">
   <title>Blockers — {{worldName}}</title>
-  <meta name="description" content="What is stuck on the owner right now: open blockers and the work they hold up.">
+  <meta name="description" content="What needs the project owner right now, and the work it holds up.">
   <link rel="icon" href="data:image/svg+xml;utf8,<svg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 32 32'><text x='16' y='24' font-size='24' text-anchor='middle' font-family='sans-serif'>⌂</text></svg>">
   <link rel="preconnect" href="https://fonts.googleapis.com">
   <link rel="preconnect" href="https://fonts.gstatic.com" crossorigin>
   <link rel="stylesheet" href="/builders/style.css?v=2026-07-02-shell1">
+  <link rel="stylesheet" href="/builders/hall-ask.css">
   <!-- task 1003455: the row shape (title + facts) is the oversight family's,
        the same archetype collab/copy-desk/watch/gate already ride. -->
   <link rel="stylesheet" href="/builders/oversight.css">
+  <link rel="stylesheet" href="/builders/blockers.css">
 </head>
 <body data-page="blockers" data-page-title="Blockers">
 
@@ -23,7 +25,6 @@
     <div class="app-content">
       <div class="page-head page-head--board">
         <h1 class="page-head__h">Blockers</h1>
-        <p class="page-head__sub" id="blockers-sub">A credential, a purchase, a product call, etc. gated at the owner level. Any tasks awaiting the same block will unblock automatically on resolution.</p>
       </div>
 
       <main id="hall-main">
@@ -33,7 +34,7 @@
              builder) below the heading, and per-row Resolve/Link (blocker.review
              — metic+archon) rendered by blockers.js when the viewer holds it. -->
         <section class="scroll" id="blockers-scroll" aria-labelledby="blockers-h">
-          <h2 id="blockers-h" class="scroll__h">Open blockers<span class="count-pill" id="blockers-count" hidden></span></h2>
+          <h2 id="blockers-h" class="scroll__h">Requires project owner fix<span class="count-pill" id="blockers-count" hidden></span></h2>
           <div id="blockers-file-area"></div>
           <div id="blockers-body">
             <p class="profile__placeholder">Loading…</p>
@@ -52,7 +53,7 @@
      chrome exists before the page script runs. -->
 <script src="/builders/shell-trail.js?v=2026-10-08-city-tab"></script>
 <script src="/builders/craft-mode.js?v=2026-10-09-living3"></script>
-<script src="/builders/shell.js?v=2026-10-18-core-move1"></script>
+<script src="/builders/shell.js?v=2026-10-25-logo1"></script>
 <!-- jump palette (Ctrl/Cmd-K). Optional by design: without it the shell's slot stays hidden. -->
 <script src="/builders/palette.js" defer></script>
 <!-- shared frontend toolkit (window.OTB — rank labels, number formats) + the
@@ -65,6 +66,7 @@
      for the "blocking N tasks" facts line, but not the overlay's own render. -->
 <script src="/builders/task-detail.js?v=2026-07-03-taskdetail"></script>
 <script src="/builders/blockers-lib.js"></script>
+<script src="/builders/hall-ask.js"></script>
 <script src="/builders/blockers.js"></script>
 </body>
 </html>

package/modules/hall-ui/public/blockers.js

@@ -52,10 +52,6 @@
   var API = '/api/bongos';
   var body = document.getElementById('blockers-body');
   var countPill = document.getElementById('blockers-count');
-  var sub = document.getElementById('blockers-sub');
-  // The reason-for-blockers prose lives ONLY in blockers.html; JS restores what
-  // the markup shipped instead of carrying a second copy that can drift.
-  var baseSub = sub ? sub.textContent : '';
   var fileArea = document.getElementById('blockers-file-area');
 
   // The generated typed client (task-detail.js's own pattern), result-mode so
@@ -92,7 +88,7 @@
   // blocker.review floor, so it gets the specific message rather than
   // whatever (or nothing) the server's envelope happened to say.
   function reviewerRefusalMessage(err, fallback) {
-    if (err && err.status === 403) return 'You need Metic+ access to do that.';
+    if (err && err.status === 403) return 'You can’t resolve or link blockers here.';
     return refusalMessage(err, fallback);
   }
 
@@ -101,11 +97,14 @@
   };
   var blockerHref = function (id) { return '#/blocker/' + encodeURIComponent(id); };
 
-  // Which rank a reviewer action (Resolve / Link) needs — mirrors the server's
-  // blocker.review floor (metic+archon), cosmetically only; the server holds
-  // the actual gate regardless of what this variable says.
-  var viewer = { rank: null };
-  var isReviewer = function () { return viewer.rank === 'metic' || viewer.rank === 'archon'; };
+  // Who may Resolve / Link — the server's own gate is requirePermission(
+  // 'blocker.review'), which a project's government can grant below Metic or
+  // withhold above it, so the page reads the SAME atom off /me.permissions
+  // (task 1004824) rather than guessing from rank. Cosmetic only: the routes
+  // hold the wall. A missing or unreadable map hides the controls (null is
+  // "authority could not be established", never "holds everything").
+  var viewer = { mayReview: false };
+  var isReviewer = function () { return viewer.mayReview === true; };
 
   // Which row (if any) has an inline action form open, and which form.
   // { id, mode: 'resolve' | 'link' } | null — a row's OWN form, not a global
@@ -142,6 +141,21 @@
           + '<button type="submit" class="td-btn td-btn--primary" data-submit>Link</button>'
           + '<button type="button" class="td-btn" data-row-cancel>Cancel</button>'
           + '</div><p class="td-action-note" data-err></p></form></div>';
+      } else if (window.OTBAsk) {
+        // task 1004820: a closed row a reviewer can act on is the city's ask card
+        // — for the one real decision, resolving it. Linking a task is
+        // bookkeeping, so it stays a plain control beside the facts (owner
+        // 2026-10-23: a card only where the page asks the reader to decide).
+        return window.OTBAsk.html({
+          attrs: { 'data-id': id },
+          q: b.title || ('Blocker ' + id), qHref: blockerHref(id),
+          saidHtml: facts.noteHtml + '<div class="ov-row__facts blockers-facts">' + facts.factsHtml
+            + '<button type="button" class="btn-ghost blockers-facts__link" data-link-open="' + kit.esc(id) + '">Link a task</button></div>',
+          row: true,
+          opts: [
+            { label: 'Resolve it', result: 'Say what settled it', rec: true, attrs: { 'data-resolve-open': id } },
+          ],
+        });
       } else {
         right = '<div class="ov-row__right"><div class="ov-row__actions">'
           + '<button type="button" class="btn-ghost" data-resolve-open="' + kit.esc(id) + '">Resolve</button>'
@@ -184,7 +198,7 @@
   // flight at once; only the newest may paint (the profile activity-log idiom).
   var inFlight = 0;
   // The rows currently on screen — kept ONLY so a purely local state change
-  // (a row's action form opening/closing, the viewer's rank arriving) can
+  // (a row's action form opening/closing, the viewer's permission arriving) can
   // repaint without asking the server again. Never sliced or paged from here.
   var lastRows = [];
 
@@ -207,9 +221,6 @@
 
   function paintHeadline() {
     if (countPill) { countPill.textContent = String(state.total); countPill.hidden = state.total === 0; }
-    if (sub) {
-      sub.textContent = state.total ? baseSub : 'Nothing is stuck on the owner right now.';
-    }
   }
 
   function renderList(rows) {
@@ -217,12 +228,12 @@
     if (!listEl) return;
     listEl.innerHTML = rows.length
       ? rows.map(rowHtml).join('')
-      : kit.emptyStateHtml('Nothing is stuck on the owner right now.');
+      : kit.emptyStateHtml('Nothing needs the project owner right now.');
   }
 
   // Repaint the rows already on screen — no server call. Used when only local
   // UI state changed (a row's Resolve/Link form opened or closed, or the
-  // viewer's rank just arrived and rowHtml() needs to reconsider isReviewer()).
+  // viewer's permission just arrived and rowHtml() needs to reconsider isReviewer()).
   function rerender() { renderList(lastRows); }
 
   // Fetch the page the pager currently points at. `reclamped` guards against a
@@ -268,7 +279,7 @@
         pager.page = state.page;
         pager.perPage = state.perPage;
         if (!painted) {
-          notice('Couldn’t load the blocker queue right now.');
+          notice('Couldn’t load the blockers right now.');
           return;
         }
         renderPager();
@@ -300,13 +311,13 @@
 
   function fileFormHtml() {
     return '<div class="td-actions" id="blockers-file-toggle">'
-      + '<button type="button" class="btn-ghost" id="blockers-file-open">+ File blocker</button>'
+      + '<button type="button" class="btn-ghost" id="blockers-file-open">File a blocker</button>'
       + '</div>'
       + '<form class="td-form" id="blockers-file-form" hidden>'
       + '<label class="td-field td-field--wide"><span>Title</span>'
-      + '<input type="text" id="bf-title" maxlength="200" required placeholder="what needs the owner’s decision"></label>'
-      + '<label class="td-field td-field--wide"><span>What’s stuck (optional)</span>'
-      + '<input type="text" id="bf-note" maxlength="2000" placeholder="a sentence of context"></label>'
+      + '<input type="text" id="bf-title" maxlength="200" required placeholder="What the owner needs to settle"></label>'
+      + '<label class="td-field td-field--wide"><span>More detail (optional)</span>'
+      + '<input type="text" id="bf-note" maxlength="2000" placeholder="One sentence"></label>'
       + '<label class="td-field"><span>Blocking task # (optional)</span>'
       + '<input type="number" id="bf-task-id" min="1" placeholder="e.g. 1002980"></label>'
       + '<div class="td-actions">'
@@ -317,7 +328,7 @@
       // touches: filing succeeds regardless, but linking needs blocker.review,
       // and a viewer below it is told so BEFORE they submit — not left to
       // discover it from a refusal.
-      + (isReviewer() ? '' : '<p class="td-form-hint">Filing is open to anyone. Linking to a task needs Metic+ — if you name one and aren’t, the blocker still files and a Metic+ can link it.</p>')
+      + (isReviewer() ? '' : '<p class="td-form-hint">Anyone can file. If you can’t link tasks, it still files and a reviewer links it.</p>')
       + '</form>';
   }
 
@@ -365,7 +376,7 @@
           } catch (linkErr) {
             // Honest copy, not a silent no-op: the filing DID succeed, and the
             // reader is told exactly what still needs a Metic+.
-            toast('Blocker #' + blocker.id + ' filed. ' + reviewerRefusalMessage(linkErr, 'Could not link it to task #' + taskId + ' — a Metic+ can do that from this page.'));
+            toast('Blocker #' + blocker.id + ' filed. ' + reviewerRefusalMessage(linkErr, 'Could not link it to task #' + taskId + ' — a reviewer can link it from this page.'));
           }
         } else if (blocker) {
           toast('Blocker #' + blocker.id + ' filed.');
@@ -429,10 +440,11 @@
   async function loadViewer() {
     try {
       var res = await api.request('GET', API + '/me');
-      if (res.ok && res.data && res.data.builder) {
-        viewer = { rank: String(res.data.builder.rank || '').toLowerCase() };
+      var perms = res.ok && res.data ? res.data.permissions : null;
+      if (perms && typeof perms === 'object') {
+        viewer = { mayReview: perms['blocker.review'] === true };
       }
-    } catch (_) { /* signed out or offline — viewer stays { rank: null }, isReviewer() false */ }
+    } catch (_) { /* signed out or offline — viewer stays { mayReview: false }, isReviewer() false */ }
   }
 
   mountShell();
@@ -444,7 +456,7 @@
     // isReviewer() at RENDER time. If the queue rendered first (the common
     // case — /me is Metic+-gated work the server does more of), it rendered
     // with isReviewer() still false and nothing re-draws it once the real
-    // rank lands — a Metic/Archon would see no Resolve/Link buttons until an
+    // permission lands — a reviewer would see no Resolve/Link buttons until an
     // unrelated re-render (a pager click, a file, an otb:blocker-resolved).
     // Re-render now that the viewer is known, but only if a page has actually
     // painted yet (fetchPage may still be in flight — it will render

package/modules/hall-ui/public/board-room.css

@@ -60,19 +60,12 @@
 .gov-board__divider { margin: var(--sp-md) 0 var(--sp-sm); }
 
 /* ---- the ballot controls ------------------------------------------------------ */
-/* The two ballot controls sit on one row; the objection disclosure takes the
-   whole row only once it is open, so its form drops under both buttons. */
-.gov-vote { display: flex; flex-wrap: wrap; align-items: flex-start; gap: 10px; }
-.gov-vote > .gov-grid-note { flex: 1 1 100%; margin: 0; }
-.gov-vote__no { flex: 0 1 auto; }
-.gov-vote__no[open] { flex: 1 1 100%; }
-/* The disclosure IS the secondary button, so its marker must go — otherwise the
-   triangle sits inside the pill. */
-.gov-vote__no > summary { display: inline-flex; cursor: pointer; }
-.gov-vote__no > summary::marker { content: ''; }
-.gov-vote__no > summary::-webkit-details-marker { display: none; }
-.gov-vote__no > *:not(summary) { margin-top: 10px; }
+/* task 1004825: the vote is the shared ask card (hall-ask.css); "Object"
+   opens the reason form under it. */
+.gov-vote__no { margin-top: 12px; }
+.gov-vote__no > * + * { margin-top: 10px; }
 .gov-vote__no textarea { display: block; width: 100%; max-width: var(--measure); box-sizing: border-box; }
 .gov-vote__sections { display: flex; flex-wrap: wrap; gap: 6px 16px; }
 .gov-vote__section { display: inline-flex; align-items: center; gap: 8px; min-height: 24px; font-size: 13px; color: var(--ink); cursor: pointer; }
 .gov-vote__section input { width: 16px; height: 16px; margin: 0; }
+

package/modules/hall-ui/public/board-room.html

@@ -9,6 +9,7 @@
   <link rel="preconnect" href="https://fonts.googleapis.com">
   <link rel="preconnect" href="https://fonts.gstatic.com" crossorigin>
   <link rel="stylesheet" href="/builders/style.css?v=2026-07-02-shell1">
+  <link rel="stylesheet" href="/builders/hall-ask.css">
   <link rel="stylesheet" href="/builders/oversight.css">
   <!-- The room's own sheet: the sitting card and the ballot controls moved here
        out of government.css with the room (ADR 0266), so neither page carries the
@@ -24,12 +25,10 @@
   <div class="app-body">
     <header class="app-topbar" id="app-topbar"></header>
     <div class="app-content">
-      <!-- The board page head (task 1003307): the LABEL voice, not a display
-           line, because on a working surface the page's own name is the least
-           interesting thing on it. -->
+      <!-- No top block (task 1004836): the head is hidden and carries only the
+           page's one <h1> for screen readers; its sub-line went in task 1004825. -->
       <div class="page-head page-head--board">
         <h1 class="page-head__h">Board Room</h1>
-        <p class="page-head__sub" id="board-sub">Loading…</p>
       </div>
 
       <main id="hall-main">
@@ -48,7 +47,6 @@
              ground: the lede sits over the sittings, each of which is a .scroll.
              The <h1> above is the room's name, so there is no second heading. -->
         <section id="board-body" hidden>
-          <p class="gov-grid-note">Read an idea, then decide. An objection needs a reason and the section it faults.</p>
           <div id="gov-board"><span class="kit-skel"></span></div>
         </section>
       </main>
@@ -62,7 +60,7 @@
 
 <script src="/builders/shell-trail.js?v=2026-10-08-city-tab"></script>
 <script src="/builders/craft-mode.js?v=2026-10-09-living3"></script>
-<script src="/builders/shell.js?v=2026-10-18-core-move1"></script>
+<script src="/builders/shell.js?v=2026-10-25-logo1"></script>
 <!-- jump palette (Ctrl/Cmd-K). Optional by design: without it the shell's slot stays hidden. -->
 <script src="/builders/palette.js" defer></script>
 <script src="/builders/dom-utils.js?v=2026-06-16-board"></script>
@@ -70,6 +68,8 @@
 <!-- task 1003761: the vocabulary this page and /government both speak. Must load
      BEFORE board-room.js, which destructures window.OTBBoardLib at IIFE entry. -->
 <script src="/builders/board-lib.js?v=2026-09-10-boardlib1"></script>
+<!-- the shared ask card the vote is drawn with (task 1004825) -->
+<script src="/builders/hall-ask.js"></script>
 <script src="/builders/board-room.js?v=2026-09-09-board-carve"></script>
 </body>
 </html>

package/modules/hall-ui/public/board-room.js

@@ -373,22 +373,38 @@
     const labels = labelsOf(item);
     const sections = Object.keys(labels).map((key) => `
       <label class="gov-vote__section"><input type="radio" name="vote-section-${escapeHtml(item.id)}" value="${escapeHtml(key)}"> <span>${escapeHtml(labels[key])}</span></label>`).join('');
+    // task 1004825: the vote is the page's one real decision, so it is the
+    // shared ask card (OTBAsk). "Object" opens the reason form under the card
+    // rather than casting — an objection needs a reason and a section.
     const ownNote = isOwnIdea
-      ? `<p class="gov-grid-note">Your own idea. You may vote, but it can’t be decided by your vote alone, and a vote on your own idea earns no karma.</p>`
+      ? 'Your own idea: it can’t be decided by your vote alone, and your vote earns no karma.'
       : '';
+    const card = window.OTBAsk.html({
+      tag: 'div',
+      q: VOTE_QUESTION[item.subject_type] || 'Pass this?',
+      said: ownNote,
+      opts: [
+        { label: 'Vote yes', result: 'It counts toward passing', rec: true, attrs: { 'data-vote': 'yes' } },
+        { label: 'Object', result: 'It goes back with your reason', attrs: { 'data-vote-open': '' } },
+      ],
+    });
     return `<div class="gov-vote" data-item="${escapeHtml(item.id)}">
-      ${ownNote}
-      <button type="button" class="btn-accent" data-vote="yes">Vote yes</button>
-      <details class="gov-vote__no">
-        <summary class="btn-ghost">Object…</summary>
-        <p class="gov-grid-note">This sends the idea back to its author. Say why, and which section.</p>
-        <textarea data-vote-reason placeholder="Why — the reason the author will act on" maxlength="5000" rows="3"></textarea>
+      ${card}
+      <div class="gov-vote__no" hidden>
+        <textarea data-vote-reason placeholder="Why — the author acts on this" maxlength="5000" rows="3"></textarea>
         <div class="gov-vote__sections">${sections}</div>
-        <button type="button" class="btn-ghost btn-ghost--danger" data-vote="no">Cast objection</button>
-      </details>
+        <button type="button" class="btn-ghost btn-ghost--danger" data-vote="no">Send objection</button>
+      </div>
     </div>`;
   }
 
+  // The card's question, by what is being decided (task 1004825).
+  const VOTE_QUESTION = {
+    full_idea: 'Pass this idea?',
+    genesis_stage: 'Close this stage?',
+    constitutional_amendment: 'Pass this change?',
+  };
+
   async function castVoteFromRoom(itemId, direction, container) {
     const body = { direction };
     if (direction === 'no') {
@@ -442,14 +458,18 @@
       ? `<p class="gov-item__amend">Proposes <code>${escapeHtml(JSON.stringify(item.subject.proposed))}</code>${item.subject.rationale_md ? ` — ${escapeHtml(item.subject.rationale_md)}` : ''}</p>`
       : '';
     const mine = item.votes.find((v) => String(v.voter_id) === String(viewerId));
-    // A voter who has cast sees WHAT they cast where the buttons were. The line
+    // A voter who has cast sees WHAT they cast where the buttons were. The
+    // ballot shows only when the server says this viewer may cast here
+    // (viewer_may_vote — board membership under the item's snapshot, clock
+    // still running; task 1004825). A missing flag hides it.
+    // The line
     // that used to fill this slot for everyone else — announcing that the reader
     // had not voted and that casting was still to come — is deleted outright: it
     // explained the UI to itself, and the form it promised shipped in R17.
     const action = !isOpen ? ''
       : mine
-        ? `<p class="gov-item__cast">You ${mine.direction === 'no' ? 'objected' : 'voted yes'}. One vote per member.</p>`
-        : voteFormHtml(item, viewerId);
+        ? `<p class="gov-item__cast">You ${mine.direction === 'no' ? 'objected' : 'voted yes'}.</p>`
+        : item.viewer_may_vote === true ? voteFormHtml(item, viewerId) : '';
     const tally = `${yes} yes · ${no} objection${no === 1 ? '' : 's'}`;
     return `<section class="scroll gov-item" id="board-item-${escapeHtml(item.id)}">
       <div class="gov-item__head">
@@ -487,17 +507,9 @@
     const open = openItems.map((i) => itemCard(i, viewerId)).join('');
     const closed = closedItems.map((i) => itemCard(i, viewerId)).join('');
     box.innerHTML =
-      (open || `<section class="scroll">${emptyStateHtml('Nothing is before the board. When a Full Idea clears the completeness grade, its window opens here.')}</section>`)
+      (open || `<section class="scroll">${emptyStateHtml('Nothing to vote on.')}</section>`)
       + `<div class="gov-board__divider">${groupHead('Closed sittings', closedItems.length)}</div>`
       + (closed || `<section class="scroll">${emptyStateHtml('No sitting has closed yet.')}</section>`);
-    // The subtitle counts what is actually waiting, so the room says on arrival
-    // what the nav badge said from outside it (ADR 0266).
-    const sub = document.getElementById('board-sub');
-    if (sub) {
-      sub.textContent = openItems.length
-        ? `${openItems.length} open ${openItems.length === 1 ? 'sitting' : 'sittings'}.`
-        : 'Nothing is before the board.';
-    }
     // R21: the Discord announcement deep-links ?item=<id> — land the reader on
     // THAT sitting. It carried `#board-room` too while this was a tab; the hash
     // is now meaningless here and government.js redirects the old form (ADR
@@ -515,6 +527,14 @@
     // R17: the cast buttons. One delegated listener; the SERVER refuses every
     // illegitimate cast regardless (membership, anti-self, closed, expired) —
     // the form is a courtesy, the route is the wall.
+    box.querySelectorAll('.gov-vote [data-vote-open]').forEach((btn) => {
+      btn.addEventListener('click', () => {
+        const form = btn.closest('.gov-vote').querySelector('.gov-vote__no');
+        form.hidden = !form.hidden;
+        btn.setAttribute('aria-expanded', String(!form.hidden));
+        if (!form.hidden) form.querySelector('textarea').focus();
+      });
+    });
     box.querySelectorAll('.gov-vote [data-vote]').forEach((btn) => {
       btn.addEventListener('click', () => {
         const wrap = btn.closest('.gov-vote');
@@ -534,7 +554,6 @@
   function showSealed() {
     document.getElementById('board-sealed').hidden = false;
     document.getElementById('board-body').hidden = true;
-    document.getElementById('board-sub').textContent = 'Restricted.';
     const body = document.getElementById('board-sealed-body');
     if (body) {
       body.textContent = 'The Board Room is open to the builders this project’s constitution seats on its board.';
@@ -552,7 +571,6 @@
       // Any other failure is not an authorization answer — show the room and let
       // the board read speak for itself.
     }
-    document.getElementById('board-sub').textContent = 'Loading sittings…';
     document.getElementById('board-body').hidden = false;
     loadBoard();
   }

package/modules/hall-ui/public/board-room.states.json

@@ -77,7 +77,7 @@
         ],
         [
           "click",
-          ".gov-vote__no > summary"
+          "[data-vote-open]"
         ],
         [
           "wait",

package/modules/hall-ui/public/brand-apply.js

@@ -61,7 +61,7 @@
       var desc = document.querySelector('meta[name="description"]');
       if (desc) {
         desc.setAttribute('content',
-          'The builder hub for ' + product + '. Standing, achievements, and work waiting to be claimed.');
+          'The builder hub for ' + product + '. Accomplishments and work waiting to be claimed.');
       }
     }
   }

package/modules/hall-ui/public/brand-holes.js

@@ -3,7 +3,7 @@
 //
 // WHY. A page's source says {{productName}} where the server writes the
 // instance's name at serve time (src/bongos/serve-internal.js applyBrandTokens),
-// and the page readings keep the token by name (scripts/gds/page-reader.js). So
+// and the page readings keep the token by name (scripts/bongos/page-reader.js). So
 // the Approval queue and the tweak editor were showing an artist the raw
 // "{{productName}}", and the editor let them type over it or lose the spaces
 // around it (the first real round came back as "This project,{{productName}}has