@bevel-software/platform-core-backend 0.35.0 → 0.36.1

package/src/modules/{workflow → version-control}/git/pull-request.service.ts

@@ -19,7 +19,7 @@ import { changeRequests } from '../../database/index.js';
 import type { WorkspaceService } from '../../workspace/index.js';
 import type { IAccessControl } from '../../access/index.js';
 import { AccessUnreadableError } from '../../access-model/index.js';
-import { AppliedChangeMismatchError, WorkflowValidationError } from '../../../shared/domain-errors.js';
+import { AppliedChangeMismatchError, VersionControlValidationError } from '../../../shared/domain-errors.js';
 import { canonicalEmail, hashEmail } from '../../../shared/email-identity.js';
 import { changeRequestLink, changeRequestLinkBase } from './change-request-link.js';
 
@@ -141,9 +141,9 @@ export function changeSourceFor(row: {
 }
 
 /**
- * The slice of the review-workflow service this module needs to compose detail
+ * The slice of the change-request-review service this module needs to compose detail
  * responses. Kept narrow (just what `getPrDetail` stitches in) so the PR
- * service doesn't depend on the full workflow interface — and so the circular
+ * service doesn't depend on the full version-control interface — and so the circular
  * relationship in the composition root is explicit and minimal.
  */
 export interface PrDetailEnricher {
@@ -183,7 +183,7 @@ export interface PrDetailEnricher {
  * The durable facts (pairing, title/body, author, state) live in the row; the
  * head/base SHAs, file list, and diffs are derived live from git so a new commit
  * or force-push is always reflected. Per-file approvals and the merge gate
- * are stitched in from the review-workflow service (also DB-backed).
+ * are stitched in from the change-request-review service (also DB-backed).
  */
 export class PullRequestService implements IPullRequestService {
   /**
@@ -223,9 +223,9 @@ export class PullRequestService implements IPullRequestService {
   >();
 
   /**
-   * Optional — set by the composition root after ReviewWorkflowService exists.
+   * Optional — set by the composition root after ChangeRequestReviewService exists.
    * Setter-based wiring (not constructor) because PullRequestService is itself
-   * a dependency of ReviewWorkflowService's routes, and we want both to live
+   * a dependency of ChangeRequestReviewService's routes, and we want both to live
    * in the same container without a forward-declaration dance.
    */
   private detailEnricher: PrDetailEnricher | null = null;
@@ -354,7 +354,7 @@ export class PullRequestService implements IPullRequestService {
       // to shout about — it is this row's turn to be fetched, and the next list
       // read answers it. Warning per request on that would be the log flood the
       // network flood came with.
-      if (err instanceof WorkflowValidationError) {
+      if (err instanceof VersionControlValidationError) {
         log.debug(`${what} could not resolve ${where}; answering no touched paths:`, { err });
       } else {
         log.warn(`${what} failed for ${where}:`, { err });
@@ -610,7 +610,7 @@ export class PullRequestService implements IPullRequestService {
 
   async getPr(prNumber: number): Promise<PullRequestSummary | null> {
     if (!Number.isInteger(prNumber) || prNumber <= 0) {
-      throw new WorkflowValidationError('PR number must be a positive integer');
+      throw new VersionControlValidationError('PR number must be a positive integer');
     }
     const row = await this.findRow(prNumber);
     if (!row) return null;
@@ -677,7 +677,7 @@ export class PullRequestService implements IPullRequestService {
     opts: { fresh?: boolean; workspaceId?: string; viewerEmail?: string; patches?: boolean } = {},
   ): Promise<PullRequestDetail | null> {
     if (!Number.isInteger(prNumber) || prNumber <= 0) {
-      throw new WorkflowValidationError('PR number must be a positive integer');
+      throw new VersionControlValidationError('PR number must be a positive integer');
     }
     const generation = this.cacheGeneration;
     const row = await this.findRow(prNumber);
@@ -798,7 +798,7 @@ export class PullRequestService implements IPullRequestService {
       // a branch not yet published or a clone not yet caught up, and presenting
       // a live proposal as one that changes nothing would tell a reviewer the
       // opposite of the truth.
-      if (!(err instanceof WorkflowValidationError) || row.state === 'open') throw err;
+      if (!(err instanceof VersionControlValidationError) || row.state === 'open') throw err;
       log.warn(
         `change request #${prNumber} is ${row.state} and can no longer be diffed; answering from its row alone:`,
         { err },
@@ -835,7 +835,7 @@ export class PullRequestService implements IPullRequestService {
       })),
     );
 
-    // Approvals come from our own DB via the review-workflow service. The
+    // Approvals come from our own DB via the change-request-review service. The
     // enricher is optional — if it isn't wired yet (startup ordering, isolated
     // tests) we return an empty list rather than blocking the fetch.
     const approvals = this.detailEnricher
@@ -953,7 +953,7 @@ export class PullRequestService implements IPullRequestService {
       viewerIsAuthor,
       viewerCanDelete,
       // Who may close a request may also change what it asks: the same
-      // grants, so the same predicate (`WorkflowService.updateChangeRequest`
+      // grants, so the same predicate (`VersionControlService.updateChangeRequest`
       // enforces it).
       viewerCanEdit: viewerCanCancel,
     };

package/src/modules/{workflow → version-control}/index.ts

@@ -1,5 +1,5 @@
 /**
- * What the workflow module offers the other modules: the addresses of its
+ * What the version-control module offers the other modules: the addresses of its
  * change requests, so a module that lands a proposal can hand back a link
  * built by the one rule — rather than each spelling the route for itself;
  * and the live-event surface — the bus, the events route, and the delivery
@@ -7,14 +7,15 @@
  * the composition root.
  */
 export { CHANGE_REQUEST_URL_NOTE, changeRequestLink, changeRequestLinkBase } from './git/change-request-link.js';
-export { WorkflowEventBus } from './event-bus.js';
+export { VersionControlEventBus } from './event-bus.js';
 export { createEventsRoutes } from './events.routes.js';
+export { createVersionControlRoutes } from './version-control.routes.js';
 export { EventDelivery, createEventAccess } from './events-delivery.js';
 export type { ChangeRequestFacts, EventAccess, EventViewer, IEventDelivery } from './events-delivery.js';
 // Reached by other modules; exported here so they stop importing the files.
 export { NodeGitRunner } from './git/node-git-runner.js';
 export { RECOVERY_BOT_EMAIL } from './recovery-bot.js';
-export type { IReviewWorkflowService } from './review-workflow/review-workflow.interface.js';
+export type { IChangeRequestReviewService } from './change-request-review/change-request-review.interface.js';
 export { sanitizeError } from './sanitize-error.js';
-export type { WorkflowHooks } from './workflow-hooks.js';
-export type { WorkflowService } from './workflow.service.js';
+export type { VersionControlHooks } from './version-control-hooks.js';
+export type { VersionControlService } from './version-control.service.js';

package/src/modules/{workflow → version-control}/pending-commits.service.ts

@@ -1,7 +1,7 @@
 /**
  * Persistent queue of "files written to disk but not yet committed to git."
  *
- * Decouples the lock-release path from git work: `WorkflowService.releaseLock`
+ * Decouples the lock-release path from git work: `VersionControlService.releaseLock`
  * enqueues a row and returns immediately; the background `PendingCommitsWorker`
  * drains rows by running `commitFile + push`. Persistence is the point — a
  * process crash mid-commit (the bug class that stranded the `GTM/Uploads/*.docx`
@@ -510,7 +510,7 @@ export class PendingCommitsService {
    * `needs_attention` row deliberately does NOT count: its ladder has
    * escalated to a human and nothing will retry it, so a caller asking
    * "is my landed-but-unpushed commit going to be published?" must hear no.
-   * Backs `IWorkflowService.hasQueuedCommit` (the synced-groups committer's
+   * Backs `IVersionControlService.hasQueuedCommit` (the synced-groups committer's
    * armed-retry proof) and the coordination-release discard guard.
    */
   async hasLiveRowFor(rawWorkspaceId: string, branch: string, path: string): Promise<boolean> {

package/src/modules/{workflow → version-control}/pending-commits.worker.ts

@@ -49,10 +49,10 @@ import {
   canonicalWorkspaceId,
 } from './pending-commits.service.js';
 import { sanitizeError } from './sanitize-error.js';
-import { WorkflowDomainError } from '../../shared/domain-errors.js';
+import { VersionControlDomainError } from '../../shared/domain-errors.js';
 
 /**
- * Where the worker escalates terminal failures — the narrow, workflow-owned
+ * Where the worker escalates terminal failures — the narrow, version-control-owned
  * slice of whatever notice sink the app provides. The enterprise app passes
  * its feedback service (structurally compatible: its `send` accepts a wider
  * source union); a core-only deployment can pass
@@ -134,11 +134,11 @@ export interface RecoveryAgentRunner {
 }
 
 /**
- * Workflow surface the worker depends on. A subset of the real
- * `WorkflowService` — pulled behind an interface so tests can stub the
+ * Version-control surface the worker depends on. A subset of the real
+ * `VersionControlService` — pulled behind an interface so tests can stub the
  * commit/push pipeline without spinning up a real git workspace.
  */
-export interface WorkflowCommitDriver {
+export interface VersionControlCommitDriver {
   /**
    * Commit whatever's currently on disk for `path`, then push the branch.
    * Uses `pushWithRecovery` semantics internally (cooperative pull-rebase
@@ -167,7 +167,7 @@ export interface WorkspaceProvider {
 
 export interface PendingCommitsWorkerDeps {
   service: PendingCommitsService;
-  workflow: WorkflowCommitDriver;
+  versionControl: VersionControlCommitDriver;
   recoveryAgent: RecoveryAgentRunner;
   feedback: ISystemNoticeSink;
   workspaces: WorkspaceProvider;
@@ -361,7 +361,7 @@ export class PendingCommitsWorker {
       name: row.authorName,
     };
     try {
-      await this.deps.workflow.runPendingCommit(row.workspaceId, row.branch, row.path, user, {
+      await this.deps.versionControl.runPendingCommit(row.workspaceId, row.branch, row.path, user, {
         skipValidation: opts?.skipValidation,
       });
       await this.deps.service.markSucceeded(row.id);
@@ -467,7 +467,7 @@ export class PendingCommitsWorker {
  * it on every attempt.
  */
 function pathOutsideRepoCorrection(err: unknown): string | null {
-  if (!(err instanceof WorkflowDomainError) || err.payload?.kind !== 'path-outside-repo') return null;
+  if (!(err instanceof VersionControlDomainError) || err.payload?.kind !== 'path-outside-repo') return null;
   const corrected = err.payload.corrected;
   return typeof corrected === 'string' && corrected.length > 0 ? corrected : '(see error)';
 }

package/src/modules/{workflow → version-control}/read-on-branch.ts

@@ -1,5 +1,5 @@
 import type { IAccessControl } from '../access/index.js';
-import { WorkflowDomainError } from '../../shared/domain-errors.js';
+import { VersionControlDomainError } from '../../shared/domain-errors.js';
 
 /**
  * Which of `paths` `userEmail` may read at `origin/<base>`, as a membership
@@ -48,7 +48,7 @@ export async function readableAtCommits(
 }
 
 /** The refusal `readableAtCommits` answers false with, as every caller words it: the branch named, never the commit. */
-export class ReadOnBranchDeniedError extends WorkflowDomainError {
+export class ReadOnBranchDeniedError extends VersionControlDomainError {
   constructor(displayPath: string, branch: string) {
     super(`You don't have permission to read "${displayPath}" on "${branch}".`, 403, {
       kind: 'read-denied',

package/src/modules/{workflow/workflow-hooks.ts → version-control/version-control-hooks.ts}

@@ -1,7 +1,7 @@
 import type { AuthUser, ValidationReport } from '@bevel-software/platform-shared';
 
 /**
- * Workflow lifecycle hooks — the generic seam that replaced the
+ * Version-control lifecycle hooks — the generic seam that replaced the
  * constructor-injected KB validator. Core code invokes the hooks at fixed
  * lifecycle points; the modules that OWN the behavior register handlers in the
  * composition root, right after `createCoreServices` returns. Core registers
@@ -85,9 +85,9 @@ export type PreWriteHook = (ctx: AgentOperationContext) => Promise<void>;
 /**
  * The registry instance. ONE per composition (created in
  * `createCoreServices`, shared by `GitService` and exposed as
- * `WorkflowService.hooks` for the composition root to register against).
+ * `VersionControlService.hooks` for the composition root to register against).
  */
-export class WorkflowHooks {
+export class VersionControlHooks {
   private readonly commitValidation: CommitValidationHook[] = [];
   private readonly agentRead: AgentReadHook[] = [];
   private readonly preWrite: PreWriteHook[] = [];