@bevel-software/platform-core-backend 0.35.0 → 0.36.1

package/src/modules/{workflow → version-control}/__tests__/event-bus.test.ts

@@ -1,6 +1,6 @@
 import { describe, it, expect, vi } from 'vitest';
-import type { WorkflowEvent } from '@bevel-software/platform-shared';
-import { WorkflowEventBus } from '../index.js';
+import type { VersionControlEvent } from '@bevel-software/platform-shared';
+import { VersionControlEventBus } from '../index.js';
 
 /**
  * Make a `Subscriber`-compatible spy. Returns the spy + a getter for
@@ -21,10 +21,10 @@ function makeSubscriber(sessionId: string, userId: string, initialFocus: string
   };
 }
 
-describe('WorkflowEventBus', () => {
+describe('VersionControlEventBus', () => {
   describe('scope filtering', () => {
     it('delivers workspace-scoped events only to sessions focused on that workspace', () => {
-      const bus = new WorkflowEventBus();
+      const bus = new VersionControlEventBus();
       const onA = makeSubscriber('s-a', 'u-1', 'ws-feat');
       const onB = makeSubscriber('s-b', 'u-2', 'ws-other');
       bus.subscribe(onA);
@@ -51,7 +51,7 @@ describe('WorkflowEventBus', () => {
     // branch reached nobody who wasn't standing there, and every such page
     // showed the old picture until a reload.
     it('delivers to a session watching a second workspace alongside its focus', () => {
-      const bus = new WorkflowEventBus();
+      const bus = new VersionControlEventBus();
       const onBranch = makeSubscriber('s-a', 'u-1', 'alice%2Fdraft');
       onBranch.alsoWatch('main');
       const elsewhere = makeSubscriber('s-b', 'u-2', 'bob%2Fdraft');
@@ -73,7 +73,7 @@ describe('WorkflowEventBus', () => {
     });
 
     it('still delivers the focused workspace to a session that also watches another', () => {
-      const bus = new WorkflowEventBus();
+      const bus = new VersionControlEventBus();
       const sub = makeSubscriber('s-a', 'u-1', 'alice%2Fdraft');
       sub.alsoWatch('main');
       bus.subscribe(sub);
@@ -98,14 +98,14 @@ describe('WorkflowEventBus', () => {
       // canonicalisation, workspace-scoped events for any branch with a `/`
       // never reach the receiver — the silent bug we hit on
       // `razvan-radulescu/sc`.
-      const bus = new WorkflowEventBus();
+      const bus = new VersionControlEventBus();
       const encodedFocus = makeSubscriber('s-enc', 'u-1', 'razvan-radulescu%2Fsc');
       const decodedFocus = makeSubscriber('s-dec', 'u-2', 'razvan-radulescu/sc');
       bus.subscribe(encodedFocus);
       bus.subscribe(decodedFocus);
 
       // Event fired with the DECODED form (mirrors what Express's
-      // req.params.id passes into workflow methods).
+      // req.params.id passes into version-control methods).
       bus.emit({
         kind: 'lock-released',
         workspaceId: 'razvan-radulescu/sc',
@@ -128,7 +128,7 @@ describe('WorkflowEventBus', () => {
     });
 
     it('delivers user-scoped events only to sessions belonging to that user', () => {
-      const bus = new WorkflowEventBus();
+      const bus = new VersionControlEventBus();
       const onAlice = makeSubscriber('s-alice', 'u-alice');
       const onBob = makeSubscriber('s-bob', 'u-bob');
       bus.subscribe(onAlice);
@@ -141,7 +141,7 @@ describe('WorkflowEventBus', () => {
     });
 
     it("delivers an agent's tool call only to the person whose agent made it", () => {
-      const bus = new WorkflowEventBus();
+      const bus = new VersionControlEventBus();
       const onAlice = makeSubscriber('s-alice', 'u-alice');
       const onBob = makeSubscriber('s-bob', 'u-bob');
       bus.subscribe(onAlice);
@@ -160,7 +160,7 @@ describe('WorkflowEventBus', () => {
     });
 
     it('delivers change-request-merge-failed only to the user who triggered the merge', () => {
-      const bus = new WorkflowEventBus();
+      const bus = new VersionControlEventBus();
       const onAlice = makeSubscriber('s-alice', 'u-alice');
       const onBob = makeSubscriber('s-bob', 'u-bob');
       bus.subscribe(onAlice);
@@ -179,7 +179,7 @@ describe('WorkflowEventBus', () => {
     });
 
     it("delivers global events (e.g. change-request-opened) to every subscriber regardless of focus or user", () => {
-      const bus = new WorkflowEventBus();
+      const bus = new VersionControlEventBus();
       const onA = makeSubscriber('s-a', 'u-1', null); // no focus at all
       const onB = makeSubscriber('s-b', 'u-2', 'ws-other');
       bus.subscribe(onA);
@@ -198,7 +198,7 @@ describe('WorkflowEventBus', () => {
     });
 
     it("skips workspace events for sessions that haven't set a focus yet", () => {
-      const bus = new WorkflowEventBus();
+      const bus = new VersionControlEventBus();
       const unfocused = makeSubscriber('s-x', 'u-1', null);
       bus.subscribe(unfocused);
 
@@ -215,7 +215,7 @@ describe('WorkflowEventBus', () => {
     });
 
     it('honours a mid-stream focus change without re-subscribing', () => {
-      const bus = new WorkflowEventBus();
+      const bus = new VersionControlEventBus();
       const sub = makeSubscriber('s-1', 'u-1', 'ws-a');
       bus.subscribe(sub);
 
@@ -234,7 +234,7 @@ describe('WorkflowEventBus', () => {
 
   describe('envelope', () => {
     it('stamps each event with a monotonic id and an ISO timestamp', () => {
-      const bus = new WorkflowEventBus();
+      const bus = new VersionControlEventBus();
       const e1 = bus.emit({ kind: 'change-request-merged', number: 1 });
       const e2 = bus.emit({ kind: 'change-request-merged', number: 2 });
       expect(e1.id).toBe(1);
@@ -246,7 +246,7 @@ describe('WorkflowEventBus', () => {
 
   describe('replay', () => {
     it('returns events strictly after the last-seen id', () => {
-      const bus = new WorkflowEventBus();
+      const bus = new VersionControlEventBus();
       const sub = { userId: 'u-1', getFocusedWorkspaceIds: () => ['ws-a'] };
       bus.emit({ kind: 'lock-released', workspaceId: 'ws-a', branch: 'a', path: '1.md' });
       bus.emit({ kind: 'lock-released', workspaceId: 'ws-a', branch: 'a', path: '2.md' });
@@ -254,11 +254,11 @@ describe('WorkflowEventBus', () => {
 
       const tail = bus.replayAfter(1, sub);
       expect(tail).not.toBeNull();
-      expect(tail!.map((e) => (e as WorkflowEvent & { path?: string }).path)).toEqual(['2.md', '3.md']);
+      expect(tail!.map((e) => (e as VersionControlEvent & { path?: string }).path)).toEqual(['2.md', '3.md']);
     });
 
     it('respects scope filtering on replay (no leak of other workspaces)', () => {
-      const bus = new WorkflowEventBus();
+      const bus = new VersionControlEventBus();
       const sub = { userId: 'u-1', getFocusedWorkspaceIds: () => ['ws-a'] };
       bus.emit({ kind: 'lock-released', workspaceId: 'ws-a', branch: 'a', path: 'a.md' });
       bus.emit({ kind: 'lock-released', workspaceId: 'ws-b', branch: 'b', path: 'b.md' });
@@ -276,7 +276,7 @@ describe('WorkflowEventBus', () => {
       // The bus's BUFFER_CAPACITY is 500 — emit one more than that to
       // force eviction of id 1, then ask to replay after id 0 (which
       // sits BEFORE the now-evicted id 1).
-      const bus = new WorkflowEventBus();
+      const bus = new VersionControlEventBus();
       for (let i = 0; i < 501; i++) {
         bus.emit({ kind: 'change-request-merged', number: i + 1 });
       }
@@ -298,7 +298,7 @@ describe('WorkflowEventBus', () => {
       // entirely different events. Returning `[]` would silently lie.
       // The bus must return `null` so the route emits a `resync` and the
       // client refetches state from scratch.
-      const bus = new WorkflowEventBus();
+      const bus = new VersionControlEventBus();
       const sub = { userId: 'u-1', getFocusedWorkspaceIds: () => [] };
       expect(bus.replayAfter(42, sub)).toBeNull();
       // First-time client (Last-Event-ID === 0) on an empty buffer is
@@ -313,7 +313,7 @@ describe('WorkflowEventBus', () => {
       // the linear `id > lastSeenId` filter would return empty — but the
       // client has actually missed everything in the new id space too.
       // Force a resync so they refetch.
-      const bus = new WorkflowEventBus();
+      const bus = new VersionControlEventBus();
       for (let i = 0; i < 5; i++) {
         bus.emit({ kind: 'change-request-merged', number: i + 1 });
       }
@@ -329,7 +329,7 @@ describe('WorkflowEventBus', () => {
 
   describe('subscriber lifecycle', () => {
     it('unsubscribe removes the subscriber from future fan-out', () => {
-      const bus = new WorkflowEventBus();
+      const bus = new VersionControlEventBus();
       const sub = makeSubscriber('s-1', 'u-1', 'ws-a');
       const off = bus.subscribe(sub);
       bus.emit({ kind: 'lock-released', workspaceId: 'ws-a', branch: 'a', path: 'x.md' });
@@ -340,7 +340,7 @@ describe('WorkflowEventBus', () => {
     });
 
     it('does not double-emit when a subscriber re-registers with the same sessionId', () => {
-      const bus = new WorkflowEventBus();
+      const bus = new VersionControlEventBus();
       const first = makeSubscriber('s-1', 'u-1', 'ws-a');
       const second = makeSubscriber('s-1', 'u-1', 'ws-a'); // same id
       bus.subscribe(first);
@@ -355,7 +355,7 @@ describe('WorkflowEventBus', () => {
     });
 
     it('absorbs handler exceptions so one bad subscriber does not break the fan-out', () => {
-      const bus = new WorkflowEventBus();
+      const bus = new VersionControlEventBus();
       const exploder = makeSubscriber('s-bad', 'u-1', 'ws-a');
       exploder.push.mockImplementation(() => { throw new Error('boom'); });
       const healthy = makeSubscriber('s-good', 'u-2', 'ws-a');
@@ -369,7 +369,7 @@ describe('WorkflowEventBus', () => {
     });
 
     it('size() reflects active subscribers', () => {
-      const bus = new WorkflowEventBus();
+      const bus = new VersionControlEventBus();
       expect(bus.size()).toBe(0);
       const off1 = bus.subscribe(makeSubscriber('s-1', 'u-1'));
       const off2 = bus.subscribe(makeSubscriber('s-2', 'u-2'));
@@ -383,7 +383,7 @@ describe('WorkflowEventBus', () => {
 
   describe('onEmit — the server-side tap', () => {
     it('sees every event, unfiltered by SSE scope, and unsubscribes cleanly', () => {
-      const bus = new WorkflowEventBus();
+      const bus = new VersionControlEventBus();
       const seen: string[] = [];
       const off = bus.onEmit((e) => seen.push(e.kind));
       // A workspace-scoped event with NO matching SSE session still reaches
@@ -397,7 +397,7 @@ describe('WorkflowEventBus', () => {
     });
 
     it('a throwing listener is contained — emit never propagates it', () => {
-      const bus = new WorkflowEventBus();
+      const bus = new VersionControlEventBus();
       const warn = vi.spyOn(console, 'warn').mockImplementation(() => {});
       bus.onEmit(() => {
         throw new Error('bad listener');

package/src/modules/{workflow → version-control}/__tests__/events-delivery.test.ts

@@ -2,9 +2,9 @@ import type { Server as HttpServer } from 'node:http';
 import type { AddressInfo } from 'node:net';
 import express from 'express';
 import { afterEach, describe, expect, it } from 'vitest';
-import type { WorkflowEvent, WorkflowEventPayload } from '@bevel-software/platform-shared';
+import type { VersionControlEvent, VersionControlEventPayload } from '@bevel-software/platform-shared';
 import {
-  WorkflowEventBus,
+  VersionControlEventBus,
   createEventsRoutes,
   EventDelivery,
   createEventAccess,
@@ -80,7 +80,7 @@ afterEach(() => {
   for (const s of servers.splice(0)) s.close();
 });
 
-function listen(bus: WorkflowEventBus, access: EventAccess): string {
+function listen(bus: VersionControlEventBus, access: EventAccess): string {
   const app = express();
   const auth: express.RequestHandler = (req, res, next) => {
     const user = USERS[String(req.headers['x-test-user'])];
@@ -99,9 +99,9 @@ function listen(bus: WorkflowEventBus, access: EventAccess): string {
 }
 
 interface Stream {
-  events: WorkflowEvent[];
+  events: VersionControlEvent[];
   /** Resolves once an event matching `pred` has arrived. */
-  until: (pred: (e: WorkflowEvent) => boolean) => Promise<void>;
+  until: (pred: (e: VersionControlEvent) => boolean) => Promise<void>;
 }
 
 async function open(base: string, user: string, sessionId: string, lastEventId?: number): Promise<Stream> {
@@ -112,8 +112,8 @@ async function open(base: string, user: string, sessionId: string, lastEventId?:
     signal: abort.signal,
   });
   expect(res.status).toBe(200);
-  const events: WorkflowEvent[] = [];
-  const waiters: Array<{ pred: (e: WorkflowEvent) => boolean; resolve: () => void }> = [];
+  const events: VersionControlEvent[] = [];
+  const waiters: Array<{ pred: (e: VersionControlEvent) => boolean; resolve: () => void }> = [];
   void (async () => {
     const decoder = new TextDecoder();
     let buf = '';
@@ -126,7 +126,7 @@ async function open(base: string, user: string, sessionId: string, lastEventId?:
           buf = buf.slice(end + 2);
           const data = frame.split('\n').find((l) => l.startsWith('data: '));
           if (!data) continue;
-          const event = JSON.parse(data.slice('data: '.length)) as WorkflowEvent;
+          const event = JSON.parse(data.slice('data: '.length)) as VersionControlEvent;
           events.push(event);
           for (const w of [...waiters]) {
             if (w.pred(event)) {
@@ -156,7 +156,7 @@ async function focus(base: string, user: string, sessionId: string): Promise<voi
   expect(res.status).toBe(200);
 }
 
-const fileChanged = (path: string): WorkflowEventPayload => ({
+const fileChanged = (path: string): VersionControlEventPayload => ({
   kind: 'file-changed',
   workspaceId: WS,
   branch: WS,
@@ -165,7 +165,7 @@ const fileChanged = (path: string): WorkflowEventPayload => ({
   byUserId: 'alice',
   byUserName: 'Alice',
 });
-const lockAcquired = (path: string): WorkflowEventPayload => ({
+const lockAcquired = (path: string): VersionControlEventPayload => ({
   kind: 'lock-acquired',
   workspaceId: WS,
   branch: WS,
@@ -173,8 +173,8 @@ const lockAcquired = (path: string): WorkflowEventPayload => ({
   holderUserId: 'alice',
   holderName: 'Alice',
 });
-const lockReleased = (path: string): WorkflowEventPayload => ({ kind: 'lock-released', workspaceId: WS, branch: WS, path });
-const approval = (number: number, path: string): WorkflowEventPayload => ({
+const lockReleased = (path: string): VersionControlEventPayload => ({ kind: 'lock-released', workspaceId: WS, branch: WS, path });
+const approval = (number: number, path: string): VersionControlEventPayload => ({
   kind: 'approval-changed',
   number,
   path,
@@ -182,25 +182,25 @@ const approval = (number: number, path: string): WorkflowEventPayload => ({
   approverUserId: 'alice',
   change: 'added',
 });
-const opened = (number: number): WorkflowEventPayload => ({
+const opened = (number: number): VersionControlEventPayload => ({
   kind: 'change-request-opened',
   number,
   source: 'alice/draft',
   target: 'main',
   authorIdHash: null,
 });
-const documentUnreadable = (path: string): WorkflowEventPayload => ({
+const documentUnreadable = (path: string): VersionControlEventPayload => ({
   kind: 'document-unreadable',
   workspaceId: WS,
   path,
   reason: 'could not be parsed as a PDF (Invalid XRef stream header)',
 });
 /** Something everybody on the workspace may have; once it arrives, everything emitted before it was judged. */
-const SENTINEL: WorkflowEventPayload = { kind: 'fs-tree-changed', workspaceId: WS, branch: WS };
-const isSentinel = (e: WorkflowEvent) => e.kind === 'fs-tree-changed';
+const SENTINEL: VersionControlEventPayload = { kind: 'fs-tree-changed', workspaceId: WS, branch: WS };
+const isSentinel = (e: VersionControlEvent) => e.kind === 'fs-tree-changed';
 
 /** Emit `payloads`, then the sentinel, and wait for it on every stream. */
-async function emitAndSettle(bus: WorkflowEventBus, payloads: WorkflowEventPayload[], ...on: Stream[]) {
+async function emitAndSettle(bus: VersionControlEventBus, payloads: VersionControlEventPayload[], ...on: Stream[]) {
   for (const p of payloads) bus.emit(p);
   const sentinel = bus.emit(SENTINEL);
   await Promise.all(on.map((s) => s.until((e) => e.id === sentinel.id)));
@@ -210,7 +210,7 @@ const kinds = (s: Stream) => s.events.filter((e) => !isSentinel(e)).map((e) => `
 
 describe('events route — delivery rule', () => {
   it('a write, a lock and an approval in a folder reach the reader of the folder, not the other person', async () => {
-    const bus = new WorkflowEventBus();
+    const bus = new VersionControlEventBus();
     const base = listen(bus, fakeAccess());
     const alice = await open(base, 'alice', 's-alice');
     const bob = await open(base, 'bob', 's-bob');
@@ -237,7 +237,7 @@ describe('events route — delivery rule', () => {
     // The kind names a path on a workspace, so the structural rule judges it
     // as it judges a write: the same gate the file routes apply, and nothing
     // the rule has to be taught per kind.
-    const bus = new WorkflowEventBus();
+    const bus = new VersionControlEventBus();
     const base = listen(bus, fakeAccess());
     const alice = await open(base, 'alice', 's-alice');
     const bob = await open(base, 'bob', 's-bob');
@@ -253,7 +253,7 @@ describe('events route — delivery rule', () => {
   });
 
   it('a person keeps every event for what they may read, unchanged and in order', async () => {
-    const bus = new WorkflowEventBus();
+    const bus = new VersionControlEventBus();
     const base = listen(bus, fakeAccess());
     const bob = await open(base, 'bob', 's-bob');
     await focus(base, 'bob', 's-bob');
@@ -265,7 +265,7 @@ describe('events route — delivery rule', () => {
   });
 
   it('a request the person may not see produces no change-request-opened for them; its author always hears of it', async () => {
-    const bus = new WorkflowEventBus();
+    const bus = new VersionControlEventBus();
     const base = listen(bus, fakeAccess());
     const alice = await open(base, 'alice', 's-alice');
     const bob = await open(base, 'bob', 's-bob');
@@ -289,7 +289,7 @@ describe('events route — delivery rule', () => {
   });
 
   it('replay after a reconnect obeys the same rule', async () => {
-    const bus = new WorkflowEventBus();
+    const bus = new VersionControlEventBus();
     const base = listen(bus, fakeAccess());
     const before = bus.emit(SENTINEL);
     bus.emit(opened(FINANCE_REQUEST));
@@ -312,19 +312,19 @@ describe('events route — delivery rule', () => {
   });
 
   it('the focus list still decides which workspaces a session hears about', async () => {
-    const bus = new WorkflowEventBus();
+    const bus = new VersionControlEventBus();
     const base = listen(bus, fakeAccess());
     const alice = await open(base, 'alice', 's-alice');
     await focus(base, 'alice', 's-alice');
 
-    bus.emit({ ...fileChanged(PUBLIC), workspaceId: 'elsewhere' } as WorkflowEventPayload);
+    bus.emit({ ...fileChanged(PUBLIC), workspaceId: 'elsewhere' } as VersionControlEventPayload);
     await emitAndSettle(bus, [], alice);
 
     expect(kinds(alice)).toEqual([]);
   });
 
   it('a grant shows on the next event, without a reconnect', async () => {
-    const bus = new WorkflowEventBus();
+    const bus = new VersionControlEventBus();
     const access = fakeAccess();
     const base = listen(bus, access);
     const bob = await open(base, 'bob', 's-bob');
@@ -338,7 +338,7 @@ describe('events route — delivery rule', () => {
   });
 
   it('replay after a reconnect asks again: a revocation since the event was first delivered withholds it', async () => {
-    const bus = new WorkflowEventBus();
+    const bus = new VersionControlEventBus();
     const access = fakeAccess();
     access.grantBob();
     const base = listen(bus, access);
@@ -367,7 +367,7 @@ describe('events route — delivery rule', () => {
   });
 
   it("keeps a session's stream in emission order when a later verdict settles first, live and on replay", async () => {
-    const bus = new WorkflowEventBus();
+    const bus = new VersionControlEventBus();
     const base0 = fakeAccess();
     // The verdict on the Finance file takes a while; every other one is immediate.
     const access: EventAccess = {
@@ -401,7 +401,7 @@ describe('events route — delivery rule', () => {
   });
 
   it('a request check that fails withholds that approval and that announcement, and nothing after them', async () => {
-    const bus = new WorkflowEventBus();
+    const bus = new VersionControlEventBus();
     const unreadable = () => Promise.reject(new Error('access tree unreadable'));
     const access: EventAccess = { ...fakeAccess(), readableAtTarget: unreadable, readableAtBase: unreadable };
     const base = listen(bus, access);
@@ -416,7 +416,7 @@ describe('events route — delivery rule', () => {
 
   it('a lock whose path lacks the knowledge-base/ prefix is judged as the repository path it names', async () => {
     // The real access wiring over a fake access service: Bob may not read `Finance/`.
-    const bus = new WorkflowEventBus();
+    const bus = new VersionControlEventBus();
     const access = createEventAccess({
       accessControl: {
         canRead: async (_ws, email, rel) => email !== USERS.bob!.email || !rel.startsWith('Finance/'),
@@ -452,7 +452,7 @@ describe('events route — delivery rule', () => {
   });
 
   it("an agent's tool call reaches its own person through the route, nobody else — an admin included", async () => {
-    const bus = new WorkflowEventBus();
+    const bus = new VersionControlEventBus();
     const base = listen(bus, fakeAccess());
     const alice = await open(base, 'alice', 's-alice');
     const bob = await open(base, 'bob', 's-bob');
@@ -474,7 +474,7 @@ describe('events route — delivery rule', () => {
   });
 
   it('fans one event out to 100 sessions through the route, each getting what it may read', async () => {
-    const bus = new WorkflowEventBus();
+    const bus = new VersionControlEventBus();
     const base = listen(bus, fakeAccess());
     const sessions = await Promise.all(
       Array.from({ length: 100 }, async (_, i) => {
@@ -502,7 +502,7 @@ describe('events route — delivery rule', () => {
   });
 
   it("git-sync-failed carries git's words only to who may read the root and every conflicted file", async () => {
-    const bus = new WorkflowEventBus();
+    const bus = new VersionControlEventBus();
     const base = listen(bus, fakeAccess());
     const people = ['alice', 'bob', 'carol'] as const;
     const [alice, bob, carol] = await Promise.all(people.map((u) => open(base, u, `s-${u}`)));
@@ -532,7 +532,7 @@ describe('events route — delivery rule', () => {
   });
 
   it('git-sync-failed with no conflict keeps its sentence for a root reader and redacts it for the rest', async () => {
-    const bus = new WorkflowEventBus();
+    const bus = new VersionControlEventBus();
     const base = listen(bus, fakeAccess());
     const carol = await open(base, 'carol', 's-carol');
     const bob = await open(base, 'bob', 's-bob');
@@ -549,8 +549,8 @@ describe('events route — delivery rule', () => {
 });
 
 describe('EventDelivery', () => {
-  const judge = (event: WorkflowEvent, viewer: EventViewer, access: EventAccess) => new EventDelivery(access).judge(event, viewer);
-  const stamp = (p: WorkflowEventPayload, id = 1): WorkflowEvent => ({ id, ts: '2026-10-19T00:00:00.000Z', ...p }) as WorkflowEvent;
+  const judge = (event: VersionControlEvent, viewer: EventViewer, access: EventAccess) => new EventDelivery(access).judge(event, viewer);
+  const stamp = (p: VersionControlEventPayload, id = 1): VersionControlEvent => ({ id, ts: '2026-10-19T00:00:00.000Z', ...p }) as VersionControlEvent;
   const toolCall = stamp({ kind: 'agent-tool-call', forUserId: 'alice', threadId: 't', tool: 'write_file', summary: `writing ${FINANCE}` });
 
   it('agent-tool-call reaches the person whose agent made the call, nobody else', async () => {
@@ -736,7 +736,7 @@ describe('createEventAccess', () => {
   it("reads a request once for one event's whole fan-out, and again for the next", async () => {
     requestReads.length = 0;
     const delivery = new EventDelivery(access);
-    const event = { id: 1, ts: '2026-10-21T00:00:00.000Z', ...opened(FINANCE_REQUEST) } as WorkflowEvent;
+    const event = { id: 1, ts: '2026-10-21T00:00:00.000Z', ...opened(FINANCE_REQUEST) } as VersionControlEvent;
     const viewers = Array.from({ length: 100 }, (_, i) => ({ userId: `u${i}`, email: `u${i}@example.com` }));
     // Nobody here reads `Finance/` and nobody wrote #7: hidden from all of them.
     expect((await Promise.all(viewers.map((v) => delivery.judge(event, v)))).filter(Boolean)).toHaveLength(0);
@@ -764,7 +764,7 @@ describe('createEventAccess', () => {
     });
     const delivery = new EventDelivery(moved);
     const bob = { userId: 'bob', email: USERS.bob!.email };
-    const stampOpened = (n: number) => ({ id: n, ts: '2026-10-21T00:00:00.000Z', ...opened(n) }) as WorkflowEvent;
+    const stampOpened = (n: number) => ({ id: n, ts: '2026-10-21T00:00:00.000Z', ...opened(n) }) as VersionControlEvent;
     expect(await delivery.judge(stampOpened(1), bob)).toBeNull();
     expect(await delivery.judge(stampOpened(2), bob)).toBeNull();
     // The control: the same file, not moved, is readable at the base and shows the request.

package/src/modules/{workflow → version-control}/__tests__/file-lock.service.deletion-gate.test.ts

@@ -2,7 +2,7 @@ import { describe, it, expect, beforeEach } from 'vitest';
 import type { AuthUser } from '@bevel-software/platform-shared';
 import type { Database } from '../../database/connection.js';
 import { FileLockService } from '../file-lock.service.js';
-import { WorkflowValidationError } from '../../../shared/domain-errors.js';
+import { VersionControlValidationError } from '../../../shared/domain-errors.js';
 import { makeFakeLockDb, type FakeLockDb } from './fake-file-lock-db.js';
 
 /**
@@ -82,7 +82,7 @@ describe('FileLockService deletion gate', () => {
     await locks.whileNoneAcquired(BRANCH, async () => {
       refused = await locks.acquire(WS, BRANCH, PATH, ALICE).catch((err: unknown) => err);
     });
-    expect(refused).toBeInstanceOf(WorkflowValidationError);
+    expect(refused).toBeInstanceOf(VersionControlValidationError);
     expect(fake.rows()).toHaveLength(0);
     // And grants it again once the deletion is over.
     await expect(locks.acquire(WS, BRANCH, PATH, ALICE)).resolves.toMatchObject({ acquired: true });

package/src/modules/{workflow → version-control}/__tests__/file-lock.service.path-identity.test.ts

@@ -1,7 +1,7 @@
 import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest';
 import type { AuthUser } from '@bevel-software/platform-shared';
 import { FileLockService } from '../file-lock.service.js';
-import { PathTraversalError, WorkflowValidationError } from '../../../shared/domain-errors.js';
+import { PathTraversalError, VersionControlValidationError } from '../../../shared/domain-errors.js';
 import { makeFakeLockDb, type FakeLockDb, type LockRow } from './fake-file-lock-db.js';
 
 /**
@@ -127,12 +127,12 @@ describe('FileLockService coordinates on one canonical path', () => {
    */
   describe('refuses a path the file verbs would refuse', () => {
     const REFUSED: [string, string, new () => Error][] = [
-      ['climbs out of the workspace', '../etc/passwd', WorkflowValidationError],
-      ['climbs out from inside', 'knowledge-base/../../etc/passwd', WorkflowValidationError],
-      ['launders back inside', 'knowledge-base/x/../y.md', WorkflowValidationError],
-      ['is a bare parent', '..', WorkflowValidationError],
-      ['is the current directory', '.', WorkflowValidationError],
-      ['uses backslashes', 'knowledge-base\\x\\a.md', WorkflowValidationError],
+      ['climbs out of the workspace', '../etc/passwd', VersionControlValidationError],
+      ['climbs out from inside', 'knowledge-base/../../etc/passwd', VersionControlValidationError],
+      ['launders back inside', 'knowledge-base/x/../y.md', VersionControlValidationError],
+      ['is a bare parent', '..', VersionControlValidationError],
+      ['is the current directory', '.', VersionControlValidationError],
+      ['uses backslashes', 'knowledge-base\\x\\a.md', VersionControlValidationError],
       ['is absolute', '/etc/passwd', PathTraversalError],
     ];
 
@@ -209,7 +209,7 @@ describe('FileLockService coordinates on one canonical path', () => {
 
     it('is not migrated or extended: its holder cannot heartbeat it by its old name', async () => {
       await expect(locks.heartbeat(WS, BRANCH, RAW, ALICE)).rejects.toBeInstanceOf(
-        WorkflowValidationError,
+        VersionControlValidationError,
       );
 
       // Not rewritten to the canonical key, and the TTL is its own.

package/src/modules/{workflow → version-control}/__tests__/merge-announces-tree.test.ts

@@ -1,17 +1,17 @@
 import { describe, it, expect, vi } from 'vitest';
 import { testKbContext } from '../../../__tests__/kb-context.js';
-import type { WorkflowEvent } from '@bevel-software/platform-shared';
+import type { VersionControlEvent } from '@bevel-software/platform-shared';
 
 import type { GitService } from '../git/git.service.js';
 import type { PullRequestService } from '../git/pull-request.service.js';
-import type { IReviewWorkflowService } from '../review-workflow/review-workflow.interface.js';
+import type { IChangeRequestReviewService } from '../change-request-review/change-request-review.interface.js';
 import type { WorkspaceService } from '../../workspace/workspace.service.js';
 import type { IAccessControl } from '../../access/access-control.interface.js';
 import type { FileLockService } from '../file-lock.service.js';
 import type { PendingCommitsService } from '../pending-commits.service.js';
-import type { WorkflowEventBus } from '../event-bus.js';
+import type { VersionControlEventBus } from '../event-bus.js';
 import type { Database } from '../../database/connection.js';
-import { WorkflowService } from '../workflow.service.js';
+import { VersionControlService } from '../version-control.service.js';
 import { openChangeGate } from '../../../__tests__/open-change-gate.js';
 
 /**
@@ -62,19 +62,19 @@ function makeSvc(
   opts: { base?: string; pullTreeChanged?: boolean; mergeThrows?: Error; pullThrows?: Error } = {},
 ) {
   const base = opts.base ?? TRUNK;
-  const events: WorkflowEvent[] = [];
+  const events: VersionControlEvent[] = [];
   const bus = {
-    emit: vi.fn((payload: WorkflowEvent) => {
+    emit: vi.fn((payload: VersionControlEvent) => {
       events.push(payload);
       return payload;
     }),
-  } as unknown as WorkflowEventBus;
+  } as unknown as VersionControlEventBus;
 
-  const reviewWorkflow = {
+  const changeRequestReview = {
     mergePr: opts.mergeThrows
       ? vi.fn().mockRejectedValue(opts.mergeThrows)
       : vi.fn().mockResolvedValue({ prNumber: 1, sha: 'merged-sha', mergedAt: 't' }),
-  } as unknown as IReviewWorkflowService;
+  } as unknown as IChangeRequestReviewService;
 
   const git = {
     fetch: vi.fn().mockResolvedValue(undefined),
@@ -99,11 +99,11 @@ function makeSvc(
     getWorkspacePath: vi.fn(async (id: string) => `/tmp/${id}`),
   } as unknown as WorkspaceService;
 
-  const svc = new WorkflowService(
+  const svc = new VersionControlService(
     {} as unknown as Database,
     git,
     prs,
-    reviewWorkflow,
+    changeRequestReview,
     workspaceService,
     noopAccessControl(),
     { acquire: vi.fn(), release: vi.fn() } as unknown as FileLockService,