@bevel-software/platform-core-backend 0.35.0 → 0.36.1

package/src/modules/{workflow → version-control}/event-bus.ts

@@ -1,7 +1,7 @@
 /**
- * In-process event bus that fans workflow state-change events out to
+ * In-process event bus that fans version-control state-change events out to
  * subscribed SSE sessions. The shape and scope rules live in
- * `@bevel-software/platform-shared/workflow/events.ts` — this module is the runtime that
+ * `@bevel-software/platform-shared/version-control/events.ts` — this module is the runtime that
  * makes them deliverable.
  *
  * **What this owns**
@@ -39,8 +39,8 @@
 import {
   isUserScoped,
   isWorkspaceScoped,
-  type WorkflowEvent,
-  type WorkflowEventPayload,
+  type VersionControlEvent,
+  type VersionControlEventPayload,
 } from '@bevel-software/platform-shared';
 import { logger } from '../../shared/logging.js';
 
@@ -60,7 +60,7 @@ const BUFFER_CAPACITY = 500;
  * stamped envelope + payload and SHOULD NOT throw — exceptions are caught
  * and logged so one misbehaving subscriber never blocks fan-out to the rest.
  */
-export type SubscriberPush = (event: WorkflowEvent) => void;
+export type SubscriberPush = (event: VersionControlEvent) => void;
 
 /**
  * Per-session subscription bookkeeping. `getFocusedWorkspaceIds` is a getter
@@ -96,11 +96,11 @@ function canonicalize(workspaceId: string): string {
   }
 }
 
-export class WorkflowEventBus {
+export class VersionControlEventBus {
   private nextId = 1;
-  private readonly buffer: WorkflowEvent[] = [];
+  private readonly buffer: VersionControlEvent[] = [];
   private readonly subscribers = new Map<string, Subscriber>();
-  private readonly emitListeners = new Set<(event: WorkflowEvent) => void>();
+  private readonly emitListeners = new Set<(event: VersionControlEvent) => void>();
 
   /**
    * Server-side tap: called for EVERY emitted event, before the per-session
@@ -111,7 +111,7 @@ export class WorkflowEventBus {
    * Best-effort like SSE dispatch: a throwing listener is logged, never
    * propagated to the emitter. Returns the unsubscribe.
    */
-  onEmit(listener: (event: WorkflowEvent) => void): () => void {
+  onEmit(listener: (event: VersionControlEvent) => void): () => void {
     this.emitListeners.add(listener);
     return () => this.emitListeners.delete(listener);
   }
@@ -122,8 +122,8 @@ export class WorkflowEventBus {
    * event so callers (e.g. tests, debug logs) can see what was actually
    * delivered.
    */
-  emit(payload: WorkflowEventPayload): WorkflowEvent {
-    const event: WorkflowEvent = {
+  emit(payload: VersionControlEventPayload): VersionControlEvent {
+    const event: VersionControlEvent = {
       id: this.nextId++,
       ts: new Date().toISOString(),
       ...payload,
@@ -165,7 +165,7 @@ export class WorkflowEventBus {
       // try/catch covers both the scope check (`matches` reaches into
       // `sub.getFocusedWorkspaceIds()`, which could throw if a bizarre
       // subscriber holds buggy state) and the dispatch itself, so
-      // workflow mutations stay successful even if a listener throws.
+      // version-control mutations stay successful even if a listener throws.
       // Callers can rely on `emit` never throwing, so they don't need
       // to wrap every emit call site in their own try/catch.
       try {
@@ -220,7 +220,7 @@ export class WorkflowEventBus {
    * is greater than `lastSeenId + 1` (i.e. we evicted events the client
    * needs to see).
    */
-  replayAfter(lastSeenId: number, sub: Pick<Subscriber, 'userId' | 'getFocusedWorkspaceIds'>): WorkflowEvent[] | null {
+  replayAfter(lastSeenId: number, sub: Pick<Subscriber, 'userId' | 'getFocusedWorkspaceIds'>): VersionControlEvent[] | null {
     // Empty buffer: a client that never saw anything (lastSeenId === 0) has
     // nothing to replay and the empty array is correct. A client that DID
     // see events (lastSeenId > 0) but reached an empty buffer means the
@@ -262,7 +262,7 @@ export class WorkflowEventBus {
    * that hasn't yet POSTed its focus gets no workspace events (correct —
    * we don't know what it cares about).
    */
-  private matches(event: WorkflowEvent, sub: Pick<Subscriber, 'userId' | 'getFocusedWorkspaceIds'>): boolean {
+  private matches(event: VersionControlEvent, sub: Pick<Subscriber, 'userId' | 'getFocusedWorkspaceIds'>): boolean {
     if (isWorkspaceScoped(event)) {
       const watched = sub.getFocusedWorkspaceIds();
       if (watched.length === 0) return false;

package/src/modules/{workflow → version-control}/events-delivery.ts

@@ -49,7 +49,7 @@
  * Nothing here changes what publishers emit; the rule only reads the event.
  */
 
-import type { ChangeRequest, WorkflowEvent } from '@bevel-software/platform-shared';
+import type { ChangeRequest, VersionControlEvent } from '@bevel-software/platform-shared';
 import { logger } from '../../shared/logging.js';
 import { workspaceIdForBranch } from '../../shared/workspace-id.js';
 import type { IAccessControl } from '../access/index.js';
@@ -100,14 +100,14 @@ export type ChangeRequestFacts = Pick<ChangeRequest, 'base' | 'authorId' | 'touc
  */
 export interface IEventDelivery {
   /** The event as `viewer` may receive it: itself, a redacted copy, or null. Never rejects. */
-  judge(event: WorkflowEvent, viewer: EventViewer): Promise<WorkflowEvent | null>;
+  judge(event: VersionControlEvent, viewer: EventViewer): Promise<VersionControlEvent | null>;
 }
 
 /** The deployment's `EventAccess`: the access service the file routes use, read in the server's own checkouts. */
 export function createEventAccess(deps: {
   accessControl: Pick<IAccessControl, 'canRead' | 'canReadBatch' | 'canReadBatchAtRef'>;
   kbDirName: string;
-  /** `IWorkflowService.getChangeRequest`: the summary the request list judges, files included. */
+  /** `IVersionControlService.getChangeRequest`: the summary the request list judges, files included. */
   getChangeRequest(number: number): Promise<ChangeRequestFacts | null>;
   workspaces: {
     /** Whether the server holds a checkout for `workspaceId` (the branch's own workspace). */
@@ -172,10 +172,10 @@ export function createEventAccess(deps: {
  * null for nothing at all.
  */
 async function deliveryFor(
-  event: WorkflowEvent,
+  event: VersionControlEvent,
   viewer: EventViewer,
   access: EventAccess,
-): Promise<WorkflowEvent | null> {
+): Promise<VersionControlEvent | null> {
   const email = viewer.email;
   try {
     switch (event.kind) {
@@ -217,7 +217,7 @@ async function maySeeRequest(number: number, email: string, access: EventAccess)
   return maySeeChangeRequest({ readableFiles, isAuthor: false });
 }
 
-type GitSyncFailed = Extract<WorkflowEvent, { kind: 'git-sync-failed' }>;
+type GitSyncFailed = Extract<VersionControlEvent, { kind: 'git-sync-failed' }>;
 
 /**
  * Every path the event names is judged: the root, which git's words are about,
@@ -225,7 +225,7 @@ type GitSyncFailed = Extract<WorkflowEvent, { kind: 'git-sync-failed' }>;
  * words go out only when every one of them is readable; otherwise the person
  * keeps the conflicted files they may read and a fixed sentence.
  */
-async function gitSyncFailedFor(event: GitSyncFailed, email: string, access: EventAccess): Promise<WorkflowEvent> {
+async function gitSyncFailedFor(event: GitSyncFailed, email: string, access: EventAccess): Promise<VersionControlEvent> {
   const conflicted = event.conflictedPaths ?? [];
   const [root, ...each] = await Promise.all([
     access.mayReadRepoPath(event.workspaceId, email, ''),
@@ -235,7 +235,7 @@ async function gitSyncFailedFor(event: GitSyncFailed, email: string, access: Eve
   return root && readable.length === conflicted.length ? event : redactGitSyncFailed(event, readable);
 }
 
-function pathOnWorkspace(event: WorkflowEvent): { workspaceId: string; path: string } | null {
+function pathOnWorkspace(event: VersionControlEvent): { workspaceId: string; path: string } | null {
   const e = event as { workspaceId?: unknown; path?: unknown };
   return typeof e.workspaceId === 'string' && typeof e.path === 'string'
     ? { workspaceId: e.workspaceId, path: e.path }
@@ -246,7 +246,7 @@ function pathOnWorkspace(event: WorkflowEvent): { workspaceId: string; path: str
  * Same shape, so a client parses it as before: git's words are gone, and of
  * the conflicted files only `readable` remain (none, the key absent).
  */
-function redactGitSyncFailed(event: GitSyncFailed, readable: string[]): WorkflowEvent {
+function redactGitSyncFailed(event: GitSyncFailed, readable: string[]): VersionControlEvent {
   const redacted: GitSyncFailed = { ...event, reason: GIT_SYNC_FAILED_REDACTED_REASON };
   if (readable.length > 0) redacted.conflictedPaths = readable;
   else delete redacted.conflictedPaths;
@@ -261,11 +261,11 @@ function redactGitSyncFailed(event: GitSyncFailed, readable: string[]): Workflow
  * delivered decides what the replay carries.
  */
 export class EventDelivery implements IEventDelivery {
-  private readonly inFlight = new Map<string, Promise<WorkflowEvent | null>>();
+  private readonly inFlight = new Map<string, Promise<VersionControlEvent | null>>();
 
   constructor(private readonly access: EventAccess) {}
 
-  judge(event: WorkflowEvent, viewer: EventViewer): Promise<WorkflowEvent | null> {
+  judge(event: VersionControlEvent, viewer: EventViewer): Promise<VersionControlEvent | null> {
     const key = `${event.id}\u0000${event.ts}\u0000${viewer.userId}`;
     const pending = this.inFlight.get(key);
     if (pending) return pending;

package/src/modules/{workflow → version-control}/events.routes.ts

@@ -44,8 +44,8 @@ import { logger } from '../../shared/logging.js';
 
 const log = logger('events');
 import express from 'express';
-import { type WorkflowEvent } from '@bevel-software/platform-shared';
-import type { WorkflowEventBus } from './event-bus.js';
+import { type VersionControlEvent } from '@bevel-software/platform-shared';
+import type { VersionControlEventBus } from './event-bus.js';
 import type { IEventDelivery } from './events-delivery.js';
 import '../auth/index.js'; // Express Request augmentation
 
@@ -104,7 +104,7 @@ interface ActiveSession {
 }
 
 export function createEventsRoutes(
-  bus: WorkflowEventBus,
+  bus: VersionControlEventBus,
   authMiddleware: express.RequestHandler,
   delivery: IEventDelivery,
 ): express.Router {
@@ -178,7 +178,7 @@ export function createEventsRoutes(
 
     // Every event this session hears goes through the delivery rule, in the
     // order it arrived: the verdict is async, the stream must not reorder.
-    const push = (event: WorkflowEvent): void => {
+    const push = (event: VersionControlEvent): void => {
       if (session.closed) return;
       const verdict = delivery.judge(event, viewer);
       session.queue = session.queue.then(async () => {
@@ -312,7 +312,7 @@ export function createEventsRoutes(
  * Data is a single line of JSON — never embedded newlines, which would
  * break the SSE parser. JSON.stringify guarantees that.
  */
-function writeSseEvent(res: Response, event: WorkflowEvent): void {
+function writeSseEvent(res: Response, event: VersionControlEvent): void {
   res.write(`id: ${event.id}\n`);
   res.write(`data: ${JSON.stringify(event)}\n\n`);
 }

package/src/modules/{workflow → version-control}/file-lock.service.ts

@@ -42,7 +42,7 @@
  * writing: a previous-version process never looks at a canonical row, so no
  * check here could make the two contend while both run. They never do — one
  * server process owns the workspaces directory (see `branchLifecycle` in the
- * workflow service; this service's deletion gate is in-process for the same
+ * version-control service; this service's deletion gate is in-process for the same
  * reason), and an upgrade stops the old process before the new one starts.
  *
  * There is no transition handling for rows written under a raw spelling
@@ -61,7 +61,7 @@ import { and, eq, gt, inArray, lte } from 'drizzle-orm';
 import type { Database } from '../database/index.js';
 import { fileLocks } from '../database/index.js';
 import type { AcquireLockResult, AuthUser, FileLock } from '@bevel-software/platform-shared';
-import { WorkflowValidationError } from '../../shared/domain-errors.js';
+import { VersionControlValidationError } from '../../shared/domain-errors.js';
 import { canonicalFileIdentity } from '../../shared/canonical-file-identity.js';
 import { branchForWorkspaceId, canonicalWorkspaceId } from '../../shared/workspace-id.js';
 
@@ -152,7 +152,7 @@ export class FileLockService {
    *
    * `opts.coordination` stamps the row's `mode` as `'coordination'` — a
    * pure-mutex hold that grants no write authority (see
-   * `IWorkflowService.acquireLock`). The mode is persisted so the workflow
+   * `IVersionControlService.acquireLock`). The mode is persisted so the version-control
    * service's write paths can refuse to treat the hold as write possession
    * for the row's whole lifetime; a takeover of an expired row re-stamps the
    * mode, so a stale coordination row can't launder a later edit acquire
@@ -168,7 +168,7 @@ export class FileLockService {
     const targetPath = canonicalFileIdentity(rawPath);
     const workspaceId = canonicalWorkspaceId(rawWorkspaceId);
     if (this.closing.has(branch)) {
-      throw new WorkflowValidationError(`"${branch}" is being deleted, so "${targetPath}" cannot be held for editing.`, {
+      throw new VersionControlValidationError(`"${branch}" is being deleted, so "${targetPath}" cannot be held for editing.`, {
         kind: 'branch-being-deleted',
         branch,
         path: targetPath,
@@ -294,7 +294,7 @@ export class FileLockService {
       )
       .limit(1);
     if (!holder) {
-      throw new WorkflowValidationError(
+      throw new VersionControlValidationError(
         `Lock contention race on "${targetPath}" — please retry.`,
         { kind: 'lock-contention-race', branch, path: targetPath },
       );
@@ -343,7 +343,7 @@ export class FileLockService {
       )
       .returning();
     if (!updated) {
-      throw new WorkflowValidationError(
+      throw new VersionControlValidationError(
         `Cannot heartbeat lock on "${targetPath}": not held by you (or no longer exists).`,
         { kind: 'lock-not-held', branch, path: targetPath },
       );

package/src/modules/{workflow → version-control}/git/__tests__/git-test-helpers.ts

@@ -1,7 +1,7 @@
 import { execFile } from 'node:child_process';
 import { promisify } from 'node:util';
 import type { WorkspaceService } from '../../../workspace/workspace.service.js';
-import { WorkflowHooks } from '../../workflow-hooks.js';
+import { VersionControlHooks } from '../../version-control-hooks.js';
 
 /**
  * Helpers shared by the GitService integration suites that drive a real git
@@ -31,8 +31,8 @@ export async function gitOut(cwd: string, args: string[]): Promise<string> {
 }
 
 /** An empty hooks registry — no commit-time validation, so pulls/merges never block. */
-export function stubWorkflowHooks(): WorkflowHooks {
-  return new WorkflowHooks();
+export function stubVersionControlHooks(): VersionControlHooks {
+  return new VersionControlHooks();
 }
 
 /** Resolves each workspace id to its directory, like the real service does. */

package/src/modules/{workflow → version-control}/git/__tests__/git.service.accessGating.test.ts

@@ -7,7 +7,7 @@ import path from 'node:path';
 import os from 'node:os';
 
 import type { WorkspaceService } from '../../../workspace/workspace.service.js';
-import { WorkflowHooks } from '../../workflow-hooks.js';
+import { VersionControlHooks } from '../../version-control-hooks.js';
 import type { IAccessControl } from '../../../access/access-control.interface.js';
 import { GitService } from '../git.service.js';
 import { AccessDeniedError } from '../../../access-model/access-errors.js';
@@ -140,7 +140,7 @@ async function makeSvc(
   const { workspaceDir, repo } = await seedWorkspace(root, workspaceId);
   const svc = new GitService(
     stubWorkspaceService(workspaceId, workspaceDir),
-    new WorkflowHooks(),
+    new VersionControlHooks(),
     testKbContext(),
     undefined,
     ac ?? null,
@@ -262,7 +262,7 @@ describe('GitService — push gate uses origin/<branch> (not HEAD or working tre
     const { ac, calls } = recordingAccessControl();
     const svc = new GitService(
       stubWorkspaceService(workspaceId, workspaceDir),
-      new WorkflowHooks(),
+      new VersionControlHooks(),
       testKbContext(),
       undefined,
       ac,
@@ -306,7 +306,7 @@ describe('GitService — push gate uses origin/<branch> (not HEAD or working tre
     });
     const svc = new GitService(
       stubWorkspaceService(workspaceId, workspaceDir),
-      new WorkflowHooks(),
+      new VersionControlHooks(),
       testKbContext(),
       undefined,
       ac,
@@ -337,7 +337,7 @@ describe('GitService — push gate uses origin/<branch> (not HEAD or working tre
     });
     const svc = new GitService(
       stubWorkspaceService(workspaceId, workspaceDir),
-      new WorkflowHooks(),
+      new VersionControlHooks(),
       testKbContext(),
       undefined,
       ac,

package/src/modules/{workflow → version-control}/git/__tests__/git.service.appliedChange.test.ts

@@ -3,9 +3,9 @@ import fs from 'node:fs/promises';
 import path from 'node:path';
 import os from 'node:os';
 import { testKbContext } from '../../../../__tests__/kb-context.js';
-import { WorkflowHooks } from '../../workflow-hooks.js';
+import { VersionControlHooks } from '../../version-control-hooks.js';
 import { GitService } from '../git.service.js';
-import { WorkflowValidationError } from '../../../../shared/domain-errors.js';
+import { VersionControlValidationError } from '../../../../shared/domain-errors.js';
 import { mergeCommitSubject } from '../merge-commit.js';
 import { runGit, gitOut, stubWorkspaceService } from './git-test-helpers.js';
 
@@ -78,7 +78,7 @@ describe('GitService reading an applied change from its merge commit', () => {
 
     git = new GitService(
       stubWorkspaceService({ [workspaceId]: path.dirname(repo) }),
-      new WorkflowHooks(),
+      new VersionControlHooks(),
       testKbContext(),
     );
     return { mergeSha, targetBefore, sourceTip };
@@ -234,7 +234,7 @@ describe('GitService reading an applied change from its merge commit', () => {
       () => git.changedPathsAndPairsOfAppliedChange(workspaceId, ref(absent)),
       () => git.appliedChangeShas(workspaceId, ref(absent)),
     ]) {
-      await expect(call()).rejects.toThrow(WorkflowValidationError);
+      await expect(call()).rejects.toThrow(VersionControlValidationError);
     }
   });
 

package/src/modules/{workflow → version-control}/git/__tests__/git.service.changedFilesForPr.test.ts

@@ -6,7 +6,7 @@ import fs from 'node:fs/promises';
 import path from 'node:path';
 import os from 'node:os';
 import type { WorkspaceService } from '../../../workspace/workspace.service.js';
-import { WorkflowHooks } from '../../workflow-hooks.js';
+import { VersionControlHooks } from '../../version-control-hooks.js';
 import { GitService, parseNameStatusZ, parseNumstatZ, withoutPlaceholderRename } from '../git.service.js';
 import { WorkspaceMutex } from '../../../kb-fs/mutex.js';
 
@@ -127,7 +127,7 @@ describe('GitService.changedFilesForPr / resolvePrShas', () => {
 
     const git = new GitService(
       stubWorkspaceService(workspaceId, repo),
-      new WorkflowHooks(),
+      new VersionControlHooks(),
       testKbContext(),
     );
 
@@ -174,7 +174,7 @@ describe('GitService.changedFilesForPr / resolvePrShas', () => {
 
     const git = new GitService(
       stubWorkspaceService(workspaceId, repo),
-      new WorkflowHooks(),
+      new VersionControlHooks(),
       testKbContext(),
     );
     // What the detail does first: resolve (and fetch) the two SHAs.
@@ -226,7 +226,7 @@ describe('GitService.changedFilesForPr / resolvePrShas', () => {
 
     const git = new GitService(
       stubWorkspaceService(workspaceId, repo),
-      new WorkflowHooks(),
+      new VersionControlHooks(),
       testKbContext(),
     );
 
@@ -264,7 +264,7 @@ describe('GitService.changedFilesForPr / resolvePrShas', () => {
     await runGit(repo, ['commit', '-m', 'folders']);
     await runGit(repo, ['push', '-u', 'origin', 'alice/new-folders']);
 
-    const git = new GitService(stubWorkspaceService(workspaceId, repo), new WorkflowHooks(), testKbContext());
+    const git = new GitService(stubWorkspaceService(workspaceId, repo), new VersionControlHooks(), testKbContext());
 
     const files = await git.changedFilesForPr(workspaceId, 'current-company-state', 'alice/new-folders');
     expect(files.map((f) => f.path)).toEqual(['Reports/q3.md']);
@@ -293,7 +293,7 @@ describe('GitService.changedFilesForPr / resolvePrShas', () => {
     await runGit(repo, ['commit', '-m', 'emptied']);
     await runGit(repo, ['push', '-u', 'origin', 'alice/emptied']);
 
-    const git = new GitService(stubWorkspaceService(workspaceId, repo), new WorkflowHooks(), testKbContext());
+    const git = new GitService(stubWorkspaceService(workspaceId, repo), new VersionControlHooks(), testKbContext());
 
     const files = await git.changedFilesForPr(workspaceId, 'current-company-state', 'alice/emptied');
     expect(files.map((f) => ({ path: f.path, status: f.status, previousPath: f.previousPath }))).toEqual([
@@ -306,7 +306,7 @@ describe('GitService.changedFilesForPr / resolvePrShas', () => {
 
   it('pathExistsAtRef answers for files and folders at a ref, and false for what is not there', async () => {
     const { repo } = await seedWorkspace(root, workspaceId);
-    const git = new GitService(stubWorkspaceService(workspaceId, repo), new WorkflowHooks(), testKbContext());
+    const git = new GitService(stubWorkspaceService(workspaceId, repo), new VersionControlHooks(), testKbContext());
     await fs.mkdir(path.join(repo, 'Docs'));
     await fs.writeFile(path.join(repo, 'Docs/.gitkeep'), '');
     await runGit(repo, ['add', '-A']);
@@ -336,7 +336,7 @@ describe('GitService.changedFilesForPr / resolvePrShas', () => {
 
     const git = new GitService(
       stubWorkspaceService(workspaceId, repo),
-      new WorkflowHooks(),
+      new VersionControlHooks(),
       testKbContext(),
     );
 
@@ -417,7 +417,7 @@ describe('GitService.changedPathsForPr: who pays for the fetch', () => {
     await pushedElsewhere(upstream, 'brief.pdf');
     const git = new GitService(
       stubWorkspaceService(workspaceId, repo),
-      new WorkflowHooks(),
+      new VersionControlHooks(),
       testKbContext(),
     );
     expect(
@@ -430,7 +430,7 @@ describe('GitService.changedPathsForPr: who pays for the fetch', () => {
     const other = await pushedElsewhere(upstream, 'brief.pdf');
     const git = new GitService(
       stubWorkspaceService(workspaceId, repo),
-      new WorkflowHooks(),
+      new VersionControlHooks(),
       testKbContext(),
     );
     // The clone now knows the branch — this stands in for the one fetch a
@@ -467,7 +467,7 @@ describe('GitService.changedPathsForPr: who pays for the fetch', () => {
     await pushedElsewhere(upstream, 'brief.pdf');
     const git = new GitService(
       stubWorkspaceService(workspaceId, repo),
-      new WorkflowHooks(),
+      new VersionControlHooks(),
       testKbContext(),
     );
     // Nothing has refreshed this clone since the branch was pushed.
@@ -505,7 +505,7 @@ describe('GitService.changedPathsForPr: who pays for the fetch', () => {
     }
     const git = new GitService(
       stubWorkspaceService(workspaceId, repo),
-      new WorkflowHooks(),
+      new VersionControlHooks(),
       testKbContext(),
       new PrunedMidCall(),
     );
@@ -567,7 +567,7 @@ describe('GitService.changedPathsAndPairsForPr agrees with changedFilesForPr', (
     await runGit(repo, ['commit', '-m', 'move it']);
     await runGit(repo, ['push', '-u', 'origin', 'alice/moved']);
 
-    const git = new GitService(stubWorkspaceService(workspaceId, repo), new WorkflowHooks(), testKbContext());
+    const git = new GitService(stubWorkspaceService(workspaceId, repo), new VersionControlHooks(), testKbContext());
     const { detail, summary, paths } = await bothViews(git, 'alice/moved');
 
     expect(summary).toEqual(['GTM/note.md<=Engineering/note.md']);
@@ -593,7 +593,7 @@ describe('GitService.changedPathsAndPairsForPr agrees with changedFilesForPr', (
     await runGit(repo, ['commit', '-m', 'mixed']);
     await runGit(repo, ['push', '-u', 'origin', 'alice/mixed']);
 
-    const git = new GitService(stubWorkspaceService(workspaceId, repo), new WorkflowHooks(), testKbContext());
+    const git = new GitService(stubWorkspaceService(workspaceId, repo), new VersionControlHooks(), testKbContext());
     const { detail, summary } = await bothViews(git, 'alice/mixed');
     expect(summary).toEqual(detail);
     expect(summary).toContain('new-home.md<=old-home.md');
@@ -610,7 +610,7 @@ describe('GitService.changedPathsAndPairsForPr agrees with changedFilesForPr', (
     await runGit(repo, ['commit', '-m', 'config + folder']);
     await runGit(repo, ['push', '-u', 'origin', 'alice/config']);
 
-    const git = new GitService(stubWorkspaceService(workspaceId, repo), new WorkflowHooks(), testKbContext());
+    const git = new GitService(stubWorkspaceService(workspaceId, repo), new VersionControlHooks(), testKbContext());
     const { detail, summary, paths } = await bothViews(git, 'alice/config');
     expect(summary).toEqual(['Reports/q3.md<=']);
     expect(summary).toEqual(detail);
@@ -633,7 +633,7 @@ describe('GitService.changedPathsAndPairsForPr agrees with changedFilesForPr', (
     await runGit(repo, ['commit', '-m', 'emptied']);
     await runGit(repo, ['push', '-u', 'origin', 'alice/emptied']);
 
-    const git = new GitService(stubWorkspaceService(workspaceId, repo), new WorkflowHooks(), testKbContext());
+    const git = new GitService(stubWorkspaceService(workspaceId, repo), new VersionControlHooks(), testKbContext());
     const { detail, summary } = await bothViews(git, 'alice/emptied');
     // `withoutPlaceholderRename` runs on both sides, so neither reports a
     // rename onto `.gitkeep` and neither loses the removed file.

package/src/modules/{workflow → version-control}/git/__tests__/git.service.changedPathsMemo.test.ts

@@ -6,7 +6,7 @@ import fs from 'node:fs/promises';
 import path from 'node:path';
 import os from 'node:os';
 import type { WorkspaceService } from '../../../workspace/workspace.service.js';
-import { WorkflowHooks } from '../../workflow-hooks.js';
+import { VersionControlHooks } from '../../version-control-hooks.js';
 import { GitService } from '../git.service.js';
 import { WorkspaceMutex } from '../../../kb-fs/mutex.js';
 
@@ -93,7 +93,7 @@ describe('a change request is diffed once per pair of commits', () => {
     } as unknown as WorkspaceService;
     svc = new GitService(
       workspace,
-      new WorkflowHooks(),
+      new VersionControlHooks(),
       testKbContext({ branchModel: { defaultBranch: 'main', protectedBranches: ['main'] } }),
       new WorkspaceMutex(),
     );

package/src/modules/{workflow → version-control}/git/__tests__/git.service.commitChanges.test.ts

@@ -6,7 +6,7 @@ import fs from 'node:fs/promises';
 import path from 'node:path';
 import os from 'node:os';
 import type { WorkspaceService } from '../../../workspace/workspace.service.js';
-import { WorkflowHooks } from '../../workflow-hooks.js';
+import { VersionControlHooks } from '../../version-control-hooks.js';
 import { GitService } from '../git.service.js';
 
 /**
@@ -49,11 +49,11 @@ function stubWorkspaceService(workspaceId: string, workspaceDir: string): Worksp
   } as unknown as WorkspaceService;
 }
 
-function makeValidator(): WorkflowHooks {
+function makeValidator(): VersionControlHooks {
   const report = { ok: true, mustFix: [], warnings: [], rawOutput: '' };
   // A clean-report commit-validation hook — the seam GitService consults
   // where it used to call the injected validator.
-  const hooks = new WorkflowHooks();
+  const hooks = new VersionControlHooks();
   hooks.onCommitValidation(vi.fn(async () => report));
   return hooks;
 }

package/src/modules/{workflow → version-control}/git/__tests__/git.service.commitFile.strayPath.test.ts

@@ -7,9 +7,9 @@ import path from 'node:path';
 import os from 'node:os';
 import type { AuthUser } from '@bevel-software/platform-shared';
 import type { WorkspaceService } from '../../../workspace/workspace.service.js';
-import { WorkflowHooks } from '../../workflow-hooks.js';
+import { VersionControlHooks } from '../../version-control-hooks.js';
 import { GitService } from '../git.service.js';
-import { WorkflowValidationError } from '../../../../shared/domain-errors.js';
+import { VersionControlValidationError } from '../../../../shared/domain-errors.js';
 
 /**
  * `commitFile` on a path whose bytes sit BESIDE the repository.
@@ -87,14 +87,14 @@ describe('GitService.commitFile with bytes beside the repository', () => {
 
   it('throws instead of returning null when the file exists at the workspace root and not in the clone', async () => {
     const { workspaceDir, repo } = await seedWorkspace(root, workspaceId);
-    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), new WorkflowHooks(), testKbContext({ kbDirName: KB }));
+    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), new VersionControlHooks(), testKbContext({ kbDirName: KB }));
     // The prefix-less write the agent made: beside the clone, not inside it.
     await fs.mkdir(path.join(workspaceDir, 'KnowledgeBase/Reviews'), { recursive: true });
     await fs.writeFile(path.join(workspaceDir, 'KnowledgeBase/Reviews/PR-12.html'), '<p>review</p>');
     const headBefore = await runGit(repo, ['rev-parse', 'HEAD']);
 
     const attempt = svc.commitFile(workspaceId, USER, 'KnowledgeBase/Reviews/PR-12.html');
-    await expect(attempt).rejects.toBeInstanceOf(WorkflowValidationError);
+    await expect(attempt).rejects.toBeInstanceOf(VersionControlValidationError);
     await expect(attempt).rejects.toThrow('"knowledge-base/KnowledgeBase/Reviews/PR-12.html"');
 
     // Nothing landed, and the stray is left where it is for someone to recover.
@@ -104,19 +104,19 @@ describe('GitService.commitFile with bytes beside the repository', () => {
 
   it('still returns null for a clean, committed path (the honest no-op)', async () => {
     const { workspaceDir } = await seedWorkspace(root, workspaceId);
-    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), new WorkflowHooks(), testKbContext({ kbDirName: KB }));
+    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), new VersionControlHooks(), testKbContext({ kbDirName: KB }));
     expect(await svc.commitFile(workspaceId, USER, `${KB}/Knowledge/A.md`)).toBeNull();
   });
 
   it('still returns null for a path that exists nowhere (a queued re-apply of a committed deletion)', async () => {
     const { workspaceDir } = await seedWorkspace(root, workspaceId);
-    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), new WorkflowHooks(), testKbContext({ kbDirName: KB }));
+    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), new VersionControlHooks(), testKbContext({ kbDirName: KB }));
     expect(await svc.commitFile(workspaceId, USER, `${KB}/Knowledge/Gone.md`)).toBeNull();
   });
 
   it('still returns null for a repo-relative path that is clean inside the clone (the form internal callers pass)', async () => {
     const { workspaceDir } = await seedWorkspace(root, workspaceId);
-    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), new WorkflowHooks(), testKbContext({ kbDirName: KB }));
+    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), new VersionControlHooks(), testKbContext({ kbDirName: KB }));
     expect(await svc.commitFile(workspaceId, USER, 'Knowledge/A.md')).toBeNull();
   });
 
@@ -125,7 +125,7 @@ describe('GitService.commitFile with bytes beside the repository', () => {
     // a repo-relative caller's no-op stays honest whatever else sits beside
     // the clone under the same name.
     const { workspaceDir } = await seedWorkspace(root, workspaceId);
-    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), new WorkflowHooks(), testKbContext({ kbDirName: KB }));
+    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), new VersionControlHooks(), testKbContext({ kbDirName: KB }));
     await fs.mkdir(path.join(workspaceDir, 'Knowledge'), { recursive: true });
     await fs.writeFile(path.join(workspaceDir, 'Knowledge/A.md'), 'a copy beside the clone\n');
     expect(await svc.commitFile(workspaceId, USER, 'Knowledge/A.md')).toBeNull();
@@ -138,7 +138,7 @@ describe('GitService.commitFile with bytes beside the repository', () => {
     // toggles read-only, so the stat below still succeeds): nothing to prove.
     if (process.getuid?.() === 0 || process.platform === 'win32') return;
     const { workspaceDir } = await seedWorkspace(root, workspaceId);
-    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), new WorkflowHooks(), testKbContext({ kbDirName: KB }));
+    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), new VersionControlHooks(), testKbContext({ kbDirName: KB }));
     const strayDir = path.join(workspaceDir, 'KnowledgeBase');
     await fs.mkdir(strayDir, { recursive: true });
     await fs.writeFile(path.join(strayDir, 'PR-12.html'), 'x');
@@ -153,7 +153,7 @@ describe('GitService.commitFile with bytes beside the repository', () => {
 
   it('still commits a prefixed path inside the clone', async () => {
     const { workspaceDir, repo } = await seedWorkspace(root, workspaceId);
-    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), new WorkflowHooks(), testKbContext({ kbDirName: KB }));
+    const svc = new GitService(stubWorkspaceService(workspaceId, workspaceDir), new VersionControlHooks(), testKbContext({ kbDirName: KB }));
     await fs.writeFile(path.join(repo, 'Knowledge/B.md'), 'b\n');
     const committed = await svc.commitFile(workspaceId, USER, `${KB}/Knowledge/B.md`);
     expect(committed).not.toBeNull();