@bananapus/core-v6 0.0.36 → 0.0.38

package/test/units/static/JBController/TestMigrateController.sol

@@ -1,157 +0,0 @@
-// SPDX-License-Identifier: MIT
-pragma solidity 0.8.28;
-
-import {StdStorage, stdStorage} from "forge-std/StdStorage.sol";
-import {JBController} from "../../../../src/JBController.sol";
-import {IJBMigratable} from "../../../../src/interfaces/IJBMigratable.sol";
-import {IJBRulesetApprovalHook} from "../../../../src/interfaces/IJBRulesetApprovalHook.sol";
-import {IJBRulesets} from "../../../../src/interfaces/IJBRulesets.sol";
-import {JBConstants} from "../../../../src/libraries/JBConstants.sol";
-import {JBRulesetMetadataResolver} from "../../../../src/libraries/JBRulesetMetadataResolver.sol";
-import {JBRuleset} from "../../../../src/structs/JBRuleset.sol";
-import {JBRulesetMetadata} from "../../../../src/structs/JBRulesetMetadata.sol";
-import {IERC721} from "@openzeppelin/contracts/token/ERC721/IERC721.sol";
-import {JBControllerSetup} from "./JBControllerSetup.sol";
-
-contract TestMigrateController_Local is JBControllerSetup {
-    using stdStorage for StdStorage;
-
-    function setUp() public {
-        super.controllerSetup();
-    }
-
-    modifier whenCallerHasPermission() {
-        // mock ownerOf call
-        bytes memory _ownerOfCall = abi.encodeCall(IERC721.ownerOf, (1));
-        bytes memory _ownerData = abi.encode(address(this));
-
-        mockExpect(address(projects), _ownerOfCall, _ownerData);
-        _;
-    }
-
-    modifier migrationIsAllowedByRuleset() {
-        JBRulesetMetadata memory _metadata = JBRulesetMetadata({
-            reservedPercent: JBConstants.MAX_RESERVED_PERCENT / 2, //50%
-            cashOutTaxRate: JBConstants.MAX_CASH_OUT_TAX_RATE / 2, //50%
-            baseCurrency: uint32(uint160(JBConstants.NATIVE_TOKEN)),
-            pausePay: false,
-            pauseCreditTransfers: false,
-            allowOwnerMinting: false,
-            allowSetCustomToken: false,
-            allowTerminalMigration: false,
-            allowSetTerminals: false,
-            ownerMustSendPayouts: false,
-            allowSetController: true,
-            allowAddAccountingContext: true,
-            allowAddPriceFeed: false,
-            holdFees: false,
-            useTotalSurplusForCashOuts: true,
-            useDataHookForPay: false,
-            useDataHookForCashOut: false,
-            dataHook: address(0),
-            metadata: 0
-        });
-
-        uint256 _packedMetadata = JBRulesetMetadataResolver.packRulesetMetadata(_metadata);
-
-        // setup: return data
-        JBRuleset memory data = JBRuleset({
-            cycleNumber: 1,
-            id: uint48(block.timestamp),
-            basedOnId: 0,
-            start: uint48(block.timestamp),
-            duration: 0,
-            weight: 0,
-            weightCutPercent: 0,
-            approvalHook: IJBRulesetApprovalHook(address(0)),
-            metadata: _packedMetadata
-        });
-
-        // mock currentOf call
-        bytes memory _currentOfCall = abi.encodeCall(IJBRulesets.currentOf, (1));
-        bytes memory _returned = abi.encode(data);
-
-        mockExpect(address(rulesets), _currentOfCall, _returned);
-        _;
-    }
-
-    modifier migrationIsNotAllowedByRuleset() {
-        JBRulesetMetadata memory _metadata = JBRulesetMetadata({
-            reservedPercent: JBConstants.MAX_RESERVED_PERCENT / 2, //50%
-            cashOutTaxRate: JBConstants.MAX_CASH_OUT_TAX_RATE / 2, //50%
-            baseCurrency: uint32(uint160(JBConstants.NATIVE_TOKEN)),
-            pausePay: false,
-            pauseCreditTransfers: false,
-            allowOwnerMinting: false,
-            allowSetCustomToken: false,
-            allowTerminalMigration: false,
-            allowSetTerminals: false,
-            ownerMustSendPayouts: false,
-            allowSetController: true,
-            allowAddAccountingContext: true,
-            allowAddPriceFeed: false,
-            holdFees: false,
-            useTotalSurplusForCashOuts: true,
-            useDataHookForPay: false,
-            useDataHookForCashOut: false,
-            dataHook: address(0),
-            metadata: 0
-        });
-
-        uint256 _packedMetadata = JBRulesetMetadataResolver.packRulesetMetadata(_metadata);
-
-        // setup: return data
-        JBRuleset memory data = JBRuleset({
-            cycleNumber: 1,
-            id: uint48(block.timestamp),
-            basedOnId: 0,
-            start: uint48(block.timestamp),
-            duration: 0,
-            weight: 0,
-            weightCutPercent: 0,
-            approvalHook: IJBRulesetApprovalHook(address(0)),
-            metadata: _packedMetadata
-        });
-
-        // mock currentOf call
-        bytes memory _currentOfCall = abi.encodeCall(IJBRulesets.currentOf, (1));
-        bytes memory _returned = abi.encode(data);
-
-        mockExpect(address(rulesets), _currentOfCall, _returned);
-        _;
-    }
-
-    function test_Revert_When_Caller_Is_Not_Directory() external {
-        // it should revert
-
-        vm.expectRevert(
-            abi.encodeWithSelector(
-                JBController.JBController_OnlyDirectory.selector, address(this), _controller.DIRECTORY()
-            )
-        );
-        IJBMigratable(address(_controller)).migrate(1, IJBMigratable(address(this)));
-    }
-
-    function test_Revert_When_GivenReservedTokenBalanceIsPending() external {
-        // it should send reserved tokens to splits
-        // set storage since we can't mock internal calls
-        stdstore.target(address(IJBMigratable(address(_controller)))).sig("pendingReservedTokenBalanceOf(uint256)")
-            .with_key(uint256(1)).checked_write(uint256(100));
-
-        vm.prank(address(directory));
-
-        // Revert as expected, this functionality is no longer allowed since `JBController4_1`,
-        // Pending is send out as part of `beforeReceiveMigrationFrom`.
-        vm.expectRevert(abi.encodeWithSelector(JBController.JBController_PendingReservedTokens.selector, 100));
-        IJBMigratable(address(_controller)).migrate(1, IJBMigratable(address(this)));
-    }
-
-    function test_GivenNoReservedTokenBalanceIsPending() external {
-        // event as expected
-        vm.expectEmit();
-        emit IJBMigratable.Migrate(1, IJBMigratable(address(this)), address(directory));
-
-        vm.prank(address(directory));
-        IJBMigratable(address(_controller)).migrate(1, IJBMigratable(address(this)));
-    }
-}

package/test/units/static/JBController/TestMintTokensOfUnits.sol

@@ -1,111 +0,0 @@
-// SPDX-License-Identifier: MIT
-pragma solidity 0.8.28;
-
-import {JBController} from "../../../../src/JBController.sol";
-import {IJBDirectory} from "../../../../src/interfaces/IJBDirectory.sol";
-import {IJBRulesetApprovalHook} from "../../../../src/interfaces/IJBRulesetApprovalHook.sol";
-import {IJBRulesets} from "../../../../src/interfaces/IJBRulesets.sol";
-import {IJBTerminal} from "../../../../src/interfaces/IJBTerminal.sol";
-import {JBConstants} from "../../../../src/libraries/JBConstants.sol";
-import {JBRulesetMetadataResolver} from "../../../../src/libraries/JBRulesetMetadataResolver.sol";
-import {JBRuleset} from "../../../../src/structs/JBRuleset.sol";
-import {JBRulesetMetadata} from "../../../../src/structs/JBRulesetMetadata.sol";
-import {IERC721} from "@openzeppelin/contracts/token/ERC721/IERC721.sol";
-import {JBControllerSetup} from "./JBControllerSetup.sol";
-
-contract TestMintTokensOfUnits_Local is JBControllerSetup {
-    uint256 _projectId = 1;
-
-    function setUp() public {
-        super.controllerSetup();
-    }
-
-    function test_WhenNoRulesetIsActive() external {
-        // it should be able to mint
-    }
-
-    function test_MintNotAllowedSenderNotHookTerminalNorRulesetAllowsMint() external {
-        // mock call to JBProjects ownerOf which will give permission
-        bytes memory _projectsCall = abi.encodeCall(IERC721.ownerOf, (_projectId));
-        bytes memory _projectsCallReturn = abi.encode(address(this));
-        mockExpect(address(projects), _projectsCall, _projectsCallReturn);
-
-        // setup: return data
-        JBRulesetMetadata memory _metadata = JBRulesetMetadata({
-            reservedPercent: JBConstants.MAX_RESERVED_PERCENT / 2, //50%
-            cashOutTaxRate: JBConstants.MAX_CASH_OUT_TAX_RATE / 2, //50%
-            baseCurrency: uint32(uint160(JBConstants.NATIVE_TOKEN)),
-            pausePay: false,
-            pauseCreditTransfers: false,
-            allowOwnerMinting: false,
-            allowSetCustomToken: false,
-            allowTerminalMigration: false,
-            allowSetTerminals: false,
-            ownerMustSendPayouts: false,
-            allowSetController: false,
-            allowAddAccountingContext: true,
-            allowAddPriceFeed: false,
-            holdFees: false,
-            useTotalSurplusForCashOuts: true,
-            useDataHookForPay: false,
-            useDataHookForCashOut: false,
-            dataHook: address(0),
-            metadata: 0
-        });
-
-        uint256 _packedMetadata = JBRulesetMetadataResolver.packRulesetMetadata(_metadata);
-
-        JBRuleset memory data = JBRuleset({
-            cycleNumber: 1,
-            id: uint48(block.timestamp),
-            basedOnId: 0,
-            start: uint48(block.timestamp),
-            duration: 8000,
-            weight: 5000,
-            weightCutPercent: 0,
-            approvalHook: IJBRulesetApprovalHook(address(0x1234567890123456789012345678901234567890)),
-            metadata: _packedMetadata
-        });
-
-        // mock call to rulesets
-        mockExpect(address(rulesets), abi.encodeCall(IJBRulesets.currentOf, (_projectId)), abi.encode(data));
-
-        // mock call to isTerminalOf
-        mockExpect(
-            address(directory),
-            abi.encodeCall(IJBDirectory.isTerminalOf, (_projectId, IJBTerminal(address(this)))),
-            abi.encode(false)
-        );
-
-        vm.expectRevert(
-            abi.encodeWithSelector(JBController.JBController_MintNotAllowedAndNotTerminalOrHook.selector, address(this))
-        );
-
-        _controller.mintTokensOf({
-            projectId: _projectId, tokenCount: 1, beneficiary: address(this), memo: "", useReservedPercent: true
-        });
-    }
-
-    function test_RevertWhen_MintingIsDisabledInTheFundingCycleRuleset() external {
-        // it should revert
-    }
-
-    modifier whenMintingIsEnabledInTheFundingCycleRuleset() {
-        _;
-    }
-
-    function test_GivenThatThereAreTokensAvailableToMint() external whenMintingIsEnabledInTheFundingCycleRuleset {
-        // it should be possible to mint
-    }
-
-    function test_GivenThatADataSourceIsConfigured() external whenMintingIsEnabledInTheFundingCycleRuleset {
-        // it should be able to mint
-    }
-
-    function test_GivenThatADataSourceHasPermissionedAnotherContractToMint()
-        external
-        whenMintingIsEnabledInTheFundingCycleRuleset
-    {
-        // it should be able to mint
-    }
-}

package/test/units/static/JBController/TestOmnichainRulesetOperator.sol

@@ -1,324 +0,0 @@
-// SPDX-License-Identifier: MIT
-pragma solidity 0.8.28;
-
-import {JBController} from "../../../../src/JBController.sol";
-import {JBPermissioned} from "../../../../src/abstract/JBPermissioned.sol";
-import {IJBController} from "../../../../src/interfaces/IJBController.sol";
-import {IJBDirectory} from "../../../../src/interfaces/IJBDirectory.sol";
-import {IJBFundAccessLimits} from "../../../../src/interfaces/IJBFundAccessLimits.sol";
-import {IJBPermissions} from "../../../../src/interfaces/IJBPermissions.sol";
-import {IJBRulesetApprovalHook} from "../../../../src/interfaces/IJBRulesetApprovalHook.sol";
-import {IJBRulesets} from "../../../../src/interfaces/IJBRulesets.sol";
-import {IJBPrices} from "../../../../src/interfaces/IJBPrices.sol";
-import {IJBProjects} from "../../../../src/interfaces/IJBProjects.sol";
-import {IJBSplits} from "../../../../src/interfaces/IJBSplits.sol";
-import {IJBTokens} from "../../../../src/interfaces/IJBTokens.sol";
-import {JBConstants} from "../../../../src/libraries/JBConstants.sol";
-import {JBRulesetMetadataResolver} from "../../../../src/libraries/JBRulesetMetadataResolver.sol";
-import {JBCurrencyAmount} from "../../../../src/structs/JBCurrencyAmount.sol";
-import {JBFundAccessLimitGroup} from "../../../../src/structs/JBFundAccessLimitGroup.sol";
-import {JBRuleset} from "../../../../src/structs/JBRuleset.sol";
-import {JBRulesetConfig} from "../../../../src/structs/JBRulesetConfig.sol";
-import {JBRulesetMetadata} from "../../../../src/structs/JBRulesetMetadata.sol";
-import {JBSplitGroup} from "../../../../src/structs/JBSplitGroup.sol";
-import {JBTerminalConfig} from "../../../../src/structs/JBTerminalConfig.sol";
-import {JBPermissionIds} from "@bananapus/permission-ids-v6/src/JBPermissionIds.sol";
-import {IERC721} from "@openzeppelin/contracts/token/ERC721/IERC721.sol";
-import {IERC165} from "@openzeppelin/contracts/utils/introspection/ERC165.sol";
-import {JBTest} from "../../../helpers/JBTest.sol";
-
-/// @notice Tests the OMNICHAIN_RULESET_OPERATOR trust boundary — verifying the operator can bypass
-/// LAUNCH_RULESETS, SET_TERMINALS, and QUEUE_RULESETS permission checks via alsoGrantAccessIf.
-contract TestOmnichainRulesetOperator_Local is JBTest {
-    IJBController public _controller;
-
-    // Mocks
-    IJBPermissions public permissions = IJBPermissions(makeAddr("permissions"));
-    IJBDirectory public directory = IJBDirectory(makeAddr("directory"));
-    IJBRulesets public rulesets = IJBRulesets(makeAddr("rulesets"));
-    IJBSplits public splits = IJBSplits(makeAddr("splits"));
-    IJBFundAccessLimits public fundAccessLimits = IJBFundAccessLimits(makeAddr("limits"));
-
-    // Use makeAddr for projects so we can mock ERC721 calls
-    address public projectsAddr = makeAddr("projects");
-
-    address public operator = makeAddr("omnichainOperator");
-    address public projectOwner = makeAddr("projectOwner");
-    address public randomCaller = makeAddr("randomCaller");
-    uint256 public projectId = 1;
-
-    function setUp() public {
-        // Deploy controller with a non-zero OMNICHAIN_RULESET_OPERATOR
-        _controller = new JBController(
-            directory,
-            fundAccessLimits,
-            permissions,
-            IJBPrices(makeAddr("prices")),
-            IJBProjects(projectsAddr),
-            rulesets,
-            splits,
-            IJBTokens(makeAddr("tokens")),
-            operator,
-            makeAddr("forwarder")
-        );
-    }
-
-    // ── Helpers
-    // ──────────────────────────────────────────────────────────
-
-    function _genRulesetConfig() internal pure returns (JBTerminalConfig[] memory, JBRulesetConfig[] memory) {
-        JBTerminalConfig[] memory terminalConfigs = new JBTerminalConfig[](0);
-        JBRulesetConfig[] memory rulesetConfigs = new JBRulesetConfig[](1);
-
-        JBRulesetMetadata memory metadata = JBRulesetMetadata({
-            reservedPercent: 0,
-            cashOutTaxRate: 0,
-            baseCurrency: uint32(uint160(JBConstants.NATIVE_TOKEN)),
-            pausePay: false,
-            pauseCreditTransfers: false,
-            allowOwnerMinting: false,
-            allowSetCustomToken: false,
-            allowTerminalMigration: false,
-            allowSetTerminals: false,
-            ownerMustSendPayouts: false,
-            allowSetController: false,
-            allowAddAccountingContext: true,
-            allowAddPriceFeed: false,
-            holdFees: false,
-            useTotalSurplusForCashOuts: false,
-            useDataHookForPay: false,
-            useDataHookForCashOut: false,
-            dataHook: address(0),
-            metadata: 0
-        });
-
-        JBFundAccessLimitGroup[] memory limitGroups = new JBFundAccessLimitGroup[](1);
-        JBCurrencyAmount[] memory payoutLimits = new JBCurrencyAmount[](1);
-        payoutLimits[0] = JBCurrencyAmount({amount: 0, currency: uint32(uint160(JBConstants.NATIVE_TOKEN))});
-        JBCurrencyAmount[] memory surplusAllowances = new JBCurrencyAmount[](1);
-        surplusAllowances[0] = JBCurrencyAmount({amount: 0, currency: uint32(uint160(JBConstants.NATIVE_TOKEN))});
-        limitGroups[0] = JBFundAccessLimitGroup({
-            terminal: address(0),
-            token: JBConstants.NATIVE_TOKEN,
-            payoutLimits: payoutLimits,
-            surplusAllowances: surplusAllowances
-        });
-
-        rulesetConfigs[0].mustStartAtOrAfter = 0;
-        rulesetConfigs[0].duration = 0;
-        rulesetConfigs[0].weight = 0;
-        rulesetConfigs[0].weightCutPercent = 0;
-        rulesetConfigs[0].approvalHook = IJBRulesetApprovalHook(address(0));
-        rulesetConfigs[0].metadata = metadata;
-        rulesetConfigs[0].splitGroups = new JBSplitGroup[](0);
-        rulesetConfigs[0].fundAccessLimitGroups = limitGroups;
-
-        return (terminalConfigs, rulesetConfigs);
-    }
-
-    /// @dev Mock the full call chain for a successful launchRulesetsFor.
-    function _mockLaunchSuccess(JBRulesetConfig[] memory rulesetConfigs) internal {
-        uint48 ts = uint48(block.timestamp);
-
-        // ownerOf
-        vm.mockCall(projectsAddr, abi.encodeCall(IERC721.ownerOf, (projectId)), abi.encode(projectOwner));
-
-        // No existing rulesets
-        vm.mockCall(address(rulesets), abi.encodeCall(IJBRulesets.latestRulesetIdOf, (projectId)), abi.encode(0));
-
-        // setControllerOf
-        vm.mockCall(
-            address(directory),
-            abi.encodeCall(IJBDirectory.setControllerOf, (projectId, IERC165(address(_controller)))),
-            ""
-        );
-
-        // queueFor
-        JBRuleset memory ruleset = JBRuleset({
-            cycleNumber: 1,
-            id: ts,
-            basedOnId: 0,
-            start: ts,
-            duration: 0,
-            weight: 0,
-            weightCutPercent: 0,
-            approvalHook: IJBRulesetApprovalHook(address(0)),
-            metadata: 0
-        });
-        vm.mockCall(
-            address(rulesets),
-            abi.encodeCall(
-                IJBRulesets.queueFor,
-                (
-                    projectId,
-                    0,
-                    0,
-                    0,
-                    rulesetConfigs[0].approvalHook,
-                    JBRulesetMetadataResolver.packRulesetMetadata(rulesetConfigs[0].metadata),
-                    0
-                )
-            ),
-            abi.encode(ruleset)
-        );
-
-        // setSplitGroupsOf
-        vm.mockCall(
-            address(splits),
-            abi.encodeCall(IJBSplits.setSplitGroupsOf, (projectId, ts, rulesetConfigs[0].splitGroups)),
-            ""
-        );
-
-        // setFundAccessLimitsFor
-        vm.mockCall(
-            address(fundAccessLimits),
-            abi.encodeCall(
-                IJBFundAccessLimits.setFundAccessLimitsFor, (projectId, ts, rulesetConfigs[0].fundAccessLimitGroups)
-            ),
-            ""
-        );
-    }
-
-    /// @dev Mock the full call chain for a successful queueRulesetsOf.
-    function _mockQueueSuccess(JBRulesetConfig[] memory rulesetConfigs) internal {
-        uint48 ts = uint48(block.timestamp);
-
-        // ownerOf
-        vm.mockCall(projectsAddr, abi.encodeCall(IERC721.ownerOf, (projectId)), abi.encode(projectOwner));
-
-        // queueFor
-        JBRuleset memory ruleset = JBRuleset({
-            cycleNumber: 2,
-            id: ts,
-            basedOnId: 1,
-            start: ts,
-            duration: 0,
-            weight: 0,
-            weightCutPercent: 0,
-            approvalHook: IJBRulesetApprovalHook(address(0)),
-            metadata: 0
-        });
-        vm.mockCall(
-            address(rulesets),
-            abi.encodeCall(
-                IJBRulesets.queueFor,
-                (
-                    projectId,
-                    0,
-                    0,
-                    0,
-                    rulesetConfigs[0].approvalHook,
-                    JBRulesetMetadataResolver.packRulesetMetadata(rulesetConfigs[0].metadata),
-                    0
-                )
-            ),
-            abi.encode(ruleset)
-        );
-
-        // setSplitGroupsOf
-        vm.mockCall(
-            address(splits),
-            abi.encodeCall(IJBSplits.setSplitGroupsOf, (projectId, ts, rulesetConfigs[0].splitGroups)),
-            ""
-        );
-
-        // setFundAccessLimitsFor
-        vm.mockCall(
-            address(fundAccessLimits),
-            abi.encodeCall(
-                IJBFundAccessLimits.setFundAccessLimitsFor, (projectId, ts, rulesetConfigs[0].fundAccessLimitGroups)
-            ),
-            ""
-        );
-    }
-
-    // ── Tests
-    // ────────────────────────────────────────────────────────────
-
-    function test_operatorCanLaunchRulesetsWithoutPermission() external {
-        (JBTerminalConfig[] memory terminalConfigs, JBRulesetConfig[] memory rulesetConfigs) = _genRulesetConfig();
-        _mockLaunchSuccess(rulesetConfigs);
-
-        // Operator calls launchRulesetsFor without owning the project or having any permission grants.
-        // The alsoGrantAccessIf bypass should allow this.
-        vm.prank(operator);
-        _controller.launchRulesetsFor(projectId, rulesetConfigs, terminalConfigs, "");
-    }
-
-    function test_operatorCanQueueRulesetsWithoutPermission() external {
-        (, JBRulesetConfig[] memory rulesetConfigs) = _genRulesetConfig();
-        _mockQueueSuccess(rulesetConfigs);
-
-        // Operator calls queueRulesetsOf without owning the project or having any permission grants.
-        vm.prank(operator);
-        _controller.queueRulesetsOf(projectId, rulesetConfigs, "");
-    }
-
-    function test_nonOperatorCannotBypassPermissions() external {
-        (JBTerminalConfig[] memory terminalConfigs, JBRulesetConfig[] memory rulesetConfigs) = _genRulesetConfig();
-
-        // Mock ownerOf — randomCaller is not the owner
-        vm.mockCall(projectsAddr, abi.encodeCall(IERC721.ownerOf, (projectId)), abi.encode(projectOwner));
-
-        // Mock permission check — randomCaller has no permissions
-        vm.mockCall(
-            address(permissions),
-            abi.encodeCall(
-                IJBPermissions.hasPermission,
-                (randomCaller, projectOwner, projectId, JBPermissionIds.LAUNCH_RULESETS, true, true)
-            ),
-            abi.encode(false)
-        );
-
-        // Should revert for launchRulesetsFor
-        vm.prank(randomCaller);
-        vm.expectRevert(
-            abi.encodeWithSelector(
-                JBPermissioned.JBPermissioned_Unauthorized.selector,
-                projectOwner,
-                randomCaller,
-                projectId,
-                JBPermissionIds.LAUNCH_RULESETS
-            )
-        );
-        _controller.launchRulesetsFor(projectId, rulesetConfigs, terminalConfigs, "");
-
-        // Mock permission check for QUEUE_RULESETS — randomCaller has no permissions
-        vm.mockCall(
-            address(permissions),
-            abi.encodeCall(
-                IJBPermissions.hasPermission,
-                (randomCaller, projectOwner, projectId, JBPermissionIds.QUEUE_RULESETS, true, true)
-            ),
-            abi.encode(false)
-        );
-
-        // Should revert for queueRulesetsOf
-        vm.prank(randomCaller);
-        vm.expectRevert(
-            abi.encodeWithSelector(
-                JBPermissioned.JBPermissioned_Unauthorized.selector,
-                projectOwner,
-                randomCaller,
-                projectId,
-                JBPermissionIds.QUEUE_RULESETS
-            )
-        );
-        _controller.queueRulesetsOf(projectId, rulesetConfigs, "");
-    }
-
-    function test_operatorCannotLaunchIfRulesetsExist() external {
-        (JBTerminalConfig[] memory terminalConfigs, JBRulesetConfig[] memory rulesetConfigs) = _genRulesetConfig();
-
-        // Mock ownerOf
-        vm.mockCall(projectsAddr, abi.encodeCall(IERC721.ownerOf, (projectId)), abi.encode(projectOwner));
-
-        // Project already has rulesets
-        vm.mockCall(address(rulesets), abi.encodeCall(IJBRulesets.latestRulesetIdOf, (projectId)), abi.encode(1));
-
-        // Even the operator cannot launch if rulesets already exist
-        vm.prank(operator);
-        vm.expectRevert(abi.encodeWithSelector(JBController.JBController_RulesetsAlreadyLaunched.selector, projectId));
-        _controller.launchRulesetsFor(projectId, rulesetConfigs, terminalConfigs, "");
-    }
-}

package/test/units/static/JBController/TestPayReservedTokenToTerminal.sol

@@ -1,74 +0,0 @@
-// SPDX-License-Identifier: MIT
-pragma solidity 0.8.28;
-
-import {JBController} from "../../../../src/JBController.sol";
-import {IJBTerminal} from "../../../../src/interfaces/IJBTerminal.sol";
-import {IJBToken} from "../../../../src/interfaces/IJBToken.sol";
-import {IERC20} from "@openzeppelin/contracts/token/ERC20/IERC20.sol";
-import {JBControllerSetup} from "./JBControllerSetup.sol";
-
-contract TestExecutePayReservedTokenToTerminal_Local is JBControllerSetup {
-    uint256 _projectId = 1;
-    uint256 _defaultAmount = 1e18;
-    IJBTerminal _terminal = IJBTerminal(makeAddr("someTerminal"));
-    IJBToken _token = IJBToken(makeAddr("someToken"));
-    address _bene = makeAddr("beneficiary");
-
-    function setUp() public {
-        super.controllerSetup();
-    }
-
-    function test_WhenCallerIsNotItself() external {
-        // it will revert
-        vm.expectRevert();
-        JBController(address(_controller))
-            .executePayReservedTokenToTerminal(_terminal, _projectId, _token, _defaultAmount, _bene, "");
-    }
-
-    modifier whenCallerIsItself() {
-        // put code at token address for OZ Address check
-        vm.etch(address(_token), abi.encode(1));
-
-        vm.prank(address(_controller));
-        _;
-    }
-
-    function test_GivenAllowanceEQZeroAfterPay() external whenCallerIsItself {
-        // it will not revert
-
-        // mock pay call to some terminal
-        mockExpect(
-            address(_terminal),
-            abi.encodeCall(IJBTerminal.pay, (_projectId, address(_token), _defaultAmount, _bene, 0, "", "")),
-            abi.encode(0)
-        );
-
-        // mock the allowance assertion
-        mockExpect(
-            address(_token), abi.encodeCall(IERC20.allowance, (address(_controller), address(_terminal))), abi.encode(0)
-        );
-
-        JBController(address(_controller))
-            .executePayReservedTokenToTerminal(_terminal, _projectId, _token, _defaultAmount, _bene, "");
-    }
-
-    function test_GivenAllowanceDNEQZeroAfterPay() external whenCallerIsItself {
-        // it will revert
-
-        // mock pay call to some terminal
-        mockExpect(
-            address(_terminal),
-            abi.encodeCall(IJBTerminal.pay, (_projectId, address(_token), _defaultAmount, _bene, 0, "", "")),
-            abi.encode(0)
-        );
-
-        // mock the allowance assertion
-        mockExpect(
-            address(_token), abi.encodeCall(IERC20.allowance, (address(_controller), address(_terminal))), abi.encode(1)
-        );
-
-        vm.expectRevert();
-        JBController(address(_controller))
-            .executePayReservedTokenToTerminal(_terminal, _projectId, _token, _defaultAmount, _bene, "");
-    }
-}