@bananapus/core-v6 0.0.36 → 0.0.38

package/test/TestMetadataOffsetOverflow.sol

@@ -1,179 +0,0 @@
-// SPDX-License-Identifier: MIT
-pragma solidity 0.8.28;
-
-import {Test} from "forge-std/Test.sol";
-import {MetadataResolverHelper} from "./helpers/MetadataResolverHelper.sol";
-import {JBMetadataResolver} from "../src/libraries/JBMetadataResolver.sol";
-
-/// @notice Regression test for uint8 overflow in addToMetadata offset increment.
-///
-/// @dev    When `addToMetadata` grows the lookup table by one word, it increments every existing
-///         offset byte by 1. If any offset byte is already 255, the old code silently wrapped to 0,
-///         corrupting the lookup table. After the fix it must revert with
-///         `JBMetadataResolver_MetadataTooLong`.
-contract TestMetadataOffsetOverflow is Test {
-    MetadataResolverHelper parser;
-
-    function setUp() external {
-        parser = new MetadataResolverHelper();
-    }
-
-    /// @notice Build metadata whose existing offset byte is 255, then call `addToMetadata` so that
-    ///         the table must grow by one word. The offset increment (255 + 1) must revert.
-    function test_addToMetadata_offsetOverflow_reverts() external {
-        // We construct metadata by hand so that an existing offset byte equals 255.
-        //
-        // Layout:
-        //   [0..31]   32 bytes reserved (all zeros)
-        //   [32..36]  id1 (4 bytes) + offset1 (1 byte = 255)
-        //   [37..63]  padding (zeros) to fill the first lookup-table word
-        //
-        // For offset1 = 255, the "data" region notionally starts at byte 255*32 = 8160.
-        // We need originalMetadata.length >= 255*32 + 32 = 8192 so the library can compute
-        // `numberOfWordslastData` without underflow and the metadata looks structurally valid.
-        //
-        // The lookup table occupies word 1 (bytes 32..63), so firstOffset = 2 would be
-        // the normal case for a single entry fitting in one word. But we're forcing offset1 = 255
-        // to trigger the overflow.
-        //
-        // However, the code path that increments offsets only fires when the new entry does NOT
-        // fit in the current last table word (i + TOTAL_ID_SIZE >= firstOffset * WORD_SIZE).
-        // With one existing entry (5 bytes at position 32..36) and firstOffset derived from the
-        // first entry's offset byte, we need to ensure the table is full enough to trigger growth.
-        //
-        // Strategy: fill the lookup table so that it occupies exactly `firstOffset - 1` words
-        // (i.e. words 1 through firstOffset-1), and the last entry's position is near the end
-        // of that region. Then adding one more entry will overflow the table word, triggering
-        // the offset increment loop.
-        //
-        // Simpler approach: pack 6 entries into the table (6 * 5 = 30 bytes, which fills word 1
-        // almost completely at bytes 32..61). firstOffset comes from the first entry's offset byte.
-        // Set all 6 offset bytes to 255. The table ends at byte 61, and firstOffset = 255 means
-        // data starts at 255*32 = 8160. When we add entry 7, position 62 + 5 = 67 >= 255*32
-        // is false... so this won't trigger growth.
-        //
-        // The growth condition is `i + TOTAL_ID_SIZE >= firstOffset * WORD_SIZE` where i is the
-        // byte index of the last non-zero byte scanning backward from firstOffset*WORD_SIZE - 1.
-        // With firstOffset = 2, data starts at byte 64. 6 entries take bytes 32..61. The 7th
-        // entry would start at byte 62, and 62 + 5 = 67 >= 64, triggering growth. But we need
-        // offset = 255 to trigger overflow.
-        //
-        // The key insight: we need firstOffset to be small (so the table is nearly full and growth
-        // is triggered), but one of the EXISTING offset bytes to be 255.
-        //
-        // We can achieve this by:
-        //   - Having 6 entries in the table (30 bytes, nearly filling one 32-byte word)
-        //   - firstOffset = 2 (from the first entry, normal for 1 table word)
-        //   - The last entry has offset byte = 255
-        //   - We need enough data padding to make the metadata length consistent.
-        //
-        // Actually, the simplest approach: use createMetadata to build valid metadata with many
-        // entries so offsets are high, then manually patch an offset byte to 255. But that's
-        // fragile. Instead, let's hand-craft minimal metadata that triggers the exact code path.
-
-        // Minimal approach: 6 entries in lookup table, first offset = 2.
-        // Entry offsets: [2, 3, 4, 5, 6, 255]
-        // Data: 5 entries of 1 word each at offsets 2-6, plus a huge gap to offset 255.
-        // Total metadata length must be at least 255*32 + 32 = 8192.
-
-        bytes memory originalMetadata = new bytes(8192);
-
-        // Word 0 (bytes 0-31): reserved - leave as zeros.
-
-        // Word 1 (bytes 32-63): lookup table with 6 entries (30 bytes + 2 bytes padding).
-        // Entry 1: id=0x11111111, offset=2
-        originalMetadata[32] = 0x11;
-        originalMetadata[33] = 0x11;
-        originalMetadata[34] = 0x11;
-        originalMetadata[35] = 0x11;
-        originalMetadata[36] = bytes1(uint8(2)); // offset = 2
-
-        // Entry 2: id=0x22222222, offset=3
-        originalMetadata[37] = 0x22;
-        originalMetadata[38] = 0x22;
-        originalMetadata[39] = 0x22;
-        originalMetadata[40] = 0x22;
-        originalMetadata[41] = bytes1(uint8(3)); // offset = 3
-
-        // Entry 3: id=0x33333333, offset=4
-        originalMetadata[42] = 0x33;
-        originalMetadata[43] = 0x33;
-        originalMetadata[44] = 0x33;
-        originalMetadata[45] = 0x33;
-        originalMetadata[46] = bytes1(uint8(4)); // offset = 4
-
-        // Entry 4: id=0x44444444, offset=5
-        originalMetadata[47] = 0x44;
-        originalMetadata[48] = 0x44;
-        originalMetadata[49] = 0x44;
-        originalMetadata[50] = 0x44;
-        originalMetadata[51] = bytes1(uint8(5)); // offset = 5
-
-        // Entry 5: id=0x55555555, offset=6
-        originalMetadata[52] = 0x55;
-        originalMetadata[53] = 0x55;
-        originalMetadata[54] = 0x55;
-        originalMetadata[55] = 0x55;
-        originalMetadata[56] = bytes1(uint8(6)); // offset = 6
-
-        // Entry 6: id=0x66666666, offset=255 -- this is the one that will overflow
-        originalMetadata[57] = 0x66;
-        originalMetadata[58] = 0x66;
-        originalMetadata[59] = 0x66;
-        originalMetadata[60] = 0x66;
-        originalMetadata[61] = bytes1(uint8(255)); // offset = 255 -- will overflow on increment
-
-        // Bytes 62-63: padding (zeros) -- already zero.
-
-        // Fill some data at offset 2 (byte 64) through offset 6 (byte 224) so the structure
-        // is valid. Just leave as zeros (already initialized).
-
-        // Fill one word of data at offset 255 (byte 8160) to make numberOfWordslastData = 1.
-        // Just needs to exist in the allocation, which it does since length = 8192.
-        originalMetadata[8160] = 0xAB; // Some non-zero data.
-
-        // The new data to add (must be >= 32 bytes and padded to 32).
-        bytes memory dataToAdd = abi.encode(uint256(42));
-
-        // Now call addToMetadata. The code will:
-        // 1. Find firstOffset = 2 (from byte 36)
-        // 2. Scan backward from byte 63 to find the last non-zero byte: byte 61 (offset=255)
-        // 3. Check if new entry fits: 61 + 5 = 66 >= 2*32 = 64 => YES, table must grow
-        // 4. Loop to increment all offset bytes -- byte 61 has value 255, 255+1 overflows!
-        //
-        // Before the fix: wraps to 0 silently, corrupting the table.
-        // After the fix: reverts with JBMetadataResolver_MetadataTooLong.
-        vm.expectRevert(JBMetadataResolver.JBMetadataResolver_MetadataTooLong.selector);
-        parser.addDataToMetadata(originalMetadata, bytes4(0x77777777), dataToAdd);
-    }
-
-    /// @notice Sanity check: adding to metadata with offset < 255 still works after the fix.
-    function test_addToMetadata_offsetNoOverflow_succeeds() external view {
-        // Use the library normally: create metadata with a few entries, then add one more.
-        bytes4[] memory ids = new bytes4[](2);
-        bytes[] memory datas = new bytes[](2);
-
-        ids[0] = bytes4(0x11111111);
-        ids[1] = bytes4(0x22222222);
-        datas[0] = abi.encode(uint256(100));
-        datas[1] = abi.encode(uint256(200));
-
-        bytes memory metadata = parser.createMetadata(ids, datas);
-
-        // Add a third entry -- offsets are small, no overflow.
-        bytes memory modified = parser.addDataToMetadata(metadata, bytes4(0x33333333), abi.encode(uint256(300)));
-
-        // Verify all three entries are retrievable.
-        (bool found1, bytes memory data1) = parser.getDataFor(bytes4(0x11111111), modified);
-        assertTrue(found1);
-        assertEq(abi.decode(data1, (uint256)), 100);
-
-        (bool found2, bytes memory data2) = parser.getDataFor(bytes4(0x22222222), modified);
-        assertTrue(found2);
-        assertEq(abi.decode(data2, (uint256)), 200);
-
-        (bool found3, bytes memory data3) = parser.getDataFor(bytes4(0x33333333), modified);
-        assertTrue(found3);
-        assertEq(abi.decode(data3, (uint256)), 300);
-    }
-}

package/test/TestMetadataParserLib.sol

@@ -1,471 +0,0 @@
-// SPDX-License-Identifier: MIT
-pragma solidity 0.8.28;
-
-import {Test} from "forge-std/Test.sol";
-import {MetadataResolverHelper} from "./helpers/MetadataResolverHelper.sol";
-import {JBMetadataResolver} from "../src/libraries/JBMetadataResolver.sol";
-
-/**
- * @notice Test the `JBDelegateMetadata` library and helper contract.
- *
- * @dev    These are a mixed collection of unit and integration tests.
- */
-contract JBDelegateMetadataLib_Test_Local is Test {
-    MetadataResolverHelper parser;
-
-    /**
-     * @notice Deploy the helper contract.
-     *
-     * @dev    Helper inherits the lib and add `createMetadata`.
-     */
-    function setUp() external {
-        parser = new MetadataResolverHelper();
-    }
-
-    /**
-     * @notice Test the parsing of arbitrary metadata.
-     */
-    function test_parse() external view {
-        bytes4 _id1 = bytes4(0x11111111);
-        bytes4 _id2 = bytes4(0x33333333);
-
-        uint256 _data1 = 69_696_969;
-        bytes memory _data2 = new bytes(50);
-
-        bytes memory _metadata = abi.encodePacked(
-            // -- offset 0 --
-            bytes32(uint256(type(uint256).max)), // First 32B reserved
-            // -- offset 1 --
-            _id1, // First id
-            uint8(2), // First data offset == 2
-            _id2, // Second id == _id
-            uint8(3), // Second data offset == 3
-            bytes22(0), // Rest of the word is 0-padded
-            // -- offset 2 --
-            _data1, // First data
-            // -- offset 3 --
-            _data2 // Second data
-        );
-
-        (bool _found, bytes memory _dataParsed) = parser.getDataFor(_id2, _metadata);
-        assertEq(_dataParsed, _data2);
-        assertTrue(_found);
-
-        (_found, _dataParsed) = parser.getDataFor(_id1, _metadata);
-        assertEq(abi.decode(_dataParsed, (uint256)), _data1);
-        assertTrue(_found);
-    }
-
-    /**
-     * @notice Test creating and parsing bytes only metadata.
-     */
-    function test_createAndParse_bytes() external view {
-        bytes4[] memory _ids = new bytes4[](10);
-        bytes[] memory _datas = new bytes[](10);
-
-        for (uint256 _i; _i < _ids.length; _i++) {
-            // forge-lint: disable-next-line(unsafe-typecast)
-            _ids[_i] = bytes4(uint32(_i + 1 * 1000));
-            _datas[_i] = abi.encode(
-                // forge-lint: disable-next-line(unsafe-typecast)
-                bytes1(uint8(_i + 1)),
-                uint32(69),
-                // forge-lint: disable-next-line(unsafe-typecast)
-                bytes2(uint16(_i + 69)),
-                bytes32(uint256(type(uint256).max))
-            );
-        }
-
-        bytes memory _metadata = parser.createMetadata(_ids, _datas);
-
-        for (uint256 _i; _i < _ids.length; _i++) {
-            (bool _found, bytes memory _dataParsed) = parser.getDataFor(_ids[_i], _metadata);
-            (bytes1 _a, uint32 _deadBeef, bytes2 _c, bytes32 _d) =
-                abi.decode(_dataParsed, (bytes1, uint32, bytes2, bytes32));
-
-            assertTrue(_found);
-
-            assertEq(uint8(_a), _i + 1);
-            assertEq(uint256(_deadBeef), uint32(69));
-            assertEq(uint16(_c), _i + 69);
-            assertEq(_d, bytes32(uint256(type(uint256).max)));
-        }
-    }
-
-    /**
-     * @notice Test creating and parsing `uint`-only metadata.
-     */
-    function test_createAndParse_uint(uint256 _numberOfIds) external {
-        // Maximum 219 hooks with 1 word data (offset overflow if more).
-        _numberOfIds = bound(_numberOfIds, 1, 220);
-
-        bytes4[] memory _ids = new bytes4[](_numberOfIds);
-        bytes[] memory _datas = new bytes[](_numberOfIds);
-
-        for (uint256 _i; _i < _ids.length; _i++) {
-            // forge-lint: disable-next-line(unsafe-typecast)
-            _ids[_i] = bytes4(uint32(_i + 1 * 1000));
-            _datas[_i] = abi.encode(type(uint256).max - _i);
-        }
-
-        if (_numberOfIds == 220) vm.expectRevert(JBMetadataResolver.JBMetadataResolver_MetadataTooLong.selector);
-        bytes memory _metadata = parser.createMetadata(_ids, _datas);
-        if (_numberOfIds < 220) {
-            for (uint256 _i; _i < _ids.length; _i++) {
-                (bool _found, bytes memory _dataParsed) = parser.getDataFor(_ids[_i], _metadata);
-                uint256 _data = abi.decode(_dataParsed, (uint256));
-
-                assertTrue(_found);
-                assertEq(_data, type(uint256).max - _i);
-            }
-        }
-    }
-
-    /**
-     * @notice Test creating and parsing metadata of varying length.
-     */
-    function test_createAndParse_mixed(uint256 _numberOfIds) external view {
-        _numberOfIds = bound(_numberOfIds, 1, 15);
-
-        bytes4[] memory _ids = new bytes4[](_numberOfIds);
-        bytes[] memory _datas = new bytes[](_numberOfIds);
-
-        for (uint256 _i; _i < _ids.length; _i++) {
-            // forge-lint: disable-next-line(unsafe-typecast)
-            _ids[_i] = bytes4(uint32(_i + 1 * 1000));
-            // forge-lint: disable-next-line(incorrect-shift)
-            _datas[_i] = abi.encode(69 << _i * 20);
-        }
-
-        bytes memory _metadata = parser.createMetadata(_ids, _datas);
-
-        for (uint256 _i; _i < _ids.length; _i++) {
-            (bool _found, bytes memory _dataParsed) = parser.getDataFor(_ids[_i], _metadata);
-            uint256 _data = abi.decode(_dataParsed, (uint256));
-
-            assertTrue(_found);
-            // forge-lint: disable-next-line(incorrect-shift)
-            assertEq(_data, 69 << _i * 20);
-        }
-    }
-
-    /**
-     * @notice Test if `createMetadata` reverts when the offset would overflow.
-     */
-    function test_createRevertIfOffsetTooBig(uint256 _numberOfIds) external {
-        // Max 1000 for evm memory limit
-        _numberOfIds = bound(_numberOfIds, 221, 1000);
-
-        bytes4[] memory _ids = new bytes4[](_numberOfIds);
-        bytes[] memory _datas = new bytes[](_numberOfIds);
-
-        for (uint256 _i; _i < _ids.length; _i++) {
-            // forge-lint: disable-next-line(unsafe-typecast)
-            _ids[_i] = bytes4(uint32(_i + 1 * 1000));
-            _datas[_i] = abi.encode(type(uint256).max - _i);
-        }
-
-        vm.expectRevert(JBMetadataResolver.JBMetadataResolver_MetadataTooLong.selector);
-        parser.createMetadata(_ids, _datas);
-    }
-
-    /**
-     * @notice Test adding `uint` to an `uint` metadata.
-     */
-    function test_addToMetadata_uint(uint256 _numberOfIds) external view {
-        _numberOfIds = bound(_numberOfIds, 1, 219);
-
-        bytes4[] memory _ids = new bytes4[](_numberOfIds);
-        bytes[] memory _datas = new bytes[](_numberOfIds);
-
-        for (uint256 _i; _i < _ids.length; _i++) {
-            // forge-lint: disable-next-line(unsafe-typecast)
-            _ids[_i] = bytes4(uint32(_i + 1 * 1000));
-            _datas[_i] = abi.encode(type(uint256).max - _i);
-        }
-
-        bytes memory _metadata = parser.createMetadata(_ids, _datas);
-
-        bytes memory _modifiedMetadata =
-            parser.addDataToMetadata(_metadata, bytes4(uint32(type(uint32).max)), abi.encode(123_456));
-
-        // Check
-        (bool _found, bytes memory _dataParsed) = parser.getDataFor(bytes4(uint32(type(uint32).max)), _modifiedMetadata);
-        uint256 _data = abi.decode(_dataParsed, (uint256));
-
-        assertTrue(_found);
-        assertEq(_data, 123_456);
-
-        for (uint256 _i; _i < _ids.length; _i++) {
-            (_found, _dataParsed) = parser.getDataFor(_ids[_i], _modifiedMetadata);
-            _data = abi.decode(_dataParsed, (uint256));
-
-            assertTrue(_found);
-            assertEq(_data, type(uint256).max - _i);
-        }
-    }
-
-    /**
-     * @notice Test adding `bytes` to a `bytes` metadata.
-     */
-    function test_addToMetadata_bytes() public view {
-        bytes4[] memory _ids = new bytes4[](2);
-        bytes[] memory _datas = new bytes[](2);
-
-        for (uint256 _i; _i < _ids.length; _i++) {
-            // forge-lint: disable-next-line(unsafe-typecast)
-            _ids[_i] = bytes4(uint32(_i + 1 * 1000));
-            _datas[_i] = abi.encode(
-                // forge-lint: disable-next-line(unsafe-typecast)
-                bytes1(uint8(_i + 1)),
-                uint32(69),
-                // forge-lint: disable-next-line(unsafe-typecast)
-                bytes2(uint16(_i + 69)),
-                bytes32(uint256(type(uint256).max))
-            );
-        }
-
-        bytes memory _metadata = parser.createMetadata(_ids, _datas);
-
-        bytes memory _modifiedMetadata = parser.addDataToMetadata(
-            _metadata,
-            bytes4(uint32(type(uint32).max)),
-            // forge-lint: disable-next-line(unsafe-typecast)
-            abi.encode(bytes32(uint256(type(uint256).max)), bytes32(hex"123456"))
-        );
-
-        (bool _found, bytes memory _dataParsed) = parser.getDataFor(bytes4(uint32(type(uint32).max)), _modifiedMetadata);
-        (bytes32 _a, bytes32 _b) = abi.decode(_dataParsed, (bytes32, bytes32));
-
-        assertTrue(_found);
-        assertEq(bytes32(uint256(type(uint256).max)), _a);
-        // forge-lint: disable-next-line(unsafe-typecast)
-        assertEq(bytes32(hex"123456"), _b);
-
-        for (uint256 _i; _i < _ids.length; _i++) {
-            (_found, _dataParsed) = parser.getDataFor(_ids[_i], _modifiedMetadata);
-
-            (bytes1 _c, uint32 _d, bytes2 _e, bytes32 _f) = abi.decode(_dataParsed, (bytes1, uint32, bytes2, bytes32));
-
-            assertTrue(_found);
-            assertEq(uint8(_c), _i + 1);
-            assertEq(_d, uint32(69));
-            assertEq(uint16(_e), _i + 69);
-            assertEq(_f, bytes32(uint256(type(uint256).max)));
-        }
-    }
-
-    /**
-     * @notice Test adding `bytes` to an `uint` metadata.
-     */
-    function test_addToMetadata_mixed(uint256 _numberOfIds) external view {
-        _numberOfIds = bound(_numberOfIds, 1, 100);
-
-        bytes4[] memory _ids = new bytes4[](_numberOfIds);
-        bytes[] memory _datas = new bytes[](_numberOfIds);
-
-        for (uint256 _i; _i < _ids.length; _i++) {
-            // forge-lint: disable-next-line(unsafe-typecast)
-            _ids[_i] = bytes4(uint32(_i + 1 * 1000));
-            _datas[_i] = abi.encode(_i * 4);
-        }
-
-        bytes memory _metadata = parser.createMetadata(_ids, _datas);
-
-        bytes memory _modifiedMetadata = parser.addDataToMetadata(
-            _metadata, bytes4(uint32(type(uint32).max)), abi.encode(uint32(69), bytes32(uint256(type(uint256).max)))
-        );
-
-        (bool _found, bytes memory _dataParsed) = parser.getDataFor(bytes4(uint32(type(uint32).max)), _modifiedMetadata);
-        (uint32 _a, bytes32 _b) = abi.decode(_dataParsed, (uint32, bytes32));
-
-        assertTrue(_found);
-        assertEq(_a, uint32(69));
-        assertEq(_b, bytes32(uint256(type(uint256).max)));
-
-        for (uint256 _i; _i < _ids.length; _i++) {
-            (_found, _dataParsed) = parser.getDataFor(_ids[_i], _modifiedMetadata);
-            uint256 _data = abi.decode(_dataParsed, (uint256));
-
-            assertTrue(_found);
-            assertEq(_data, _i * 4);
-        }
-    }
-
-    /**
-     * @notice Test adding `bytes32` and `uint` to an empty metadata.
-     */
-    function test_addToMetadata_emptyInitialMetadata() external view {
-        bytes memory _metadata;
-
-        bytes memory _modifiedMetadata = parser.addDataToMetadata(
-            _metadata, bytes4(uint32(type(uint32).max)), abi.encode(uint32(69), bytes32(uint256(type(uint256).max)))
-        );
-
-        (bool _found, bytes memory _dataParsed) = parser.getDataFor(bytes4(uint32(type(uint32).max)), _modifiedMetadata);
-        (uint32 _a, bytes32 _b) = abi.decode(_dataParsed, (uint32, bytes32));
-
-        assertTrue(_found);
-        assertEq(_a, uint32(69));
-        assertEq(_b, bytes32(uint256(type(uint256).max)));
-    }
-
-    /**
-     * @notice Test adding `bytes32` and `uint` to a metadata which contains something in the first bytes32
-     */
-    function test_addToMetadata_preexistingMetadata(uint256 _reserved) external view {
-        bytes memory _metadata = abi.encode(_reserved);
-
-        bytes memory _modifiedMetadata = parser.addDataToMetadata(
-            _metadata, bytes4(uint32(type(uint32).max)), abi.encode(uint32(69), bytes32(uint256(type(uint256).max)))
-        );
-
-        (bool _found, bytes memory _dataParsed) = parser.getDataFor(bytes4(uint32(type(uint32).max)), _modifiedMetadata);
-        (uint32 _a, bytes32 _b) = abi.decode(_dataParsed, (uint32, bytes32));
-
-        assertTrue(_found);
-        assertEq(_a, uint32(69));
-        assertEq(_b, bytes32(uint256(type(uint256).max)));
-
-        // forge-lint: disable-next-line(unsafe-typecast)
-        assertEq(uint256(bytes32(_modifiedMetadata)), _reserved);
-    }
-
-    function test_addToMetadata_invalidExistingTable_reverts() public {
-        vm.expectRevert(JBMetadataResolver.JBMetadataResolver_MetadataTooShort.selector);
-
-        // Preexisting metadata: 32B + 4B
-        parser.addDataToMetadata(
-            abi.encodePacked(bytes32(uint256(type(uint256).max)), bytes4(uint32(type(uint32).max))),
-            bytes4(uint32(type(uint32).max)),
-            bytes("12345678901234567890123456789012345678901234567890123456789012345678901234567890")
-        );
-    }
-
-    function test_addToMetadata_shortDataToAdd_reverts() public {
-        vm.expectRevert(JBMetadataResolver.JBMetadataResolver_DataNotPadded.selector);
-
-        // Preexisting metadata: 32B + 4B
-        parser.addDataToMetadata(
-            abi.encodePacked(bytes32(uint256(type(uint256).max)), bytes8(uint64(type(uint64).max))),
-            bytes4(uint32(type(uint32).max)),
-            bytes("1234")
-        );
-    }
-
-    /**
-     * @notice Test behaviour if the ID is not found in the lookup table.
-     */
-    function test_idNotFound(uint256 _numberOfIds) public view {
-        _numberOfIds = bound(_numberOfIds, 1, 100);
-
-        bytes4[] memory _ids = new bytes4[](_numberOfIds);
-        bytes[] memory _datas = new bytes[](_numberOfIds);
-
-        for (uint256 _i; _i < _ids.length; _i++) {
-            // forge-lint: disable-next-line(unsafe-typecast)
-            _ids[_i] = bytes4(uint32(_i + 1 * 1000));
-            _datas[_i] = abi.encode(_i * 4);
-        }
-
-        bytes memory _metadata = parser.createMetadata(_ids, _datas);
-
-        (bool _found, bytes memory _dataParsed) = parser.getDataFor(bytes4(uint32(type(uint32).max)), _metadata);
-
-        assertFalse(_found);
-        assertEq(_dataParsed, "");
-    }
-
-    /**
-     * @notice Test behaviour if the metadata is empty or less than one ID long.
-     */
-    function test_emptyMetadata(uint256 _length) public view {
-        _length = bound(_length, 0, 37);
-
-        bytes memory _metadata;
-
-        // Fill with hex `F`.
-        _metadata = abi.encodePacked(bytes32(uint256(type(uint256).max)), bytes32(uint256(type(uint256).max)));
-
-        // Downsize to the length.
-        assembly {
-            mstore(_metadata, _length)
-        }
-
-        (bool _found, bytes memory _dataParsed) = parser.getDataFor(bytes4(uint32(type(uint32).max)), _metadata);
-
-        assertFalse(_found);
-        assertEq(_dataParsed, "");
-    }
-
-    function test_differentSizeIdAndMetadataArray_reverts(uint256 _numberOfIds, uint256 _numberOfMetadatas) public {
-        _numberOfIds = bound(_numberOfIds, 1, 100);
-        _numberOfMetadatas = bound(_numberOfMetadatas, 1, 100);
-
-        vm.assume(_numberOfIds != _numberOfMetadatas);
-
-        bytes4[] memory _ids = new bytes4[](_numberOfIds);
-        bytes[] memory _datas = new bytes[](_numberOfMetadatas);
-
-        for (uint256 _i; _i < _ids.length; _i++) {
-            // forge-lint: disable-next-line(unsafe-typecast)
-            _ids[_i] = bytes4(uint32(_i + 1 * 1000));
-        }
-
-        for (uint256 _i; _i < _datas.length; _i++) {
-            _datas[_i] = abi.encode(_i * 4);
-        }
-
-        // Below should revert.
-        vm.expectRevert(JBMetadataResolver.JBMetadataResolver_LengthMismatch.selector);
-        parser.createMetadata(_ids, _datas);
-    }
-
-    /**
-     * @notice Test creating and parsing metadata of incorrect length.
-     */
-    function test_create__unpadded() external {
-        bytes4[] memory _ids = new bytes4[](1);
-        bytes[] memory _datas = new bytes[](1);
-
-        uint8 something = uint8(1);
-        bytes memory shortData = abi.encodePacked(something);
-
-        _ids[0] = bytes4(uint32(1));
-        _datas[0] = shortData;
-
-        vm.expectRevert(JBMetadataResolver.JBMetadataResolver_DataNotPadded.selector);
-        parser.createMetadata(_ids, _datas);
-    }
-
-    /**
-     * @notice Test creating and parsing bytes only metadata.
-     */
-    function test_create_incorrect_data_length() external {
-        bytes4[] memory _ids = new bytes4[](10);
-        bytes[] memory _datas = new bytes[](10);
-
-        for (uint256 _i; _i < _ids.length; _i++) {
-            // forge-lint: disable-next-line(unsafe-typecast)
-            _ids[_i] = bytes4(uint32(_i + 1 * 1000));
-
-            // forge-lint: disable-next-line(unsafe-typecast)
-            _datas[_i] = abi.encodePacked(
-                // forge-lint: disable-next-line(unsafe-typecast)
-                bytes1(uint8(_i + 1)),
-                uint32(69),
-                // forge-lint: disable-next-line(unsafe-typecast)
-                bytes2(uint16(_i + 69)),
-                bytes32(uint256(type(uint256).max))
-            );
-        }
-
-        // Ensure data length is not multiple of word size and is gt word size.
-        assertGt(_datas[0].length, 32);
-        assertGt(_datas[0].length % 32, 0);
-
-        // New revert to help integrators.
-        vm.expectRevert(JBMetadataResolver.JBMetadataResolver_DataNotPadded.selector);
-        parser.createMetadata(_ids, _datas);
-    }
-}