@bananapus/core-v6 0.0.15 → 0.0.16

package/test/formal/FeeProperties.t.sol

@@ -1,7 +1,7 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.17;
 
-import "forge-std/Test.sol";
+import {Test} from "forge-std/Test.sol";
 import {JBFees} from "../../src/libraries/JBFees.sol";
 import {JBConstants} from "../../src/libraries/JBConstants.sol";
 
@@ -17,6 +17,7 @@ contract FeeProperties is Test {
     // =========================================================================
     /// @notice feeAmountFrom(a+b, fee) vs feeAmountFrom(a, fee) + feeAmountFrom(b, fee)
     ///         differ by at most 1 wei due to mulDiv rounding.
+    // forge-lint: disable-next-line(mixed-case-function)
     function check_fee_additivity(uint256 a, uint256 b, uint256 feePercent) public pure {
         vm.assume(a > 0 && b > 0);
         vm.assume(a <= type(uint128).max && b <= type(uint128).max);
@@ -53,6 +54,7 @@ contract FeeProperties is Test {
     /// @notice feeAmountResultingIn(netAmount, fee) >= feeAmountFrom(netAmount + feeAmountResultingIn(netAmount, fee),
     // fee) /         The reverse fee is always >= the forward fee on the gross amount, ensuring
     ///         the protocol never undercharges when returning held fees.
+    // forge-lint: disable-next-line(mixed-case-function)
     function check_fee_returnConsistency(uint256 netAmount, uint256 feePercent) public pure {
         vm.assume(netAmount > 0 && netAmount <= type(uint128).max);
         vm.assume(feePercent > 0 && feePercent < MAX_FEE);
@@ -91,6 +93,7 @@ contract FeeProperties is Test {
     ///         The overshoot is bounded by MAX_FEE / (MAX_FEE - feePercent): the rounding
     ///         error in fee1 (at most 1 wei of net) gets amplified by the fee ratio when
     ///         computing the reverse fee, plus 1 for the reverse mulDiv rounding itself.
+    // forge-lint: disable-next-line(mixed-case-function)
     function check_fee_roundTrip(uint256 amount, uint256 feePercent) public pure {
         vm.assume(amount > 0 && amount <= type(uint128).max);
         vm.assume(feePercent > 0 && feePercent < MAX_FEE);
@@ -133,6 +136,7 @@ contract FeeProperties is Test {
     // Property 4: Partial return monotonicity
     // =========================================================================
     /// @notice feeAmountResultingIn(a, fee) <= feeAmountResultingIn(b, fee) when a <= b.
+    // forge-lint: disable-next-line(mixed-case-function)
     function check_fee_partialReturnMonotonicity(uint256 a, uint256 b, uint256 feePercent) public pure {
         vm.assume(a > 0 && b > 0);
         vm.assume(a <= type(uint128).max && b <= type(uint128).max);
@@ -163,6 +167,7 @@ contract FeeProperties is Test {
     ///         fee = feeAmountFrom(heldFeeAmount, feePercent) <= heldFeeAmount.
     ///         This guarantees leftover = heldFeeAmount - fee never underflows, and
     ///         leftover + fee == heldFeeAmount (exact decomposition).
+    // forge-lint: disable-next-line(mixed-case-function)
     function check_fee_subtractionSafety(uint256 heldFeeAmount, uint256 feePercent) public pure {
         vm.assume(heldFeeAmount > 0 && heldFeeAmount <= type(uint128).max);
         vm.assume(feePercent > 0 && feePercent < MAX_FEE);
@@ -195,6 +200,7 @@ contract FeeProperties is Test {
     /// @notice After N splits each paying fee, total fee error vs single-payment fee
     ///         is bounded by N wei. For N=10: sum(feeAmountFrom(amount/N, fee), N times)
     ///         vs feeAmountFrom(amount, fee) differ by at most N.
+    // forge-lint: disable-next-line(mixed-case-function)
     function check_fee_multiSplitAccumulation(uint256 amount, uint256 feePercent) public pure {
         vm.assume(amount >= 10); // Must be divisible into 10 parts
         vm.assume(amount <= type(uint128).max);

package/test/helpers/JBTest.sol

@@ -6,7 +6,7 @@ import {JBRulesetMetadata} from "../../src/structs/JBRulesetMetadata.sol";
 import {JBRulesetMetadataResolver} from "../../src/libraries/JBRulesetMetadataResolver.sol";
 import {JBConstants} from "../../src/libraries/JBConstants.sol";
 import {IJBRulesetApprovalHook} from "../../src/interfaces/IJBRulesetApprovalHook.sol";
-import "lib/forge-std/src/Test.sol";
+import {Test} from "lib/forge-std/src/Test.sol";
 
 contract JBTest is Test {
     using JBRulesetMetadataResolver for JBRulesetMetadata;

package/test/helpers/TestBaseWorkflow.sol

@@ -1,18 +1,32 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.6;
 
-import "forge-std/Test.sol";
+// forge-lint: disable-next-line(unused-import)
+import {Test} from "forge-std/Test.sol";
+// forge-lint: disable-next-line(unused-import)
+import {StdStorage, stdStorage} from "forge-std/StdStorage.sol";
 
+// forge-lint: disable-next-line(unused-import)
 import {IERC721} from "@openzeppelin/contracts/token/ERC721/IERC721.sol";
+// forge-lint: disable-next-line(unused-import)
 import {IERC721Metadata} from "@openzeppelin/contracts/token/ERC721/extensions/IERC721Metadata.sol";
+// forge-lint: disable-next-line(unused-import)
 import {IERC20Metadata} from "@openzeppelin/contracts/token/ERC20/extensions/IERC20Metadata.sol";
+// forge-lint: disable-next-line(unused-import)
 import {IERC20Permit} from "@openzeppelin/contracts/token/ERC20/extensions/IERC20Permit.sol";
+// forge-lint: disable-next-line(unused-import)
 import {Clones} from "@openzeppelin/contracts/proxy/Clones.sol";
+// forge-lint: disable-next-line(unused-import)
 import {IERC20} from "@openzeppelin/contracts/token/ERC20/IERC20.sol";
+// forge-lint: disable-next-line(unused-import)
 import {Ownable} from "@openzeppelin/contracts/access/Ownable.sol";
+// forge-lint: disable-next-line(unused-import)
 import {ERC165, IERC165} from "@openzeppelin/contracts/utils/introspection/ERC165.sol";
+// forge-lint: disable-next-line(unused-import)
 import {JBPermissionIds} from "@bananapus/permission-ids-v6/src/JBPermissionIds.sol";
+// forge-lint: disable-next-line(unused-import)
 import {JBControlled} from "../../src/abstract/JBControlled.sol";
+// forge-lint: disable-next-line(unused-import)
 import {JBPermissioned} from "../../src/abstract/JBPermissioned.sol";
 import {JBController} from "../../src/JBController.sol";
 import {JBDirectory} from "../../src/JBDirectory.sol";
@@ -26,70 +40,132 @@ import {JBProjects} from "../../src/JBProjects.sol";
 import {JBSplits} from "../../src/JBSplits.sol";
 import {JBERC20} from "../../src/JBERC20.sol";
 import {JBTokens} from "../../src/JBTokens.sol";
+// forge-lint: disable-next-line(unused-import)
 import {JBDeadline} from "../../src/JBDeadline.sol";
+// forge-lint: disable-next-line(unused-import)
 import {JBApprovalStatus} from "../../src/enums/JBApprovalStatus.sol";
 import {JBMultiTerminal} from "../../src/JBMultiTerminal.sol";
+// forge-lint: disable-next-line(unused-import)
 import {JBAccountingContext} from "../../src/structs/JBAccountingContext.sol";
+// forge-lint: disable-next-line(unused-import)
 import {JBCurrencyAmount} from "../../src/structs/JBCurrencyAmount.sol";
+// forge-lint: disable-next-line(unused-import)
 import {JBAfterPayRecordedContext} from "../../src/structs/JBAfterPayRecordedContext.sol";
+// forge-lint: disable-next-line(unused-import)
 import {JBAfterCashOutRecordedContext} from "../../src/structs/JBAfterCashOutRecordedContext.sol";
+// forge-lint: disable-next-line(unused-import)
 import {JBFee} from "../../src/structs/JBFee.sol";
+// forge-lint: disable-next-line(unused-import)
 import {JBFees} from "../../src/libraries/JBFees.sol";
+// forge-lint: disable-next-line(unused-import)
 import {JBMetadataResolver} from "../../src/libraries/JBMetadataResolver.sol";
+// forge-lint: disable-next-line(unused-import)
 import {JBCashOuts} from "../../src/libraries/JBCashOuts.sol";
+// forge-lint: disable-next-line(unused-import)
 import {JBFundAccessLimitGroup} from "../../src/structs/JBFundAccessLimitGroup.sol";
+// forge-lint: disable-next-line(unused-import)
 import {JBRuleset} from "../../src/structs/JBRuleset.sol";
+// forge-lint: disable-next-line(unused-import)
 import {JBRulesetWithMetadata} from "../../src/structs/JBRulesetWithMetadata.sol";
+// forge-lint: disable-next-line(unused-import)
 import {JBRulesetMetadata} from "../../src/structs/JBRulesetMetadata.sol";
+// forge-lint: disable-next-line(unused-import)
 import {JBRulesetConfig} from "../../src/structs/JBRulesetConfig.sol";
+// forge-lint: disable-next-line(unused-import)
 import {JBSplitGroup} from "../../src/structs/JBSplitGroup.sol";
+// forge-lint: disable-next-line(unused-import)
 import {JBPermissionsData} from "../../src/structs/JBPermissionsData.sol";
+// forge-lint: disable-next-line(unused-import)
 import {JBBeforePayRecordedContext} from "../../src/structs/JBBeforePayRecordedContext.sol";
+// forge-lint: disable-next-line(unused-import)
 import {JBBeforeCashOutRecordedContext} from "../../src/structs/JBBeforeCashOutRecordedContext.sol";
+// forge-lint: disable-next-line(unused-import)
 import {JBSplit} from "../../src/structs/JBSplit.sol";
+// forge-lint: disable-next-line(unused-import)
 import {JBTerminalConfig} from "../../src/structs/JBTerminalConfig.sol";
+// forge-lint: disable-next-line(unused-import)
 import {JBPayHookSpecification} from "../../src/structs/JBPayHookSpecification.sol";
+// forge-lint: disable-next-line(unused-import)
 import {JBCashOutHookSpecification} from "../../src/structs/JBCashOutHookSpecification.sol";
+// forge-lint: disable-next-line(unused-import)
 import {JBTokenAmount} from "../../src/structs/JBTokenAmount.sol";
+// forge-lint: disable-next-line(unused-import)
 import {JBSplitHookContext} from "../../src/structs/JBSplitHookContext.sol";
+// forge-lint: disable-next-line(unused-import)
 import {IJBToken} from "../../src/interfaces/IJBToken.sol";
+// forge-lint: disable-next-line(unused-import)
 import {JBSingleAllowance} from "../../src/structs/JBSingleAllowance.sol";
+// forge-lint: disable-next-line(unused-import)
 import {IJBController} from "../../src/interfaces/IJBController.sol";
+// forge-lint: disable-next-line(unused-import)
 import {IJBFeelessAddresses} from "../../src/interfaces/IJBFeelessAddresses.sol";
+// forge-lint: disable-next-line(unused-import)
 import {IJBFundAccessLimits} from "../../src/interfaces/IJBFundAccessLimits.sol";
+// forge-lint: disable-next-line(unused-import)
 import {IJBMigratable} from "../../src/interfaces/IJBMigratable.sol";
+// forge-lint: disable-next-line(unused-import)
 import {IJBPermissions} from "../../src/interfaces/IJBPermissions.sol";
+// forge-lint: disable-next-line(unused-import)
 import {IJBDirectoryAccessControl} from "../../src/interfaces/IJBDirectoryAccessControl.sol";
+// forge-lint: disable-next-line(unused-import)
 import {IJBTerminalStore} from "../../src/interfaces/IJBTerminalStore.sol";
+// forge-lint: disable-next-line(unused-import)
 import {IJBProjects} from "../../src/interfaces/IJBProjects.sol";
+// forge-lint: disable-next-line(unused-import)
 import {IJBRulesetApprovalHook} from "../../src/interfaces/IJBRulesetApprovalHook.sol";
+// forge-lint: disable-next-line(unused-import)
 import {IJBDirectory} from "../../src/interfaces/IJBDirectory.sol";
+// forge-lint: disable-next-line(unused-import)
 import {IJBRulesets} from "../../src/interfaces/IJBRulesets.sol";
+// forge-lint: disable-next-line(unused-import)
 import {IJBSplits} from "../../src/interfaces/IJBSplits.sol";
+// forge-lint: disable-next-line(unused-import)
 import {IJBTokenUriResolver} from "../../src/interfaces/IJBTokenUriResolver.sol";
+// forge-lint: disable-next-line(unused-import)
 import {IJBTokens} from "../../src/interfaces/IJBTokens.sol";
+// forge-lint: disable-next-line(unused-import)
 import {IJBSplitHook} from "../../src/interfaces/IJBSplitHook.sol";
+// forge-lint: disable-next-line(unused-import)
 import {IJBPayHook} from "../../src/interfaces/IJBPayHook.sol";
+// forge-lint: disable-next-line(unused-import)
 import {IJBRulesetDataHook} from "../../src/interfaces/IJBRulesetDataHook.sol";
+// forge-lint: disable-next-line(unused-import)
 import {IJBCashOutHook} from "../../src/interfaces/IJBCashOutHook.sol";
+// forge-lint: disable-next-line(unused-import)
 import {IJBRulesetDataHook} from "../../src/interfaces/IJBRulesetDataHook.sol";
+// forge-lint: disable-next-line(unused-import)
 import {IJBMultiTerminal} from "../../src/interfaces/IJBMultiTerminal.sol";
+// forge-lint: disable-next-line(unused-import)
 import {IJBCashOutTerminal} from "../../src/interfaces/IJBCashOutTerminal.sol";
+// forge-lint: disable-next-line(unused-import)
 import {IJBPayoutTerminal} from "../../src/interfaces/IJBPayoutTerminal.sol";
+// forge-lint: disable-next-line(unused-import)
 import {IJBPermitTerminal} from "../../src/interfaces/IJBPermitTerminal.sol";
+// forge-lint: disable-next-line(unused-import)
 import {IJBFeeTerminal} from "../../src/interfaces/IJBFeeTerminal.sol";
+// forge-lint: disable-next-line(unused-import)
 import {IJBTerminal} from "../../src/interfaces/IJBTerminal.sol";
+// forge-lint: disable-next-line(unused-import)
 import {IJBPriceFeed} from "../../src/interfaces/IJBPriceFeed.sol";
+// forge-lint: disable-next-line(unused-import)
 import {IJBPermissioned} from "../../src/interfaces/IJBPermissioned.sol";
+// forge-lint: disable-next-line(unused-import)
 import {IJBProjectUriRegistry} from "../../src/interfaces/IJBProjectUriRegistry.sol";
+// forge-lint: disable-next-line(unused-import)
 import {IJBRulesetApprovalHook} from "../../src/interfaces/IJBRulesetApprovalHook.sol";
+// forge-lint: disable-next-line(unused-import)
 import {IJBPrices} from "../../src/interfaces/IJBPrices.sol";
 
+// forge-lint: disable-next-line(unused-import)
 import {JBConstants} from "../../src/libraries/JBConstants.sol";
+// forge-lint: disable-next-line(unused-import)
 import {JBCurrencyIds} from "../../src/libraries/JBCurrencyIds.sol";
+// forge-lint: disable-next-line(unused-import)
 import {JBRulesetMetadataResolver} from "../../src/libraries/JBRulesetMetadataResolver.sol";
+// forge-lint: disable-next-line(unused-import)
 import {JBSplitGroupIds} from "../../src/libraries/JBSplitGroupIds.sol";
 
+// forge-lint: disable-next-line(unused-import)
 import {IPermit2, IAllowanceTransfer} from "@uniswap/permit2/src/interfaces/IPermit2.sol";
 import {DeployPermit2} from "@uniswap/permit2/test/utils/DeployPermit2.sol";
 
@@ -98,7 +174,9 @@ import {JBTest} from "./JBTest.sol";
 
 import {MockERC20} from "./../mock/MockERC20.sol";
 
+// forge-lint: disable-next-line(unused-import)
 import {mulDiv} from "@prb/math/src/Common.sol";
+// forge-lint: disable-next-line(unused-import)
 import {mul as UD60x18mul, wrap as UD60x18wrap, unwrap as UD60x18unwrap} from "@prb/math/src/UD60x18.sol";
 
 // Base contract for Juicebox system tests.
@@ -294,14 +372,19 @@ contract TestBaseWorkflow is JBTest, DeployPermit2 {
         if (_nonce == 0x00) {
             data = abi.encodePacked(bytes1(0xd6), bytes1(0x94), _origin, bytes1(0x80));
         } else if (_nonce <= 0x7f) {
+            // forge-lint: disable-next-line(unsafe-typecast)
             data = abi.encodePacked(bytes1(0xd6), bytes1(0x94), _origin, uint8(_nonce));
         } else if (_nonce <= 0xff) {
+            // forge-lint: disable-next-line(unsafe-typecast)
             data = abi.encodePacked(bytes1(0xd7), bytes1(0x94), _origin, bytes1(0x81), uint8(_nonce));
         } else if (_nonce <= 0xffff) {
+            // forge-lint: disable-next-line(unsafe-typecast)
             data = abi.encodePacked(bytes1(0xd8), bytes1(0x94), _origin, bytes1(0x82), uint16(_nonce));
         } else if (_nonce <= 0xffffff) {
+            // forge-lint: disable-next-line(unsafe-typecast)
             data = abi.encodePacked(bytes1(0xd9), bytes1(0x94), _origin, bytes1(0x83), uint24(_nonce));
         } else {
+            // forge-lint: disable-next-line(unsafe-typecast)
             data = abi.encodePacked(bytes1(0xda), bytes1(0x94), _origin, bytes1(0x84), uint32(_nonce));
         }
         bytes32 hash = keccak256(data);

package/test/invariants/Phase3DeepInvariant.t.sol

@@ -1,8 +1,19 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.6;
 
-import "forge-std/StdInvariant.sol";
-import /* {*} from */ "../helpers/TestBaseWorkflow.sol";
+import {StdInvariant} from "forge-std/StdInvariant.sol";
+import {TestBaseWorkflow} from "../helpers/TestBaseWorkflow.sol";
+import {IJBRulesetApprovalHook} from "../../src/interfaces/IJBRulesetApprovalHook.sol";
+import {IJBSplitHook} from "../../src/interfaces/IJBSplitHook.sol";
+import {JBRulesetMetadataResolver} from "../../src/libraries/JBRulesetMetadataResolver.sol";
+import {JBCurrencyAmount} from "../../src/structs/JBCurrencyAmount.sol";
+import {JBFundAccessLimitGroup} from "../../src/structs/JBFundAccessLimitGroup.sol";
+import {JBRuleset} from "../../src/structs/JBRuleset.sol";
+import {JBRulesetConfig} from "../../src/structs/JBRulesetConfig.sol";
+import {JBRulesetMetadata} from "../../src/structs/JBRulesetMetadata.sol";
+import {JBSplit} from "../../src/structs/JBSplit.sol";
+import {JBSplitGroup} from "../../src/structs/JBSplitGroup.sol";
+import {JBTerminalConfig} from "../../src/structs/JBTerminalConfig.sol";
 import {Phase3Handler} from "./handlers/Phase3Handler.sol";
 import {JBAccountingContext} from "../../src/structs/JBAccountingContext.sol";
 import {JBConstants} from "../../src/libraries/JBConstants.sol";

package/test/invariants/RulesetsInvariant.t.sol

@@ -1,8 +1,18 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.6;
 
-import "forge-std/StdInvariant.sol";
-import /* {*} from */ "../helpers/TestBaseWorkflow.sol";
+import {StdInvariant} from "forge-std/StdInvariant.sol";
+import {TestBaseWorkflow} from "../helpers/TestBaseWorkflow.sol";
+import {IJBRulesetApprovalHook} from "../../src/interfaces/IJBRulesetApprovalHook.sol";
+import {JBConstants} from "../../src/libraries/JBConstants.sol";
+import {JBRulesetMetadataResolver} from "../../src/libraries/JBRulesetMetadataResolver.sol";
+import {JBAccountingContext} from "../../src/structs/JBAccountingContext.sol";
+import {JBFundAccessLimitGroup} from "../../src/structs/JBFundAccessLimitGroup.sol";
+import {JBRuleset} from "../../src/structs/JBRuleset.sol";
+import {JBRulesetConfig} from "../../src/structs/JBRulesetConfig.sol";
+import {JBRulesetMetadata} from "../../src/structs/JBRulesetMetadata.sol";
+import {JBSplitGroup} from "../../src/structs/JBSplitGroup.sol";
+import {JBTerminalConfig} from "../../src/structs/JBTerminalConfig.sol";
 import {RulesetsHandler} from "./handlers/RulesetsHandler.sol";
 
 /// @notice Invariant tests for JBRulesets cycling, weight decay, and monotonicity.

package/test/invariants/TerminalStoreInvariant.t.sol

@@ -1,8 +1,17 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.6;
 
-import "forge-std/StdInvariant.sol";
-import /* {*} from */ "../helpers/TestBaseWorkflow.sol";
+import {StdInvariant} from "forge-std/StdInvariant.sol";
+import {TestBaseWorkflow} from "../helpers/TestBaseWorkflow.sol";
+import {IJBRulesetApprovalHook} from "../../src/interfaces/IJBRulesetApprovalHook.sol";
+import {JBConstants} from "../../src/libraries/JBConstants.sol";
+import {JBRulesetMetadataResolver} from "../../src/libraries/JBRulesetMetadataResolver.sol";
+import {JBFundAccessLimitGroup} from "../../src/structs/JBFundAccessLimitGroup.sol";
+import {JBRuleset} from "../../src/structs/JBRuleset.sol";
+import {JBRulesetConfig} from "../../src/structs/JBRulesetConfig.sol";
+import {JBRulesetMetadata} from "../../src/structs/JBRulesetMetadata.sol";
+import {JBSplitGroup} from "../../src/structs/JBSplitGroup.sol";
+import {JBTerminalConfig} from "../../src/structs/JBTerminalConfig.sol";
 import {TerminalStoreHandler} from "./handlers/TerminalStoreHandler.sol";
 import {JBAccountingContext} from "../../src/structs/JBAccountingContext.sol";
 

package/test/invariants/TokensInvariant.t.sol

@@ -1,8 +1,19 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.6;
 
-import "forge-std/StdInvariant.sol";
-import /* {*} from */ "../helpers/TestBaseWorkflow.sol";
+import {StdInvariant} from "forge-std/StdInvariant.sol";
+import {TestBaseWorkflow} from "../helpers/TestBaseWorkflow.sol";
+import {IJBRulesetApprovalHook} from "../../src/interfaces/IJBRulesetApprovalHook.sol";
+import {IJBToken} from "../../src/interfaces/IJBToken.sol";
+import {JBConstants} from "../../src/libraries/JBConstants.sol";
+import {JBRulesetMetadataResolver} from "../../src/libraries/JBRulesetMetadataResolver.sol";
+import {JBAccountingContext} from "../../src/structs/JBAccountingContext.sol";
+import {JBFundAccessLimitGroup} from "../../src/structs/JBFundAccessLimitGroup.sol";
+import {JBRuleset} from "../../src/structs/JBRuleset.sol";
+import {JBRulesetConfig} from "../../src/structs/JBRulesetConfig.sol";
+import {JBRulesetMetadata} from "../../src/structs/JBRulesetMetadata.sol";
+import {JBSplitGroup} from "../../src/structs/JBSplitGroup.sol";
+import {JBTerminalConfig} from "../../src/structs/JBTerminalConfig.sol";
 import {TokensHandler} from "./handlers/TokensHandler.sol";
 
 /// @notice Invariant tests for JBTokens supply and balance consistency.

package/test/invariants/handlers/ComprehensiveHandler.sol

@@ -1,7 +1,7 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.6;
 
-import "forge-std/Test.sol";
+import {Test} from "forge-std/Test.sol";
 import {JBConstants} from "../../../src/libraries/JBConstants.sol";
 import {IJBMultiTerminal} from "../../../src/interfaces/IJBMultiTerminal.sol";
 import {IJBTerminalStore} from "../../../src/interfaces/IJBTerminalStore.sol";
@@ -20,12 +20,19 @@ contract ComprehensiveHandler is Test {
     address public projectOwner;
 
     // Ghost variables for fund tracking
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public ghost_totalPaidIn;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public ghost_totalCashedOut;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public ghost_totalPaidOut;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public ghost_totalAddedToBalance;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public ghost_totalAllowanceUsed;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public ghost_feeProjectBalanceLast;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public ghost_feeProjectBalanceDecreased; // should always be 0
 
     // Track actors
@@ -34,15 +41,25 @@ contract ComprehensiveHandler is Test {
     uint256 public constant NUM_ACTORS = 5;
 
     // Operation counters for debugging
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_pay;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_cashOut;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_sendPayouts;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_addToBalance;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_sendReservedTokens;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_useAllowance;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_burnTokens;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_claimCredits;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_advanceTime;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_processHeldFees;
 
     constructor(
@@ -62,6 +79,7 @@ contract ComprehensiveHandler is Test {
 
         // Create actor addresses
         for (uint256 i = 0; i < NUM_ACTORS; i++) {
+            // forge-lint: disable-next-line(unsafe-typecast)
             address actor = address(uint160(0x2000 + i));
             actors.push(actor);
             isActor[actor] = true;

package/test/invariants/handlers/EconomicHandler.sol

@@ -1,7 +1,7 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.6;
 
-import "forge-std/Test.sol";
+import {Test} from "forge-std/Test.sol";
 import {JBConstants} from "../../../src/libraries/JBConstants.sol";
 import {IJBMultiTerminal} from "../../../src/interfaces/IJBMultiTerminal.sol";
 import {IJBTerminalStore} from "../../../src/interfaces/IJBTerminalStore.sol";
@@ -25,25 +25,41 @@ contract EconomicHandler is Test {
     address public projectOwner;
 
     // Ghost variables for conservation tracking
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public ghost_totalPaidInA;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public ghost_totalPaidInB;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public ghost_totalPaidInC;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public ghost_totalCashedOutA;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public ghost_totalCashedOutB;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public ghost_totalCashedOutC;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public ghost_totalPaidOutA;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public ghost_totalPaidOutB;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public ghost_totalPaidOutC;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public ghost_totalAddedToBalanceA;
 
     // Fee project tracking
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public ghost_feeProjectBalance;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public ghost_feeProjectBalancePrev;
+    // forge-lint: disable-next-line(mixed-case-variable)
     bool public ghost_feeProjectBalanceDecreased;
 
     // Cross-project split tracking
+    // forge-lint: disable-next-line(mixed-case-variable)
     bool public ghost_splitCascadeOccurred;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public ghost_projectBBalanceBeforeSplit;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public ghost_projectBBalanceAfterSplit;
 
     // Track actors
@@ -52,18 +68,31 @@ contract EconomicHandler is Test {
     uint256 public constant NUM_ACTORS = 10;
 
     // Operation counters
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_payA;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_payB;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_payC;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_cashOutA;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_cashOutB;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_cashOutC;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_sendPayoutsA;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_sendPayoutsB;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_sendPayoutsC;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_addToBalanceA;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_sendReservedA;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_sendReservedC;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_advanceTime;
 
     // Per-actor tracking
@@ -90,6 +119,7 @@ contract EconomicHandler is Test {
         projectOwner = _projectOwner;
 
         for (uint256 i = 0; i < NUM_ACTORS; i++) {
+            // forge-lint: disable-next-line(unsafe-typecast)
             address actor = address(uint160(0x3000 + i));
             actors.push(actor);
             isActor[actor] = true;

package/test/invariants/handlers/Phase3Handler.sol

@@ -1,7 +1,7 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.6;
 
-import "forge-std/Test.sol";
+import {Test} from "forge-std/Test.sol";
 import {JBConstants} from "../../../src/libraries/JBConstants.sol";
 import {JBFees} from "../../../src/libraries/JBFees.sol";
 import {JBFee} from "../../../src/structs/JBFee.sol";
@@ -39,44 +39,73 @@ contract Phase3Handler is Test {
     // =========================================================================
 
     // Per-project total inflows/outflows
+    // forge-lint: disable-next-line(mixed-case-variable)
     mapping(uint256 => uint256) public ghost_totalPaidIn;
+    // forge-lint: disable-next-line(mixed-case-variable)
     mapping(uint256 => uint256) public ghost_totalCashedOut;
+    // forge-lint: disable-next-line(mixed-case-variable)
     mapping(uint256 => uint256) public ghost_totalPaidOut;
+    // forge-lint: disable-next-line(mixed-case-variable)
     mapping(uint256 => uint256) public ghost_totalAllowanceUsed;
+    // forge-lint: disable-next-line(mixed-case-variable)
     mapping(uint256 => uint256) public ghost_totalAddedToBalance;
 
     // Fee tracking (key innovation for strict invariants)
+    // forge-lint: disable-next-line(mixed-case-variable)
     mapping(uint256 => uint256) public ghost_totalFeesDeducted;
+    // forge-lint: disable-next-line(mixed-case-variable)
     mapping(uint256 => uint256) public ghost_totalFeesSentToProject1;
+    // forge-lint: disable-next-line(mixed-case-variable)
     mapping(uint256 => uint256) public ghost_totalHeldFeeAmounts;
+    // forge-lint: disable-next-line(mixed-case-variable)
     mapping(uint256 => uint256) public ghost_totalReturnedFees;
+    // forge-lint: disable-next-line(mixed-case-variable)
     mapping(uint256 => uint256) public ghost_totalProcessedFees;
 
     // Per-actor tracking
+    // forge-lint: disable-next-line(mixed-case-variable)
     mapping(address => mapping(uint256 => uint256)) public ghost_actorContributed;
+    // forge-lint: disable-next-line(mixed-case-variable)
     mapping(address => mapping(uint256 => uint256)) public ghost_actorExtracted;
 
     // Token tracking
+    // forge-lint: disable-next-line(mixed-case-variable)
     mapping(uint256 => uint256) public ghost_totalReservesSent;
 
     // Global conservation
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public ghost_globalInflows;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public ghost_globalOutflows;
 
     // Operation counters
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_pay2;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_pay3;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_cashOut2;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_cashOut3;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_sendPayouts2;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_useAllowance2;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_sendReserved2;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_processHeldFees2;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_addToBalanceReturn2;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_addToBalanceNoReturn2;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_burnTokens2;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_burnTokens3;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_claimCredits2;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_advanceTime;
 
     constructor(
@@ -99,6 +128,7 @@ contract Phase3Handler is Test {
         projectOwner = _projectOwner;
 
         for (uint256 i = 0; i < NUM_ACTORS; i++) {
+            // forge-lint: disable-next-line(unsafe-typecast)
             address actor = address(uint160(0x4000 + i));
             actors.push(actor);
         }

package/test/invariants/handlers/RulesetsHandler.sol

@@ -1,7 +1,7 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.6;
 
-import "forge-std/Test.sol";
+import {Test} from "forge-std/Test.sol";
 import {JBConstants} from "../../../src/libraries/JBConstants.sol";
 import {IJBRulesets} from "../../../src/interfaces/IJBRulesets.sol";
 import {IJBController} from "../../../src/interfaces/IJBController.sol";
@@ -25,9 +25,13 @@ contract RulesetsHandler is Test {
     address public projectOwner;
 
     // Ghost: track the last observed cycle number and weight for monotonicity checks
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint48 public ghost_lastCycleNumber;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint112 public ghost_lastWeight;
+    // forge-lint: disable-next-line(mixed-case-variable)
     bool public ghost_hasLaunched;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public ghost_queueCount;
 
     constructor(IJBRulesets _rulesets, IJBController _controller, uint256 _projectId, address _projectOwner) {