@bananapus/core-v6 0.0.15 → 0.0.16

package/ADMINISTRATION.md

@@ -108,6 +108,7 @@ Admin privileges and their scope in nana-core-v6.
 | `sendReservedTokensToSplitsOf` | Anyone | N/A | Per project | Distributes accumulated reserved tokens to the project's reserved token split group. No permission required -- anyone can trigger this. |
 | `setSplitGroupsOf` | Project owner or operator | SET_SPLIT_GROUPS (18) | Per project | Sets split groups for a project. Must preserve any currently locked splits. |
 | `setTokenFor` | Project owner or operator | SET_TOKEN (9) | Per project | Assigns an external ERC-20 token to the project. Requires the ruleset's `allowSetCustomToken` flag. Can only be called once (before any token is set). |
+| `setTokenMetadataOf` | Project owner or operator | SET_TOKEN_METADATA (21) | Per project | Sets the name and symbol of a project's ERC-20 token. The project must have a token deployed. |
 | `setUriOf` | Project owner or operator | SET_PROJECT_URI (7) | Per project | Updates the project's metadata URI. |
 | `transferCreditsFrom` | Credit holder or operator | TRANSFER_CREDITS (13) | Per project | Transfers internal token credits between addresses. Requires the ruleset's `pauseCreditTransfers` flag to be false. |
 | `migrate` | JBDirectory only | N/A (msg.sender == DIRECTORY) | Per project | Called by the directory during controller migration. Reverts if there are pending reserved tokens. |
@@ -140,6 +141,7 @@ Admin privileges and their scope in nana-core-v6.
 | `deployERC20For` | Project's controller | N/A (onlyControllerOf) | Per project | Deploys a cloned JBERC20 token for the project. |
 | `mintFor` | Project's controller | N/A (onlyControllerOf) | Per project | Mints new tokens (ERC-20 if deployed) or credits for a holder. |
 | `setTokenFor` | Project's controller | N/A (onlyControllerOf) | Per project | Sets an external ERC-20 token for the project. Cannot be changed once set. |
+| `setTokenMetadataFor` | Project's controller | N/A (onlyControllerOf) | Per project | Sets the name and symbol of a project's token. |
 | `transferCreditsFrom` | Project's controller | N/A (onlyControllerOf) | Per project | Transfers credits between addresses. |
 
 ### JBSplits
@@ -180,6 +182,7 @@ Admin privileges and their scope in nana-core-v6.
 | `mint` | Contract owner (JBTokens) | N/A (onlyOwner) | Per token | Mints new tokens to an address. |
 | `burn` | Contract owner (JBTokens) | N/A (onlyOwner) | Per token | Burns tokens from an address. |
 | `initialize` | Anyone (once) | N/A | Per token | Initializes the token name, symbol, and owner. Can only be called once. |
+| `setMetadata` | Contract owner (JBTokens) | N/A (onlyOwner) | Per token | Updates the token's name and symbol. |
 
 ### JBTerminalStore
 
@@ -228,6 +231,7 @@ JBPermissions implements a 256-bit packed permission bitmap system:
 | 18 | SET_SPLIT_GROUPS | `JBController.setSplitGroupsOf` |
 | 19 | ADD_PRICE_FEED | `JBController.addPriceFeed` |
 | 20 | ADD_ACCOUNTING_CONTEXTS | `JBMultiTerminal.addAccountingContextsFor` |
+| 21 | SET_TOKEN_METADATA | `JBController.setTokenMetadataOf` |
 
 ## Immutable Configuration
 

package/README.md

@@ -97,7 +97,7 @@ All contracts use Solidity `0.8.26`.
 | `JBProjects` | ERC-721 registry of projects. Minting an NFT creates a project. Optionally mints project #1 to a fee beneficiary owner. |
 | `JBPermissions` | Bitmap-based permission system. Accounts grant operators specific permissions scoped to project IDs. Supports ROOT (255) for all-permissions and wildcard project ID (0). |
 | `JBDirectory` | Maps each project to its controller and terminals. Entry point for looking up where to interact with a project. Manages an allowlist of addresses permitted to set a project's first controller. |
-| `JBController` | Coordinates rulesets, tokens, splits, and fund access limits. Entry point for launching projects, queuing rulesets, minting/burning tokens, deploying ERC-20s, sending reserved tokens, setting project URIs, adding price feeds, and transferring credits. |
+| `JBController` | Coordinates rulesets, tokens, splits, and fund access limits. Entry point for launching projects, queuing rulesets, minting/burning tokens, deploying ERC-20s, updating token metadata, sending reserved tokens, setting project URIs, adding price feeds, and transferring credits. |
 | `JBMultiTerminal` | Accepts payments (native ETH and ERC-20s), processes cash outs, distributes payouts, manages surplus allowances, and handles fees. Integrates with Permit2 for ERC-20 approvals. |
 | `JBTerminalStore` | Bookkeeping engine for all terminal inflows and outflows. Tracks balances, enforces payout limits and surplus allowances, computes cash out reclaim amounts via a bonding curve, and integrates with data hooks. |
 | `JBRulesets` | Stores and manages project rulesets. Handles queuing, cycling, weight decay, approval hook validation, and weight caching for long-running projects. |
@@ -110,7 +110,7 @@ All contracts use Solidity `0.8.26`.
 
 | Contract | Description |
 |----------|-------------|
-| `JBERC20` | Cloneable ERC-20 with ERC20Votes and ERC20Permit. Deployed by `JBTokens` via `Clones.clone()`. Owned by `JBTokens`. |
+| `JBERC20` | Cloneable ERC-20 with ERC20Votes and ERC20Permit. Deployed by `JBTokens` via `Clones.clone()`. Owned by `JBTokens`. Name and symbol can be updated by the project owner via `JBController.setTokenMetadataOf`. |
 | `JBChainlinkV3PriceFeed` | `IJBPriceFeed` backed by a Chainlink `AggregatorV3Interface` with staleness threshold. Rejects negative/zero prices and incomplete rounds. |
 | `JBChainlinkV3SequencerPriceFeed` | Extends `JBChainlinkV3PriceFeed` with L2 sequencer uptime validation and grace period for Optimism/Arbitrum. |
 | `JBMatchingPriceFeed` | Returns 1:1 price (e.g., ETH/NATIVE_TOKEN on applicable chains). Lives in `src/periphery/`. |

package/SKILLS.md

@@ -42,6 +42,7 @@ The core Juicebox V6 protocol on EVM: a modular system for launching treasury-ba
 | `claimTokensFor(address holder, uint256 projectId, uint256 count, address beneficiary)` | Redeems credits for ERC-20 tokens into beneficiary's wallet. |
 | `setSplitGroupsOf(uint256 projectId, uint256 rulesetId, JBSplitGroup[] splitGroups)` | Sets the split groups for a project's ruleset. |
 | `setTokenFor(uint256 projectId, IJBToken token)` | Sets an existing ERC-20 token for the project (requires `allowSetCustomToken` in ruleset). |
+| `setTokenMetadataOf(uint256 projectId, string name, string symbol)` | Sets the name and symbol of a project's ERC-20 token. Requires `SET_TOKEN_METADATA` permission. |
 | `setUriOf(uint256 projectId, string uri)` | Sets the project's metadata URI. |
 | `transferCreditsFrom(address holder, uint256 projectId, address recipient, uint256 creditCount)` | Transfers credits between addresses (reverts if `pauseCreditTransfers` is set in ruleset). |
 | `addPriceFeedFor(uint256 projectId, uint256 pricingCurrency, uint256 unitCurrency, IJBPriceFeed feed)` | Registers a price feed (requires `allowAddPriceFeed` in ruleset). |
@@ -129,6 +130,7 @@ The core Juicebox V6 protocol on EVM: a modular system for launching treasury-ba
 | `totalBalanceOf(address holder, uint256 projectId)` | Returns combined credit + ERC-20 balance. |
 | `creditBalanceOf(address holder, uint256 projectId)` | Returns the holder's credit balance. |
 | `tokenOf(uint256 projectId)` | Returns the ERC-20 token for a project (`IJBToken`). |
+| `setTokenMetadataFor(uint256 projectId, string name, string symbol)` | Sets the name and symbol of a project's token. Controller-only. |
 
 ### JBSplits
 

package/STYLE_GUIDE.md

@@ -197,7 +197,7 @@ interface IJBExample is IJBBase {
 | Public/external function | `camelCase` | `cashOutTokensOf` |
 | Internal/private function | `_camelCase` | `_processFee` |
 | Internal storage | `_camelCase` | `_accountingContextForTokenOf` |
-| Function parameter | `camelCase` | `projectId`, `cashOutCount` |
+| Function parameter | `camelCase` (no underscores) | `projectId`, `cashOutCount` |
 
 ## NatSpec
 
@@ -253,9 +253,12 @@ uint256 public constant MAX_RESERVED_PERCENT = 10_000;
 
 ## Function Calls
 
-Use named parameters for readability when calling functions with 3+ arguments:
+Use named arguments for all function calls with 2 or more arguments — in both `src/` and `script/`:
 
 ```solidity
+// Good — named arguments
+token.mint({account: beneficiary, amount: count});
+_transferOwnership({newOwner: address(0), projectId: 0});
 PERMISSIONS.hasPermission({
     operator: sender,
     account: account,
@@ -264,8 +267,18 @@ PERMISSIONS.hasPermission({
     includeRoot: true,
     includeWildcardProjectId: true
 });
+
+// Bad — positional arguments with 2+ args
+token.mint(beneficiary, count);
+_transferOwnership(address(0), 0);
 ```
 
+Single-argument calls use positional style: `_burn(amount)`.
+
+This also applies to constructor calls, struct literals, and inherited/library calls (e.g., OZ `_mint`, `_safeMint`, `safeTransfer`, `allowance`, `Clones.cloneDeterministic`).
+
+Named argument keys must use **camelCase** — never underscores. If a function's parameter names use underscores, rename them to camelCase first.
+
 ## Multiline Signatures
 
 ```solidity
@@ -553,6 +566,7 @@ CI checks formatting via `forge fmt --check`.
 
 CI runs `forge build --sizes` to catch contracts approaching the 24KB limit. When the repo's default `optimizer_runs` differs from what you want for size checking, use `FOUNDRY_PROFILE=ci_sizes forge build --sizes` with a `[profile.ci_sizes]` section in `foundry.toml`.
 
+
 ## Repo-Specific Deviations
 
 None. This repo follows the standard configuration exactly.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bananapus/core-v6",
-  "version": "0.0.15",
+  "version": "0.0.16",
   "license": "MIT",
   "repository": {
     "type": "git",
@@ -26,7 +26,7 @@
     "artifacts": "source ./.env && npx sphinx artifacts --org-id 'ea165b21-7cdc-4d7b-be59-ecdd4c26bee4' --project-name 'nana-core-v6'"
   },
   "dependencies": {
-    "@bananapus/permission-ids-v6": "^0.0.8",
+    "@bananapus/permission-ids-v6": "^0.0.9",
     "@chainlink/contracts": "^1.3.0",
     "@openzeppelin/contracts": "^5.6.1",
     "@prb/math": "^4.1.1",

package/script/Deploy.s.sol

@@ -1,7 +1,7 @@
 // SPDX-License-Identifier: MIT
 pragma solidity 0.8.26;
 
-import "@sphinx-labs/contracts/contracts/foundry/SphinxPlugin.sol";
+import {Sphinx} from "@sphinx-labs/contracts/contracts/foundry/SphinxPlugin.sol";
 import {Script} from "forge-std/Script.sol";
 
 import {IPermit2} from "@uniswap/permit2/src/interfaces/IPermit2.sol";
@@ -26,16 +26,20 @@ contract Deploy is Script, Sphinx {
 
     /// @notice The address that is allowed to forward calls to the terminal and controller on a users behalf.
     string private constant TRUSTED_FORWARDER_NAME = "Juicebox";
+    // forge-lint: disable-next-line(mixed-case-variable)
     address private TRUSTED_FORWARDER;
 
     /// @notice The address that will manage the few privileged functions of the protocol.
+    // forge-lint: disable-next-line(mixed-case-variable)
     address private MANAGER;
 
     /// @notice The address that will own the fee-project.
+    // forge-lint: disable-next-line(mixed-case-variable)
     address private FEE_PROJECT_OWNER;
 
     /// @notice The nonce that gets used across all chains to sync deployment addresses and allow for new deployments of
     /// the same bytecode.
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 private CORE_DEPLOYMENT_NONCE = 6;
 
     function configureSphinx() public override {
@@ -61,19 +65,24 @@ contract Deploy is Script, Sphinx {
 
         JBPermissions permissions =
             new JBPermissions{salt: keccak256(abi.encode(CORE_DEPLOYMENT_NONCE))}(TRUSTED_FORWARDER);
-        JBProjects projects = new JBProjects{salt: keccak256(abi.encode(CORE_DEPLOYMENT_NONCE))}(
-            safeAddress(), safeAddress(), TRUSTED_FORWARDER
-        );
-        JBDirectory directory =
-            new JBDirectory{salt: keccak256(abi.encode(CORE_DEPLOYMENT_NONCE))}(permissions, projects, safeAddress());
+        JBProjects projects = new JBProjects{salt: keccak256(abi.encode(CORE_DEPLOYMENT_NONCE))}({
+            owner: safeAddress(), feeProjectOwner: safeAddress(), trustedForwarder: TRUSTED_FORWARDER
+        });
+        JBDirectory directory = new JBDirectory{salt: keccak256(abi.encode(CORE_DEPLOYMENT_NONCE))}({
+            permissions: permissions, projects: projects, owner: safeAddress()
+        });
         JBSplits splits = new JBSplits{salt: keccak256(abi.encode(CORE_DEPLOYMENT_NONCE))}(directory);
         JBRulesets rulesets = new JBRulesets{salt: keccak256(abi.encode(CORE_DEPLOYMENT_NONCE))}(directory);
-        JBPrices prices = new JBPrices{salt: keccak256(abi.encode(CORE_DEPLOYMENT_NONCE))}(
-            directory, permissions, projects, safeAddress(), TRUSTED_FORWARDER
-        );
-        JBTokens tokens = new JBTokens{salt: keccak256(abi.encode(CORE_DEPLOYMENT_NONCE))}(
-            directory, new JBERC20{salt: keccak256(abi.encode(CORE_DEPLOYMENT_NONCE))}()
-        );
+        JBPrices prices = new JBPrices{salt: keccak256(abi.encode(CORE_DEPLOYMENT_NONCE))}({
+            directory: directory,
+            permissions: permissions,
+            projects: projects,
+            owner: safeAddress(),
+            trustedForwarder: TRUSTED_FORWARDER
+        });
+        JBTokens tokens = new JBTokens{salt: keccak256(abi.encode(CORE_DEPLOYMENT_NONCE))}({
+            directory: directory, token: new JBERC20{salt: keccak256(abi.encode(CORE_DEPLOYMENT_NONCE))}()
+        });
 
         new JBFundAccessLimits{salt: keccak256(abi.encode(CORE_DEPLOYMENT_NONCE))}(directory);
 
@@ -103,7 +112,7 @@ contract Deploy is Script, Sphinx {
 
         // Transfer ownership to the fee project owner.
         if (FEE_PROJECT_OWNER != safeAddress() && FEE_PROJECT_OWNER != address(0)) {
-            projects.safeTransferFrom(safeAddress(), FEE_PROJECT_OWNER, 1);
+            projects.safeTransferFrom({from: safeAddress(), to: FEE_PROJECT_OWNER, tokenId: 1});
         }
     }
 }

package/script/DeployPeriphery.s.sol

@@ -1,7 +1,7 @@
 // SPDX-License-Identifier: MIT
 pragma solidity 0.8.26;
 
-import "@sphinx-labs/contracts/contracts/foundry/SphinxPlugin.sol";
+import {Sphinx} from "@sphinx-labs/contracts/contracts/foundry/SphinxPlugin.sol";
 import {Script} from "forge-std/Script.sol";
 import {CoreDeployment, CoreDeploymentLib} from "./helpers/CoreDeploymentLib.sol";
 
@@ -23,13 +23,17 @@ contract DeployPeriphery is Script, Sphinx {
     /// @notice tracks the deployment of the core contracts for the chain we are deploying to.
     CoreDeployment core;
 
+    // forge-lint: disable-next-line(mixed-case-variable)
     address private TRUSTED_FORWARDER;
 
+    // forge-lint: disable-next-line(mixed-case-variable)
     bytes32 private DEADLINES_SALT = keccak256("_JBDeadlinesV6_");
+    // forge-lint: disable-next-line(mixed-case-variable)
     bytes32 private USD_NATIVE_FEED_SALT = keccak256("USD_FEEDV6");
 
     /// @notice The nonce that gets used across all chains to sync deployment addresses and allow for new deployments of
     /// the same bytecode.
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 private CORE_DEPLOYMENT_NONCE = 6;
 
     /// @notice The address of the omnichain ruleset operator contract (e.g. JBOmnichainDeployer).
@@ -39,6 +43,7 @@ contract DeployPeriphery is Script, Sphinx {
     /// @dev This address should correspond to the deterministic CREATE2 deployment of the omnichain deployer contract
     /// from the nana-omnichain-deployers-v6 repository. Verify it matches the deployed address on all target chains
     /// before running this script.
+    // forge-lint: disable-next-line(mixed-case-variable)
     address private OMNICHAIN_RULESET_OPERATOR = address(0x8f5DED85c40b50d223269C1F922A056E72101590);
 
     function configureSphinx() public override {
@@ -71,6 +76,7 @@ contract DeployPeriphery is Script, Sphinx {
         matchingPriceFeed = new JBMatchingPriceFeed();
 
         // Same as the chainlink example grace period.
+        // forge-lint: disable-next-line(mixed-case-variable)
         uint256 L2GracePeriod = 3600 seconds;
 
         // NOTE: Feeds come from this url `https://data.chain.link/feeds/ethereum/mainnet/eth-usd`.
@@ -78,13 +84,15 @@ contract DeployPeriphery is Script, Sphinx {
 
         // Perform the deploy for L1(s).
         if (block.chainid == 1) {
-            feed = new JBChainlinkV3PriceFeed{salt: USD_NATIVE_FEED_SALT}(
-                AggregatorV3Interface(address(0x5f4eC3Df9cbd43714FE2740f5E3616155c5b8419)), 3600 seconds
-            );
+            feed = new JBChainlinkV3PriceFeed{salt: USD_NATIVE_FEED_SALT}({
+                feed: AggregatorV3Interface(address(0x5f4eC3Df9cbd43714FE2740f5E3616155c5b8419)),
+                threshold: 3600 seconds
+            });
         } else if (block.chainid == 11_155_111) {
-            feed = new JBChainlinkV3PriceFeed{salt: USD_NATIVE_FEED_SALT}(
-                AggregatorV3Interface(address(0x694AA1769357215DE4FAC081bf1f309aDC325306)), 3600 seconds
-            );
+            feed = new JBChainlinkV3PriceFeed{salt: USD_NATIVE_FEED_SALT}({
+                feed: AggregatorV3Interface(address(0x694AA1769357215DE4FAC081bf1f309aDC325306)),
+                threshold: 3600 seconds
+            });
         } else {
             // Perform the deploy for L2s
             AggregatorV3Interface source;
@@ -92,47 +100,47 @@ contract DeployPeriphery is Script, Sphinx {
             // Optimism
             if (block.chainid == 10) {
                 source = AggregatorV3Interface(0x13e3Ee699D1909E989722E753853AE30b17e08c5);
-                feed = new JBChainlinkV3SequencerPriceFeed{salt: USD_NATIVE_FEED_SALT}(
-                    source,
-                    3600 seconds,
-                    AggregatorV2V3Interface(0x371EAD81c9102C9BF4874A9075FFFf170F2Ee389),
-                    L2GracePeriod
-                );
+                feed = new JBChainlinkV3SequencerPriceFeed{salt: USD_NATIVE_FEED_SALT}({
+                    feed: source,
+                    threshold: 3600 seconds,
+                    sequencerFeed: AggregatorV2V3Interface(0x371EAD81c9102C9BF4874A9075FFFf170F2Ee389),
+                    gracePeriod: L2GracePeriod
+                });
             }
             // Optimism Sepolia
             else if (block.chainid == 11_155_420) {
                 source = AggregatorV3Interface(address(0x61Ec26aA57019C486B10502285c5A3D4A4750AD7));
-                feed = new JBChainlinkV3PriceFeed{salt: USD_NATIVE_FEED_SALT}(source, 3600 seconds);
+                feed = new JBChainlinkV3PriceFeed{salt: USD_NATIVE_FEED_SALT}({feed: source, threshold: 3600 seconds});
             }
             // Base
             else if (block.chainid == 8453) {
                 source = AggregatorV3Interface(0x71041dddad3595F9CEd3DcCFBe3D1F4b0a16Bb70);
-                feed = new JBChainlinkV3SequencerPriceFeed{salt: USD_NATIVE_FEED_SALT}(
-                    source,
-                    3600 seconds,
-                    AggregatorV2V3Interface(0xBCF85224fc0756B9Fa45aA7892530B47e10b6433),
-                    L2GracePeriod
-                );
+                feed = new JBChainlinkV3SequencerPriceFeed{salt: USD_NATIVE_FEED_SALT}({
+                    feed: source,
+                    threshold: 3600 seconds,
+                    sequencerFeed: AggregatorV2V3Interface(0xBCF85224fc0756B9Fa45aA7892530B47e10b6433),
+                    gracePeriod: L2GracePeriod
+                });
             }
             // Base Sepolia
             else if (block.chainid == 84_532) {
                 source = AggregatorV3Interface(address(0x4aDC67696bA383F43DD60A9e78F2C97Fbbfc7cb1));
-                feed = new JBChainlinkV3PriceFeed{salt: USD_NATIVE_FEED_SALT}(source, 3600 seconds);
+                feed = new JBChainlinkV3PriceFeed{salt: USD_NATIVE_FEED_SALT}({feed: source, threshold: 3600 seconds});
             }
             // Arbitrum
             else if (block.chainid == 42_161) {
                 source = AggregatorV3Interface(0x639Fe6ab55C921f74e7fac1ee960C0B6293ba612);
-                feed = new JBChainlinkV3SequencerPriceFeed{salt: USD_NATIVE_FEED_SALT}(
-                    source,
-                    3600 seconds,
-                    AggregatorV2V3Interface(0xFdB631F5EE196F0ed6FAa767959853A9F217697D),
-                    L2GracePeriod
-                );
+                feed = new JBChainlinkV3SequencerPriceFeed{salt: USD_NATIVE_FEED_SALT}({
+                    feed: source,
+                    threshold: 3600 seconds,
+                    sequencerFeed: AggregatorV2V3Interface(0xFdB631F5EE196F0ed6FAa767959853A9F217697D),
+                    gracePeriod: L2GracePeriod
+                });
             }
             // Arbitrum Sepolia
             else if (block.chainid == 421_614) {
                 source = AggregatorV3Interface(address(0xd30e2101a97dcbAeBCBC04F14C3f624E67A35165));
-                feed = new JBChainlinkV3PriceFeed{salt: USD_NATIVE_FEED_SALT}(source, 3600 seconds);
+                feed = new JBChainlinkV3PriceFeed{salt: USD_NATIVE_FEED_SALT}({feed: source, threshold: 3600 seconds});
             } else {
                 revert("Unsupported chain");
             }
@@ -169,25 +177,25 @@ contract DeployPeriphery is Script, Sphinx {
         _deployUSDCFeed(L2GracePeriod);
 
         // Deploy the JBDeadlines
-        if (!_isDeployed(DEADLINES_SALT, type(JBDeadline3Hours).creationCode, "")) {
+        if (!_isDeployed({salt: DEADLINES_SALT, creationCode: type(JBDeadline3Hours).creationCode, arguments: ""})) {
             new JBDeadline3Hours{salt: DEADLINES_SALT}();
         }
 
-        if (!_isDeployed(DEADLINES_SALT, type(JBDeadline1Day).creationCode, "")) {
+        if (!_isDeployed({salt: DEADLINES_SALT, creationCode: type(JBDeadline1Day).creationCode, arguments: ""})) {
             new JBDeadline1Day{salt: DEADLINES_SALT}();
         }
 
-        if (!_isDeployed(DEADLINES_SALT, type(JBDeadline3Days).creationCode, "")) {
+        if (!_isDeployed({salt: DEADLINES_SALT, creationCode: type(JBDeadline3Days).creationCode, arguments: ""})) {
             new JBDeadline3Days{salt: DEADLINES_SALT}();
         }
 
-        if (!_isDeployed(DEADLINES_SALT, type(JBDeadline7Days).creationCode, "")) {
+        if (!_isDeployed({salt: DEADLINES_SALT, creationCode: type(JBDeadline7Days).creationCode, arguments: ""})) {
             new JBDeadline7Days{salt: DEADLINES_SALT}();
         }
 
         core.directory
-            .setIsAllowedToSetFirstController(
-                address(
+            .setIsAllowedToSetFirstController({
+                addr: address(
                     new JBController{salt: keccak256(abi.encode(CORE_DEPLOYMENT_NONCE))}({
                         directory: core.directory,
                         fundAccessLimits: core.fundAccess,
@@ -201,24 +209,27 @@ contract DeployPeriphery is Script, Sphinx {
                         trustedForwarder: TRUSTED_FORWARDER
                     })
                 ),
-                true
-            );
+                flag: true
+            });
     }
 
+    // forge-lint: disable-next-line(mixed-case-function, mixed-case-variable)
     function _deployUSDCFeed(uint256 L2GracePeriod) internal {
         IJBPriceFeed usdcFeed;
         address usdc;
 
         if (block.chainid == 1) {
             usdc = address(0xA0b86991c6218b36c1d19D4a2e9Eb0cE3606eB48);
-            usdcFeed = new JBChainlinkV3PriceFeed(
-                AggregatorV3Interface(address(0x8fFfFfd4AfB6115b954Bd326cbe7B4BA576818f6)), 86_400 seconds
-            );
+            usdcFeed = new JBChainlinkV3PriceFeed({
+                feed: AggregatorV3Interface(address(0x8fFfFfd4AfB6115b954Bd326cbe7B4BA576818f6)),
+                threshold: 86_400 seconds
+            });
         } else if (block.chainid == 11_155_111) {
             usdc = address(0x1c7D4B196Cb0C7B01d743Fbc6116a902379C7238);
-            usdcFeed = new JBChainlinkV3PriceFeed(
-                AggregatorV3Interface(address(0xA2F78ab2355fe2f984D808B5CeE7FD0A93D5270E)), 86_400 seconds
-            );
+            usdcFeed = new JBChainlinkV3PriceFeed({
+                feed: AggregatorV3Interface(address(0xA2F78ab2355fe2f984D808B5CeE7FD0A93D5270E)),
+                threshold: 86_400 seconds
+            });
         } else if (block.chainid == 10) {
             usdc = address(0x0b2C639c533813f4Aa9D7837CAf62653d097Ff85);
             usdcFeed = new JBChainlinkV3SequencerPriceFeed({
@@ -229,9 +240,10 @@ contract DeployPeriphery is Script, Sphinx {
             });
         } else if (block.chainid == 11_155_420) {
             usdc = address(0x5fd84259d66Cd46123540766Be93DFE6D43130D7);
-            usdcFeed = new JBChainlinkV3PriceFeed(
-                AggregatorV3Interface(address(0x6e44e50E3cc14DD16e01C590DC1d7020cb36eD4C)), 86_400 seconds
-            );
+            usdcFeed = new JBChainlinkV3PriceFeed({
+                feed: AggregatorV3Interface(address(0x6e44e50E3cc14DD16e01C590DC1d7020cb36eD4C)),
+                threshold: 86_400 seconds
+            });
         } else if (block.chainid == 8453) {
             usdc = address(0x833589fCD6eDb6E08f4c7C32D4f71b54bdA02913);
             usdcFeed = new JBChainlinkV3SequencerPriceFeed({
@@ -242,9 +254,10 @@ contract DeployPeriphery is Script, Sphinx {
             });
         } else if (block.chainid == 84_532) {
             usdc = address(0x036CbD53842c5426634e7929541eC2318f3dCF7e);
-            usdcFeed = new JBChainlinkV3PriceFeed(
-                AggregatorV3Interface(address(0xd30e2101a97dcbAeBCBC04F14C3f624E67A35165)), 86_400 seconds
-            );
+            usdcFeed = new JBChainlinkV3PriceFeed({
+                feed: AggregatorV3Interface(address(0xd30e2101a97dcbAeBCBC04F14C3f624E67A35165)),
+                threshold: 86_400 seconds
+            });
         } else if (block.chainid == 42_161) {
             usdc = address(0xaf88d065e77c8cC2239327C5EDb3A432268e5831);
             usdcFeed = new JBChainlinkV3SequencerPriceFeed({
@@ -255,9 +268,10 @@ contract DeployPeriphery is Script, Sphinx {
             });
         } else if (block.chainid == 421_614) {
             usdc = address(0x75faf114eafb1BDbe2F0316DF893fd58CE46AA4d);
-            usdcFeed = new JBChainlinkV3PriceFeed(
-                AggregatorV3Interface(address(0x0153002d20B96532C639313c2d54c3dA09109309)), 86_400 seconds
-            );
+            usdcFeed = new JBChainlinkV3PriceFeed({
+                feed: AggregatorV3Interface(address(0x0153002d20B96532C639313c2d54c3dA09109309)),
+                threshold: 86_400 seconds
+            });
         } else {
             revert("Unsupported chain for USDC feed");
         }
@@ -267,7 +281,11 @@ contract DeployPeriphery is Script, Sphinx {
 
         core.prices
             .addPriceFeedFor({
-                projectId: 0, pricingCurrency: JBCurrencyIds.USD, unitCurrency: uint32(uint160(usdc)), feed: usdcFeed
+                // forge-lint: disable-next-line(unsafe-typecast)
+                projectId: 0,
+                pricingCurrency: JBCurrencyIds.USD,
+                unitCurrency: uint32(uint160(usdc)),
+                feed: usdcFeed
             });
     }
 

package/script/helpers/CoreDeploymentLib.sol

@@ -38,6 +38,7 @@ struct CoreDeployment {
 library CoreDeploymentLib {
     // Cheat code address, 0x7109709ECfa91a80626fF3989D68f67F5b1DD12D.
     address internal constant VM_ADDRESS = address(uint160(uint256(keccak256("hevm cheat code"))));
+    // forge-lint: disable-next-line(screaming-snake-case-const)
     Vm internal constant vm = Vm(VM_ADDRESS);
     string constant PROJECT_NAME = "nana-core-v5";
 
@@ -52,7 +53,7 @@ library CoreDeploymentLib {
 
         for (uint256 _i; _i < networks.length; _i++) {
             if (networks[_i].chainId == chainId) {
-                return getDeployment(path, networks[_i].name);
+                return getDeployment({path: path, networkName: networks[_i].name});
             }
         }
 
@@ -61,41 +62,87 @@ library CoreDeploymentLib {
 
     function getDeployment(
         string memory path,
-        string memory network_name
+        string memory networkName
     )
         internal
         view
         returns (CoreDeployment memory deployment)
     {
-        deployment.permissions = JBPermissions(_getDeploymentAddress(path, PROJECT_NAME, network_name, "JBPermissions"));
-
-        deployment.projects = JBProjects(_getDeploymentAddress(path, PROJECT_NAME, network_name, "JBProjects"));
-
-        deployment.directory = JBDirectory(_getDeploymentAddress(path, PROJECT_NAME, network_name, "JBDirectory"));
-
-        deployment.splits = JBSplits(_getDeploymentAddress(path, PROJECT_NAME, network_name, "JBSplits"));
-
-        deployment.rulesets = JBRulesets(_getDeploymentAddress(path, PROJECT_NAME, network_name, "JBRulesets"));
-
-        deployment.controller = JBController(_getDeploymentAddress(path, PROJECT_NAME, network_name, "JBController"));
-
-        deployment.terminal =
-            JBMultiTerminal(_getDeploymentAddress(path, PROJECT_NAME, network_name, "JBMultiTerminal"));
-
-        deployment.terminalStore =
-            JBTerminalStore(_getDeploymentAddress(path, PROJECT_NAME, network_name, "JBTerminalStore"));
-
-        deployment.prices = JBPrices(_getDeploymentAddress(path, PROJECT_NAME, network_name, "JBPrices"));
-
-        deployment.feeless =
-            JBFeelessAddresses(_getDeploymentAddress(path, PROJECT_NAME, network_name, "JBFeelessAddresses"));
-
-        deployment.fundAccess =
-            JBFundAccessLimits(_getDeploymentAddress(path, PROJECT_NAME, network_name, "JBFundAccessLimits"));
-
-        deployment.tokens = JBTokens(_getDeploymentAddress(path, PROJECT_NAME, network_name, "JBTokens"));
-
-        deployment.trustedForwarder = _getDeploymentAddress(path, PROJECT_NAME, network_name, "ERC2771Forwarder");
+        deployment.permissions = JBPermissions(
+            _getDeploymentAddress({
+                path: path, projectName: PROJECT_NAME, networkName: networkName, contractName: "JBPermissions"
+            })
+        );
+
+        deployment.projects = JBProjects(
+            _getDeploymentAddress({
+                path: path, projectName: PROJECT_NAME, networkName: networkName, contractName: "JBProjects"
+            })
+        );
+
+        deployment.directory = JBDirectory(
+            _getDeploymentAddress({
+                path: path, projectName: PROJECT_NAME, networkName: networkName, contractName: "JBDirectory"
+            })
+        );
+
+        deployment.splits = JBSplits(
+            _getDeploymentAddress({
+                path: path, projectName: PROJECT_NAME, networkName: networkName, contractName: "JBSplits"
+            })
+        );
+
+        deployment.rulesets = JBRulesets(
+            _getDeploymentAddress({
+                path: path, projectName: PROJECT_NAME, networkName: networkName, contractName: "JBRulesets"
+            })
+        );
+
+        deployment.controller = JBController(
+            _getDeploymentAddress({
+                path: path, projectName: PROJECT_NAME, networkName: networkName, contractName: "JBController"
+            })
+        );
+
+        deployment.terminal = JBMultiTerminal(
+            _getDeploymentAddress({
+                path: path, projectName: PROJECT_NAME, networkName: networkName, contractName: "JBMultiTerminal"
+            })
+        );
+
+        deployment.terminalStore = JBTerminalStore(
+            _getDeploymentAddress({
+                path: path, projectName: PROJECT_NAME, networkName: networkName, contractName: "JBTerminalStore"
+            })
+        );
+
+        deployment.prices = JBPrices(
+            _getDeploymentAddress({
+                path: path, projectName: PROJECT_NAME, networkName: networkName, contractName: "JBPrices"
+            })
+        );
+
+        deployment.feeless = JBFeelessAddresses(
+            _getDeploymentAddress({
+                path: path, projectName: PROJECT_NAME, networkName: networkName, contractName: "JBFeelessAddresses"
+            })
+        );
+
+        deployment.fundAccess = JBFundAccessLimits(
+            _getDeploymentAddress({
+                path: path, projectName: PROJECT_NAME, networkName: networkName, contractName: "JBFundAccessLimits"
+            })
+        );
+
+        deployment.tokens = JBTokens(
+            _getDeploymentAddress({
+                path: path, projectName: PROJECT_NAME, networkName: networkName, contractName: "JBTokens"
+            })
+        );
+
+        deployment.trustedForwarder = _getDeploymentAddress({
+            path: path, projectName: PROJECT_NAME, networkName: networkName, contractName: "ERC2771Forwarder"
+        });
     }
 
     /// @notice Get the address of a contract that was deployed by the Deploy script.
@@ -105,8 +152,8 @@ library CoreDeploymentLib {
     /// @return The address of the contract.
     function _getDeploymentAddress(
         string memory path,
-        string memory project_name,
-        string memory network_name,
+        string memory projectName,
+        string memory networkName,
         string memory contractName
     )
         internal
@@ -114,7 +161,8 @@ library CoreDeploymentLib {
         returns (address)
     {
         string memory deploymentJson =
-            vm.readFile(string.concat(path, project_name, "/", network_name, "/", contractName, ".json"));
-        return stdJson.readAddress(deploymentJson, ".address");
+        // forge-lint: disable-next-line(unsafe-cheatcode)
+        vm.readFile(string.concat(path, projectName, "/", networkName, "/", contractName, ".json"));
+        return stdJson.readAddress({json: deploymentJson, key: ".address"});
     }
 }

package/src/JBChainlinkV3PriceFeed.sol

@@ -68,6 +68,7 @@ contract JBChainlinkV3PriceFeed is IJBPriceFeed {
         uint256 feedDecimals = FEED.decimals();
 
         // Return the price, adjusted to the specified number of decimals.
+        // forge-lint: disable-next-line(unsafe-typecast)
         return uint256(price).adjustDecimals({decimals: feedDecimals, targetDecimals: decimals});
     }
 }